[INFO] cloning repository https://github.com/hangy/openfoodfacts-packager-codes-imsoc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hangy/openfoodfacts-packager-codes-imsoc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhangy%2Fopenfoodfacts-packager-codes-imsoc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhangy%2Fopenfoodfacts-packager-codes-imsoc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 73e231612d51e41c0c94074b8ea8804616ac6f3a [INFO] linting hangy/openfoodfacts-packager-codes-imsoc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhangy%2Fopenfoodfacts-packager-codes-imsoc" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hangy/openfoodfacts-packager-codes-imsoc [INFO] finished tweaking git repo https://github.com/hangy/openfoodfacts-packager-codes-imsoc [INFO] tweaked toml for git repo https://github.com/hangy/openfoodfacts-packager-codes-imsoc written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hangy/openfoodfacts-packager-codes-imsoc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hangy/openfoodfacts-packager-codes-imsoc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded geocoding v0.4.0 [INFO] [stderr] Downloaded geo-types v0.7.11 [INFO] [stderr] Downloaded openssl-sys v0.9.96 [INFO] [stderr] Downloaded openssl v0.10.60 [INFO] [stderr] Downloaded h2 v0.4.3 [INFO] [stderr] Downloaded reqwest v0.12.4 [INFO] [stderr] Downloaded rustix v0.38.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f268551071d0907e4d70df4917a2ff1bf9f2cc6f10327bd6db3c03f9408cd87d [INFO] running `Command { std: "docker" "start" "-a" "f268551071d0907e4d70df4917a2ff1bf9f2cc6f10327bd6db3c03f9408cd87d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f268551071d0907e4d70df4917a2ff1bf9f2cc6f10327bd6db3c03f9408cd87d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f268551071d0907e4d70df4917a2ff1bf9f2cc6f10327bd6db3c03f9408cd87d", kill_on_drop: false }` [INFO] [stdout] f268551071d0907e4d70df4917a2ff1bf9f2cc6f10327bd6db3c03f9408cd87d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0bbf0dd34a398e6ac75fa38efb7a6da7b35688beda9ab5b360c0a477285f8f99 [INFO] running `Command { std: "docker" "start" "-a" "0bbf0dd34a398e6ac75fa38efb7a6da7b35688beda9ab5b360c0a477285f8f99", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling openssl v0.10.60 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking geo-types v0.7.11 [INFO] [stderr] Compiling openssl-sys v0.9.96 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking serde v1.0.198 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.3 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking geocoding v0.4.0 [INFO] [stderr] Checking off-imsoc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `operator_id` is never read [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | struct Establishment { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 30 | operator_id: i32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Establishment` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `city_id` and `name` are never read [INFO] [stdout] --> src/main.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 51 | struct City { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 52 | city_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 53 | postal_code: Option, [INFO] [stdout] 54 | name: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `City` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/main.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | struct ClassificationSectionId { [INFO] [stdout] | ----------------------- field in this struct [INFO] [stdout] 74 | id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ClassificationSectionId` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sequence_number` is never read [INFO] [stdout] --> src/main.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 80 | struct CountryCategory { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 81 | sequence_number: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CountryCategory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `operator_id` is never read [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | struct Establishment { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 30 | operator_id: i32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Establishment` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `city_id` and `name` are never read [INFO] [stdout] --> src/main.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 51 | struct City { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 52 | city_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 53 | postal_code: Option, [INFO] [stdout] 54 | name: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `City` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/main.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | struct ClassificationSectionId { [INFO] [stdout] | ----------------------- field in this struct [INFO] [stdout] 74 | id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ClassificationSectionId` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sequence_number` is never read [INFO] [stdout] --> src/main.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 80 | struct CountryCategory { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 81 | sequence_number: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CountryCategory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(establishments); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(establishments); [INFO] [stdout] 108 + Ok(establishments) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | return Ok(resp); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return Ok(resp); [INFO] [stdout] 131 + Ok(resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Ok(()); [INFO] [stdout] 144 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if !e.address.city_reference.postal_code.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `e.address.city_reference.postal_code.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | return Ok(packager_codes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return Ok(packager_codes); [INFO] [stdout] 203 + Ok(packager_codes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:152:32 [INFO] [stdout] | [INFO] [stdout] 152 | for (_, establishments) in &establishments_by_country { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 152 - for (_, establishments) in &establishments_by_country { [INFO] [stdout] 152 + for establishments in establishments_by_country.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | return r; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return r; [INFO] [stdout] 181 + r [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 224 | return Ok(grouped_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return Ok(grouped_map); [INFO] [stdout] 224 + Ok(grouped_map) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:220:36 [INFO] [stdout] | [INFO] [stdout] 220 | grouped_map.entry(key).or_insert_with(Vec::new).push(item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | return Ok(filtered); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return Ok(filtered); [INFO] [stdout] 238 + Ok(filtered) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | return std::future::ready(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return std::future::ready(result); [INFO] [stdout] 234 + std::future::ready(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | return Ok(country_categories); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - return Ok(country_categories); [INFO] [stdout] 257 + Ok(country_categories) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | return Ok(resp); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return Ok(resp); [INFO] [stdout] 270 + Ok(resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(establishments); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(establishments); [INFO] [stdout] 108 + Ok(establishments) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | return Ok(resp); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return Ok(resp); [INFO] [stdout] 131 + Ok(resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Ok(()); [INFO] [stdout] 144 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if !e.address.city_reference.postal_code.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `e.address.city_reference.postal_code.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | return Ok(packager_codes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return Ok(packager_codes); [INFO] [stdout] 203 + Ok(packager_codes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:152:32 [INFO] [stdout] | [INFO] [stdout] 152 | for (_, establishments) in &establishments_by_country { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 152 - for (_, establishments) in &establishments_by_country { [INFO] [stdout] 152 + for establishments in establishments_by_country.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | return r; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return r; [INFO] [stdout] 181 + r [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 224 | return Ok(grouped_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return Ok(grouped_map); [INFO] [stdout] 224 + Ok(grouped_map) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:220:36 [INFO] [stdout] | [INFO] [stdout] 220 | grouped_map.entry(key).or_insert_with(Vec::new).push(item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | return Ok(filtered); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return Ok(filtered); [INFO] [stdout] 238 + Ok(filtered) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | return std::future::ready(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return std::future::ready(result); [INFO] [stdout] 234 + std::future::ready(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | return Ok(country_categories); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - return Ok(country_categories); [INFO] [stdout] 257 + Ok(country_categories) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | return Ok(resp); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return Ok(resp); [INFO] [stdout] 270 + Ok(resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.45s [INFO] running `Command { std: "docker" "inspect" "0bbf0dd34a398e6ac75fa38efb7a6da7b35688beda9ab5b360c0a477285f8f99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bbf0dd34a398e6ac75fa38efb7a6da7b35688beda9ab5b360c0a477285f8f99", kill_on_drop: false }` [INFO] [stdout] 0bbf0dd34a398e6ac75fa38efb7a6da7b35688beda9ab5b360c0a477285f8f99