[INFO] cloning repository https://github.com/hamzaelmarjani/rust-actixweb-boilerplate [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hamzaelmarjani/rust-actixweb-boilerplate" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhamzaelmarjani%2Frust-actixweb-boilerplate", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhamzaelmarjani%2Frust-actixweb-boilerplate'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e7a9960074b24525fd25a2b9abadf149d0259cb4 [INFO] linting hamzaelmarjani/rust-actixweb-boilerplate against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhamzaelmarjani%2Frust-actixweb-boilerplate" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-7-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/hamzaelmarjani/rust-actixweb-boilerplate [INFO] finished tweaking git repo https://github.com/hamzaelmarjani/rust-actixweb-boilerplate [INFO] tweaked toml for git repo https://github.com/hamzaelmarjani/rust-actixweb-boilerplate written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hamzaelmarjani/rust-actixweb-boilerplate on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hamzaelmarjani/rust-actixweb-boilerplate already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uniqer_rs v0.0.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62946da8245b7232dbf3b2c828f7727f198b5a16f1734f8dee059d9341ba25ca [INFO] running `Command { std: "docker" "start" "-a" "62946da8245b7232dbf3b2c828f7727f198b5a16f1734f8dee059d9341ba25ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62946da8245b7232dbf3b2c828f7727f198b5a16f1734f8dee059d9341ba25ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62946da8245b7232dbf3b2c828f7727f198b5a16f1734f8dee059d9341ba25ca", kill_on_drop: false }` [INFO] [stdout] 62946da8245b7232dbf3b2c828f7727f198b5a16f1734f8dee059d9341ba25ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f5d7ebdf9720dba1d89617877bdf766f31754bc9609a13b9244bae0a6ccba51 [INFO] running `Command { std: "docker" "start" "-a" "7f5d7ebdf9720dba1d89617877bdf766f31754bc9609a13b9244bae0a6ccba51", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling cc v1.2.45 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling bytestring v1.5.0 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling regex-lite v0.1.8 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Compiling askama_parser v0.14.0 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking atomic v0.6.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking uniqer_rs v0.0.4 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking jsonwebtoken v10.2.0 [INFO] [stderr] Compiling askama_derive v0.14.0 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking askama v0.14.0 [INFO] [stderr] Checking actix-http v3.11.2 [INFO] [stderr] Checking actix-web v4.11.0 [INFO] [stderr] Checking actix-cors v0.7.1 [INFO] [stderr] Checking rust-actixweb-boilerplate v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `TokensPayload` [INFO] [stdout] --> src/middleware/guard.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | jwt::{JwtManager, TokensPayload}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/main.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 98 | .bind(("0.0.0.0:8080"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove them: `"0.0.0.0:8080"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/main.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 98 | .bind(("0.0.0.0:8080"))? [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - .bind(("0.0.0.0:8080"))? [INFO] [stdout] 98 + .bind("0.0.0.0:8080" )? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TokensPayload` [INFO] [stdout] --> src/middleware/guard.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | jwt::{JwtManager, TokensPayload}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/main.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 98 | .bind(("0.0.0.0:8080"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove them: `"0.0.0.0:8080"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/main.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 98 | .bind(("0.0.0.0:8080"))? [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - .bind(("0.0.0.0:8080"))? [INFO] [stdout] 98 + .bind("0.0.0.0:8080" )? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/constants/responder.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | let builder: HttpResponseBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `builder` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 | [INFO] [stdout] 39 ~ let builder: HttpResponseBuilder = match status_code { [INFO] [stdout] 40 | // 2xx Success [INFO] [stdout] 41 ~ 201 => HttpResponse::Created(), [INFO] [stdout] 42 ~ 202 => HttpResponse::Accepted(), [INFO] [stdout] 43 ~ 204 => HttpResponse::NoContent(), [INFO] [stdout] 44 | [INFO] [stdout] 45 | // 3xx Redirection [INFO] [stdout] 46 ~ 301 => HttpResponse::MovedPermanently(), [INFO] [stdout] 47 ~ 302 => HttpResponse::Found(), [INFO] [stdout] 48 ~ 304 => HttpResponse::NotModified(), [INFO] [stdout] 49 ~ 307 => HttpResponse::TemporaryRedirect(), [INFO] [stdout] 50 ~ 308 => HttpResponse::PermanentRedirect(), [INFO] [stdout] 51 | [INFO] [stdout] 52 | // 4xx Client Errors [INFO] [stdout] 53 ~ 400 => HttpResponse::BadRequest(), [INFO] [stdout] 54 ~ 401 => HttpResponse::Unauthorized(), [INFO] [stdout] 55 ~ 402 => HttpResponse::PaymentRequired(), [INFO] [stdout] 56 ~ 403 => HttpResponse::Forbidden(), [INFO] [stdout] 57 ~ 404 => HttpResponse::NotFound(), [INFO] [stdout] 58 ~ 405 => HttpResponse::MethodNotAllowed(), [INFO] [stdout] 59 ~ 406 => HttpResponse::NotAcceptable(), [INFO] [stdout] 60 ~ 408 => HttpResponse::RequestTimeout(), [INFO] [stdout] 61 ~ 413 => HttpResponse::PayloadTooLarge(), [INFO] [stdout] 62 ~ 429 => HttpResponse::TooManyRequests(), [INFO] [stdout] 63 | [INFO] [stdout] 64 | // 5xx Server Errors [INFO] [stdout] 65 ~ 500 => HttpResponse::InternalServerError(), [INFO] [stdout] 66 ~ 502 => HttpResponse::BadGateway(), [INFO] [stdout] 67 ~ 503 => HttpResponse::ServiceUnavailable(), [INFO] [stdout] 68 | [INFO] [stdout] 69 | // Default to 200 Success [INFO] [stdout] 70 ~ _ => HttpResponse::Ok(), [INFO] [stdout] 71 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/controllers/crud/create.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | if let Some(_) = data_from_db.iter_mut().find(|m| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ if data_from_db.iter_mut().find(|m| { [INFO] [stdout] 38 + m.values() [INFO] [stdout] 39 + .any(|v| v.as_str() == Some(&body.arg.iter().next().unwrap().1).unwrap().as_str()) [INFO] [stdout] 40 ~ }).is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> src/controllers/crud/create.rs:39:36 [INFO] [stdout] | [INFO] [stdout] 39 | .any(|v| v.as_str() == Some(&body.arg.iter().next().unwrap().1).unwrap().as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] | [INFO] [stdout] 39 - .any(|v| v.as_str() == Some(&body.arg.iter().next().unwrap().1).unwrap().as_str()) [INFO] [stdout] 39 + .any(|v| v.as_str() == &body.arg.iter().next().unwrap().1.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `refreshed_token` after checking its variant with `is_none` [INFO] [stdout] --> src/controllers/user/tokanize_user.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 20 | let refresh_token = if refreshed_token.is_none() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = refreshed_token` [INFO] [stdout] ... [INFO] [stdout] 26 | refreshed_token.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controllers/user/email_verification.rs:48:65 [INFO] [stdout] | [INFO] [stdout] 48 | if email.is_none() || username.is_none() || !is_valid_email(&email.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `email.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controllers/user/email_verification.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 59 | success_to_verify_email(&email.unwrap(), &name) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `email.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/controllers/user/combinator.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | id: String::from(id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jwt/manager.rs:57:37 [INFO] [stdout] | [INFO] [stdout] 57 | let cipher = Aes256Gcm::new(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jwt/manager.rs:132:39 [INFO] [stdout] | [INFO] [stdout] 132 | let decoded = self.decode_jwt(&token)?; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/middleware/guard.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Some(auth_header) = req.headers().get("Authorization") { [INFO] [stdout] 122 | | if let Ok(auth_str) = auth_header.to_str() { [INFO] [stdout] 123 | | if let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | | return Some(token); [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 121 ~ if let Some(auth_header) = req.headers().get("Authorization") [INFO] [stdout] 122 ~ && let Ok(auth_str) = auth_header.to_str() { [INFO] [stdout] 123 | if let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | return Some(token); [INFO] [stdout] 125 | } [INFO] [stdout] 126 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/middleware/guard.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / if let Ok(auth_str) = auth_header.to_str() { [INFO] [stdout] 123 | | if let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | | return Some(token); [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ if let Ok(auth_str) = auth_header.to_str() [INFO] [stdout] 123 ~ && let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | return Some(token); [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `structs::user::User` [INFO] [stdout] --> src/structs/user.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn to_string(&self) -> String { [INFO] [stdout] 16 | | serde_json::to_string(self).unwrap() [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `structs::user::User` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/sign_in.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | access_token: Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] | ___________________________^ [INFO] [stdout] 30 | | .unwrap_or(Some("")) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 29 - access_token: Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 30 - .unwrap_or(Some("")) [INFO] [stdout] 29 + access_token: body["data3"]["access_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/sign_in.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | refresh_token: Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 34 | | .unwrap_or(Some("")) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 33 - refresh_token: Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 34 - .unwrap_or(Some("")) [INFO] [stdout] 33 + refresh_token: body["data3"]["refresh_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/constants/responder.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | let builder: HttpResponseBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `builder` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 | [INFO] [stdout] 39 ~ let builder: HttpResponseBuilder = match status_code { [INFO] [stdout] 40 | // 2xx Success [INFO] [stdout] 41 ~ 201 => HttpResponse::Created(), [INFO] [stdout] 42 ~ 202 => HttpResponse::Accepted(), [INFO] [stdout] 43 ~ 204 => HttpResponse::NoContent(), [INFO] [stdout] 44 | [INFO] [stdout] 45 | // 3xx Redirection [INFO] [stdout] 46 ~ 301 => HttpResponse::MovedPermanently(), [INFO] [stdout] 47 ~ 302 => HttpResponse::Found(), [INFO] [stdout] 48 ~ 304 => HttpResponse::NotModified(), [INFO] [stdout] 49 ~ 307 => HttpResponse::TemporaryRedirect(), [INFO] [stdout] 50 ~ 308 => HttpResponse::PermanentRedirect(), [INFO] [stdout] 51 | [INFO] [stdout] 52 | // 4xx Client Errors [INFO] [stdout] 53 ~ 400 => HttpResponse::BadRequest(), [INFO] [stdout] 54 ~ 401 => HttpResponse::Unauthorized(), [INFO] [stdout] 55 ~ 402 => HttpResponse::PaymentRequired(), [INFO] [stdout] 56 ~ 403 => HttpResponse::Forbidden(), [INFO] [stdout] 57 ~ 404 => HttpResponse::NotFound(), [INFO] [stdout] 58 ~ 405 => HttpResponse::MethodNotAllowed(), [INFO] [stdout] 59 ~ 406 => HttpResponse::NotAcceptable(), [INFO] [stdout] 60 ~ 408 => HttpResponse::RequestTimeout(), [INFO] [stdout] 61 ~ 413 => HttpResponse::PayloadTooLarge(), [INFO] [stdout] 62 ~ 429 => HttpResponse::TooManyRequests(), [INFO] [stdout] 63 | [INFO] [stdout] 64 | // 5xx Server Errors [INFO] [stdout] 65 ~ 500 => HttpResponse::InternalServerError(), [INFO] [stdout] 66 ~ 502 => HttpResponse::BadGateway(), [INFO] [stdout] 67 ~ 503 => HttpResponse::ServiceUnavailable(), [INFO] [stdout] 68 | [INFO] [stdout] 69 | // Default to 200 Success [INFO] [stdout] 70 ~ _ => HttpResponse::Ok(), [INFO] [stdout] 71 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/controllers/crud/create.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | if let Some(_) = data_from_db.iter_mut().find(|m| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ if data_from_db.iter_mut().find(|m| { [INFO] [stdout] 38 + m.values() [INFO] [stdout] 39 + .any(|v| v.as_str() == Some(&body.arg.iter().next().unwrap().1).unwrap().as_str()) [INFO] [stdout] 40 ~ }).is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> src/controllers/crud/create.rs:39:36 [INFO] [stdout] | [INFO] [stdout] 39 | .any(|v| v.as_str() == Some(&body.arg.iter().next().unwrap().1).unwrap().as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] | [INFO] [stdout] 39 - .any(|v| v.as_str() == Some(&body.arg.iter().next().unwrap().1).unwrap().as_str()) [INFO] [stdout] 39 + .any(|v| v.as_str() == &body.arg.iter().next().unwrap().1.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `refreshed_token` after checking its variant with `is_none` [INFO] [stdout] --> src/controllers/user/tokanize_user.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 20 | let refresh_token = if refreshed_token.is_none() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = refreshed_token` [INFO] [stdout] ... [INFO] [stdout] 26 | refreshed_token.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controllers/user/email_verification.rs:48:65 [INFO] [stdout] | [INFO] [stdout] 48 | if email.is_none() || username.is_none() || !is_valid_email(&email.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `email.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controllers/user/email_verification.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 59 | success_to_verify_email(&email.unwrap(), &name) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `email.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/controllers/user/combinator.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | id: String::from(id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jwt/manager.rs:57:37 [INFO] [stdout] | [INFO] [stdout] 57 | let cipher = Aes256Gcm::new(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jwt/manager.rs:132:39 [INFO] [stdout] | [INFO] [stdout] 132 | let decoded = self.decode_jwt(&token)?; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/middleware/guard.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Some(auth_header) = req.headers().get("Authorization") { [INFO] [stdout] 122 | | if let Ok(auth_str) = auth_header.to_str() { [INFO] [stdout] 123 | | if let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | | return Some(token); [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 121 ~ if let Some(auth_header) = req.headers().get("Authorization") [INFO] [stdout] 122 ~ && let Ok(auth_str) = auth_header.to_str() { [INFO] [stdout] 123 | if let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | return Some(token); [INFO] [stdout] 125 | } [INFO] [stdout] 126 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/middleware/guard.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / if let Ok(auth_str) = auth_header.to_str() { [INFO] [stdout] 123 | | if let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | | return Some(token); [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ if let Ok(auth_str) = auth_header.to_str() [INFO] [stdout] 123 ~ && let Some(token) = auth_str.strip_prefix("Bearer ") { [INFO] [stdout] 124 | return Some(token); [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `structs::user::User` [INFO] [stdout] --> src/structs/user.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn to_string(&self) -> String { [INFO] [stdout] 16 | | serde_json::to_string(self).unwrap() [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `structs::user::User` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/constants.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(is_public, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(is_public, false); [INFO] [stdout] 27 + assert!(!is_public); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_ne!` with a literal bool [INFO] [stdout] --> src/test/constants.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_ne!(is_public, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_ne!(is_public, true); [INFO] [stdout] 28 + assert!(!is_public); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/jwt.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | .encode_jwt(&"SOME_DATA_TO_ENCODE", None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"SOME_DATA_TO_ENCODE"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/test/jwt.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | assert!(!decoded.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `decoded.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/jwt.rs:23:37 [INFO] [stdout] | [INFO] [stdout] 23 | .decode_jwt_and_decrypt(&"INVALIDE_TOKEN"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `"INVALIDE_TOKEN"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/sign_in.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | access_token: Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] | ___________________________^ [INFO] [stdout] 30 | | .unwrap_or(Some("")) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 29 - access_token: Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 30 - .unwrap_or(Some("")) [INFO] [stdout] 29 + access_token: body["data3"]["access_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/sign_in.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | refresh_token: Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 34 | | .unwrap_or(Some("")) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 33 - refresh_token: Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 34 - .unwrap_or(Some("")) [INFO] [stdout] 33 + refresh_token: body["data3"]["refresh_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/controllers/user/sign_in.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / assert_eq!( [INFO] [stdout] 55 | | JwtManager::new() [INFO] [stdout] 56 | | .unwrap() [INFO] [stdout] 57 | | .verify(&tokens_payload.access_token) [INFO] [stdout] ... | [INFO] [stdout] 60 | | false [INFO] [stdout] 61 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 54 ~ assert!( [INFO] [stdout] 55 ~ !JwtManager::new() [INFO] [stdout] 56 | .unwrap() [INFO] [stdout] 57 | .verify(&tokens_payload.access_token) [INFO] [stdout] 58 | .unwrap() [INFO] [stdout] 59 ~ .expired [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/controllers/user/sign_in.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / assert_eq!( [INFO] [stdout] 64 | | JwtManager::new() [INFO] [stdout] 65 | | .unwrap() [INFO] [stdout] 66 | | .verify(&tokens_payload.refresh_token) [INFO] [stdout] ... | [INFO] [stdout] 69 | | false [INFO] [stdout] 70 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 ~ assert!( [INFO] [stdout] 64 ~ !JwtManager::new() [INFO] [stdout] 65 | .unwrap() [INFO] [stdout] 66 | .verify(&tokens_payload.refresh_token) [INFO] [stdout] 67 | .unwrap() [INFO] [stdout] 68 ~ .expired [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/controllers/user/sign_up.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / assert_eq!( [INFO] [stdout] 29 | | JwtManager::new() [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] 31 | | .verify( [INFO] [stdout] ... | [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 ~ assert!( [INFO] [stdout] 29 ~ !JwtManager::new() [INFO] [stdout] 30 | .unwrap() [INFO] [stdout] ... [INFO] [stdout] 37 | .unwrap() [INFO] [stdout] 38 ~ .expired [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/test/controllers/user/sign_up.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | / &Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 33 | | .unwrap_or(Some("")) [INFO] [stdout] 34 | | .unwrap() [INFO] [stdout] 35 | | .to_string() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 32 ~ Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 33 + .unwrap_or(Some("")) [INFO] [stdout] 34 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/sign_up.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | &Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] | ______________________^ [INFO] [stdout] 33 | | .unwrap_or(Some("")) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 32 - &Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 33 - .unwrap_or(Some("")) [INFO] [stdout] 32 + &body["data3"]["access_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/controllers/user/sign_up.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / assert_eq!( [INFO] [stdout] 43 | | JwtManager::new() [INFO] [stdout] 44 | | .unwrap() [INFO] [stdout] 45 | | .verify( [INFO] [stdout] ... | [INFO] [stdout] 53 | | false [INFO] [stdout] 54 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 42 ~ assert!( [INFO] [stdout] 43 ~ !JwtManager::new() [INFO] [stdout] 44 | .unwrap() [INFO] [stdout] ... [INFO] [stdout] 51 | .unwrap() [INFO] [stdout] 52 ~ .expired [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/test/controllers/user/sign_up.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | / &Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 47 | | .unwrap_or(Some("")) [INFO] [stdout] 48 | | .unwrap() [INFO] [stdout] 49 | | .to_string() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 46 ~ Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 47 + .unwrap_or(Some("")) [INFO] [stdout] 48 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/sign_up.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | &Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] | ______________________^ [INFO] [stdout] 47 | | .unwrap_or(Some("")) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 46 - &Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 47 - .unwrap_or(Some("")) [INFO] [stdout] 46 + &body["data3"]["refresh_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/controllers/user/lifecycle.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / assert_eq!( [INFO] [stdout] 38 | | JwtManager::new() [INFO] [stdout] 39 | | .unwrap() [INFO] [stdout] 40 | | .verify( [INFO] [stdout] ... | [INFO] [stdout] 48 | | false [INFO] [stdout] 49 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 37 ~ assert!( [INFO] [stdout] 38 ~ !JwtManager::new() [INFO] [stdout] 39 | .unwrap() [INFO] [stdout] ... [INFO] [stdout] 46 | .unwrap() [INFO] [stdout] 47 ~ .expired [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/test/controllers/user/lifecycle.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | / &Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 42 | | .unwrap_or(Some("")) [INFO] [stdout] 43 | | .unwrap() [INFO] [stdout] 44 | | .to_string() [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 41 ~ Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 42 + .unwrap_or(Some("")) [INFO] [stdout] 43 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/lifecycle.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 41 | &Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 42 | | .unwrap_or(Some("")) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 41 - &Some(body["data3"]["access_token"].clone().as_str()) [INFO] [stdout] 42 - .unwrap_or(Some("")) [INFO] [stdout] 41 + &body["data3"]["access_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/controllers/user/lifecycle.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / assert_eq!( [INFO] [stdout] 52 | | JwtManager::new() [INFO] [stdout] 53 | | .unwrap() [INFO] [stdout] 54 | | .verify( [INFO] [stdout] ... | [INFO] [stdout] 62 | | false [INFO] [stdout] 63 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 ~ assert!( [INFO] [stdout] 52 ~ !JwtManager::new() [INFO] [stdout] 53 | .unwrap() [INFO] [stdout] ... [INFO] [stdout] 60 | .unwrap() [INFO] [stdout] 61 ~ .expired [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/test/controllers/user/lifecycle.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | / &Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 56 | | .unwrap_or(Some("")) [INFO] [stdout] 57 | | .unwrap() [INFO] [stdout] 58 | | .to_string() [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 55 ~ Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 56 + .unwrap_or(Some("")) [INFO] [stdout] 57 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `Some` value [INFO] [stdout] --> src/test/controllers/user/lifecycle.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 55 | &Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 56 | | .unwrap_or(Some("")) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] help: remove the `Some` and `unwrap_or()` [INFO] [stdout] | [INFO] [stdout] 55 - &Some(body["data3"]["refresh_token"].clone().as_str()) [INFO] [stdout] 56 - .unwrap_or(Some("")) [INFO] [stdout] 55 + &body["data3"]["refresh_token"].clone().as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 21s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "7f5d7ebdf9720dba1d89617877bdf766f31754bc9609a13b9244bae0a6ccba51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f5d7ebdf9720dba1d89617877bdf766f31754bc9609a13b9244bae0a6ccba51", kill_on_drop: false }` [INFO] [stdout] 7f5d7ebdf9720dba1d89617877bdf766f31754bc9609a13b9244bae0a6ccba51