[INFO] cloning repository https://github.com/hamaluik/ttf2cp437 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hamaluik/ttf2cp437" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhamaluik%2Fttf2cp437", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhamaluik%2Fttf2cp437'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d09e5ddfefbcaf62c3eb875038cba46905b35ebd [INFO] linting hamaluik/ttf2cp437 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhamaluik%2Fttf2cp437" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hamaluik/ttf2cp437 [INFO] finished tweaking git repo https://github.com/hamaluik/ttf2cp437 [INFO] tweaked toml for git repo https://github.com/hamaluik/ttf2cp437 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hamaluik/ttf2cp437 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hamaluik/ttf2cp437 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-derive v0.2.5 [INFO] [stderr] Downloaded png v0.15.2 [INFO] [stderr] Downloaded rusttype v0.8.2 [INFO] [stderr] Downloaded memoffset v0.5.3 [INFO] [stderr] Downloaded gif v0.10.3 [INFO] [stderr] Downloaded rayon-core v1.7.0 [INFO] [stderr] Downloaded crossbeam-epoch v0.8.0 [INFO] [stderr] Downloaded jpeg-decoder v0.1.18 [INFO] [stderr] Downloaded crossbeam-deque v0.7.2 [INFO] [stderr] Downloaded num-rational v0.2.2 [INFO] [stderr] Downloaded tiff v0.3.1 [INFO] [stderr] Downloaded rayon v1.3.0 [INFO] [stderr] Downloaded image v0.22.3 [INFO] [stderr] Downloaded num-traits v0.2.10 [INFO] [stderr] Downloaded hermit-abi v0.1.5 [INFO] [stderr] Downloaded num_cpus v1.11.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aec5936cf151ca02ffa2adf11aa9f07b5508448e944340b500cb35bdfa47d427 [INFO] running `Command { std: "docker" "start" "-a" "aec5936cf151ca02ffa2adf11aa9f07b5508448e944340b500cb35bdfa47d427", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aec5936cf151ca02ffa2adf11aa9f07b5508448e944340b500cb35bdfa47d427", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aec5936cf151ca02ffa2adf11aa9f07b5508448e944340b500cb35bdfa47d427", kill_on_drop: false }` [INFO] [stdout] aec5936cf151ca02ffa2adf11aa9f07b5508448e944340b500cb35bdfa47d427 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24e7a76cd8a0a405d0e87b20e6305eda1602c29c2839cd94c409365e004594be [INFO] running `Command { std: "docker" "start" "-a" "24e7a76cd8a0a405d0e87b20e6305eda1602c29c2839cd94c409365e004594be", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking png v0.15.2 [INFO] [stderr] Checking rusttype v0.8.2 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking jpeg-decoder v0.1.18 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking image v0.22.3 [INFO] [stderr] Checking ttf2cp437 v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !font_path.file_stem().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `font_path.file_stem().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(()); [INFO] [stdout] 87 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | let is_ttf = if let Some("ttf") = font_path.extension().map(std::ffi::OsStr::to_str).flatten() { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 24 - let is_ttf = if let Some("ttf") = font_path.extension().map(std::ffi::OsStr::to_str).flatten() { true } else { false }; [INFO] [stdout] 24 + let is_ttf = matches!(font_path.extension().map(std::ffi::OsStr::to_str).flatten(), Some("ttf")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/main.rs:24:61 [INFO] [stdout] | [INFO] [stdout] 24 | let is_ttf = if let Some("ttf") = font_path.extension().map(std::ffi::OsStr::to_str).flatten() { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(std::ffi::OsStr::to_str)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/main.rs:76:43 [INFO] [stdout] | [INFO] [stdout] 76 | let file_stem = font_path.file_stem().map(std::ffi::OsStr::to_str).flatten().expect("file stem"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(std::ffi::OsStr::to_str)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !font_path.file_stem().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `font_path.file_stem().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(()); [INFO] [stdout] 87 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | let is_ttf = if let Some("ttf") = font_path.extension().map(std::ffi::OsStr::to_str).flatten() { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 24 - let is_ttf = if let Some("ttf") = font_path.extension().map(std::ffi::OsStr::to_str).flatten() { true } else { false }; [INFO] [stdout] 24 + let is_ttf = matches!(font_path.extension().map(std::ffi::OsStr::to_str).flatten(), Some("ttf")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/main.rs:24:61 [INFO] [stdout] | [INFO] [stdout] 24 | let is_ttf = if let Some("ttf") = font_path.extension().map(std::ffi::OsStr::to_str).flatten() { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(std::ffi::OsStr::to_str)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/main.rs:76:43 [INFO] [stdout] | [INFO] [stdout] 76 | let file_stem = font_path.file_stem().map(std::ffi::OsStr::to_str).flatten().expect("file stem"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(std::ffi::OsStr::to_str)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.27s [INFO] running `Command { std: "docker" "inspect" "24e7a76cd8a0a405d0e87b20e6305eda1602c29c2839cd94c409365e004594be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24e7a76cd8a0a405d0e87b20e6305eda1602c29c2839cd94c409365e004594be", kill_on_drop: false }` [INFO] [stdout] 24e7a76cd8a0a405d0e87b20e6305eda1602c29c2839cd94c409365e004594be