[INFO] cloning repository https://github.com/ha36ad/Rust-Shell-CodeCrafters [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ha36ad/Rust-Shell-CodeCrafters" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fha36ad%2FRust-Shell-CodeCrafters", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fha36ad%2FRust-Shell-CodeCrafters'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30eb89de958bf7fe9ee92e56924cf87cc4515e75 [INFO] linting ha36ad/Rust-Shell-CodeCrafters against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fha36ad%2FRust-Shell-CodeCrafters" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ha36ad/Rust-Shell-CodeCrafters [INFO] finished tweaking git repo https://github.com/ha36ad/Rust-Shell-CodeCrafters [INFO] tweaked toml for git repo https://github.com/ha36ad/Rust-Shell-CodeCrafters written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ha36ad/Rust-Shell-CodeCrafters on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ha36ad/Rust-Shell-CodeCrafters already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded error-code v3.3.2 [INFO] [stderr] Downloaded home v0.5.11 [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded fd-lock v4.0.4 [INFO] [stderr] Downloaded clipboard-win v5.4.0 [INFO] [stderr] Downloaded bytes v1.7.1 [INFO] [stderr] Downloaded rustyline v16.0.0 [INFO] [stderr] Downloaded syn v2.0.75 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcb250263136c4bf8cdf1e59ccd28ff9c016ae47e5f3b141163a0bfbfb183a33 [INFO] running `Command { std: "docker" "start" "-a" "fcb250263136c4bf8cdf1e59ccd28ff9c016ae47e5f3b141163a0bfbfb183a33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcb250263136c4bf8cdf1e59ccd28ff9c016ae47e5f3b141163a0bfbfb183a33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcb250263136c4bf8cdf1e59ccd28ff9c016ae47e5f3b141163a0bfbfb183a33", kill_on_drop: false }` [INFO] [stdout] fcb250263136c4bf8cdf1e59ccd28ff9c016ae47e5f3b141163a0bfbfb183a33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cca508a4e40dc6fff5eb80a2c54bdf4de00959289a08edc1c6450a68c2b22c38 [INFO] running `Command { std: "docker" "start" "-a" "cca508a4e40dc6fff5eb80a2c54bdf4de00959289a08edc1c6450a68c2b22c38", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking fd-lock v4.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rustyline v16.0.0 [INFO] [stderr] Checking codecrafters-shell-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `prev_output` [INFO] [stdout] --> src/execution.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 73 | } else if let Some(ref prev_output) = previous_output { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prev_output` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/completer.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 71 | / ... if file_name.starts_with(last_token) && entry.path().is_file() && is_executable(&entry.path()) { [INFO] [stdout] 72 | | ... if !executable_matches.contains(&file_name) { [INFO] [stdout] 73 | | ... executable_matches.push(file_name.clone()); [INFO] [stdout] 74 | | ... } [INFO] [stdout] 75 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 71 ~ if file_name.starts_with(last_token) && entry.path().is_file() && is_executable(&entry.path()) [INFO] [stdout] 72 ~ && !executable_matches.contains(&file_name) { [INFO] [stdout] 73 | executable_matches.push(file_name.clone()); [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/builtins.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !env::set_current_dir(target_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(target_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/execution.rs:67:40 [INFO] [stdout] | [INFO] [stdout] 67 | let mut cmd = Command::new(&cmd_args[0]); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cmd_args[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/redirection.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn parse_redirection(input: &str) -> (String, Option<(String, bool)>, Option<(String, bool)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:9:63 [INFO] [stdout] | [INFO] [stdout] 9 | let file_path = file_part.trim_start_matches(" 2>> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:14:62 [INFO] [stdout] | [INFO] [stdout] 14 | let file_path = file_part.trim_start_matches(" 2> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:22:63 [INFO] [stdout] | [INFO] [stdout] 22 | let file_path = file_part.trim_start_matches(" 1>> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:27:62 [INFO] [stdout] | [INFO] [stdout] 27 | let file_path = file_part.trim_start_matches(" >> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:32:62 [INFO] [stdout] | [INFO] [stdout] 32 | let file_path = file_part.trim_start_matches(" 1> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:37:61 [INFO] [stdout] | [INFO] [stdout] 37 | let file_path = file_part.trim_start_matches(" > ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_output` [INFO] [stdout] --> src/execution.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 73 | } else if let Some(ref prev_output) = previous_output { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prev_output` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/builtins.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | let builtins = vec!["echo", "exit", "type", "pwd","history", "cd"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["echo", "exit", "type", "pwd","history", "cd"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/execution.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | let builtins = vec!["echo", "exit", "type", "pwd", "cd"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["echo", "exit", "type", "pwd", "cd"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/execution.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 115 | let builtins = vec!["echo", "exit", "type", "pwd", "cd"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["echo", "exit", "type", "pwd", "cd"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/completer.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 71 | / ... if file_name.starts_with(last_token) && entry.path().is_file() && is_executable(&entry.path()) { [INFO] [stdout] 72 | | ... if !executable_matches.contains(&file_name) { [INFO] [stdout] 73 | | ... executable_matches.push(file_name.clone()); [INFO] [stdout] 74 | | ... } [INFO] [stdout] 75 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 71 ~ if file_name.starts_with(last_token) && entry.path().is_file() && is_executable(&entry.path()) [INFO] [stdout] 72 ~ && !executable_matches.contains(&file_name) { [INFO] [stdout] 73 | executable_matches.push(file_name.clone()); [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/builtins.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !env::set_current_dir(target_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(target_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/execution.rs:67:40 [INFO] [stdout] | [INFO] [stdout] 67 | let mut cmd = Command::new(&cmd_args[0]); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cmd_args[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/redirection.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn parse_redirection(input: &str) -> (String, Option<(String, bool)>, Option<(String, bool)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:9:63 [INFO] [stdout] | [INFO] [stdout] 9 | let file_path = file_part.trim_start_matches(" 2>> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:14:62 [INFO] [stdout] | [INFO] [stdout] 14 | let file_path = file_part.trim_start_matches(" 2> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:22:63 [INFO] [stdout] | [INFO] [stdout] 22 | let file_path = file_part.trim_start_matches(" 1>> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:27:62 [INFO] [stdout] | [INFO] [stdout] 27 | let file_path = file_part.trim_start_matches(" >> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:32:62 [INFO] [stdout] | [INFO] [stdout] 32 | let file_path = file_part.trim_start_matches(" 1> ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/redirection.rs:37:61 [INFO] [stdout] | [INFO] [stdout] 37 | let file_path = file_part.trim_start_matches(" > ").trim().split_whitespace().next().unwrap_or(""); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/builtins.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | let builtins = vec!["echo", "exit", "type", "pwd","history", "cd"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["echo", "exit", "type", "pwd","history", "cd"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/execution.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | let builtins = vec!["echo", "exit", "type", "pwd", "cd"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["echo", "exit", "type", "pwd", "cd"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/execution.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 115 | let builtins = vec!["echo", "exit", "type", "pwd", "cd"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["echo", "exit", "type", "pwd", "cd"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.36s [INFO] running `Command { std: "docker" "inspect" "cca508a4e40dc6fff5eb80a2c54bdf4de00959289a08edc1c6450a68c2b22c38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cca508a4e40dc6fff5eb80a2c54bdf4de00959289a08edc1c6450a68c2b22c38", kill_on_drop: false }` [INFO] [stdout] cca508a4e40dc6fff5eb80a2c54bdf4de00959289a08edc1c6450a68c2b22c38