[INFO] cloning repository https://github.com/gushernobindsme/rust-typical90 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gushernobindsme/rust-typical90" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgushernobindsme%2Frust-typical90", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgushernobindsme%2Frust-typical90'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8255779058f7143aa42e25a8e8e15047d1fdde6b [INFO] linting gushernobindsme/rust-typical90 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgushernobindsme%2Frust-typical90" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/gushernobindsme/rust-typical90 [INFO] finished tweaking git repo https://github.com/gushernobindsme/rust-typical90 [INFO] tweaked toml for git repo https://github.com/gushernobindsme/rust-typical90 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gushernobindsme/rust-typical90 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gushernobindsme/rust-typical90 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proconio-derive v0.1.9 [INFO] [stderr] Downloaded proconio v0.3.6 [INFO] [stderr] Downloaded cli_test_dir v0.1.7 [INFO] [stderr] Downloaded petgraph v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 630a5c44366c0a7e3abc7a7e81107dd4cd1bf5c67ba2a98bd4ce8d1712246a8a [INFO] running `Command { std: "docker" "start" "-a" "630a5c44366c0a7e3abc7a7e81107dd4cd1bf5c67ba2a98bd4ce8d1712246a8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "630a5c44366c0a7e3abc7a7e81107dd4cd1bf5c67ba2a98bd4ce8d1712246a8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "630a5c44366c0a7e3abc7a7e81107dd4cd1bf5c67ba2a98bd4ce8d1712246a8a", kill_on_drop: false }` [INFO] [stdout] 630a5c44366c0a7e3abc7a7e81107dd4cd1bf5c67ba2a98bd4ce8d1712246a8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24e058f8923723453026de8f125f723f1e70127648c16d2225aa66186f4318af [INFO] running `Command { std: "docker" "start" "-a" "24e058f8923723453026de8f125f723f1e70127648c16d2225aa66186f4318af", kill_on_drop: false }` [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking cli_test_dir v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking superslice v1.0.0 [INFO] [stderr] Checking petgraph v0.5.0 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Compiling proconio-derive v0.1.9 [INFO] [stderr] Checking proconio v0.3.6 [INFO] [stderr] Checking q-027 v0.1.0 (/opt/rustwide/workdir/q-027) [INFO] [stderr] Checking q-067 v0.1.0 (/opt/rustwide/workdir/q-067) [INFO] [stderr] Checking q-020 v0.1.0 (/opt/rustwide/workdir/q-020) [INFO] [stderr] Checking q-024 v0.1.0 (/opt/rustwide/workdir/q-024) [INFO] [stderr] Checking q-014 v0.1.0 (/opt/rustwide/workdir/q-014) [INFO] [stderr] Checking q-033 v0.1.0 (/opt/rustwide/workdir/q-033) [INFO] [stderr] Checking q-055 v0.1.0 (/opt/rustwide/workdir/q-055) [INFO] [stderr] Checking q-010 v0.1.0 (/opt/rustwide/workdir/q-010) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-067/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-033/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-055/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking q-022 v0.1.0 (/opt/rustwide/workdir/q-022) [INFO] [stderr] Checking q-007 v0.1.0 (/opt/rustwide/workdir/q-007) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-024/src/main.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking q-016 v0.1.0 (/opt/rustwide/workdir/q-016) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> q-027/src/main.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | vec.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 - vec.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] 21 + vec.sort_by_key(|a| a.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> q-016/src/main.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | let mut answer = std::i64::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 11 - let mut answer = std::i64::MAX; [INFO] [stdout] 11 + let mut answer = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-027/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> q-016/src/main.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | let mut answer = std::i64::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 11 - let mut answer = std::i64::MAX; [INFO] [stdout] 11 + let mut answer = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking q-004 v0.1.0 (/opt/rustwide/workdir/q-004) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-024/src/main.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-067/src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return result; [INFO] [stdout] 30 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> q-067/src/main.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !(n > 0) { [INFO] [stdout] | ^^^^^^^^ help: try: `(n <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-067/src/main.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return result.into_iter().collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return result.into_iter().collect::(); [INFO] [stdout] 46 + result.into_iter().collect::() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-067/src/main.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return n.replace("8", "5").chars().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return n.replace("8", "5").chars().collect(); [INFO] [stdout] 51 + n.replace("8", "5").chars().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> q-033/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | ((h + 1) / 2) * ((w + 1) / 2) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `h.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> q-033/src/main.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | ((h + 1) / 2) * ((w + 1) / 2) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking q-061 v0.1.0 (/opt/rustwide/workdir/q-061) [INFO] [stderr] Checking q-002 v0.1.0 (/opt/rustwide/workdir/q-002) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-010/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 16 | for i in 0..h { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 16 - for i in 0..h { [INFO] [stdout] 16 + for (i, ) in a.iter().enumerate().take(h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | for j in 0..w { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 18 - for j in 0..w { [INFO] [stdout] 18 + for (j, ) in a.iter().enumerate().take(w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | for i in 0..h { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 24 - for i in 0..h { [INFO] [stdout] 24 + for (i, ) in a.iter().enumerate().take(h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | for j in 0..w { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for j in 0..w { [INFO] [stdout] 26 + for (j, ) in a.iter().enumerate().take(w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `answers` [INFO] [stdout] --> q-004/src/main.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..h { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..h { [INFO] [stdout] 34 + for in answers.iter().take(h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> q-027/src/main.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | vec.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 - vec.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] 21 + vec.sort_by_key(|a| a.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> q-055/src/main.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | ... answer = answer + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `answer += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking q-078 v0.1.0 (/opt/rustwide/workdir/q-078) [INFO] [stdout] warning: the loop variable `i` is only used to index `tx` [INFO] [stdout] --> q-061/src/main.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 0..q { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 14 - for i in 0..q { [INFO] [stdout] 14 + for in tx.iter().take(q) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-067/src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return result; [INFO] [stdout] 30 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> q-067/src/main.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !(n > 0) { [INFO] [stdout] | ^^^^^^^^ help: try: `(n <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-067/src/main.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return result.into_iter().collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return result.into_iter().collect::(); [INFO] [stdout] 46 + result.into_iter().collect::() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> q-067/src/main.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return n.replace("8", "5").chars().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return n.replace("8", "5").chars().collect(); [INFO] [stdout] 51 + n.replace("8", "5").chars().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> q-078/src/main.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | answer = answer + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `answer += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> q-055/src/main.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | ... answer = answer + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `answer += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-078/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-024/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-022/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 16 | for i in 0..h { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 16 - for i in 0..h { [INFO] [stdout] 16 + for (i, ) in a.iter().enumerate().take(h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | for j in 0..w { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 18 - for j in 0..w { [INFO] [stdout] 18 + for (j, ) in a.iter().enumerate().take(w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | for i in 0..h { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 24 - for i in 0..h { [INFO] [stdout] 24 + for (i, ) in a.iter().enumerate().take(h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `a` [INFO] [stdout] --> q-004/src/main.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | for j in 0..w { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for j in 0..w { [INFO] [stdout] 26 + for (j, ) in a.iter().enumerate().take(w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `answers` [INFO] [stdout] --> q-004/src/main.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..h { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..h { [INFO] [stdout] 34 + for in answers.iter().take(h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-016/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tx` [INFO] [stdout] --> q-061/src/main.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 0..q { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 14 - for i in 0..q { [INFO] [stdout] 14 + for in tx.iter().take(q) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-020/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-002/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> q-078/src/main.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | answer = answer + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `answer += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-014/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-007/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-061/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> q-004/tests/sample_inputs.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | const BIN: &'static str = "./main"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> q-033/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | ((h + 1) / 2) * ((w + 1) / 2) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `h.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> q-033/src/main.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | ((h + 1) / 2) * ((w + 1) / 2) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.02s [INFO] running `Command { std: "docker" "inspect" "24e058f8923723453026de8f125f723f1e70127648c16d2225aa66186f4318af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24e058f8923723453026de8f125f723f1e70127648c16d2225aa66186f4318af", kill_on_drop: false }` [INFO] [stdout] 24e058f8923723453026de8f125f723f1e70127648c16d2225aa66186f4318af