[INFO] cloning repository https://github.com/gula00/guclaw-core
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gula00/guclaw-core" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgula00%2Fguclaw-core", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgula00%2Fguclaw-core'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] a86cd66d14f9bdf8e20f73498a9ec4b55443cbfe
[INFO] linting gula00/guclaw-core against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgula00%2Fguclaw-core" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/gula00/guclaw-core
[INFO] finished tweaking git repo https://github.com/gula00/guclaw-core
[INFO] tweaked toml for git repo https://github.com/gula00/guclaw-core written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/gula00/guclaw-core on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/gula00/guclaw-core already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Updating crates.io index
[INFO] [stderr] Downloading crates ...
[INFO] [stderr] Downloaded napi-build v2.3.1
[INFO] [stderr] Downloaded napi-sys v2.4.0
[INFO] [stderr] Downloaded imagesize v0.13.0
[INFO] [stderr] Downloaded napi-derive v2.16.13
[INFO] [stderr] Downloaded napi-derive-backend v1.0.75
[INFO] [stderr] Downloaded napi v2.16.17
[INFO] [stderr] Downloaded zerocopy-derive v0.8.40
[INFO] [stderr] Downloaded zerocopy v0.8.40
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 92f1f55eb1b082140c58c57d412ed32571ee0e8311c5a23b118e05f9a6a67fe6
[INFO] running `Command { std: "docker" "start" "-a" "92f1f55eb1b082140c58c57d412ed32571ee0e8311c5a23b118e05f9a6a67fe6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "92f1f55eb1b082140c58c57d412ed32571ee0e8311c5a23b118e05f9a6a67fe6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "92f1f55eb1b082140c58c57d412ed32571ee0e8311c5a23b118e05f9a6a67fe6", kill_on_drop: false }`
[INFO] [stdout] 92f1f55eb1b082140c58c57d412ed32571ee0e8311c5a23b118e05f9a6a67fe6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] bd7feeb0b14e34765357a0497e6c33c4f248fdea57c2d6f620526a7686e9254b
[INFO] running `Command { std: "docker" "start" "-a" "bd7feeb0b14e34765357a0497e6c33c4f248fdea57c2d6f620526a7686e9254b", kill_on_drop: false }`
[INFO] [stderr] Compiling quote v1.0.45
[INFO] [stderr] Compiling unicode-ident v1.0.24
[INFO] [stderr] Compiling zerocopy v0.8.40
[INFO] [stderr] Compiling memchr v2.8.0
[INFO] [stderr] Compiling regex-syntax v0.8.10
[INFO] [stderr] Compiling ahash v0.8.12
[INFO] [stderr] Compiling convert_case v0.6.0
[INFO] [stderr] Compiling napi-build v2.3.1
[INFO] [stderr] Compiling semver v1.0.27
[INFO] [stderr] Compiling serde_json v1.0.149
[INFO] [stderr] Compiling libsqlite3-sys v0.28.0
[INFO] [stderr] Checking fallible-streaming-iterator v0.1.9
[INFO] [stderr] Checking napi-sys v2.4.0
[INFO] [stderr] Checking imagesize v0.13.0
[INFO] [stderr] Compiling proc-macro2 v1.0.106
[INFO] [stderr] Compiling gula_db_core v0.1.0 (/opt/rustwide/workdir)
[INFO] [stderr] Compiling aho-corasick v1.1.4
[INFO] [stderr] Compiling syn v2.0.117
[INFO] [stderr] Compiling regex-automata v0.4.14
[INFO] [stderr] Checking hashbrown v0.14.5
[INFO] [stderr] Compiling serde_derive v1.0.228
[INFO] [stderr] Compiling ctor v0.2.9
[INFO] [stderr] Compiling regex v1.12.3
[INFO] [stderr] Checking napi v2.16.17
[INFO] [stderr] Compiling napi-derive-backend v1.0.75
[INFO] [stderr] Checking hashlink v0.9.1
[INFO] [stderr] Compiling napi-derive v2.16.13
[INFO] [stderr] Checking serde v1.0.228
[INFO] [stderr] Checking rusqlite v0.31.0
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:35:17
[INFO] [stdout] |
[INFO] [stdout] 35 | |row| map_channel_mapping_row(row),
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_channel_mapping_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:66:46
[INFO] [stdout] |
[INFO] [stdout] 66 | conn.query_row(&sql, [input.id], |row| map_channel_mapping_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_channel_mapping_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:129:53
[INFO] [stdout] |
[INFO] [stdout] 129 | let mapped = stmt.query_map([platform], |row| map_distinct_channel_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_distinct_channel_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:142:54
[INFO] [stdout] |
[INFO] [stdout] 142 | let mapped = stmt.query_map([thread_id], |row| map_channel_mapping_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_channel_mapping_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:170:45
[INFO] [stdout] |
[INFO] [stdout] 170 | let mapped = stmt.query_map([], |row| map_model_caps_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_model_caps_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:182:40
[INFO] [stdout] |
[INFO] [stdout] 182 | conn.query_row(&sql, [id], |row| map_model_caps_cache_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_model_caps_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:205:54
[INFO] [stdout] |
[INFO] [stdout] 205 | let row = tx.query_row(&sql, [input.id], |row| map_model_caps_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_model_caps_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:250:40
[INFO] [stdout] |
[INFO] [stdout] 250 | conn.query_row(&sql, [id], |row| map_provider_models_cache_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_provider_models_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:290:54
[INFO] [stdout] |
[INFO] [stdout] 290 | let row = tx.query_row(&sql, [input.id], |row| map_provider_models_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_provider_models_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:330:40
[INFO] [stdout] |
[INFO] [stdout] 330 | conn.query_row(&sql, [id], |row| map_thread_diff_stats_cache_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_thread_diff_stats_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:359:54
[INFO] [stdout] |
[INFO] [stdout] 359 | let row = tx.query_row(&sql, [input.id], |row| map_thread_diff_stats_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_thread_diff_stats_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:15:45
[INFO] [stdout] |
[INFO] [stdout] 15 | let mapped = stmt.query_map([], |row| map_custom_theme_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:24:40
[INFO] [stdout] |
[INFO] [stdout] 24 | conn.query_row(&sql, [id], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:33:42
[INFO] [stdout] |
[INFO] [stdout] 33 | conn.query_row(&sql, [name], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:62:46
[INFO] [stdout] |
[INFO] [stdout] 62 | conn.query_row(&sql, [input.id], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:123:46
[INFO] [stdout] |
[INFO] [stdout] 123 | .query_row(&sql, [input.id], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `split_once`
[INFO] [stdout] --> src/ops/gallery_cache.rs:70:5
[INFO] [stdout] |
[INFO] [stdout] 70 | let mut parts = url.splitn(2, ',');
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 71 | let header = parts.next()?;
[INFO] [stdout] | --------------------------- first usage here
[INFO] [stdout] 72 | let payload = parts.next()?;
[INFO] [stdout] | ---------------------------- second usage here
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once
[INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default
[INFO] [stdout] help: replace with `split_once`
[INFO] [stdout] |
[INFO] [stdout] 70 ~ let (header, payload) = url.split_once(',')?;
[INFO] [stdout] 71 ~
[INFO] [stdout] 72 ~
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:35:17
[INFO] [stdout] |
[INFO] [stdout] 35 | |row| map_channel_mapping_row(row),
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_channel_mapping_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:66:46
[INFO] [stdout] |
[INFO] [stdout] 66 | conn.query_row(&sql, [input.id], |row| map_channel_mapping_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_channel_mapping_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:129:53
[INFO] [stdout] |
[INFO] [stdout] 129 | let mapped = stmt.query_map([platform], |row| map_distinct_channel_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_distinct_channel_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:142:54
[INFO] [stdout] |
[INFO] [stdout] 142 | let mapped = stmt.query_map([thread_id], |row| map_channel_mapping_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_channel_mapping_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:170:45
[INFO] [stdout] |
[INFO] [stdout] 170 | let mapped = stmt.query_map([], |row| map_model_caps_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_model_caps_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:182:40
[INFO] [stdout] |
[INFO] [stdout] 182 | conn.query_row(&sql, [id], |row| map_model_caps_cache_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_model_caps_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:205:54
[INFO] [stdout] |
[INFO] [stdout] 205 | let row = tx.query_row(&sql, [input.id], |row| map_model_caps_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_model_caps_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:250:40
[INFO] [stdout] |
[INFO] [stdout] 250 | conn.query_row(&sql, [id], |row| map_provider_models_cache_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_provider_models_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:290:54
[INFO] [stdout] |
[INFO] [stdout] 290 | let row = tx.query_row(&sql, [input.id], |row| map_provider_models_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_provider_models_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:330:40
[INFO] [stdout] |
[INFO] [stdout] 330 | conn.query_row(&sql, [id], |row| map_thread_diff_stats_cache_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_thread_diff_stats_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/channel_cache.rs:359:54
[INFO] [stdout] |
[INFO] [stdout] 359 | let row = tx.query_row(&sql, [input.id], |row| map_thread_diff_stats_cache_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_thread_diff_stats_cache_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:75:45
[INFO] [stdout] |
[INFO] [stdout] 75 | let mapped = stmt.query_map([], |row| map_mcp_server_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:88:45
[INFO] [stdout] |
[INFO] [stdout] 88 | let mapped = stmt.query_map([], |row| map_mcp_server_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:97:40
[INFO] [stdout] |
[INFO] [stdout] 97 | conn.query_row(&sql, [id], |row| map_mcp_server_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:109:49
[INFO] [stdout] |
[INFO] [stdout] 109 | conn.query_row(&sql, [registry_id], |row| map_mcp_server_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:118:42
[INFO] [stdout] |
[INFO] [stdout] 118 | conn.query_row(&sql, [name], |row| map_mcp_server_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:149:46
[INFO] [stdout] |
[INFO] [stdout] 149 | conn.query_row(&sql, [input.id], |row| map_mcp_server_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:235:46
[INFO] [stdout] |
[INFO] [stdout] 235 | .query_row(&sql, [input.id], |row| map_mcp_server_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_server_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:257:47
[INFO] [stdout] |
[INFO] [stdout] 257 | conn.query_row(&sql, [server_id], |row| map_mcp_oauth_token_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_oauth_token_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:266:45
[INFO] [stdout] |
[INFO] [stdout] 266 | let mapped = stmt.query_map([], |row| map_mcp_oauth_token_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_oauth_token_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:15:45
[INFO] [stdout] |
[INFO] [stdout] 15 | let mapped = stmt.query_map([], |row| map_custom_theme_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:24:40
[INFO] [stdout] |
[INFO] [stdout] 24 | conn.query_row(&sql, [id], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:33:42
[INFO] [stdout] |
[INFO] [stdout] 33 | conn.query_row(&sql, [name], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:337:55
[INFO] [stdout] |
[INFO] [stdout] 337 | let row = tx.query_row(&sql, [server_id], |row| map_mcp_oauth_token_row(row))?;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_oauth_token_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:62:46
[INFO] [stdout] |
[INFO] [stdout] 62 | conn.query_row(&sql, [input.id], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/mcp_state.rs:375:47
[INFO] [stdout] |
[INFO] [stdout] 375 | conn.query_row(&sql, [server_id], |row| map_mcp_oauth_token_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_mcp_oauth_token_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant closure
[INFO] [stdout] --> src/ops/custom_theme_state.rs:123:46
[INFO] [stdout] |
[INFO] [stdout] 123 | .query_row(&sql, [input.id], |row| map_custom_theme_row(row))
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `map_custom_theme_row`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `split_once`
[INFO] [stdout] --> src/ops/gallery_cache.rs:70:5
[INFO] [stdout] |
[INFO] [stdout] 70 | let mut parts = url.splitn(2, ',');
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 71 | let header = parts.next()?;
[INFO] [stdout] | --------------------------- first usage here
[INFO] [stdout] 72 | let payload = parts.next()?;
[INFO] [stdout] | ---------------------------- second usage here
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once
[INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default
[INFO] [stdout] help: replace with `split_once`
[INFO] [stdout] |
[INFO] [stdout] 70 ~ let (header, payload) = url.split_once(',')?;
[INFO] [stdout] 71 ~
[INFO] [stdout] 72 ~
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: useless conversion to the same type: `rusqlite::Error`
[INFO] [stdout] --> src/ops/memory_state.rs:192:40
[INFO] [stdout] |
[INFO] [stdout] 192 | Err(err) => return Err(err.into()),
[INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `err`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this function has too many arguments (10/7)
[INFO] [stdout] --> src/ops/memory_state.rs:199:5
[INFO] [stdout] |
[INFO] [stdout] 199 | / pub fn add_memory_with_embedding(
[INFO] [stdout] 200 | | &self,
[INFO] [stdout] 201 | | id: String,
[INFO] [stdout] 202 | | content: String,
[INFO] [stdout] ... |
[INFO] [stdout] 209 | | embedding_json: String,
[INFO] [stdout] 210 | | ) -> Result