[INFO] cloning repository https://github.com/gtors/inj
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gtors/inj" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgtors%2Finj", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgtors%2Finj'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0f7c4a2cbe04383418496d4d88d046c5abd9353f
[INFO] linting gtors/inj against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgtors%2Finj" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/gtors/inj
[INFO] finished tweaking git repo https://github.com/gtors/inj
[INFO] tweaked toml for git repo https://github.com/gtors/inj written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/gtors/inj on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/gtors/inj already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded pyo3-macros v0.21.2
[INFO] [stderr]   Downloaded pyo3-build-config v0.21.2
[INFO] [stderr]   Downloaded pyo3-macros-backend v0.21.2
[INFO] [stderr]   Downloaded pyo3-ffi v0.21.2
[INFO] [stderr]   Downloaded pyo3 v0.21.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a345388e830051149c4a95a6a0b862f1ebecbf2f046f3ba672fb65e2b40521bc
[INFO] running `Command { std: "docker" "start" "-a" "a345388e830051149c4a95a6a0b862f1ebecbf2f046f3ba672fb65e2b40521bc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a345388e830051149c4a95a6a0b862f1ebecbf2f046f3ba672fb65e2b40521bc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a345388e830051149c4a95a6a0b862f1ebecbf2f046f3ba672fb65e2b40521bc", kill_on_drop: false }`
[INFO] [stdout] a345388e830051149c4a95a6a0b862f1ebecbf2f046f3ba672fb65e2b40521bc
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 3ce395e87de596e9936a7a8963dc7aa211b26bc8850b6b8779923a7bda1be539
[INFO] running `Command { std: "docker" "start" "-a" "3ce395e87de596e9936a7a8963dc7aa211b26bc8850b6b8779923a7bda1be539", kill_on_drop: false }`
[INFO] [stderr]    Compiling pyo3-build-config v0.21.2
[INFO] [stderr]    Compiling autocfg v1.2.0
[INFO] [stderr]    Compiling proc-macro2 v1.0.81
[INFO] [stderr]     Checking smallvec v1.13.2
[INFO] [stderr]     Checking unindent v0.2.3
[INFO] [stderr]     Checking parking_lot_core v0.9.9
[INFO] [stderr]    Compiling lock_api v0.4.11
[INFO] [stderr]    Compiling memoffset v0.9.1
[INFO] [stderr]    Compiling quote v1.0.36
[INFO] [stderr]     Checking parking_lot v0.12.1
[INFO] [stderr]    Compiling syn v2.0.60
[INFO] [stderr]    Compiling pyo3-ffi v0.21.2
[INFO] [stderr]    Compiling pyo3 v0.21.2
[INFO] [stderr]    Compiling pyo3-macros-backend v0.21.2
[INFO] [stderr]    Compiling pyo3-macros v0.21.2
[INFO] [stderr]     Checking inj v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `pyo3::intern`
[INFO] [stdout]  --> src/containers.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use pyo3::intern;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `pyo3::intern`
[INFO] [stdout]  --> src/containers.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use pyo3::intern;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/providers.rs:92:13
[INFO] [stdout]    |
[INFO] [stdout] 92 |             instance_of: instance_of,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_of`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/providers.rs:93:13
[INFO] [stdout]    |
[INFO] [stdout] 93 |             default: default,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/providers.rs:92:13
[INFO] [stdout]    |
[INFO] [stdout] 92 |             instance_of: instance_of,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_of`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/providers.rs:93:13
[INFO] [stdout]    |
[INFO] [stdout] 93 |             default: default,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `kwargs`
[INFO] [stdout]   --> src/providers.rs:89:9
[INFO] [stdout]    |
[INFO] [stdout] 89 |         kwargs: Option<Py<PyDict>>,
[INFO] [stdout]    |         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_kwargs`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `dependencies`
[INFO] [stdout]    --> src/providers.rs:120:12
[INFO] [stdout]     |
[INFO] [stdout] 120 |     fn new(dependencies: Option<HashMap<String, Py<PyAny>>>) -> (Self, Provider) {
[INFO] [stdout]     |            ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dependencies`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `kwargs`
[INFO] [stdout]   --> src/providers.rs:89:9
[INFO] [stdout]    |
[INFO] [stdout] 89 |         kwargs: Option<Py<PyDict>>,
[INFO] [stdout]    |         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_kwargs`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `dependencies`
[INFO] [stdout]    --> src/providers.rs:120:12
[INFO] [stdout]     |
[INFO] [stdout] 120 |     fn new(dependencies: Option<HashMap<String, Py<PyAny>>>) -> (Self, Provider) {
[INFO] [stdout]     |            ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dependencies`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `last_overriding` and `overrides` are never read
[INFO] [stdout]   --> src/providers.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout]  8 | pub struct Provider {
[INFO] [stdout]    |            -------- fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 11 |     last_overriding: Option<PyObject>,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^
[INFO] [stdout] 12 |     overrides: Vec<PyObject>,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Provider` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `instance_of`, `default`, and `parent` are never read
[INFO] [stdout]   --> src/providers.rs:76:5
[INFO] [stdout]    |
[INFO] [stdout] 75 | pub struct Dependency {
[INFO] [stdout]    |            ---------- fields in this struct
[INFO] [stdout] 76 |     instance_of: Option<Py<PyType>>,
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout] 77 |     default: Option<Py<PyAny>>,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout] 78 |     parent: Option<Py<PyObject>>,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `providers` and `parent` are never read
[INFO] [stdout]    --> src/providers.rs:112:5
[INFO] [stdout]     |
[INFO] [stdout] 111 | pub struct DependenciesContainer {
[INFO] [stdout]     |            --------------------- fields in this struct
[INFO] [stdout] 112 |     providers: HashMap<String, Py<PyObject>>,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 113 |     parent: Option<Py<PyObject>>,
[INFO] [stdout]     |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `container_cls` is never read
[INFO] [stdout]    --> src/providers.rs:133:5
[INFO] [stdout]     |
[INFO] [stdout] 132 | pub struct Container {
[INFO] [stdout]     |            --------- field in this struct
[INFO] [stdout] 133 |     container_cls: Option<Py<PyType>>,
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `providers` is never read
[INFO] [stdout]    --> src/providers.rs:194:5
[INFO] [stdout]     |
[INFO] [stdout] 193 | pub struct Traverse {
[INFO] [stdout]     |            -------- field in this struct
[INFO] [stdout] 194 |     providers: Vec<Py<Provider>>,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or_else` to construct default value
[INFO] [stdout]   --> src/containers.rs:42:30
[INFO] [stdout]    |
[INFO] [stdout] 42 |             modules: modules.unwrap_or_else(Vec::new),
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or_else` to construct default value
[INFO] [stdout]   --> src/containers.rs:43:32
[INFO] [stdout]    |
[INFO] [stdout] 43 |             packages: packages.unwrap_or_else(Vec::new),
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `last_overriding` and `overrides` are never read
[INFO] [stdout]   --> src/providers.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout]  8 | pub struct Provider {
[INFO] [stdout]    |            -------- fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 11 |     last_overriding: Option<PyObject>,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^
[INFO] [stdout] 12 |     overrides: Vec<PyObject>,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Provider` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/containers.rs:231:33
[INFO] [stdout]     |
[INFO] [stdout] 231 |         let providers: Vec<_> = self.providers.values().map(|p| p.clone()).collect();
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.providers.values().cloned()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `instance_of`, `default`, and `parent` are never read
[INFO] [stdout]   --> src/providers.rs:76:5
[INFO] [stdout]    |
[INFO] [stdout] 75 | pub struct Dependency {
[INFO] [stdout]    |            ---------- fields in this struct
[INFO] [stdout] 76 |     instance_of: Option<Py<PyType>>,
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout] 77 |     default: Option<Py<PyAny>>,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout] 78 |     parent: Option<Py<PyObject>>,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `providers` and `parent` are never read
[INFO] [stdout]    --> src/providers.rs:112:5
[INFO] [stdout]     |
[INFO] [stdout] 111 | pub struct DependenciesContainer {
[INFO] [stdout]     |            --------------------- fields in this struct
[INFO] [stdout] 112 |     providers: HashMap<String, Py<PyObject>>,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 113 |     parent: Option<Py<PyObject>>,
[INFO] [stdout]     |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `container_cls` is never read
[INFO] [stdout]    --> src/providers.rs:133:5
[INFO] [stdout]     |
[INFO] [stdout] 132 | pub struct Container {
[INFO] [stdout]     |            --------- field in this struct
[INFO] [stdout] 133 |     container_cls: Option<Py<PyType>>,
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `providers` is never read
[INFO] [stdout]    --> src/providers.rs:194:5
[INFO] [stdout]     |
[INFO] [stdout] 193 | pub struct Traverse {
[INFO] [stdout]     |            -------- field in this struct
[INFO] [stdout] 194 |     providers: Vec<Py<Provider>>,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods called `from_*` usually take no `self`
[INFO] [stdout]    --> src/containers.rs:523:20
[INFO] [stdout]     |
[INFO] [stdout] 523 |     fn from_schema(&mut self, py: Python, schema: Py<PyDict>) -> PyResult<()> {
[INFO] [stdout]     |                    ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider choosing a less ambiguous name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout]     = note: `#[warn(clippy::wrong_self_convention)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods called `from_*` usually take no `self`
[INFO] [stdout]    --> src/containers.rs:540:25
[INFO] [stdout]     |
[INFO] [stdout] 540 |     fn from_json_schema(&mut self, py: Python, filepath: &str) -> PyResult<()> {
[INFO] [stdout]     |                         ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider choosing a less ambiguous name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or_else` to construct default value
[INFO] [stdout]   --> src/containers.rs:42:30
[INFO] [stdout]    |
[INFO] [stdout] 42 |             modules: modules.unwrap_or_else(Vec::new),
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or_else` to construct default value
[INFO] [stdout]   --> src/containers.rs:43:32
[INFO] [stdout]    |
[INFO] [stdout] 43 |             packages: packages.unwrap_or_else(Vec::new),
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/containers.rs:579:12
[INFO] [stdout]     |
[INFO] [stdout] 579 |         if !provider.is_instance(&self.provider_type.bind(py)).is_ok() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `provider.is_instance(&self.provider_type.bind(py)).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/containers.rs:579:34
[INFO] [stdout]     |
[INFO] [stdout] 579 |         if !provider.is_instance(&self.provider_type.bind(py)).is_ok() {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.provider_type.bind(py)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/containers.rs:231:33
[INFO] [stdout]     |
[INFO] [stdout] 231 |         let providers: Vec<_> = self.providers.values().map(|p| p.clone()).collect();
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.providers.values().cloned()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/providers.rs:16:1
[INFO] [stdout]    |
[INFO] [stdout] 16 | / impl std::default::Default for Provider {
[INFO] [stdout] 17 | |     fn default() -> Self {
[INFO] [stdout] 18 | |         Self {
[INFO] [stdout] 19 | |             overridden: Vec::new(),
[INFO] [stdout] ...  |
[INFO] [stdout] 25 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute
[INFO] [stdout]    |
[INFO] [stdout]  8 + #[derive(Default)]
[INFO] [stdout]  9 | pub struct Provider {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods called `from_*` usually take no `self`
[INFO] [stdout]    --> src/containers.rs:523:20
[INFO] [stdout]     |
[INFO] [stdout] 523 |     fn from_schema(&mut self, py: Python, schema: Py<PyDict>) -> PyResult<()> {
[INFO] [stdout]     |                    ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider choosing a less ambiguous name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout]     = note: `#[warn(clippy::wrong_self_convention)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods called `from_*` usually take no `self`
[INFO] [stdout]    --> src/containers.rs:540:25
[INFO] [stdout]     |
[INFO] [stdout] 540 |     fn from_json_schema(&mut self, py: Python, filepath: &str) -> PyResult<()> {
[INFO] [stdout]     |                         ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider choosing a less ambiguous name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/providers.rs:218:9
[INFO] [stdout]     |
[INFO] [stdout] 218 |         return Ok(visiting);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 218 -         return Ok(visiting);
[INFO] [stdout] 218 +         Ok(visiting)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/containers.rs:579:12
[INFO] [stdout]     |
[INFO] [stdout] 579 |         if !provider.is_instance(&self.provider_type.bind(py)).is_ok() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `provider.is_instance(&self.provider_type.bind(py)).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/containers.rs:579:34
[INFO] [stdout]     |
[INFO] [stdout] 579 |         if !provider.is_instance(&self.provider_type.bind(py)).is_ok() {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.provider_type.bind(py)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/schema.rs:165:48
[INFO] [stdout]     |
[INFO] [stdout] 165 |             _ if _is_str_starts_with_container(&arg)? => {
[INFO] [stdout]     |                                                ^^^^ help: change this to: `arg`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/schema.rs:169:43
[INFO] [stdout]     |
[INFO] [stdout] 169 |             _ if PyDict::is_type_of_bound(&arg) => {
[INFO] [stdout]     |                                           ^^^^ help: change this to: `arg`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `segments.get(0)`
[INFO] [stdout]    --> src/schema.rs:193:56
[INFO] [stdout]     |
[INFO] [stdout] 193 |         let mut provider = self.container.getattr(py, *segments.get(0).unwrap())?;
[INFO] [stdout]     |                                                        ^^^^^^^^^^^^^^^ help: try: `segments.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/providers.rs:16:1
[INFO] [stdout]    |
[INFO] [stdout] 16 | / impl std::default::Default for Provider {
[INFO] [stdout] 17 | |     fn default() -> Self {
[INFO] [stdout] 18 | |         Self {
[INFO] [stdout] 19 | |             overridden: Vec::new(),
[INFO] [stdout] ...  |
[INFO] [stdout] 25 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute
[INFO] [stdout]    |
[INFO] [stdout]  8 + #[derive(Default)]
[INFO] [stdout]  9 | pub struct Provider {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/schema.rs:271:35
[INFO] [stdout]     |
[INFO] [stdout] 271 |     Ok(PyString::is_type_of_bound(&obj)
[INFO] [stdout]     |                                   ^^^^ help: change this to: `obj`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/providers.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |     py: Python,
[INFO] [stdout]     |         ^^^^^^ the lifetime is hidden here
[INFO] [stdout] ...
[INFO] [stdout] 170 | ) -> PyResult<Bound<'_, PyIterator>> {
[INFO] [stdout]     |                     ^^ the same lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'_`
[INFO] [stdout]     |
[INFO] [stdout] 167 |     py: Python<'_>,
[INFO] [stdout]     |               ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/providers.rs:218:9
[INFO] [stdout]     |
[INFO] [stdout] 218 |         return Ok(visiting);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 218 -         return Ok(visiting);
[INFO] [stdout] 218 +         Ok(visiting)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/schema.rs:165:48
[INFO] [stdout]     |
[INFO] [stdout] 165 |             _ if _is_str_starts_with_container(&arg)? => {
[INFO] [stdout]     |                                                ^^^^ help: change this to: `arg`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/schema.rs:169:43
[INFO] [stdout]     |
[INFO] [stdout] 169 |             _ if PyDict::is_type_of_bound(&arg) => {
[INFO] [stdout]     |                                           ^^^^ help: change this to: `arg`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `segments.get(0)`
[INFO] [stdout]    --> src/schema.rs:193:56
[INFO] [stdout]     |
[INFO] [stdout] 193 |         let mut provider = self.container.getattr(py, *segments.get(0).unwrap())?;
[INFO] [stdout]     |                                                        ^^^^^^^^^^^^^^^ help: try: `segments.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/schema.rs:271:35
[INFO] [stdout]     |
[INFO] [stdout] 271 |     Ok(PyString::is_type_of_bound(&obj)
[INFO] [stdout]     |                                   ^^^^ help: change this to: `obj`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/providers.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |     py: Python,
[INFO] [stdout]     |         ^^^^^^ the lifetime is hidden here
[INFO] [stdout] ...
[INFO] [stdout] 170 | ) -> PyResult<Bound<'_, PyIterator>> {
[INFO] [stdout]     |                     ^^ the same lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'_`
[INFO] [stdout]     |
[INFO] [stdout] 167 |     py: Python<'_>,
[INFO] [stdout]     |               ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.14s
[INFO] running `Command { std: "docker" "inspect" "3ce395e87de596e9936a7a8963dc7aa211b26bc8850b6b8779923a7bda1be539", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3ce395e87de596e9936a7a8963dc7aa211b26bc8850b6b8779923a7bda1be539", kill_on_drop: false }`
[INFO] [stdout] 3ce395e87de596e9936a7a8963dc7aa211b26bc8850b6b8779923a7bda1be539