[INFO] cloning repository https://github.com/grumyantsev/clifft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/grumyantsev/clifft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrumyantsev%2Fclifft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrumyantsev%2Fclifft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce2d0427b809df86b0bd47b5d60fc470a98a09e8 [INFO] linting grumyantsev/clifft against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrumyantsev%2Fclifft" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/grumyantsev/clifft [INFO] finished tweaking git repo https://github.com/grumyantsev/clifft [INFO] tweaked toml for git repo https://github.com/grumyantsev/clifft written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/grumyantsev/clifft on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/grumyantsev/clifft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 238728fdd70b9be3754f2652180cb7967755ebf850c833cf009cf02eff92b4d2 [INFO] running `Command { std: "docker" "start" "-a" "238728fdd70b9be3754f2652180cb7967755ebf850c833cf009cf02eff92b4d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "238728fdd70b9be3754f2652180cb7967755ebf850c833cf009cf02eff92b4d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "238728fdd70b9be3754f2652180cb7967755ebf850c833cf009cf02eff92b4d2", kill_on_drop: false }` [INFO] [stdout] 238728fdd70b9be3754f2652180cb7967755ebf850c833cf009cf02eff92b4d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3d5e0a0d4f917e8743118ca14e735ae4ac36bbd93c55a85fab1945347852274 [INFO] running `Command { std: "docker" "start" "-a" "f3d5e0a0d4f917e8743118ca14e735ae4ac36bbd93c55a85fab1945347852274", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking clifft v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/grade_iter.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | weight: weight, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/grade_iter.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | weight: weight, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grade_iter.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !self.subiter.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subiter.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.subiter` after checking its variant with `is_none` [INFO] [stdout] --> src/grade_iter.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 15 | if !self.subiter.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 16 | self.subiter.as_mut().unwrap().refresh(self.pos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 263 | *c = *c * I_POWERS[((idx & idx_mask).count_ones() % 4) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*c *= I_POWERS[((idx & idx_mask).count_ones() % 4) as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 270 | if (&m).len() == 1 { [INFO] [stdout] | ^^^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | let w = (&m).ncols(); [INFO] [stdout] | ^^^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | let h = (&m).nrows(); [INFO] [stdout] | ^^^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grade_iter.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !self.subiter.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subiter.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.subiter` after checking its variant with `is_none` [INFO] [stdout] --> src/grade_iter.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 15 | if !self.subiter.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 16 | self.subiter.as_mut().unwrap().refresh(self.pos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/grade_iter.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | assert!(check_arr[idx] == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!check_arr[idx]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 263 | *c = *c * I_POWERS[((idx & idx_mask).count_ones() % 4) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*c *= I_POWERS[((idx & idx_mask).count_ones() % 4) as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 270 | if (&m).len() == 1 { [INFO] [stdout] | ^^^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | let w = (&m).ncols(); [INFO] [stdout] | ^^^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | let h = (&m).nrows(); [INFO] [stdout] | ^^^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `reserve` immediately after creation [INFO] [stdout] --> tests/unit.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / let mut c = Vec::::new(); [INFO] [stdout] 80 | | c.reserve(n); [INFO] [stdout] | |_________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut c = Vec::with_capacity(n);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization [INFO] [stdout] = note: `#[warn(clippy::reserve_after_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> tests/unit.rs:106:29 [INFO] [stdout] | [INFO] [stdout] 106 | let expected_unit = (&cx).dot(&cx); [INFO] [stdout] | ^^^^^ help: change this to: `cx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.56s [INFO] running `Command { std: "docker" "inspect" "f3d5e0a0d4f917e8743118ca14e735ae4ac36bbd93c55a85fab1945347852274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3d5e0a0d4f917e8743118ca14e735ae4ac36bbd93c55a85fab1945347852274", kill_on_drop: false }` [INFO] [stdout] f3d5e0a0d4f917e8743118ca14e735ae4ac36bbd93c55a85fab1945347852274