[INFO] cloning repository https://github.com/grubertw/mandelbrot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/grubertw/mandelbrot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrubertw%2Fmandelbrot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrubertw%2Fmandelbrot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] db2986bb996b83d97ebf59e09ef442d45885cd77 [INFO] linting grubertw/mandelbrot against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrubertw%2Fmandelbrot" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/grubertw/mandelbrot [INFO] finished tweaking git repo https://github.com/grubertw/mandelbrot [INFO] tweaked toml for git repo https://github.com/grubertw/mandelbrot written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/grubertw/mandelbrot on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/grubertw/mandelbrot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded iced_winit v0.14.0 [INFO] [stderr] Downloaded iced_futures v0.14.0 [INFO] [stderr] Downloaded iced_program v0.14.0 [INFO] [stderr] Downloaded self_cell v1.2.1 [INFO] [stderr] Downloaded iced_runtime v0.14.0 [INFO] [stderr] Downloaded erased-serde v0.4.10 [INFO] [stderr] Downloaded android_system_properties v0.1.2 [INFO] [stderr] Downloaded window_clipboard v0.5.1 [INFO] [stderr] Downloaded iced_renderer v0.14.0 [INFO] [stderr] Downloaded iced_debug v0.14.0 [INFO] [stderr] Downloaded config v0.15.19 [INFO] [stderr] Downloaded iced_core v0.14.0 [INFO] [stderr] Downloaded iced_wgpu v0.14.0 [INFO] [stderr] Downloaded chrono v0.4.20 [INFO] [stderr] Downloaded yaml-rust2 v0.10.4 [INFO] [stderr] Downloaded lilt v0.8.1 [INFO] [stderr] Downloaded iced_widget v0.14.2 [INFO] [stderr] Downloaded rug v1.28.1 [INFO] [stderr] Downloaded cryoglyph v0.1.0 [INFO] [stderr] Downloaded iced_graphics v0.14.0 [INFO] [stderr] Downloaded harfrust v0.3.2 [INFO] [stderr] Downloaded profiling v1.0.6 [INFO] [stderr] Downloaded cosmic-text v0.15.0 [INFO] [stderr] Downloaded gmp-mpfr-sys v1.6.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] feee4dd5a59636054467b9868200d2b4af67addb93f8aa65483988ad68b4bab1 [INFO] running `Command { std: "docker" "start" "-a" "feee4dd5a59636054467b9868200d2b4af67addb93f8aa65483988ad68b4bab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "feee4dd5a59636054467b9868200d2b4af67addb93f8aa65483988ad68b4bab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feee4dd5a59636054467b9868200d2b4af67addb93f8aa65483988ad68b4bab1", kill_on_drop: false }` [INFO] [stdout] feee4dd5a59636054467b9868200d2b4af67addb93f8aa65483988ad68b4bab1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b38bd922207afe6ea7e74a08bfca35e867b8be36b849c25c21c9715fed159d97 [INFO] running `Command { std: "docker" "start" "-a" "b38bd922207afe6ea7e74a08bfca35e867b8be36b849c25c21c9715fed159d97", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling syn v2.0.109 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking lilt v0.8.1 [INFO] [stderr] Checking unicode-ident v1.0.22 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking zeno v0.3.3 [INFO] [stderr] Checking yazi v0.2.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling naga v27.0.3 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking wayland-sys v0.31.7 [INFO] [stderr] Checking linebender_resource_handle v0.1.1 [INFO] [stderr] Checking self_cell v1.2.1 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling wgpu-hal v27.0.4 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking profiling v1.0.6 [INFO] [stderr] Compiling pest v2.8.6 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Checking euclid v0.22.7 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Checking svg_fmt v0.4.1 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling erased-serde v0.4.10 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling gmp-mpfr-sys v1.6.8 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Checking toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking etagere v0.2.15 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Compiling rug v1.28.1 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking yaml-rust2 v0.10.4 [INFO] [stderr] Checking rust-ini v0.21.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking jiff v0.2.16 [INFO] [stderr] Checking fontdb v0.23.0 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking chrono v0.4.20 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Checking toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking toml v0.9.12+spec-1.1.0 [INFO] [stderr] Checking serde-untagged v0.1.9 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking iced_core v0.14.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking zerocopy v0.8.27 [INFO] [stderr] Checking font-types v0.10.1 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking read-fonts v0.35.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking clipboard_x11 v0.4.2 [INFO] [stderr] Checking iced_futures v0.14.0 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking ron v0.12.0 [INFO] [stderr] Checking iced_debug v0.14.0 [INFO] [stderr] Checking iced_runtime v0.14.0 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking config v0.15.19 [INFO] [stderr] Checking skrifa v0.37.0 [INFO] [stderr] Checking harfrust v0.3.2 [INFO] [stderr] Checking swash v0.2.6 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking cosmic-text v0.15.0 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking iced_graphics v0.14.0 [INFO] [stderr] Checking iced_renderer v0.14.0 [INFO] [stderr] Checking iced_program v0.14.0 [INFO] [stderr] Checking iced_widget v0.14.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking clipboard_wayland v0.2.2 [INFO] [stderr] Checking window_clipboard v0.5.1 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking iced_winit v0.14.0 [INFO] [stderr] Checking cryoglyph v0.1.0 [INFO] [stderr] Checking iced_wgpu v0.14.0 [INFO] [stderr] Checking mandelbrot v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/numerics.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use bytemuck; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/numerics.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use bytemuck; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ScoutEngineConfig` which implements the `Copy` trait [INFO] [stdout] --> src/controls.rs:460:34 [INFO] [stdout] | [INFO] [stdout] 460 | let mut config = scene_b.scout_config().lock().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*scene_b.scout_config().lock()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/controls.rs:461:47 [INFO] [stdout] | [INFO] [stdout] 461 | config.ref_iters_multiplier = if let Ok(v) = [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 462 | | self.ref_iters_multiplier.parse::() { v } else { 0.0 }; [INFO] [stdout] | |_______________________________________________________________________________^ help: replace with: `self.ref_iters_multiplier.parse::().unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/controls.rs:463:54 [INFO] [stdout] | [INFO] [stdout] 463 | config.num_seeds_to_spawn_per_eval = if let Ok(v) = [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 464 | | self.spawn_per_eval.parse::() { v } else { 0 }; [INFO] [stdout] | |_______________________________________________________________________^ help: ascribe the type u32 and replace your expression with: `self.spawn_per_eval.parse::().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/controls.rs:465:47 [INFO] [stdout] | [INFO] [stdout] 465 | config.num_qualified_orbits = if let Ok(v) = [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 466 | | self.num_qualified_orbits.parse::() { v } else { 0 }; [INFO] [stdout] | |_____________________________________________________________________________^ help: ascribe the type u32 and replace your expression with: `self.num_qualified_orbits.parse::().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scene.rs:160:18 [INFO] [stdout] | [INFO] [stdout] 160 | let gx = (self.max_screen_width + 15) / 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.max_screen_width.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scene.rs:161:18 [INFO] [stdout] | [INFO] [stdout] 161 | let gy = (self.max_screen_height + 15) / 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.max_screen_height.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `delta_c_pair` after checking its variant with `is_some` [INFO] [stdout] --> src/scene.rs:299:25 [INFO] [stdout] | [INFO] [stdout] 298 | if delta_c_pair.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = delta_c_pair` [INFO] [stdout] 299 | delta_c_pair.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DebugOut` which implements the `Copy` trait [INFO] [stdout] --> src/scene.rs:450:27 [INFO] [stdout] | [INFO] [stdout] 450 | let dbg = bytemuck::from_bytes::(&data[..]).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*bytemuck::from_bytes::(&data[..])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/scene.rs:631:49 [INFO] [stdout] | [INFO] [stdout] 631 | pub fn set_selected_palette(&mut self, key: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 631 ~ pub fn set_selected_palette(&mut self, key: &str) { [INFO] [stdout] 632 ~ self.selected_palette = key.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/scene.rs:762:41 [INFO] [stdout] | [INFO] [stdout] 762 | fn upload_orbits(&mut self, orbits: &Vec, queue: &wgpu::Queue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 762 - fn upload_orbits(&mut self, orbits: &Vec, queue: &wgpu::Queue) { [INFO] [stdout] 762 + fn upload_orbits(&mut self, orbits: &[QualifiedOrbit], queue: &wgpu::Queue) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scene.rs:763:12 [INFO] [stdout] | [INFO] [stdout] 763 | if orbits.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `orbits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scene.rs:770:12 [INFO] [stdout] | [INFO] [stdout] 770 | if orbits.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!orbits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scene.rs:790:12 [INFO] [stdout] | [INFO] [stdout] 790 | if self.loaded_orbits.len() > 0 && self.loaded_orbits.len() <= self.max_orbits_per_frame as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.loaded_orbits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/scene.rs:930:13 [INFO] [stdout] | [INFO] [stdout] 930 | orbits: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 930 - orbits: &Vec, [INFO] [stdout] 930 + orbits: &[QualifiedOrbit], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ScoutEngineConfig` which implements the `Copy` trait [INFO] [stdout] --> src/controls.rs:460:34 [INFO] [stdout] | [INFO] [stdout] 460 | let mut config = scene_b.scout_config().lock().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*scene_b.scout_config().lock()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/controls.rs:461:47 [INFO] [stdout] | [INFO] [stdout] 461 | config.ref_iters_multiplier = if let Ok(v) = [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 462 | | self.ref_iters_multiplier.parse::() { v } else { 0.0 }; [INFO] [stdout] | |_______________________________________________________________________________^ help: replace with: `self.ref_iters_multiplier.parse::().unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/controls.rs:463:54 [INFO] [stdout] | [INFO] [stdout] 463 | config.num_seeds_to_spawn_per_eval = if let Ok(v) = [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 464 | | self.spawn_per_eval.parse::() { v } else { 0 }; [INFO] [stdout] | |_______________________________________________________________________^ help: ascribe the type u32 and replace your expression with: `self.spawn_per_eval.parse::().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/controls.rs:465:47 [INFO] [stdout] | [INFO] [stdout] 465 | config.num_qualified_orbits = if let Ok(v) = [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 466 | | self.num_qualified_orbits.parse::() { v } else { 0 }; [INFO] [stdout] | |_____________________________________________________________________________^ help: ascribe the type u32 and replace your expression with: `self.num_qualified_orbits.parse::().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/numerics.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn to_float(&self, prec: u32) -> Float { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/numerics.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn to_complex(&self, prec: u32) -> Complex { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scene.rs:160:18 [INFO] [stdout] | [INFO] [stdout] 160 | let gx = (self.max_screen_width + 15) / 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.max_screen_width.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scene.rs:161:18 [INFO] [stdout] | [INFO] [stdout] 161 | let gy = (self.max_screen_height + 15) / 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.max_screen_height.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/scout_engine/orbit.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | let prec = *&c_ref.prec().0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `c_ref.prec().0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `delta_c_pair` after checking its variant with `is_some` [INFO] [stdout] --> src/scene.rs:299:25 [INFO] [stdout] | [INFO] [stdout] 298 | if delta_c_pair.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = delta_c_pair` [INFO] [stdout] 299 | delta_c_pair.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DebugOut` which implements the `Copy` trait [INFO] [stdout] --> src/scene.rs:450:27 [INFO] [stdout] | [INFO] [stdout] 450 | let dbg = bytemuck::from_bytes::(&data[..]).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*bytemuck::from_bytes::(&data[..])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TileId` which implements the `Copy` trait [INFO] [stdout] --> src/scout_engine/tile.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | id: tile_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*tile_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/scene.rs:631:49 [INFO] [stdout] | [INFO] [stdout] 631 | pub fn set_selected_palette(&mut self, key: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 631 ~ pub fn set_selected_palette(&mut self, key: &str) { [INFO] [stdout] 632 ~ self.selected_palette = key.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/scene.rs:762:41 [INFO] [stdout] | [INFO] [stdout] 762 | fn upload_orbits(&mut self, orbits: &Vec, queue: &wgpu::Queue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 762 - fn upload_orbits(&mut self, orbits: &Vec, queue: &wgpu::Queue) { [INFO] [stdout] 762 + fn upload_orbits(&mut self, orbits: &[QualifiedOrbit], queue: &wgpu::Queue) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scene.rs:763:12 [INFO] [stdout] | [INFO] [stdout] 763 | if orbits.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `orbits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scene.rs:770:12 [INFO] [stdout] | [INFO] [stdout] 770 | if orbits.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!orbits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scene.rs:790:12 [INFO] [stdout] | [INFO] [stdout] 790 | if self.loaded_orbits.len() > 0 && self.loaded_orbits.len() <= self.max_orbits_per_frame as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.loaded_orbits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FrameStamp` which implements the `Copy` trait [INFO] [stdout] --> src/scout_engine/worker.rs:248:39 [INFO] [stdout] | [INFO] [stdout] 248 | ... current_camera.frame_stamp().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*current_camera.frame_stamp()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/scene.rs:930:13 [INFO] [stdout] | [INFO] [stdout] 930 | orbits: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 930 - orbits: &Vec, [INFO] [stdout] 930 + orbits: &[QualifiedOrbit], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/scout_engine/tasks.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|c| ComplexDf::from_complex(c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ComplexDf::from_complex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 152 | &settings [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:158:42 [INFO] [stdout] | [INFO] [stdout] 158 | let controls = Controls::new(&settings, Rc::clone(&scene)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let MouseScrollDelta::LineDelta(_, h) = delta { [INFO] [stdout] 358 | | let new_scale = scene.borrow_mut().change_scale(if h > 0.0 {true} else {false}); [INFO] [stdout] 359 | | scene.borrow_mut().take_camera_snapshot(); [INFO] [stdout] ... | [INFO] [stdout] 362 | | h, new_scale); [INFO] [stdout] 363 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:356:39 [INFO] [stdout] | [INFO] [stdout] 356 | WindowEvent::MouseWheel { delta, .. } => { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 357 | if let MouseScrollDelta::LineDelta(_, h) = delta { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `delta: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:245:36 [INFO] [stdout] | [INFO] [stdout] 245 | ... s.draw(&device, &queue, &view); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 245 | ... s.draw(&device, &queue, &view); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:248:42 [INFO] [stdout] | [INFO] [stdout] 248 | ... s.read_debug(&device, &queue); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:248:51 [INFO] [stdout] | [INFO] [stdout] 248 | ... s.read_debug(&device, &queue); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:249:50 [INFO] [stdout] | [INFO] [stdout] 249 | ... s.read_grid_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:249:59 [INFO] [stdout] | [INFO] [stdout] 249 | ... s.read_grid_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:250:51 [INFO] [stdout] | [INFO] [stdout] 250 | ... s.read_orbit_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:250:60 [INFO] [stdout] | [INFO] [stdout] 250 | ... s.read_orbit_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:331:41 [INFO] [stdout] | [INFO] [stdout] 331 | ... let diff = ((position.x - prev_pos.0) as f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((position.x - prev_pos.0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:332:41 [INFO] [stdout] | [INFO] [stdout] 332 | ... (position.y - prev_pos.1) as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((position.y - prev_pos.1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:358:69 [INFO] [stdout] | [INFO] [stdout] 358 | let new_scale = scene.borrow_mut().change_scale(if h > 0.0 {true} else {false}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `h > 0.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return e; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return e; [INFO] [stdout] 485 + e [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/numerics.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn to_float(&self, prec: u32) -> Float { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/numerics.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn to_complex(&self, prec: u32) -> Complex { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/scout_engine/orbit.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | let prec = *&c_ref.prec().0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `c_ref.prec().0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TileId` which implements the `Copy` trait [INFO] [stdout] --> src/scout_engine/tile.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | id: tile_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*tile_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FrameStamp` which implements the `Copy` trait [INFO] [stdout] --> src/scout_engine/worker.rs:248:39 [INFO] [stdout] | [INFO] [stdout] 248 | ... current_camera.frame_stamp().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*current_camera.frame_stamp()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/scout_engine/tasks.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|c| ComplexDf::from_complex(c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ComplexDf::from_complex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 152 | &settings [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:158:42 [INFO] [stdout] | [INFO] [stdout] 158 | let controls = Controls::new(&settings, Rc::clone(&scene)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let MouseScrollDelta::LineDelta(_, h) = delta { [INFO] [stdout] 358 | | let new_scale = scene.borrow_mut().change_scale(if h > 0.0 {true} else {false}); [INFO] [stdout] 359 | | scene.borrow_mut().take_camera_snapshot(); [INFO] [stdout] ... | [INFO] [stdout] 362 | | h, new_scale); [INFO] [stdout] 363 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:356:39 [INFO] [stdout] | [INFO] [stdout] 356 | WindowEvent::MouseWheel { delta, .. } => { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 357 | if let MouseScrollDelta::LineDelta(_, h) = delta { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `delta: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:245:36 [INFO] [stdout] | [INFO] [stdout] 245 | ... s.draw(&device, &queue, &view); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 245 | ... s.draw(&device, &queue, &view); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:248:42 [INFO] [stdout] | [INFO] [stdout] 248 | ... s.read_debug(&device, &queue); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:248:51 [INFO] [stdout] | [INFO] [stdout] 248 | ... s.read_debug(&device, &queue); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:249:50 [INFO] [stdout] | [INFO] [stdout] 249 | ... s.read_grid_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:249:59 [INFO] [stdout] | [INFO] [stdout] 249 | ... s.read_grid_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:250:51 [INFO] [stdout] | [INFO] [stdout] 250 | ... s.read_orbit_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:250:60 [INFO] [stdout] | [INFO] [stdout] 250 | ... s.read_orbit_feedback(&device, &queue); [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:331:41 [INFO] [stdout] | [INFO] [stdout] 331 | ... let diff = ((position.x - prev_pos.0) as f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((position.x - prev_pos.0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:332:41 [INFO] [stdout] | [INFO] [stdout] 332 | ... (position.y - prev_pos.1) as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((position.y - prev_pos.1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:358:69 [INFO] [stdout] | [INFO] [stdout] 358 | let new_scale = scene.borrow_mut().change_scale(if h > 0.0 {true} else {false}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `h > 0.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return e; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return e; [INFO] [stdout] 485 + e [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 32s [INFO] running `Command { std: "docker" "inspect" "b38bd922207afe6ea7e74a08bfca35e867b8be36b849c25c21c9715fed159d97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b38bd922207afe6ea7e74a08bfca35e867b8be36b849c25c21c9715fed159d97", kill_on_drop: false }` [INFO] [stdout] b38bd922207afe6ea7e74a08bfca35e867b8be36b849c25c21c9715fed159d97