[INFO] cloning repository https://github.com/grimsteel/pass-secret-service [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/grimsteel/pass-secret-service" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrimsteel%2Fpass-secret-service", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrimsteel%2Fpass-secret-service'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b033a419b2fe644df5f8fa9de0a514398eb8428b [INFO] linting grimsteel/pass-secret-service against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgrimsteel%2Fpass-secret-service" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/grimsteel/pass-secret-service [INFO] finished tweaking git repo https://github.com/grimsteel/pass-secret-service [INFO] tweaked toml for git repo https://github.com/grimsteel/pass-secret-service written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/grimsteel/pass-secret-service on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/grimsteel/pass-secret-service already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded windows-collections v0.3.2 [INFO] [stderr] Downloaded async-process v2.2.3 [INFO] [stderr] Downloaded zvariant_utils v2.0.0 [INFO] [stderr] Downloaded windows-threading v0.2.1 [INFO] [stderr] Downloaded zvariant_derive v4.1.2 [INFO] [stderr] Downloaded windows-numerics v0.3.1 [INFO] [stderr] Downloaded windows-future v0.3.2 [INFO] [stderr] Downloaded zvariant v4.1.2 [INFO] [stderr] Downloaded bytes v1.6.1 [INFO] [stderr] Downloaded jiff-static v0.2.19 [INFO] [stderr] Downloaded cc v1.1.5 [INFO] [stderr] Downloaded zbus_macros v4.3.1 [INFO] [stderr] Downloaded ntapi v0.4.2 [INFO] [stderr] Downloaded redb v2.1.1 [INFO] [stderr] Downloaded zbus v4.3.1 [INFO] [stderr] Downloaded sysinfo v0.38.0 [INFO] [stderr] Downloaded objc2-io-kit v0.3.2 [INFO] [stderr] Downloaded jiff v0.2.19 [INFO] [stderr] Downloaded tokio v1.38.1 [INFO] [stderr] Downloaded windows v0.62.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6088fadba1322adc34b12b4e061f56bc085ac9938dde23a03d790f0fad9b0c19 [INFO] running `Command { std: "docker" "start" "-a" "6088fadba1322adc34b12b4e061f56bc085ac9938dde23a03d790f0fad9b0c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6088fadba1322adc34b12b4e061f56bc085ac9938dde23a03d790f0fad9b0c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6088fadba1322adc34b12b4e061f56bc085ac9938dde23a03d790f0fad9b0c19", kill_on_drop: false }` [INFO] [stdout] 6088fadba1322adc34b12b4e061f56bc085ac9938dde23a03d790f0fad9b0c19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69b1f57bf945bd20cfa835a6a0fa956eaf7f208c94cb4fd51ad9a14cf0f00654 [INFO] running `Command { std: "docker" "start" "-a" "69b1f57bf945bd20cfa835a6a0fa956eaf7f208c94cb4fd51ad9a14cf0f00654", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling argh_shared v0.1.13 [INFO] [stderr] Compiling redb v2.1.1 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking jiff v0.2.19 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking rust-fuzzy-search v0.1.1 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking xdg-home v1.2.0 [INFO] [stderr] Checking sysinfo v0.38.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking nanoid v0.4.0 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling zvariant_utils v2.0.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling zvariant_derive v4.1.2 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling argh_derive v0.1.13 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling zbus_macros v4.3.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking argh v0.1.13 [INFO] [stderr] Checking zvariant v4.1.2 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus v4.3.1 [INFO] [stderr] Checking pass-secret-service v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/dbus_server/service.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | pub const DEFAULT_COLLECTION_NAME: &'static str = "default"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/secret_store/redb.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | const ATTRIBUTES_DB: &'static str = "attributes.redb"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/secret_store/mod.rs:18:25 [INFO] [stdout] | [INFO] [stdout] 18 | pub const PASS_SUBDIR: &'static str = "secret-service"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 20 | const WELL_KNOWN_NAME: &'static str = "org.freedesktop.secrets"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | const BASE_PATH: &'static str = "/org/freedesktop/secrets"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/dbus_server/service.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | pub const DEFAULT_COLLECTION_NAME: &'static str = "default"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/secret_store/redb.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | const ATTRIBUTES_DB: &'static str = "attributes.redb"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/secret_store/mod.rs:18:25 [INFO] [stdout] | [INFO] [stdout] 18 | pub const PASS_SUBDIR: &'static str = "secret-service"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 20 | const WELL_KNOWN_NAME: &'static str = "org.freedesktop.secrets"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | const BASE_PATH: &'static str = "/org/freedesktop/secrets"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:138:47 [INFO] [stdout] | [INFO] [stdout] 138 | let secrets = self.store.list_secrets(&*self.id).await?; [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:230:33 [INFO] [stdout] | [INFO] [stdout] 230 | .set_secret(&*self.id, &*secret_id, secret_value) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:230:44 [INFO] [stdout] | [INFO] [stdout] 230 | .set_secret(&*self.id, &*secret_id, secret_value) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&secret_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:285:27 [INFO] [stdout] | [INFO] [stdout] 285 | .list_secrets(&*self.id) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 127 | .read_secret(&*self.collection_id, &*self.id, true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:127:48 [INFO] [stdout] | [INFO] [stdout] 127 | .read_secret(&*self.collection_id, &*self.id, true) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:138:47 [INFO] [stdout] | [INFO] [stdout] 138 | let secrets = self.store.list_secrets(&*self.id).await?; [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:230:33 [INFO] [stdout] | [INFO] [stdout] 230 | .set_secret(&*self.id, &*secret_id, secret_value) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:230:44 [INFO] [stdout] | [INFO] [stdout] 230 | .set_secret(&*self.id, &*secret_id, secret_value) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&secret_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/collection.rs:285:27 [INFO] [stdout] | [INFO] [stdout] 285 | .list_secrets(&*self.id) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:226:25 [INFO] [stdout] | [INFO] [stdout] 226 | .set_secret(&*self.collection_id, &*self.id, secret_value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:226:47 [INFO] [stdout] | [INFO] [stdout] 226 | .set_secret(&*self.collection_id, &*self.id, secret_value) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:291:26 [INFO] [stdout] | [INFO] [stdout] 291 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:291:48 [INFO] [stdout] | [INFO] [stdout] 291 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:300:26 [INFO] [stdout] | [INFO] [stdout] 300 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:300:48 [INFO] [stdout] | [INFO] [stdout] 300 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 127 | .read_secret(&*self.collection_id, &*self.id, true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:127:48 [INFO] [stdout] | [INFO] [stdout] 127 | .read_secret(&*self.collection_id, &*self.id, true) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:226:25 [INFO] [stdout] | [INFO] [stdout] 226 | .set_secret(&*self.collection_id, &*self.id, secret_value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:226:47 [INFO] [stdout] | [INFO] [stdout] 226 | .set_secret(&*self.collection_id, &*self.id, secret_value) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:48:42 [INFO] [stdout] | [INFO] [stdout] 48 | fn decrypt(&self, secret: Secret) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:49:68 [INFO] [stdout] | [INFO] [stdout] 49 | fn encrypt(&self, value: Vec, session: OwnedObjectPath) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:82:42 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(client_pub_key: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | (&*TWO) [INFO] [stdout] | ^^^^^^^ help: change this to: `(*TWO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | (&*TWO) [INFO] [stdout] | ^^^^^^^ help: try: `&TWO` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | .modpow(&self.server_priv, &*DH_SECOND_OAKLEY_PRIME) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&DH_SECOND_OAKLEY_PRIME` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | / Ok(Aes128CbcDec::new(&self.shared_key, &iv) [INFO] [stdout] 126 | | .decrypt_padded_vec_mut::(&secret.value[..]) [INFO] [stdout] 127 | | .map_err(|_| Error::EncryptionError("AES Unpad Error"))?) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 125 ~ Aes128CbcDec::new(&self.shared_key, &iv) [INFO] [stdout] 126 | .decrypt_padded_vec_mut::(&secret.value[..]) [INFO] [stdout] 127 ~ .map_err(|_| Error::EncryptionError("AES Unpad Error")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:291:26 [INFO] [stdout] | [INFO] [stdout] 291 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:125:48 [INFO] [stdout] | [INFO] [stdout] 125 | Ok(Aes128CbcDec::new(&self.shared_key, &iv) [INFO] [stdout] | ^^^ help: change this to: `iv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:291:48 [INFO] [stdout] | [INFO] [stdout] 291 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:300:26 [INFO] [stdout] | [INFO] [stdout] 300 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&self.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/item.rs:300:48 [INFO] [stdout] | [INFO] [stdout] 300 | .stat_secret(&*self.collection_id, &*self.id) [INFO] [stdout] | ^^^^^^^^^ help: try: `&self.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/service.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | .list_secrets(&*collection_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/dbus_server/service.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | let alias = if alias == "" { None } else { Some(alias) }; [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/service.rs:271:48 [INFO] [stdout] | [INFO] [stdout] 271 | ... get_collection_dir(&*item.get().await.collection_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&item.get().await.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/service.rs:279:69 [INFO] [stdout] | [INFO] [stdout] 279 | ... let collection_dir = get_collection_dir(&*collection.get().await.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&collection.get().await.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dbus_server/service.rs:391:55 [INFO] [stdout] | [INFO] [stdout] 391 | for secret in self.store.list_secrets(&id).await? { [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:48:42 [INFO] [stdout] | [INFO] [stdout] 48 | fn decrypt(&self, secret: Secret) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:49:68 [INFO] [stdout] | [INFO] [stdout] 49 | fn encrypt(&self, value: Vec, session: OwnedObjectPath) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:82:42 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(client_pub_key: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | (&*TWO) [INFO] [stdout] | ^^^^^^^ help: change this to: `(*TWO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | (&*TWO) [INFO] [stdout] | ^^^^^^^ help: try: `&TWO` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | .modpow(&self.server_priv, &*DH_SECOND_OAKLEY_PRIME) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&DH_SECOND_OAKLEY_PRIME` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | / Ok(Aes128CbcDec::new(&self.shared_key, &iv) [INFO] [stdout] 126 | | .decrypt_padded_vec_mut::(&secret.value[..]) [INFO] [stdout] 127 | | .map_err(|_| Error::EncryptionError("AES Unpad Error"))?) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 125 ~ Aes128CbcDec::new(&self.shared_key, &iv) [INFO] [stdout] 126 | .decrypt_padded_vec_mut::(&secret.value[..]) [INFO] [stdout] 127 ~ .map_err(|_| Error::EncryptionError("AES Unpad Error")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dbus_server/secret_transfer.rs:125:48 [INFO] [stdout] | [INFO] [stdout] 125 | Ok(Aes128CbcDec::new(&self.shared_key, &iv) [INFO] [stdout] | ^^^ help: change this to: `iv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/service.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | .list_secrets(&*collection_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/dbus_server/service.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | let alias = if alias == "" { None } else { Some(alias) }; [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/service.rs:271:48 [INFO] [stdout] | [INFO] [stdout] 271 | ... get_collection_dir(&*item.get().await.collection_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&item.get().await.collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/dbus_server/service.rs:279:69 [INFO] [stdout] | [INFO] [stdout] 279 | ... let collection_dir = get_collection_dir(&*collection.get().await.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&collection.get().await.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dbus_server/service.rs:391:55 [INFO] [stdout] | [INFO] [stdout] 391 | for secret in self.store.list_secrets(&id).await? { [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/session.rs:68:67 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn decrypt(&self, secret: Secret, header: &Header<'_>) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dbus_server/session.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | if !header.sender().is_some_and(|s| self.client_name == *s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.sender().is_none_or(|s| self.client_name != *s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/session.rs:77:68 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn encrypt(&self, secret: Vec, header: &Header<'_>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dbus_server/session.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !header.sender().is_some_and(|s| self.client_name == *s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.sender().is_none_or(|s| self.client_name != *s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | IoError(#[from] io::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | DbusError(#[from] zbus::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | EncryptionError(&'static str), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | GpgError(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/error.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] ... [INFO] [stdout] 83 | fn into_result(self) -> Result; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/error.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] ... [INFO] [stdout] 93 | fn into_not_found(self) -> Result; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pass.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn from_env(password_store_dir: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pass.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return Err(Error::NotInitialized); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return Err(Error::NotInitialized); [INFO] [stdout] 141 + Err(Error::NotInitialized) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/pass.rs:237:14 [INFO] [stdout] | [INFO] [stdout] 237 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/pass.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | / let Some(item_type) = line.nth(0) else { [INFO] [stdout] 329 | | return None; [INFO] [stdout] 330 | | }; [INFO] [stdout] | |__________________^ help: replace it with: `let item_type = line.nth(0)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/session.rs:68:67 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn decrypt(&self, secret: Secret, header: &Header<'_>) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dbus_server/session.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | if !header.sender().is_some_and(|s| self.client_name == *s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.sender().is_none_or(|s| self.client_name != *s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/pass.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | / let Some(keygrip) = line.nth(8) else { [INFO] [stdout] 339 | | return None; [INFO] [stdout] 340 | | }; [INFO] [stdout] | |__________________^ help: replace it with: `let keygrip = line.nth(8)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/dbus_server/session.rs:77:68 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn encrypt(&self, secret: Vec, header: &Header<'_>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dbus_server/session.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !header.sender().is_some_and(|s| self.client_name == *s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.sender().is_none_or(|s| self.client_name != *s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/secret_store/redb.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | .map_err(|e| Into::::into(e))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `Into::::into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/secret_store/redb.rs:45:77 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn search_collection(attrs: &HashMap, db: &Database) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/secret_store/redb.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if attrs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `attrs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` [INFO] [stdout] --> src/secret_store/redb.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 55 | let mut attr_iter = attrs.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|r| -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:109:30 [INFO] [stdout] | [INFO] [stdout] 109 | let db = open_db(&pass, db_path).await?; [INFO] [stdout] | ^^^^^ help: change this to: `pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | IoError(#[from] io::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | DbusError(#[from] zbus::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 122 | let db = open_db(&pass, &format!("{PASS_SUBDIR}/collections.redb")).await?; [INFO] [stdout] | ^^^^^ help: change this to: `pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | EncryptionError(&'static str), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | GpgError(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 139 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 140 | | let tx = db.begin_read().into_result()?; [INFO] [stdout] 141 | | let table = raise_nonexistent_table!(tx.open_table(LABELS_TABLE)); [INFO] [stdout] 142 | | let label = table [INFO] [stdout] ... | [INFO] [stdout] 147 | | Ok(label.value().to_owned()) [INFO] [stdout] 148 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | Ok(spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/error.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] ... [INFO] [stdout] 83 | fn into_result(self) -> Result; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/error.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] ... [INFO] [stdout] 93 | fn into_not_found(self) -> Result; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pass.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn from_env(password_store_dir: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:170:38 [INFO] [stdout] | [INFO] [stdout] 170 | Ok(spawn_blocking(move || -> Result<_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:180:22 [INFO] [stdout] | [INFO] [stdout] 180 | .map(|i| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 181 | | let (target, aliases) = i?; [INFO] [stdout] 182 | | let aliases = aliases [INFO] [stdout] 183 | | .map(|a| RedbResult::Ok(a?.value().to_owned())) [INFO] [stdout] 184 | | .collect::>>()?; [INFO] [stdout] 185 | | Ok((target.value().to_owned(), aliases)) [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________________^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:183:30 [INFO] [stdout] | [INFO] [stdout] 183 | .map(|a| RedbResult::Ok(a?.value().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pass.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return Err(Error::NotInitialized); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return Err(Error::NotInitialized); [INFO] [stdout] 141 + Err(Error::NotInitialized) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:196:35 [INFO] [stdout] | [INFO] [stdout] 196 | spawn_blocking(move || -> Result<_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | .map(|el| Ok(el?.value().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 215 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 216 | | // open the aliases table [INFO] [stdout] 217 | | let tx = db.begin_read().into_result()?; [INFO] [stdout] 218 | | let table = raise_nonexistent_table!(tx.open_table(ALIASES_TABLE)); [INFO] [stdout] ... | [INFO] [stdout] 225 | | Ok(target) [INFO] [stdout] 226 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:233:38 [INFO] [stdout] | [INFO] [stdout] 233 | Ok(spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:282:55 [INFO] [stdout] | [INFO] [stdout] 282 | let collection_id = spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/pass.rs:237:14 [INFO] [stdout] | [INFO] [stdout] 237 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:356:30 [INFO] [stdout] | [INFO] [stdout] 356 | let db = open_db(&self.pass, collection_path).await?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/pass.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | / let Some(item_type) = line.nth(0) else { [INFO] [stdout] 329 | | return None; [INFO] [stdout] 330 | | }; [INFO] [stdout] | |__________________^ help: replace it with: `let item_type = line.nth(0)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/pass.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | / let Some(keygrip) = line.nth(8) else { [INFO] [stdout] 339 | | return None; [INFO] [stdout] 340 | | }; [INFO] [stdout] | |__________________^ help: replace it with: `let keygrip = line.nth(8)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:375:35 [INFO] [stdout] | [INFO] [stdout] 375 | spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/secret_store/redb.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | .map_err(|e| Into::::into(e))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `Into::::into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:411:35 [INFO] [stdout] | [INFO] [stdout] 411 | spawn_blocking(move || -> Result<_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/secret_store/redb.rs:45:77 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn search_collection(attrs: &HashMap, db: &Database) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:414:22 [INFO] [stdout] | [INFO] [stdout] 414 | .map(|(id, db)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 415 | | // search each collection [INFO] [stdout] 416 | | Ok((id.to_owned(), search_collection(&attributes, db)?)) [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/secret_store/redb.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if attrs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `attrs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` [INFO] [stdout] --> src/secret_store/redb.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 55 | let mut attr_iter = attrs.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:431:24 [INFO] [stdout] | [INFO] [stdout] 431 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 432 | | let cols = collections.blocking_read(); [INFO] [stdout] 433 | | let db = cols.get(collection_id.as_ref()).into_not_found()?; [INFO] [stdout] 434 | | Ok(search_collection(&attributes, db)?) [INFO] [stdout] 435 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|r| -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/secret_store/redb.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | Ok(search_collection(&attributes, db)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 434 - Ok(search_collection(&attributes, db)?) [INFO] [stdout] 434 + search_collection(&attributes, db) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/secret_store/redb.rs:444:19 [INFO] [stdout] | [INFO] [stdout] 444 | .join(&collection_id) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/secret_store/redb.rs:450:59 [INFO] [stdout] | [INFO] [stdout] 450 | let collection_path = Path::new(PASS_SUBDIR).join(&collection_id); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:109:30 [INFO] [stdout] | [INFO] [stdout] 109 | let db = open_db(&pass, db_path).await?; [INFO] [stdout] | ^^^^^ help: change this to: `pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 122 | let db = open_db(&pass, &format!("{PASS_SUBDIR}/collections.redb")).await?; [INFO] [stdout] | ^^^^^ help: change this to: `pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:490:24 [INFO] [stdout] | [INFO] [stdout] 490 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 491 | | let cols = collections.blocking_read(); [INFO] [stdout] 492 | | let db = cols.get(&*collection_id).into_not_found()?; [INFO] [stdout] 493 | | let tx = db.begin_read().into_result()?; [INFO] [stdout] ... | [INFO] [stdout] 507 | | .collect()) [INFO] [stdout] 508 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 139 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 140 | | let tx = db.begin_read().into_result()?; [INFO] [stdout] 141 | | let table = raise_nonexistent_table!(tx.open_table(LABELS_TABLE)); [INFO] [stdout] 142 | | let label = table [INFO] [stdout] ... | [INFO] [stdout] 147 | | Ok(label.value().to_owned()) [INFO] [stdout] 148 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:524:35 [INFO] [stdout] | [INFO] [stdout] 524 | spawn_blocking(move || -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | Ok(spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:170:38 [INFO] [stdout] | [INFO] [stdout] 170 | Ok(spawn_blocking(move || -> Result<_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/secret_store/redb.rs:561:19 [INFO] [stdout] | [INFO] [stdout] 561 | .join(&format!("{secret_id}.gpg")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{secret_id}.gpg")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:578:38 [INFO] [stdout] | [INFO] [stdout] 578 | format!("{}_{}", slugify(&label), nanoid!(4, &NANOID_ALPHABET)) [INFO] [stdout] | ^^^^^^ help: change this to: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:180:22 [INFO] [stdout] | [INFO] [stdout] 180 | .map(|i| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 181 | | let (target, aliases) = i?; [INFO] [stdout] 182 | | let aliases = aliases [INFO] [stdout] 183 | | .map(|a| RedbResult::Ok(a?.value().to_owned())) [INFO] [stdout] 184 | | .collect::>>()?; [INFO] [stdout] 185 | | Ok((target.value().to_owned(), aliases)) [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________________^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:183:30 [INFO] [stdout] | [INFO] [stdout] 183 | .map(|a| RedbResult::Ok(a?.value().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:196:35 [INFO] [stdout] | [INFO] [stdout] 196 | spawn_blocking(move || -> Result<_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:590:24 [INFO] [stdout] | [INFO] [stdout] 590 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 591 | | let cols = collections.blocking_read(); [INFO] [stdout] ... | [INFO] [stdout] 629 | | Ok(secret_id) [INFO] [stdout] 630 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | .map(|el| Ok(el?.value().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 215 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 216 | | // open the aliases table [INFO] [stdout] 217 | | let tx = db.begin_read().into_result()?; [INFO] [stdout] 218 | | let table = raise_nonexistent_table!(tx.open_table(ALIASES_TABLE)); [INFO] [stdout] ... | [INFO] [stdout] 225 | | Ok(target) [INFO] [stdout] 226 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:233:38 [INFO] [stdout] | [INFO] [stdout] 233 | Ok(spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:654:24 [INFO] [stdout] | [INFO] [stdout] 654 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 655 | | let cols = collections.blocking_read(); [INFO] [stdout] ... | [INFO] [stdout] 670 | | Ok(()) [INFO] [stdout] 671 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:682:24 [INFO] [stdout] | [INFO] [stdout] 682 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 683 | | let cols = collections.blocking_read(); [INFO] [stdout] ... | [INFO] [stdout] 698 | | Ok(label) [INFO] [stdout] 699 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:282:55 [INFO] [stdout] | [INFO] [stdout] 282 | let collection_id = spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:712:24 [INFO] [stdout] | [INFO] [stdout] 712 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 713 | | let cols = collections.blocking_read(); [INFO] [stdout] 714 | | let db = cols.get(&*collection_id).into_not_found()?; [INFO] [stdout] 715 | | let tx = db.begin_write().into_result()?; [INFO] [stdout] ... | [INFO] [stdout] 749 | | Ok(()) [INFO] [stdout] 750 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:356:30 [INFO] [stdout] | [INFO] [stdout] 356 | let db = open_db(&self.pass, collection_path).await?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:375:35 [INFO] [stdout] | [INFO] [stdout] 375 | spawn_blocking(move || -> RedbResult<_> { [INFO] [stdout] | ^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `redb::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:411:35 [INFO] [stdout] | [INFO] [stdout] 411 | spawn_blocking(move || -> Result<_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:414:22 [INFO] [stdout] | [INFO] [stdout] 414 | .map(|(id, db)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 415 | | // search each collection [INFO] [stdout] 416 | | Ok((id.to_owned(), search_collection(&attributes, db)?)) [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:431:24 [INFO] [stdout] | [INFO] [stdout] 431 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 432 | | let cols = collections.blocking_read(); [INFO] [stdout] 433 | | let db = cols.get(collection_id.as_ref()).into_not_found()?; [INFO] [stdout] 434 | | Ok(search_collection(&attributes, db)?) [INFO] [stdout] 435 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/secret_store/redb.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | Ok(search_collection(&attributes, db)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 434 - Ok(search_collection(&attributes, db)?) [INFO] [stdout] 434 + search_collection(&attributes, db) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` [INFO] [stdout] --> src/secret_store/redb_imps.rs:136:29 [INFO] [stdout] | [INFO] [stdout] 136 | for (k, v) in value.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/secret_store/redb.rs:444:19 [INFO] [stdout] | [INFO] [stdout] 444 | .join(&collection_id) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/secret_store/redb.rs:450:59 [INFO] [stdout] | [INFO] [stdout] 450 | let collection_path = Path::new(PASS_SUBDIR).join(&collection_id); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `collection_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:490:24 [INFO] [stdout] | [INFO] [stdout] 490 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 491 | | let cols = collections.blocking_read(); [INFO] [stdout] 492 | | let db = cols.get(&*collection_id).into_not_found()?; [INFO] [stdout] 493 | | let tx = db.begin_read().into_result()?; [INFO] [stdout] ... | [INFO] [stdout] 507 | | .collect()) [INFO] [stdout] 508 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:524:35 [INFO] [stdout] | [INFO] [stdout] 524 | spawn_blocking(move || -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/secret_store/redb.rs:561:19 [INFO] [stdout] | [INFO] [stdout] 561 | .join(&format!("{secret_id}.gpg")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{secret_id}.gpg")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/secret_store/redb.rs:578:38 [INFO] [stdout] | [INFO] [stdout] 578 | format!("{}_{}", slugify(&label), nanoid!(4, &NANOID_ALPHABET)) [INFO] [stdout] | ^^^^^^ help: change this to: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:590:24 [INFO] [stdout] | [INFO] [stdout] 590 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 591 | | let cols = collections.blocking_read(); [INFO] [stdout] ... | [INFO] [stdout] 629 | | Ok(secret_id) [INFO] [stdout] 630 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:654:24 [INFO] [stdout] | [INFO] [stdout] 654 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 655 | | let cols = collections.blocking_read(); [INFO] [stdout] ... | [INFO] [stdout] 670 | | Ok(()) [INFO] [stdout] 671 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:682:24 [INFO] [stdout] | [INFO] [stdout] 682 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 683 | | let cols = collections.blocking_read(); [INFO] [stdout] ... | [INFO] [stdout] 698 | | Ok(label) [INFO] [stdout] 699 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/secret_store/redb.rs:712:24 [INFO] [stdout] | [INFO] [stdout] 712 | spawn_blocking(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 713 | | let cols = collections.blocking_read(); [INFO] [stdout] 714 | | let db = cols.get(&*collection_id).into_not_found()?; [INFO] [stdout] 715 | | let tx = db.begin_write().into_result()?; [INFO] [stdout] ... | [INFO] [stdout] 749 | | Ok(()) [INFO] [stdout] 750 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | RedbError(#[from] redb::Error), [INFO] [stdout] | ------------------------------ the largest variant contains at least 144 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` [INFO] [stdout] --> src/secret_store/redb_imps.rs:136:29 [INFO] [stdout] | [INFO] [stdout] 136 | for (k, v) in value.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 47.10s [INFO] running `Command { std: "docker" "inspect" "69b1f57bf945bd20cfa835a6a0fa956eaf7f208c94cb4fd51ad9a14cf0f00654", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69b1f57bf945bd20cfa835a6a0fa956eaf7f208c94cb4fd51ad9a14cf0f00654", kill_on_drop: false }` [INFO] [stdout] 69b1f57bf945bd20cfa835a6a0fa956eaf7f208c94cb4fd51ad9a14cf0f00654