[INFO] cloning repository https://github.com/gowrizrh/northstar
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gowrizrh/northstar" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgowrizrh%2Fnorthstar", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgowrizrh%2Fnorthstar'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 2aa4b85cdc82dda8ee3726555115ded8f0ff01bd
[INFO] linting gowrizrh/northstar against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgowrizrh%2Fnorthstar" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/gowrizrh/northstar
[INFO] finished tweaking git repo https://github.com/gowrizrh/northstar
[INFO] tweaked toml for git repo https://github.com/gowrizrh/northstar written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/gowrizrh/northstar on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/gowrizrh/northstar already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 83482359ee0a1359341e20b863370b2e08e8eb6d4cb25372ffcbe3494795b4e3
[INFO] running `Command { std: "docker" "start" "-a" "83482359ee0a1359341e20b863370b2e08e8eb6d4cb25372ffcbe3494795b4e3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "83482359ee0a1359341e20b863370b2e08e8eb6d4cb25372ffcbe3494795b4e3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "83482359ee0a1359341e20b863370b2e08e8eb6d4cb25372ffcbe3494795b4e3", kill_on_drop: false }`
[INFO] [stdout] 83482359ee0a1359341e20b863370b2e08e8eb6d4cb25372ffcbe3494795b4e3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 085a8e1feb4f852a16871ef2941a287005a2cf9b667312c291a58e5689ea2a62
[INFO] running `Command { std: "docker" "start" "-a" "085a8e1feb4f852a16871ef2941a287005a2cf9b667312c291a58e5689ea2a62", kill_on_drop: false }`
[INFO] [stderr]     Checking northstar v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded unit expression
[INFO] [stdout]   --> src/core/path_finder.rs:54:25
[INFO] [stdout]    |
[INFO] [stdout] 54 |                         ()
[INFO] [stdout]    |                         ^^ help: remove the final `()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit expression
[INFO] [stdout]   --> src/core/path_finder.rs:54:25
[INFO] [stdout]    |
[INFO] [stdout] 54 |                         ()
[INFO] [stdout]    |                         ^^ help: remove the final `()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `print` is never used
[INFO] [stdout]   --> src/core/map.rs:12:12
[INFO] [stdout]    |
[INFO] [stdout]  7 | impl Map {
[INFO] [stdout]    | -------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 12 |     pub fn print(&self) -> () {
[INFO] [stdout]    |            ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/core/heap.rs:31:9
[INFO] [stdout]    |
[INFO] [stdout] 31 | /         match result {
[INFO] [stdout] 32 | |             Some(item) => {
[INFO] [stdout] 33 | |                 self.set.remove(&item);
[INFO] [stdout] 34 | |             },
[INFO] [stdout] 35 | |             None => ()
[INFO] [stdout] 36 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 31 ~         if let Some(item) = result {
[INFO] [stdout] 32 +             self.set.remove(&item);
[INFO] [stdout] 33 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/core/heap.rs:62:9
[INFO] [stdout]    |
[INFO] [stdout] 62 |         assert_eq!(true, heap.contains(3));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 62 -         assert_eq!(true, heap.contains(3));
[INFO] [stdout] 62 +         assert!(heap.contains(3));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/core/heap.rs:68:9
[INFO] [stdout]    |
[INFO] [stdout] 68 |         assert_eq!(false, heap.contains(3));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 68 -         assert_eq!(false, heap.contains(3));
[INFO] [stdout] 68 +         assert!(!heap.contains(3));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/core/heap.rs:72:9
[INFO] [stdout]    |
[INFO] [stdout] 72 |         assert_eq!(false, heap.contains(2));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 72 -         assert_eq!(false, heap.contains(2));
[INFO] [stdout] 72 +         assert!(!heap.contains(2));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/core/heap.rs:73:9
[INFO] [stdout]    |
[INFO] [stdout] 73 |         assert_eq!(true, heap.contains(1));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 73 -         assert_eq!(true, heap.contains(1));
[INFO] [stdout] 73 +         assert!(heap.contains(1));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `print` is never used
[INFO] [stdout]   --> src/core/map.rs:12:12
[INFO] [stdout]    |
[INFO] [stdout]  7 | impl Map {
[INFO] [stdout]    | -------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 12 |     pub fn print(&self) -> () {
[INFO] [stdout]    |            ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: mutable key type
[INFO] [stdout]    --> src/core/location.rs:147:9
[INFO] [stdout]     |
[INFO] [stdout] 147 |         let mut closed: HashSet<&Location> = HashSet::new();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: ... because it contains `&Location`, which has interior mutability
[INFO] [stdout]     = note: ... because it contains `Location`, which has interior mutability
[INFO] [stdout]     = note: ... because it contains `Cell<i64>`, which has interior mutability
[INFO] [stdout]     = note: ... because it contains `UnsafeCell<i64>`, which has interior mutability
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
[INFO] [stdout]     = note: `#[warn(clippy::mutable_key_type)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/core/heap.rs:31:9
[INFO] [stdout]    |
[INFO] [stdout] 31 | /         match result {
[INFO] [stdout] 32 | |             Some(item) => {
[INFO] [stdout] 33 | |                 self.set.remove(&item);
[INFO] [stdout] 34 | |             },
[INFO] [stdout] 35 | |             None => ()
[INFO] [stdout] 36 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 31 ~         if let Some(item) = result {
[INFO] [stdout] 32 +             self.set.remove(&item);
[INFO] [stdout] 33 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/core/location.rs:230:17
[INFO] [stdout]     |
[INFO] [stdout] 230 |         assert!(!(origin < origin_duplicate));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(origin >= origin_duplicate)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/core/location.rs:231:17
[INFO] [stdout]     |
[INFO] [stdout] 231 |         assert!(!(origin > origin_duplicate));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(origin <= origin_duplicate)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/core/map.rs:12:24
[INFO] [stdout]    |
[INFO] [stdout] 12 |     pub fn print(&self) -> () {
[INFO] [stdout]    |                        ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/core/map.rs:12:24
[INFO] [stdout]    |
[INFO] [stdout] 12 |     pub fn print(&self) -> () {
[INFO] [stdout]    |                        ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/core/map.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         return self.cells.len();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 50 -         return self.cells.len();
[INFO] [stdout] 50 +         self.cells.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/core/map.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         return self.cells[current_row].len();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 55 -         return self.cells[current_row].len();
[INFO] [stdout] 55 +         self.cells[current_row].len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: mutable key type
[INFO] [stdout]   --> src/core/path_finder.rs:32:9
[INFO] [stdout]    |
[INFO] [stdout] 32 |         let mut closed: HashSet<&Location> = HashSet::new();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: ... because it contains `&Location`, which has interior mutability
[INFO] [stdout]    = note: ... because it contains `Location`, which has interior mutability
[INFO] [stdout]    = note: ... because it contains `Cell<i64>`, which has interior mutability
[INFO] [stdout]    = note: ... because it contains `UnsafeCell<i64>`, which has interior mutability
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/core/map.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         return self.cells.len();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 50 -         return self.cells.len();
[INFO] [stdout] 50 +         self.cells.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/core/map.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         return self.cells[current_row].len();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 55 -         return self.cells[current_row].len();
[INFO] [stdout] 55 +         self.cells[current_row].len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: mutable key type
[INFO] [stdout]   --> src/core/path_finder.rs:32:9
[INFO] [stdout]    |
[INFO] [stdout] 32 |         let mut closed: HashSet<&Location> = HashSet::new();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: ... because it contains `&Location`, which has interior mutability
[INFO] [stdout]    = note: ... because it contains `Location`, which has interior mutability
[INFO] [stdout]    = note: ... because it contains `Cell<i64>`, which has interior mutability
[INFO] [stdout]    = note: ... because it contains `UnsafeCell<i64>`, which has interior mutability
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
[INFO] [stdout]    = note: `#[warn(clippy::mutable_key_type)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s
[INFO] running `Command { std: "docker" "inspect" "085a8e1feb4f852a16871ef2941a287005a2cf9b667312c291a58e5689ea2a62", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "085a8e1feb4f852a16871ef2941a287005a2cf9b667312c291a58e5689ea2a62", kill_on_drop: false }`
[INFO] [stdout] 085a8e1feb4f852a16871ef2941a287005a2cf9b667312c291a58e5689ea2a62