[INFO] cloning repository https://github.com/gostonefire/mygrid [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gostonefire/mygrid" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgostonefire%2Fmygrid", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgostonefire%2Fmygrid'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b01a12f98ccd67a819860742cd1c804a937eeb30 [INFO] linting gostonefire/mygrid against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgostonefire%2Fmygrid" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gostonefire/mygrid [INFO] finished tweaking git repo https://github.com/gostonefire/mygrid [INFO] tweaked toml for git repo https://github.com/gostonefire/mygrid written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gostonefire/mygrid on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gostonefire/mygrid already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded email_address v0.2.9 [INFO] [stderr] Downloaded quoted_printable v0.5.1 [INFO] [stderr] Downloaded thread-id v5.1.0 [INFO] [stderr] Downloaded email-encoding v0.4.1 [INFO] [stderr] Downloaded psm v0.1.30 [INFO] [stderr] Downloaded tempfile v3.26.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.40 [INFO] [stderr] Downloaded foxess v1.0.0 [INFO] [stderr] Downloaded stacker v0.1.23 [INFO] [stderr] Downloaded lettre v0.11.19 [INFO] [stderr] Downloaded arc-swap v1.8.2 [INFO] [stderr] Downloaded zerocopy v0.8.40 [INFO] [stderr] Downloaded chumsky v0.9.3 [INFO] [stderr] Downloaded ar_archive_writer v0.5.1 [INFO] [stderr] Downloaded aws-lc-rs v1.16.0 [INFO] [stderr] Downloaded aws-lc-sys v0.37.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b40eae2d3fe8b37597fd1c2d16de2a05849f1b1ebb3f5d62204a8dcd5e809ed [INFO] running `Command { std: "docker" "start" "-a" "2b40eae2d3fe8b37597fd1c2d16de2a05849f1b1ebb3f5d62204a8dcd5e809ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b40eae2d3fe8b37597fd1c2d16de2a05849f1b1ebb3f5d62204a8dcd5e809ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b40eae2d3fe8b37597fd1c2d16de2a05849f1b1ebb3f5d62204a8dcd5e809ed", kill_on_drop: false }` [INFO] [stdout] 2b40eae2d3fe8b37597fd1c2d16de2a05849f1b1ebb3f5d62204a8dcd5e809ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d56a55f61c0c8326704ec33e9969a8efca377071f85bcac4f8b7534fdea4ecfb [INFO] running `Command { std: "docker" "start" "-a" "d56a55f61c0c8326704ec33e9969a8efca377071f85bcac4f8b7534fdea4ecfb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking thread-id v5.1.0 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling stacker v0.1.23 [INFO] [stderr] Checking hostname v0.4.2 [INFO] [stderr] Checking arc-swap v1.8.2 [INFO] [stderr] Checking toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking email-encoding v0.4.1 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling ar_archive_writer v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking quoted_printable v0.5.1 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Checking email_address v0.2.9 [INFO] [stderr] Checking mock_instant v0.6.0 [INFO] [stderr] Compiling psm v0.1.30 [INFO] [stderr] Checking toml v1.0.3+spec-1.1.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking log4rs v1.4.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking lettre v0.11.19 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking foxess v1.0.0 [INFO] [stderr] Checking mygrid v4.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/initialization.rs:33:34 [INFO] [stdout] | [INFO] [stdout] 33 | let mut config = load_config(&config_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `config_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/initialization.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let _ = setup_logger(&config.general.log_path, config.general.log_level, config.general.log_to_stdout)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 41 - let _ = setup_logger(&config.general.log_path, config.general.log_level, config.general.log_to_stdout)?; [INFO] [stdout] 41 + setup_logger(&config.general.log_path, config.general.log_level, config.general.log_to_stdout)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/manual_worker.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / if let Some(block_id) = active_block { [INFO] [stdout] 47 | | if schedule.is_active_charging(block_id, utc_now) [INFO] [stdout] 48 | | { [INFO] [stdout] 49 | | let block: &mut Block = schedule.get_block_by_id(block_id).ok_or(WorkerError::Other("Active block not found"))?; [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Some(block_id) = active_block [INFO] [stdout] 47 ~ && schedule.is_active_charging(block_id, utc_now) [INFO] [stdout] 48 | { [INFO] [stdout] ... [INFO] [stdout] 57 | } [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/manual_worker.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let status: Status; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `status` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 | let soc = get_current_soc(&mgr.fox)?; [INFO] [stdout] 89 ~ let status: Status = match block.block_type { [INFO] [stdout] 90 | BlockType::Charge => { [INFO] [stdout] 91 ~ set_charge(&mgr.fox, soc, block, utc_now).map_err(|e| { [INFO] [stdout] 92 | WorkerError::SetCharge(e.to_string()) [INFO] [stdout] 93 ~ })? [INFO] [stdout] 94 | }, [INFO] [stdout] 95 | [INFO] [stdout] 96 | BlockType::Hold => { [INFO] [stdout] 97 ~ set_hold(&mgr.fox, soc, block.soc_in as u8).map_err(|e| { [INFO] [stdout] 98 | WorkerError::SetHold(e.to_string()) [INFO] [stdout] 99 ~ })? [INFO] [stdout] 100 | }, [INFO] [stdout] 101 | [INFO] [stdout] 102 | BlockType::Use => { [INFO] [stdout] 103 ~ set_use(&mgr.fox).map_err(|e| { [INFO] [stdout] 104 | WorkerError::SetUse(e.to_string()) [INFO] [stdout] 105 ~ })? [INFO] [stdout] 106 | }, [INFO] [stdout] 107 | [INFO] [stdout] 108 ~ BlockType::Unknown => Status::Error, [INFO] [stdout] 109 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / let _ = retry!( [INFO] [stdout] 140 | | "disable_charge_schedule", [INFO] [stdout] 141 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 142 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 139 - let _ = retry!( [INFO] [stdout] 139 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / let _ = retry!( [INFO] [stdout] 144 | | "set_setting_typed::", [INFO] [stdout] 145 | | ||fox.set_setting_typed::(block.soc_out as u8), [INFO] [stdout] 146 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 143 - let _ = retry!( [INFO] [stdout] 143 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / ... let _ = retry!( [INFO] [stdout] 151 | | ... "set_battery_charging_time_schedule", [INFO] [stdout] 152 | | ... ||fox.set_battery_charging_time_schedule(true, block.start_time, block.end_time.add(Duration::minutes(BLOCK_UNIT_SIZE))), [INFO] [stdout] 153 | | ... )?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 150 - let _ = retry!( [INFO] [stdout] 150 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/manual_worker.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | let min_soc = max_soc.max(10).min(100); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `max_soc.clamp(10, 100)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / let _ = retry!( [INFO] [stdout] 179 | | "disable_charge_schedule", [INFO] [stdout] 180 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 181 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 178 - let _ = retry!( [INFO] [stdout] 178 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / let _ = retry!( [INFO] [stdout] 183 | | "set_setting_typed::", [INFO] [stdout] 184 | | ||fox.set_setting_typed::(min_soc as u8), [INFO] [stdout] 185 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 182 - let _ = retry!( [INFO] [stdout] 182 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | / let _ = retry!( [INFO] [stdout] 223 | | "disable_charge_schedule", [INFO] [stdout] 224 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 225 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 222 - let _ = retry!( [INFO] [stdout] 222 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 226 | / let _ = retry!( [INFO] [stdout] 227 | | "set_setting_typed::", [INFO] [stdout] 228 | | ||fox.set_setting_typed::(min_soc), [INFO] [stdout] 229 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 226 - let _ = retry!( [INFO] [stdout] 226 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 248 | / let _ = retry!( [INFO] [stdout] 249 | | "disable_charge_schedule", [INFO] [stdout] 250 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 251 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 248 - let _ = retry!( [INFO] [stdout] 248 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | / let _ = retry!( [INFO] [stdout] 253 | | "set_setting_typed::", [INFO] [stdout] 254 | | ||fox.set_setting_typed::(10), [INFO] [stdout] 255 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 252 - let _ = retry!( [INFO] [stdout] 252 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/manual.rs:29:44 [INFO] [stdout] | [INFO] [stdout] 29 | let json = std::fs::read_to_string(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/manual.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | JSON(#[from] serde_json::Error), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/manual_scheduler.rs:27:55 [INFO] [stdout] | [INFO] [stdout] 27 | blocks: schedule_blocks.map(|b| b.blocks).unwrap_or(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/manual_scheduler.rs:72:30 [INFO] [stdout] | [INFO] [stdout] 72 | block.is_none_or(|b| (b.start_time > date_hour || b.end_time < date_hour) || [INFO] [stdout] | ______________________________^ [INFO] [stdout] 73 | | (b.start_time <= date_hour && b.end_time >= date_hour && b.status == Status::Waiting)) [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - block.is_none_or(|b| (b.start_time > date_hour || b.end_time < date_hour) || [INFO] [stdout] 73 - (b.start_time <= date_hour && b.end_time >= date_hour && b.status == Status::Waiting)) [INFO] [stdout] 72 + block.is_none_or(|b| !(b.start_time <= date_hour && b.end_time >= date_hour && b.status != Status::Waiting)) [INFO] [stdout] | [INFO] [stdout] 72 - block.is_none_or(|b| (b.start_time > date_hour || b.end_time < date_hour) || [INFO] [stdout] 73 - (b.start_time <= date_hour && b.end_time >= date_hour && b.status == Status::Waiting)) [INFO] [stdout] 72 + block.is_none_or(|b| b.start_time > date_hour || b.end_time < date_hour || b.status == Status::Waiting) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mode_scheduler.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / if let Some(first_block) = groups.first() { [INFO] [stdout] 61 | | if first_block.start_hour != 0 && first_block.start_minute != 0 { [INFO] [stdout] 62 | | groups.insert(0, Group { [INFO] [stdout] 63 | | start_hour: 0, [INFO] [stdout] ... | [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 60 ~ if let Some(first_block) = groups.first() [INFO] [stdout] 61 ~ && first_block.start_hour != 0 && first_block.start_minute != 0 { [INFO] [stdout] 62 | groups.insert(0, Group { [INFO] [stdout] ... [INFO] [stdout] 69 | }); [INFO] [stdout] 70 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `warn!` args [INFO] [stdout] --> src/mode_scheduler.rs:82:99 [INFO] [stdout] | [INFO] [stdout] 82 | warn!("Error in imported schedule: {}\n\nUsing default schedule for mode scheduler", e.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mode_scheduler.rs:83:141 [INFO] [stdout] | [INFO] [stdout] 83 | ...ported schedule: {}\n\nUsing default schedule", e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/mode_scheduler.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 124 | let block = self.import_schedule.blocks.iter().filter(|b| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 125 | | date_time >= b.start_time && date_time < b.end_time.add(TimeDelta::minutes(BLOCK_UNIT_SIZE)) [INFO] [stdout] 126 | | }).last(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - }).last(); [INFO] [stdout] 126 + }).next_back(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/mode_scheduler.rs:143:33 [INFO] [stdout] | [INFO] [stdout] 143 | fn validate_schedule(ts_groups: &Vec) -> Result<(), SchedulingError> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 143 - fn validate_schedule(ts_groups: &Vec) -> Result<(), SchedulingError> { [INFO] [stdout] 143 + fn validate_schedule(ts_groups: &[Group]) -> Result<(), SchedulingError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/manager_files.rs:66:58 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn save_scheduled_blocks(schedule_dir: &str, blocks: &Vec, soc_kwh: f64, mode_scheduler: bool, schedule_id: i64) -> Resul... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 ~ pub fn save_scheduled_blocks(schedule_dir: &str, blocks: &[Block], soc_kwh: f64, mode_scheduler: bool, schedule_id: i64) -> Result<(), FileManagerError> { [INFO] [stdout] 67 | let import_schedule = ImportSchedule { [INFO] [stdout] 68 | mode_scheduler, [INFO] [stdout] 69 | soc_kwh, [INFO] [stdout] 70 ~ blocks: blocks.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/manager_files.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | Ok(save_import_schedule(schedule_dir, &import_schedule)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 74 - Ok(save_import_schedule(schedule_dir, &import_schedule)?) [INFO] [stdout] 74 + save_import_schedule(schedule_dir, &import_schedule) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/manager_files.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 99 | fn get_schedule_time(path_buf: &PathBuf) -> anyhow::Result<(DateTime, DateTime), FileManagerError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 99 - fn get_schedule_time(path_buf: &PathBuf) -> anyhow::Result<(DateTime, DateTime), FileManagerError> { [INFO] [stdout] 99 + fn get_schedule_time(path_buf: &Path) -> anyhow::Result<(DateTime, DateTime), FileManagerError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/manager_files.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | JSON(#[from] serde_json::Error), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GLOB` contains a capitalized acronym [INFO] [stdout] --> src/manager_files.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | GLOB(#[from] glob::PatternError), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATE` contains a capitalized acronym [INFO] [stdout] --> src/manager_files.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | DATE(#[from] chrono::format::ParseError), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Date` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mode_worker.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / if let Some((status, assumed_work_mode)) = s.get_current_schedule_status(&mgr.mail, instant) { [INFO] [stdout] 41 | | if status == Status::Waiting { [INFO] [stdout] 42 | | let mut work_mode = get_working_mode(&mgr.fox)?; [INFO] [stdout] 43 | | let soc = get_current_soc(&mgr.fox)?; [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if let Some((status, assumed_work_mode)) = s.get_current_schedule_status(&mgr.mail, instant) [INFO] [stdout] 41 ~ && status == Status::Waiting { [INFO] [stdout] 42 | let mut work_mode = get_working_mode(&mgr.fox)?; [INFO] [stdout] ... [INFO] [stdout] 50 | s.update_import_schedule(&config.files.schedule_dir, instant, work_mode, Status::Started, soc)?; [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mode_worker.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / let _ = retry!( [INFO] [stdout] 111 | | "set_scheduler_time_segments", [INFO] [stdout] 112 | | || fox.set_scheduler_time_segments(schedule), [INFO] [stdout] 113 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 110 - let _ = retry!( [INFO] [stdout] 110 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/worker_common.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | / if self.block_type == BlockType::Charge { [INFO] [stdout] 114 | | if let Status::Full(full_at) = &status { [INFO] [stdout] 115 | | self.soc_out = full_at.soc; [INFO] [stdout] 116 | | self.charge_out = (full_at.soc - 10) as f64 * self.soc_kwh; [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 113 ~ if self.block_type == BlockType::Charge [INFO] [stdout] 114 ~ && let Status::Full(full_at) = &status { [INFO] [stdout] 115 | self.soc_out = full_at.soc; [INFO] [stdout] 116 | self.charge_out = (full_at.soc - 10) as f64 * self.soc_kwh; [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:42 [INFO] [stdout] | [INFO] [stdout] 72 | run_manual_scheduler(config, &mut mgr) [INFO] [stdout] | ^^^^^^^^ help: change this to: `mgr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:74:40 [INFO] [stdout] | [INFO] [stdout] 74 | run_mode_scheduler(config, &mut mgr) [INFO] [stdout] | ^^^^^^^^ help: change this to: `mgr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/initialization.rs:33:34 [INFO] [stdout] | [INFO] [stdout] 33 | let mut config = load_config(&config_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `config_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/initialization.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let _ = setup_logger(&config.general.log_path, config.general.log_level, config.general.log_to_stdout)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 41 - let _ = setup_logger(&config.general.log_path, config.general.log_level, config.general.log_to_stdout)?; [INFO] [stdout] 41 + setup_logger(&config.general.log_path, config.general.log_level, config.general.log_to_stdout)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/manual_worker.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / if let Some(block_id) = active_block { [INFO] [stdout] 47 | | if schedule.is_active_charging(block_id, utc_now) [INFO] [stdout] 48 | | { [INFO] [stdout] 49 | | let block: &mut Block = schedule.get_block_by_id(block_id).ok_or(WorkerError::Other("Active block not found"))?; [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Some(block_id) = active_block [INFO] [stdout] 47 ~ && schedule.is_active_charging(block_id, utc_now) [INFO] [stdout] 48 | { [INFO] [stdout] ... [INFO] [stdout] 57 | } [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/manual_worker.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let status: Status; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `status` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 | let soc = get_current_soc(&mgr.fox)?; [INFO] [stdout] 89 ~ let status: Status = match block.block_type { [INFO] [stdout] 90 | BlockType::Charge => { [INFO] [stdout] 91 ~ set_charge(&mgr.fox, soc, block, utc_now).map_err(|e| { [INFO] [stdout] 92 | WorkerError::SetCharge(e.to_string()) [INFO] [stdout] 93 ~ })? [INFO] [stdout] 94 | }, [INFO] [stdout] 95 | [INFO] [stdout] 96 | BlockType::Hold => { [INFO] [stdout] 97 ~ set_hold(&mgr.fox, soc, block.soc_in as u8).map_err(|e| { [INFO] [stdout] 98 | WorkerError::SetHold(e.to_string()) [INFO] [stdout] 99 ~ })? [INFO] [stdout] 100 | }, [INFO] [stdout] 101 | [INFO] [stdout] 102 | BlockType::Use => { [INFO] [stdout] 103 ~ set_use(&mgr.fox).map_err(|e| { [INFO] [stdout] 104 | WorkerError::SetUse(e.to_string()) [INFO] [stdout] 105 ~ })? [INFO] [stdout] 106 | }, [INFO] [stdout] 107 | [INFO] [stdout] 108 ~ BlockType::Unknown => Status::Error, [INFO] [stdout] 109 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / let _ = retry!( [INFO] [stdout] 140 | | "disable_charge_schedule", [INFO] [stdout] 141 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 142 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 139 - let _ = retry!( [INFO] [stdout] 139 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / let _ = retry!( [INFO] [stdout] 144 | | "set_setting_typed::", [INFO] [stdout] 145 | | ||fox.set_setting_typed::(block.soc_out as u8), [INFO] [stdout] 146 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 143 - let _ = retry!( [INFO] [stdout] 143 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / ... let _ = retry!( [INFO] [stdout] 151 | | ... "set_battery_charging_time_schedule", [INFO] [stdout] 152 | | ... ||fox.set_battery_charging_time_schedule(true, block.start_time, block.end_time.add(Duration::minutes(BLOCK_UNIT_SIZE))), [INFO] [stdout] 153 | | ... )?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 150 - let _ = retry!( [INFO] [stdout] 150 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/manual_worker.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | let min_soc = max_soc.max(10).min(100); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `max_soc.clamp(10, 100)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / let _ = retry!( [INFO] [stdout] 179 | | "disable_charge_schedule", [INFO] [stdout] 180 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 181 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 178 - let _ = retry!( [INFO] [stdout] 178 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / let _ = retry!( [INFO] [stdout] 183 | | "set_setting_typed::", [INFO] [stdout] 184 | | ||fox.set_setting_typed::(min_soc as u8), [INFO] [stdout] 185 | | )?; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 182 - let _ = retry!( [INFO] [stdout] 182 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | / let _ = retry!( [INFO] [stdout] 223 | | "disable_charge_schedule", [INFO] [stdout] 224 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 225 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 222 - let _ = retry!( [INFO] [stdout] 222 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 226 | / let _ = retry!( [INFO] [stdout] 227 | | "set_setting_typed::", [INFO] [stdout] 228 | | ||fox.set_setting_typed::(min_soc), [INFO] [stdout] 229 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 226 - let _ = retry!( [INFO] [stdout] 226 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 248 | / let _ = retry!( [INFO] [stdout] 249 | | "disable_charge_schedule", [INFO] [stdout] 250 | | ||fox.disable_charge_schedule(), [INFO] [stdout] 251 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 248 - let _ = retry!( [INFO] [stdout] 248 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/manual_worker.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | / let _ = retry!( [INFO] [stdout] 253 | | "set_setting_typed::", [INFO] [stdout] 254 | | ||fox.set_setting_typed::(10), [INFO] [stdout] 255 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 252 - let _ = retry!( [INFO] [stdout] 252 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/manual.rs:29:44 [INFO] [stdout] | [INFO] [stdout] 29 | let json = std::fs::read_to_string(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/manual.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | JSON(#[from] serde_json::Error), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/manual_scheduler.rs:27:55 [INFO] [stdout] | [INFO] [stdout] 27 | blocks: schedule_blocks.map(|b| b.blocks).unwrap_or(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/manual_scheduler.rs:72:30 [INFO] [stdout] | [INFO] [stdout] 72 | block.is_none_or(|b| (b.start_time > date_hour || b.end_time < date_hour) || [INFO] [stdout] | ______________________________^ [INFO] [stdout] 73 | | (b.start_time <= date_hour && b.end_time >= date_hour && b.status == Status::Waiting)) [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - block.is_none_or(|b| (b.start_time > date_hour || b.end_time < date_hour) || [INFO] [stdout] 73 - (b.start_time <= date_hour && b.end_time >= date_hour && b.status == Status::Waiting)) [INFO] [stdout] 72 + block.is_none_or(|b| !(b.start_time <= date_hour && b.end_time >= date_hour && b.status != Status::Waiting)) [INFO] [stdout] | [INFO] [stdout] 72 - block.is_none_or(|b| (b.start_time > date_hour || b.end_time < date_hour) || [INFO] [stdout] 73 - (b.start_time <= date_hour && b.end_time >= date_hour && b.status == Status::Waiting)) [INFO] [stdout] 72 + block.is_none_or(|b| b.start_time > date_hour || b.end_time < date_hour || b.status == Status::Waiting) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mode_scheduler.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / if let Some(first_block) = groups.first() { [INFO] [stdout] 61 | | if first_block.start_hour != 0 && first_block.start_minute != 0 { [INFO] [stdout] 62 | | groups.insert(0, Group { [INFO] [stdout] 63 | | start_hour: 0, [INFO] [stdout] ... | [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 60 ~ if let Some(first_block) = groups.first() [INFO] [stdout] 61 ~ && first_block.start_hour != 0 && first_block.start_minute != 0 { [INFO] [stdout] 62 | groups.insert(0, Group { [INFO] [stdout] ... [INFO] [stdout] 69 | }); [INFO] [stdout] 70 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `warn!` args [INFO] [stdout] --> src/mode_scheduler.rs:82:99 [INFO] [stdout] | [INFO] [stdout] 82 | warn!("Error in imported schedule: {}\n\nUsing default schedule for mode scheduler", e.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mode_scheduler.rs:83:141 [INFO] [stdout] | [INFO] [stdout] 83 | ...ported schedule: {}\n\nUsing default schedule", e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/mode_scheduler.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 124 | let block = self.import_schedule.blocks.iter().filter(|b| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 125 | | date_time >= b.start_time && date_time < b.end_time.add(TimeDelta::minutes(BLOCK_UNIT_SIZE)) [INFO] [stdout] 126 | | }).last(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - }).last(); [INFO] [stdout] 126 + }).next_back(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/mode_scheduler.rs:143:33 [INFO] [stdout] | [INFO] [stdout] 143 | fn validate_schedule(ts_groups: &Vec) -> Result<(), SchedulingError> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 143 - fn validate_schedule(ts_groups: &Vec) -> Result<(), SchedulingError> { [INFO] [stdout] 143 + fn validate_schedule(ts_groups: &[Group]) -> Result<(), SchedulingError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/manager_files.rs:66:58 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn save_scheduled_blocks(schedule_dir: &str, blocks: &Vec, soc_kwh: f64, mode_scheduler: bool, schedule_id: i64) -> Resul... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 ~ pub fn save_scheduled_blocks(schedule_dir: &str, blocks: &[Block], soc_kwh: f64, mode_scheduler: bool, schedule_id: i64) -> Result<(), FileManagerError> { [INFO] [stdout] 67 | let import_schedule = ImportSchedule { [INFO] [stdout] 68 | mode_scheduler, [INFO] [stdout] 69 | soc_kwh, [INFO] [stdout] 70 ~ blocks: blocks.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/manager_files.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | Ok(save_import_schedule(schedule_dir, &import_schedule)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 74 - Ok(save_import_schedule(schedule_dir, &import_schedule)?) [INFO] [stdout] 74 + save_import_schedule(schedule_dir, &import_schedule) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/manager_files.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 99 | fn get_schedule_time(path_buf: &PathBuf) -> anyhow::Result<(DateTime, DateTime), FileManagerError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 99 - fn get_schedule_time(path_buf: &PathBuf) -> anyhow::Result<(DateTime, DateTime), FileManagerError> { [INFO] [stdout] 99 + fn get_schedule_time(path_buf: &Path) -> anyhow::Result<(DateTime, DateTime), FileManagerError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/manager_files.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | JSON(#[from] serde_json::Error), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GLOB` contains a capitalized acronym [INFO] [stdout] --> src/manager_files.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | GLOB(#[from] glob::PatternError), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATE` contains a capitalized acronym [INFO] [stdout] --> src/manager_files.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | DATE(#[from] chrono::format::ParseError), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Date` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mode_worker.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / if let Some((status, assumed_work_mode)) = s.get_current_schedule_status(&mgr.mail, instant) { [INFO] [stdout] 41 | | if status == Status::Waiting { [INFO] [stdout] 42 | | let mut work_mode = get_working_mode(&mgr.fox)?; [INFO] [stdout] 43 | | let soc = get_current_soc(&mgr.fox)?; [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if let Some((status, assumed_work_mode)) = s.get_current_schedule_status(&mgr.mail, instant) [INFO] [stdout] 41 ~ && status == Status::Waiting { [INFO] [stdout] 42 | let mut work_mode = get_working_mode(&mgr.fox)?; [INFO] [stdout] ... [INFO] [stdout] 50 | s.update_import_schedule(&config.files.schedule_dir, instant, work_mode, Status::Started, soc)?; [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mode_worker.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / let _ = retry!( [INFO] [stdout] 111 | | "set_scheduler_time_segments", [INFO] [stdout] 112 | | || fox.set_scheduler_time_segments(schedule), [INFO] [stdout] 113 | | )?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 110 - let _ = retry!( [INFO] [stdout] 110 + retry!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/worker_common.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | / if self.block_type == BlockType::Charge { [INFO] [stdout] 114 | | if let Status::Full(full_at) = &status { [INFO] [stdout] 115 | | self.soc_out = full_at.soc; [INFO] [stdout] 116 | | self.charge_out = (full_at.soc - 10) as f64 * self.soc_kwh; [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 113 ~ if self.block_type == BlockType::Charge [INFO] [stdout] 114 ~ && let Status::Full(full_at) = &status { [INFO] [stdout] 115 | self.soc_out = full_at.soc; [INFO] [stdout] 116 | self.charge_out = (full_at.soc - 10) as f64 * self.soc_kwh; [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:42 [INFO] [stdout] | [INFO] [stdout] 72 | run_manual_scheduler(config, &mut mgr) [INFO] [stdout] | ^^^^^^^^ help: change this to: `mgr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:74:40 [INFO] [stdout] | [INFO] [stdout] 74 | run_mode_scheduler(config, &mut mgr) [INFO] [stdout] | ^^^^^^^^ help: change this to: `mgr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 05s [INFO] running `Command { std: "docker" "inspect" "d56a55f61c0c8326704ec33e9969a8efca377071f85bcac4f8b7534fdea4ecfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d56a55f61c0c8326704ec33e9969a8efca377071f85bcac4f8b7534fdea4ecfb", kill_on_drop: false }` [INFO] [stdout] d56a55f61c0c8326704ec33e9969a8efca377071f85bcac4f8b7534fdea4ecfb