[INFO] cloning repository https://github.com/gohyuhan/rtop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gohyuhan/rtop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgohyuhan%2Frtop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgohyuhan%2Frtop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7a0c1e006dad4d524313e5d0b3c43c3ac6049f30 [INFO] linting gohyuhan/rtop against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgohyuhan%2Frtop" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-1-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/gohyuhan/rtop [INFO] finished tweaking git repo https://github.com/gohyuhan/rtop [INFO] tweaked toml for git repo https://github.com/gohyuhan/rtop written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gohyuhan/rtop on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gohyuhan/rtop already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstream v0.6.19 [INFO] [stderr] Downloaded clap v4.5.40 [INFO] [stderr] Downloaded anstyle-query v1.1.3 [INFO] [stderr] Downloaded clap_derive v4.5.40 [INFO] [stderr] Downloaded inquire v0.7.5 [INFO] [stderr] Downloaded libproc v0.14.10 [INFO] [stderr] Downloaded libloading v0.8.8 [INFO] [stderr] Downloaded cc v1.2.25 [INFO] [stderr] Downloaded anstyle-wincon v3.0.9 [INFO] [stderr] Downloaded newline-converter v0.3.0 [INFO] [stderr] Downloaded clap_builder v4.5.40 [INFO] [stderr] Downloaded sysinfo v0.34.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc9a70fe7fff8f0b67104d4e69129982fd1e619b0ce3270990a5d56f4daef0ef [INFO] running `Command { std: "docker" "start" "-a" "dc9a70fe7fff8f0b67104d4e69129982fd1e619b0ce3270990a5d56f4daef0ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc9a70fe7fff8f0b67104d4e69129982fd1e619b0ce3270990a5d56f4daef0ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc9a70fe7fff8f0b67104d4e69129982fd1e619b0ce3270990a5d56f4daef0ef", kill_on_drop: false }` [INFO] [stdout] dc9a70fe7fff8f0b67104d4e69129982fd1e619b0ce3270990a5d56f4daef0ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f8ef88ac83364b60c3644161a74d462dc2c492c2ce62e01c22d32e4f25042ffc [INFO] running `Command { std: "docker" "start" "-a" "f8ef88ac83364b60c3644161a74d462dc2c492c2ce62e01c22d32e4f25042ffc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling libloading v0.8.8 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking errno v0.3.12 [INFO] [stderr] Checking dyn-clone v1.0.19 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking sysinfo v0.34.2 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Compiling libproc v0.14.10 [INFO] [stderr] Checking rtop v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `pid` [INFO] [stdout] --> src/get_sys_info.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | pid: i32, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thread_hashmap_win_only` [INFO] [stdout] --> src/get_sys_info.rs:297:5 [INFO] [stdout] | [INFO] [stdout] 297 | thread_hashmap_win_only: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread_hashmap_win_only` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pid` [INFO] [stdout] --> src/get_sys_info.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | pid: i32, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thread_hashmap_win_only` [INFO] [stdout] --> src/get_sys_info.rs:297:5 [INFO] [stdout] | [INFO] [stdout] 297 | thread_hashmap_win_only: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread_hashmap_win_only` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `c_sys_info` after checking its variant with `is_ok` [INFO] [stdout] --> src/app.rs:190:54 [INFO] [stdout] | [INFO] [stdout] 189 | if c_sys_info.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = c_sys_info` [INFO] [stdout] 190 | process_sys_info(&mut self.sys_info, c_sys_info.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `c_process_info` after checking its variant with `is_ok` [INFO] [stdout] --> src/app.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 194 | if c_process_info.is_ok() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = c_process_info` [INFO] [stdout] ... [INFO] [stdout] 197 | c_process_info.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | / if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 291 | | true [INFO] [stdout] 292 | | } else { [INFO] [stdout] 293 | | false [INFO] [stdout] 294 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | / if self.selected_container == SelectedContainer::Memory { [INFO] [stdout] 305 | | true [INFO] [stdout] 306 | | } else { [INFO] [stdout] 307 | | false [INFO] [stdout] 308 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | &selected_disk, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `selected_disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:319:25 [INFO] [stdout] | [INFO] [stdout] 319 | / if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 320 | | true [INFO] [stdout] 321 | | } else { [INFO] [stdout] 322 | | false [INFO] [stdout] 323 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:330:25 [INFO] [stdout] | [INFO] [stdout] 330 | &selected_network, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `selected_network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:334:25 [INFO] [stdout] | [INFO] [stdout] 334 | / if self.selected_container == SelectedContainer::Network { [INFO] [stdout] 335 | | true [INFO] [stdout] 336 | | } else { [INFO] [stdout] 337 | | false [INFO] [stdout] 338 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:359:25 [INFO] [stdout] | [INFO] [stdout] 359 | / if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 360 | | true [INFO] [stdout] 361 | | } else { [INFO] [stdout] 362 | | false [INFO] [stdout] 363 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Process` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:376:21 [INFO] [stdout] | [INFO] [stdout] 376 | / if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 377 | | true [INFO] [stdout] 378 | | } else { [INFO] [stdout] 379 | | false [INFO] [stdout] 380 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | / if self.selected_container == SelectedContainer::Memory { [INFO] [stdout] 391 | | true [INFO] [stdout] 392 | | } else { [INFO] [stdout] 393 | | false [INFO] [stdout] 394 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:401:21 [INFO] [stdout] | [INFO] [stdout] 401 | &selected_disk, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `selected_disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:405:21 [INFO] [stdout] | [INFO] [stdout] 405 | / if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 406 | | true [INFO] [stdout] 407 | | } else { [INFO] [stdout] 408 | | false [INFO] [stdout] 409 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:416:21 [INFO] [stdout] | [INFO] [stdout] 416 | &selected_network, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `selected_network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | / if self.selected_container == SelectedContainer::Network { [INFO] [stdout] 421 | | true [INFO] [stdout] 422 | | } else { [INFO] [stdout] 423 | | false [INFO] [stdout] 424 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:445:21 [INFO] [stdout] | [INFO] [stdout] 445 | / if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 446 | | true [INFO] [stdout] 447 | | } else { [INFO] [stdout] 448 | | false [INFO] [stdout] 449 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Process` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:830:44 [INFO] [stdout] | [INFO] [stdout] 827 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 830 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 831 | | .current_showing_process_detail [INFO] [stdout] 832 | | .as_ref() [INFO] [stdout] 833 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:865:44 [INFO] [stdout] | [INFO] [stdout] 862 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 865 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 866 | | .current_showing_process_detail [INFO] [stdout] 867 | | .as_ref() [INFO] [stdout] 868 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:901:44 [INFO] [stdout] | [INFO] [stdout] 898 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 901 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 902 | | .current_showing_process_detail [INFO] [stdout] 903 | | .as_ref() [INFO] [stdout] 904 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:937:44 [INFO] [stdout] | [INFO] [stdout] 934 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 937 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 938 | | .current_showing_process_detail [INFO] [stdout] 939 | | .as_ref() [INFO] [stdout] 940 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:973:44 [INFO] [stdout] | [INFO] [stdout] 970 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 973 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 974 | | .current_showing_process_detail [INFO] [stdout] 975 | | .as_ref() [INFO] [stdout] 976 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:1010:44 [INFO] [stdout] | [INFO] [stdout] 1007 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 1010 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 1011 | | .current_showing_process_detail [INFO] [stdout] 1012 | | .as_ref() [INFO] [stdout] 1013 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:491:17 [INFO] [stdout] | [INFO] [stdout] 491 | / if self.state == AppState::View { [INFO] [stdout] 492 | | // quit the ratatui terminal user interface [INFO] [stdout] 493 | | if self.selected_container == SelectedContainer::None { [INFO] [stdout] 494 | | self.is_quit = true; [INFO] [stdout] ... | [INFO] [stdout] 502 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 490 ~ KeyCode::Esc [INFO] [stdout] 491 ~ if self.state == AppState::View => { [INFO] [stdout] 492 | // quit the ratatui terminal user interface [INFO] [stdout] ... [INFO] [stdout] 501 | } [INFO] [stdout] 502 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:506:17 [INFO] [stdout] | [INFO] [stdout] 506 | / if self.state == AppState::View { [INFO] [stdout] 507 | | if self.tick > 100 { [INFO] [stdout] 508 | | self.tick -= 100; [INFO] [stdout] 509 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 512 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 505 ~ KeyCode::Char('-') [INFO] [stdout] 506 ~ if self.state == AppState::View => { [INFO] [stdout] 507 | if self.tick > 100 { [INFO] [stdout] ... [INFO] [stdout] 511 | } [INFO] [stdout] 512 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:515:17 [INFO] [stdout] | [INFO] [stdout] 515 | / if self.state == AppState::View { [INFO] [stdout] 516 | | if self.tick < 10000 { [INFO] [stdout] 517 | | self.tick += 100; [INFO] [stdout] 518 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 521 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 514 ~ KeyCode::Char('+') [INFO] [stdout] 515 ~ if self.state == AppState::View => { [INFO] [stdout] 516 | if self.tick < 10000 { [INFO] [stdout] ... [INFO] [stdout] 520 | } [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:525:17 [INFO] [stdout] | [INFO] [stdout] 525 | / if self.state == AppState::View { [INFO] [stdout] 526 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 527 | | if let Some(selected) = self.cpu_selected_state.selected() { [INFO] [stdout] 528 | | if selected > 0 { [INFO] [stdout] ... | [INFO] [stdout] 544 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 524 ~ KeyCode::Up [INFO] [stdout] 525 ~ if self.state == AppState::View => { [INFO] [stdout] 526 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 543 | } [INFO] [stdout] 544 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | / if self.state == AppState::View { [INFO] [stdout] 548 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 549 | | if let Some(selected) = self.cpu_selected_state.selected() { [INFO] [stdout] 550 | | if selected < self.sys_info.cpus.len().saturating_sub(1) { [INFO] [stdout] ... | [INFO] [stdout] 565 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ KeyCode::Down [INFO] [stdout] 547 ~ if self.state == AppState::View => { [INFO] [stdout] 548 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 564 | } [INFO] [stdout] 565 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:568:17 [INFO] [stdout] | [INFO] [stdout] 568 | / if self.state == AppState::View { [INFO] [stdout] 569 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 570 | | if self.cpu_graph_shown_range > 100 { [INFO] [stdout] 571 | | self.cpu_graph_shown_range -= 10; [INFO] [stdout] ... | [INFO] [stdout] 606 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 567 ~ KeyCode::Char('[') [INFO] [stdout] 568 ~ if self.state == AppState::View => { [INFO] [stdout] 569 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 605 | } [INFO] [stdout] 606 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:610:17 [INFO] [stdout] | [INFO] [stdout] 610 | / if self.state == AppState::View { [INFO] [stdout] 611 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 612 | | if self.cpu_graph_shown_range < MAX_GRAPH_SHOWN_RANGE { [INFO] [stdout] 613 | | self.cpu_graph_shown_range += 10; [INFO] [stdout] ... | [INFO] [stdout] 648 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 609 ~ KeyCode::Char(']') [INFO] [stdout] 610 ~ if self.state == AppState::View => { [INFO] [stdout] 611 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 647 | } [INFO] [stdout] 648 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:653:17 [INFO] [stdout] | [INFO] [stdout] 653 | / if self.state == AppState::View { [INFO] [stdout] 654 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 655 | | || self.selected_container != SelectedContainer::Cpu [INFO] [stdout] ... | [INFO] [stdout] 662 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 652 ~ KeyCode::Char('c') [INFO] [stdout] 653 ~ if self.state == AppState::View => { [INFO] [stdout] 654 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 661 | } [INFO] [stdout] 662 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:665:17 [INFO] [stdout] | [INFO] [stdout] 665 | / if self.state == AppState::View { [INFO] [stdout] 666 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 667 | | || self.selected_container != SelectedContainer::Cpu [INFO] [stdout] ... | [INFO] [stdout] 674 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 664 ~ KeyCode::Char('C') [INFO] [stdout] 665 ~ if self.state == AppState::View => { [INFO] [stdout] 666 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] 674 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:679:17 [INFO] [stdout] | [INFO] [stdout] 679 | / if self.state == AppState::View { [INFO] [stdout] 680 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 681 | | || self.selected_container != SelectedContainer::Memory [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 678 ~ KeyCode::Char('m') [INFO] [stdout] 679 ~ if self.state == AppState::View => { [INFO] [stdout] 680 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 687 | } [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:691:17 [INFO] [stdout] | [INFO] [stdout] 691 | / if self.state == AppState::View { [INFO] [stdout] 692 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 693 | | || self.selected_container != SelectedContainer::Memory [INFO] [stdout] ... | [INFO] [stdout] 700 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 690 ~ KeyCode::Char('M') [INFO] [stdout] 691 ~ if self.state == AppState::View => { [INFO] [stdout] 692 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 699 | } [INFO] [stdout] 700 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:705:17 [INFO] [stdout] | [INFO] [stdout] 705 | / if self.state == AppState::View { [INFO] [stdout] 706 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 707 | | || self.selected_container != SelectedContainer::Disk [INFO] [stdout] ... | [INFO] [stdout] 714 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 704 ~ KeyCode::Char('d') [INFO] [stdout] 705 ~ if self.state == AppState::View => { [INFO] [stdout] 706 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 713 | } [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:717:17 [INFO] [stdout] | [INFO] [stdout] 717 | / if self.state == AppState::View { [INFO] [stdout] 718 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 719 | | || self.selected_container != SelectedContainer::Disk [INFO] [stdout] ... | [INFO] [stdout] 726 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 716 ~ KeyCode::Char('D') [INFO] [stdout] 717 ~ if self.state == AppState::View => { [INFO] [stdout] 718 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 725 | } [INFO] [stdout] 726 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:731:17 [INFO] [stdout] | [INFO] [stdout] 731 | / if self.state == AppState::View { [INFO] [stdout] 732 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 733 | | || self.selected_container != SelectedContainer::Network [INFO] [stdout] ... | [INFO] [stdout] 740 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 730 ~ KeyCode::Char('n') [INFO] [stdout] 731 ~ if self.state == AppState::View => { [INFO] [stdout] 732 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 739 | } [INFO] [stdout] 740 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:743:17 [INFO] [stdout] | [INFO] [stdout] 743 | / if self.state == AppState::View { [INFO] [stdout] 744 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 745 | | || self.selected_container != SelectedContainer::Network [INFO] [stdout] ... | [INFO] [stdout] 752 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 742 ~ KeyCode::Char('N') [INFO] [stdout] 743 ~ if self.state == AppState::View => { [INFO] [stdout] 744 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 751 | } [INFO] [stdout] 752 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:757:17 [INFO] [stdout] | [INFO] [stdout] 757 | / if self.state == AppState::View { [INFO] [stdout] 758 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 759 | | || self.selected_container != SelectedContainer::Process [INFO] [stdout] ... | [INFO] [stdout] 766 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 756 ~ KeyCode::Char('p') [INFO] [stdout] 757 ~ if self.state == AppState::View => { [INFO] [stdout] 758 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 765 | } [INFO] [stdout] 766 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:769:17 [INFO] [stdout] | [INFO] [stdout] 769 | / if self.state == AppState::View { [INFO] [stdout] 770 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 771 | | || self.selected_container != SelectedContainer::Process [INFO] [stdout] ... | [INFO] [stdout] 778 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 768 ~ KeyCode::Char('P') [INFO] [stdout] 769 ~ if self.state == AppState::View => { [INFO] [stdout] 770 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 777 | } [INFO] [stdout] 778 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | / if self.state == AppState::View { [INFO] [stdout] 783 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 784 | | if self.process_sort_is_reversed { [INFO] [stdout] 785 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 790 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 781 ~ KeyCode::Char('R') [INFO] [stdout] 782 ~ if self.state == AppState::View => { [INFO] [stdout] 783 | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] ... [INFO] [stdout] 789 | } [INFO] [stdout] 790 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:794:17 [INFO] [stdout] | [INFO] [stdout] 794 | / if self.state == AppState::View { [INFO] [stdout] 795 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 796 | | if self.process_sort_is_reversed { [INFO] [stdout] 797 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 802 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 793 ~ KeyCode::Char('r') [INFO] [stdout] 794 ~ if self.state == AppState::View => { [INFO] [stdout] 795 | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] ... [INFO] [stdout] 801 | } [INFO] [stdout] 802 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:806:17 [INFO] [stdout] | [INFO] [stdout] 806 | / if self.state == AppState::View { [INFO] [stdout] 807 | | self.state = AppState::Typing; [INFO] [stdout] 808 | | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] 809 | | self.process_filter = "_".to_string(); [INFO] [stdout] 810 | | } [INFO] [stdout] 811 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 805 ~ KeyCode::Char('f') [INFO] [stdout] 806 ~ if self.state == AppState::View => { [INFO] [stdout] 807 | self.state = AppState::Typing; [INFO] [stdout] ... [INFO] [stdout] 810 | } [INFO] [stdout] 811 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:815:17 [INFO] [stdout] | [INFO] [stdout] 815 | / if self.state == AppState::View { [INFO] [stdout] 816 | | self.state = AppState::Typing; [INFO] [stdout] 817 | | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] 818 | | self.process_filter = "_".to_string(); [INFO] [stdout] 819 | | } [INFO] [stdout] 820 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 814 ~ KeyCode::Char('F') [INFO] [stdout] 815 ~ if self.state == AppState::View => { [INFO] [stdout] 816 | self.state = AppState::Typing; [INFO] [stdout] ... [INFO] [stdout] 819 | } [INFO] [stdout] 820 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:824:17 [INFO] [stdout] | [INFO] [stdout] 824 | / if self.state == AppState::View { [INFO] [stdout] 825 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 826 | | && self.process_show_details [INFO] [stdout] 827 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 855 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 823 ~ KeyCode::Char('K') [INFO] [stdout] 824 ~ if self.state == AppState::View => { [INFO] [stdout] 825 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 854 | } [INFO] [stdout] 855 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | / if self.state == AppState::View { [INFO] [stdout] 860 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 861 | | && self.process_show_details [INFO] [stdout] 862 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 891 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 858 ~ KeyCode::Char('k') [INFO] [stdout] 859 ~ if self.state == AppState::View => { [INFO] [stdout] 860 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 890 | } [INFO] [stdout] 891 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:895:17 [INFO] [stdout] | [INFO] [stdout] 895 | / if self.state == AppState::View { [INFO] [stdout] 896 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 897 | | && self.process_show_details [INFO] [stdout] 898 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 894 ~ KeyCode::Char('T') [INFO] [stdout] 895 ~ if self.state == AppState::View => { [INFO] [stdout] 896 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 926 | } [INFO] [stdout] 927 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:931:17 [INFO] [stdout] | [INFO] [stdout] 931 | / if self.state == AppState::View { [INFO] [stdout] 932 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 933 | | && self.process_show_details [INFO] [stdout] 934 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 963 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 930 ~ KeyCode::Char('t') [INFO] [stdout] 931 ~ if self.state == AppState::View => { [INFO] [stdout] 932 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 962 | } [INFO] [stdout] 963 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:967:17 [INFO] [stdout] | [INFO] [stdout] 967 | / if self.state == AppState::View { [INFO] [stdout] 968 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 969 | | && self.process_show_details [INFO] [stdout] 970 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1000 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 966 ~ KeyCode::Char('S') [INFO] [stdout] 967 ~ if self.state == AppState::View => { [INFO] [stdout] 968 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 999 | } [INFO] [stdout] 1000 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1004:17 [INFO] [stdout] | [INFO] [stdout] 1004 | / if self.state == AppState::View { [INFO] [stdout] 1005 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 1006 | | && self.process_show_details [INFO] [stdout] 1007 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1037 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1003 ~ KeyCode::Char('s') [INFO] [stdout] 1004 ~ if self.state == AppState::View => { [INFO] [stdout] 1005 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 1036 | } [INFO] [stdout] 1037 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1041:17 [INFO] [stdout] | [INFO] [stdout] 1041 | / if self.state == AppState::View { [INFO] [stdout] 1042 | | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 1043 | | if self.disk_selected_entry == 0 { [INFO] [stdout] 1044 | | self.disk_selected_entry = self.sys_info.disks.len() - 1; [INFO] [stdout] ... | [INFO] [stdout] 1065 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1040 ~ KeyCode::Left [INFO] [stdout] 1041 ~ if self.state == AppState::View => { [INFO] [stdout] 1042 | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] ... [INFO] [stdout] 1064 | } [INFO] [stdout] 1065 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1068:17 [INFO] [stdout] | [INFO] [stdout] 1068 | / if self.state == AppState::View { [INFO] [stdout] 1069 | | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 1070 | | if self.disk_selected_entry == self.sys_info.disks.len() - 1 { [INFO] [stdout] 1071 | | self.disk_selected_entry = 0 [INFO] [stdout] ... | [INFO] [stdout] 1093 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1067 ~ KeyCode::Right [INFO] [stdout] 1068 ~ if self.state == AppState::View => { [INFO] [stdout] 1069 | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] ... [INFO] [stdout] 1092 | } [INFO] [stdout] 1093 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1097:17 [INFO] [stdout] | [INFO] [stdout] 1097 | / if self.state == AppState::View { [INFO] [stdout] 1098 | | self.process_filter = "".to_string(); [INFO] [stdout] 1099 | | self.process_selected_state.select(None); [INFO] [stdout] 1100 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1096 ~ KeyCode::Backspace [INFO] [stdout] 1097 ~ if self.state == AppState::View => { [INFO] [stdout] 1098 | self.process_filter = "".to_string(); [INFO] [stdout] 1099 | self.process_selected_state.select(None); [INFO] [stdout] 1100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1104:17 [INFO] [stdout] | [INFO] [stdout] 1104 | / if self.state == AppState::View { [INFO] [stdout] 1105 | | // for a container to be full screen, it need to be selected first [INFO] [stdout] 1106 | | if self.container_full_screen [INFO] [stdout] 1107 | | && self.selected_container != SelectedContainer::None [INFO] [stdout] ... | [INFO] [stdout] 1115 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1103 ~ KeyCode::Tab [INFO] [stdout] 1104 ~ if self.state == AppState::View => { [INFO] [stdout] 1105 | // for a container to be full screen, it need to be selected first [INFO] [stdout] ... [INFO] [stdout] 1114 | } [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1119:17 [INFO] [stdout] | [INFO] [stdout] 1119 | / if self.state == AppState::View { [INFO] [stdout] 1120 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 1121 | | if let Some(selected) = self.process_selected_state.selected() { [INFO] [stdout] 1122 | | self.process_show_details = true; [INFO] [stdout] ... | [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1118 ~ KeyCode::Enter [INFO] [stdout] 1119 ~ if self.state == AppState::View => { [INFO] [stdout] 1120 | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] ... [INFO] [stdout] 1136 | } [INFO] [stdout] 1137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:506:17 [INFO] [stdout] | [INFO] [stdout] 506 | / if self.state == AppState::View { [INFO] [stdout] 507 | | if self.tick > 100 { [INFO] [stdout] 508 | | self.tick -= 100; [INFO] [stdout] 509 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 512 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 506 ~ if self.state == AppState::View [INFO] [stdout] 507 ~ && self.tick > 100 { [INFO] [stdout] 508 | self.tick -= 100; [INFO] [stdout] 509 | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 510 | self.process_tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 511 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:515:17 [INFO] [stdout] | [INFO] [stdout] 515 | / if self.state == AppState::View { [INFO] [stdout] 516 | | if self.tick < 10000 { [INFO] [stdout] 517 | | self.tick += 100; [INFO] [stdout] 518 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 521 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 515 ~ if self.state == AppState::View [INFO] [stdout] 516 ~ && self.tick < 10000 { [INFO] [stdout] 517 | self.tick += 100; [INFO] [stdout] 518 | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 519 | self.process_tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 520 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | / if self.state == AppState::View { [INFO] [stdout] 783 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 784 | | if self.process_sort_is_reversed { [INFO] [stdout] 785 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 790 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 782 ~ if self.state == AppState::View [INFO] [stdout] 783 ~ && self.selected_container == SelectedContainer::Process { [INFO] [stdout] 784 | if self.process_sort_is_reversed { [INFO] [stdout] ... [INFO] [stdout] 788 | } [INFO] [stdout] 789 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/app.rs:784:25 [INFO] [stdout] | [INFO] [stdout] 784 | / if self.process_sort_is_reversed { [INFO] [stdout] 785 | | self.process_sort_is_reversed = false; [INFO] [stdout] 786 | | } else { [INFO] [stdout] 787 | | self.process_sort_is_reversed = true; [INFO] [stdout] 788 | | } [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.process_sort_is_reversed = !self.process_sort_is_reversed;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:794:17 [INFO] [stdout] | [INFO] [stdout] 794 | / if self.state == AppState::View { [INFO] [stdout] 795 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 796 | | if self.process_sort_is_reversed { [INFO] [stdout] 797 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 802 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 794 ~ if self.state == AppState::View [INFO] [stdout] 795 ~ && self.selected_container == SelectedContainer::Process { [INFO] [stdout] 796 | if self.process_sort_is_reversed { [INFO] [stdout] ... [INFO] [stdout] 800 | } [INFO] [stdout] 801 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/app.rs:796:25 [INFO] [stdout] | [INFO] [stdout] 796 | / if self.process_sort_is_reversed { [INFO] [stdout] 797 | | self.process_sort_is_reversed = false; [INFO] [stdout] 798 | | } else { [INFO] [stdout] 799 | | self.process_sort_is_reversed = true; [INFO] [stdout] 800 | | } [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.process_sort_is_reversed = !self.process_sort_is_reversed;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:808:81 [INFO] [stdout] | [INFO] [stdout] 808 | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:817:81 [INFO] [stdout] | [INFO] [stdout] 817 | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:824:17 [INFO] [stdout] | [INFO] [stdout] 824 | / if self.state == AppState::View { [INFO] [stdout] 825 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 826 | | && self.process_show_details [INFO] [stdout] 827 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 855 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 824 ~ if self.state == AppState::View [INFO] [stdout] 825 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 826 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 853 | self.pop_up_type = AppPopUpType::KillConfirmation; [INFO] [stdout] 854 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | / if self.state == AppState::View { [INFO] [stdout] 860 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 861 | | && self.process_show_details [INFO] [stdout] 862 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 891 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 859 ~ if self.state == AppState::View [INFO] [stdout] 860 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 861 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 889 | self.pop_up_type = AppPopUpType::KillConfirmation; [INFO] [stdout] 890 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:895:17 [INFO] [stdout] | [INFO] [stdout] 895 | / if self.state == AppState::View { [INFO] [stdout] 896 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 897 | | && self.process_show_details [INFO] [stdout] 898 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 895 ~ if self.state == AppState::View [INFO] [stdout] 896 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 897 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 925 | self.pop_up_type = AppPopUpType::TerminateConfirmation; [INFO] [stdout] 926 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:931:17 [INFO] [stdout] | [INFO] [stdout] 931 | / if self.state == AppState::View { [INFO] [stdout] 932 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 933 | | && self.process_show_details [INFO] [stdout] 934 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 963 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 931 ~ if self.state == AppState::View [INFO] [stdout] 932 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 933 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 961 | self.pop_up_type = AppPopUpType::TerminateConfirmation; [INFO] [stdout] 962 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:967:17 [INFO] [stdout] | [INFO] [stdout] 967 | / if self.state == AppState::View { [INFO] [stdout] 968 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 969 | | && self.process_show_details [INFO] [stdout] 970 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1000 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 967 ~ if self.state == AppState::View [INFO] [stdout] 968 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 969 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 998 | self.pop_up_type = AppPopUpType::SignalMenu; [INFO] [stdout] 999 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1004:17 [INFO] [stdout] | [INFO] [stdout] 1004 | / if self.state == AppState::View { [INFO] [stdout] 1005 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 1006 | | && self.process_show_details [INFO] [stdout] 1007 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1037 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1004 ~ if self.state == AppState::View [INFO] [stdout] 1005 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 1006 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 1035 | self.pop_up_type = AppPopUpType::SignalMenu; [INFO] [stdout] 1036 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1119:17 [INFO] [stdout] | [INFO] [stdout] 1119 | / if self.state == AppState::View { [INFO] [stdout] 1120 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 1121 | | if let Some(selected) = self.process_selected_state.selected() { [INFO] [stdout] 1122 | | self.process_show_details = true; [INFO] [stdout] ... | [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1119 ~ if self.state == AppState::View [INFO] [stdout] 1120 ~ && self.selected_container == SelectedContainer::Process { [INFO] [stdout] 1121 | if let Some(selected) = self.process_selected_state.selected() { [INFO] [stdout] ... [INFO] [stdout] 1135 | } [INFO] [stdout] 1136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1146:17 [INFO] [stdout] | [INFO] [stdout] 1146 | / ... if !self.process_filter.is_empty() && self.process_filter != "_".to_string() { [INFO] [stdout] 1147 | | ... self.process_filter.remove(self.process_filter.len() - 2); // there will be a "_" character at the end and we don't wa... [INFO] [stdout] 1148 | | ... self.process_selected_state.select(None); [INFO] [stdout] 1149 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1145 ~ KeyCode::Backspace [INFO] [stdout] 1146 ~ if !self.process_filter.is_empty() && self.process_filter != "_".to_string() => { [INFO] [stdout] 1147 | self.process_filter.remove(self.process_filter.len() - 2); // there will be a "_" character at the end and we don't want to remove that [INFO] [stdout] 1148 | self.process_selected_state.select(None); [INFO] [stdout] 1149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:1146:78 [INFO] [stdout] | [INFO] [stdout] 1146 | if !self.process_filter.is_empty() && self.process_filter != "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:1348:20 [INFO] [stdout] | [INFO] [stdout] 1348 | if !self [INFO] [stdout] | ____________________^ [INFO] [stdout] 1349 | | .current_process_signal_state_data [INFO] [stdout] 1350 | | .as_ref() [INFO] [stdout] 1351 | | .unwrap() [INFO] [stdout] 1352 | | .signal_id [INFO] [stdout] 1353 | | .is_none() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1348 ~ if self [INFO] [stdout] 1349 + .current_process_signal_state_data [INFO] [stdout] 1350 + .as_ref() [INFO] [stdout] 1351 + .unwrap() [INFO] [stdout] 1352 + .signal_id.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1348:17 [INFO] [stdout] | [INFO] [stdout] 1348 | / if !self [INFO] [stdout] 1349 | | .current_process_signal_state_data [INFO] [stdout] 1350 | | .as_ref() [INFO] [stdout] 1351 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 1394 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1347 ~ KeyCode::Backspace [INFO] [stdout] 1348 | if !self [INFO] [stdout] ... [INFO] [stdout] 1353 | .is_none() [INFO] [stdout] 1354 ~ => { [INFO] [stdout] 1355 | if self [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] 1394 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/cpu.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn draw_cpu_info( [INFO] [stdout] 17 | | tick: u64, [INFO] [stdout] 18 | | cpus: &Vec, [INFO] [stdout] 19 | | size: Rect, [INFO] [stdout] ... | [INFO] [stdout] 24 | | app_color_info: &AppColorInfo, [INFO] [stdout] 25 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/components/cpu.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | cpus: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - cpus: &Vec, [INFO] [stdout] 18 + cpus: &[CpuData], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/cpu.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | let name = format!("{}", cpu.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `cpu.id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/disk.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn draw_disk_info( [INFO] [stdout] 20 | | tick: u64, [INFO] [stdout] 21 | | disk_data: &DiskData, [INFO] [stdout] 22 | | area: Rect, [INFO] [stdout] ... | [INFO] [stdout] 27 | | is_full_screen: bool, [INFO] [stdout] 28 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/disk.rs:209:40 [INFO] [stdout] | [INFO] [stdout] 209 | let file_system_usage = Line::from(format!("{}", file_system)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `file_system.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/disk.rs:244:40 [INFO] [stdout] | [INFO] [stdout] 244 | let mount_point_usage = Line::from(format!("{}", mount_point)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `mount_point.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/disk.rs:266:38 [INFO] [stdout] | [INFO] [stdout] 266 | let disk_kind_usage = Line::from(format!("{}", disk_data.disk_kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `disk_data.disk_kind.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/disk.rs:323:55 [INFO] [stdout] | [INFO] [stdout] 323 | (usage / current_max_written_bytes) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/memory.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn draw_memory_info( [INFO] [stdout] 22 | | tick: u64, [INFO] [stdout] 23 | | memory: &MemoryData, [INFO] [stdout] 24 | | area: Rect, [INFO] [stdout] ... | [INFO] [stdout] 29 | | is_full_screen: bool, [INFO] [stdout] 30 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:178:53 [INFO] [stdout] | [INFO] [stdout] 178 | let y = (usage / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:250:54 [INFO] [stdout] | [INFO] [stdout] 250 | let y = (remain / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:321:52 [INFO] [stdout] | [INFO] [stdout] 321 | let y = (free / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:394:77 [INFO] [stdout] | [INFO] [stdout] 394 | (swap.min(memory.total_memory) / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:469:23 [INFO] [stdout] | [INFO] [stdout] 469 | * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/network.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn draw_network_info( [INFO] [stdout] 20 | | tick: u64, [INFO] [stdout] 21 | | network_data: &NetworkData, [INFO] [stdout] 22 | | area: Rect, [INFO] [stdout] ... | [INFO] [stdout] 27 | | is_full_screen: bool, [INFO] [stdout] 28 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `network_data.ip_network` after checking its variant with `is_some` [INFO] [stdout] --> src/components/network.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 70 | if network_data.ip_network.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = &network_data.ip_network` [INFO] [stdout] 71 | main_block = main_block.title( [INFO] [stdout] 72 | Line::from(format!(" {} ", network_data.ip_network.as_ref().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/network.rs:167:58 [INFO] [stdout] | [INFO] [stdout] 167 | (usage / current_max_network_received) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/network.rs:261:61 [INFO] [stdout] | [INFO] [stdout] 261 | (usage / current_max_network_transmitted) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (18/7) [INFO] [stdout] --> src/components/process.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn draw_process_info( [INFO] [stdout] 39 | | tick: u64, [INFO] [stdout] 40 | | process_data: &HashMap, [INFO] [stdout] 41 | | process_current_list: &mut Vec, [INFO] [stdout] ... | [INFO] [stdout] 56 | | is_full_screen: bool, [INFO] [stdout] 57 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/components/process.rs:157:59 [INFO] [stdout] | [INFO] [stdout] 157 | if process_filter.is_empty() || process_filter == "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/components/process.rs:184:38 [INFO] [stdout] | [INFO] [stdout] 184 | let is_process_selected = if let Some(_) = process_selected_state.selected() { [INFO] [stdout] | -------^^^^^^^------------------------------------ help: try: `if process_selected_state.selected().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/components/process.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 192 | / let is_eol = if selected + 1 == *process_selectable_entries { [INFO] [stdout] 193 | | true [INFO] [stdout] 194 | | } else { [INFO] [stdout] 195 | | false [INFO] [stdout] 196 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 197 | [INFO] [stdout] 198 | is_eol [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 192 ~ [INFO] [stdout] 193 | [INFO] [stdout] 194 ~ if selected + 1 == *process_selectable_entries { [INFO] [stdout] 195 + true [INFO] [stdout] 196 + } else { [INFO] [stdout] 197 + false [INFO] [stdout] 198 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/components/process.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | let is_eol = if selected + 1 == *process_selectable_entries { [INFO] [stdout] | ______________________^ [INFO] [stdout] 193 | | true [INFO] [stdout] 194 | | } else { [INFO] [stdout] 195 | | false [INFO] [stdout] 196 | | }; [INFO] [stdout] | |_________^ help: you can reduce it to: `selected + 1 == *process_selectable_entries` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/components/process.rs:356:32 [INFO] [stdout] | [INFO] [stdout] 356 | if let Some(_) = process_selected_state.selected() { [INFO] [stdout] | -------^^^^^^^------------------------------------ help: try: `if process_selected_state.selected().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/components/process.rs:365:33 [INFO] [stdout] | [INFO] [stdout] 365 | / ... if value.status == "killed".to_string() { [INFO] [stdout] 366 | | ... true [INFO] [stdout] 367 | | ... } else { [INFO] [stdout] 368 | | ... false [INFO] [stdout] 369 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `value.status == "killed".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/components/process.rs:365:52 [INFO] [stdout] | [INFO] [stdout] 365 | ... if value.status == "killed".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"killed"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/process.rs:842:48 [INFO] [stdout] | [INFO] [stdout] 842 | let total_io_read_detail = format!( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 843 | | "{}", [INFO] [stdout] 844 | | process_to_kib_mib_gib(value.total_read_disk_usage as f64) [INFO] [stdout] 845 | | ); // this will be render at the extra detail row [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `process_to_kib_mib_gib(value.total_read_disk_usage as f64).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/process.rs:850:49 [INFO] [stdout] | [INFO] [stdout] 850 | let total_io_write_detail = format!( [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 851 | | "{}", [INFO] [stdout] 852 | | process_to_kib_mib_gib(value.total_write_disk_usage as f64) [INFO] [stdout] 853 | | ); // this will be render at the extra detail row [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `process_to_kib_mib_gib(value.total_write_disk_usage as f64).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `c_sys_info` after checking its variant with `is_ok` [INFO] [stdout] --> src/app.rs:190:54 [INFO] [stdout] | [INFO] [stdout] 189 | if c_sys_info.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = c_sys_info` [INFO] [stdout] 190 | process_sys_info(&mut self.sys_info, c_sys_info.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `c_process_info` after checking its variant with `is_ok` [INFO] [stdout] --> src/app.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 194 | if c_process_info.is_ok() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = c_process_info` [INFO] [stdout] ... [INFO] [stdout] 197 | c_process_info.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | / if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 291 | | true [INFO] [stdout] 292 | | } else { [INFO] [stdout] 293 | | false [INFO] [stdout] 294 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | / if self.selected_container == SelectedContainer::Memory { [INFO] [stdout] 305 | | true [INFO] [stdout] 306 | | } else { [INFO] [stdout] 307 | | false [INFO] [stdout] 308 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/process.rs:1060:58 [INFO] [stdout] | [INFO] [stdout] 1060 | ... (usage / total_memory) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | &selected_disk, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `selected_disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:319:25 [INFO] [stdout] | [INFO] [stdout] 319 | / if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 320 | | true [INFO] [stdout] 321 | | } else { [INFO] [stdout] 322 | | false [INFO] [stdout] 323 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:330:25 [INFO] [stdout] | [INFO] [stdout] 330 | &selected_network, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `selected_network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:334:25 [INFO] [stdout] | [INFO] [stdout] 334 | / if self.selected_container == SelectedContainer::Network { [INFO] [stdout] 335 | | true [INFO] [stdout] 336 | | } else { [INFO] [stdout] 337 | | false [INFO] [stdout] 338 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:359:25 [INFO] [stdout] | [INFO] [stdout] 359 | / if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 360 | | true [INFO] [stdout] 361 | | } else { [INFO] [stdout] 362 | | false [INFO] [stdout] 363 | | }, [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Process` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:376:21 [INFO] [stdout] | [INFO] [stdout] 376 | / if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 377 | | true [INFO] [stdout] 378 | | } else { [INFO] [stdout] 379 | | false [INFO] [stdout] 380 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | / if self.selected_container == SelectedContainer::Memory { [INFO] [stdout] 391 | | true [INFO] [stdout] 392 | | } else { [INFO] [stdout] 393 | | false [INFO] [stdout] 394 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:401:21 [INFO] [stdout] | [INFO] [stdout] 401 | &selected_disk, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `selected_disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:405:21 [INFO] [stdout] | [INFO] [stdout] 405 | / if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 406 | | true [INFO] [stdout] 407 | | } else { [INFO] [stdout] 408 | | false [INFO] [stdout] 409 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Disk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:416:21 [INFO] [stdout] | [INFO] [stdout] 416 | &selected_network, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `selected_network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | / if self.selected_container == SelectedContainer::Network { [INFO] [stdout] 421 | | true [INFO] [stdout] 422 | | } else { [INFO] [stdout] 423 | | false [INFO] [stdout] 424 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Network` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/app.rs:445:21 [INFO] [stdout] | [INFO] [stdout] 445 | / if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 446 | | true [INFO] [stdout] 447 | | } else { [INFO] [stdout] 448 | | false [INFO] [stdout] 449 | | }, [INFO] [stdout] | |_____________________^ help: you can reduce it to: `self.selected_container == SelectedContainer::Process` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:830:44 [INFO] [stdout] | [INFO] [stdout] 827 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 830 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 831 | | .current_showing_process_detail [INFO] [stdout] 832 | | .as_ref() [INFO] [stdout] 833 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:865:44 [INFO] [stdout] | [INFO] [stdout] 862 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 865 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 866 | | .current_showing_process_detail [INFO] [stdout] 867 | | .as_ref() [INFO] [stdout] 868 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:901:44 [INFO] [stdout] | [INFO] [stdout] 898 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 901 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 902 | | .current_showing_process_detail [INFO] [stdout] 903 | | .as_ref() [INFO] [stdout] 904 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:937:44 [INFO] [stdout] | [INFO] [stdout] 934 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 937 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 938 | | .current_showing_process_detail [INFO] [stdout] 939 | | .as_ref() [INFO] [stdout] 940 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:973:44 [INFO] [stdout] | [INFO] [stdout] 970 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 973 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 974 | | .current_showing_process_detail [INFO] [stdout] 975 | | .as_ref() [INFO] [stdout] 976 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current_showing_process_detail` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:1010:44 [INFO] [stdout] | [INFO] [stdout] 1007 | && self.current_showing_process_detail.is_some() [INFO] [stdout] | --------------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 1010 | let (key, value) = self [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 1011 | | .current_showing_process_detail [INFO] [stdout] 1012 | | .as_ref() [INFO] [stdout] 1013 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:491:17 [INFO] [stdout] | [INFO] [stdout] 491 | / if self.state == AppState::View { [INFO] [stdout] 492 | | // quit the ratatui terminal user interface [INFO] [stdout] 493 | | if self.selected_container == SelectedContainer::None { [INFO] [stdout] 494 | | self.is_quit = true; [INFO] [stdout] ... | [INFO] [stdout] 502 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 490 ~ KeyCode::Esc [INFO] [stdout] 491 ~ if self.state == AppState::View => { [INFO] [stdout] 492 | // quit the ratatui terminal user interface [INFO] [stdout] ... [INFO] [stdout] 501 | } [INFO] [stdout] 502 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:506:17 [INFO] [stdout] | [INFO] [stdout] 506 | / if self.state == AppState::View { [INFO] [stdout] 507 | | if self.tick > 100 { [INFO] [stdout] 508 | | self.tick -= 100; [INFO] [stdout] 509 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 512 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 505 ~ KeyCode::Char('-') [INFO] [stdout] 506 ~ if self.state == AppState::View => { [INFO] [stdout] 507 | if self.tick > 100 { [INFO] [stdout] ... [INFO] [stdout] 511 | } [INFO] [stdout] 512 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:515:17 [INFO] [stdout] | [INFO] [stdout] 515 | / if self.state == AppState::View { [INFO] [stdout] 516 | | if self.tick < 10000 { [INFO] [stdout] 517 | | self.tick += 100; [INFO] [stdout] 518 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 521 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 514 ~ KeyCode::Char('+') [INFO] [stdout] 515 ~ if self.state == AppState::View => { [INFO] [stdout] 516 | if self.tick < 10000 { [INFO] [stdout] ... [INFO] [stdout] 520 | } [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:525:17 [INFO] [stdout] | [INFO] [stdout] 525 | / if self.state == AppState::View { [INFO] [stdout] 526 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 527 | | if let Some(selected) = self.cpu_selected_state.selected() { [INFO] [stdout] 528 | | if selected > 0 { [INFO] [stdout] ... | [INFO] [stdout] 544 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 524 ~ KeyCode::Up [INFO] [stdout] 525 ~ if self.state == AppState::View => { [INFO] [stdout] 526 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 543 | } [INFO] [stdout] 544 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | / if self.state == AppState::View { [INFO] [stdout] 548 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 549 | | if let Some(selected) = self.cpu_selected_state.selected() { [INFO] [stdout] 550 | | if selected < self.sys_info.cpus.len().saturating_sub(1) { [INFO] [stdout] ... | [INFO] [stdout] 565 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ KeyCode::Down [INFO] [stdout] 547 ~ if self.state == AppState::View => { [INFO] [stdout] 548 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 564 | } [INFO] [stdout] 565 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:568:17 [INFO] [stdout] | [INFO] [stdout] 568 | / if self.state == AppState::View { [INFO] [stdout] 569 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 570 | | if self.cpu_graph_shown_range > 100 { [INFO] [stdout] 571 | | self.cpu_graph_shown_range -= 10; [INFO] [stdout] ... | [INFO] [stdout] 606 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 567 ~ KeyCode::Char('[') [INFO] [stdout] 568 ~ if self.state == AppState::View => { [INFO] [stdout] 569 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 605 | } [INFO] [stdout] 606 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:610:17 [INFO] [stdout] | [INFO] [stdout] 610 | / if self.state == AppState::View { [INFO] [stdout] 611 | | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] 612 | | if self.cpu_graph_shown_range < MAX_GRAPH_SHOWN_RANGE { [INFO] [stdout] 613 | | self.cpu_graph_shown_range += 10; [INFO] [stdout] ... | [INFO] [stdout] 648 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 609 ~ KeyCode::Char(']') [INFO] [stdout] 610 ~ if self.state == AppState::View => { [INFO] [stdout] 611 | if self.selected_container == SelectedContainer::Cpu { [INFO] [stdout] ... [INFO] [stdout] 647 | } [INFO] [stdout] 648 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:653:17 [INFO] [stdout] | [INFO] [stdout] 653 | / if self.state == AppState::View { [INFO] [stdout] 654 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 655 | | || self.selected_container != SelectedContainer::Cpu [INFO] [stdout] ... | [INFO] [stdout] 662 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 652 ~ KeyCode::Char('c') [INFO] [stdout] 653 ~ if self.state == AppState::View => { [INFO] [stdout] 654 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 661 | } [INFO] [stdout] 662 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:665:17 [INFO] [stdout] | [INFO] [stdout] 665 | / if self.state == AppState::View { [INFO] [stdout] 666 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 667 | | || self.selected_container != SelectedContainer::Cpu [INFO] [stdout] ... | [INFO] [stdout] 674 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 664 ~ KeyCode::Char('C') [INFO] [stdout] 665 ~ if self.state == AppState::View => { [INFO] [stdout] 666 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] 674 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:679:17 [INFO] [stdout] | [INFO] [stdout] 679 | / if self.state == AppState::View { [INFO] [stdout] 680 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 681 | | || self.selected_container != SelectedContainer::Memory [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 678 ~ KeyCode::Char('m') [INFO] [stdout] 679 ~ if self.state == AppState::View => { [INFO] [stdout] 680 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 687 | } [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:691:17 [INFO] [stdout] | [INFO] [stdout] 691 | / if self.state == AppState::View { [INFO] [stdout] 692 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 693 | | || self.selected_container != SelectedContainer::Memory [INFO] [stdout] ... | [INFO] [stdout] 700 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 690 ~ KeyCode::Char('M') [INFO] [stdout] 691 ~ if self.state == AppState::View => { [INFO] [stdout] 692 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 699 | } [INFO] [stdout] 700 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:705:17 [INFO] [stdout] | [INFO] [stdout] 705 | / if self.state == AppState::View { [INFO] [stdout] 706 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 707 | | || self.selected_container != SelectedContainer::Disk [INFO] [stdout] ... | [INFO] [stdout] 714 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 704 ~ KeyCode::Char('d') [INFO] [stdout] 705 ~ if self.state == AppState::View => { [INFO] [stdout] 706 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 713 | } [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:717:17 [INFO] [stdout] | [INFO] [stdout] 717 | / if self.state == AppState::View { [INFO] [stdout] 718 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 719 | | || self.selected_container != SelectedContainer::Disk [INFO] [stdout] ... | [INFO] [stdout] 726 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 716 ~ KeyCode::Char('D') [INFO] [stdout] 717 ~ if self.state == AppState::View => { [INFO] [stdout] 718 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 725 | } [INFO] [stdout] 726 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:731:17 [INFO] [stdout] | [INFO] [stdout] 731 | / if self.state == AppState::View { [INFO] [stdout] 732 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 733 | | || self.selected_container != SelectedContainer::Network [INFO] [stdout] ... | [INFO] [stdout] 740 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 730 ~ KeyCode::Char('n') [INFO] [stdout] 731 ~ if self.state == AppState::View => { [INFO] [stdout] 732 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 739 | } [INFO] [stdout] 740 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:743:17 [INFO] [stdout] | [INFO] [stdout] 743 | / if self.state == AppState::View { [INFO] [stdout] 744 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 745 | | || self.selected_container != SelectedContainer::Network [INFO] [stdout] ... | [INFO] [stdout] 752 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 742 ~ KeyCode::Char('N') [INFO] [stdout] 743 ~ if self.state == AppState::View => { [INFO] [stdout] 744 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 751 | } [INFO] [stdout] 752 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:757:17 [INFO] [stdout] | [INFO] [stdout] 757 | / if self.state == AppState::View { [INFO] [stdout] 758 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 759 | | || self.selected_container != SelectedContainer::Process [INFO] [stdout] ... | [INFO] [stdout] 766 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 756 ~ KeyCode::Char('p') [INFO] [stdout] 757 ~ if self.state == AppState::View => { [INFO] [stdout] 758 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 765 | } [INFO] [stdout] 766 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:769:17 [INFO] [stdout] | [INFO] [stdout] 769 | / if self.state == AppState::View { [INFO] [stdout] 770 | | if self.selected_container == SelectedContainer::None [INFO] [stdout] 771 | | || self.selected_container != SelectedContainer::Process [INFO] [stdout] ... | [INFO] [stdout] 778 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 768 ~ KeyCode::Char('P') [INFO] [stdout] 769 ~ if self.state == AppState::View => { [INFO] [stdout] 770 | if self.selected_container == SelectedContainer::None [INFO] [stdout] ... [INFO] [stdout] 777 | } [INFO] [stdout] 778 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | / if self.state == AppState::View { [INFO] [stdout] 783 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 784 | | if self.process_sort_is_reversed { [INFO] [stdout] 785 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 790 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 781 ~ KeyCode::Char('R') [INFO] [stdout] 782 ~ if self.state == AppState::View => { [INFO] [stdout] 783 | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] ... [INFO] [stdout] 789 | } [INFO] [stdout] 790 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:794:17 [INFO] [stdout] | [INFO] [stdout] 794 | / if self.state == AppState::View { [INFO] [stdout] 795 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 796 | | if self.process_sort_is_reversed { [INFO] [stdout] 797 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 802 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 793 ~ KeyCode::Char('r') [INFO] [stdout] 794 ~ if self.state == AppState::View => { [INFO] [stdout] 795 | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] ... [INFO] [stdout] 801 | } [INFO] [stdout] 802 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:806:17 [INFO] [stdout] | [INFO] [stdout] 806 | / if self.state == AppState::View { [INFO] [stdout] 807 | | self.state = AppState::Typing; [INFO] [stdout] 808 | | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] 809 | | self.process_filter = "_".to_string(); [INFO] [stdout] 810 | | } [INFO] [stdout] 811 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 805 ~ KeyCode::Char('f') [INFO] [stdout] 806 ~ if self.state == AppState::View => { [INFO] [stdout] 807 | self.state = AppState::Typing; [INFO] [stdout] ... [INFO] [stdout] 810 | } [INFO] [stdout] 811 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/components/process.rs:1420:30 [INFO] [stdout] | [INFO] [stdout] 1420 | let command = if value.cmd.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.cmd.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:815:17 [INFO] [stdout] | [INFO] [stdout] 815 | / if self.state == AppState::View { [INFO] [stdout] 816 | | self.state = AppState::Typing; [INFO] [stdout] 817 | | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] 818 | | self.process_filter = "_".to_string(); [INFO] [stdout] 819 | | } [INFO] [stdout] 820 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 814 ~ KeyCode::Char('F') [INFO] [stdout] 815 ~ if self.state == AppState::View => { [INFO] [stdout] 816 | self.state = AppState::Typing; [INFO] [stdout] ... [INFO] [stdout] 819 | } [INFO] [stdout] 820 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:824:17 [INFO] [stdout] | [INFO] [stdout] 824 | / if self.state == AppState::View { [INFO] [stdout] 825 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 826 | | && self.process_show_details [INFO] [stdout] 827 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 855 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 823 ~ KeyCode::Char('K') [INFO] [stdout] 824 ~ if self.state == AppState::View => { [INFO] [stdout] 825 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 854 | } [INFO] [stdout] 855 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | / if self.state == AppState::View { [INFO] [stdout] 860 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 861 | | && self.process_show_details [INFO] [stdout] 862 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 891 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 858 ~ KeyCode::Char('k') [INFO] [stdout] 859 ~ if self.state == AppState::View => { [INFO] [stdout] 860 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 890 | } [INFO] [stdout] 891 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:895:17 [INFO] [stdout] | [INFO] [stdout] 895 | / if self.state == AppState::View { [INFO] [stdout] 896 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 897 | | && self.process_show_details [INFO] [stdout] 898 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 894 ~ KeyCode::Char('T') [INFO] [stdout] 895 ~ if self.state == AppState::View => { [INFO] [stdout] 896 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 926 | } [INFO] [stdout] 927 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:931:17 [INFO] [stdout] | [INFO] [stdout] 931 | / if self.state == AppState::View { [INFO] [stdout] 932 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 933 | | && self.process_show_details [INFO] [stdout] 934 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 963 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 930 ~ KeyCode::Char('t') [INFO] [stdout] 931 ~ if self.state == AppState::View => { [INFO] [stdout] 932 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 962 | } [INFO] [stdout] 963 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:967:17 [INFO] [stdout] | [INFO] [stdout] 967 | / if self.state == AppState::View { [INFO] [stdout] 968 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 969 | | && self.process_show_details [INFO] [stdout] 970 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1000 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 966 ~ KeyCode::Char('S') [INFO] [stdout] 967 ~ if self.state == AppState::View => { [INFO] [stdout] 968 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 999 | } [INFO] [stdout] 1000 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1004:17 [INFO] [stdout] | [INFO] [stdout] 1004 | / if self.state == AppState::View { [INFO] [stdout] 1005 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 1006 | | && self.process_show_details [INFO] [stdout] 1007 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1037 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1003 ~ KeyCode::Char('s') [INFO] [stdout] 1004 ~ if self.state == AppState::View => { [INFO] [stdout] 1005 | if self.selected_container == SelectedContainer::Process [INFO] [stdout] ... [INFO] [stdout] 1036 | } [INFO] [stdout] 1037 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1041:17 [INFO] [stdout] | [INFO] [stdout] 1041 | / if self.state == AppState::View { [INFO] [stdout] 1042 | | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 1043 | | if self.disk_selected_entry == 0 { [INFO] [stdout] 1044 | | self.disk_selected_entry = self.sys_info.disks.len() - 1; [INFO] [stdout] ... | [INFO] [stdout] 1065 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1040 ~ KeyCode::Left [INFO] [stdout] 1041 ~ if self.state == AppState::View => { [INFO] [stdout] 1042 | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] ... [INFO] [stdout] 1064 | } [INFO] [stdout] 1065 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1068:17 [INFO] [stdout] | [INFO] [stdout] 1068 | / if self.state == AppState::View { [INFO] [stdout] 1069 | | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] 1070 | | if self.disk_selected_entry == self.sys_info.disks.len() - 1 { [INFO] [stdout] 1071 | | self.disk_selected_entry = 0 [INFO] [stdout] ... | [INFO] [stdout] 1093 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1067 ~ KeyCode::Right [INFO] [stdout] 1068 ~ if self.state == AppState::View => { [INFO] [stdout] 1069 | if self.selected_container == SelectedContainer::Disk { [INFO] [stdout] ... [INFO] [stdout] 1092 | } [INFO] [stdout] 1093 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1097:17 [INFO] [stdout] | [INFO] [stdout] 1097 | / if self.state == AppState::View { [INFO] [stdout] 1098 | | self.process_filter = "".to_string(); [INFO] [stdout] 1099 | | self.process_selected_state.select(None); [INFO] [stdout] 1100 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1096 ~ KeyCode::Backspace [INFO] [stdout] 1097 ~ if self.state == AppState::View => { [INFO] [stdout] 1098 | self.process_filter = "".to_string(); [INFO] [stdout] 1099 | self.process_selected_state.select(None); [INFO] [stdout] 1100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1104:17 [INFO] [stdout] | [INFO] [stdout] 1104 | / if self.state == AppState::View { [INFO] [stdout] 1105 | | // for a container to be full screen, it need to be selected first [INFO] [stdout] 1106 | | if self.container_full_screen [INFO] [stdout] 1107 | | && self.selected_container != SelectedContainer::None [INFO] [stdout] ... | [INFO] [stdout] 1115 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1103 ~ KeyCode::Tab [INFO] [stdout] 1104 ~ if self.state == AppState::View => { [INFO] [stdout] 1105 | // for a container to be full screen, it need to be selected first [INFO] [stdout] ... [INFO] [stdout] 1114 | } [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1119:17 [INFO] [stdout] | [INFO] [stdout] 1119 | / if self.state == AppState::View { [INFO] [stdout] 1120 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 1121 | | if let Some(selected) = self.process_selected_state.selected() { [INFO] [stdout] 1122 | | self.process_show_details = true; [INFO] [stdout] ... | [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1118 ~ KeyCode::Enter [INFO] [stdout] 1119 ~ if self.state == AppState::View => { [INFO] [stdout] 1120 | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] ... [INFO] [stdout] 1136 | } [INFO] [stdout] 1137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:506:17 [INFO] [stdout] | [INFO] [stdout] 506 | / if self.state == AppState::View { [INFO] [stdout] 507 | | if self.tick > 100 { [INFO] [stdout] 508 | | self.tick -= 100; [INFO] [stdout] 509 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 512 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 506 ~ if self.state == AppState::View [INFO] [stdout] 507 ~ && self.tick > 100 { [INFO] [stdout] 508 | self.tick -= 100; [INFO] [stdout] 509 | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 510 | self.process_tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 511 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:515:17 [INFO] [stdout] | [INFO] [stdout] 515 | / if self.state == AppState::View { [INFO] [stdout] 516 | | if self.tick < 10000 { [INFO] [stdout] 517 | | self.tick += 100; [INFO] [stdout] 518 | | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 521 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 515 ~ if self.state == AppState::View [INFO] [stdout] 516 ~ && self.tick < 10000 { [INFO] [stdout] 517 | self.tick += 100; [INFO] [stdout] 518 | self.tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 519 | self.process_tick_tx.send(self.tick).unwrap(); [INFO] [stdout] 520 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/components/process.rs:1541:35 [INFO] [stdout] | [INFO] [stdout] 1541 | *process_selectable_entries = process_list.len() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `process_list.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | "default" => return DEFAULT, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - "default" => return DEFAULT, [INFO] [stdout] 55 + "default" => DEFAULT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | "dracula" => return DRACULA, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - "dracula" => return DRACULA, [INFO] [stdout] 56 + "dracula" => DRACULA, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 57 | "gruvbox_dark" => return GRUVBOX_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - "gruvbox_dark" => return GRUVBOX_DARK, [INFO] [stdout] 57 + "gruvbox_dark" => GRUVBOX_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | "gruvbox_light" => return GRUVBOX_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - "gruvbox_light" => return GRUVBOX_LIGHT, [INFO] [stdout] 58 + "gruvbox_light" => GRUVBOX_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | "gruvbox_mat_dark" => return GRUVBOX_MAT_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - "gruvbox_mat_dark" => return GRUVBOX_MAT_DARK, [INFO] [stdout] 59 + "gruvbox_mat_dark" => GRUVBOX_MAT_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | "ayu" => return AYU, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - "ayu" => return AYU, [INFO] [stdout] 60 + "ayu" => AYU, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | "everforest_dark" => return EVERFOREST_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - "everforest_dark" => return EVERFOREST_DARK, [INFO] [stdout] 61 + "everforest_dark" => EVERFOREST_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | "everforest_light" => return EVERFOREST_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - "everforest_light" => return EVERFOREST_LIGHT, [INFO] [stdout] 62 + "everforest_light" => EVERFOREST_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | "flatremix" => return FLATREMIX, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - "flatremix" => return FLATREMIX, [INFO] [stdout] 63 + "flatremix" => FLATREMIX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:64:30 [INFO] [stdout] | [INFO] [stdout] 64 | "flatremix_light" => return FLATREMIX_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - "flatremix_light" => return FLATREMIX_LIGHT, [INFO] [stdout] 64 + "flatremix_light" => FLATREMIX_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:65:24 [INFO] [stdout] | [INFO] [stdout] 65 | "grayscale" => return GRAYSCALE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - "grayscale" => return GRAYSCALE, [INFO] [stdout] 65 + "grayscale" => GRAYSCALE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | "horizon" => return HORIZON, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - "horizon" => return HORIZON, [INFO] [stdout] 66 + "horizon" => HORIZON, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:67:28 [INFO] [stdout] | [INFO] [stdout] 67 | "kanagawa_wave" => return KANAGAWA_WAVE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - "kanagawa_wave" => return KANAGAWA_WAVE, [INFO] [stdout] 67 + "kanagawa_wave" => KANAGAWA_WAVE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 68 | "kanagawa_lotus" => return KANAGAWA_LOTUS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - "kanagawa_lotus" => return KANAGAWA_LOTUS, [INFO] [stdout] 68 + "kanagawa_lotus" => KANAGAWA_LOTUS, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:69:22 [INFO] [stdout] | [INFO] [stdout] 69 | "monokai" => return MONOKAI, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - "monokai" => return MONOKAI, [INFO] [stdout] 69 + "monokai" => MONOKAI, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | "onedark" => return ONEDARK, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - "onedark" => return ONEDARK, [INFO] [stdout] 70 + "onedark" => ONEDARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | "nightowl" => return NIGHT_OWL, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - "nightowl" => return NIGHT_OWL, [INFO] [stdout] 71 + "nightowl" => NIGHT_OWL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | "rosepine" => return ROSE_PINE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - "rosepine" => return ROSE_PINE, [INFO] [stdout] 72 + "rosepine" => ROSE_PINE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 73 | "matcha_dark_sea" => return MATCHA_DARK_SEA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - "matcha_dark_sea" => return MATCHA_DARK_SEA, [INFO] [stdout] 73 + "matcha_dark_sea" => MATCHA_DARK_SEA, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | "paper" => return PAPER, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - "paper" => return PAPER, [INFO] [stdout] 74 + "paper" => PAPER, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | "solarized_dark" => return SOLARIZED_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - "solarized_dark" => return SOLARIZED_DARK, [INFO] [stdout] 75 + "solarized_dark" => SOLARIZED_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:76:30 [INFO] [stdout] | [INFO] [stdout] 76 | "solarized_light" => return SOLARIZED_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - "solarized_light" => return SOLARIZED_LIGHT, [INFO] [stdout] 76 + "solarized_light" => SOLARIZED_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:77:26 [INFO] [stdout] | [INFO] [stdout] 77 | "tokyo_night" => return TOKYO_NIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - "tokyo_night" => return TOKYO_NIGHT, [INFO] [stdout] 77 + "tokyo_night" => TOKYO_NIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:78:26 [INFO] [stdout] | [INFO] [stdout] 78 | "tokyo_storm" => return TOKYO_STORM, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - "tokyo_storm" => return TOKYO_STORM, [INFO] [stdout] 78 + "tokyo_storm" => TOKYO_STORM, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | "catppuccin_mocha" => return CATPPUCCIN_MOCHA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - "catppuccin_mocha" => return CATPPUCCIN_MOCHA, [INFO] [stdout] 79 + "catppuccin_mocha" => CATPPUCCIN_MOCHA, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | "github_dark" => return GITHUB_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - "github_dark" => return GITHUB_DARK, [INFO] [stdout] 80 + "github_dark" => GITHUB_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 81 | _ => return DEFAULT, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - _ => return DEFAULT, [INFO] [stdout] 81 + _ => DEFAULT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i8` is unnecessary [INFO] [stdout] --> src/get_sys_info.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | id: -1 as i8, [INFO] [stdout] | ^^^^^^^^ help: try: `-1_i8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/get_sys_info.rs:131:44 [INFO] [stdout] | [INFO] [stdout] 131 | ... ip_network: if network_data.ip_networks().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!network_data.ip_networks().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `u` after checking its variant with `is_some` [INFO] [stdout] --> src/get_sys_info.rs:233:40 [INFO] [stdout] | [INFO] [stdout] 232 | ... if u.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = u` [INFO] [stdout] 233 | ... user = u.unwrap().name(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/get_sys_info.rs:223:82 [INFO] [stdout] | [INFO] [stdout] 223 | let thread_count = get_thread_count(pid.as_u32() as i32, &process, None); [INFO] [stdout] | ^^^^^^^^ help: change this to: `process` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/get_sys_info.rs:247:34 [INFO] [stdout] | [INFO] [stdout] 247 | ... .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_sys_info.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 328 | return thread_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return thread_count; [INFO] [stdout] 328 + thread_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_sys_info.rs:358:5 [INFO] [stdout] | [INFO] [stdout] 358 | return cached_memory; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 - return cached_memory; [INFO] [stdout] 358 + cached_memory [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | / if self.state == AppState::View { [INFO] [stdout] 783 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 784 | | if self.process_sort_is_reversed { [INFO] [stdout] 785 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 790 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 782 ~ if self.state == AppState::View [INFO] [stdout] 783 ~ && self.selected_container == SelectedContainer::Process { [INFO] [stdout] 784 | if self.process_sort_is_reversed { [INFO] [stdout] ... [INFO] [stdout] 788 | } [INFO] [stdout] 789 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/app.rs:784:25 [INFO] [stdout] | [INFO] [stdout] 784 | / if self.process_sort_is_reversed { [INFO] [stdout] 785 | | self.process_sort_is_reversed = false; [INFO] [stdout] 786 | | } else { [INFO] [stdout] 787 | | self.process_sort_is_reversed = true; [INFO] [stdout] 788 | | } [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.process_sort_is_reversed = !self.process_sort_is_reversed;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:794:17 [INFO] [stdout] | [INFO] [stdout] 794 | / if self.state == AppState::View { [INFO] [stdout] 795 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 796 | | if self.process_sort_is_reversed { [INFO] [stdout] 797 | | self.process_sort_is_reversed = false; [INFO] [stdout] ... | [INFO] [stdout] 802 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 794 ~ if self.state == AppState::View [INFO] [stdout] 795 ~ && self.selected_container == SelectedContainer::Process { [INFO] [stdout] 796 | if self.process_sort_is_reversed { [INFO] [stdout] ... [INFO] [stdout] 800 | } [INFO] [stdout] 801 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/app.rs:796:25 [INFO] [stdout] | [INFO] [stdout] 796 | / if self.process_sort_is_reversed { [INFO] [stdout] 797 | | self.process_sort_is_reversed = false; [INFO] [stdout] 798 | | } else { [INFO] [stdout] 799 | | self.process_sort_is_reversed = true; [INFO] [stdout] 800 | | } [INFO] [stdout] | |_________________________^ help: you can reduce it to: `self.process_sort_is_reversed = !self.process_sort_is_reversed;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:808:81 [INFO] [stdout] | [INFO] [stdout] 808 | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:817:81 [INFO] [stdout] | [INFO] [stdout] 817 | if self.process_filter.is_empty() || self.process_filter == "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:824:17 [INFO] [stdout] | [INFO] [stdout] 824 | / if self.state == AppState::View { [INFO] [stdout] 825 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 826 | | && self.process_show_details [INFO] [stdout] 827 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 855 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 824 ~ if self.state == AppState::View [INFO] [stdout] 825 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 826 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 853 | self.pop_up_type = AppPopUpType::KillConfirmation; [INFO] [stdout] 854 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | / if self.state == AppState::View { [INFO] [stdout] 860 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 861 | | && self.process_show_details [INFO] [stdout] 862 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 891 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 859 ~ if self.state == AppState::View [INFO] [stdout] 860 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 861 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 889 | self.pop_up_type = AppPopUpType::KillConfirmation; [INFO] [stdout] 890 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_sys_info.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 409 - return None; [INFO] [stdout] 409 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:895:17 [INFO] [stdout] | [INFO] [stdout] 895 | / if self.state == AppState::View { [INFO] [stdout] 896 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 897 | | && self.process_show_details [INFO] [stdout] 898 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 895 ~ if self.state == AppState::View [INFO] [stdout] 896 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 897 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 925 | self.pop_up_type = AppPopUpType::TerminateConfirmation; [INFO] [stdout] 926 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:931:17 [INFO] [stdout] | [INFO] [stdout] 931 | / if self.state == AppState::View { [INFO] [stdout] 932 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 933 | | && self.process_show_details [INFO] [stdout] 934 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 963 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 931 ~ if self.state == AppState::View [INFO] [stdout] 932 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 933 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 961 | self.pop_up_type = AppPopUpType::TerminateConfirmation; [INFO] [stdout] 962 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:967:17 [INFO] [stdout] | [INFO] [stdout] 967 | / if self.state == AppState::View { [INFO] [stdout] 968 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 969 | | && self.process_show_details [INFO] [stdout] 970 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1000 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 967 ~ if self.state == AppState::View [INFO] [stdout] 968 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 969 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 998 | self.pop_up_type = AppPopUpType::SignalMenu; [INFO] [stdout] 999 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/types.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | / pub fn default() -> MemoryData { [INFO] [stdout] 180 | | MemoryData { [INFO] [stdout] 181 | | total_memory: -1.0, [INFO] [stdout] 182 | | available_memory_vec: vec![0.0], [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/types.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | / return MemoryData { [INFO] [stdout] 199 | | total_memory: total, [INFO] [stdout] 200 | | available_memory_vec: vec![available], [INFO] [stdout] 201 | | used_memory_vec: vec![used], [INFO] [stdout] ... | [INFO] [stdout] 204 | | cached_memory_vec: vec![cached], [INFO] [stdout] 205 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 ~ MemoryData { [INFO] [stdout] 199 + total_memory: total, [INFO] [stdout] 200 + available_memory_vec: vec![available], [INFO] [stdout] 201 + used_memory_vec: vec![used], [INFO] [stdout] 202 + used_swap_vec: vec![used_swap], [INFO] [stdout] 203 + free_memory_vec: vec![free], [INFO] [stdout] 204 + cached_memory_vec: vec![cached], [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/types.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | / pub fn new( [INFO] [stdout] 244 | | name: String, [INFO] [stdout] 245 | | total_space: f64, [INFO] [stdout] 246 | | available_space: f64, [INFO] [stdout] ... | [INFO] [stdout] 252 | | kind: String, [INFO] [stdout] 253 | | ) -> DiskData { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/types.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / pub fn update( [INFO] [stdout] 269 | | &mut self, [INFO] [stdout] 270 | | name: String, [INFO] [stdout] 271 | | total_space: f64, [INFO] [stdout] ... | [INFO] [stdout] 278 | | kind: String, [INFO] [stdout] 279 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1004:17 [INFO] [stdout] | [INFO] [stdout] 1004 | / if self.state == AppState::View { [INFO] [stdout] 1005 | | if self.selected_container == SelectedContainer::Process [INFO] [stdout] 1006 | | && self.process_show_details [INFO] [stdout] 1007 | | && self.current_showing_process_detail.is_some() [INFO] [stdout] ... | [INFO] [stdout] 1037 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1004 ~ if self.state == AppState::View [INFO] [stdout] 1005 ~ && self.selected_container == SelectedContainer::Process [INFO] [stdout] 1006 | && self.process_show_details [INFO] [stdout] ... [INFO] [stdout] 1035 | self.pop_up_type = AppPopUpType::SignalMenu; [INFO] [stdout] 1036 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/types.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | / return NetworkData { [INFO] [stdout] 310 | | interface_name, [INFO] [stdout] 311 | | ip_network, [INFO] [stdout] 312 | | current_received_vec: vec![current_received], [INFO] [stdout] ... | [INFO] [stdout] 316 | | is_updated: true, [INFO] [stdout] 317 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 ~ NetworkData { [INFO] [stdout] 310 + interface_name, [INFO] [stdout] 311 + ip_network, [INFO] [stdout] 312 + current_received_vec: vec![current_received], [INFO] [stdout] 313 + current_transmitted_vec: vec![current_transmitted], [INFO] [stdout] 314 + total_received, [INFO] [stdout] 315 + total_transmitted, [INFO] [stdout] 316 + is_updated: true, [INFO] [stdout] 317 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1119:17 [INFO] [stdout] | [INFO] [stdout] 1119 | / if self.state == AppState::View { [INFO] [stdout] 1120 | | if self.selected_container == SelectedContainer::Process { [INFO] [stdout] 1121 | | if let Some(selected) = self.process_selected_state.selected() { [INFO] [stdout] 1122 | | self.process_show_details = true; [INFO] [stdout] ... | [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1119 ~ if self.state == AppState::View [INFO] [stdout] 1120 ~ && self.selected_container == SelectedContainer::Process { [INFO] [stdout] 1121 | if let Some(selected) = self.process_selected_state.selected() { [INFO] [stdout] ... [INFO] [stdout] 1135 | } [INFO] [stdout] 1136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (15/7) [INFO] [stdout] --> src/types.rs:346:5 [INFO] [stdout] | [INFO] [stdout] 346 | / pub fn new( [INFO] [stdout] 347 | | pid: u32, [INFO] [stdout] 348 | | name: String, [INFO] [stdout] 349 | | exe_path: Option, [INFO] [stdout] ... | [INFO] [stdout] 361 | | total_write_disk_usage: u64, [INFO] [stdout] 362 | | ) -> ProcessData { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/types.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | / return ProcessData { [INFO] [stdout] 364 | | pid, [INFO] [stdout] 365 | | name, [INFO] [stdout] 366 | | exe_path, [INFO] [stdout] ... | [INFO] [stdout] 379 | | total_write_disk_usage, [INFO] [stdout] 380 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 363 ~ ProcessData { [INFO] [stdout] 364 + pid, [INFO] [stdout] 365 + name, [INFO] [stdout] 366 + exe_path, [INFO] [stdout] 367 + cmd, [INFO] [stdout] 368 + user, [INFO] [stdout] 369 + cpu_usage: vec![cpu_usage], [INFO] [stdout] 370 + thread_count, [INFO] [stdout] 371 + memory: vec![memory], [INFO] [stdout] 372 + status, [INFO] [stdout] 373 + elapsed, [INFO] [stdout] 374 + parent, [INFO] [stdout] 375 + is_updated: true, [INFO] [stdout] 376 + current_read_disk_usage, [INFO] [stdout] 377 + total_read_disk_usage, [INFO] [stdout] 378 + current_write_disk_usage, [INFO] [stdout] 379 + total_write_disk_usage, [INFO] [stdout] 380 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1146:17 [INFO] [stdout] | [INFO] [stdout] 1146 | / ... if !self.process_filter.is_empty() && self.process_filter != "_".to_string() { [INFO] [stdout] 1147 | | ... self.process_filter.remove(self.process_filter.len() - 2); // there will be a "_" character at the end and we don't wa... [INFO] [stdout] 1148 | | ... self.process_selected_state.select(None); [INFO] [stdout] 1149 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1145 ~ KeyCode::Backspace [INFO] [stdout] 1146 ~ if !self.process_filter.is_empty() && self.process_filter != "_".to_string() => { [INFO] [stdout] 1147 | self.process_filter.remove(self.process_filter.len() - 2); // there will be a "_" character at the end and we don't want to remove that [INFO] [stdout] 1148 | self.process_selected_state.select(None); [INFO] [stdout] 1149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:1146:78 [INFO] [stdout] | [INFO] [stdout] 1146 | if !self.process_filter.is_empty() && self.process_filter != "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/types.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 383 | / pub fn update( [INFO] [stdout] 384 | | &mut self, [INFO] [stdout] 385 | | pid: u32, [INFO] [stdout] 386 | | name: String, [INFO] [stdout] ... | [INFO] [stdout] 399 | | total_write_disk_usage: u64, [INFO] [stdout] 400 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:1348:20 [INFO] [stdout] | [INFO] [stdout] 1348 | if !self [INFO] [stdout] | ____________________^ [INFO] [stdout] 1349 | | .current_process_signal_state_data [INFO] [stdout] 1350 | | .as_ref() [INFO] [stdout] 1351 | | .unwrap() [INFO] [stdout] 1352 | | .signal_id [INFO] [stdout] 1353 | | .is_none() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1348 ~ if self [INFO] [stdout] 1349 + .current_process_signal_state_data [INFO] [stdout] 1350 + .as_ref() [INFO] [stdout] 1351 + .unwrap() [INFO] [stdout] 1352 + .signal_id.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:1348:17 [INFO] [stdout] | [INFO] [stdout] 1348 | / if !self [INFO] [stdout] 1349 | | .current_process_signal_state_data [INFO] [stdout] 1350 | | .as_ref() [INFO] [stdout] 1351 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 1394 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1347 ~ KeyCode::Backspace [INFO] [stdout] 1348 | if !self [INFO] [stdout] ... [INFO] [stdout] 1353 | .is_none() [INFO] [stdout] 1354 ~ => { [INFO] [stdout] 1355 | if self [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] 1394 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return PathBuf::from(home_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return PathBuf::from(home_dir); [INFO] [stdout] 32 + PathBuf::from(home_dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if current_sys_info.cpus.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_sys_info.cpus.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/utils.rs:50:36 [INFO] [stdout] | [INFO] [stdout] 50 | let cpu = CpuData::new(cpu.id as i8, cpu.brand.clone(), cpu.usage); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `cpu.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/utils.rs:55:63 [INFO] [stdout] | [INFO] [stdout] 55 | current_sys_info.cpus[cpu.id as usize + 1].update(cpu.id as i8, cpu.usage); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `cpu.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if current_sys_info.disks.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_sys_info.disks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/cpu.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn draw_cpu_info( [INFO] [stdout] 17 | | tick: u64, [INFO] [stdout] 18 | | cpus: &Vec, [INFO] [stdout] 19 | | size: Rect, [INFO] [stdout] ... | [INFO] [stdout] 24 | | app_color_info: &AppColorInfo, [INFO] [stdout] 25 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 170 | if current_sys_info.networks.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_sys_info.networks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/components/cpu.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | cpus: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - cpus: &Vec, [INFO] [stdout] 18 + cpus: &[CpuData], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:246:8 [INFO] [stdout] | [INFO] [stdout] 246 | if current_process_info.processes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_process_info.processes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/cpu.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | let name = format!("{}", cpu.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `cpu.id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:377:5 [INFO] [stdout] | [INFO] [stdout] 377 | return refresh_tick; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 377 - return refresh_tick; [INFO] [stdout] 377 + refresh_tick [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | return vec![line]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 - return vec![line]; [INFO] [stdout] 390 + vec![line] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | return line_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return line_vec; [INFO] [stdout] 406 + line_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | return format!("{:.2} {}", ((value * 1000.0).round() / 1000.0), unit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return format!("{:.2} {}", ((value * 1000.0).round() / 1000.0), unit); [INFO] [stdout] 433 + format!("{:.2} {}", ((value * 1000.0).round() / 1000.0), unit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/disk.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn draw_disk_info( [INFO] [stdout] 20 | | tick: u64, [INFO] [stdout] 21 | | disk_data: &DiskData, [INFO] [stdout] 22 | | area: Rect, [INFO] [stdout] ... | [INFO] [stdout] 27 | | is_full_screen: bool, [INFO] [stdout] 28 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | return format!("{}:{}:{}:{}", days, hours, minutes, seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 442 - return format!("{}:{}:{}:{}", days, hours, minutes, seconds); [INFO] [stdout] 442 + format!("{}:{}:{}:{}", days, hours, minutes, seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 444 | return format!("{}:{}:{}", hours, minutes, seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 444 - return format!("{}:{}:{}", hours, minutes, seconds); [INFO] [stdout] 444 + format!("{}:{}:{}", hours, minutes, seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:558:5 [INFO] [stdout] | [INFO] [stdout] 558 | return processes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 558 - return processes; [INFO] [stdout] 558 + processes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/utils.rs:456:43 [INFO] [stdout] | [INFO] [stdout] 456 | let mut processes: Vec = process_data [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 457 | | .iter() [INFO] [stdout] 458 | | .map(|(_, value)| value) [INFO] [stdout] | |________________________________^ help: try: `process_data.values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/disk.rs:209:40 [INFO] [stdout] | [INFO] [stdout] 209 | let file_system_usage = Line::from(format!("{}", file_system)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `file_system.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/disk.rs:244:40 [INFO] [stdout] | [INFO] [stdout] 244 | let mount_point_usage = Line::from(format!("{}", mount_point)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `mount_point.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_process_signal_state_data.signal_id` after checking its variant with `is_none` [INFO] [stdout] --> src/utils.rs:799:21 [INFO] [stdout] | [INFO] [stdout] 796 | if current_process_signal_state_data.signal_id.is_none() { [INFO] [stdout] | -------------------------------------------------------- help: try: `if let Some() = current_process_signal_state_data.signal_id` [INFO] [stdout] ... [INFO] [stdout] 799 | / current_process_signal_state_data [INFO] [stdout] 800 | | .signal_id [INFO] [stdout] 801 | | .unwrap() [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/disk.rs:266:38 [INFO] [stdout] | [INFO] [stdout] 266 | let disk_kind_usage = Line::from(format!("{}", disk_data.disk_kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `disk_data.disk_kind.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/disk.rs:323:55 [INFO] [stdout] | [INFO] [stdout] 323 | (usage / current_max_written_bytes) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/memory.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn draw_memory_info( [INFO] [stdout] 22 | | tick: u64, [INFO] [stdout] 23 | | memory: &MemoryData, [INFO] [stdout] 24 | | area: Rect, [INFO] [stdout] ... | [INFO] [stdout] 29 | | is_full_screen: bool, [INFO] [stdout] 30 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:178:53 [INFO] [stdout] | [INFO] [stdout] 178 | let y = (usage / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:250:54 [INFO] [stdout] | [INFO] [stdout] 250 | let y = (remain / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_selected_signal_id` after checking its variant with `is_some` [INFO] [stdout] --> src/utils.rs:1221:12 [INFO] [stdout] | [INFO] [stdout] 1220 | let signal_id_span = if current_selected_signal_id.is_some() { [INFO] [stdout] | --------------------------------------- help: try: `if let Some() = current_selected_signal_id` [INFO] [stdout] 1221 | if current_selected_signal_id.unwrap() == signal_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_selected_signal_id` after checking its variant with `is_some` [INFO] [stdout] --> src/utils.rs:1241:12 [INFO] [stdout] | [INFO] [stdout] 1240 | let signal_name_span = if current_selected_signal_id.is_some() { [INFO] [stdout] | --------------------------------------- help: try: `if let Some() = current_selected_signal_id` [INFO] [stdout] 1241 | if current_selected_signal_id.unwrap() == signal_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:321:52 [INFO] [stdout] | [INFO] [stdout] 321 | let y = (free / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:394:77 [INFO] [stdout] | [INFO] [stdout] 394 | (swap.min(memory.total_memory) / memory.total_memory) * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/memory.rs:469:23 [INFO] [stdout] | [INFO] [stdout] 469 | * GRAPH_PERCENTAGE as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/components/network.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn draw_network_info( [INFO] [stdout] 20 | | tick: u64, [INFO] [stdout] 21 | | network_data: &NetworkData, [INFO] [stdout] 22 | | area: Rect, [INFO] [stdout] ... | [INFO] [stdout] 27 | | is_full_screen: bool, [INFO] [stdout] 28 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `network_data.ip_network` after checking its variant with `is_some` [INFO] [stdout] --> src/components/network.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 70 | if network_data.ip_network.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = &network_data.ip_network` [INFO] [stdout] 71 | main_block = main_block.title( [INFO] [stdout] 72 | Line::from(format!(" {} ", network_data.ip_network.as_ref().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/network.rs:167:58 [INFO] [stdout] | [INFO] [stdout] 167 | (usage / current_max_network_received) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils.rs:365:52 [INFO] [stdout] | [INFO] [stdout] 365 | pub fn get_tick_line_ui(tick: u64, app_color_info: &AppColorInfo) -> Line { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 365 | pub fn get_tick_line_ui(tick: u64, app_color_info: &AppColorInfo) -> Line<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/network.rs:261:61 [INFO] [stdout] | [INFO] [stdout] 261 | (usage / current_max_network_transmitted) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (18/7) [INFO] [stdout] --> src/components/process.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn draw_process_info( [INFO] [stdout] 39 | | tick: u64, [INFO] [stdout] 40 | | process_data: &HashMap, [INFO] [stdout] 41 | | process_current_list: &mut Vec, [INFO] [stdout] ... | [INFO] [stdout] 56 | | is_full_screen: bool, [INFO] [stdout] 57 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/components/process.rs:157:59 [INFO] [stdout] | [INFO] [stdout] 157 | if process_filter.is_empty() || process_filter == "_".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/components/process.rs:184:38 [INFO] [stdout] | [INFO] [stdout] 184 | let is_process_selected = if let Some(_) = process_selected_state.selected() { [INFO] [stdout] | -------^^^^^^^------------------------------------ help: try: `if process_selected_state.selected().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/components/process.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 192 | / let is_eol = if selected + 1 == *process_selectable_entries { [INFO] [stdout] 193 | | true [INFO] [stdout] 194 | | } else { [INFO] [stdout] 195 | | false [INFO] [stdout] 196 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 197 | [INFO] [stdout] 198 | is_eol [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 192 ~ [INFO] [stdout] 193 | [INFO] [stdout] 194 ~ if selected + 1 == *process_selectable_entries { [INFO] [stdout] 195 + true [INFO] [stdout] 196 + } else { [INFO] [stdout] 197 + false [INFO] [stdout] 198 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/components/process.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | let is_eol = if selected + 1 == *process_selectable_entries { [INFO] [stdout] | ______________________^ [INFO] [stdout] 193 | | true [INFO] [stdout] 194 | | } else { [INFO] [stdout] 195 | | false [INFO] [stdout] 196 | | }; [INFO] [stdout] | |_________^ help: you can reduce it to: `selected + 1 == *process_selectable_entries` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/components/process.rs:356:32 [INFO] [stdout] | [INFO] [stdout] 356 | if let Some(_) = process_selected_state.selected() { [INFO] [stdout] | -------^^^^^^^------------------------------------ help: try: `if process_selected_state.selected().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/components/process.rs:365:33 [INFO] [stdout] | [INFO] [stdout] 365 | / ... if value.status == "killed".to_string() { [INFO] [stdout] 366 | | ... true [INFO] [stdout] 367 | | ... } else { [INFO] [stdout] 368 | | ... false [INFO] [stdout] 369 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `value.status == "killed".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/components/process.rs:365:52 [INFO] [stdout] | [INFO] [stdout] 365 | ... if value.status == "killed".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"killed"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/process.rs:842:48 [INFO] [stdout] | [INFO] [stdout] 842 | let total_io_read_detail = format!( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 843 | | "{}", [INFO] [stdout] 844 | | process_to_kib_mib_gib(value.total_read_disk_usage as f64) [INFO] [stdout] 845 | | ); // this will be render at the extra detail row [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `process_to_kib_mib_gib(value.total_read_disk_usage as f64).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/components/process.rs:850:49 [INFO] [stdout] | [INFO] [stdout] 850 | let total_io_write_detail = format!( [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 851 | | "{}", [INFO] [stdout] 852 | | process_to_kib_mib_gib(value.total_write_disk_usage as f64) [INFO] [stdout] 853 | | ); // this will be render at the extra detail row [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `process_to_kib_mib_gib(value.total_write_disk_usage as f64).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/components/process.rs:1060:58 [INFO] [stdout] | [INFO] [stdout] 1060 | ... (usage / total_memory) * GRAPH_PERCENTAGE as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GRAPH_PERCENTAGE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/components/process.rs:1420:30 [INFO] [stdout] | [INFO] [stdout] 1420 | let command = if value.cmd.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.cmd.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/components/process.rs:1541:35 [INFO] [stdout] | [INFO] [stdout] 1541 | *process_selectable_entries = process_list.len() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `process_list.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | "default" => return DEFAULT, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - "default" => return DEFAULT, [INFO] [stdout] 55 + "default" => DEFAULT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | "dracula" => return DRACULA, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - "dracula" => return DRACULA, [INFO] [stdout] 56 + "dracula" => DRACULA, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 57 | "gruvbox_dark" => return GRUVBOX_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - "gruvbox_dark" => return GRUVBOX_DARK, [INFO] [stdout] 57 + "gruvbox_dark" => GRUVBOX_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | "gruvbox_light" => return GRUVBOX_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - "gruvbox_light" => return GRUVBOX_LIGHT, [INFO] [stdout] 58 + "gruvbox_light" => GRUVBOX_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | "gruvbox_mat_dark" => return GRUVBOX_MAT_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - "gruvbox_mat_dark" => return GRUVBOX_MAT_DARK, [INFO] [stdout] 59 + "gruvbox_mat_dark" => GRUVBOX_MAT_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | "ayu" => return AYU, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - "ayu" => return AYU, [INFO] [stdout] 60 + "ayu" => AYU, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | "everforest_dark" => return EVERFOREST_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - "everforest_dark" => return EVERFOREST_DARK, [INFO] [stdout] 61 + "everforest_dark" => EVERFOREST_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | "everforest_light" => return EVERFOREST_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - "everforest_light" => return EVERFOREST_LIGHT, [INFO] [stdout] 62 + "everforest_light" => EVERFOREST_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | "flatremix" => return FLATREMIX, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - "flatremix" => return FLATREMIX, [INFO] [stdout] 63 + "flatremix" => FLATREMIX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:64:30 [INFO] [stdout] | [INFO] [stdout] 64 | "flatremix_light" => return FLATREMIX_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - "flatremix_light" => return FLATREMIX_LIGHT, [INFO] [stdout] 64 + "flatremix_light" => FLATREMIX_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:65:24 [INFO] [stdout] | [INFO] [stdout] 65 | "grayscale" => return GRAYSCALE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - "grayscale" => return GRAYSCALE, [INFO] [stdout] 65 + "grayscale" => GRAYSCALE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | "horizon" => return HORIZON, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - "horizon" => return HORIZON, [INFO] [stdout] 66 + "horizon" => HORIZON, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:67:28 [INFO] [stdout] | [INFO] [stdout] 67 | "kanagawa_wave" => return KANAGAWA_WAVE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - "kanagawa_wave" => return KANAGAWA_WAVE, [INFO] [stdout] 67 + "kanagawa_wave" => KANAGAWA_WAVE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 68 | "kanagawa_lotus" => return KANAGAWA_LOTUS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - "kanagawa_lotus" => return KANAGAWA_LOTUS, [INFO] [stdout] 68 + "kanagawa_lotus" => KANAGAWA_LOTUS, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:69:22 [INFO] [stdout] | [INFO] [stdout] 69 | "monokai" => return MONOKAI, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - "monokai" => return MONOKAI, [INFO] [stdout] 69 + "monokai" => MONOKAI, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | "onedark" => return ONEDARK, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - "onedark" => return ONEDARK, [INFO] [stdout] 70 + "onedark" => ONEDARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | "nightowl" => return NIGHT_OWL, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - "nightowl" => return NIGHT_OWL, [INFO] [stdout] 71 + "nightowl" => NIGHT_OWL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | "rosepine" => return ROSE_PINE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - "rosepine" => return ROSE_PINE, [INFO] [stdout] 72 + "rosepine" => ROSE_PINE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 73 | "matcha_dark_sea" => return MATCHA_DARK_SEA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - "matcha_dark_sea" => return MATCHA_DARK_SEA, [INFO] [stdout] 73 + "matcha_dark_sea" => MATCHA_DARK_SEA, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | "paper" => return PAPER, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - "paper" => return PAPER, [INFO] [stdout] 74 + "paper" => PAPER, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | "solarized_dark" => return SOLARIZED_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - "solarized_dark" => return SOLARIZED_DARK, [INFO] [stdout] 75 + "solarized_dark" => SOLARIZED_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:76:30 [INFO] [stdout] | [INFO] [stdout] 76 | "solarized_light" => return SOLARIZED_LIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - "solarized_light" => return SOLARIZED_LIGHT, [INFO] [stdout] 76 + "solarized_light" => SOLARIZED_LIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:77:26 [INFO] [stdout] | [INFO] [stdout] 77 | "tokyo_night" => return TOKYO_NIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - "tokyo_night" => return TOKYO_NIGHT, [INFO] [stdout] 77 + "tokyo_night" => TOKYO_NIGHT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:78:26 [INFO] [stdout] | [INFO] [stdout] 78 | "tokyo_storm" => return TOKYO_STORM, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - "tokyo_storm" => return TOKYO_STORM, [INFO] [stdout] 78 + "tokyo_storm" => TOKYO_STORM, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | "catppuccin_mocha" => return CATPPUCCIN_MOCHA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - "catppuccin_mocha" => return CATPPUCCIN_MOCHA, [INFO] [stdout] 79 + "catppuccin_mocha" => CATPPUCCIN_MOCHA, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | "github_dark" => return GITHUB_DARK, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - "github_dark" => return GITHUB_DARK, [INFO] [stdout] 80 + "github_dark" => GITHUB_DARK, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/theme.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 81 | _ => return DEFAULT, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - _ => return DEFAULT, [INFO] [stdout] 81 + _ => DEFAULT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i8` is unnecessary [INFO] [stdout] --> src/get_sys_info.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | id: -1 as i8, [INFO] [stdout] | ^^^^^^^^ help: try: `-1_i8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/get_sys_info.rs:131:44 [INFO] [stdout] | [INFO] [stdout] 131 | ... ip_network: if network_data.ip_networks().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!network_data.ip_networks().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `u` after checking its variant with `is_some` [INFO] [stdout] --> src/get_sys_info.rs:233:40 [INFO] [stdout] | [INFO] [stdout] 232 | ... if u.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = u` [INFO] [stdout] 233 | ... user = u.unwrap().name(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/get_sys_info.rs:223:82 [INFO] [stdout] | [INFO] [stdout] 223 | let thread_count = get_thread_count(pid.as_u32() as i32, &process, None); [INFO] [stdout] | ^^^^^^^^ help: change this to: `process` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/get_sys_info.rs:247:34 [INFO] [stdout] | [INFO] [stdout] 247 | ... .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_sys_info.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 328 | return thread_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return thread_count; [INFO] [stdout] 328 + thread_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_sys_info.rs:358:5 [INFO] [stdout] | [INFO] [stdout] 358 | return cached_memory; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 - return cached_memory; [INFO] [stdout] 358 + cached_memory [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_sys_info.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 409 - return None; [INFO] [stdout] 409 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/types.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | / pub fn default() -> MemoryData { [INFO] [stdout] 180 | | MemoryData { [INFO] [stdout] 181 | | total_memory: -1.0, [INFO] [stdout] 182 | | available_memory_vec: vec![0.0], [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/types.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | / return MemoryData { [INFO] [stdout] 199 | | total_memory: total, [INFO] [stdout] 200 | | available_memory_vec: vec![available], [INFO] [stdout] 201 | | used_memory_vec: vec![used], [INFO] [stdout] ... | [INFO] [stdout] 204 | | cached_memory_vec: vec![cached], [INFO] [stdout] 205 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 ~ MemoryData { [INFO] [stdout] 199 + total_memory: total, [INFO] [stdout] 200 + available_memory_vec: vec![available], [INFO] [stdout] 201 + used_memory_vec: vec![used], [INFO] [stdout] 202 + used_swap_vec: vec![used_swap], [INFO] [stdout] 203 + free_memory_vec: vec![free], [INFO] [stdout] 204 + cached_memory_vec: vec![cached], [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/types.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | / pub fn new( [INFO] [stdout] 244 | | name: String, [INFO] [stdout] 245 | | total_space: f64, [INFO] [stdout] 246 | | available_space: f64, [INFO] [stdout] ... | [INFO] [stdout] 252 | | kind: String, [INFO] [stdout] 253 | | ) -> DiskData { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/types.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / pub fn update( [INFO] [stdout] 269 | | &mut self, [INFO] [stdout] 270 | | name: String, [INFO] [stdout] 271 | | total_space: f64, [INFO] [stdout] ... | [INFO] [stdout] 278 | | kind: String, [INFO] [stdout] 279 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/types.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | / return NetworkData { [INFO] [stdout] 310 | | interface_name, [INFO] [stdout] 311 | | ip_network, [INFO] [stdout] 312 | | current_received_vec: vec![current_received], [INFO] [stdout] ... | [INFO] [stdout] 316 | | is_updated: true, [INFO] [stdout] 317 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 ~ NetworkData { [INFO] [stdout] 310 + interface_name, [INFO] [stdout] 311 + ip_network, [INFO] [stdout] 312 + current_received_vec: vec![current_received], [INFO] [stdout] 313 + current_transmitted_vec: vec![current_transmitted], [INFO] [stdout] 314 + total_received, [INFO] [stdout] 315 + total_transmitted, [INFO] [stdout] 316 + is_updated: true, [INFO] [stdout] 317 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (15/7) [INFO] [stdout] --> src/types.rs:346:5 [INFO] [stdout] | [INFO] [stdout] 346 | / pub fn new( [INFO] [stdout] 347 | | pid: u32, [INFO] [stdout] 348 | | name: String, [INFO] [stdout] 349 | | exe_path: Option, [INFO] [stdout] ... | [INFO] [stdout] 361 | | total_write_disk_usage: u64, [INFO] [stdout] 362 | | ) -> ProcessData { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/types.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | / return ProcessData { [INFO] [stdout] 364 | | pid, [INFO] [stdout] 365 | | name, [INFO] [stdout] 366 | | exe_path, [INFO] [stdout] ... | [INFO] [stdout] 379 | | total_write_disk_usage, [INFO] [stdout] 380 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 363 ~ ProcessData { [INFO] [stdout] 364 + pid, [INFO] [stdout] 365 + name, [INFO] [stdout] 366 + exe_path, [INFO] [stdout] 367 + cmd, [INFO] [stdout] 368 + user, [INFO] [stdout] 369 + cpu_usage: vec![cpu_usage], [INFO] [stdout] 370 + thread_count, [INFO] [stdout] 371 + memory: vec![memory], [INFO] [stdout] 372 + status, [INFO] [stdout] 373 + elapsed, [INFO] [stdout] 374 + parent, [INFO] [stdout] 375 + is_updated: true, [INFO] [stdout] 376 + current_read_disk_usage, [INFO] [stdout] 377 + total_read_disk_usage, [INFO] [stdout] 378 + current_write_disk_usage, [INFO] [stdout] 379 + total_write_disk_usage, [INFO] [stdout] 380 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/types.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 383 | / pub fn update( [INFO] [stdout] 384 | | &mut self, [INFO] [stdout] 385 | | pid: u32, [INFO] [stdout] 386 | | name: String, [INFO] [stdout] ... | [INFO] [stdout] 399 | | total_write_disk_usage: u64, [INFO] [stdout] 400 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return PathBuf::from(home_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return PathBuf::from(home_dir); [INFO] [stdout] 32 + PathBuf::from(home_dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if current_sys_info.cpus.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_sys_info.cpus.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/utils.rs:50:36 [INFO] [stdout] | [INFO] [stdout] 50 | let cpu = CpuData::new(cpu.id as i8, cpu.brand.clone(), cpu.usage); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `cpu.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/utils.rs:55:63 [INFO] [stdout] | [INFO] [stdout] 55 | current_sys_info.cpus[cpu.id as usize + 1].update(cpu.id as i8, cpu.usage); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `cpu.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if current_sys_info.disks.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_sys_info.disks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 170 | if current_sys_info.networks.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_sys_info.networks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:246:8 [INFO] [stdout] | [INFO] [stdout] 246 | if current_process_info.processes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_process_info.processes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:377:5 [INFO] [stdout] | [INFO] [stdout] 377 | return refresh_tick; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 377 - return refresh_tick; [INFO] [stdout] 377 + refresh_tick [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | return vec![line]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 - return vec![line]; [INFO] [stdout] 390 + vec![line] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | return line_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return line_vec; [INFO] [stdout] 406 + line_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | return format!("{:.2} {}", ((value * 1000.0).round() / 1000.0), unit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return format!("{:.2} {}", ((value * 1000.0).round() / 1000.0), unit); [INFO] [stdout] 433 + format!("{:.2} {}", ((value * 1000.0).round() / 1000.0), unit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | return format!("{}:{}:{}:{}", days, hours, minutes, seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 442 - return format!("{}:{}:{}:{}", days, hours, minutes, seconds); [INFO] [stdout] 442 + format!("{}:{}:{}:{}", days, hours, minutes, seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 444 | return format!("{}:{}:{}", hours, minutes, seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 444 - return format!("{}:{}:{}", hours, minutes, seconds); [INFO] [stdout] 444 + format!("{}:{}:{}", hours, minutes, seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:558:5 [INFO] [stdout] | [INFO] [stdout] 558 | return processes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 558 - return processes; [INFO] [stdout] 558 + processes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/utils.rs:456:43 [INFO] [stdout] | [INFO] [stdout] 456 | let mut processes: Vec = process_data [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 457 | | .iter() [INFO] [stdout] 458 | | .map(|(_, value)| value) [INFO] [stdout] | |________________________________^ help: try: `process_data.values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_process_signal_state_data.signal_id` after checking its variant with `is_none` [INFO] [stdout] --> src/utils.rs:799:21 [INFO] [stdout] | [INFO] [stdout] 796 | if current_process_signal_state_data.signal_id.is_none() { [INFO] [stdout] | -------------------------------------------------------- help: try: `if let Some() = current_process_signal_state_data.signal_id` [INFO] [stdout] ... [INFO] [stdout] 799 | / current_process_signal_state_data [INFO] [stdout] 800 | | .signal_id [INFO] [stdout] 801 | | .unwrap() [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_selected_signal_id` after checking its variant with `is_some` [INFO] [stdout] --> src/utils.rs:1221:12 [INFO] [stdout] | [INFO] [stdout] 1220 | let signal_id_span = if current_selected_signal_id.is_some() { [INFO] [stdout] | --------------------------------------- help: try: `if let Some() = current_selected_signal_id` [INFO] [stdout] 1221 | if current_selected_signal_id.unwrap() == signal_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_selected_signal_id` after checking its variant with `is_some` [INFO] [stdout] --> src/utils.rs:1241:12 [INFO] [stdout] | [INFO] [stdout] 1240 | let signal_name_span = if current_selected_signal_id.is_some() { [INFO] [stdout] | --------------------------------------- help: try: `if let Some() = current_selected_signal_id` [INFO] [stdout] 1241 | if current_selected_signal_id.unwrap() == signal_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils.rs:365:52 [INFO] [stdout] | [INFO] [stdout] 365 | pub fn get_tick_line_ui(tick: u64, app_color_info: &AppColorInfo) -> Line { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 365 | pub fn get_tick_line_ui(tick: u64, app_color_info: &AppColorInfo) -> Line<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `Command { std: "docker" "inspect" "f8ef88ac83364b60c3644161a74d462dc2c492c2ce62e01c22d32e4f25042ffc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8ef88ac83364b60c3644161a74d462dc2c492c2ce62e01c22d32e4f25042ffc", kill_on_drop: false }` [INFO] [stdout] f8ef88ac83364b60c3644161a74d462dc2c492c2ce62e01c22d32e4f25042ffc