[INFO] cloning repository https://github.com/glowcouch/ls-clone [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/glowcouch/ls-clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fglowcouch%2Fls-clone", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fglowcouch%2Fls-clone'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4662512e3c37209bf3dbe6166efce3a6f58ad322 [INFO] linting glowcouch/ls-clone against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fglowcouch%2Fls-clone" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/glowcouch/ls-clone [INFO] finished tweaking git repo https://github.com/glowcouch/ls-clone [INFO] tweaked toml for git repo https://github.com/glowcouch/ls-clone written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/glowcouch/ls-clone on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/glowcouch/ls-clone already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded temp-dir v0.1.12 [INFO] [stderr] Downloaded clap v4.5.1 [INFO] [stderr] Downloaded anstream v0.6.12 [INFO] [stderr] Downloaded clap_derive v4.5.0 [INFO] [stderr] Downloaded clap_builder v4.5.1 [INFO] [stderr] Downloaded nerd-font-symbols v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6a8fa32c34d99ed8bfbcac3c63f2d7aa6c8e1a38bbf50ae6c4e379eb86bec08 [INFO] running `Command { std: "docker" "start" "-a" "e6a8fa32c34d99ed8bfbcac3c63f2d7aa6c8e1a38bbf50ae6c4e379eb86bec08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6a8fa32c34d99ed8bfbcac3c63f2d7aa6c8e1a38bbf50ae6c4e379eb86bec08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6a8fa32c34d99ed8bfbcac3c63f2d7aa6c8e1a38bbf50ae6c4e379eb86bec08", kill_on_drop: false }` [INFO] [stdout] e6a8fa32c34d99ed8bfbcac3c63f2d7aa6c8e1a38bbf50ae6c4e379eb86bec08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d5373f5a3649fe189589063ea60e60aebce481d52c23b1dedeb02fff566765a [INFO] running `Command { std: "docker" "start" "-a" "8d5373f5a3649fe189589063ea60e60aebce481d52c23b1dedeb02fff566765a", kill_on_drop: false }` [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking temp-dir v0.1.12 [INFO] [stderr] Checking nerd-font-symbols v0.1.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking ls-clone v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/colors.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn colorize_label(label: &String, file: &Path) -> ColoredString { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn colorize_label(label: &String, file: &Path) -> ColoredString { [INFO] [stdout] 5 + pub fn colorize_label(label: &str, file: &Path) -> ColoredString { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | if (!entry [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | .as_ref() [INFO] [stdout] 72 | | .unwrap() [INFO] [stdout] 73 | | .path() [INFO] [stdout] ... | [INFO] [stdout] 79 | | && !hide_dots) [INFO] [stdout] 80 | | || hide_dots [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 ~ if !(entry [INFO] [stdout] 71 + .as_ref() [INFO] [stdout] 72 + .unwrap() [INFO] [stdout] 73 + .path() [INFO] [stdout] 74 + .file_name() [INFO] [stdout] 75 + .unwrap() [INFO] [stdout] 76 + .to_str() [INFO] [stdout] 77 + .unwrap() [INFO] [stdout] 78 + .starts_with(".") && !hide_dots) [INFO] [stdout] | [INFO] [stdout] 70 ~ if !entry [INFO] [stdout] 71 + .as_ref() [INFO] [stdout] 72 + .unwrap() [INFO] [stdout] 73 + .path() [INFO] [stdout] 74 + .file_name() [INFO] [stdout] 75 + .unwrap() [INFO] [stdout] 76 + .to_str() [INFO] [stdout] 77 + .unwrap() [INFO] [stdout] 78 + .starts_with(".") || hide_dots [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/colors.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn colorize_label(label: &String, file: &Path) -> ColoredString { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn colorize_label(label: &String, file: &Path) -> ColoredString { [INFO] [stdout] 5 + pub fn colorize_label(label: &str, file: &Path) -> ColoredString { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> src/main.rs:98:72 [INFO] [stdout] | [INFO] [stdout] 98 | if entry.as_ref().unwrap().path().is_dir() && recursive && (depth > 0 || depth < 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `depth != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | if (!entry [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | .as_ref() [INFO] [stdout] 72 | | .unwrap() [INFO] [stdout] 73 | | .path() [INFO] [stdout] ... | [INFO] [stdout] 79 | | && !hide_dots) [INFO] [stdout] 80 | | || hide_dots [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 ~ if !(entry [INFO] [stdout] 71 + .as_ref() [INFO] [stdout] 72 + .unwrap() [INFO] [stdout] 73 + .path() [INFO] [stdout] 74 + .file_name() [INFO] [stdout] 75 + .unwrap() [INFO] [stdout] 76 + .to_str() [INFO] [stdout] 77 + .unwrap() [INFO] [stdout] 78 + .starts_with(".") && !hide_dots) [INFO] [stdout] | [INFO] [stdout] 70 ~ if !entry [INFO] [stdout] 71 + .as_ref() [INFO] [stdout] 72 + .unwrap() [INFO] [stdout] 73 + .path() [INFO] [stdout] 74 + .file_name() [INFO] [stdout] 75 + .unwrap() [INFO] [stdout] 76 + .to_str() [INFO] [stdout] 77 + .unwrap() [INFO] [stdout] 78 + .starts_with(".") || hide_dots [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> src/main.rs:98:72 [INFO] [stdout] | [INFO] [stdout] 98 | if entry.as_ref().unwrap().path().is_dir() && recursive && (depth > 0 || depth < 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `depth != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.37s [INFO] running `Command { std: "docker" "inspect" "8d5373f5a3649fe189589063ea60e60aebce481d52c23b1dedeb02fff566765a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d5373f5a3649fe189589063ea60e60aebce481d52c23b1dedeb02fff566765a", kill_on_drop: false }` [INFO] [stdout] 8d5373f5a3649fe189589063ea60e60aebce481d52c23b1dedeb02fff566765a