[INFO] cloning repository https://github.com/gjf2a/midi_improv_hero [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gjf2a/midi_improv_hero" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgjf2a%2Fmidi_improv_hero", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgjf2a%2Fmidi_improv_hero'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5d7ae5abbd493fb215844a34bf519e7881542d7b [INFO] linting gjf2a/midi_improv_hero against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgjf2a%2Fmidi_improv_hero" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gjf2a/midi_improv_hero [INFO] finished tweaking git repo https://github.com/gjf2a/midi_improv_hero [INFO] tweaked toml for git repo https://github.com/gjf2a/midi_improv_hero written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gjf2a/midi_improv_hero on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gjf2a/midi_improv_hero already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/gjf2a/midi_melody_gui` [INFO] [stderr] Updating git repository `https://github.com/gjf2a/midi_note_recorder` [INFO] [stderr] Updating git repository `https://github.com/gjf2a/music_analyzer_generator` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded coremidi v0.8.0 [INFO] [stderr] Downloaded coremidi-sys v3.2.0 [INFO] [stderr] Downloaded float_eq v1.0.1 [INFO] [stderr] Downloaded read_input v0.8.6 [INFO] [stderr] Downloaded hash_histogram v0.13.0 [INFO] [stderr] Downloaded mach2 v0.5.0 [INFO] [stderr] Downloaded webbrowser v1.1.0 [INFO] [stderr] Downloaded midir v0.10.3 [INFO] [stderr] Downloaded alsa v0.10.0 [INFO] [stderr] Downloaded wide v1.1.1 [INFO] [stderr] Downloaded cpal v0.17.1 [INFO] [stderr] Downloaded midi-msg v0.8.1 [INFO] [stderr] Downloaded midi_fundsp v0.7.1 [INFO] [stderr] Downloaded bare_metal_modulo v1.2.6 [INFO] [stderr] Downloaded objc2-avf-audio v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46e6752ffb075074d2ddad8a0925345fdab2a155e7132490e79422955e17a1cc [INFO] running `Command { std: "docker" "start" "-a" "46e6752ffb075074d2ddad8a0925345fdab2a155e7132490e79422955e17a1cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46e6752ffb075074d2ddad8a0925345fdab2a155e7132490e79422955e17a1cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46e6752ffb075074d2ddad8a0925345fdab2a155e7132490e79422955e17a1cc", kill_on_drop: false }` [INFO] [stdout] 46e6752ffb075074d2ddad8a0925345fdab2a155e7132490e79422955e17a1cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac4b22613ae6a29e0a97ec8551e5bf2b8be1724e1c19e97511fe037e6de6aee2 [INFO] running `Command { std: "docker" "start" "-a" "ac4b22613ae6a29e0a97ec8551e5bf2b8be1724e1c19e97511fe037e6de6aee2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking wayland-sys v0.31.8 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking accesskit v0.21.1 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling rtsan-standalone v0.3.0 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking wayland-backend v0.3.12 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking glam v0.28.0 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking epaint_default_fonts v0.33.3 [INFO] [stderr] Checking accesskit_consumer v0.31.0 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cpal v0.17.1 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking alsa v0.10.0 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking resampler v0.4.1 [INFO] [stderr] Checking micromath v1.1.1 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking midir v0.10.3 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rustfft v6.4.1 [INFO] [stderr] Checking microfft v0.6.0 [INFO] [stderr] Checking read_input v0.8.6 [INFO] [stderr] Checking generic-array v1.3.5 [INFO] [stderr] Compiling num_cpus v1.17.0 [INFO] [stderr] Checking float_eq v1.0.1 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking numeric-array v0.6.1 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Compiling tempfile v3.24.0 [INFO] [stderr] Compiling rtsan-standalone-sys v0.3.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling trait-set v0.3.0 [INFO] [stderr] Checking bare_metal_modulo v1.2.6 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking midi-msg v0.8.1 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling rtsan-standalone-macros v0.3.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling enum-iterator-derive v1.5.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking enum-iterator v2.3.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking symphonia-core v0.5.5 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking safe_arch v1.0.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking funutd v0.16.0 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking realfft v3.5.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking thingbuf v0.1.6 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking fft-convolver v0.3.0 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking wide v1.1.1 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking symphonia-metadata v0.5.5 [INFO] [stderr] Checking symphonia-codec-aac v0.5.5 [INFO] [stderr] Checking symphonia-codec-alac v0.5.5 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.5 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.5 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.5 [INFO] [stderr] Checking symphonia-format-riff v0.5.5 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Checking symphonia-format-caf v0.5.5 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Checking symphonia-format-mkv v0.5.5 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.5 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking symphonia-format-ogg v0.5.5 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant_utils v3.3.0 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking hash_histogram v0.13.0 [INFO] [stderr] Checking symphonia v0.5.5 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Compiling zvariant_derive v5.9.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking fundsp v0.23.0 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling zvariant v5.9.2 [INFO] [stderr] Checking webbrowser v1.1.0 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking wayland-client v0.31.12 [INFO] [stderr] Checking zbus_names v4.3.1 [INFO] [stderr] Checking egui_glow v0.33.3 [INFO] [stderr] Checking zbus_xml v5.1.0 [INFO] [stderr] Checking midi_fundsp v0.7.1 [INFO] [stderr] Checking zbus-lockstep v0.5.2 [INFO] [stderr] Checking midi_note_recorder v0.2.0 (https://github.com/gjf2a/midi_note_recorder#a4630596) [INFO] [stderr] Checking music_analyzer_generator v0.1.0 (https://github.com/gjf2a/music_analyzer_generator#568bbf3d) [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Compiling zbus_macros v5.13.2 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.2 [INFO] [stderr] Checking zbus v5.13.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking winit v0.30.12 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.2 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.2 [INFO] [stderr] Checking accesskit_winit v0.29.2 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking eframe v0.33.3 [INFO] [stderr] Checking midi_melody_gui v0.1.0 (https://github.com/gjf2a/midi_melody_gui#fe000c80) [INFO] [stderr] Checking midi_improv_hero v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/recorder.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 187 | msg: msg, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/melody_scoring.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 22 | ... todo!("Figure out how to determine if note fits this chord. Maybe see if it is a member of one of the scales that fit the chord."); [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 23 | ... timestamp += note.duration(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/melody_scoring.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut compatible_chord_pitches = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/melody_scoring.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut timestamp = 0.0; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `out_of_figures` is assigned to, but never used [INFO] [stdout] --> src/melody_scoring.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | let mut out_of_figures = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_out_of_figures` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `compatible_chord_pitches` [INFO] [stdout] --> src/melody_scoring.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut compatible_chord_pitches = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_compatible_chord_pitches` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `note` [INFO] [stdout] --> src/melody_scoring.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | for (i, note) in melody.iter().enumerate() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_note` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chord` [INFO] [stdout] --> src/melody_scoring.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | let chord = chords.chord_at_time(timestamp).unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_chord` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `out_of_figures` is never read [INFO] [stdout] --> src/melody_scoring.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | out_of_figures += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `total_pitches`, `total_chords`, `compatible_chord_pitches`, `chords_with_tones`, and `out_of_figures` are never read [INFO] [stdout] --> src/melody_scoring.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct MelodyScore { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 4 | total_pitches: usize, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 5 | total_chords: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 6 | compatible_chord_pitches: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 7 | chords_with_tones: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 8 | out_of_figures: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/recorder.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if self.accompaniments.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.accompaniments.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/recorder.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(recent) = self.accompaniments.last() { [INFO] [stdout] 119 | | if let Some((_, last_msg)) = recent.last() { [INFO] [stdout] 120 | | if let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] 121 | | return velocity > 0 [INFO] [stdout] ... | [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(recent) = self.accompaniments.last() [INFO] [stdout] 119 ~ && let Some((_, last_msg)) = recent.last() { [INFO] [stdout] 120 | if let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] ... [INFO] [stdout] 124 | } [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/recorder.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | / if let Some((_, last_msg)) = recent.last() { [INFO] [stdout] 120 | | if let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] 121 | | return velocity > 0 [INFO] [stdout] 122 | | || Instant::now().duration_since(self.last_msg).as_secs_f64() [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Some((_, last_msg)) = recent.last() [INFO] [stdout] 120 ~ && let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] 121 | return velocity > 0 [INFO] [stdout] 122 | || Instant::now().duration_since(self.last_msg).as_secs_f64() [INFO] [stdout] 123 | < self.timeout; [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/melody_scoring.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | if figure_table[i].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `figure_table[i].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/recorder.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 187 | msg: msg, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/melody_scoring.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 22 | ... todo!("Figure out how to determine if note fits this chord. Maybe see if it is a member of one of the scales that fit the chord."); [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 23 | ... timestamp += note.duration(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/melody_scoring.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut compatible_chord_pitches = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/melody_scoring.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut timestamp = 0.0; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `out_of_figures` is assigned to, but never used [INFO] [stdout] --> src/melody_scoring.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | let mut out_of_figures = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_out_of_figures` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `compatible_chord_pitches` [INFO] [stdout] --> src/melody_scoring.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut compatible_chord_pitches = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_compatible_chord_pitches` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `note` [INFO] [stdout] --> src/melody_scoring.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | for (i, note) in melody.iter().enumerate() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_note` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chord` [INFO] [stdout] --> src/melody_scoring.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | let chord = chords.chord_at_time(timestamp).unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_chord` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `out_of_figures` is never read [INFO] [stdout] --> src/melody_scoring.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | out_of_figures += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `total_pitches`, `total_chords`, `compatible_chord_pitches`, `chords_with_tones`, and `out_of_figures` are never read [INFO] [stdout] --> src/melody_scoring.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct MelodyScore { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 4 | total_pitches: usize, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 5 | total_chords: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 6 | compatible_chord_pitches: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 7 | chords_with_tones: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 8 | out_of_figures: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/recorder.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if self.accompaniments.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.accompaniments.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/recorder.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(recent) = self.accompaniments.last() { [INFO] [stdout] 119 | | if let Some((_, last_msg)) = recent.last() { [INFO] [stdout] 120 | | if let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] 121 | | return velocity > 0 [INFO] [stdout] ... | [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(recent) = self.accompaniments.last() [INFO] [stdout] 119 ~ && let Some((_, last_msg)) = recent.last() { [INFO] [stdout] 120 | if let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] ... [INFO] [stdout] 124 | } [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/recorder.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | / if let Some((_, last_msg)) = recent.last() { [INFO] [stdout] 120 | | if let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] 121 | | return velocity > 0 [INFO] [stdout] 122 | | || Instant::now().duration_since(self.last_msg).as_secs_f64() [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Some((_, last_msg)) = recent.last() [INFO] [stdout] 120 ~ && let Some((_, velocity)) = note_velocity_from(&last_msg) { [INFO] [stdout] 121 | return velocity > 0 [INFO] [stdout] 122 | || Instant::now().duration_since(self.last_msg).as_secs_f64() [INFO] [stdout] 123 | < self.timeout; [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/melody_scoring.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | if figure_table[i].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `figure_table[i].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | / if playback_button { [INFO] [stdout] 159 | | if ui.button("Play chords").clicked() { [INFO] [stdout] 160 | | recorder.start_accompaniment_playback_thread( [INFO] [stdout] 161 | | self.selected_recording, [INFO] [stdout] ... | [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ if playback_button [INFO] [stdout] 159 ~ && ui.button("Play chords").clicked() { [INFO] [stdout] 160 | recorder.start_accompaniment_playback_thread( [INFO] [stdout] ... [INFO] [stdout] 164 | ); [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | / if playback_button { [INFO] [stdout] 159 | | if ui.button("Play chords").clicked() { [INFO] [stdout] 160 | | recorder.start_accompaniment_playback_thread( [INFO] [stdout] 161 | | self.selected_recording, [INFO] [stdout] ... | [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ if playback_button [INFO] [stdout] 159 ~ && ui.button("Play chords").clicked() { [INFO] [stdout] 160 | recorder.start_accompaniment_playback_thread( [INFO] [stdout] ... [INFO] [stdout] 164 | ); [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | &recorder.accompaniment(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `recorder.accompaniment(0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | &recorder.accompaniment(*selected_recording) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `recorder.accompaniment(*selected_recording)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 299 | sounds: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 299 - sounds: &Vec, [INFO] [stdout] 299 + sounds: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | &recorder.accompaniment(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `recorder.accompaniment(0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | &recorder.accompaniment(*selected_recording) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `recorder.accompaniment(*selected_recording)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 299 | sounds: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 299 - sounds: &Vec, [INFO] [stdout] 299 + sounds: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `Command { std: "docker" "inspect" "ac4b22613ae6a29e0a97ec8551e5bf2b8be1724e1c19e97511fe037e6de6aee2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac4b22613ae6a29e0a97ec8551e5bf2b8be1724e1c19e97511fe037e6de6aee2", kill_on_drop: false }` [INFO] [stdout] ac4b22613ae6a29e0a97ec8551e5bf2b8be1724e1c19e97511fe037e6de6aee2