[INFO] cloning repository https://github.com/gitandy/AoC2015 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gitandy/AoC2015" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgitandy%2FAoC2015", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgitandy%2FAoC2015'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 66f00a87ca9db662b87822c75ca92d218a83c8f6 [INFO] linting gitandy/AoC2015 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgitandy%2FAoC2015" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gitandy/AoC2015 [INFO] finished tweaking git repo https://github.com/gitandy/AoC2015 [INFO] tweaked toml for git repo https://github.com/gitandy/AoC2015 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gitandy/AoC2015 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gitandy/AoC2015 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded block-buffer v0.10.4 [INFO] [stderr] Downloaded regex v1.12.2 [INFO] [stderr] Downloaded digest v0.10.7 [INFO] [stderr] Downloaded version_check v0.9.5 [INFO] [stderr] Downloaded crypto-common v0.1.7 [INFO] [stderr] Downloaded generic-array v0.14.7 [INFO] [stderr] Downloaded aho-corasick v1.1.4 [INFO] [stderr] Downloaded regex-syntax v0.8.8 [INFO] [stderr] Downloaded regex-automata v0.4.13 [INFO] [stderr] Downloaded cfg-if v1.0.4 [INFO] [stderr] Downloaded md-5 v0.10.6 [INFO] [stderr] Downloaded memchr v2.7.6 [INFO] [stderr] Downloaded typenum v1.19.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7aa9b95eb2ba8422e36cc85c5251b61c092d83d02d53272159ed129336781bce [INFO] running `Command { std: "docker" "start" "-a" "7aa9b95eb2ba8422e36cc85c5251b61c092d83d02d53272159ed129336781bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7aa9b95eb2ba8422e36cc85c5251b61c092d83d02d53272159ed129336781bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7aa9b95eb2ba8422e36cc85c5251b61c092d83d02d53272159ed129336781bce", kill_on_drop: false }` [INFO] [stdout] 7aa9b95eb2ba8422e36cc85c5251b61c092d83d02d53272159ed129336781bce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30dfbc80b094b9c87eb12aa259083e4baf770b357346ace0f401493abcdabb0d [INFO] running `Command { std: "docker" "start" "-a" "30dfbc80b094b9c87eb12aa259083e4baf770b357346ace0f401493abcdabb0d", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking util v0.1.0 (/opt/rustwide/workdir/util) [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking day02 v0.1.0 (/opt/rustwide/workdir/days/day02) [INFO] [stderr] Checking day01 v0.1.0 (/opt/rustwide/workdir/days/day01) [INFO] [stderr] Checking day03 v0.1.0 (/opt/rustwide/workdir/days/day03) [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> days/day02/src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | let smallest = if let Some(x) = sides.iter().min() {x} else {&0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `sides.iter().min().unwrap_or(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> days/day02/src/main.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | let smallest = if let Some(x) = perimeter.iter().min() {x} else {&0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `perimeter.iter().min().unwrap_or(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> days/day02/src/main.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let sides = vec![width*height, height*length, width*length]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[width*height, height*length, width*length]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> days/day02/src/main.rs:41:21 [INFO] [stdout] | [INFO] [stdout] 41 | let perimeter = vec![width+height, height+length, width+length]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[width+height, height+length, width+length]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> days/day01/src/main.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | fn eval_floor(buffer: &String) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 ~ fn eval_floor(buffer: &str) -> i32 { [INFO] [stdout] 20 | let mut floor = 0; [INFO] [stdout] 21 | [INFO] [stdout] 22 ~ for c in buffer.to_owned().chars() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> days/day01/src/main.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | fn first_basement(buffer: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ fn first_basement(buffer: &str) -> u32 { [INFO] [stdout] 33 | let mut floor = 0; [INFO] [stdout] 34 | let mut char_count = 0; [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ for c in buffer.to_owned().chars() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> days/day03/src/main.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | fn walk_grid(dirs: &mut String, alternate: bool) -> ([[u8; GRID_SIZE]; GRID_SIZE], u32) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - fn walk_grid(dirs: &mut String, alternate: bool) -> ([[u8; GRID_SIZE]; GRID_SIZE], u32) { [INFO] [stdout] 28 + fn walk_grid(dirs: &mut str, alternate: bool) -> ([[u8; GRID_SIZE]; GRID_SIZE], u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking day05 v0.1.0 (/opt/rustwide/workdir/days/day05) [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> days/day02/src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | let smallest = if let Some(x) = sides.iter().min() {x} else {&0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `sides.iter().min().unwrap_or(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> days/day03/src/main.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | fn walk_grid(dirs: &mut String, alternate: bool) -> ([[u8; GRID_SIZE]; GRID_SIZE], u32) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - fn walk_grid(dirs: &mut String, alternate: bool) -> ([[u8; GRID_SIZE]; GRID_SIZE], u32) { [INFO] [stdout] 28 + fn walk_grid(dirs: &mut str, alternate: bool) -> ([[u8; GRID_SIZE]; GRID_SIZE], u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> days/day02/src/main.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | let smallest = if let Some(x) = perimeter.iter().min() {x} else {&0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `perimeter.iter().min().unwrap_or(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> days/day02/src/main.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let sides = vec![width*height, height*length, width*length]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[width*height, height*length, width*length]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> days/day02/src/main.rs:41:21 [INFO] [stdout] | [INFO] [stdout] 41 | let perimeter = vec![width+height, height+length, width+length]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[width+height, height+length, width+length]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> days/day01/src/main.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | fn eval_floor(buffer: &String) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 ~ fn eval_floor(buffer: &str) -> i32 { [INFO] [stdout] 20 | let mut floor = 0; [INFO] [stdout] 21 | [INFO] [stdout] 22 ~ for c in buffer.to_owned().chars() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> days/day01/src/main.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | fn first_basement(buffer: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ fn first_basement(buffer: &str) -> u32 { [INFO] [stdout] 33 | let mut floor = 0; [INFO] [stdout] 34 | let mut char_count = 0; [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ for c in buffer.to_owned().chars() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> days/day05/src/main.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | .map(|word| check_word(word)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `check_word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> days/day05/src/main.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | .map(|word| check_word(word)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `check_word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> days/day05/src/main.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | let mut chars = word.chars().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `word.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> days/day05/src/main.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | let mut chars = word.chars().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `word.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking day04 v0.1.0 (/opt/rustwide/workdir/days/day04) [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking day06 v0.1.0 (/opt/rustwide/workdir/days/day06) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> days/day06/src/main.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | fn calc_lit_up(matrix: &Vec>) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 36 - fn calc_lit_up(matrix: &Vec>) -> usize { [INFO] [stdout] 36 + fn calc_lit_up(matrix: &[Vec]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> days/day06/src/main.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | fn calc_brightness(matrix: &Vec>) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 - fn calc_brightness(matrix: &Vec>) -> u32 { [INFO] [stdout] 40 + fn calc_brightness(matrix: &[Vec]) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> days/day06/src/main.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 44 | fn decorate>(input: T, matrix: &mut Vec>, brightness: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - fn decorate>(input: T, matrix: &mut Vec>, brightness: bool) { [INFO] [stdout] 44 + fn decorate>(input: T, matrix: &mut [Vec], brightness: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> days/day06/src/main.rs:59:48 [INFO] [stdout] | [INFO] [stdout] 59 | ... matrix[x][y] = !(matrix[x][y] != 0) as u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[x][y] == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `matrix` [INFO] [stdout] --> days/day06/src/main.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | for x in act.1.x..=act.2.x { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 52 - for x in act.1.x..=act.2.x { [INFO] [stdout] 52 + for in matrix.iter_mut().take(act.2.x + 1).skip(act.1.x) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is only used to index `matrix` [INFO] [stdout] --> days/day06/src/main.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | for y in act.1.y..=act.2.y { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 53 - for y in act.1.y..=act.2.y { [INFO] [stdout] 53 + for in matrix.iter_mut().take(act.2.y + 1).skip(act.1.y) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> days/day06/src/main.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | fn calc_lit_up(matrix: &Vec>) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 36 - fn calc_lit_up(matrix: &Vec>) -> usize { [INFO] [stdout] 36 + fn calc_lit_up(matrix: &[Vec]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> days/day06/src/main.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | fn calc_brightness(matrix: &Vec>) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 - fn calc_brightness(matrix: &Vec>) -> u32 { [INFO] [stdout] 40 + fn calc_brightness(matrix: &[Vec]) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> days/day06/src/main.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 44 | fn decorate>(input: T, matrix: &mut Vec>, brightness: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - fn decorate>(input: T, matrix: &mut Vec>, brightness: bool) { [INFO] [stdout] 44 + fn decorate>(input: T, matrix: &mut [Vec], brightness: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> days/day06/src/main.rs:59:48 [INFO] [stdout] | [INFO] [stdout] 59 | ... matrix[x][y] = !(matrix[x][y] != 0) as u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[x][y] == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `matrix` [INFO] [stdout] --> days/day06/src/main.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | for x in act.1.x..=act.2.x { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 52 - for x in act.1.x..=act.2.x { [INFO] [stdout] 52 + for in matrix.iter_mut().take(act.2.x + 1).skip(act.1.x) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is only used to index `matrix` [INFO] [stdout] --> days/day06/src/main.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | for y in act.1.y..=act.2.y { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 53 - for y in act.1.y..=act.2.y { [INFO] [stdout] 53 + for in matrix.iter_mut().take(act.2.y + 1).skip(act.1.y) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.04s [INFO] running `Command { std: "docker" "inspect" "30dfbc80b094b9c87eb12aa259083e4baf770b357346ace0f401493abcdabb0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30dfbc80b094b9c87eb12aa259083e4baf770b357346ace0f401493abcdabb0d", kill_on_drop: false }` [INFO] [stdout] 30dfbc80b094b9c87eb12aa259083e4baf770b357346ace0f401493abcdabb0d