[INFO] cloning repository https://github.com/giox069/ScreenTextScroller [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/giox069/ScreenTextScroller" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgiox069%2FScreenTextScroller", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgiox069%2FScreenTextScroller'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e0737ee258879a395d47be30baa5620d1ab80326 [INFO] linting giox069/ScreenTextScroller against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgiox069%2FScreenTextScroller" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/giox069/ScreenTextScroller [INFO] finished tweaking git repo https://github.com/giox069/ScreenTextScroller [INFO] tweaked toml for git repo https://github.com/giox069/ScreenTextScroller written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/giox069/ScreenTextScroller on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/giox069/ScreenTextScroller already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-xid v0.2.2 [INFO] [stderr] Downloaded parking_lot v0.12.0 [INFO] [stderr] Downloaded tokio-macros v1.7.0 [INFO] [stderr] Downloaded pwhash v1.0.0 [INFO] [stderr] Downloaded glutin_glx_sys v0.1.7 [INFO] [stderr] Downloaded ndk-context v0.1.0 [INFO] [stderr] Downloaded glutin_wgl_sys v0.1.5 [INFO] [stderr] Downloaded osmesa-sys v0.1.2 [INFO] [stderr] Downloaded cocoa-foundation v0.1.0 [INFO] [stderr] Downloaded glutin_egl_sys v0.1.5 [INFO] [stderr] Downloaded itoa v1.0.1 [INFO] [stderr] Downloaded android_glue v0.2.3 [INFO] [stderr] Downloaded darling_macro v0.13.1 [INFO] [stderr] Downloaded cgl v0.3.2 [INFO] [stderr] Downloaded glutin_emscripten_sys v0.1.1 [INFO] [stderr] Downloaded gl v0.14.0 [INFO] [stderr] Downloaded gl_generator v0.14.0 [INFO] [stderr] Downloaded discard v1.0.4 [INFO] [stderr] Downloaded tower-service v0.3.1 [INFO] [stderr] Downloaded getrandom v0.2.6 [INFO] [stderr] Downloaded slab v0.4.5 [INFO] [stderr] Downloaded redox_users v0.4.2 [INFO] [stderr] Downloaded const_fn v0.4.9 [INFO] [stderr] Downloaded cookie v0.13.3 [INFO] [stderr] Downloaded tracing-core v0.1.23 [INFO] [stderr] Downloaded indexmap v1.8.0 [INFO] [stderr] Downloaded http v0.2.6 [INFO] [stderr] Downloaded h2 v0.3.12 [INFO] [stderr] Downloaded hyper v0.14.18 [INFO] [stderr] Downloaded stdweb v0.4.20 [INFO] [stderr] Downloaded exr v1.4.1 [INFO] [stderr] Downloaded image v0.24.1 [INFO] [stderr] Downloaded ndk-sys v0.2.2 [INFO] [stderr] Downloaded object v0.27.1 [INFO] [stderr] Downloaded winit v0.26.1 [INFO] [stderr] Downloaded earcutr v0.2.0 [INFO] [stderr] Downloaded jpeg-decoder v0.2.4 [INFO] [stderr] Downloaded tokio-util v0.6.9 [INFO] [stderr] Downloaded png v0.17.5 [INFO] [stderr] Downloaded flate2 v1.0.22 [INFO] [stderr] Downloaded futures v0.1.31 [INFO] [stderr] Downloaded nix v0.22.3 [INFO] [stderr] Downloaded syn v1.0.90 [INFO] [stderr] Downloaded libc v0.2.121 [INFO] [stderr] Downloaded serde_json v1.0.79 [INFO] [stderr] Downloaded tokio v1.17.0 [INFO] [stderr] Downloaded khronos_api v3.1.0 [INFO] [stderr] Downloaded rayon v1.5.1 [INFO] [stderr] Downloaded wasm-bindgen v0.2.79 [INFO] [stderr] Downloaded web-sys v0.3.56 [INFO] [stderr] Downloaded httparse v1.6.0 [INFO] [stderr] Downloaded tracing v0.1.32 [INFO] [stderr] Downloaded pin-project v1.0.10 [INFO] [stderr] Downloaded miniz_oxide v0.5.1 [INFO] [stderr] Downloaded glow v0.7.2 [INFO] [stderr] Downloaded wayland-protocols v0.29.4 [INFO] [stderr] Downloaded flume v0.10.12 [INFO] [stderr] Downloaded half v1.8.2 [INFO] [stderr] Downloaded speedy2d v1.6.0 [INFO] [stderr] Downloaded num-rational v0.4.0 [INFO] [stderr] Downloaded deflate v1.0.0 [INFO] [stderr] Downloaded hmac v0.10.1 [INFO] [stderr] Downloaded backtrace v0.3.64 [INFO] [stderr] Downloaded smithay-client-toolkit v0.15.3 [INFO] [stderr] Downloaded ntapi v0.3.7 [INFO] [stderr] Downloaded bit_field v0.10.1 [INFO] [stderr] Downloaded spin v0.9.2 [INFO] [stderr] Downloaded inflate v0.4.5 [INFO] [stderr] Downloaded blowfish v0.7.0 [INFO] [stderr] Downloaded slotmap v0.4.3 [INFO] [stderr] Downloaded ttf-parser v0.6.2 [INFO] [stderr] Downloaded unicode-normalization v0.1.19 [INFO] [stderr] Downloaded stdweb-derive v0.5.3 [INFO] [stderr] Downloaded base-x v0.2.8 [INFO] [stderr] Downloaded sha1 v0.6.1 [INFO] [stderr] Downloaded stdweb-internal-macros v0.2.9 [INFO] [stderr] Downloaded tiff v0.7.1 [INFO] [stderr] Downloaded stdweb-internal-runtime v0.1.5 [INFO] [stderr] Downloaded time v0.2.27 [INFO] [stderr] Downloaded standback v0.2.17 [INFO] [stderr] Downloaded time-macros-impl v0.1.2 [INFO] [stderr] Downloaded time-macros v0.1.1 [INFO] [stderr] Downloaded phf_macros v0.8.0 [INFO] [stderr] Downloaded proc-macro-hack v0.5.19 [INFO] [stderr] Downloaded csscolorparser v0.5.0 [INFO] [stderr] Downloaded http-body v0.4.4 [INFO] [stderr] Downloaded md-5 v0.9.1 [INFO] [stderr] Downloaded crossbeam-channel v0.5.4 [INFO] [stderr] Downloaded mio v0.8.2 [INFO] [stderr] Downloaded pin-project-internal v1.0.10 [INFO] [stderr] Downloaded ryu v1.0.9 [INFO] [stderr] Downloaded serde v1.0.136 [INFO] [stderr] Downloaded calloop v0.9.3 [INFO] [stderr] Downloaded wayland-client v0.29.4 [INFO] [stderr] Downloaded x11-dl v2.19.1 [INFO] [stderr] Downloaded glutin v0.28.0 [INFO] [stderr] Downloaded rayon-core v1.9.1 [INFO] [stderr] Downloaded js-sys v0.3.56 [INFO] [stderr] Downloaded bumpalo v3.9.1 [INFO] [stderr] Downloaded memchr v2.4.1 [INFO] [stderr] Downloaded smallvec v1.8.0 [INFO] [stderr] Downloaded lebe v0.5.1 [INFO] [stderr] Downloaded darling_core v0.13.1 [INFO] [stderr] Downloaded serde_derive v1.0.136 [INFO] [stderr] Downloaded toml v0.5.8 [INFO] [stderr] Downloaded num-traits v0.2.14 [INFO] [stderr] Downloaded xml-rs v0.8.4 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.8 [INFO] [stderr] Downloaded weezl v0.1.5 [INFO] [stderr] Downloaded tinyvec v1.5.1 [INFO] [stderr] Downloaded cocoa v0.24.0 [INFO] [stderr] Downloaded core-foundation v0.7.0 [INFO] [stderr] Downloaded ndk v0.5.0 [INFO] [stderr] Downloaded bytemuck v1.8.0 [INFO] [stderr] Downloaded gif v0.11.3 [INFO] [stderr] Downloaded crossbeam-utils v0.8.8 [INFO] [stderr] Downloaded owned_ttf_parser v0.6.0 [INFO] [stderr] Downloaded log v0.4.16 [INFO] [stderr] Downloaded sha1_smol v1.0.0 [INFO] [stderr] Downloaded crypto-mac v0.10.1 [INFO] [stderr] Downloaded rusttype v0.9.2 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.79 [INFO] [stderr] Downloaded once_cell v1.10.0 [INFO] [stderr] Downloaded redox_syscall v0.2.12 [INFO] [stderr] Downloaded parking_lot_core v0.9.1 [INFO] [stderr] Downloaded core-graphics v0.22.3 [INFO] [stderr] Downloaded core-foundation-sys v0.7.0 [INFO] [stderr] Downloaded core-graphics v0.19.2 [INFO] [stderr] Downloaded thiserror v1.0.30 [INFO] [stderr] Downloaded windows-sys v0.32.0 [INFO] [stderr] Downloaded darling v0.13.1 [INFO] [stderr] Downloaded memmap2 v0.3.1 [INFO] [stderr] Downloaded wayland-sys v0.29.4 [INFO] [stderr] Downloaded wayland-commons v0.29.4 [INFO] [stderr] Downloaded wayland-scanner v0.29.4 [INFO] [stderr] Downloaded pkg-config v0.3.24 [INFO] [stderr] Downloaded num-integer v0.1.44 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.79 [INFO] [stderr] Downloaded miow v0.3.7 [INFO] [stderr] Downloaded lock_api v0.4.6 [INFO] [stderr] Downloaded pin-project-lite v0.2.8 [INFO] [stderr] Downloaded quote v1.0.17 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Downloaded glutin_gles2_sys v0.1.5 [INFO] [stderr] Downloaded thiserror-impl v1.0.30 [INFO] [stderr] Downloaded ndk-glue v0.5.1 [INFO] [stderr] Downloaded either v1.6.1 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.79 [INFO] [stderr] Downloaded core-graphics-types v0.1.1 [INFO] [stderr] Downloaded xcursor v0.3.4 [INFO] [stderr] Downloaded wayland-cursor v0.29.4 [INFO] [stderr] Downloaded raw-window-handle v0.4.2 [INFO] [stderr] Downloaded proc-macro2 v1.0.36 [INFO] [stderr] Downloaded wayland-egl v0.29.4 [INFO] [stderr] Downloaded num_enum v0.5.7 [INFO] [stderr] Downloaded ndk-macro v0.3.0 [INFO] [stderr] Downloaded dlib v0.5.0 [INFO] [stderr] Downloaded num-iter v0.1.42 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.79 [INFO] [stderr] Downloaded num_enum_derive v0.5.7 [INFO] [stderr] Downloaded core-video-sys v0.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78a570bf776db95b4892334fb75c1535218186f61d68902716a14b864bea6b2a [INFO] running `Command { std: "docker" "start" "-a" "78a570bf776db95b4892334fb75c1535218186f61d68902716a14b864bea6b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78a570bf776db95b4892334fb75c1535218186f61d68902716a14b864bea6b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78a570bf776db95b4892334fb75c1535218186f61d68902716a14b864bea6b2a", kill_on_drop: false }` [INFO] [stdout] 78a570bf776db95b4892334fb75c1535218186f61d68902716a14b864bea6b2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 159bc36dc2f86f591ed76c467403d40e43706d71baf1439176e3802fcade654f [INFO] running `Command { std: "docker" "start" "-a" "159bc36dc2f86f591ed76c467403d40e43706d71baf1439176e3802fcade654f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling wayland-sys v0.29.4 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.15.3 [INFO] [stderr] Compiling wayland-scanner v0.29.4 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Compiling winit v0.26.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling const_fn v0.4.9 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking nix v0.22.3 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking memmap2 v0.3.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.4.2 [INFO] [stderr] Compiling wayland-client v0.29.4 [INFO] [stderr] Compiling wayland-protocols v0.29.4 [INFO] [stderr] Compiling backtrace v0.3.64 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking spin v0.9.2 [INFO] [stderr] Checking tracing-core v0.1.23 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking bytemuck v1.8.0 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking crypto-mac v0.10.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Checking miniz_oxide v0.5.1 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking lebe v0.5.1 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking bit_field v0.10.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking png v0.17.5 [INFO] [stderr] Checking tiff v0.7.1 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking blowfish v0.7.0 [INFO] [stderr] Checking jpeg-decoder v0.2.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking earcutr v0.2.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking glow v0.7.2 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking pwhash v1.0.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking csscolorparser v0.5.0 [INFO] [stderr] Checking wayland-commons v0.29.4 [INFO] [stderr] Checking calloop v0.9.3 [INFO] [stderr] Checking cookie v0.13.3 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking flume v0.10.12 [INFO] [stderr] Checking exr v1.4.1 [INFO] [stderr] Checking wayland-cursor v0.29.4 [INFO] [stderr] Checking wayland-egl v0.29.4 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking image v0.24.1 [INFO] [stderr] Checking h2 v0.3.12 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking glutin v0.28.0 [INFO] [stderr] Checking speedy2d v1.6.0 [INFO] [stderr] Checking screen-text-scroller v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | font: font, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | rgd: rgd, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rgd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:317:5 [INFO] [stdout] | [INFO] [stdout] 317 | runtime_data_dir: runtime_data_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `runtime_data_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 318 | html_dir: html_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `html_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 319 | cfg: cfg [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | font: font, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | rgd: rgd, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rgd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:317:5 [INFO] [stdout] | [INFO] [stdout] 317 | runtime_data_dir: runtime_data_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `runtime_data_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 318 | html_dir: html_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `html_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 319 | cfg: cfg [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/lconfig.rs:138:4 [INFO] [stdout] | [INFO] [stdout] 138 | / if self.disp_scrollspeed < -50 { [INFO] [stdout] 139 | | self.disp_scrollspeed = -50; [INFO] [stdout] 140 | | } [INFO] [stdout] 141 | | if self.disp_scrollspeed > 50 { [INFO] [stdout] 142 | | self.disp_scrollspeed = 50; [INFO] [stdout] 143 | | } [INFO] [stdout] | |_____________^ help: replace with clamp: `self.disp_scrollspeed = self.disp_scrollspeed.clamp(-50, 50);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/lconfig.rs:160:36 [INFO] [stdout] | [INFO] [stdout] 160 | self.encrypted_admin_password = match bcrypt::hash("admin") { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 161 | | Ok(s) => s, [INFO] [stdout] 162 | | Err(_e) => String::from("") [INFO] [stdout] 163 | | }; [INFO] [stdout] | |_____________^ help: replace it with: `bcrypt::hash("admin").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/httpsrv/api_pwd.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 33 | let oldpass= match oldpassv.as_str() { [INFO] [stdout] | __________________^ [INFO] [stdout] 34 | | Some(s) => s, [INFO] [stdout] 35 | | None => "" [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_____^ help: replace it with: `oldpassv.as_str().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/httpsrv/api_pwd.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | let newpass= match newpassv.as_str() { [INFO] [stdout] | __________________^ [INFO] [stdout] 40 | | Some(s) => s, [INFO] [stdout] 41 | | None => "" [INFO] [stdout] 42 | | }; [INFO] [stdout] | |_____^ help: replace it with: `newpassv.as_str().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/lconfig.rs:138:4 [INFO] [stdout] | [INFO] [stdout] 138 | / if self.disp_scrollspeed < -50 { [INFO] [stdout] 139 | | self.disp_scrollspeed = -50; [INFO] [stdout] 140 | | } [INFO] [stdout] 141 | | if self.disp_scrollspeed > 50 { [INFO] [stdout] 142 | | self.disp_scrollspeed = 50; [INFO] [stdout] 143 | | } [INFO] [stdout] | |_____________^ help: replace with clamp: `self.disp_scrollspeed = self.disp_scrollspeed.clamp(-50, 50);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/lconfig.rs:160:36 [INFO] [stdout] | [INFO] [stdout] 160 | self.encrypted_admin_password = match bcrypt::hash("admin") { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 161 | | Ok(s) => s, [INFO] [stdout] 162 | | Err(_e) => String::from("") [INFO] [stdout] 163 | | }; [INFO] [stdout] | |_____________^ help: replace it with: `bcrypt::hash("admin").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/httpsrv/api_pwd.rs:49:27 [INFO] [stdout] | [INFO] [stdout] 49 | let encrypted_password = match bcrypt::hash(newpass) { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 50 | | Ok(s) => s, [INFO] [stdout] 51 | | Err(_e) => String::from("") [INFO] [stdout] 52 | | }; [INFO] [stdout] | |_____^ help: ascribe the type std::string::String and replace your expression with: `bcrypt::hash(newpass).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/httpsrv/api_pwd.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 33 | let oldpass= match oldpassv.as_str() { [INFO] [stdout] | __________________^ [INFO] [stdout] 34 | | Some(s) => s, [INFO] [stdout] 35 | | None => "" [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_____^ help: replace it with: `oldpassv.as_str().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/httpsrv/api_pwd.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | let newpass= match newpassv.as_str() { [INFO] [stdout] | __________________^ [INFO] [stdout] 40 | | Some(s) => s, [INFO] [stdout] 41 | | None => "" [INFO] [stdout] 42 | | }; [INFO] [stdout] | |_____^ help: replace it with: `newpassv.as_str().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/httpsrv/mod.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 84 | match &*self { [INFO] [stdout] | ^^^^^^ help: if you would like to reborrow, try removing `&*`: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/httpsrv/mod.rs:92:14 [INFO] [stdout] | [INFO] [stdout] 92 | let ch = match req.headers().get(COOKIE_HEADER_NAME) { [INFO] [stdout] | ______________^ [INFO] [stdout] 93 | | Some(v) => v, [INFO] [stdout] 94 | | None => return None [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_____^ help: try instead: `req.headers().get(COOKIE_HEADER_NAME)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/httpsrv/mod.rs:165:71 [INFO] [stdout] | [INFO] [stdout] 165 | Err(e) => return Err(format!("Unable to parse json POST body: {}", e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/httpsrv/mod.rs:179:71 [INFO] [stdout] | [INFO] [stdout] 179 | Err(e) => return Err(format!("Unable to parse json POST body: {}", e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/httpsrv/mod.rs:230:3 [INFO] [stdout] | [INFO] [stdout] 230 | !(age_sec > SESSION_TIMEOUT) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(age_sec <= SESSION_TIMEOUT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/httpsrv/api_pwd.rs:49:27 [INFO] [stdout] | [INFO] [stdout] 49 | let encrypted_password = match bcrypt::hash(newpass) { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 50 | | Ok(s) => s, [INFO] [stdout] 51 | | Err(_e) => String::from("") [INFO] [stdout] 52 | | }; [INFO] [stdout] | |_____^ help: ascribe the type std::string::String and replace your expression with: `bcrypt::hash(newpass).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `hyper::http::HeaderValue` [INFO] [stdout] --> src/httpsrv/mod.rs:246:46 [INFO] [stdout] | [INFO] [stdout] 246 | response.headers_mut().insert("Set-Cookie", HeaderValue::from(cookie_header)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `HeaderValue::from()`: `cookie_header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/httpsrv/mod.rs:287:18 [INFO] [stdout] | [INFO] [stdout] 287 | None => return () [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/httpsrv/mod.rs:294:2 [INFO] [stdout] | [INFO] [stdout] 294 | / match rd.authenticated_sessions.get(&sid) { [INFO] [stdout] 295 | | Some(_ses) => { [INFO] [stdout] 296 | | println!("Logging off session {}", sid); [INFO] [stdout] 297 | | rd.authenticated_sessions.remove(&sid); [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | None => () [INFO] [stdout] 300 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 294 ~ if let Some(_ses) = rd.authenticated_sessions.get(&sid) { [INFO] [stdout] 295 ~ println!("Logging off session {}", sid); [INFO] [stdout] 296 ~ rd.authenticated_sessions.remove(&sid); [INFO] [stdout] 297 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/httpsrv/mod.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 84 | match &*self { [INFO] [stdout] | ^^^^^^ help: if you would like to reborrow, try removing `&*`: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/httpsrv/mod.rs:92:14 [INFO] [stdout] | [INFO] [stdout] 92 | let ch = match req.headers().get(COOKIE_HEADER_NAME) { [INFO] [stdout] | ______________^ [INFO] [stdout] 93 | | Some(v) => v, [INFO] [stdout] 94 | | None => return None [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_____^ help: try instead: `req.headers().get(COOKIE_HEADER_NAME)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/httpsrv/mod.rs:165:71 [INFO] [stdout] | [INFO] [stdout] 165 | Err(e) => return Err(format!("Unable to parse json POST body: {}", e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/httpsrv/mod.rs:374:21 [INFO] [stdout] | [INFO] [stdout] 374 | static SLASH: u8 = '/' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'/'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/httpsrv/mod.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | is_authenticated(dc1, &req).await == None && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `is_authenticated(dc1, &req).await.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/httpsrv/mod.rs:179:71 [INFO] [stdout] | [INFO] [stdout] 179 | Err(e) => return Err(format!("Unable to parse json POST body: {}", e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/httpsrv/mod.rs:230:3 [INFO] [stdout] | [INFO] [stdout] 230 | !(age_sec > SESSION_TIMEOUT) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(age_sec <= SESSION_TIMEOUT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:398:39 [INFO] [stdout] | [INFO] [stdout] 398 | if req.uri() == "/authservice" && req.method() == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::POST` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:400:39 [INFO] [stdout] | [INFO] [stdout] 400 | } else if req.uri() == "/lapi" && req.method() == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::POST` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:402:44 [INFO] [stdout] | [INFO] [stdout] 402 | } else if req.uri() == "/logoff.do" && req.method() == &Method::GET { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::GET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `hyper::http::HeaderValue` [INFO] [stdout] --> src/httpsrv/mod.rs:246:46 [INFO] [stdout] | [INFO] [stdout] 246 | response.headers_mut().insert("Set-Cookie", HeaderValue::from(cookie_header)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `HeaderValue::from()`: `cookie_header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/httpsrv/mod.rs:425:69 [INFO] [stdout] | [INFO] [stdout] 425 | ... println!("Unalbe to read file {}: {}", filename.display(), e.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/httpsrv/mod.rs:426:68 [INFO] [stdout] | [INFO] [stdout] 426 | ... format!("Unalbe to read file {}: {}", filename.display(), e.to_string()).into_bytes() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/httpsrv/mod.rs:287:18 [INFO] [stdout] | [INFO] [stdout] 287 | None => return () [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/httpsrv/mod.rs:294:2 [INFO] [stdout] | [INFO] [stdout] 294 | / match rd.authenticated_sessions.get(&sid) { [INFO] [stdout] 295 | | Some(_ses) => { [INFO] [stdout] 296 | | println!("Logging off session {}", sid); [INFO] [stdout] 297 | | rd.authenticated_sessions.remove(&sid); [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | None => () [INFO] [stdout] 300 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 294 ~ if let Some(_ses) = rd.authenticated_sessions.get(&sid) { [INFO] [stdout] 295 ~ println!("Logging off session {}", sid); [INFO] [stdout] 296 ~ rd.authenticated_sessions.remove(&sid); [INFO] [stdout] 297 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:453:8 [INFO] [stdout] | [INFO] [stdout] 453 | if method == &Method::GET || method == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::GET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:453:34 [INFO] [stdout] | [INFO] [stdout] 453 | if method == &Method::GET || method == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::POST` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/httpsrv/mod.rs:483:16 [INFO] [stdout] | [INFO] [stdout] 483 | let addr = addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/httpsrv/mod.rs:486:43 [INFO] [stdout] | [INFO] [stdout] 486 | Ok::<_,Infallible>(servicefn(d, req, addr.clone()).await) [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/httpsrv/mod.rs:374:21 [INFO] [stdout] | [INFO] [stdout] 374 | static SLASH: u8 = '/' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'/'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/httpsrv/mod.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | is_authenticated(dc1, &req).await == None && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `is_authenticated(dc1, &req).await.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:398:39 [INFO] [stdout] | [INFO] [stdout] 398 | if req.uri() == "/authservice" && req.method() == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::POST` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | / match &self.block { [INFO] [stdout] 200 | | Some(b) => { [INFO] [stdout] 201 | | [INFO] [stdout] 202 | | let fgcolor = match csscolorparser::parse(&self.current_cfg_copy.disp_textcolor) { [INFO] [stdout] ... | [INFO] [stdout] 243 | | None => {} [INFO] [stdout] 244 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 199 ~ if let Some(b) = &self.block { [INFO] [stdout] 200 + [INFO] [stdout] 201 ~ let fgcolor = match csscolorparser::parse(&self.current_cfg_copy.disp_textcolor) { [INFO] [stdout] 202 ~ Ok(c) => Color::from_rgb(c.r as f32, c.g as f32, c.b as f32), [INFO] [stdout] 203 ~ Err(_) => Color::WHITE [INFO] [stdout] 204 ~ }; [INFO] [stdout] 205 + [INFO] [stdout] 206 ~ graphics.set_clip(Some(clip_area)); [INFO] [stdout] 207 + [INFO] [stdout] 208 ~ graphics.draw_text(( [INFO] [stdout] 209 ~ self.x, [INFO] [stdout] 210 ~ self.y [INFO] [stdout] 211 ~ ), [INFO] [stdout] 212 ~ fgcolor, &b); [INFO] [stdout] 213 + [INFO] [stdout] 214 ~ // println!("self.size.x={} self.size.y={} self.x={} self.y={}", self.size.x, self.size.y, self.x, self.y); [INFO] [stdout] 215 + [INFO] [stdout] 216 ~ if !self.pause { [INFO] [stdout] 217 ~ match self.current_cfg_copy.disp_orientation { [INFO] [stdout] 218 ~ TextScrollOrientation::ScrollVertical => { [INFO] [stdout] 219 ~ self.y -= self.current_cfg_copy.disp_scrollspeed as f32; [INFO] [stdout] 220 + [INFO] [stdout] 221 ~ if self.y >= self.max_y { [INFO] [stdout] 222 ~ self.y = self.min_y; [INFO] [stdout] 223 ~ } [INFO] [stdout] 224 ~ if self.y < self.min_y { [INFO] [stdout] 225 ~ self.y = self.max_y; [INFO] [stdout] 226 ~ } [INFO] [stdout] 227 ~ }, [INFO] [stdout] 228 ~ TextScrollOrientation::ScrollHorizontal => { [INFO] [stdout] 229 ~ self.x -= self.current_cfg_copy.disp_scrollspeed as f32; [INFO] [stdout] 230 + [INFO] [stdout] 231 ~ if self.x >= self.max_x { [INFO] [stdout] 232 ~ self.x = self.min_x; [INFO] [stdout] 233 ~ } [INFO] [stdout] 234 ~ if self.x < self.min_x { [INFO] [stdout] 235 ~ self.x = self.max_x; [INFO] [stdout] 236 ~ } [INFO] [stdout] 237 ~ } [INFO] [stdout] 238 ~ } [INFO] [stdout] 239 ~ } [INFO] [stdout] 240 + [INFO] [stdout] 241 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:400:39 [INFO] [stdout] | [INFO] [stdout] 400 | } else if req.uri() == "/lapi" && req.method() == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::POST` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:213:15 [INFO] [stdout] | [INFO] [stdout] 213 | fgcolor, &b); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:402:44 [INFO] [stdout] | [INFO] [stdout] 402 | } else if req.uri() == "/logoff.do" && req.method() == &Method::GET { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::GET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:246:3 [INFO] [stdout] | [INFO] [stdout] 246 | / if self.current_cfg_copy.disp_fullscreen && !self.mouse_hidden { [INFO] [stdout] 247 | | if self.last_mouse_move.elapsed().as_millis() > FULLSCREEN_MOUSE_HIDE_MILLISEC { [INFO] [stdout] 248 | | self.mouse_hidden = true; [INFO] [stdout] 249 | | helper.set_cursor_visible(false); [INFO] [stdout] 250 | | } [INFO] [stdout] 251 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ if self.current_cfg_copy.disp_fullscreen && !self.mouse_hidden [INFO] [stdout] 247 ~ && self.last_mouse_move.elapsed().as_millis() > FULLSCREEN_MOUSE_HIDE_MILLISEC { [INFO] [stdout] 248 | self.mouse_hidden = true; [INFO] [stdout] 249 | helper.set_cursor_visible(false); [INFO] [stdout] 250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vector2` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:272:15 [INFO] [stdout] | [INFO] [stdout] 272 | self.size = info.viewport_size_pixels().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*info.viewport_size_pixels()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/httpsrv/mod.rs:425:69 [INFO] [stdout] | [INFO] [stdout] 425 | ... println!("Unalbe to read file {}: {}", filename.display(), e.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/httpsrv/mod.rs:426:68 [INFO] [stdout] | [INFO] [stdout] 426 | ... format!("Unalbe to read file {}: {}", filename.display(), e.to_string()).into_bytes() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:453:8 [INFO] [stdout] | [INFO] [stdout] 453 | if method == &Method::GET || method == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::GET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/httpsrv/mod.rs:453:34 [INFO] [stdout] | [INFO] [stdout] 453 | if method == &Method::GET || method == &Method::POST { [INFO] [stdout] | ^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Method::POST` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/httpsrv/mod.rs:483:16 [INFO] [stdout] | [INFO] [stdout] 483 | let addr = addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/httpsrv/mod.rs:486:43 [INFO] [stdout] | [INFO] [stdout] 486 | Ok::<_,Infallible>(servicefn(d, req, addr.clone()).await) [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | / match &self.block { [INFO] [stdout] 200 | | Some(b) => { [INFO] [stdout] 201 | | [INFO] [stdout] 202 | | let fgcolor = match csscolorparser::parse(&self.current_cfg_copy.disp_textcolor) { [INFO] [stdout] ... | [INFO] [stdout] 243 | | None => {} [INFO] [stdout] 244 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 199 ~ if let Some(b) = &self.block { [INFO] [stdout] 200 + [INFO] [stdout] 201 ~ let fgcolor = match csscolorparser::parse(&self.current_cfg_copy.disp_textcolor) { [INFO] [stdout] 202 ~ Ok(c) => Color::from_rgb(c.r as f32, c.g as f32, c.b as f32), [INFO] [stdout] 203 ~ Err(_) => Color::WHITE [INFO] [stdout] 204 ~ }; [INFO] [stdout] 205 + [INFO] [stdout] 206 ~ graphics.set_clip(Some(clip_area)); [INFO] [stdout] 207 + [INFO] [stdout] 208 ~ graphics.draw_text(( [INFO] [stdout] 209 ~ self.x, [INFO] [stdout] 210 ~ self.y [INFO] [stdout] 211 ~ ), [INFO] [stdout] 212 ~ fgcolor, &b); [INFO] [stdout] 213 + [INFO] [stdout] 214 ~ // println!("self.size.x={} self.size.y={} self.x={} self.y={}", self.size.x, self.size.y, self.x, self.y); [INFO] [stdout] 215 + [INFO] [stdout] 216 ~ if !self.pause { [INFO] [stdout] 217 ~ match self.current_cfg_copy.disp_orientation { [INFO] [stdout] 218 ~ TextScrollOrientation::ScrollVertical => { [INFO] [stdout] 219 ~ self.y -= self.current_cfg_copy.disp_scrollspeed as f32; [INFO] [stdout] 220 + [INFO] [stdout] 221 ~ if self.y >= self.max_y { [INFO] [stdout] 222 ~ self.y = self.min_y; [INFO] [stdout] 223 ~ } [INFO] [stdout] 224 ~ if self.y < self.min_y { [INFO] [stdout] 225 ~ self.y = self.max_y; [INFO] [stdout] 226 ~ } [INFO] [stdout] 227 ~ }, [INFO] [stdout] 228 ~ TextScrollOrientation::ScrollHorizontal => { [INFO] [stdout] 229 ~ self.x -= self.current_cfg_copy.disp_scrollspeed as f32; [INFO] [stdout] 230 + [INFO] [stdout] 231 ~ if self.x >= self.max_x { [INFO] [stdout] 232 ~ self.x = self.min_x; [INFO] [stdout] 233 ~ } [INFO] [stdout] 234 ~ if self.x < self.min_x { [INFO] [stdout] 235 ~ self.x = self.max_x; [INFO] [stdout] 236 ~ } [INFO] [stdout] 237 ~ } [INFO] [stdout] 238 ~ } [INFO] [stdout] 239 ~ } [INFO] [stdout] 240 + [INFO] [stdout] 241 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:213:15 [INFO] [stdout] | [INFO] [stdout] 213 | fgcolor, &b); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:246:3 [INFO] [stdout] | [INFO] [stdout] 246 | / if self.current_cfg_copy.disp_fullscreen && !self.mouse_hidden { [INFO] [stdout] 247 | | if self.last_mouse_move.elapsed().as_millis() > FULLSCREEN_MOUSE_HIDE_MILLISEC { [INFO] [stdout] 248 | | self.mouse_hidden = true; [INFO] [stdout] 249 | | helper.set_cursor_visible(false); [INFO] [stdout] 250 | | } [INFO] [stdout] 251 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ if self.current_cfg_copy.disp_fullscreen && !self.mouse_hidden [INFO] [stdout] 247 ~ && self.last_mouse_move.elapsed().as_millis() > FULLSCREEN_MOUSE_HIDE_MILLISEC { [INFO] [stdout] 248 | self.mouse_hidden = true; [INFO] [stdout] 249 | helper.set_cursor_visible(false); [INFO] [stdout] 250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vector2` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:272:15 [INFO] [stdout] | [INFO] [stdout] 272 | self.size = info.viewport_size_pixels().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*info.viewport_size_pixels()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `Command { std: "docker" "inspect" "159bc36dc2f86f591ed76c467403d40e43706d71baf1439176e3802fcade654f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "159bc36dc2f86f591ed76c467403d40e43706d71baf1439176e3802fcade654f", kill_on_drop: false }` [INFO] [stdout] 159bc36dc2f86f591ed76c467403d40e43706d71baf1439176e3802fcade654f