[INFO] cloning repository https://github.com/gianpy15/rust-splitwise [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gianpy15/rust-splitwise" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgianpy15%2Frust-splitwise", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgianpy15%2Frust-splitwise'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 61c6e4e9eb4b81b40d74eb21990536a8b7ac3704 [INFO] linting gianpy15/rust-splitwise against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgianpy15%2Frust-splitwise" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gianpy15/rust-splitwise [INFO] finished tweaking git repo https://github.com/gianpy15/rust-splitwise [INFO] tweaked toml for git repo https://github.com/gianpy15/rust-splitwise written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gianpy15/rust-splitwise on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gianpy15/rust-splitwise already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded newline-converter v0.2.2 [INFO] [stderr] Downloaded signal-hook v0.3.15 [INFO] [stderr] Downloaded crossterm_winapi v0.9.0 [INFO] [stderr] Downloaded serde_spanned v0.6.2 [INFO] [stderr] Downloaded dyn-clone v1.0.11 [INFO] [stderr] Downloaded migrations_internals v2.1.0 [INFO] [stderr] Downloaded diesel_migrations v2.1.0 [INFO] [stderr] Downloaded migrations_macros v2.1.0 [INFO] [stderr] Downloaded diffy v0.3.0 [INFO] [stderr] Downloaded clap v4.3.3 [INFO] [stderr] Downloaded diesel_cli v2.1.0 [INFO] [stderr] Downloaded clap_complete v4.3.1 [INFO] [stderr] Downloaded diesel_derives v2.1.0 [INFO] [stderr] Downloaded toml v0.7.4 [INFO] [stderr] Downloaded inquire v0.6.2 [INFO] [stderr] Downloaded clap_builder v4.3.3 [INFO] [stderr] Downloaded diesel v2.1.0 [INFO] [stderr] Downloaded rustix v0.37.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09b58bca66cf0e252d27fd6a1675278331ca2b28292a9fe379e2b5d57f1b09eb [INFO] running `Command { std: "docker" "start" "-a" "09b58bca66cf0e252d27fd6a1675278331ca2b28292a9fe379e2b5d57f1b09eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09b58bca66cf0e252d27fd6a1675278331ca2b28292a9fe379e2b5d57f1b09eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09b58bca66cf0e252d27fd6a1675278331ca2b28292a9fe379e2b5d57f1b09eb", kill_on_drop: false }` [INFO] [stdout] 09b58bca66cf0e252d27fd6a1675278331ca2b28292a9fe379e2b5d57f1b09eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad75ca648f3e4c6b254183105490ba161fea8334865276965f87f7b748609b53 [INFO] running `Command { std: "docker" "start" "-a" "ad75ca648f3e4c6b254183105490ba161fea8334865276965f87f7b748609b53", kill_on_drop: false }` [INFO] [stderr] warning: splitwise v0.1.0 (/opt/rustwide/workdir) ignoring invalid dependency `diesel_cli` which is missing a lib target [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking dyn-clone v1.0.11 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling libsqlite3-sys v0.26.0 [INFO] [stderr] Checking newline-converter v0.2.2 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling diesel_derives v2.1.0 [INFO] [stderr] Checking inquire v0.6.2 [INFO] [stderr] Checking diesel v2.1.0 [INFO] [stderr] Checking splitwise v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/context.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / match &self.logged_user { [INFO] [stdout] 33 | | Some(user) => { [INFO] [stdout] 34 | | writeln!(f, "--- {} ---", user.username)?; [INFO] [stdout] 35 | | writeln!(f, "--- Balance: {} ---", user.balance)?; [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | None => (), [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Some(user) = &self.logged_user { [INFO] [stdout] 33 + writeln!(f, "--- {} ---", user.username)?; [INFO] [stdout] 34 + writeln!(f, "--- Balance: {} ---", user.balance)?; [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/context.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / match &self.selected_group { [INFO] [stdout] 41 | | Some(group) => writeln!(f, "--- Group: {} ---", group.name)?, [INFO] [stdout] 42 | | None => (), [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_________^ help: try: `if let Some(group) = &self.selected_group { writeln!(f, "--- Group: {} ---", group.name)? }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/db/queries.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 19 | match users.into_iter().nth(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `users.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/db/queries.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 70 | match groups.into_iter().nth(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `groups.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/context.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / match &self.logged_user { [INFO] [stdout] 33 | | Some(user) => { [INFO] [stdout] 34 | | writeln!(f, "--- {} ---", user.username)?; [INFO] [stdout] 35 | | writeln!(f, "--- Balance: {} ---", user.balance)?; [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | None => (), [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Some(user) = &self.logged_user { [INFO] [stdout] 33 + writeln!(f, "--- {} ---", user.username)?; [INFO] [stdout] 34 + writeln!(f, "--- Balance: {} ---", user.balance)?; [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/context.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / match &self.selected_group { [INFO] [stdout] 41 | | Some(group) => writeln!(f, "--- Group: {} ---", group.name)?, [INFO] [stdout] 42 | | None => (), [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_________^ help: try: `if let Some(group) = &self.selected_group { writeln!(f, "--- Group: {} ---", group.name)? }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/db/queries.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 19 | match users.into_iter().nth(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `users.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/db/queries.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 70 | match groups.into_iter().nth(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `groups.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | if !cli::base::welcome(&mut context).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cli::base::welcome(&mut context).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | if !cli::base::welcome(&mut context).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cli::base::welcome(&mut context).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.47s [INFO] running `Command { std: "docker" "inspect" "ad75ca648f3e4c6b254183105490ba161fea8334865276965f87f7b748609b53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad75ca648f3e4c6b254183105490ba161fea8334865276965f87f7b748609b53", kill_on_drop: false }` [INFO] [stdout] ad75ca648f3e4c6b254183105490ba161fea8334865276965f87f7b748609b53