[INFO] cloning repository https://github.com/ghiegie/test_db_conn [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ghiegie/test_db_conn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fghiegie%2Ftest_db_conn", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fghiegie%2Ftest_db_conn'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2921b4e1b28eebecf6626c7fdb34f3c2d6bdaa6e [INFO] linting ghiegie/test_db_conn against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fghiegie%2Ftest_db_conn" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ghiegie/test_db_conn [INFO] finished tweaking git repo https://github.com/ghiegie/test_db_conn [INFO] tweaked toml for git repo https://github.com/ghiegie/test_db_conn written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ghiegie/test_db_conn on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ghiegie/test_db_conn already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded force-send-sync v1.1.0 [INFO] [stderr] Downloaded objc-sys v0.3.1 [INFO] [stderr] Downloaded polling v3.3.0 [INFO] [stderr] Downloaded odbc-sys v0.23.1 [INFO] [stderr] Downloaded web-time v0.2.3 [INFO] [stderr] Downloaded android-activity v0.5.0 [INFO] [stderr] Downloaded odbc-api v3.0.1 [INFO] [stderr] Downloaded winit v0.29.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb585af282d340e5dc80f001d2d908e7fe9560e85efc7d9dd1367a62cb49b783 [INFO] running `Command { std: "docker" "start" "-a" "cb585af282d340e5dc80f001d2d908e7fe9560e85efc7d9dd1367a62cb49b783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb585af282d340e5dc80f001d2d908e7fe9560e85efc7d9dd1367a62cb49b783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb585af282d340e5dc80f001d2d908e7fe9560e85efc7d9dd1367a62cb49b783", kill_on_drop: false }` [INFO] [stdout] cb585af282d340e5dc80f001d2d908e7fe9560e85efc7d9dd1367a62cb49b783 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf0bcdea0c2c8e9285ea2f6a9d35d17b3c91c8732ad3b1529715ab9f66974dba [INFO] running `Command { std: "docker" "start" "-a" "cf0bcdea0c2c8e9285ea2f6a9d35d17b3c91c8732ad3b1529715ab9f66974dba", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling odbc-sys v0.23.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking widestring v1.0.2 [INFO] [stderr] Checking force-send-sync v1.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking thiserror v1.0.50 [INFO] [stderr] Checking odbc-api v3.0.1 [INFO] [stderr] Checking test_db_conn v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `ConnectionOptions` and `Environment` [INFO] [stdout] --> src/main.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use odbc_api::{ConnectionOptions, Environment}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Connection`, `Error`, and `IntoParameter` [INFO] [stdout] --> src/main.rs:25:56 [INFO] [stdout] | [INFO] [stdout] 25 | use odbc_api::{ConnectionOptions, Environment, Connection, Error, IntoParameter, Cursor}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/main.rs:134:67 [INFO] [stdout] | [INFO] [stdout] 134 | conn.execute("insert into ProductTbl(Product) values(?)", (&to_insert.into_parameter())).expect("FAILED TO INSERT"); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 134 - conn.execute("insert into ProductTbl(Product) values(?)", (&to_insert.into_parameter())).expect("FAILED TO INSERT"); [INFO] [stdout] 134 + conn.execute("insert into ProductTbl(Product) values(?)", &to_insert.into_parameter() ).expect("FAILED TO INSERT"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/main.rs:200:64 [INFO] [stdout] | [INFO] [stdout] 200 | conn.execute("delete from ProductTbl where Product=?", (&to_del.into_parameter())).expect("FAILED TO DELETE"); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 200 - conn.execute("delete from ProductTbl where Product=?", (&to_del.into_parameter())).expect("FAILED TO DELETE"); [INFO] [stdout] 200 + conn.execute("delete from ProductTbl where Product=?", &to_del.into_parameter() ).expect("FAILED TO DELETE"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ConnectionOptions` and `Environment` [INFO] [stdout] --> src/main.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use odbc_api::{ConnectionOptions, Environment}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | let mut conn = env.connect_with_connection_string(conn_str, ConnectionOptions::default()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | ... let mut conn = env.connect_with_connection_string(conn_str, ConnectionOptions::default()).expect("FAILED TO CREATE CONNECTION"); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | assert!(!conn.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `conn.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | assert!(!ret.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `ret.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / loop { [INFO] [stdout] 65 | | if let Ok(somthing) = cursor.next_row() { [INFO] [stdout] 66 | | if let Some(mut obj) = somthing { [INFO] [stdout] 67 | | let mut item: i32 = 0; [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________^ help: try: `while let Ok(somthing) = cursor.next_row() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | / if let Some(mut obj) = somthing { [INFO] [stdout] 67 | | let mut item: i32 = 0; [INFO] [stdout] 68 | | obj.get_data(6, &mut item).unwrap(); [INFO] [stdout] 69 | | println!("{}", item); [INFO] [stdout] 70 | | } else { [INFO] [stdout] 71 | | break; [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 65 | if let Ok(somthing) = cursor.next_row() { [INFO] [stdout] | ^^^^^^^^ replace this binding [INFO] [stdout] 66 | if let Some(mut obj) = somthing { [INFO] [stdout] | ^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.72s [INFO] running `Command { std: "docker" "inspect" "cf0bcdea0c2c8e9285ea2f6a9d35d17b3c91c8732ad3b1529715ab9f66974dba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf0bcdea0c2c8e9285ea2f6a9d35d17b3c91c8732ad3b1529715ab9f66974dba", kill_on_drop: false }` [INFO] [stdout] cf0bcdea0c2c8e9285ea2f6a9d35d17b3c91c8732ad3b1529715ab9f66974dba