[INFO] cloning repository https://github.com/geraldsaberon/aoc-2015
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/geraldsaberon/aoc-2015" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgeraldsaberon%2Faoc-2015", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgeraldsaberon%2Faoc-2015'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 3d16949b4bdeb2fef77318df26c2d1b19c62daaa
[INFO] linting geraldsaberon/aoc-2015 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgeraldsaberon%2Faoc-2015" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/geraldsaberon/aoc-2015
[INFO] finished tweaking git repo https://github.com/geraldsaberon/aoc-2015
[INFO] tweaked toml for git repo https://github.com/geraldsaberon/aoc-2015 written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/geraldsaberon/aoc-2015 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/geraldsaberon/aoc-2015 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 4b8424331d42561ef33c160e3a663520c06a34a5d83632de33cfca32b85ebc8a
[INFO] running `Command { std: "docker" "start" "-a" "4b8424331d42561ef33c160e3a663520c06a34a5d83632de33cfca32b85ebc8a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "4b8424331d42561ef33c160e3a663520c06a34a5d83632de33cfca32b85ebc8a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "4b8424331d42561ef33c160e3a663520c06a34a5d83632de33cfca32b85ebc8a", kill_on_drop: false }`
[INFO] [stdout] 4b8424331d42561ef33c160e3a663520c06a34a5d83632de33cfca32b85ebc8a
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 31ee8ddb8270e604d3a975e1f8f144ccfdc9076195769e154ad9bbc11b15fa85
[INFO] running `Command { std: "docker" "start" "-a" "31ee8ddb8270e604d3a975e1f8f144ccfdc9076195769e154ad9bbc11b15fa85", kill_on_drop: false }`
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking md-5 v0.10.6
[INFO] [stderr]     Checking aoc-2015 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/03.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     return visited.len();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -     return visited.len();
[INFO] [stdout] 16 +     visited.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/03.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     return visited.len();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -     return visited.len();
[INFO] [stdout] 32 +     visited.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/03.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 36 | /     return match d {
[INFO] [stdout] 37 | |         '^' => (p.0-1, p.1),
[INFO] [stdout] 38 | |         'v' => (p.0+1, p.1),
[INFO] [stdout] 39 | |         '>' => (p.0, p.1+1),
[INFO] [stdout] 40 | |         '<' => (p.0, p.1-1),
[INFO] [stdout] 41 | |         _ => p
[INFO] [stdout] 42 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 ~     match d {
[INFO] [stdout] 37 +         '^' => (p.0-1, p.1),
[INFO] [stdout] 38 +         'v' => (p.0+1, p.1),
[INFO] [stdout] 39 +         '>' => (p.0, p.1+1),
[INFO] [stdout] 40 +         '<' => (p.0, p.1-1),
[INFO] [stdout] 41 +         _ => p
[INFO] [stdout] 42 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/bin/07.rs:29:16
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                ^^^^^^^^^^^^ help: try: `l.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/bin/07.rs:29:32
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                                ^^^^^^^^^^^^ help: try: `r.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `l` after checking its variant with `is_none`
[INFO] [stdout]   --> src/bin/07.rs:30:25
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                 ----------- the check is happening here
[INFO] [stdout] 30 |                 let l = l.unwrap();
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `r` after checking its variant with `is_none`
[INFO] [stdout]   --> src/bin/07.rs:31:25
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                                 ----------- the check is happening here
[INFO] [stdout] 30 |                 let l = l.unwrap();
[INFO] [stdout] 31 |                 let r = r.unwrap();
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 |     return *values.get("a").unwrap();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 46 -     return *values.get("a").unwrap();
[INFO] [stdout] 46 +     *values.get("a").unwrap()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return Some(n);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -         return Some(n);
[INFO] [stdout] 51 +         Some(n)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:53:9
[INFO] [stdout]    |
[INFO] [stdout] 53 |         return Some(*n);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 53 -         return Some(*n);
[INFO] [stdout] 53 +         Some(*n)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         return None;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 55 -         return None;
[INFO] [stdout] 55 +         None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/05.rs:44:5
[INFO] [stdout]    |
[INFO] [stdout] 44 |     return n_vowels > 2 && has_double;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 44 -     return n_vowels > 2 && has_double;
[INFO] [stdout] 44 +     n_vowels > 2 && has_double
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/06.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     return result;
[INFO] [stdout] 22 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/05.rs:74:5
[INFO] [stdout]    |
[INFO] [stdout] 74 |     return has_pair && has_repeat;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 74 -     return has_pair && has_repeat;
[INFO] [stdout] 74 +     has_pair && has_repeat
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]   --> src/bin/05.rs:57:13
[INFO] [stdout]    |
[INFO] [stdout] 57 | /             if pairs.contains_key(&pair) {
[INFO] [stdout] 58 | |                 let j = pairs.get(&pair).unwrap();
[INFO] [stdout] 59 | |                 if i - j > 1 {
[INFO] [stdout] 60 | |                     has_pair = true;
[INFO] [stdout] ...  |
[INFO] [stdout] 63 | |                 pairs.insert(pair, i);
[INFO] [stdout] 64 | |             }
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout]    = note: `#[warn(clippy::map_entry)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/06.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 40 -     return result;
[INFO] [stdout] 40 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/bin/07.rs:29:16
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                ^^^^^^^^^^^^ help: try: `l.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/bin/07.rs:29:32
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                                ^^^^^^^^^^^^ help: try: `r.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `l` after checking its variant with `is_none`
[INFO] [stdout]   --> src/bin/07.rs:30:25
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                 ----------- the check is happening here
[INFO] [stdout] 30 |                 let l = l.unwrap();
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `r` after checking its variant with `is_none`
[INFO] [stdout]   --> src/bin/07.rs:31:25
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if !l.is_none() && !r.is_none() {
[INFO] [stdout]    |                                 ----------- the check is happening here
[INFO] [stdout] 30 |                 let l = l.unwrap();
[INFO] [stdout] 31 |                 let r = r.unwrap();
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 |     return *values.get("a").unwrap();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 46 -     return *values.get("a").unwrap();
[INFO] [stdout] 46 +     *values.get("a").unwrap()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return Some(n);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -         return Some(n);
[INFO] [stdout] 51 +         Some(n)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:53:9
[INFO] [stdout]    |
[INFO] [stdout] 53 |         return Some(*n);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 53 -         return Some(*n);
[INFO] [stdout] 53 +         Some(*n)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/07.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         return None;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 55 -         return None;
[INFO] [stdout] 55 +         None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/10.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -     return result;
[INFO] [stdout] 23 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/bin/10.rs:10:25
[INFO] [stdout]    |
[INFO] [stdout] 10 |     let mut current_n = input.chars().nth(0).expect("Input is empty");
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `input.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/03.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     return visited.len();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -     return visited.len();
[INFO] [stdout] 16 +     visited.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/03.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     return visited.len();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -     return visited.len();
[INFO] [stdout] 32 +     visited.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/03.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 36 | /     return match d {
[INFO] [stdout] 37 | |         '^' => (p.0-1, p.1),
[INFO] [stdout] 38 | |         'v' => (p.0+1, p.1),
[INFO] [stdout] 39 | |         '>' => (p.0, p.1+1),
[INFO] [stdout] 40 | |         '<' => (p.0, p.1-1),
[INFO] [stdout] 41 | |         _ => p
[INFO] [stdout] 42 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 ~     match d {
[INFO] [stdout] 37 +         '^' => (p.0-1, p.1),
[INFO] [stdout] 38 +         'v' => (p.0+1, p.1),
[INFO] [stdout] 39 +         '>' => (p.0, p.1+1),
[INFO] [stdout] 40 +         '<' => (p.0, p.1-1),
[INFO] [stdout] 41 +         _ => p
[INFO] [stdout] 42 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/10.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -     return result;
[INFO] [stdout] 23 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/bin/10.rs:10:25
[INFO] [stdout]    |
[INFO] [stdout] 10 |     let mut current_n = input.chars().nth(0).expect("Input is empty");
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `input.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/06.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     return result;
[INFO] [stdout] 22 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/06.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 40 -     return result;
[INFO] [stdout] 40 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/05.rs:44:5
[INFO] [stdout]    |
[INFO] [stdout] 44 |     return n_vowels > 2 && has_double;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 44 -     return n_vowels > 2 && has_double;
[INFO] [stdout] 44 +     n_vowels > 2 && has_double
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/05.rs:74:5
[INFO] [stdout]    |
[INFO] [stdout] 74 |     return has_pair && has_repeat;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 74 -     return has_pair && has_repeat;
[INFO] [stdout] 74 +     has_pair && has_repeat
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]   --> src/bin/05.rs:57:13
[INFO] [stdout]    |
[INFO] [stdout] 57 | /             if pairs.contains_key(&pair) {
[INFO] [stdout] 58 | |                 let j = pairs.get(&pair).unwrap();
[INFO] [stdout] 59 | |                 if i - j > 1 {
[INFO] [stdout] 60 | |                     has_pair = true;
[INFO] [stdout] ...  |
[INFO] [stdout] 63 | |                 pairs.insert(pair, i);
[INFO] [stdout] 64 | |             }
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout]    = note: `#[warn(clippy::map_entry)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.40s
[INFO] running `Command { std: "docker" "inspect" "31ee8ddb8270e604d3a975e1f8f144ccfdc9076195769e154ad9bbc11b15fa85", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "31ee8ddb8270e604d3a975e1f8f144ccfdc9076195769e154ad9bbc11b15fa85", kill_on_drop: false }`
[INFO] [stdout] 31ee8ddb8270e604d3a975e1f8f144ccfdc9076195769e154ad9bbc11b15fa85