[INFO] cloning repository https://github.com/gdanezis/auth_db [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gdanezis/auth_db" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgdanezis%2Fauth_db", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgdanezis%2Fauth_db'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e149938aa7ea41141c74535b001970cf49fc92ed [INFO] linting gdanezis/auth_db against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgdanezis%2Fauth_db" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-7-tc1/source/.cargo/config [INFO] started tweaking git repo https://github.com/gdanezis/auth_db [INFO] finished tweaking git repo https://github.com/gdanezis/auth_db [INFO] tweaked toml for git repo https://github.com/gdanezis/auth_db written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gdanezis/auth_db on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gdanezis/auth_db already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crossbeam-epoch v0.9.1 [INFO] [stderr] Downloaded parking_lot_core v0.8.2 [INFO] [stderr] Downloaded lock_api v0.4.2 [INFO] [stderr] Downloaded const_fn v0.4.5 [INFO] [stderr] Downloaded crossbeam-utils v0.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d67a507053db303362dffd94e52213edb691fa574634aeab403f98bbb38f8a5 [INFO] running `Command { std: "docker" "start" "-a" "4d67a507053db303362dffd94e52213edb691fa574634aeab403f98bbb38f8a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d67a507053db303362dffd94e52213edb691fa574634aeab403f98bbb38f8a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d67a507053db303362dffd94e52213edb691fa574634aeab403f98bbb38f8a5", kill_on_drop: false }` [INFO] [stdout] 4d67a507053db303362dffd94e52213edb691fa574634aeab403f98bbb38f8a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7a5618e0e784d56bfccec9c4951d3c472cbdcb8aa74c14d91952afcacbded87 [INFO] running `Command { std: "docker" "start" "-a" "b7a5618e0e784d56bfccec9c4951d3c472cbdcb8aa74c14d91952afcacbded87", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling const_fn v0.4.5 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_core v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking auth_db v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/auth_db.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 294 | pointer: pointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/auth_db.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 294 | pointer: pointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `digest`, `path`, and `data` are never read [INFO] [stdout] --> src/auth_db.rs:739:5 [INFO] [stdout] | [INFO] [stdout] 737 | pub struct AuthTreeEntry { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 738 | key: AKey, [INFO] [stdout] 739 | digest: [u8; DIGEST_SIZE], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 740 | path: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 741 | data: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthTreeEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TreeWorkSet` [INFO] [stdout] --> src/auth_db.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> TreeWorkSet { [INFO] [stdout] 22 | | TreeWorkSet { [INFO] [stdout] 23 | | cache: HashMap::new(), [INFO] [stdout] 24 | | remove: Vec::new(), [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for TreeWorkSet { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TreeCache` [INFO] [stdout] --> src/auth_db.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / pub fn new() -> TreeCache { [INFO] [stdout] 73 | | TreeCache { [INFO] [stdout] 74 | | root: None, [INFO] [stdout] 75 | | cache: HashMap::with_capacity(1000), [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 71 + impl Default for TreeCache { [INFO] [stdout] 72 + fn default() -> Self { [INFO] [stdout] 73 + Self::new() [INFO] [stdout] 74 + } [INFO] [stdout] 75 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/auth_db.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 82 | for (_k, v) in &mut self.cache { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 82 - for (_k, v) in &mut self.cache { [INFO] [stdout] 82 + for v in self.cache.values_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth_db.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | self.cache.remove(&elem); [INFO] [stdout] | ^^^^^ help: change this to: `elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/auth_db.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 107 | let current_pointer = self.next_pointer.fetch_add(1, Ordering::Relaxed); [INFO] [stdout] | ------------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 108 | current_pointer [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 107 ~ [INFO] [stdout] 108 ~ self.next_pointer.fetch_add(1, Ordering::Relaxed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.root` after checking its variant with `is_none` [INFO] [stdout] --> src/auth_db.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 134 | let root_pointer = if self.root.is_none() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.root` [INFO] [stdout] ... [INFO] [stdout] 141 | self.root.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/auth_db.rs:156:42 [INFO] [stdout] | [INFO] [stdout] 156 | if number_of_returns == 0 && scratch.spare_elements.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `scratch.spare_elements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/auth_db.rs:219:33 [INFO] [stdout] | [INFO] [stdout] 219 | let positions: Vec<_> = (0..this_node_len).into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..this_node_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth_db.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | return scratch; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 247 - return scratch; [INFO] [stdout] 247 + scratch [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/auth_db.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 230 | if ops.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ops.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth_db.rs:239:91 [INFO] [stdout] | [INFO] [stdout] 239 | self.update_parallel(depth + 1, &mut scratch, this_child_ref.pointer, &ops); [INFO] [stdout] | ^^^^ help: change this to: `ops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth_db.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 305 - } [INFO] [stdout] 306 - return; [INFO] [stdout] 305 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:336:39 [INFO] [stdout] | [INFO] [stdout] 336 | if peek_next.is_none() || !(peek_next.unwrap().key() <= &this_child_ref.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(peek_next.unwrap().key() > &this_child_ref.key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/auth_db.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 426 | / let new_node = AuthTreeInternalNode { [INFO] [stdout] 427 | | updated: false, [INFO] [stdout] 428 | | leaf, [INFO] [stdout] 429 | | elements: 0, [INFO] [stdout] 430 | | bounds, [INFO] [stdout] 431 | | items: [Default::default(); NODE_CAPACITY], [INFO] [stdout] 432 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 433 | [INFO] [stdout] 434 | new_node [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 426 ~ [INFO] [stdout] 427 | [INFO] [stdout] 428 ~ AuthTreeInternalNode { [INFO] [stdout] 429 + updated: false, [INFO] [stdout] 430 + leaf, [INFO] [stdout] 431 + elements: 0, [INFO] [stdout] 432 + bounds, [INFO] [stdout] 433 + items: [Default::default(); NODE_CAPACITY], [INFO] [stdout] 434 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | if !(peek_key <= &bounds[1]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(peek_key > &bounds[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:496:16 [INFO] [stdout] | [INFO] [stdout] 496 | if !(self.bounds[0] <= elem.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.bounds[0] > elem.key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:502:20 [INFO] [stdout] | [INFO] [stdout] 502 | if !(old_val < elem.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(old_val >= elem.key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth_db.rs:523:13 [INFO] [stdout] | [INFO] [stdout] 523 | return GetPointer::NotFound; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 523 - return GetPointer::NotFound; [INFO] [stdout] 523 + GetPointer::NotFound [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:564:44 [INFO] [stdout] | [INFO] [stdout] 564 | let self_list_finished: bool = !(position < self.elements); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(position >= self.elements)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:566:43 [INFO] [stdout] | [INFO] [stdout] 566 | peek_element.is_none() || !(peek_element.unwrap().key() <= &self.bounds[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(peek_element.unwrap().key() > &self.bounds[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:644:16 [INFO] [stdout] | [INFO] [stdout] 644 | if !(next_key <= &self.bounds[1]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(next_key > &self.bounds[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/auth_db.rs:630:12 [INFO] [stdout] | [INFO] [stdout] 630 | if size % NODE_CAPACITY > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!size.is_multiple_of(NODE_CAPACITY)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `digest`, `path`, and `data` are never read [INFO] [stdout] --> src/auth_db.rs:739:5 [INFO] [stdout] | [INFO] [stdout] 737 | pub struct AuthTreeEntry { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 738 | key: AKey, [INFO] [stdout] 739 | digest: [u8; DIGEST_SIZE], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 740 | path: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 741 | data: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthTreeEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TreeWorkSet` [INFO] [stdout] --> src/auth_db.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> TreeWorkSet { [INFO] [stdout] 22 | | TreeWorkSet { [INFO] [stdout] 23 | | cache: HashMap::new(), [INFO] [stdout] 24 | | remove: Vec::new(), [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for TreeWorkSet { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TreeCache` [INFO] [stdout] --> src/auth_db.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / pub fn new() -> TreeCache { [INFO] [stdout] 73 | | TreeCache { [INFO] [stdout] 74 | | root: None, [INFO] [stdout] 75 | | cache: HashMap::with_capacity(1000), [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 71 + impl Default for TreeCache { [INFO] [stdout] 72 + fn default() -> Self { [INFO] [stdout] 73 + Self::new() [INFO] [stdout] 74 + } [INFO] [stdout] 75 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/auth_db.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 82 | for (_k, v) in &mut self.cache { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 82 - for (_k, v) in &mut self.cache { [INFO] [stdout] 82 + for v in self.cache.values_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth_db.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | self.cache.remove(&elem); [INFO] [stdout] | ^^^^^ help: change this to: `elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/auth_db.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 107 | let current_pointer = self.next_pointer.fetch_add(1, Ordering::Relaxed); [INFO] [stdout] | ------------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 108 | current_pointer [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 107 ~ [INFO] [stdout] 108 ~ self.next_pointer.fetch_add(1, Ordering::Relaxed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.root` after checking its variant with `is_none` [INFO] [stdout] --> src/auth_db.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 134 | let root_pointer = if self.root.is_none() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.root` [INFO] [stdout] ... [INFO] [stdout] 141 | self.root.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/auth_db.rs:156:42 [INFO] [stdout] | [INFO] [stdout] 156 | if number_of_returns == 0 && scratch.spare_elements.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `scratch.spare_elements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/auth_db.rs:219:33 [INFO] [stdout] | [INFO] [stdout] 219 | let positions: Vec<_> = (0..this_node_len).into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..this_node_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth_db.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | return scratch; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 247 - return scratch; [INFO] [stdout] 247 + scratch [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/auth_db.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 230 | if ops.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ops.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth_db.rs:239:91 [INFO] [stdout] | [INFO] [stdout] 239 | self.update_parallel(depth + 1, &mut scratch, this_child_ref.pointer, &ops); [INFO] [stdout] | ^^^^ help: change this to: `ops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth_db.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 305 - } [INFO] [stdout] 306 - return; [INFO] [stdout] 305 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:336:39 [INFO] [stdout] | [INFO] [stdout] 336 | if peek_next.is_none() || !(peek_next.unwrap().key() <= &this_child_ref.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(peek_next.unwrap().key() > &this_child_ref.key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/auth_db.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 426 | / let new_node = AuthTreeInternalNode { [INFO] [stdout] 427 | | updated: false, [INFO] [stdout] 428 | | leaf, [INFO] [stdout] 429 | | elements: 0, [INFO] [stdout] 430 | | bounds, [INFO] [stdout] 431 | | items: [Default::default(); NODE_CAPACITY], [INFO] [stdout] 432 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 433 | [INFO] [stdout] 434 | new_node [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 426 ~ [INFO] [stdout] 427 | [INFO] [stdout] 428 ~ AuthTreeInternalNode { [INFO] [stdout] 429 + updated: false, [INFO] [stdout] 430 + leaf, [INFO] [stdout] 431 + elements: 0, [INFO] [stdout] 432 + bounds, [INFO] [stdout] 433 + items: [Default::default(); NODE_CAPACITY], [INFO] [stdout] 434 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | if !(peek_key <= &bounds[1]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(peek_key > &bounds[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:496:16 [INFO] [stdout] | [INFO] [stdout] 496 | if !(self.bounds[0] <= elem.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.bounds[0] > elem.key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:502:20 [INFO] [stdout] | [INFO] [stdout] 502 | if !(old_val < elem.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(old_val >= elem.key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth_db.rs:523:13 [INFO] [stdout] | [INFO] [stdout] 523 | return GetPointer::NotFound; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 523 - return GetPointer::NotFound; [INFO] [stdout] 523 + GetPointer::NotFound [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:564:44 [INFO] [stdout] | [INFO] [stdout] 564 | let self_list_finished: bool = !(position < self.elements); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(position >= self.elements)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:566:43 [INFO] [stdout] | [INFO] [stdout] 566 | peek_element.is_none() || !(peek_element.unwrap().key() <= &self.bounds[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(peek_element.unwrap().key() > &self.bounds[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth_db.rs:644:16 [INFO] [stdout] | [INFO] [stdout] 644 | if !(next_key <= &self.bounds[1]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(next_key > &self.bounds[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/auth_db.rs:630:12 [INFO] [stdout] | [INFO] [stdout] 630 | if size % NODE_CAPACITY > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!size.is_multiple_of(NODE_CAPACITY)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tests.rs:15:45 [INFO] [stdout] | [INFO] [stdout] 15 | let x: Vec = (0..1000).map(|num| get_test_entry(num)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_test_entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tests.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|num| get_test_entry(num)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_test_entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tests.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|num| get_test_entry(num)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_test_entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tests.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|num| get_test_entry(num)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_test_entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | assert!(returns.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!returns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | assert!(returns.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!returns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:168:24 [INFO] [stdout] | [INFO] [stdout] 168 | match tree.get(&key_exists.key(), &mut None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `key_exists.key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:178:24 [INFO] [stdout] | [INFO] [stdout] 178 | match tree.get(&key_exists.key(), &mut None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `key_exists.key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | assert!(tree.cache.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tree.cache.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:214:24 [INFO] [stdout] | [INFO] [stdout] 214 | match tree.get(&key_exists.key(), &mut None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `key_exists.key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:221:24 [INFO] [stdout] | [INFO] [stdout] 221 | match tree.get(&key_not_exists.key(), &mut None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `key_not_exists.key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:235:24 [INFO] [stdout] | [INFO] [stdout] 235 | match tree.get(&key_exists.key(), &mut None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `key_exists.key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:242:24 [INFO] [stdout] | [INFO] [stdout] 242 | match tree.get(&key_not_exists.key(), &mut None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `key_not_exists.key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:267:13 [INFO] [stdout] | [INFO] [stdout] 267 | assert!(tree.get_updated_pointers().len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tree.get_updated_pointers().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | assert!(tree.get_updated_pointers().len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tree.get_updated_pointers().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | assert!(tree.get_updated_pointers().len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tree.get_updated_pointers().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tests.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | assert!(tree.get_updated_pointers().len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tree.get_updated_pointers().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.80s [INFO] running `Command { std: "docker" "inspect" "b7a5618e0e784d56bfccec9c4951d3c472cbdcb8aa74c14d91952afcacbded87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7a5618e0e784d56bfccec9c4951d3c472cbdcb8aa74c14d91952afcacbded87", kill_on_drop: false }` [INFO] [stdout] b7a5618e0e784d56bfccec9c4951d3c472cbdcb8aa74c14d91952afcacbded87