[INFO] cloning repository https://github.com/gboutte/assets-manager [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gboutte/assets-manager" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgboutte%2Fassets-manager", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgboutte%2Fassets-manager'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ff207a5715db91581cf95801c394830a9ee814bd [INFO] linting gboutte/assets-manager against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgboutte%2Fassets-manager" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gboutte/assets-manager [INFO] finished tweaking git repo https://github.com/gboutte/assets-manager [INFO] tweaked toml for git repo https://github.com/gboutte/assets-manager written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gboutte/assets-manager on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gboutte/assets-manager already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sdd v3.0.10 [INFO] [stderr] Downloaded filesize v0.2.0 [INFO] [stderr] Downloaded serial_test_derive v3.4.0 [INFO] [stderr] Downloaded serial_test v3.4.0 [INFO] [stderr] Downloaded deflate64 v0.1.11 [INFO] [stderr] Downloaded unicase_serde v0.1.0 [INFO] [stderr] Downloaded rocket_cors v0.6.0 [INFO] [stderr] Downloaded scc v2.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 907df027e67a04d66affdca30d4d72541befd68f59db5cbe8bf19a69bff44855 [INFO] running `Command { std: "docker" "start" "-a" "907df027e67a04d66affdca30d4d72541befd68f59db5cbe8bf19a69bff44855", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "907df027e67a04d66affdca30d4d72541befd68f59db5cbe8bf19a69bff44855", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "907df027e67a04d66affdca30d4d72541befd68f59db5cbe8bf19a69bff44855", kill_on_drop: false }` [INFO] [stdout] 907df027e67a04d66affdca30d4d72541befd68f59db5cbe8bf19a69bff44855 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ac3d12fbacbfa3097162409b4a595f935c8dce46d0cd7e135d4416d70347134 [INFO] running `Command { std: "docker" "start" "-a" "0ac3d12fbacbfa3097162409b4a595f935c8dce46d0cd7e135d4416d70347134", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling http v0.2.12 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling deranged v0.5.5 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Compiling devise_core v0.4.2 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling http-body v0.4.6 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Checking cookie v0.18.1 [INFO] [stderr] Compiling pear v0.2.9 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling rocket v0.5.1 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Compiling devise_codegen v0.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling socket2 v0.5.10 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling devise v0.4.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking crc v3.4.0 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking uncased v0.9.10 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking ubyte v0.10.4 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking unicase_serde v0.1.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking deflate64 v0.1.11 [INFO] [stderr] Checking filesize v0.2.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling serial_test_derive v3.4.0 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking bzip2 v0.5.2 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Compiling hyper v0.14.32 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking figment v0.10.19 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking serial_test v3.4.0 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Compiling rocket_http v0.5.1 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking multer v3.1.0 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Compiling rocket_codegen v0.5.1 [INFO] [stderr] Checking rocket_cors v0.6.0 [INFO] [stderr] Checking assets-manager v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/storage.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | let ends_with_slash = path.as_ref() [INFO] [stdout] | _______________________________^ [INFO] [stdout] 33 | | .to_str() [INFO] [stdout] 34 | | .map_or(false, |s| s.ends_with('/')); [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 34 - .map_or(false, |s| s.ends_with('/')); [INFO] [stdout] 34 + .is_some_and(|s| s.ends_with('/')); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/storage.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | let ends_with_slash = path.as_ref() [INFO] [stdout] | _______________________________^ [INFO] [stdout] 33 | | .to_str() [INFO] [stdout] 34 | | .map_or(false, |s| s.ends_with('/')); [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 34 - .map_or(false, |s| s.ends_with('/')); [INFO] [stdout] 34 + .is_some_and(|s| s.ends_with('/')); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 32 - let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 32 + let uploaded_filepath = form.file.path().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 39 | let file_path_str =file_path.to_str().ok_or_else(|| Status::BadRequest)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 39 - let file_path_str =file_path.to_str().ok_or_else(|| Status::BadRequest)?; [INFO] [stdout] 39 + let file_path_str =file_path.to_str().ok_or(Status::BadRequest)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 44 - let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 44 + let prefix = full_path.parent().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 32 - let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 32 + let uploaded_filepath = form.file.path().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 39 | let file_path_str =file_path.to_str().ok_or_else(|| Status::BadRequest)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 39 - let file_path_str =file_path.to_str().ok_or_else(|| Status::BadRequest)?; [INFO] [stdout] 39 + let file_path_str =file_path.to_str().ok_or(Status::BadRequest)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 44 - let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 44 + let prefix = full_path.parent().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 74 - let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 74 + let prefix = full_path.parent().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 79 - let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 79 + let uploaded_filepath = form.file.path().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 74 - let prefix = full_path.parent().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 74 + let prefix = full_path.parent().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/upload.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 79 - let uploaded_filepath = form.file.path().ok_or_else(|| Status::InternalServerError)?; [INFO] [stdout] 79 + let uploaded_filepath = form.file.path().ok_or(Status::InternalServerError)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/storage_test.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | assert!(!storage_path_res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `storage_path_res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/storage_test.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | assert!(!storage_path_res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `storage_path_res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 43.93s [INFO] running `Command { std: "docker" "inspect" "0ac3d12fbacbfa3097162409b4a595f935c8dce46d0cd7e135d4416d70347134", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ac3d12fbacbfa3097162409b4a595f935c8dce46d0cd7e135d4416d70347134", kill_on_drop: false }` [INFO] [stdout] 0ac3d12fbacbfa3097162409b4a595f935c8dce46d0cd7e135d4416d70347134