[INFO] cloning repository https://github.com/garnish-lang/garnish-core [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/garnish-lang/garnish-core" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgarnish-lang%2Fgarnish-core", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgarnish-lang%2Fgarnish-core'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d79c537e3f5deb904670aca6f4f0fe267878c2b9 [INFO] linting garnish-lang/garnish-core against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgarnish-lang%2Fgarnish-core" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/garnish-lang/garnish-core [INFO] finished tweaking git repo https://github.com/garnish-lang/garnish-core [INFO] tweaked toml for git repo https://github.com/garnish-lang/garnish-core written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/garnish-lang/garnish-core on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3d3a433da7aeb062e26a7fb8994b7edd9d92ffca6db101b14e3e12a987e30ae [INFO] running `Command { std: "docker" "start" "-a" "c3d3a433da7aeb062e26a7fb8994b7edd9d92ffca6db101b14e3e12a987e30ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3d3a433da7aeb062e26a7fb8994b7edd9d92ffca6db101b14e3e12a987e30ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3d3a433da7aeb062e26a7fb8994b7edd9d92ffca6db101b14e3e12a987e30ae", kill_on_drop: false }` [INFO] [stdout] c3d3a433da7aeb062e26a7fb8994b7edd9d92ffca6db101b14e3e12a987e30ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf7733a49df6a99d2e0526660e933c84dde6f7e0e8bda3a0b2930129fba2d4db [INFO] running `Command { std: "docker" "start" "-a" "bf7733a49df6a99d2e0526660e933c84dde6f7e0e8bda3a0b2930129fba2d4db", kill_on_drop: false }` [INFO] [stderr] Checking garnish_lang_traits v0.0.25-alpha (/opt/rustwide/workdir/traits) [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking jiff v0.2.23 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/data.rs:184:83 [INFO] [stdout] | [INFO] [stdout] 184 | ...tem_index: Self::Number) -> Result>, Self::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> traits/src/error.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | e.source = Some(source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `RuntimeError:: { source: Some(source), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> traits/src/error.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | let mut e = RuntimeError::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/helpers/concatenation.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | ) -> Result<(Option, Data::Size), RuntimeError> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/helpers/concatenation.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | ) -> Result<(Option, Data::Size), RuntimeError> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/helpers/concatenation.rs:53:6 [INFO] [stdout] | [INFO] [stdout] 53 | ) -> Result<(Option, Data::Size), RuntimeError> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> traits/src/helpers/concatenation.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | format!("Popping more registers than placed during concatenation indexing.").as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Popping more registers than placed during concatenation indexing.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> traits/src/helpers/concatenation.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | / match temp_result { [INFO] [stdout] 109 | | Some(_) => { [INFO] [stdout] 110 | | result = temp_result; [INFO] [stdout] 111 | | break; [INFO] [stdout] 112 | | } [INFO] [stdout] 113 | | _ => (), // continue [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 108 ~ if let Some(_) = temp_result { [INFO] [stdout] 109 + result = temp_result; [INFO] [stdout] 110 + break; [INFO] [stdout] 111 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> traits/src/helpers/clone.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 130 | while let Some(index) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for index in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> traits/src/helpers/clone.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | / match to.get_data_type(left)? { [INFO] [stdout] 189 | | GarnishDataType::Symbol => true, [INFO] [stdout] 190 | | _ => false, [INFO] [stdout] 191 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 188 - match to.get_data_type(left)? { [INFO] [stdout] 189 - GarnishDataType::Symbol => true, [INFO] [stdout] 190 - _ => false, [INFO] [stdout] 191 - } [INFO] [stdout] 188 + matches!(to.get_data_type(left)?, GarnishDataType::Symbol) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking garnish_lang_simple_data v0.0.25-alpha (/opt/rustwide/workdir/data) [INFO] [stderr] Checking garnish_lang_runtime v0.0.25-alpha (/opt/rustwide/workdir/runtime) [INFO] [stderr] Checking garnish_lang_compiler v0.0.25-alpha (/opt/rustwide/workdir/compiler) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/data.rs:184:83 [INFO] [stdout] | [INFO] [stdout] 184 | ...tem_index: Self::Number) -> Result>, Self::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> traits/src/error.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | e.source = Some(source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `RuntimeError:: { source: Some(source), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> traits/src/error.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | let mut e = RuntimeError::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/helpers/concatenation.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | ) -> Result<(Option, Data::Size), RuntimeError> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/helpers/concatenation.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | ) -> Result<(Option, Data::Size), RuntimeError> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> traits/src/helpers/concatenation.rs:53:6 [INFO] [stdout] | [INFO] [stdout] 53 | ) -> Result<(Option, Data::Size), RuntimeError> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> traits/src/helpers/concatenation.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | format!("Popping more registers than placed during concatenation indexing.").as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Popping more registers than placed during concatenation indexing.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> traits/src/helpers/concatenation.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | / match temp_result { [INFO] [stdout] 109 | | Some(_) => { [INFO] [stdout] 110 | | result = temp_result; [INFO] [stdout] 111 | | break; [INFO] [stdout] 112 | | } [INFO] [stdout] 113 | | _ => (), // continue [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 108 ~ if let Some(_) = temp_result { [INFO] [stdout] 109 + result = temp_result; [INFO] [stdout] 110 + break; [INFO] [stdout] 111 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> traits/src/helpers/clone.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 130 | while let Some(index) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for index in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> traits/src/helpers/clone.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | / match to.get_data_type(left)? { [INFO] [stdout] 189 | | GarnishDataType::Symbol => true, [INFO] [stdout] 190 | | _ => false, [INFO] [stdout] 191 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 188 - match to.get_data_type(left)? { [INFO] [stdout] 189 - GarnishDataType::Symbol => true, [INFO] [stdout] 190 - _ => false, [INFO] [stdout] 191 - } [INFO] [stdout] 188 + matches!(to.get_data_type(left)?, GarnishDataType::Symbol) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> runtime/src/runtime/equality.rs:291:30 [INFO] [stdout] | [INFO] [stdout] 291 | fn compare_list_to_primitive( [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 300 | Data: GarnishData, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> runtime/src/runtime/equality.rs:291:30 [INFO] [stdout] | [INFO] [stdout] 291 | fn compare_list_to_primitive( [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 300 | Data: GarnishData, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> runtime/src/runtime/mod.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 114 | Self { current: 0, s: s } [INFO] [stdout] | ^^^^ help: replace it with: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> runtime/src/runtime/mod.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | Self { current: 0, b: b } [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> runtime/src/runtime/mod.rs:164:32 [INFO] [stdout] | [INFO] [stdout] 164 | Self { current: 0, symbol_list: symbol_list } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/apply.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | None => state_error(format!("Failed to pop input during reapply operation."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to pop input during reapply operation.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> runtime/src/runtime/apply.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/apply.rs:205:42 [INFO] [stdout] | [INFO] [stdout] 205 | _ => state_error(format!("Could not narrow range."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not narrow range.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/apply.rs:208:34 [INFO] [stdout] | [INFO] [stdout] 208 | _ => state_error(format!("Could not narrow range."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not narrow range.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/apply.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> compiler/src/build/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod build; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/apply.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | None => state_error(format!("Failed to pop input during reapply operation."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to pop input during reapply operation.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> runtime/src/runtime/apply.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/build/build.rs:226:65 [INFO] [stdout] | [INFO] [stdout] 226 | Some(Some(node)) if node.contributes_to_list => match node.list_parent { [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 227 | | Some((parent, _)) => { [INFO] [stdout] 228 | | node.contributes_to_list = false; [INFO] [stdout] ... | [INFO] [stdout] 233 | | None => {} [INFO] [stdout] 234 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 226 ~ Some(Some(node)) if node.contributes_to_list => if let Some((parent, _)) = node.list_parent { [INFO] [stdout] 227 + node.contributes_to_list = false; [INFO] [stdout] 228 + [INFO] [stdout] 229 + let parent_node = nodes.get_mut_or_error(parent)?; [INFO] [stdout] 230 + parent_node.child_count.next(); [INFO] [stdout] 231 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:262:1 [INFO] [stdout] | [INFO] [stdout] 262 | / fn handle_parse_node( [INFO] [stdout] 263 | | data: &mut Data, [INFO] [stdout] 264 | | mut nodes: &mut Vec>>, [INFO] [stdout] 265 | | mut instruction_metadata: &mut Vec, [INFO] [stdout] ... | [INFO] [stdout] 270 | | parse_node: &ParseNode, [INFO] [stdout] 271 | | ) -> Result<(), CompilerError<::Error>> { [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:273:79 [INFO] [stdout] | [INFO] [stdout] 273 | ... Definition::Unit => handle_value_primitive(|data, _| data.add_unit(), &mut nodes, node_index, &mut stack, parse_node, data, &... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:273:103 [INFO] [stdout] | [INFO] [stdout] 273 | ..._| data.add_unit(), &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:273:133 [INFO] [stdout] | [INFO] [stdout] 273 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:274:81 [INFO] [stdout] | [INFO] [stdout] 274 | ... Definition::False => handle_value_primitive(|data, _| data.add_false(), &mut nodes, node_index, &mut stack, parse_node, data,... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:274:105 [INFO] [stdout] | [INFO] [stdout] 274 | ...| data.add_false(), &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:274:135 [INFO] [stdout] | [INFO] [stdout] 274 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:275:79 [INFO] [stdout] | [INFO] [stdout] 275 | ... Definition::True => handle_value_primitive(|data, _| data.add_true(), &mut nodes, node_index, &mut stack, parse_node, data, &... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:275:103 [INFO] [stdout] | [INFO] [stdout] 275 | ..._| data.add_true(), &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:275:133 [INFO] [stdout] | [INFO] [stdout] 275 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 280 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 283 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/apply.rs:205:42 [INFO] [stdout] | [INFO] [stdout] 205 | _ => state_error(format!("Could not narrow range."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not narrow range.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/apply.rs:208:34 [INFO] [stdout] | [INFO] [stdout] 208 | _ => state_error(format!("Could not narrow range."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not narrow range.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:305:13 [INFO] [stdout] | [INFO] [stdout] 305 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 310 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:312:88 [INFO] [stdout] | [INFO] [stdout] 312 | ... Definition::Value => handle_value_like(|_, _| Ok(None), Instruction::PutValue, &mut nodes, node_index, &mut stack, parse_node... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:312:112 [INFO] [stdout] | [INFO] [stdout] 312 | ...truction::PutValue, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:312:142 [INFO] [stdout] | [INFO] [stdout] 312 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 318 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:343:86 [INFO] [stdout] | [INFO] [stdout] 343 | ... Definition::AbsoluteValue => handle_unary_prefix(Instruction::AbsoluteValue, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:343:110 [INFO] [stdout] | [INFO] [stdout] 343 | ...ion::AbsoluteValue, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:343:140 [INFO] [stdout] | [INFO] [stdout] 343 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:344:76 [INFO] [stdout] | [INFO] [stdout] 344 | ... Definition::Opposite => handle_unary_prefix(Instruction::Opposite, &mut nodes, node_index, &mut stack, parse_node, data, &mut... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:344:100 [INFO] [stdout] | [INFO] [stdout] 344 | ...truction::Opposite, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:344:130 [INFO] [stdout] | [INFO] [stdout] 344 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:345:80 [INFO] [stdout] | [INFO] [stdout] 345 | ... Definition::BitwiseNot => handle_unary_prefix(Instruction::BitwiseNot, &mut nodes, node_index, &mut stack, parse_node, data, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:345:104 [INFO] [stdout] | [INFO] [stdout] 345 | ...uction::BitwiseNot, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:345:134 [INFO] [stdout] | [INFO] [stdout] 345 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:346:66 [INFO] [stdout] | [INFO] [stdout] 346 | ... Definition::Not => handle_unary_prefix(Instruction::Not, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:346:90 [INFO] [stdout] | [INFO] [stdout] 346 | ... Definition::Not => handle_unary_prefix(Instruction::Not, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:346:120 [INFO] [stdout] | [INFO] [stdout] 346 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:347:66 [INFO] [stdout] | [INFO] [stdout] 347 | ... Definition::Tis => handle_unary_prefix(Instruction::Tis, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:347:90 [INFO] [stdout] | [INFO] [stdout] 347 | ... Definition::Tis => handle_unary_prefix(Instruction::Tis, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:347:120 [INFO] [stdout] | [INFO] [stdout] 347 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:348:72 [INFO] [stdout] | [INFO] [stdout] 348 | ... Definition::TypeOf => handle_unary_prefix(Instruction::TypeOf, &mut nodes, node_index, &mut stack, parse_node, data, &mut ins... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:348:96 [INFO] [stdout] | [INFO] [stdout] 348 | ...nstruction::TypeOf, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:348:126 [INFO] [stdout] | [INFO] [stdout] 348 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:349:96 [INFO] [stdout] | [INFO] [stdout] 349 | ...ary_prefix(Instruction::AccessLeftInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:349:120 [INFO] [stdout] | [INFO] [stdout] 349 | ...AccessLeftInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:349:150 [INFO] [stdout] | [INFO] [stdout] 349 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:350:80 [INFO] [stdout] | [INFO] [stdout] 350 | ... Definition::EmptyApply => handle_unary_suffix(Instruction::EmptyApply, &mut nodes, node_index, &mut stack, parse_node, data, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:350:104 [INFO] [stdout] | [INFO] [stdout] 350 | ...uction::EmptyApply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:350:134 [INFO] [stdout] | [INFO] [stdout] 350 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:351:98 [INFO] [stdout] | [INFO] [stdout] 351 | ...ry_suffix(Instruction::AccessRightInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:351:122 [INFO] [stdout] | [INFO] [stdout] 351 | ...ccessRightInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:351:152 [INFO] [stdout] | [INFO] [stdout] 351 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:352:100 [INFO] [stdout] | [INFO] [stdout] 352 | ...y_suffix(Instruction::AccessLengthInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:352:124 [INFO] [stdout] | [INFO] [stdout] 352 | ...cessLengthInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:352:154 [INFO] [stdout] | [INFO] [stdout] 352 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:353:75 [INFO] [stdout] | [INFO] [stdout] 353 | ... Definition::Addition => handle_binary_operation(Instruction::Add, &mut nodes, node_index, &mut stack, parse_node, data, &mut ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:353:99 [INFO] [stdout] | [INFO] [stdout] 353 | ...n(Instruction::Add, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:353:129 [INFO] [stdout] | [INFO] [stdout] 353 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:354:83 [INFO] [stdout] | [INFO] [stdout] 354 | ... Definition::Subtraction => handle_binary_operation(Instruction::Subtract, &mut nodes, node_index, &mut stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:354:107 [INFO] [stdout] | [INFO] [stdout] 354 | ...truction::Subtract, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:354:137 [INFO] [stdout] | [INFO] [stdout] 354 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:355:90 [INFO] [stdout] | [INFO] [stdout] 355 | ... Definition::MultiplicationSign => handle_binary_operation(Instruction::Multiply, &mut nodes, node_index, &mut stack, parse_no... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:355:114 [INFO] [stdout] | [INFO] [stdout] 355 | ...truction::Multiply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:355:144 [INFO] [stdout] | [INFO] [stdout] 355 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:356:78 [INFO] [stdout] | [INFO] [stdout] 356 | ... Definition::Division => handle_binary_operation(Instruction::Divide, &mut nodes, node_index, &mut stack, parse_node, data, &m... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:356:102 [INFO] [stdout] | [INFO] [stdout] 356 | ...nstruction::Divide, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:356:132 [INFO] [stdout] | [INFO] [stdout] 356 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:357:76 [INFO] [stdout] | [INFO] [stdout] 357 | ... Definition::Access => handle_binary_operation(Instruction::Access, &mut nodes, node_index, &mut stack, parse_node, data, &mut... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:357:100 [INFO] [stdout] | [INFO] [stdout] 357 | ...nstruction::Access, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:357:130 [INFO] [stdout] | [INFO] [stdout] 357 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:358:78 [INFO] [stdout] | [INFO] [stdout] 358 | ... Definition::Range => handle_binary_operation(Instruction::MakeRange, &mut nodes, node_index, &mut stack, parse_node, data, &m... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:358:102 [INFO] [stdout] | [INFO] [stdout] 358 | ...ruction::MakeRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:358:132 [INFO] [stdout] | [INFO] [stdout] 358 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:359:106 [INFO] [stdout] | [INFO] [stdout] 359 | ...ation(Instruction::MakeStartExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:359:130 [INFO] [stdout] | [INFO] [stdout] 359 | ...tartExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:359:160 [INFO] [stdout] | [INFO] [stdout] 359 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:360:102 [INFO] [stdout] | [INFO] [stdout] 360 | ...eration(Instruction::MakeEndExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:360:126 [INFO] [stdout] | [INFO] [stdout] 360 | ...eEndExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:360:156 [INFO] [stdout] | [INFO] [stdout] 360 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:361:96 [INFO] [stdout] | [INFO] [stdout] 361 | ..._operation(Instruction::MakeExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:361:120 [INFO] [stdout] | [INFO] [stdout] 361 | ...MakeExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:361:150 [INFO] [stdout] | [INFO] [stdout] 361 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:362:84 [INFO] [stdout] | [INFO] [stdout] 362 | ... Definition::ExponentialSign => handle_binary_operation(Instruction::Power, &mut nodes, node_index, &mut stack, parse_node, da... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:362:108 [INFO] [stdout] | [INFO] [stdout] 362 | ...Instruction::Power, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:362:138 [INFO] [stdout] | [INFO] [stdout] 362 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:363:82 [INFO] [stdout] | [INFO] [stdout] 363 | ... Definition::Remainder => handle_binary_operation(Instruction::Remainder, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:363:106 [INFO] [stdout] | [INFO] [stdout] 363 | ...ruction::Remainder, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:363:136 [INFO] [stdout] | [INFO] [stdout] 363 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:364:92 [INFO] [stdout] | [INFO] [stdout] 364 | ...inary_operation(Instruction::IntegerDivide, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:364:116 [INFO] [stdout] | [INFO] [stdout] 364 | ...ion::IntegerDivide, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> runtime/src/runtime/casting.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:364:146 [INFO] [stdout] | [INFO] [stdout] 364 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:365:84 [INFO] [stdout] | [INFO] [stdout] 365 | ... Definition::BitwiseAnd => handle_binary_operation(Instruction::BitwiseAnd, &mut nodes, node_index, &mut stack, parse_node, da... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:365:108 [INFO] [stdout] | [INFO] [stdout] 365 | ...uction::BitwiseAnd, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:365:138 [INFO] [stdout] | [INFO] [stdout] 365 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:366:82 [INFO] [stdout] | [INFO] [stdout] 366 | ... Definition::BitwiseOr => handle_binary_operation(Instruction::BitwiseOr, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:366:106 [INFO] [stdout] | [INFO] [stdout] 366 | ...ruction::BitwiseOr, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:366:136 [INFO] [stdout] | [INFO] [stdout] 366 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:367:84 [INFO] [stdout] | [INFO] [stdout] 367 | ... Definition::BitwiseXor => handle_binary_operation(Instruction::BitwiseXor, &mut nodes, node_index, &mut stack, parse_node, da... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:367:108 [INFO] [stdout] | [INFO] [stdout] 367 | ...uction::BitwiseXor, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:367:138 [INFO] [stdout] | [INFO] [stdout] 367 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:368:98 [INFO] [stdout] | [INFO] [stdout] 368 | ...y_operation(Instruction::BitwiseShiftRight, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:368:122 [INFO] [stdout] | [INFO] [stdout] 368 | ...:BitwiseShiftRight, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:368:152 [INFO] [stdout] | [INFO] [stdout] 368 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:369:96 [INFO] [stdout] | [INFO] [stdout] 369 | ...ry_operation(Instruction::BitwiseShiftLeft, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:369:120 [INFO] [stdout] | [INFO] [stdout] 369 | ...::BitwiseShiftLeft, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:369:150 [INFO] [stdout] | [INFO] [stdout] 369 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:370:70 [INFO] [stdout] | [INFO] [stdout] 370 | ... Definition::Xor => handle_binary_operation(Instruction::Xor, &mut nodes, node_index, &mut stack, parse_node, data, &mut instr... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:370:94 [INFO] [stdout] | [INFO] [stdout] 370 | ...n(Instruction::Xor, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:370:124 [INFO] [stdout] | [INFO] [stdout] 370 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:371:82 [INFO] [stdout] | [INFO] [stdout] 371 | ... Definition::TypeEqual => handle_binary_operation(Instruction::TypeEqual, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:371:106 [INFO] [stdout] | [INFO] [stdout] 371 | ...ruction::TypeEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:371:136 [INFO] [stdout] | [INFO] [stdout] 371 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:372:81 [INFO] [stdout] | [INFO] [stdout] 372 | ... Definition::TypeCast => handle_binary_operation(Instruction::ApplyType, &mut nodes, node_index, &mut stack, parse_node, data,... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:372:105 [INFO] [stdout] | [INFO] [stdout] 372 | ...ruction::ApplyType, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:372:135 [INFO] [stdout] | [INFO] [stdout] 372 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:373:77 [INFO] [stdout] | [INFO] [stdout] 373 | ... Definition::Equality => handle_binary_operation(Instruction::Equal, &mut nodes, node_index, &mut stack, parse_node, data, &mu... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:373:101 [INFO] [stdout] | [INFO] [stdout] 373 | ...Instruction::Equal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:373:131 [INFO] [stdout] | [INFO] [stdout] 373 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:374:82 [INFO] [stdout] | [INFO] [stdout] 374 | ... Definition::Inequality => handle_binary_operation(Instruction::NotEqual, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:374:106 [INFO] [stdout] | [INFO] [stdout] 374 | ...truction::NotEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:374:136 [INFO] [stdout] | [INFO] [stdout] 374 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:375:80 [INFO] [stdout] | [INFO] [stdout] 375 | ... Definition::LessThan => handle_binary_operation(Instruction::LessThan, &mut nodes, node_index, &mut stack, parse_node, data, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:375:104 [INFO] [stdout] | [INFO] [stdout] 375 | ...truction::LessThan, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:375:134 [INFO] [stdout] | [INFO] [stdout] 375 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:376:94 [INFO] [stdout] | [INFO] [stdout] 376 | ...ary_operation(Instruction::LessThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:376:118 [INFO] [stdout] | [INFO] [stdout] 376 | ...n::LessThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:376:148 [INFO] [stdout] | [INFO] [stdout] 376 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:377:86 [INFO] [stdout] | [INFO] [stdout] 377 | ... Definition::GreaterThan => handle_binary_operation(Instruction::GreaterThan, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:377:110 [INFO] [stdout] | [INFO] [stdout] 377 | ...ction::GreaterThan, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:377:140 [INFO] [stdout] | [INFO] [stdout] 377 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:378:100 [INFO] [stdout] | [INFO] [stdout] 378 | ..._operation(Instruction::GreaterThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:378:124 [INFO] [stdout] | [INFO] [stdout] 378 | ...GreaterThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:378:154 [INFO] [stdout] | [INFO] [stdout] 378 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:379:74 [INFO] [stdout] | [INFO] [stdout] 379 | ... Definition::Apply => handle_binary_operation(Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, data, &mut i... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:379:98 [INFO] [stdout] | [INFO] [stdout] 379 | ...Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:379:128 [INFO] [stdout] | [INFO] [stdout] 379 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:380:88 [INFO] [stdout] | [INFO] [stdout] 380 | ... Definition::PartialApply => handle_binary_operation(Instruction::PartialApply, &mut nodes, node_index, &mut stack, parse_node... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:380:112 [INFO] [stdout] | [INFO] [stdout] 380 | ...tion::PartialApply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:380:142 [INFO] [stdout] | [INFO] [stdout] 380 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:381:83 [INFO] [stdout] | [INFO] [stdout] 381 | ... Definition::Concatenation => handle_binary_operation(Instruction::Concat, &mut nodes, node_index, &mut stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:381:107 [INFO] [stdout] | [INFO] [stdout] 381 | ...nstruction::Concat, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:381:137 [INFO] [stdout] | [INFO] [stdout] 381 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:382:86 [INFO] [stdout] | [INFO] [stdout] 382 | ... Definition::Pair => handle_binary_operation_with_push(Instruction::MakePair, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:382:110 [INFO] [stdout] | [INFO] [stdout] 382 | ...truction::MakePair, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:382:140 [INFO] [stdout] | [INFO] [stdout] 382 | ...mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:385:86 [INFO] [stdout] | [INFO] [stdout] 385 | ... Definition::ApplyTo => handle_binary_operation_with_push(Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:385:110 [INFO] [stdout] | [INFO] [stdout] 385 | ...Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:385:140 [INFO] [stdout] | [INFO] [stdout] 385 | ...mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:388:69 [INFO] [stdout] | [INFO] [stdout] 388 | ... Definition::CommaList => handle_list(Definition::CommaList, &mut nodes, node_index, &mut stack, parse_node, data, &mut instru... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:388:93 [INFO] [stdout] | [INFO] [stdout] 388 | ...inition::CommaList, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:388:123 [INFO] [stdout] | [INFO] [stdout] 388 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:389:59 [INFO] [stdout] | [INFO] [stdout] 389 | ... Definition::List => handle_list(Definition::List, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_meta... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:389:83 [INFO] [stdout] | [INFO] [stdout] 389 | ... Definition::List => handle_list(Definition::List, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_meta... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:389:113 [INFO] [stdout] | [INFO] [stdout] 389 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:66 [INFO] [stdout] | [INFO] [stdout] 390 | ... Definition::Or => handle_logical_binary(Instruction::Or, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:90 [INFO] [stdout] | [INFO] [stdout] 390 | ... Definition::Or => handle_logical_binary(Instruction::Or, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:102 [INFO] [stdout] | [INFO] [stdout] 390 | ...r, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:137 [INFO] [stdout] | [INFO] [stdout] 390 | ...oot_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:68 [INFO] [stdout] | [INFO] [stdout] 391 | ... Definition::And => handle_logical_binary(Instruction::And, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, d... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:92 [INFO] [stdout] | [INFO] [stdout] 391 | ...y(Instruction::And, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:104 [INFO] [stdout] | [INFO] [stdout] 391 | ...d, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:139 [INFO] [stdout] | [INFO] [stdout] 391 | ...oot_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:452:13 [INFO] [stdout] | [INFO] [stdout] 452 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:454:13 [INFO] [stdout] | [INFO] [stdout] 454 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:455:13 [INFO] [stdout] | [INFO] [stdout] 455 | &mut root_stack, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 458 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:462:13 [INFO] [stdout] | [INFO] [stdout] 462 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:465:13 [INFO] [stdout] | [INFO] [stdout] 465 | &mut root_stack, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> compiler/src/build/build.rs:502:28 [INFO] [stdout] | [INFO] [stdout] 502 | if node.conditional_items.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!node.conditional_items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:579:13 [INFO] [stdout] | [INFO] [stdout] 579 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:581:13 [INFO] [stdout] | [INFO] [stdout] 581 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 584 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:589:13 [INFO] [stdout] | [INFO] [stdout] 589 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:591:13 [INFO] [stdout] | [INFO] [stdout] 591 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:594:13 [INFO] [stdout] | [INFO] [stdout] 594 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:635:1 [INFO] [stdout] | [INFO] [stdout] 635 | / fn handle_unary_fix_apply( [INFO] [stdout] 636 | | child: Option, [INFO] [stdout] 637 | | definition: Definition, [INFO] [stdout] 638 | | nodes: &mut Vec>>, [INFO] [stdout] ... | [INFO] [stdout] 643 | | instruction_metadata: &mut Vec, [INFO] [stdout] 644 | | ) -> Result<(), CompilerError> { [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:638:12 [INFO] [stdout] | [INFO] [stdout] 638 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 638 - nodes: &mut Vec>>, [INFO] [stdout] 638 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:676:1 [INFO] [stdout] | [INFO] [stdout] 676 | / fn handle_jump_if( [INFO] [stdout] 677 | | instruction: Instruction, [INFO] [stdout] 678 | | nodes: &mut Vec>>, [INFO] [stdout] 679 | | node_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 684 | | instruction_metadata: &mut Vec, [INFO] [stdout] 685 | | ) -> Result<(), CompilerError> { [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:678:12 [INFO] [stdout] | [INFO] [stdout] 678 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 678 - nodes: &mut Vec>>, [INFO] [stdout] 678 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/build/build.rs:707:45 [INFO] [stdout] | [INFO] [stdout] 707 | Some(conditional_parent) => match nodes.get_mut(conditional_parent) { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 708 | | Some(Some(parent)) => { [INFO] [stdout] 709 | | parent.conditional_items.push(ConditionItem { [INFO] [stdout] 710 | | node_index: right, [INFO] [stdout] ... | [INFO] [stdout] 717 | | _ => {} [INFO] [stdout] 718 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 707 ~ Some(conditional_parent) => if let Some(Some(parent)) = nodes.get_mut(conditional_parent) { [INFO] [stdout] 708 + parent.conditional_items.push(ConditionItem { [INFO] [stdout] 709 + node_index: right, [INFO] [stdout] 710 + jump_index_to_update: jump_index.clone(), [INFO] [stdout] 711 + root_end_instruction: (Instruction::Invalid, None), [INFO] [stdout] 712 + }); [INFO] [stdout] 713 + data.push_instruction(instruction, Some(jump_index.clone()))?; [INFO] [stdout] 714 + instruction_metadata.push(InstructionMetadata::new(Some(node_index))); [INFO] [stdout] 715 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:739:1 [INFO] [stdout] | [INFO] [stdout] 739 | / fn handle_logical_binary( [INFO] [stdout] 740 | | instruction: Instruction, [INFO] [stdout] 741 | | nodes: &mut Vec>>, [INFO] [stdout] 742 | | node_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 747 | | instruction_metadata: &mut Vec, [INFO] [stdout] 748 | | ) -> Result<(), CompilerError> { [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:741:12 [INFO] [stdout] | [INFO] [stdout] 741 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 741 - nodes: &mut Vec>>, [INFO] [stdout] 741 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:813:1 [INFO] [stdout] | [INFO] [stdout] 813 | / fn handle_value_like( [INFO] [stdout] 814 | | add_fn: Fn, [INFO] [stdout] 815 | | instruction: Instruction, [INFO] [stdout] 816 | | nodes: &mut Vec>>, [INFO] [stdout] ... | [INFO] [stdout] 823 | | where [INFO] [stdout] 824 | | Fn: FnOnce(&mut Data, &ParseNode) -> Result, Data::Error>, [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:816:12 [INFO] [stdout] | [INFO] [stdout] 816 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 816 - nodes: &mut Vec>>, [INFO] [stdout] 816 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> runtime/src/runtime/casting.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:937:1 [INFO] [stdout] | [INFO] [stdout] 937 | / fn handle_binary_operation_with_push( [INFO] [stdout] 938 | | instruction: Instruction, [INFO] [stdout] 939 | | nodes: &mut Vec>>, [INFO] [stdout] 940 | | node_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 947 | | where [INFO] [stdout] 948 | | Fn: FnOnce(usize, usize) -> (usize, usize), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:939:12 [INFO] [stdout] | [INFO] [stdout] 939 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 939 - nodes: &mut Vec>>, [INFO] [stdout] 939 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> compiler/src/error.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | e.source = Some(source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `CompilerError:: { source: Some(source), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> compiler/src/error.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mut e = CompilerError::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/error.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 109 | Err(CompilerError::new_message(format!("Syntax Error: Unmatched grouping token")).append_token_details(token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Syntax Error: Unmatched grouping token".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> runtime/src/runtime/casting.rs:284:16 [INFO] [stdout] | [INFO] [stdout] 284 | Ok(list_index as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `list_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/error.rs:113:36 [INFO] [stdout] | [INFO] [stdout] 113 | Err(CompilerError::new_message(format!("Syntax Error: Unclosed grouping")).append_token_details(token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Syntax Error: Unclosed grouping".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/jumps.rs:86:37 [INFO] [stdout] | [INFO] [stdout] 86 | None => state_error(format!("No inputs available to update during end expression operation."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No inputs available to update during end expression operation.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> compiler/src/lex/lexer.rs:361:24 [INFO] [stdout] | [INFO] [stdout] 361 | Some(t) => match t { [INFO] [stdout] | ________________________^ [INFO] [stdout] 362 | | TokenType::Identifier => { [INFO] [stdout] 363 | | if self.current_characters == "_" || self.current_characters == ":" { [INFO] [stdout] 364 | | Err(CompilerError::new( [INFO] [stdout] ... | [INFO] [stdout] 373 | | _ => Ok(()), [INFO] [stdout] 374 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> compiler/src/lex/lexer.rs:361:18 [INFO] [stdout] | [INFO] [stdout] 361 | Some(t) => match t { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 362 | TokenType::Identifier => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:505:24 [INFO] [stdout] | [INFO] [stdout] 505 | let item = self.items.get(list as usize).unwrap().get(index as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.items.get(list as usize).unwrap().get(index as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> runtime/src/runtime/list.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Ok(None); [INFO] [stdout] 89 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:510:24 [INFO] [stdout] | [INFO] [stdout] 510 | let item = self.items.get(list as usize).unwrap().get(index as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.items.get(list as usize).unwrap().get(index as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:515:24 [INFO] [stdout] | [INFO] [stdout] 515 | let item = self.items.get(list as usize).unwrap().get(index as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.items.get(list as usize).unwrap().get(index as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> runtime/src/runtime/equality.rs:520:5 [INFO] [stdout] | [INFO] [stdout] 520 | / impl Default for ListCompData { [INFO] [stdout] 521 | | fn default() -> Self { [INFO] [stdout] 522 | | Self { [INFO] [stdout] 523 | | types: vec![], [INFO] [stdout] ... | [INFO] [stdout] 529 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 496 ~ #[derive(Default)] [INFO] [stdout] 497 ~ struct ListCompData { [INFO] [stdout] 498 | pub types: Vec, [INFO] [stdout] ... [INFO] [stdout] 520 | [INFO] [stdout] 521 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:540:48 [INFO] [stdout] | [INFO] [stdout] 540 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:568:48 [INFO] [stdout] | [INFO] [stdout] 568 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:596:48 [INFO] [stdout] | [INFO] [stdout] 596 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:624:48 [INFO] [stdout] | [INFO] [stdout] 624 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:652:48 [INFO] [stdout] | [INFO] [stdout] 652 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:679:48 [INFO] [stdout] | [INFO] [stdout] 679 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> runtime/src/runtime/list.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | / match list_item { [INFO] [stdout] 263 | | Some(addr) => { [INFO] [stdout] 264 | | match this.get_data_type(addr.clone())? { [INFO] [stdout] 265 | | GarnishDataType::Pair => { [INFO] [stdout] ... | [INFO] [stdout] 279 | | None => {} [INFO] [stdout] 280 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 262 ~ if let Some(addr) = list_item { [INFO] [stdout] 263 + match this.get_data_type(addr.clone())? { [INFO] [stdout] 264 + GarnishDataType::Pair => { [INFO] [stdout] 265 + let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 266 + match this.get_data_type(left.clone())? { [INFO] [stdout] 267 + GarnishDataType::Symbol => { [INFO] [stdout] 268 + if this.get_symbol(left)? == sym { [INFO] [stdout] 269 + item = Some(right); [INFO] [stdout] 270 + } [INFO] [stdout] 271 + } [INFO] [stdout] 272 + _ => (), [INFO] [stdout] 273 + } [INFO] [stdout] 274 + } [INFO] [stdout] 275 + _ => (), [INFO] [stdout] 276 + } [INFO] [stdout] 277 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:264:33 [INFO] [stdout] | [INFO] [stdout] 264 | / ... match this.get_data_type(addr.clone())? { [INFO] [stdout] 265 | | ... GarnishDataType::Pair => { [INFO] [stdout] 266 | | ... let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 267 | | ... match this.get_data_type(left.clone())? { [INFO] [stdout] ... | [INFO] [stdout] 276 | | ... _ => (), [INFO] [stdout] 277 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 264 ~ if this.get_data_type(addr.clone())? == GarnishDataType::Pair { [INFO] [stdout] 265 + let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 266 + match this.get_data_type(left.clone())? { [INFO] [stdout] 267 + GarnishDataType::Symbol => { [INFO] [stdout] 268 + if this.get_symbol(left)? == sym { [INFO] [stdout] 269 + item = Some(right); [INFO] [stdout] 270 + } [INFO] [stdout] 271 + } [INFO] [stdout] 272 + _ => (), [INFO] [stdout] 273 + } [INFO] [stdout] 274 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> runtime/src/runtime/list.rs:269:49 [INFO] [stdout] | [INFO] [stdout] 269 | / ... if this.get_symbol(left)? == sym { [INFO] [stdout] 270 | | ... item = Some(right); [INFO] [stdout] 271 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 268 ~ GarnishDataType::Symbol [INFO] [stdout] 269 ~ if this.get_symbol(left)? == sym => { [INFO] [stdout] 270 | item = Some(right); [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:267:41 [INFO] [stdout] | [INFO] [stdout] 267 | / ... match this.get_data_type(left.clone())? { [INFO] [stdout] 268 | | ... GarnishDataType::Symbol => { [INFO] [stdout] 269 | | ... if this.get_symbol(left)? == sym { [INFO] [stdout] 270 | | ... item = Some(right); [INFO] [stdout] ... | [INFO] [stdout] 273 | | ... _ => (), [INFO] [stdout] 274 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 267 ~ if this.get_data_type(left.clone())? == GarnishDataType::Symbol { [INFO] [stdout] 268 + if this.get_symbol(left)? == sym { [INFO] [stdout] 269 + item = Some(right); [INFO] [stdout] 270 + } [INFO] [stdout] 271 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:706:48 [INFO] [stdout] | [INFO] [stdout] 706 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:733:48 [INFO] [stdout] | [INFO] [stdout] 733 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 323 | / match this.get_data_type(addr.clone())? { [INFO] [stdout] 324 | | GarnishDataType::Pair => { [INFO] [stdout] 325 | | let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 326 | | match this.get_data_type(left.clone())? { [INFO] [stdout] ... | [INFO] [stdout] 335 | | _ => (), [INFO] [stdout] 336 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 323 ~ if this.get_data_type(addr.clone())? == GarnishDataType::Pair { [INFO] [stdout] 324 + let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 325 + match this.get_data_type(left.clone())? { [INFO] [stdout] 326 + GarnishDataType::Symbol => { [INFO] [stdout] 327 + if this.get_symbol(left)? == sym { [INFO] [stdout] 328 + return Ok(Some(right)); [INFO] [stdout] 329 + } [INFO] [stdout] 330 + } [INFO] [stdout] 331 + _ => (), [INFO] [stdout] 332 + } [INFO] [stdout] 333 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> runtime/src/runtime/list.rs:328:21 [INFO] [stdout] | [INFO] [stdout] 328 | / if this.get_symbol(left)? == sym { [INFO] [stdout] 329 | | return Ok(Some(right)); [INFO] [stdout] 330 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 327 ~ GarnishDataType::Symbol [INFO] [stdout] 328 ~ if this.get_symbol(left)? == sym => { [INFO] [stdout] 329 | return Ok(Some(right)); [INFO] [stdout] 330 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | / match this.get_data_type(left.clone())? { [INFO] [stdout] 327 | | GarnishDataType::Symbol => { [INFO] [stdout] 328 | | if this.get_symbol(left)? == sym { [INFO] [stdout] 329 | | return Ok(Some(right)); [INFO] [stdout] ... | [INFO] [stdout] 332 | | _ => (), [INFO] [stdout] 333 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 326 ~ if this.get_data_type(left.clone())? == GarnishDataType::Symbol { [INFO] [stdout] 327 + if this.get_symbol(left)? == sym { [INFO] [stdout] 328 + return Ok(Some(right)); [INFO] [stdout] 329 + } [INFO] [stdout] 330 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:760:48 [INFO] [stdout] | [INFO] [stdout] 760 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:764:54 [INFO] [stdout] | [INFO] [stdout] 764 | data.stub_get_symbol_list_len = |data, i| Ok(data.lens.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.lens.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:789:48 [INFO] [stdout] | [INFO] [stdout] 789 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> runtime/src/runtime/logical.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | let result = match (is_true_value(this, left)?, is_true_value(this, right)?) { [INFO] [stdout] | __________________^ [INFO] [stdout] 39 | | (false, false) | (true, true) => false, [INFO] [stdout] 40 | | _ => true, [INFO] [stdout] 41 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 38 - let result = match (is_true_value(this, left)?, is_true_value(this, right)?) { [INFO] [stdout] 39 - (false, false) | (true, true) => false, [INFO] [stdout] 40 - _ => true, [INFO] [stdout] 41 - }; [INFO] [stdout] 38 + let result = !matches!((is_true_value(this, left)?, is_true_value(this, right)?), (false, false) | (true, true)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:823:48 [INFO] [stdout] | [INFO] [stdout] 823 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:832:17 [INFO] [stdout] | [INFO] [stdout] 832 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:860:48 [INFO] [stdout] | [INFO] [stdout] 860 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:867:17 [INFO] [stdout] | [INFO] [stdout] 867 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> runtime/src/runtime/logical.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | Ok(match this.get_data_type(addr)? { [INFO] [stdout] | ________^ [INFO] [stdout] 66 | | GarnishDataType::False | GarnishDataType::Unit => false, [INFO] [stdout] 67 | | _ => true, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 65 - Ok(match this.get_data_type(addr)? { [INFO] [stdout] 66 - GarnishDataType::False | GarnishDataType::Unit => false, [INFO] [stdout] 67 - _ => true, [INFO] [stdout] 68 - }) [INFO] [stdout] 65 + Ok(!matches!(this.get_data_type(addr)?, GarnishDataType::False | GarnishDataType::Unit)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/lex/lexer.rs:830:28 [INFO] [stdout] | [INFO] [stdout] 830 | Some(c) => match self.process_char(c) { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 831 | | Some(t) => { [INFO] [stdout] 832 | | next_token = Some(t); [INFO] [stdout] 833 | | break; [INFO] [stdout] 834 | | } [INFO] [stdout] 835 | | None => (), [INFO] [stdout] 836 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 830 ~ Some(c) => if let Some(t) = self.process_char(c) { [INFO] [stdout] 831 + next_token = Some(t); [INFO] [stdout] 832 + break; [INFO] [stdout] 833 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/lex/lexer.rs:841:21 [INFO] [stdout] | [INFO] [stdout] 841 | / match self.process_char('\0') { [INFO] [stdout] 842 | | Some(t) => { [INFO] [stdout] 843 | | next_token = Some(t); [INFO] [stdout] 844 | | break; [INFO] [stdout] 845 | | } [INFO] [stdout] 846 | | None => (), [INFO] [stdout] 847 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 841 ~ if let Some(t) = self.process_char('\0') { [INFO] [stdout] 842 + next_token = Some(t); [INFO] [stdout] 843 + break; [INFO] [stdout] 844 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> compiler/src/lex/lexer.rs:850:24 [INFO] [stdout] | [INFO] [stdout] 850 | if self.current_characters.len() > 0 && self.result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.current_characters.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:896:48 [INFO] [stdout] | [INFO] [stdout] 896 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:903:17 [INFO] [stdout] | [INFO] [stdout] 903 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:939:48 [INFO] [stdout] | [INFO] [stdout] 939 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/put.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | None => state_error(format!("No inputs available to update for update value operation."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No inputs available to update for update value operation.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:948:17 [INFO] [stdout] | [INFO] [stdout] 948 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> compiler/src/lex/lexer.rs:888:13 [INFO] [stdout] | [INFO] [stdout] 888 | / if !current.children.contains_key(&c) { [INFO] [stdout] 889 | | let t = match last { [INFO] [stdout] 890 | | true => Some(token_type), [INFO] [stdout] 891 | | false => None, [INFO] [stdout] ... | [INFO] [stdout] 913 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 888 ~ if let std::collections::hash_map::Entry::Vacant(e) = current.children.entry(c) { [INFO] [stdout] 889 + let t = match last { [INFO] [stdout] 890 + true => Some(token_type), [INFO] [stdout] 891 + false => None, [INFO] [stdout] 892 + }; [INFO] [stdout] 893 + [INFO] [stdout] 894 + e.insert(LexerOperatorNode { [INFO] [stdout] 895 + value: c, [INFO] [stdout] 896 + token_type: t, [INFO] [stdout] 897 + children: HashMap::new(), [INFO] [stdout] 898 + }); [INFO] [stdout] 899 + } else { [INFO] [stdout] 900 + // has child [INFO] [stdout] 901 + if last { [INFO] [stdout] 902 + // update token type [INFO] [stdout] 903 + match current.children.get_mut(&c) { [INFO] [stdout] 904 + Some(node) => { [INFO] [stdout] 905 + node.token_type = Some(token_type); [INFO] [stdout] 906 + } [INFO] [stdout] 907 + None => unreachable!(), [INFO] [stdout] 908 + } [INFO] [stdout] 909 + } [INFO] [stdout] 910 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:976:48 [INFO] [stdout] | [INFO] [stdout] 976 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:983:17 [INFO] [stdout] | [INFO] [stdout] 983 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1012:48 [INFO] [stdout] | [INFO] [stdout] 1012 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1019:17 [INFO] [stdout] | [INFO] [stdout] 1019 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1054:48 [INFO] [stdout] | [INFO] [stdout] 1054 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> runtime/src/runtime/equality.rs:1058:26 [INFO] [stdout] | [INFO] [stdout] 1058 | if addr == 2 { [INFO] [stdout] | __________________________^ [INFO] [stdout] 1059 | | Ok((0, 1)) [INFO] [stdout] 1060 | | } else if addr == 3 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> runtime/src/runtime/equality.rs:1060:33 [INFO] [stdout] | [INFO] [stdout] 1060 | } else if addr == 3 { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 1061 | | Ok((0, 1)) [INFO] [stdout] 1062 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/resolve.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / match this.get_data_type(data.clone())? { [INFO] [stdout] 31 | | GarnishDataType::Symbol => { [INFO] [stdout] 32 | | match this.resolve(this.get_symbol(data)?)? { [INFO] [stdout] 33 | | true => return Ok(None), // context resolved end look up [INFO] [stdout] ... | [INFO] [stdout] 37 | | _ => (), // not a symbol push unit below [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ if this.get_data_type(data.clone())? == GarnishDataType::Symbol { [INFO] [stdout] 31 + match this.resolve(this.get_symbol(data)?)? { [INFO] [stdout] 32 + true => return Ok(None), // context resolved end look up [INFO] [stdout] 33 + false => (), // not resolved fall through [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1063:17 [INFO] [stdout] | [INFO] [stdout] 1063 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/resolve.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / match this.resolve(this.get_symbol(data)?)? { [INFO] [stdout] 33 | | true => return Ok(None), // context resolved end look up [INFO] [stdout] 34 | | false => (), // not resolved fall through [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____________^ help: try: `if this.resolve(this.get_symbol(data)?)? == true { return Ok(None) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1097:48 [INFO] [stdout] | [INFO] [stdout] 1097 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1104:17 [INFO] [stdout] | [INFO] [stdout] 1104 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1139:48 [INFO] [stdout] | [INFO] [stdout] 1139 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1146:17 [INFO] [stdout] | [INFO] [stdout] 1146 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/utilities.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | None => state_error(format!("No references in register."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No references in register.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/utilities.rs:14:71 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn next_two_raw_ref(this: &mut Data) -> Result<(Data::Size, Data::Size), RuntimeError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/utilities.rs:24:6 [INFO] [stdout] | [INFO] [stdout] 24 | ) -> Result<(Data::Number, Data::Number, Data::Number), RuntimeError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1181:48 [INFO] [stdout] | [INFO] [stdout] 1181 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1188:17 [INFO] [stdout] | [INFO] [stdout] 1188 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1223:48 [INFO] [stdout] | [INFO] [stdout] 1223 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1230:17 [INFO] [stdout] | [INFO] [stdout] 1230 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1265:48 [INFO] [stdout] | [INFO] [stdout] 1265 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> runtime/src/runtime/equality.rs:1269:26 [INFO] [stdout] | [INFO] [stdout] 1269 | if addr == 2 { [INFO] [stdout] | __________________________^ [INFO] [stdout] 1270 | | Ok((0, 1)) [INFO] [stdout] 1271 | | } else if addr == 3 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> runtime/src/runtime/equality.rs:1271:33 [INFO] [stdout] | [INFO] [stdout] 1271 | } else if addr == 3 { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 1272 | | Ok((0, 1)) [INFO] [stdout] 1273 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1274:17 [INFO] [stdout] | [INFO] [stdout] 1274 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1309:48 [INFO] [stdout] | [INFO] [stdout] 1309 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1318:17 [INFO] [stdout] | [INFO] [stdout] 1318 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1354:48 [INFO] [stdout] | [INFO] [stdout] 1354 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1363:17 [INFO] [stdout] | [INFO] [stdout] 1363 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1399:48 [INFO] [stdout] | [INFO] [stdout] 1399 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1406:17 [INFO] [stdout] | [INFO] [stdout] 1406 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1442:48 [INFO] [stdout] | [INFO] [stdout] 1442 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1449:17 [INFO] [stdout] | [INFO] [stdout] 1449 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1485:48 [INFO] [stdout] | [INFO] [stdout] 1485 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1492:17 [INFO] [stdout] | [INFO] [stdout] 1492 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1528:48 [INFO] [stdout] | [INFO] [stdout] 1528 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1535:17 [INFO] [stdout] | [INFO] [stdout] 1535 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1571:48 [INFO] [stdout] | [INFO] [stdout] 1571 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1580:17 [INFO] [stdout] | [INFO] [stdout] 1580 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1608:48 [INFO] [stdout] | [INFO] [stdout] 1608 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1615:17 [INFO] [stdout] | [INFO] [stdout] 1615 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1644:48 [INFO] [stdout] | [INFO] [stdout] 1644 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/equality.rs:1651:17 [INFO] [stdout] | [INFO] [stdout] 1651 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1685:48 [INFO] [stdout] | [INFO] [stdout] 1685 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1717:48 [INFO] [stdout] | [INFO] [stdout] 1717 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1749:48 [INFO] [stdout] | [INFO] [stdout] 1749 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ParseResult` [INFO] [stdout] --> compiler/src/parse/parser.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 318 | / pub fn new() -> Self { [INFO] [stdout] 319 | | Self { root: 0, nodes: vec![] } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 317 + impl Default for ParseResult { [INFO] [stdout] 318 + fn default() -> Self { [INFO] [stdout] 319 + Self::new() [INFO] [stdout] 320 + } [INFO] [stdout] 321 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1781:48 [INFO] [stdout] | [INFO] [stdout] 1781 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1814:48 [INFO] [stdout] | [INFO] [stdout] 1814 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GarnishDataType` which implements the `Copy` trait [INFO] [stdout] --> runtime/src/runtime/equality.rs:1847:48 [INFO] [stdout] | [INFO] [stdout] 1847 | data.stub_get_data_type = |data, i| Ok(data.types.get(i as usize).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.types.get(i as usize).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:476:6 [INFO] [stdout] | [INFO] [stdout] 476 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:466:1 [INFO] [stdout] | [INFO] [stdout] 466 | / fn parse_token( [INFO] [stdout] 467 | | id: usize, [INFO] [stdout] 468 | | definition: Definition, [INFO] [stdout] 469 | | left: Option, [INFO] [stdout] ... | [INFO] [stdout] 475 | | right_to_left: bool, [INFO] [stdout] 476 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/parse/parser.rs:471:12 [INFO] [stdout] | [INFO] [stdout] 471 | nodes: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 471 - nodes: &mut Vec, [INFO] [stdout] 471 + nodes: &mut [ParseNode], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:537:34 [INFO] [stdout] | [INFO] [stdout] 537 | implementation_error(format!("Max iterations reached when searching for last parent."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Max iterations reached when searching for last parent.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:607:6 [INFO] [stdout] | [INFO] [stdout] 607 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:598:1 [INFO] [stdout] | [INFO] [stdout] 598 | / fn parse_token_left_to_right( [INFO] [stdout] 599 | | id: usize, [INFO] [stdout] 600 | | definition: Definition, [INFO] [stdout] 601 | | left: Option, [INFO] [stdout] ... | [INFO] [stdout] 606 | | under_group: Option, [INFO] [stdout] 607 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:620:6 [INFO] [stdout] | [INFO] [stdout] 620 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:611:1 [INFO] [stdout] | [INFO] [stdout] 611 | / fn parse_token_right_to_left( [INFO] [stdout] 612 | | id: usize, [INFO] [stdout] 613 | | definition: Definition, [INFO] [stdout] 614 | | left: Option, [INFO] [stdout] ... | [INFO] [stdout] 619 | | under_group: Option, [INFO] [stdout] 620 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:634:6 [INFO] [stdout] | [INFO] [stdout] 634 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:624:1 [INFO] [stdout] | [INFO] [stdout] 624 | / fn parse_value_like( [INFO] [stdout] 625 | | id: usize, [INFO] [stdout] 626 | | definition: Definition, [INFO] [stdout] 627 | | check_for_list: &mut bool, [INFO] [stdout] ... | [INFO] [stdout] 633 | | under_group: Option, [INFO] [stdout] 634 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:648:13 [INFO] [stdout] | [INFO] [stdout] 648 | &priority_map, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `priority_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:677:6 [INFO] [stdout] | [INFO] [stdout] 677 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/parse/parser.rs:674:12 [INFO] [stdout] | [INFO] [stdout] 674 | nodes: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 674 - nodes: &mut Vec, [INFO] [stdout] 674 + nodes: &mut [ParseNode], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:722:125 [INFO] [stdout] | [INFO] [stdout] 722 | (SecondaryDefinition::Value, SecondaryDefinition::Value) if !check_for_list => composition_error(previous, current, &token), [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/jumps.rs:86:37 [INFO] [stdout] | [INFO] [stdout] 86 | None => state_error(format!("No inputs available to update during end expression operation."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No inputs available to update during end expression operation.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:760:120 [INFO] [stdout] | [INFO] [stdout] 760 | | (SecondaryDefinition::UnarySuffix, SecondaryDefinition::UnaryPrefix) => composition_error(previous, current, &token), [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/parse/parser.rs:766:24 [INFO] [stdout] | [INFO] [stdout] 766 | fn trim_tokens(tokens: &Vec) -> &[LexerToken] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 766 - fn trim_tokens(tokens: &Vec) -> &[LexerToken] { [INFO] [stdout] 766 + fn trim_tokens(tokens: &[LexerToken]) -> &[LexerToken] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> compiler/src/parse/parser.rs:1290:11 [INFO] [stdout] | [INFO] [stdout] 1290 | while !node.parent.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `node.parent.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> runtime/src/runtime/list.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Ok(None); [INFO] [stdout] 89 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:808:31 [INFO] [stdout] | [INFO] [stdout] 808 | let trimmed = trim_tokens(&lex_tokens); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `lex_tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:827:57 [INFO] [stdout] | [INFO] [stdout] 827 | None => implementation_error_with_token(format!("Current group set to non-existant group in stack."), token)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Current group set to non-existant group in stack.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> compiler/src/parse/parser.rs:847:25 [INFO] [stdout] | [INFO] [stdout] 847 | / last_left.and_then(|p| nodes.get(p)).and_then(|node| { [INFO] [stdout] 848 | | // need to update prev def as well for composition check [INFO] [stdout] 849 | | previous_second_def = node.secondary_definition; [INFO] [stdout] 850 | | Some(()) [INFO] [stdout] 851 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 847 ~ last_left.and_then(|p| nodes.get(p)).map(|node| { [INFO] [stdout] 848 | // need to update prev def as well for composition check [INFO] [stdout] 849 | previous_second_def = node.secondary_definition; [INFO] [stdout] 850 ~ () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:880:97 [INFO] [stdout] | [INFO] [stdout] 880 | setup_space_list_check(last_left, under_group, &mut nodes, &mut check_for_list, &mut &mut next_last_left)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut next_last_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> runtime/src/runtime/list.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | / match list_item { [INFO] [stdout] 263 | | Some(addr) => { [INFO] [stdout] 264 | | match this.get_data_type(addr.clone())? { [INFO] [stdout] 265 | | GarnishDataType::Pair => { [INFO] [stdout] ... | [INFO] [stdout] 279 | | None => {} [INFO] [stdout] 280 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 262 ~ if let Some(addr) = list_item { [INFO] [stdout] 263 + match this.get_data_type(addr.clone())? { [INFO] [stdout] 264 + GarnishDataType::Pair => { [INFO] [stdout] 265 + let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 266 + match this.get_data_type(left.clone())? { [INFO] [stdout] 267 + GarnishDataType::Symbol => { [INFO] [stdout] 268 + if this.get_symbol(left)? == sym { [INFO] [stdout] 269 + item = Some(right); [INFO] [stdout] 270 + } [INFO] [stdout] 271 + } [INFO] [stdout] 272 + _ => (), [INFO] [stdout] 273 + } [INFO] [stdout] 274 + } [INFO] [stdout] 275 + _ => (), [INFO] [stdout] 276 + } [INFO] [stdout] 277 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:264:33 [INFO] [stdout] | [INFO] [stdout] 264 | / ... match this.get_data_type(addr.clone())? { [INFO] [stdout] 265 | | ... GarnishDataType::Pair => { [INFO] [stdout] 266 | | ... let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 267 | | ... match this.get_data_type(left.clone())? { [INFO] [stdout] ... | [INFO] [stdout] 276 | | ... _ => (), [INFO] [stdout] 277 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 264 ~ if this.get_data_type(addr.clone())? == GarnishDataType::Pair { [INFO] [stdout] 265 + let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 266 + match this.get_data_type(left.clone())? { [INFO] [stdout] 267 + GarnishDataType::Symbol => { [INFO] [stdout] 268 + if this.get_symbol(left)? == sym { [INFO] [stdout] 269 + item = Some(right); [INFO] [stdout] 270 + } [INFO] [stdout] 271 + } [INFO] [stdout] 272 + _ => (), [INFO] [stdout] 273 + } [INFO] [stdout] 274 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> runtime/src/runtime/list.rs:269:49 [INFO] [stdout] | [INFO] [stdout] 269 | / ... if this.get_symbol(left)? == sym { [INFO] [stdout] 270 | | ... item = Some(right); [INFO] [stdout] 271 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 268 ~ GarnishDataType::Symbol [INFO] [stdout] 269 ~ if this.get_symbol(left)? == sym => { [INFO] [stdout] 270 | item = Some(right); [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:267:41 [INFO] [stdout] | [INFO] [stdout] 267 | / ... match this.get_data_type(left.clone())? { [INFO] [stdout] 268 | | ... GarnishDataType::Symbol => { [INFO] [stdout] 269 | | ... if this.get_symbol(left)? == sym { [INFO] [stdout] 270 | | ... item = Some(right); [INFO] [stdout] ... | [INFO] [stdout] 273 | | ... _ => (), [INFO] [stdout] 274 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 267 ~ if this.get_data_type(left.clone())? == GarnishDataType::Symbol { [INFO] [stdout] 268 + if this.get_symbol(left)? == sym { [INFO] [stdout] 269 + item = Some(right); [INFO] [stdout] 270 + } [INFO] [stdout] 271 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:1089:55 [INFO] [stdout] | [INFO] [stdout] 1089 | ... .append_token_details(&token))?; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 323 | / match this.get_data_type(addr.clone())? { [INFO] [stdout] 324 | | GarnishDataType::Pair => { [INFO] [stdout] 325 | | let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 326 | | match this.get_data_type(left.clone())? { [INFO] [stdout] ... | [INFO] [stdout] 335 | | _ => (), [INFO] [stdout] 336 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 323 ~ if this.get_data_type(addr.clone())? == GarnishDataType::Pair { [INFO] [stdout] 324 + let (left, right) = this.get_pair(addr)?; [INFO] [stdout] 325 + match this.get_data_type(left.clone())? { [INFO] [stdout] 326 + GarnishDataType::Symbol => { [INFO] [stdout] 327 + if this.get_symbol(left)? == sym { [INFO] [stdout] 328 + return Ok(Some(right)); [INFO] [stdout] 329 + } [INFO] [stdout] 330 + } [INFO] [stdout] 331 + _ => (), [INFO] [stdout] 332 + } [INFO] [stdout] 333 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> runtime/src/runtime/list.rs:328:21 [INFO] [stdout] | [INFO] [stdout] 328 | / if this.get_symbol(left)? == sym { [INFO] [stdout] 329 | | return Ok(Some(right)); [INFO] [stdout] 330 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 327 ~ GarnishDataType::Symbol [INFO] [stdout] 328 ~ if this.get_symbol(left)? == sym => { [INFO] [stdout] 329 | return Ok(Some(right)); [INFO] [stdout] 330 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/list.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | / match this.get_data_type(left.clone())? { [INFO] [stdout] 327 | | GarnishDataType::Symbol => { [INFO] [stdout] 328 | | if this.get_symbol(left)? == sym { [INFO] [stdout] 329 | | return Ok(Some(right)); [INFO] [stdout] ... | [INFO] [stdout] 332 | | _ => (), [INFO] [stdout] 333 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 326 ~ if this.get_data_type(left.clone())? == GarnishDataType::Symbol { [INFO] [stdout] 327 + if this.get_symbol(left)? == sym { [INFO] [stdout] 328 + return Ok(Some(right)); [INFO] [stdout] 329 + } [INFO] [stdout] 330 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:1160:65 [INFO] [stdout] | [INFO] [stdout] 1160 | ...mentation_error_with_token(format!("Current group set to non-existant group in stack."), token)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Current group set to non-existant group in stack.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:1173:101 [INFO] [stdout] | [INFO] [stdout] 1173 | setup_space_list_check(last_left, under_group, &mut nodes, &mut check_for_list, &mut &mut next_last_left)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut next_last_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> runtime/src/runtime/logical.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | let result = match (is_true_value(this, left)?, is_true_value(this, right)?) { [INFO] [stdout] | __________________^ [INFO] [stdout] 39 | | (false, false) | (true, true) => false, [INFO] [stdout] 40 | | _ => true, [INFO] [stdout] 41 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 38 - let result = match (is_true_value(this, left)?, is_true_value(this, right)?) { [INFO] [stdout] 39 - (false, false) | (true, true) => false, [INFO] [stdout] 40 - _ => true, [INFO] [stdout] 41 - }; [INFO] [stdout] 38 + let result = !matches!((is_true_value(this, left)?, is_true_value(this, right)?), (false, false) | (true, true)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> runtime/src/runtime/logical.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | Ok(match this.get_data_type(addr)? { [INFO] [stdout] | ________^ [INFO] [stdout] 66 | | GarnishDataType::False | GarnishDataType::Unit => false, [INFO] [stdout] 67 | | _ => true, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 65 - Ok(match this.get_data_type(addr)? { [INFO] [stdout] 66 - GarnishDataType::False | GarnishDataType::Unit => false, [INFO] [stdout] 67 - _ => true, [INFO] [stdout] 68 - }) [INFO] [stdout] 65 + Ok(!matches!(this.get_data_type(addr)?, GarnishDataType::False | GarnishDataType::Unit)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> compiler/src/parse/parser.rs:1227:13 [INFO] [stdout] | [INFO] [stdout] 1227 | / match definition { [INFO] [stdout] 1228 | | Definition::Identifier => match parent.and_then(|p| nodes.get(p)) { [INFO] [stdout] 1229 | | None => (), [INFO] [stdout] 1230 | | Some(p) => { [INFO] [stdout] ... | [INFO] [stdout] 1236 | | _ => (), [INFO] [stdout] 1237 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1227 ~ if definition == Definition::Identifier { match parent.and_then(|p| nodes.get(p)) { [INFO] [stdout] 1228 + None => (), [INFO] [stdout] 1229 + Some(p) => { [INFO] [stdout] 1230 + if p.definition == Definition::Access { [INFO] [stdout] 1231 + definition = Definition::Property; [INFO] [stdout] 1232 + } [INFO] [stdout] 1233 + } [INFO] [stdout] 1234 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> compiler/src/parse/parser.rs:1231:25 [INFO] [stdout] | [INFO] [stdout] 1231 | / if p.definition == Definition::Access { [INFO] [stdout] 1232 | | definition = Definition::Property; [INFO] [stdout] 1233 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1230 ~ Some(p) [INFO] [stdout] 1231 ~ if p.definition == Definition::Access => { [INFO] [stdout] 1232 | definition = Definition::Property; [INFO] [stdout] 1233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> compiler/src/parse/parser.rs:1247:27 [INFO] [stdout] | [INFO] [stdout] 1247 | None => match nodes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `nodes.get(0)` [INFO] [stdout] --> compiler/src/parse/parser.rs:1282:26 [INFO] [stdout] | [INFO] [stdout] 1282 | let mut node = match nodes.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `nodes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:1283:38 [INFO] [stdout] | [INFO] [stdout] 1283 | None => implementation_error(format!("No node regisistered in first slot."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No node regisistered in first slot.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/put.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | None => state_error(format!("No inputs available to update for update value operation."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No inputs available to update for update value operation.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:1306:34 [INFO] [stdout] | [INFO] [stdout] 1306 | implementation_error(format!("Max iterations reached when searching for root node."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Max iterations reached when searching for root node.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/resolve.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / match this.get_data_type(data.clone())? { [INFO] [stdout] 31 | | GarnishDataType::Symbol => { [INFO] [stdout] 32 | | match this.resolve(this.get_symbol(data)?)? { [INFO] [stdout] 33 | | true => return Ok(None), // context resolved end look up [INFO] [stdout] ... | [INFO] [stdout] 37 | | _ => (), // not a symbol push unit below [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ if this.get_data_type(data.clone())? == GarnishDataType::Symbol { [INFO] [stdout] 31 + match this.resolve(this.get_symbol(data)?)? { [INFO] [stdout] 32 + true => return Ok(None), // context resolved end look up [INFO] [stdout] 33 + false => (), // not resolved fall through [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> runtime/src/runtime/resolve.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / match this.resolve(this.get_symbol(data)?)? { [INFO] [stdout] 33 | | true => return Ok(None), // context resolved end look up [INFO] [stdout] 34 | | false => (), // not resolved fall through [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____________^ help: try: `if this.resolve(this.get_symbol(data)?)? == true { return Ok(None) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> runtime/src/runtime/utilities.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | None => state_error(format!("No references in register."))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No references in register.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/utilities.rs:14:71 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn next_two_raw_ref(this: &mut Data) -> Result<(Data::Size, Data::Size), RuntimeError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/utilities.rs:24:6 [INFO] [stdout] | [INFO] [stdout] 24 | ) -> Result<(Data::Number, Data::Number, Data::Number), RuntimeError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> runtime/src/runtime/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / impl Default for MockIterator { [INFO] [stdout] 76 | | fn default() -> Self { [INFO] [stdout] 77 | | MockIterator { current: 0, max: 0 } [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 60 ~ #[derive(Default)] [INFO] [stdout] 61 ~ pub struct MockIterator { [INFO] [stdout] 62 | current: i32, [INFO] [stdout] ... [INFO] [stdout] 75 | [INFO] [stdout] 76 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:242:28 [INFO] [stdout] | [INFO] [stdout] 242 | pub stub_get_pair: fn(&T, addr: i32) -> Result<(i32, i32), MockError>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | pub stub_get_concatenation: fn(&T, addr: i32) -> Result<(i32, i32), MockError>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:244:29 [INFO] [stdout] | [INFO] [stdout] 244 | pub stub_get_range: fn(&T, addr: i32) -> Result<(i32, i32), MockError>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:245:29 [INFO] [stdout] | [INFO] [stdout] 245 | pub stub_get_slice: fn(&T, addr: i32) -> Result<(i32, i32), MockError>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:246:31 [INFO] [stdout] | [INFO] [stdout] 246 | pub stub_get_partial: fn(&T, addr: i32) -> Result<(i32, i32), MockError>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:257:40 [INFO] [stdout] | [INFO] [stdout] 257 | pub stub_get_symbol_list_item: fn(&T, addr: i32, item_index: i32) -> Result>, MockError>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:289:35 [INFO] [stdout] | [INFO] [stdout] 289 | pub stub_get_instruction: fn(&T, addr: i32) -> Option<(Instruction, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> runtime/src/runtime/mod.rs:318:28 [INFO] [stdout] | [INFO] [stdout] 318 | ...p: fn(&mut T, operation: Instruction, left: (GarnishDataType, i32), right: (GarnishDataType, i32)) -> Result, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> runtime/src/runtime/mod.rs:399:21 [INFO] [stdout] | [INFO] [stdout] 399 | assert!(false, "Ran out of test register data."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> runtime/src/runtime/mod.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 416 | m.data = data; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `MockGarnishData:: { data: data, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> runtime/src/runtime/mod.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | let mut m = MockGarnishData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/clone.rs:14:35 [INFO] [stdout] | [INFO] [stdout] 14 | new_data.instruction_cursor = from.instruction_cursor.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from.instruction_cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `fn(&mut SimpleGarnishData, u64) -> Result` which implements the `Copy` trait [INFO] [stdout] --> data/src/clone.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | new_data.resolver = from.resolver.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from.resolver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `fn(&mut SimpleGarnishData, Instruction, (GarnishDataType, usize), (GarnishDataType, usize)) -> Result` which implements the `Copy` trait [INFO] [stdout] --> data/src/clone.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | new_data.op_handler = from.op_handler.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from.op_handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/data/display.rs:30:40 [INFO] [stdout] | [INFO] [stdout] 30 | SimpleData::CharList(s) => format!("{}", s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/data/display.rs:79:30 [INFO] [stdout] | [INFO] [stdout] 79 | false => format!("{}", bytes.iter().map(|b| b.to_string()).collect::>().join(" ")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `bytes.iter().map(|b| b.to_string()).collect::>().join(" ").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/data/display.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 86 | ... Some(s) => format!("{}", s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> data/src/data/display.rs:179:32 [INFO] [stdout] | [INFO] [stdout] 179 | return String::from(format!("Slice({}, {}..{})", list, start, end)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Slice({}, {}..{})", list, start, end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return Some(self.current_front - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Some(self.current_front - 1); [INFO] [stdout] 38 + Some(self.current_front - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Some(self.current_back); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Some(self.current_back); [INFO] [stdout] 49 + Some(self.current_back) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return Some(self.current_front.subtract(SimpleNumber::Integer(1)).unwrap_or(self.min)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Some(self.current_front.subtract(SimpleNumber::Integer(1)).unwrap_or(self.min)); [INFO] [stdout] 87 + Some(self.current_front.subtract(SimpleNumber::Integer(1)).unwrap_or(self.min)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Some(self.current_back); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Some(self.current_back); [INFO] [stdout] 98 + Some(self.current_back) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> data/src/data/number.rs:40:45 [INFO] [stdout] | [INFO] [stdout] 40 | SimpleNumber::Float(v) => Float(*v as f64), [INFO] [stdout] | ^^^^^^^^^ help: try: `(*v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> data/src/data/number.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | SimpleNumber::Integer(v) => Integer(*v as i32), [INFO] [stdout] | ^^^^^^^^^ help: try: `(*v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> data/src/data/parsing.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if input.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:112:39 [INFO] [stdout] | [INFO] [stdout] 112 | 'n' => bytes.push('\n' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:113:39 [INFO] [stdout] | [INFO] [stdout] 113 | 't' => bytes.push('\t' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:114:39 [INFO] [stdout] | [INFO] [stdout] 114 | 'r' => bytes.push('\r' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:115:39 [INFO] [stdout] | [INFO] [stdout] 115 | '0' => bytes.push('\0' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:116:40 [INFO] [stdout] | [INFO] [stdout] 116 | '\\' => bytes.push('\\' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:117:40 [INFO] [stdout] | [INFO] [stdout] 117 | '\'' => bytes.push('\'' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\''` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> data/src/data/parsing.rs:144:31 [INFO] [stdout] | [INFO] [stdout] 144 | } else if c == ' ' && current_number.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> data/src/data/parsing.rs:182:28 [INFO] [stdout] | [INFO] [stdout] 182 | if v < 2 || v > 36 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `!(2..=36).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SimpleDataList` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> data/src/data/mod.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> data/src/data/mod.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | / match self { [INFO] [stdout] 182 | | SimpleData::Unit => true, [INFO] [stdout] 183 | | _ => false, [INFO] [stdout] 184 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 181 - match self { [INFO] [stdout] 182 - SimpleData::Unit => true, [INFO] [stdout] 183 - _ => false, [INFO] [stdout] 184 - } [INFO] [stdout] 181 + matches!(self, SimpleData::Unit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> data/src/data/mod.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | / match self { [INFO] [stdout] 189 | | SimpleData::True => true, [INFO] [stdout] 190 | | _ => false, [INFO] [stdout] 191 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 188 - match self { [INFO] [stdout] 189 - SimpleData::True => true, [INFO] [stdout] 190 - _ => false, [INFO] [stdout] 191 - } [INFO] [stdout] 188 + matches!(self, SimpleData::True) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> data/src/data/mod.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | / match self { [INFO] [stdout] 196 | | SimpleData::False => true, [INFO] [stdout] 197 | | _ => false, [INFO] [stdout] 198 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 195 - match self { [INFO] [stdout] 196 - SimpleData::False => true, [INFO] [stdout] 197 - _ => false, [INFO] [stdout] 198 - } [INFO] [stdout] 195 + matches!(self, SimpleData::False) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> data/src/error.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / match self.backtrace.status() { [INFO] [stdout] 49 | | BacktraceStatus::Captured => write!(f, "\n{}", self.backtrace)?, [INFO] [stdout] 50 | | _ => {} [INFO] [stdout] 51 | | } [INFO] [stdout] | |_________^ help: try: `if self.backtrace.status() == BacktraceStatus::Captured { write!(f, "\n{}", self.backtrace)? }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> data/src/error.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | write!(f, " }}\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 52 - write!(f, " }}\n")?; [INFO] [stdout] 52 + writeln!(f, " }}")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/runtime.rs:22:41 [INFO] [stdout] | [INFO] [stdout] 22 | SimpleNumber::Integer(v) => match (v as u8).try_into() { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 23 | | Ok(c) => Some(c), [INFO] [stdout] 24 | | Err(_) => None, [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ help: replace with: `(v as u8).try_into().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> data/src/runtime.rs:22:57 [INFO] [stdout] | [INFO] [stdout] 22 | SimpleNumber::Integer(v) => match (v as u8).try_into() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u8` to `char` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 22 - SimpleNumber::Integer(v) => match (v as u8).try_into() { [INFO] [stdout] 22 + SimpleNumber::Integer(v) => match (v as u8).into() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/runtime.rs:32:41 [INFO] [stdout] | [INFO] [stdout] 32 | SimpleNumber::Integer(v) => match v.try_into() { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 33 | | Ok(b) => Some(b), [INFO] [stdout] 34 | | Err(_) => None, [INFO] [stdout] 35 | | }, [INFO] [stdout] | |_____________^ help: replace with: `v.try_into().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> data/src/runtime.rs:413:55 [INFO] [stdout] | [INFO] [stdout] 413 | self.data.push(SimpleData::SymbolList(list1.iter().chain(list2).map(|i| *i).collect())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `list1.iter().chain(list2).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> data/src/runtime.rs:521:9 [INFO] [stdout] | [INFO] [stdout] 521 | self.instructions.get(index).and_then(|i| Some((i.instruction, i.data))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.instructions.get(index).map(|i| (i.instruction, i.data))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> data/src/runtime.rs:563:31 [INFO] [stdout] | [INFO] [stdout] 563 | Some(data) => match data { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 564 | | SimpleData::StackFrame(frame) => return Ok(Some(frame.return_addr())), [INFO] [stdout] 565 | | _ => (), [INFO] [stdout] 566 | | }, [INFO] [stdout] | |_________________^ help: try: `if let SimpleData::StackFrame(frame) = data { return Ok(Some(frame.return_addr())) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> data/src/runtime.rs:695:12 [INFO] [stdout] | [INFO] [stdout] 695 | Ok(self.get_list_len(list_addr) [INFO] [stdout] | ____________^ [INFO] [stdout] 696 | | .and_then(|len| Ok(NumberIterator::new(SimpleNumber::Integer(0), SimpleDataFactory::size_to_number(len)))) [INFO] [stdout] | |______________________________________________________________________________________________________________________^ help: try: `self.get_list_len(list_addr).map(|len| NumberIterator::new(SimpleNumber::Integer(0), SimpleDataFactory::size_to_number(len)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> data/src/runtime.rs:701:12 [INFO] [stdout] | [INFO] [stdout] 701 | Ok(self.get_list_associations_len(list_addr) [INFO] [stdout] | ____________^ [INFO] [stdout] 702 | | .and_then(|len| Ok(NumberIterator::new(SimpleNumber::Integer(0), SimpleDataFactory::size_to_number(len)))) [INFO] [stdout] | |______________________________________________________________________________________________________________________^ help: try: `self.get_list_associations_len(list_addr).map(|len| NumberIterator::new(SimpleNumber::Integer(0), SimpleDataFactory::size_to_number(len)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SimpleGarnishData` [INFO] [stdout] --> data/src/simple.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | / pub fn new() -> Self { [INFO] [stdout] 88 | | SimpleGarnishData { [INFO] [stdout] 89 | | register: vec![], [INFO] [stdout] 90 | | data: SimpleDataList::default(), [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 86 + impl Default for SimpleGarnishData { [INFO] [stdout] 87 + fn default() -> Self { [INFO] [stdout] 88 + Self::new() [INFO] [stdout] 89 + } [INFO] [stdout] 90 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `data::SimpleData` [INFO] [stdout] --> data/src/simple.rs:209:36 [INFO] [stdout] | [INFO] [stdout] 209 | let i = self.cache_add(item.into())?; [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `data::SimpleData` [INFO] [stdout] --> data/src/simple.rs:220:36 [INFO] [stdout] | [INFO] [stdout] 220 | let i = self.cache_add(value.into())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:222:43 [INFO] [stdout] | [INFO] [stdout] 222 | list_index = self.add_to_list(list_index.clone(), pair)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `list_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `data::SimpleData` [INFO] [stdout] --> data/src/simple.rs:233:36 [INFO] [stdout] | [INFO] [stdout] 233 | let first = self.cache_add(first.into())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `first` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `data::SimpleData` [INFO] [stdout] --> data/src/simple.rs:234:37 [INFO] [stdout] | [INFO] [stdout] 234 | let second = self.cache_add(second.into())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `second` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> data/src/simple.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 305 | / self.values [INFO] [stdout] 306 | | .last() [INFO] [stdout] 307 | | .and_then(|l| Some(self.data.display_for_item(*l))) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 305 ~ self.values [INFO] [stdout] 306 + .last().map(|l| self.data.display_for_item(*l)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:319:36 [INFO] [stdout] | [INFO] [stdout] 319 | con_stack.push(right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:320:36 [INFO] [stdout] | [INFO] [stdout] 320 | con_stack.push(left.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:324:36 [INFO] [stdout] | [INFO] [stdout] 324 | items.push(item.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:347:67 [INFO] [stdout] | [INFO] [stdout] 347 | ... nested_con_stack.push(right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:348:67 [INFO] [stdout] | [INFO] [stdout] 348 | ... nested_con_stack.push(left.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/simple.rs:350:71 [INFO] [stdout] | [INFO] [stdout] 350 | ... _ => top_level_con_items.push(item.clone()), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/simple.rs:475:31 [INFO] [stdout] | [INFO] [stdout] 475 | strs.push(format!("{}", s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> data/src/simple.rs:608:25 [INFO] [stdout] | [INFO] [stdout] 608 | / iterate_concatenation_mut(self, value, |this, index, addr| { [INFO] [stdout] 609 | | let i = index.to_integer().as_integer()?; [INFO] [stdout] 610 | | if i >= start && i <= end { [INFO] [stdout] 611 | | this.add_to_current_char_list(addr, depth + 1)?; [INFO] [stdout] ... | [INFO] [stdout] 615 | | }) [INFO] [stdout] 616 | | .or_else(|err| Err(DataError::from(format!("{:?}", err))))?; [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 608 ~ iterate_concatenation_mut(self, value, |this, index, addr| { [INFO] [stdout] 609 + let i = index.to_integer().as_integer()?; [INFO] [stdout] 610 + if i >= start && i <= end { [INFO] [stdout] 611 + this.add_to_current_char_list(addr, depth + 1)?; [INFO] [stdout] 612 + } [INFO] [stdout] 613 + [INFO] [stdout] 614 + Ok(None) [INFO] [stdout] 615 ~ }).map_err(|err| DataError::from(format!("{:?}", err)))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> data/src/simple.rs:608:64 [INFO] [stdout] | [INFO] [stdout] 608 | iterate_concatenation_mut(self, value, |this, index, addr| { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 609 | | let i = index.to_integer().as_integer()?; [INFO] [stdout] 610 | | if i >= start && i <= end { [INFO] [stdout] 611 | | this.add_to_current_char_list(addr, depth + 1)?; [INFO] [stdout] ... | [INFO] [stdout] 614 | | Ok(None) [INFO] [stdout] 615 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `garnish_lang_traits::RuntimeError`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> data/src/basic/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod basic; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> data/src/basic/basic.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:134:104 [INFO] [stdout] | [INFO] [stdout] 134 | ... let item = self.lookup_in_data_slice(lookup_start, lookup_end, item.clone())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:138:104 [INFO] [stdout] | [INFO] [stdout] 138 | ... let item = self.lookup_in_data_slice(lookup_start, lookup_end, item.clone())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:139:92 [INFO] [stdout] | [INFO] [stdout] 139 | ... self.push_to_data_block(BasicData::AssociativeItem(symbol.clone(), item))?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:174:104 [INFO] [stdout] | [INFO] [stdout] 174 | ... let item = self.lookup_in_data_slice(lookup_start, lookup_end, item.clone())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:178:104 [INFO] [stdout] | [INFO] [stdout] 178 | ... let item = self.lookup_in_data_slice(lookup_start, lookup_end, item.clone())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:179:92 [INFO] [stdout] | [INFO] [stdout] 179 | ... self.push_to_data_block(BasicData::AssociativeItem(symbol.clone(), item))?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Instruction` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:215:84 [INFO] [stdout] | [INFO] [stdout] 215 | ... self.push_to_data_block(BasicData::InstructionWithData(instruction.clone(), data))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instruction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Instruction` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:217:111 [INFO] [stdout] | [INFO] [stdout] 217 | BasicData::Instruction(instruction) => self.push_to_data_block(BasicData::Instruction(instruction.clone()))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instruction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/clone.rs:287:26 [INFO] [stdout] | [INFO] [stdout] 287 | Some(new.clone()) [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/data.rs:168:44 [INFO] [stdout] | [INFO] [stdout] 168 | BasicData::SymbolList(s) => Ok(s.clone()), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | None => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - None => return None, [INFO] [stdout] 63 + None => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | Ok(self.get_from_data_block_ensure_index(list_index)?.as_char_list()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 192 - Ok(self.get_from_data_block_ensure_index(list_index)?.as_char_list()?) [INFO] [stdout] 192 + self.get_from_data_block_ensure_index(list_index)?.as_char_list() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | Ok(self.get_from_data_block_ensure_index(addr)?.as_byte_list()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 214 - Ok(self.get_from_data_block_ensure_index(addr)?.as_byte_list()?) [INFO] [stdout] 214 + self.get_from_data_block_ensure_index(addr)?.as_byte_list() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | Ok(self.get_from_data_block_ensure_index(addr)?.as_symbol_list()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 236 - Ok(self.get_from_data_block_ensure_index(addr)?.as_symbol_list()?) [INFO] [stdout] 236 + self.get_from_data_block_ensure_index(addr)?.as_symbol_list() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:250:62 [INFO] [stdout] | [INFO] [stdout] 250 | BasicData::Symbol(sym) => SymbolListPart::Symbol(sym.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*sym` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SimpleNumber` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:251:62 [INFO] [stdout] | [INFO] [stdout] 251 | BasicData::Number(num) => SymbolListPart::Number(num.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:273:25 [INFO] [stdout] | [INFO] [stdout] 273 | / return Err(DataError::new( [INFO] [stdout] 274 | | "Not a symbol list part", [INFO] [stdout] 275 | | DataErrorType::NotASymbolListPart(d.get_data_type()), [INFO] [stdout] 276 | | )); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 273 ~ Err(DataError::new( [INFO] [stdout] 274 + "Not a symbol list part", [INFO] [stdout] 275 + DataErrorType::NotASymbolListPart(d.get_data_type()), [INFO] [stdout] 276 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:270:73 [INFO] [stdout] | [INFO] [stdout] 270 | BasicData::Symbol(sym) => Ok(SymbolListPart::Symbol(sym.clone())), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*sym` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SimpleNumber` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:271:73 [INFO] [stdout] | [INFO] [stdout] 271 | BasicData::Number(num) => Ok(SymbolListPart::Number(num.clone())), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:309:32 [INFO] [stdout] | [INFO] [stdout] 309 | stack.push(right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:310:32 [INFO] [stdout] | [INFO] [stdout] 310 | stack.push(left.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:408:58 [INFO] [stdout] | [INFO] [stdout] 408 | DataErrorType::ExceededInitialListLength(len.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:412:19 [INFO] [stdout] | [INFO] [stdout] 412 | let len = len.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:419:9 [INFO] [stdout] | [INFO] [stdout] 419 | / if let BasicData::Pair(left, right) = self.get_from_data_block_ensure_index(item_index)? { [INFO] [stdout] 420 | | if let BasicData::Symbol(sym) = self.get_from_data_block_ensure_index(*left)? { [INFO] [stdout] 421 | | let paired_index = current_index + len; [INFO] [stdout] 422 | | let association_item = BasicData::::AssociativeItem(sym.clone(), right.clone()); [INFO] [stdout] ... | [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 419 ~ if let BasicData::Pair(left, right) = self.get_from_data_block_ensure_index(item_index)? [INFO] [stdout] 420 ~ && let BasicData::Symbol(sym) = self.get_from_data_block_ensure_index(*left)? { [INFO] [stdout] 421 | let paired_index = current_index + len; [INFO] [stdout] ... [INFO] [stdout] 424 | *item = association_item; [INFO] [stdout] 425 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:422:72 [INFO] [stdout] | [INFO] [stdout] 422 | let association_item = BasicData::::AssociativeItem(sym.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*sym` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:422:85 [INFO] [stdout] | [INFO] [stdout] 422 | let association_item = BasicData::::AssociativeItem(sym.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:436:56 [INFO] [stdout] | [INFO] [stdout] 436 | DataErrorType::NotFullyInitializedList(len.clone(), count.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:436:69 [INFO] [stdout] | [INFO] [stdout] 436 | DataErrorType::NotFullyInitializedList(len.clone(), count.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:440:19 [INFO] [stdout] | [INFO] [stdout] 440 | let len = len.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:518:9 [INFO] [stdout] | [INFO] [stdout] 518 | / match list.get(index).cloned() { [INFO] [stdout] 519 | | Some(value) => Some(value.clone()), [INFO] [stdout] 520 | | None => None, [INFO] [stdout] 521 | | } [INFO] [stdout] | |_________^ help: try: `list.get(index).cloned().map(|value| value.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:519:33 [INFO] [stdout] | [INFO] [stdout] 519 | Some(value) => Some(value.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:549:9 [INFO] [stdout] | [INFO] [stdout] 549 | / match self.get_from_instruction_block_ensure_index(addr) { [INFO] [stdout] 550 | | Ok(instruction) => Some(instruction), [INFO] [stdout] 551 | | Err(_) => None, [INFO] [stdout] 552 | | } [INFO] [stdout] | |_________^ help: replace with: `self.get_from_instruction_block_ensure_index(addr).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:578:9 [INFO] [stdout] | [INFO] [stdout] 578 | / match self.get_from_jump_table_block_ensure_index(index) { [INFO] [stdout] 579 | | Ok(point) => Some(point), [INFO] [stdout] 580 | | Err(_) => None, [INFO] [stdout] 581 | | } [INFO] [stdout] | |_________^ help: replace with: `self.get_from_jump_table_block_ensure_index(index).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/basic/garnish/garnish_impl.rs:585:9 [INFO] [stdout] | [INFO] [stdout] 585 | / match self.get_from_jump_table_block_ensure_index_mut(index) { [INFO] [stdout] 586 | | Ok(point) => Some(point), [INFO] [stdout] 587 | | Err(_) => None, [INFO] [stdout] 588 | | } [INFO] [stdout] | |_________^ help: replace with: `self.get_from_jump_table_block_ensure_index_mut(index).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/basic/garnish/factory.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | BasicNumber::Integer(v) => match (v as u8).try_into() { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 19 | | Ok(c) => Some(c), [INFO] [stdout] 20 | | Err(_) => None, [INFO] [stdout] 21 | | }, [INFO] [stdout] | |_____________^ help: replace with: `(v as u8).try_into().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> data/src/basic/garnish/factory.rs:18:56 [INFO] [stdout] | [INFO] [stdout] 18 | BasicNumber::Integer(v) => match (v as u8).try_into() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u8` to `char` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 18 - BasicNumber::Integer(v) => match (v as u8).try_into() { [INFO] [stdout] 18 + BasicNumber::Integer(v) => match (v as u8).into() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> data/src/basic/garnish/factory.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | BasicNumber::Integer(v) => match v.try_into() { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 29 | | Ok(b) => Some(b), [INFO] [stdout] 30 | | Err(_) => None, [INFO] [stdout] 31 | | }, [INFO] [stdout] | |_____________^ help: replace with: `v.try_into().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/bytes.rs:14:49 [INFO] [stdout] | [INFO] [stdout] 14 | BasicData::Char(value) => u32::from(value.clone()).to_le_bytes().to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> data/src/basic/garnish/conversions/bytes.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|c| c.as_char().map(|c| u32::from(c).to_le_bytes().to_vec()).unwrap_or(vec![])) [INFO] [stdout] | ______________________^ [INFO] [stdout] 30 | | .flatten() [INFO] [stdout] | |______________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|c| c.as_char().map(|c| u32::from(c).to_le_bytes().to_vec()).unwrap_or(vec![]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> data/src/basic/garnish/conversions/bytes.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 38 | .map(|c| match c { [INFO] [stdout] | ______________________^ [INFO] [stdout] 39 | | BasicData::Symbol(value) => value.to_le_bytes().to_vec(), [INFO] [stdout] 40 | | BasicData::Number(value) => match value { [INFO] [stdout] 41 | | BasicNumber::Integer(value) => value.to_le_bytes().to_vec(), [INFO] [stdout] ... | [INFO] [stdout] 45 | | }) [INFO] [stdout] 46 | | .flatten() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 38 ~ .flat_map(|c| match c { [INFO] [stdout] 39 + BasicData::Symbol(value) => value.to_le_bytes().to_vec(), [INFO] [stdout] 40 + BasicData::Number(value) => match value { [INFO] [stdout] 41 + BasicNumber::Integer(value) => value.to_le_bytes().to_vec(), [INFO] [stdout] 42 + BasicNumber::Float(value) => value.to_le_bytes().to_vec(), [INFO] [stdout] 43 + }, [INFO] [stdout] 44 + _ => vec![], [INFO] [stdout] 45 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / Ok(match delegate.get_data_at(from)? { [INFO] [stdout] 139 | | BasicData::Unit => { [INFO] [stdout] 140 | | delegate.push_char('(')?; [INFO] [stdout] 141 | | delegate.push_char(')')?; [INFO] [stdout] ... | [INFO] [stdout] 375 | | | BasicData::CloneIndexMap(_, _) => {} [INFO] [stdout] 376 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 138 ~ let _: () = match delegate.get_data_at(from)? { [INFO] [stdout] 139 + BasicData::Unit => { [INFO] [stdout] 140 + delegate.push_char('(')?; [INFO] [stdout] 141 + delegate.push_char(')')?; [INFO] [stdout] 142 + } [INFO] [stdout] 143 + BasicData::True => { [INFO] [stdout] 144 + delegate.push_char('T')?; [INFO] [stdout] 145 + delegate.push_char('r')?; [INFO] [stdout] 146 + delegate.push_char('u')?; [INFO] [stdout] 147 + delegate.push_char('e')?; [INFO] [stdout] 148 + } [INFO] [stdout] 149 + BasicData::False => { [INFO] [stdout] 150 + delegate.push_char('F')?; [INFO] [stdout] 151 + delegate.push_char('a')?; [INFO] [stdout] 152 + delegate.push_char('l')?; [INFO] [stdout] 153 + delegate.push_char('s')?; [INFO] [stdout] 154 + delegate.push_char('e')?; [INFO] [stdout] 155 + } [INFO] [stdout] 156 + BasicData::Type(garnish_data_type) => { [INFO] [stdout] 157 + let s = format!("{}", garnish_data_type); [INFO] [stdout] 158 + for c in s.chars() { [INFO] [stdout] 159 + delegate.push_char(c)?; [INFO] [stdout] 160 + } [INFO] [stdout] 161 + } [INFO] [stdout] 162 + BasicData::Number(simple_number) => { [INFO] [stdout] 163 + let s = simple_number.to_string(); [INFO] [stdout] 164 + for c in s.chars() { [INFO] [stdout] 165 + delegate.push_char(c)?; [INFO] [stdout] 166 + } [INFO] [stdout] 167 + } [INFO] [stdout] 168 + BasicData::Char(c) => { [INFO] [stdout] 169 + delegate.push_char(c.clone())?; [INFO] [stdout] 170 + } [INFO] [stdout] 171 + BasicData::Byte(b) => { [INFO] [stdout] 172 + let s = b.to_string(); [INFO] [stdout] 173 + for c in s.chars() { [INFO] [stdout] 174 + delegate.push_char(c)?; [INFO] [stdout] 175 + } [INFO] [stdout] 176 + } [INFO] [stdout] 177 + BasicData::Symbol(sym) => { [INFO] [stdout] 178 + match delegate.data().get_symbol_string(sym.clone())? { [INFO] [stdout] 179 + Some(s) => { [INFO] [stdout] 180 + delegate.push_char(':')?; [INFO] [stdout] 181 + for c in s.chars() { [INFO] [stdout] 182 + delegate.push_char(c)?; [INFO] [stdout] 183 + } [INFO] [stdout] 184 + return Ok(()); [INFO] [stdout] 185 + } [INFO] [stdout] 186 + None => { [INFO] [stdout] 187 + let s = format!("[Symbol {}]", sym.to_string()); [INFO] [stdout] 188 + for c in s.chars() { [INFO] [stdout] 189 + delegate.push_char(c)?; [INFO] [stdout] 190 + } [INFO] [stdout] 191 + return Ok(()); [INFO] [stdout] 192 + } [INFO] [stdout] 193 + }; [INFO] [stdout] 194 + } [INFO] [stdout] 195 + BasicData::SymbolList(length) => { [INFO] [stdout] 196 + let length = length.clone(); [INFO] [stdout] 197 + let end = from + 1 + length; [INFO] [stdout] 198 + let range = from + 1..end; [INFO] [stdout] 199 + [INFO] [stdout] 200 + if depth > 0 { [INFO] [stdout] 201 + delegate.push_char('(')?; [INFO] [stdout] 202 + } [INFO] [stdout] 203 + [INFO] [stdout] 204 + for i in range { [INFO] [stdout] 205 + convert_with_delegate(delegate, i, depth + 1)?; [INFO] [stdout] 206 + [INFO] [stdout] 207 + if i < end - 1 { [INFO] [stdout] 208 + delegate.push_char(' ')?; [INFO] [stdout] 209 + } [INFO] [stdout] 210 + } [INFO] [stdout] 211 + [INFO] [stdout] 212 + if depth > 0 { [INFO] [stdout] 213 + delegate.push_char(')')?; [INFO] [stdout] 214 + } [INFO] [stdout] 215 + } [INFO] [stdout] 216 + BasicData::Expression(jump_table_index) => { [INFO] [stdout] 217 + let s = format!("[Expression {}]", jump_table_index); [INFO] [stdout] 218 + for c in s.chars() { [INFO] [stdout] 219 + delegate.push_char(c)?; [INFO] [stdout] 220 + } [INFO] [stdout] 221 + } [INFO] [stdout] 222 + BasicData::External(value) => { [INFO] [stdout] 223 + let s = format!("[External {}]", value); [INFO] [stdout] 224 + for c in s.chars() { [INFO] [stdout] 225 + delegate.push_char(c)?; [INFO] [stdout] 226 + } [INFO] [stdout] 227 + } [INFO] [stdout] 228 + BasicData::ByteList(length) => { [INFO] [stdout] 229 + let length = length.clone(); [INFO] [stdout] 230 + let end = from + 1 + length; [INFO] [stdout] 231 + let range = from + 1..end; [INFO] [stdout] 232 + [INFO] [stdout] 233 + if depth > 0 { [INFO] [stdout] 234 + delegate.push_char('(')?; [INFO] [stdout] 235 + } [INFO] [stdout] 236 + [INFO] [stdout] 237 + for i in range { [INFO] [stdout] 238 + convert_with_delegate(delegate, i, depth + 1)?; [INFO] [stdout] 239 + [INFO] [stdout] 240 + if i < end - 1 { [INFO] [stdout] 241 + delegate.push_char(' ')?; [INFO] [stdout] 242 + } [INFO] [stdout] 243 + } [INFO] [stdout] 244 + [INFO] [stdout] 245 + if depth > 0 { [INFO] [stdout] 246 + delegate.push_char(')')?; [INFO] [stdout] 247 + } [INFO] [stdout] 248 + } [INFO] [stdout] 249 + BasicData::CharList(length) => { [INFO] [stdout] 250 + let start = from + 1; [INFO] [stdout] 251 + let length = length.clone(); [INFO] [stdout] 252 + for i in start..start + length { [INFO] [stdout] 253 + let c = delegate.get_data_at(i)?.as_char()?; [INFO] [stdout] 254 + delegate.push_char(c)?; [INFO] [stdout] 255 + } [INFO] [stdout] 256 + } [INFO] [stdout] 257 + BasicData::Pair(left, right) => { [INFO] [stdout] 258 + let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] 259 + [INFO] [stdout] 260 + if depth > 0 { [INFO] [stdout] 261 + delegate.push_char('(')?; [INFO] [stdout] 262 + } [INFO] [stdout] 263 + [INFO] [stdout] 264 + convert_with_delegate(delegate, left, depth + 1)?; [INFO] [stdout] 265 + [INFO] [stdout] 266 + delegate.push_char(' ')?; [INFO] [stdout] 267 + delegate.push_char('=')?; [INFO] [stdout] 268 + delegate.push_char(' ')?; [INFO] [stdout] 269 + [INFO] [stdout] 270 + convert_with_delegate(delegate, right, depth + 1)?; [INFO] [stdout] 271 + [INFO] [stdout] 272 + if depth > 0 { [INFO] [stdout] 273 + delegate.push_char(')')?; [INFO] [stdout] 274 + } [INFO] [stdout] 275 + } [INFO] [stdout] 276 + BasicData::Range(start, end) => { [INFO] [stdout] 277 + let (start, end) = (start.clone(), end.clone()); [INFO] [stdout] 278 + convert_with_delegate(delegate, start, depth + 1)?; [INFO] [stdout] 279 + delegate.push_char('.')?; [INFO] [stdout] 280 + delegate.push_char('.')?; [INFO] [stdout] 281 + convert_with_delegate(delegate, end, depth + 1)?; [INFO] [stdout] 282 + } [INFO] [stdout] 283 + BasicData::Slice(list, range) => { [INFO] [stdout] 284 + let (list, range) = (list.clone(), range.clone()); [INFO] [stdout] 285 + [INFO] [stdout] 286 + if depth > 0 { [INFO] [stdout] 287 + delegate.push_char('(')?; [INFO] [stdout] 288 + } [INFO] [stdout] 289 + [INFO] [stdout] 290 + convert_with_delegate(delegate, list, depth + 1)?; [INFO] [stdout] 291 + delegate.push_char(' ')?; [INFO] [stdout] 292 + delegate.push_char('~')?; [INFO] [stdout] 293 + delegate.push_char(' ')?; [INFO] [stdout] 294 + convert_with_delegate(delegate, range, depth + 1)?; [INFO] [stdout] 295 + [INFO] [stdout] 296 + if depth > 0 { [INFO] [stdout] 297 + delegate.push_char(')')?; [INFO] [stdout] 298 + } [INFO] [stdout] 299 + } [INFO] [stdout] 300 + BasicData::Partial(reciever, input) => { [INFO] [stdout] 301 + let (reciever, input) = (reciever.clone(), input.clone()); [INFO] [stdout] 302 + [INFO] [stdout] 303 + if depth > 0 { [INFO] [stdout] 304 + delegate.push_char('(')?; [INFO] [stdout] 305 + } [INFO] [stdout] 306 + [INFO] [stdout] 307 + convert_with_delegate(delegate, reciever, depth + 1)?; [INFO] [stdout] 308 + delegate.push_char(' ')?; [INFO] [stdout] 309 + delegate.push_char('~')?; [INFO] [stdout] 310 + delegate.push_char(' ')?; [INFO] [stdout] 311 + convert_with_delegate(delegate, input, depth + 1)?; [INFO] [stdout] 312 + [INFO] [stdout] 313 + if depth > 0 { [INFO] [stdout] 314 + delegate.push_char(')')?; [INFO] [stdout] 315 + } [INFO] [stdout] 316 + } [INFO] [stdout] 317 + BasicData::List(length, _) => { [INFO] [stdout] 318 + let end = from + 1 + length; [INFO] [stdout] 319 + let range = from + 1..end; [INFO] [stdout] 320 + [INFO] [stdout] 321 + if depth > 0 { [INFO] [stdout] 322 + delegate.push_char('(')?; [INFO] [stdout] 323 + } [INFO] [stdout] 324 + [INFO] [stdout] 325 + for i in range { [INFO] [stdout] 326 + let true_index = delegate.data().get_from_data_block_ensure_index(i)?.as_list_item()?; [INFO] [stdout] 327 + convert_with_delegate(delegate, true_index, depth + 1)?; [INFO] [stdout] 328 + [INFO] [stdout] 329 + if i < end - 1 { [INFO] [stdout] 330 + delegate.push_char(' ')?; [INFO] [stdout] 331 + } [INFO] [stdout] 332 + } [INFO] [stdout] 333 + [INFO] [stdout] 334 + if depth > 0 { [INFO] [stdout] 335 + delegate.push_char(')')?; [INFO] [stdout] 336 + } [INFO] [stdout] 337 + } [INFO] [stdout] 338 + BasicData::Concatenation(left, right) => { [INFO] [stdout] 339 + let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] 340 + [INFO] [stdout] 341 + if depth > 0 { [INFO] [stdout] 342 + delegate.push_char('(')?; [INFO] [stdout] 343 + } [INFO] [stdout] 344 + [INFO] [stdout] 345 + convert_with_delegate(delegate, left, depth + 1)?; [INFO] [stdout] 346 + delegate.push_char(' ')?; [INFO] [stdout] 347 + delegate.push_char('<')?; [INFO] [stdout] 348 + delegate.push_char('>')?; [INFO] [stdout] 349 + delegate.push_char(' ')?; [INFO] [stdout] 350 + convert_with_delegate(delegate, right, depth + 1)?; [INFO] [stdout] 351 + [INFO] [stdout] 352 + if depth > 0 { [INFO] [stdout] 353 + delegate.push_char(')')?; [INFO] [stdout] 354 + } [INFO] [stdout] 355 + } [INFO] [stdout] 356 + BasicData::Custom(value) => { [INFO] [stdout] 357 + T::convert_custom_data_with_delegate::(delegate, value.clone())?; [INFO] [stdout] 358 + } [INFO] [stdout] 359 + BasicData::Empty [INFO] [stdout] 360 + | BasicData::UninitializedList(_, _) [INFO] [stdout] 361 + | BasicData::ListItem(_) [INFO] [stdout] 362 + | BasicData::AssociativeItem(_, _) [INFO] [stdout] 363 + | BasicData::Value(_, _) [INFO] [stdout] 364 + | BasicData::ValueRoot(_) [INFO] [stdout] 365 + | BasicData::Register(_, _) [INFO] [stdout] 366 + | BasicData::RegisterRoot(_) [INFO] [stdout] 367 + | BasicData::JumpPoint(_) [INFO] [stdout] 368 + | BasicData::InstructionWithData(_, _) [INFO] [stdout] 369 + | BasicData::Instruction(_) [INFO] [stdout] 370 + | BasicData::Frame(_, _) [INFO] [stdout] 371 + | BasicData::FrameIndex(_) [INFO] [stdout] 372 + | BasicData::FrameRegister(_) [INFO] [stdout] 373 + | BasicData::FrameRoot [INFO] [stdout] 374 + | BasicData::CloneItem(_) [INFO] [stdout] 375 + | BasicData::CloneIndexMap(_, _) => {} [INFO] [stdout] 376 + }; [INFO] [stdout] 377 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:169:32 [INFO] [stdout] | [INFO] [stdout] 169 | delegate.push_char(c.clone())?; [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:178:53 [INFO] [stdout] | [INFO] [stdout] 178 | match delegate.data().get_symbol_string(sym.clone())? { [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*sym` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:187:55 [INFO] [stdout] | [INFO] [stdout] 187 | let s = format!("[Symbol {}]", sym.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:196:26 [INFO] [stdout] | [INFO] [stdout] 196 | let length = length.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:229:26 [INFO] [stdout] | [INFO] [stdout] 229 | let length = length.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:251:26 [INFO] [stdout] | [INFO] [stdout] 251 | let length = length.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:258:34 [INFO] [stdout] | [INFO] [stdout] 258 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:258:48 [INFO] [stdout] | [INFO] [stdout] 258 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:277:33 [INFO] [stdout] | [INFO] [stdout] 277 | let (start, end) = (start.clone(), end.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:277:48 [INFO] [stdout] | [INFO] [stdout] 277 | let (start, end) = (start.clone(), end.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:284:34 [INFO] [stdout] | [INFO] [stdout] 284 | let (list, range) = (list.clone(), range.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:284:48 [INFO] [stdout] | [INFO] [stdout] 284 | let (list, range) = (list.clone(), range.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:301:38 [INFO] [stdout] | [INFO] [stdout] 301 | let (reciever, input) = (reciever.clone(), input.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*reciever` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:301:56 [INFO] [stdout] | [INFO] [stdout] 301 | let (reciever, input) = (reciever.clone(), input.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:339:34 [INFO] [stdout] | [INFO] [stdout] 339 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/string.rs:339:48 [INFO] [stdout] | [INFO] [stdout] 339 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SimpleNumber` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/number.rs:10:47 [INFO] [stdout] | [INFO] [stdout] 10 | BasicData::Number(number) => Some(number.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> data/src/basic/garnish/conversions/number.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | / match value.to_digit(10) { [INFO] [stdout] 13 | | Some(value) => Some(BasicNumber::Integer(value as i32)), [INFO] [stdout] 14 | | None => None, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_________________^ help: try: `value.to_digit(10).map(|value| BasicNumber::Integer(value as i32))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/garnish/conversions/number.rs:17:65 [INFO] [stdout] | [INFO] [stdout] 17 | BasicData::Byte(value) => Some(BasicNumber::Integer(value.clone() as i32)), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> data/src/basic/internal.rs:89:39 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn push_to_block(heap: &mut Vec>, block: &mut StorageBlock, data: BasicData) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 89 - pub(crate) fn push_to_block(heap: &mut Vec>, block: &mut StorageBlock, data: BasicData) -> usize { [INFO] [stdout] 89 + pub(crate) fn push_to_block(heap: &mut [BasicData], block: &mut StorageBlock, data: BasicData) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> data/src/basic/internal.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | / for i in 0..instruction_cursor { [INFO] [stdout] 163 | | new_heap[current_block_start + i] = self.data()[instruction_start + i].clone(); [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `new_heap[current_block_start..(instruction_cursor + current_block_start)].clone_from_slice(&self.data()[instruction_start..(instruction_cursor + instruction_start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> data/src/basic/internal.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | / for i in 0..jump_table_cursor { [INFO] [stdout] 171 | | new_heap[current_block_start + i] = self.data()[jump_table_start + i].clone(); [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `new_heap[current_block_start..(jump_table_cursor + current_block_start)].clone_from_slice(&self.data()[jump_table_start..(jump_table_cursor + jump_table_start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> data/src/basic/internal.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / for i in 0..symbol_table_cursor { [INFO] [stdout] 179 | | new_heap[current_block_start + i] = self.data()[symbol_table_start + i].clone(); [INFO] [stdout] 180 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `new_heap[current_block_start..(symbol_table_cursor + current_block_start)].clone_from_slice(&self.data()[symbol_table_start..(symbol_table_cursor + symbol_table_start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> data/src/basic/internal.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | / for i in 0..expression_symbol_cursor { [INFO] [stdout] 187 | | new_heap[current_block_start + i] = self.data()[expression_symbol_start + i].clone(); [INFO] [stdout] 188 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `new_heap[current_block_start..(expression_symbol_cursor + current_block_start)].clone_from_slice(&self.data()[expression_symbol_start..(expression_symbol_cursor + expression_symbol_start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> data/src/basic/internal.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | / for i in 0..data_cursor { [INFO] [stdout] 195 | | new_heap[current_block_start + i] = self.data()[data_start + i].clone(); [INFO] [stdout] 196 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `new_heap[current_block_start..(data_cursor + current_block_start)].clone_from_slice(&self.data()[data_start..(data_cursor + data_start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> data/src/basic/internal.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | / for i in 0..custom_data_cursor { [INFO] [stdout] 203 | | new_heap[current_block_start + i] = self.data()[custom_data_start + i].clone(); [INFO] [stdout] 204 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `new_heap[current_block_start..(custom_data_cursor + current_block_start)].clone_from_slice(&self.data()[custom_data_start..(custom_data_cursor + custom_data_start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 66 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:66:56 [INFO] [stdout] | [INFO] [stdout] 66 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:71:42 [INFO] [stdout] | [INFO] [stdout] 71 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:71:56 [INFO] [stdout] | [INFO] [stdout] 71 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:76:42 [INFO] [stdout] | [INFO] [stdout] 76 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:76:56 [INFO] [stdout] | [INFO] [stdout] 76 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:81:42 [INFO] [stdout] | [INFO] [stdout] 81 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:81:56 [INFO] [stdout] | [INFO] [stdout] 81 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:86:42 [INFO] [stdout] | [INFO] [stdout] 86 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:86:56 [INFO] [stdout] | [INFO] [stdout] 86 | let (left, right) = (left.clone(), right.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:111:78 [INFO] [stdout] | [INFO] [stdout] 111 | ... self.push_to_data_block(BasicData::CloneItem(item.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:126:46 [INFO] [stdout] | [INFO] [stdout] 126 | let (previous, value) = (previous.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*previous` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:126:64 [INFO] [stdout] | [INFO] [stdout] 126 | let (previous, value) = (previous.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:131:33 [INFO] [stdout] | [INFO] [stdout] 131 | let value = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:135:46 [INFO] [stdout] | [INFO] [stdout] 135 | let (previous, value) = (previous.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*previous` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:135:64 [INFO] [stdout] | [INFO] [stdout] 135 | let (previous, value) = (previous.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:140:33 [INFO] [stdout] | [INFO] [stdout] 140 | let value = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:144:66 [INFO] [stdout] | [INFO] [stdout] 144 | self.push_to_data_block(BasicData::CloneItem(data.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:149:49 [INFO] [stdout] | [INFO] [stdout] 149 | let (previous, register) = (previous.clone(), register.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*previous` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:149:67 [INFO] [stdout] | [INFO] [stdout] 149 | let (previous, register) = (previous.clone(), register.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*register` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:154:36 [INFO] [stdout] | [INFO] [stdout] 154 | let previous = previous.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*previous` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/basic/ordering.rs:158:36 [INFO] [stdout] | [INFO] [stdout] 158 | let register = register.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*register` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> data/src/basic/storage.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / impl Default for StorageBlock { [INFO] [stdout] 10 | | fn default() -> Self { [INFO] [stdout] 11 | | Self { cursor: 0, size: 0, start: 0, settings: StorageSettings::default() } [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct StorageBlock { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> data/src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 24 | let hv = h.finish(); [INFO] [stdout] | -------------------- unnecessary `let` binding [INFO] [stdout] 25 | [INFO] [stdout] 26 | hv [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 24 ~ [INFO] [stdout] 25 | [INFO] [stdout] 26 ~ h.finish() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking garnish_lang v0.0.25-alpha (/opt/rustwide/workdir/garnish) [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> compiler/src/build/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod build; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/build/build.rs:226:65 [INFO] [stdout] | [INFO] [stdout] 226 | Some(Some(node)) if node.contributes_to_list => match node.list_parent { [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 227 | | Some((parent, _)) => { [INFO] [stdout] 228 | | node.contributes_to_list = false; [INFO] [stdout] ... | [INFO] [stdout] 233 | | None => {} [INFO] [stdout] 234 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 226 ~ Some(Some(node)) if node.contributes_to_list => if let Some((parent, _)) = node.list_parent { [INFO] [stdout] 227 + node.contributes_to_list = false; [INFO] [stdout] 228 + [INFO] [stdout] 229 + let parent_node = nodes.get_mut_or_error(parent)?; [INFO] [stdout] 230 + parent_node.child_count.next(); [INFO] [stdout] 231 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:262:1 [INFO] [stdout] | [INFO] [stdout] 262 | / fn handle_parse_node( [INFO] [stdout] 263 | | data: &mut Data, [INFO] [stdout] 264 | | mut nodes: &mut Vec>>, [INFO] [stdout] 265 | | mut instruction_metadata: &mut Vec, [INFO] [stdout] ... | [INFO] [stdout] 270 | | parse_node: &ParseNode, [INFO] [stdout] 271 | | ) -> Result<(), CompilerError<::Error>> { [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:273:79 [INFO] [stdout] | [INFO] [stdout] 273 | ... Definition::Unit => handle_value_primitive(|data, _| data.add_unit(), &mut nodes, node_index, &mut stack, parse_node, data, &... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:273:103 [INFO] [stdout] | [INFO] [stdout] 273 | ..._| data.add_unit(), &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:273:133 [INFO] [stdout] | [INFO] [stdout] 273 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:274:81 [INFO] [stdout] | [INFO] [stdout] 274 | ... Definition::False => handle_value_primitive(|data, _| data.add_false(), &mut nodes, node_index, &mut stack, parse_node, data,... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:274:105 [INFO] [stdout] | [INFO] [stdout] 274 | ...| data.add_false(), &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:274:135 [INFO] [stdout] | [INFO] [stdout] 274 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:275:79 [INFO] [stdout] | [INFO] [stdout] 275 | ... Definition::True => handle_value_primitive(|data, _| data.add_true(), &mut nodes, node_index, &mut stack, parse_node, data, &... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:275:103 [INFO] [stdout] | [INFO] [stdout] 275 | ..._| data.add_true(), &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:275:133 [INFO] [stdout] | [INFO] [stdout] 275 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 280 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 283 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:305:13 [INFO] [stdout] | [INFO] [stdout] 305 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 310 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:312:88 [INFO] [stdout] | [INFO] [stdout] 312 | ... Definition::Value => handle_value_like(|_, _| Ok(None), Instruction::PutValue, &mut nodes, node_index, &mut stack, parse_node... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:312:112 [INFO] [stdout] | [INFO] [stdout] 312 | ...truction::PutValue, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:312:142 [INFO] [stdout] | [INFO] [stdout] 312 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 318 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:343:86 [INFO] [stdout] | [INFO] [stdout] 343 | ... Definition::AbsoluteValue => handle_unary_prefix(Instruction::AbsoluteValue, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:343:110 [INFO] [stdout] | [INFO] [stdout] 343 | ...ion::AbsoluteValue, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:343:140 [INFO] [stdout] | [INFO] [stdout] 343 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:344:76 [INFO] [stdout] | [INFO] [stdout] 344 | ... Definition::Opposite => handle_unary_prefix(Instruction::Opposite, &mut nodes, node_index, &mut stack, parse_node, data, &mut... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:344:100 [INFO] [stdout] | [INFO] [stdout] 344 | ...truction::Opposite, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:344:130 [INFO] [stdout] | [INFO] [stdout] 344 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:345:80 [INFO] [stdout] | [INFO] [stdout] 345 | ... Definition::BitwiseNot => handle_unary_prefix(Instruction::BitwiseNot, &mut nodes, node_index, &mut stack, parse_node, data, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:345:104 [INFO] [stdout] | [INFO] [stdout] 345 | ...uction::BitwiseNot, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:345:134 [INFO] [stdout] | [INFO] [stdout] 345 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:346:66 [INFO] [stdout] | [INFO] [stdout] 346 | ... Definition::Not => handle_unary_prefix(Instruction::Not, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:346:90 [INFO] [stdout] | [INFO] [stdout] 346 | ... Definition::Not => handle_unary_prefix(Instruction::Not, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:346:120 [INFO] [stdout] | [INFO] [stdout] 346 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:347:66 [INFO] [stdout] | [INFO] [stdout] 347 | ... Definition::Tis => handle_unary_prefix(Instruction::Tis, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:347:90 [INFO] [stdout] | [INFO] [stdout] 347 | ... Definition::Tis => handle_unary_prefix(Instruction::Tis, &mut nodes, node_index, &mut stack, parse_node, data, &mut instructi... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:347:120 [INFO] [stdout] | [INFO] [stdout] 347 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:348:72 [INFO] [stdout] | [INFO] [stdout] 348 | ... Definition::TypeOf => handle_unary_prefix(Instruction::TypeOf, &mut nodes, node_index, &mut stack, parse_node, data, &mut ins... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:348:96 [INFO] [stdout] | [INFO] [stdout] 348 | ...nstruction::TypeOf, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:348:126 [INFO] [stdout] | [INFO] [stdout] 348 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:349:96 [INFO] [stdout] | [INFO] [stdout] 349 | ...ary_prefix(Instruction::AccessLeftInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:349:120 [INFO] [stdout] | [INFO] [stdout] 349 | ...AccessLeftInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:349:150 [INFO] [stdout] | [INFO] [stdout] 349 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:350:80 [INFO] [stdout] | [INFO] [stdout] 350 | ... Definition::EmptyApply => handle_unary_suffix(Instruction::EmptyApply, &mut nodes, node_index, &mut stack, parse_node, data, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:350:104 [INFO] [stdout] | [INFO] [stdout] 350 | ...uction::EmptyApply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:350:134 [INFO] [stdout] | [INFO] [stdout] 350 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:351:98 [INFO] [stdout] | [INFO] [stdout] 351 | ...ry_suffix(Instruction::AccessRightInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:351:122 [INFO] [stdout] | [INFO] [stdout] 351 | ...ccessRightInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:351:152 [INFO] [stdout] | [INFO] [stdout] 351 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:352:100 [INFO] [stdout] | [INFO] [stdout] 352 | ...y_suffix(Instruction::AccessLengthInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:352:124 [INFO] [stdout] | [INFO] [stdout] 352 | ...cessLengthInternal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:352:154 [INFO] [stdout] | [INFO] [stdout] 352 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:353:75 [INFO] [stdout] | [INFO] [stdout] 353 | ... Definition::Addition => handle_binary_operation(Instruction::Add, &mut nodes, node_index, &mut stack, parse_node, data, &mut ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:353:99 [INFO] [stdout] | [INFO] [stdout] 353 | ...n(Instruction::Add, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:353:129 [INFO] [stdout] | [INFO] [stdout] 353 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:354:83 [INFO] [stdout] | [INFO] [stdout] 354 | ... Definition::Subtraction => handle_binary_operation(Instruction::Subtract, &mut nodes, node_index, &mut stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:354:107 [INFO] [stdout] | [INFO] [stdout] 354 | ...truction::Subtract, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:354:137 [INFO] [stdout] | [INFO] [stdout] 354 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:355:90 [INFO] [stdout] | [INFO] [stdout] 355 | ... Definition::MultiplicationSign => handle_binary_operation(Instruction::Multiply, &mut nodes, node_index, &mut stack, parse_no... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:355:114 [INFO] [stdout] | [INFO] [stdout] 355 | ...truction::Multiply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:355:144 [INFO] [stdout] | [INFO] [stdout] 355 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:356:78 [INFO] [stdout] | [INFO] [stdout] 356 | ... Definition::Division => handle_binary_operation(Instruction::Divide, &mut nodes, node_index, &mut stack, parse_node, data, &m... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:356:102 [INFO] [stdout] | [INFO] [stdout] 356 | ...nstruction::Divide, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:356:132 [INFO] [stdout] | [INFO] [stdout] 356 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:357:76 [INFO] [stdout] | [INFO] [stdout] 357 | ... Definition::Access => handle_binary_operation(Instruction::Access, &mut nodes, node_index, &mut stack, parse_node, data, &mut... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:357:100 [INFO] [stdout] | [INFO] [stdout] 357 | ...nstruction::Access, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:357:130 [INFO] [stdout] | [INFO] [stdout] 357 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:358:78 [INFO] [stdout] | [INFO] [stdout] 358 | ... Definition::Range => handle_binary_operation(Instruction::MakeRange, &mut nodes, node_index, &mut stack, parse_node, data, &m... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:358:102 [INFO] [stdout] | [INFO] [stdout] 358 | ...ruction::MakeRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:358:132 [INFO] [stdout] | [INFO] [stdout] 358 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:359:106 [INFO] [stdout] | [INFO] [stdout] 359 | ...ation(Instruction::MakeStartExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:359:130 [INFO] [stdout] | [INFO] [stdout] 359 | ...tartExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:359:160 [INFO] [stdout] | [INFO] [stdout] 359 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:360:102 [INFO] [stdout] | [INFO] [stdout] 360 | ...eration(Instruction::MakeEndExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:360:126 [INFO] [stdout] | [INFO] [stdout] 360 | ...eEndExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:360:156 [INFO] [stdout] | [INFO] [stdout] 360 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:361:96 [INFO] [stdout] | [INFO] [stdout] 361 | ..._operation(Instruction::MakeExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:361:120 [INFO] [stdout] | [INFO] [stdout] 361 | ...MakeExclusiveRange, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:361:150 [INFO] [stdout] | [INFO] [stdout] 361 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:362:84 [INFO] [stdout] | [INFO] [stdout] 362 | ... Definition::ExponentialSign => handle_binary_operation(Instruction::Power, &mut nodes, node_index, &mut stack, parse_node, da... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:362:108 [INFO] [stdout] | [INFO] [stdout] 362 | ...Instruction::Power, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:362:138 [INFO] [stdout] | [INFO] [stdout] 362 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:363:82 [INFO] [stdout] | [INFO] [stdout] 363 | ... Definition::Remainder => handle_binary_operation(Instruction::Remainder, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:363:106 [INFO] [stdout] | [INFO] [stdout] 363 | ...ruction::Remainder, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:363:136 [INFO] [stdout] | [INFO] [stdout] 363 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:364:92 [INFO] [stdout] | [INFO] [stdout] 364 | ...inary_operation(Instruction::IntegerDivide, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:364:116 [INFO] [stdout] | [INFO] [stdout] 364 | ...ion::IntegerDivide, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:364:146 [INFO] [stdout] | [INFO] [stdout] 364 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:365:84 [INFO] [stdout] | [INFO] [stdout] 365 | ... Definition::BitwiseAnd => handle_binary_operation(Instruction::BitwiseAnd, &mut nodes, node_index, &mut stack, parse_node, da... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:365:108 [INFO] [stdout] | [INFO] [stdout] 365 | ...uction::BitwiseAnd, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:365:138 [INFO] [stdout] | [INFO] [stdout] 365 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:366:82 [INFO] [stdout] | [INFO] [stdout] 366 | ... Definition::BitwiseOr => handle_binary_operation(Instruction::BitwiseOr, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:366:106 [INFO] [stdout] | [INFO] [stdout] 366 | ...ruction::BitwiseOr, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:366:136 [INFO] [stdout] | [INFO] [stdout] 366 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:367:84 [INFO] [stdout] | [INFO] [stdout] 367 | ... Definition::BitwiseXor => handle_binary_operation(Instruction::BitwiseXor, &mut nodes, node_index, &mut stack, parse_node, da... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:367:108 [INFO] [stdout] | [INFO] [stdout] 367 | ...uction::BitwiseXor, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:367:138 [INFO] [stdout] | [INFO] [stdout] 367 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:368:98 [INFO] [stdout] | [INFO] [stdout] 368 | ...y_operation(Instruction::BitwiseShiftRight, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:368:122 [INFO] [stdout] | [INFO] [stdout] 368 | ...:BitwiseShiftRight, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:368:152 [INFO] [stdout] | [INFO] [stdout] 368 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:369:96 [INFO] [stdout] | [INFO] [stdout] 369 | ...ry_operation(Instruction::BitwiseShiftLeft, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:369:120 [INFO] [stdout] | [INFO] [stdout] 369 | ...::BitwiseShiftLeft, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:369:150 [INFO] [stdout] | [INFO] [stdout] 369 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:370:70 [INFO] [stdout] | [INFO] [stdout] 370 | ... Definition::Xor => handle_binary_operation(Instruction::Xor, &mut nodes, node_index, &mut stack, parse_node, data, &mut instr... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:370:94 [INFO] [stdout] | [INFO] [stdout] 370 | ...n(Instruction::Xor, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:370:124 [INFO] [stdout] | [INFO] [stdout] 370 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:371:82 [INFO] [stdout] | [INFO] [stdout] 371 | ... Definition::TypeEqual => handle_binary_operation(Instruction::TypeEqual, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:371:106 [INFO] [stdout] | [INFO] [stdout] 371 | ...ruction::TypeEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:371:136 [INFO] [stdout] | [INFO] [stdout] 371 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:372:81 [INFO] [stdout] | [INFO] [stdout] 372 | ... Definition::TypeCast => handle_binary_operation(Instruction::ApplyType, &mut nodes, node_index, &mut stack, parse_node, data,... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:372:105 [INFO] [stdout] | [INFO] [stdout] 372 | ...ruction::ApplyType, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:372:135 [INFO] [stdout] | [INFO] [stdout] 372 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:373:77 [INFO] [stdout] | [INFO] [stdout] 373 | ... Definition::Equality => handle_binary_operation(Instruction::Equal, &mut nodes, node_index, &mut stack, parse_node, data, &mu... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:373:101 [INFO] [stdout] | [INFO] [stdout] 373 | ...Instruction::Equal, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:373:131 [INFO] [stdout] | [INFO] [stdout] 373 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:374:82 [INFO] [stdout] | [INFO] [stdout] 374 | ... Definition::Inequality => handle_binary_operation(Instruction::NotEqual, &mut nodes, node_index, &mut stack, parse_node, data... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:374:106 [INFO] [stdout] | [INFO] [stdout] 374 | ...truction::NotEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:374:136 [INFO] [stdout] | [INFO] [stdout] 374 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:375:80 [INFO] [stdout] | [INFO] [stdout] 375 | ... Definition::LessThan => handle_binary_operation(Instruction::LessThan, &mut nodes, node_index, &mut stack, parse_node, data, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:375:104 [INFO] [stdout] | [INFO] [stdout] 375 | ...truction::LessThan, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:375:134 [INFO] [stdout] | [INFO] [stdout] 375 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:376:94 [INFO] [stdout] | [INFO] [stdout] 376 | ...ary_operation(Instruction::LessThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:376:118 [INFO] [stdout] | [INFO] [stdout] 376 | ...n::LessThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:376:148 [INFO] [stdout] | [INFO] [stdout] 376 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:377:86 [INFO] [stdout] | [INFO] [stdout] 377 | ... Definition::GreaterThan => handle_binary_operation(Instruction::GreaterThan, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:377:110 [INFO] [stdout] | [INFO] [stdout] 377 | ...ction::GreaterThan, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:377:140 [INFO] [stdout] | [INFO] [stdout] 377 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:378:100 [INFO] [stdout] | [INFO] [stdout] 378 | ..._operation(Instruction::GreaterThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:378:124 [INFO] [stdout] | [INFO] [stdout] 378 | ...GreaterThanOrEqual, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:378:154 [INFO] [stdout] | [INFO] [stdout] 378 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:379:74 [INFO] [stdout] | [INFO] [stdout] 379 | ... Definition::Apply => handle_binary_operation(Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, data, &mut i... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:379:98 [INFO] [stdout] | [INFO] [stdout] 379 | ...Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:379:128 [INFO] [stdout] | [INFO] [stdout] 379 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:380:88 [INFO] [stdout] | [INFO] [stdout] 380 | ... Definition::PartialApply => handle_binary_operation(Instruction::PartialApply, &mut nodes, node_index, &mut stack, parse_node... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:380:112 [INFO] [stdout] | [INFO] [stdout] 380 | ...tion::PartialApply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:380:142 [INFO] [stdout] | [INFO] [stdout] 380 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:381:83 [INFO] [stdout] | [INFO] [stdout] 381 | ... Definition::Concatenation => handle_binary_operation(Instruction::Concat, &mut nodes, node_index, &mut stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:381:107 [INFO] [stdout] | [INFO] [stdout] 381 | ...nstruction::Concat, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:381:137 [INFO] [stdout] | [INFO] [stdout] 381 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:382:86 [INFO] [stdout] | [INFO] [stdout] 382 | ... Definition::Pair => handle_binary_operation_with_push(Instruction::MakePair, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:382:110 [INFO] [stdout] | [INFO] [stdout] 382 | ...truction::MakePair, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:382:140 [INFO] [stdout] | [INFO] [stdout] 382 | ...mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:385:86 [INFO] [stdout] | [INFO] [stdout] 385 | ... Definition::ApplyTo => handle_binary_operation_with_push(Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, ... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:385:110 [INFO] [stdout] | [INFO] [stdout] 385 | ...Instruction::Apply, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:385:140 [INFO] [stdout] | [INFO] [stdout] 385 | ...mut stack, parse_node, data, &mut instruction_metadata, |left, right| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:388:69 [INFO] [stdout] | [INFO] [stdout] 388 | ... Definition::CommaList => handle_list(Definition::CommaList, &mut nodes, node_index, &mut stack, parse_node, data, &mut instru... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:388:93 [INFO] [stdout] | [INFO] [stdout] 388 | ...inition::CommaList, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:388:123 [INFO] [stdout] | [INFO] [stdout] 388 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:389:59 [INFO] [stdout] | [INFO] [stdout] 389 | ... Definition::List => handle_list(Definition::List, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_meta... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:389:83 [INFO] [stdout] | [INFO] [stdout] 389 | ... Definition::List => handle_list(Definition::List, &mut nodes, node_index, &mut stack, parse_node, data, &mut instruction_meta... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:389:113 [INFO] [stdout] | [INFO] [stdout] 389 | ...mut stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:66 [INFO] [stdout] | [INFO] [stdout] 390 | ... Definition::Or => handle_logical_binary(Instruction::Or, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:90 [INFO] [stdout] | [INFO] [stdout] 390 | ... Definition::Or => handle_logical_binary(Instruction::Or, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, dat... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:102 [INFO] [stdout] | [INFO] [stdout] 390 | ...r, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:390:137 [INFO] [stdout] | [INFO] [stdout] 390 | ...oot_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:68 [INFO] [stdout] | [INFO] [stdout] 391 | ... Definition::And => handle_logical_binary(Instruction::And, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, d... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:92 [INFO] [stdout] | [INFO] [stdout] 391 | ...y(Instruction::And, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:104 [INFO] [stdout] | [INFO] [stdout] 391 | ...d, &mut nodes, node_index, &mut stack, &mut root_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:391:139 [INFO] [stdout] | [INFO] [stdout] 391 | ...oot_stack, parse_node, data, &mut instruction_metadata)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:452:13 [INFO] [stdout] | [INFO] [stdout] 452 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:454:13 [INFO] [stdout] | [INFO] [stdout] 454 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:455:13 [INFO] [stdout] | [INFO] [stdout] 455 | &mut root_stack, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 458 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:462:13 [INFO] [stdout] | [INFO] [stdout] 462 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:465:13 [INFO] [stdout] | [INFO] [stdout] 465 | &mut root_stack, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> compiler/src/build/build.rs:502:28 [INFO] [stdout] | [INFO] [stdout] 502 | if node.conditional_items.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!node.conditional_items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:579:13 [INFO] [stdout] | [INFO] [stdout] 579 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:581:13 [INFO] [stdout] | [INFO] [stdout] 581 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 584 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:589:13 [INFO] [stdout] | [INFO] [stdout] 589 | &mut nodes, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:591:13 [INFO] [stdout] | [INFO] [stdout] 591 | &mut stack, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `stack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/build/build.rs:594:13 [INFO] [stdout] | [INFO] [stdout] 594 | &mut instruction_metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction_metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:635:1 [INFO] [stdout] | [INFO] [stdout] 635 | / fn handle_unary_fix_apply( [INFO] [stdout] 636 | | child: Option, [INFO] [stdout] 637 | | definition: Definition, [INFO] [stdout] 638 | | nodes: &mut Vec>>, [INFO] [stdout] ... | [INFO] [stdout] 643 | | instruction_metadata: &mut Vec, [INFO] [stdout] 644 | | ) -> Result<(), CompilerError> { [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:638:12 [INFO] [stdout] | [INFO] [stdout] 638 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 638 - nodes: &mut Vec>>, [INFO] [stdout] 638 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:676:1 [INFO] [stdout] | [INFO] [stdout] 676 | / fn handle_jump_if( [INFO] [stdout] 677 | | instruction: Instruction, [INFO] [stdout] 678 | | nodes: &mut Vec>>, [INFO] [stdout] 679 | | node_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 684 | | instruction_metadata: &mut Vec, [INFO] [stdout] 685 | | ) -> Result<(), CompilerError> { [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:678:12 [INFO] [stdout] | [INFO] [stdout] 678 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 678 - nodes: &mut Vec>>, [INFO] [stdout] 678 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/build/build.rs:707:45 [INFO] [stdout] | [INFO] [stdout] 707 | Some(conditional_parent) => match nodes.get_mut(conditional_parent) { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 708 | | Some(Some(parent)) => { [INFO] [stdout] 709 | | parent.conditional_items.push(ConditionItem { [INFO] [stdout] 710 | | node_index: right, [INFO] [stdout] ... | [INFO] [stdout] 717 | | _ => {} [INFO] [stdout] 718 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 707 ~ Some(conditional_parent) => if let Some(Some(parent)) = nodes.get_mut(conditional_parent) { [INFO] [stdout] 708 + parent.conditional_items.push(ConditionItem { [INFO] [stdout] 709 + node_index: right, [INFO] [stdout] 710 + jump_index_to_update: jump_index.clone(), [INFO] [stdout] 711 + root_end_instruction: (Instruction::Invalid, None), [INFO] [stdout] 712 + }); [INFO] [stdout] 713 + data.push_instruction(instruction, Some(jump_index.clone()))?; [INFO] [stdout] 714 + instruction_metadata.push(InstructionMetadata::new(Some(node_index))); [INFO] [stdout] 715 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:739:1 [INFO] [stdout] | [INFO] [stdout] 739 | / fn handle_logical_binary( [INFO] [stdout] 740 | | instruction: Instruction, [INFO] [stdout] 741 | | nodes: &mut Vec>>, [INFO] [stdout] 742 | | node_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 747 | | instruction_metadata: &mut Vec, [INFO] [stdout] 748 | | ) -> Result<(), CompilerError> { [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:741:12 [INFO] [stdout] | [INFO] [stdout] 741 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 741 - nodes: &mut Vec>>, [INFO] [stdout] 741 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:813:1 [INFO] [stdout] | [INFO] [stdout] 813 | / fn handle_value_like( [INFO] [stdout] 814 | | add_fn: Fn, [INFO] [stdout] 815 | | instruction: Instruction, [INFO] [stdout] 816 | | nodes: &mut Vec>>, [INFO] [stdout] ... | [INFO] [stdout] 823 | | where [INFO] [stdout] 824 | | Fn: FnOnce(&mut Data, &ParseNode) -> Result, Data::Error>, [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:816:12 [INFO] [stdout] | [INFO] [stdout] 816 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 816 - nodes: &mut Vec>>, [INFO] [stdout] 816 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/build/build.rs:937:1 [INFO] [stdout] | [INFO] [stdout] 937 | / fn handle_binary_operation_with_push( [INFO] [stdout] 938 | | instruction: Instruction, [INFO] [stdout] 939 | | nodes: &mut Vec>>, [INFO] [stdout] 940 | | node_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 947 | | where [INFO] [stdout] 948 | | Fn: FnOnce(usize, usize) -> (usize, usize), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/build/build.rs:939:12 [INFO] [stdout] | [INFO] [stdout] 939 | nodes: &mut Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 939 - nodes: &mut Vec>>, [INFO] [stdout] 939 + nodes: &mut [Option>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> data/src/clone.rs:14:35 [INFO] [stdout] | [INFO] [stdout] 14 | new_data.instruction_cursor = from.instruction_cursor.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from.instruction_cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `fn(&mut SimpleGarnishData, u64) -> Result` which implements the `Copy` trait [INFO] [stdout] --> data/src/clone.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | new_data.resolver = from.resolver.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from.resolver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `fn(&mut SimpleGarnishData, Instruction, (GarnishDataType, usize), (GarnishDataType, usize)) -> Result` which implements the `Copy` trait [INFO] [stdout] --> data/src/clone.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | new_data.op_handler = from.op_handler.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from.op_handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> compiler/src/build/build.rs:1208:97 [INFO] [stdout] | [INFO] [stdout] 1208 | assert_eq!(data.get_data(), &SimpleDataList::default().append(SimpleData::ByteList(vec!['a' as u8, 'b' as u8, 'c' as u8]))); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> compiler/src/build/build.rs:1208:108 [INFO] [stdout] | [INFO] [stdout] 1208 | assert_eq!(data.get_data(), &SimpleDataList::default().append(SimpleData::ByteList(vec!['a' as u8, 'b' as u8, 'c' as u8]))); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'b'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> compiler/src/build/build.rs:1208:119 [INFO] [stdout] | [INFO] [stdout] 1208 | assert_eq!(data.get_data(), &SimpleDataList::default().append(SimpleData::ByteList(vec!['a' as u8, 'b' as u8, 'c' as u8]))); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'c'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/data/display.rs:30:40 [INFO] [stdout] | [INFO] [stdout] 30 | SimpleData::CharList(s) => format!("{}", s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/data/display.rs:79:30 [INFO] [stdout] | [INFO] [stdout] 79 | false => format!("{}", bytes.iter().map(|b| b.to_string()).collect::>().join(" ")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `bytes.iter().map(|b| b.to_string()).collect::>().join(" ").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> data/src/data/display.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 86 | ... Some(s) => format!("{}", s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> data/src/data/display.rs:179:32 [INFO] [stdout] | [INFO] [stdout] 179 | return String::from(format!("Slice({}, {}..{})", list, start, end)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Slice({}, {}..{})", list, start, end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return Some(self.current_front - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Some(self.current_front - 1); [INFO] [stdout] 38 + Some(self.current_front - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Some(self.current_back); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Some(self.current_back); [INFO] [stdout] 49 + Some(self.current_back) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return Some(self.current_front.subtract(SimpleNumber::Integer(1)).unwrap_or(self.min)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Some(self.current_front.subtract(SimpleNumber::Integer(1)).unwrap_or(self.min)); [INFO] [stdout] 87 + Some(self.current_front.subtract(SimpleNumber::Integer(1)).unwrap_or(self.min)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> data/src/data/iterators.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Some(self.current_back); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Some(self.current_back); [INFO] [stdout] 98 + Some(self.current_back) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking garnish_lang_tests v0.0.25-alpha (/opt/rustwide/workdir/tests) [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> data/src/data/number.rs:40:45 [INFO] [stdout] | [INFO] [stdout] 40 | SimpleNumber::Float(v) => Float(*v as f64), [INFO] [stdout] | ^^^^^^^^^ help: try: `(*v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> data/src/data/number.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | SimpleNumber::Integer(v) => Integer(*v as i32), [INFO] [stdout] | ^^^^^^^^^ help: try: `(*v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> compiler/src/error.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | e.source = Some(source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `CompilerError:: { source: Some(source), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> compiler/src/error.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mut e = CompilerError::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> data/src/data/number.rs:549:69 [INFO] [stdout] | [INFO] [stdout] 549 | assert_eq!(SimpleNumber::Integer(10).as_integer().unwrap(), 10.into()); [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/error.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 109 | Err(CompilerError::new_message(format!("Syntax Error: Unmatched grouping token")).append_token_details(token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Syntax Error: Unmatched grouping token".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/error.rs:113:36 [INFO] [stdout] | [INFO] [stdout] 113 | Err(CompilerError::new_message(format!("Syntax Error: Unclosed grouping")).append_token_details(token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Syntax Error: Unclosed grouping".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> compiler/src/lex/lexer.rs:361:24 [INFO] [stdout] | [INFO] [stdout] 361 | Some(t) => match t { [INFO] [stdout] | ________________________^ [INFO] [stdout] 362 | | TokenType::Identifier => { [INFO] [stdout] 363 | | if self.current_characters == "_" || self.current_characters == ":" { [INFO] [stdout] 364 | | Err(CompilerError::new( [INFO] [stdout] ... | [INFO] [stdout] 373 | | _ => Ok(()), [INFO] [stdout] 374 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> compiler/src/lex/lexer.rs:361:18 [INFO] [stdout] | [INFO] [stdout] 361 | Some(t) => match t { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 362 | TokenType::Identifier => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/lex/lexer.rs:830:28 [INFO] [stdout] | [INFO] [stdout] 830 | Some(c) => match self.process_char(c) { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 831 | | Some(t) => { [INFO] [stdout] 832 | | next_token = Some(t); [INFO] [stdout] 833 | | break; [INFO] [stdout] 834 | | } [INFO] [stdout] 835 | | None => (), [INFO] [stdout] 836 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 830 ~ Some(c) => if let Some(t) = self.process_char(c) { [INFO] [stdout] 831 + next_token = Some(t); [INFO] [stdout] 832 + break; [INFO] [stdout] 833 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> compiler/src/lex/lexer.rs:841:21 [INFO] [stdout] | [INFO] [stdout] 841 | / match self.process_char('\0') { [INFO] [stdout] 842 | | Some(t) => { [INFO] [stdout] 843 | | next_token = Some(t); [INFO] [stdout] 844 | | break; [INFO] [stdout] 845 | | } [INFO] [stdout] 846 | | None => (), [INFO] [stdout] 847 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 841 ~ if let Some(t) = self.process_char('\0') { [INFO] [stdout] 842 + next_token = Some(t); [INFO] [stdout] 843 + break; [INFO] [stdout] 844 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> compiler/src/lex/lexer.rs:850:24 [INFO] [stdout] | [INFO] [stdout] 850 | if self.current_characters.len() > 0 && self.result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.current_characters.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> compiler/src/lex/lexer.rs:888:13 [INFO] [stdout] | [INFO] [stdout] 888 | / if !current.children.contains_key(&c) { [INFO] [stdout] 889 | | let t = match last { [INFO] [stdout] 890 | | true => Some(token_type), [INFO] [stdout] 891 | | false => None, [INFO] [stdout] ... | [INFO] [stdout] 913 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 888 ~ if let std::collections::hash_map::Entry::Vacant(e) = current.children.entry(c) { [INFO] [stdout] 889 + let t = match last { [INFO] [stdout] 890 + true => Some(token_type), [INFO] [stdout] 891 + false => None, [INFO] [stdout] 892 + }; [INFO] [stdout] 893 + [INFO] [stdout] 894 + e.insert(LexerOperatorNode { [INFO] [stdout] 895 + value: c, [INFO] [stdout] 896 + token_type: t, [INFO] [stdout] 897 + children: HashMap::new(), [INFO] [stdout] 898 + }); [INFO] [stdout] 899 + } else { [INFO] [stdout] 900 + // has child [INFO] [stdout] 901 + if last { [INFO] [stdout] 902 + // update token type [INFO] [stdout] 903 + match current.children.get_mut(&c) { [INFO] [stdout] 904 + Some(node) => { [INFO] [stdout] 905 + node.token_type = Some(token_type); [INFO] [stdout] 906 + } [INFO] [stdout] 907 + None => unreachable!(), [INFO] [stdout] 908 + } [INFO] [stdout] 909 + } [INFO] [stdout] 910 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:977:26 [INFO] [stdout] | [INFO] [stdout] 977 | let result = lex(&"?".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"?"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1054:26 [INFO] [stdout] | [INFO] [stdout] 1054 | let result = lex(&"".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1061:26 [INFO] [stdout] | [INFO] [stdout] 1061 | let result = lex(&"+".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"+"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1076:26 [INFO] [stdout] | [INFO] [stdout] 1076 | let result = lex(&"-".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1091:26 [INFO] [stdout] | [INFO] [stdout] 1091 | let result = lex(&"*".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"*"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1106:26 [INFO] [stdout] | [INFO] [stdout] 1106 | let result = lex(&"/".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1121:26 [INFO] [stdout] | [INFO] [stdout] 1121 | let result = lex(&"**".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"**"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1136:26 [INFO] [stdout] | [INFO] [stdout] 1136 | let result = lex(&"//".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"//"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1151:26 [INFO] [stdout] | [INFO] [stdout] 1151 | let result = lex(&"%".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"%"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1166:26 [INFO] [stdout] | [INFO] [stdout] 1166 | let result = lex(&"--".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"--"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1181:26 [INFO] [stdout] | [INFO] [stdout] 1181 | let result = lex(&"++".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"++"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1196:26 [INFO] [stdout] | [INFO] [stdout] 1196 | let result = lex(&"!".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1211:26 [INFO] [stdout] | [INFO] [stdout] 1211 | let result = lex(&"&".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"&"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1226:26 [INFO] [stdout] | [INFO] [stdout] 1226 | let result = lex(&"|".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"|"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1241:26 [INFO] [stdout] | [INFO] [stdout] 1241 | let result = lex(&"^".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1256:26 [INFO] [stdout] | [INFO] [stdout] 1256 | let result = lex(&"<<".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"<<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1271:26 [INFO] [stdout] | [INFO] [stdout] 1271 | let result = lex(&">>".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `">>"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1286:26 [INFO] [stdout] | [INFO] [stdout] 1286 | let result = lex(&"=".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1301:26 [INFO] [stdout] | [INFO] [stdout] 1301 | let result = lex(&".".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1316:26 [INFO] [stdout] | [INFO] [stdout] 1316 | let result = lex(&"$.0".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `"$.0"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1345:26 [INFO] [stdout] | [INFO] [stdout] 1345 | let result = lex(&"_.".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"_."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1360:26 [INFO] [stdout] | [INFO] [stdout] 1360 | let result = lex(&"_.value".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"_.value"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1383:26 [INFO] [stdout] | [INFO] [stdout] 1383 | let result = lex(&"._".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"._"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1398:26 [INFO] [stdout] | [INFO] [stdout] 1398 | let result = lex(&".|".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `".|"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1413:26 [INFO] [stdout] | [INFO] [stdout] 1413 | let result = lex(&"?>".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"?>"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1428:26 [INFO] [stdout] | [INFO] [stdout] 1428 | let result = lex(&"!>".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"!>"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1443:26 [INFO] [stdout] | [INFO] [stdout] 1443 | let result = lex(&"|>".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"|>"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1458:26 [INFO] [stdout] | [INFO] [stdout] 1458 | let result = lex(&"&&".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"&&"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1473:26 [INFO] [stdout] | [INFO] [stdout] 1473 | let result = lex(&"||".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"||"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1488:26 [INFO] [stdout] | [INFO] [stdout] 1488 | let result = lex(&"^^".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"^^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1503:26 [INFO] [stdout] | [INFO] [stdout] 1503 | let result = lex(&"!!".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"!!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1518:26 [INFO] [stdout] | [INFO] [stdout] 1518 | let result = lex(&"??".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"??"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1533:26 [INFO] [stdout] | [INFO] [stdout] 1533 | let result = lex(&"==".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"=="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1548:26 [INFO] [stdout] | [INFO] [stdout] 1548 | let result = lex(&"!=".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"!="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1563:26 [INFO] [stdout] | [INFO] [stdout] 1563 | let result = lex(&"<".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1578:26 [INFO] [stdout] | [INFO] [stdout] 1578 | let result = lex(&"<=".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"<="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1593:26 [INFO] [stdout] | [INFO] [stdout] 1593 | let result = lex(&">".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `">"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1608:26 [INFO] [stdout] | [INFO] [stdout] 1608 | let result = lex(&">=".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `">="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1623:26 [INFO] [stdout] | [INFO] [stdout] 1623 | let result = lex(&"#".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"#"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1638:26 [INFO] [stdout] | [INFO] [stdout] 1638 | let result = lex(&"~#".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"~#"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1653:26 [INFO] [stdout] | [INFO] [stdout] 1653 | let result = lex(&"#=".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"#="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1668:26 [INFO] [stdout] | [INFO] [stdout] 1668 | let result = lex(&"$".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"$"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1683:26 [INFO] [stdout] | [INFO] [stdout] 1683 | let result = lex(&"$?".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"$?"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1698:26 [INFO] [stdout] | [INFO] [stdout] 1698 | let result = lex(&"$!".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"$!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1713:26 [INFO] [stdout] | [INFO] [stdout] 1713 | let result = lex(&"<~".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"<~"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1728:26 [INFO] [stdout] | [INFO] [stdout] 1728 | let result = lex(&"~".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"~"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1743:26 [INFO] [stdout] | [INFO] [stdout] 1743 | let result = lex(&"~~".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"~~"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1758:26 [INFO] [stdout] | [INFO] [stdout] 1758 | let result = lex(&"^~".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"^~"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1773:26 [INFO] [stdout] | [INFO] [stdout] 1773 | let result = lex(&"~>".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"~>"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1788:26 [INFO] [stdout] | [INFO] [stdout] 1788 | let result = lex(&"<>".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"<>"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1803:26 [INFO] [stdout] | [INFO] [stdout] 1803 | let result = lex(&"..".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `".."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1818:26 [INFO] [stdout] | [INFO] [stdout] 1818 | let result = lex(&">..".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `">.."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1833:26 [INFO] [stdout] | [INFO] [stdout] 1833 | let result = lex(&"..<".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `"..<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1848:26 [INFO] [stdout] | [INFO] [stdout] 1848 | let result = lex(&">..<".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `">..<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1863:26 [INFO] [stdout] | [INFO] [stdout] 1863 | let result = lex(&":my_symbol".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `":my_symbol"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1878:26 [INFO] [stdout] | [INFO] [stdout] 1878 | let result = lex(&":".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `":"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1893:26 [INFO] [stdout] | [INFO] [stdout] 1893 | let result = lex(&":my_symbol:my_sub_symbol".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `":my_symbol:my_sub_symbol"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1908:26 [INFO] [stdout] | [INFO] [stdout] 1908 | let result = lex(&"(".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1923:26 [INFO] [stdout] | [INFO] [stdout] 1923 | let result = lex(&")".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1938:26 [INFO] [stdout] | [INFO] [stdout] 1938 | let result = lex(&"[".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"["` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1953:26 [INFO] [stdout] | [INFO] [stdout] 1953 | let result = lex(&"]".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"]"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1968:26 [INFO] [stdout] | [INFO] [stdout] 1968 | let result = lex(&"{".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"{"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1983:26 [INFO] [stdout] | [INFO] [stdout] 1983 | let result = lex(&"}".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"}"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:1998:26 [INFO] [stdout] | [INFO] [stdout] 1998 | let result = lex(&",".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `","` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2013:26 [INFO] [stdout] | [INFO] [stdout] 2013 | let result = lex(&"()".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"()"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2028:26 [INFO] [stdout] | [INFO] [stdout] 2028 | let result = lex(&"{{{".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `"{{{"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2057:26 [INFO] [stdout] | [INFO] [stdout] 2057 | let result = lex(&"+\0+\0+".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"+\0+\0+"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2064:26 [INFO] [stdout] | [INFO] [stdout] 2064 | let result = lex(&" + \t +\t\t\t\t\t\t+ ".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" + \t +\t\t\t\t\t\t+ "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2117:26 [INFO] [stdout] | [INFO] [stdout] 2117 | let result = lex(&"\r\n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"\r\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2132:26 [INFO] [stdout] | [INFO] [stdout] 2132 | let result = lex(&"\n \t \n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\n \t \n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2147:26 [INFO] [stdout] | [INFO] [stdout] 2147 | let result = lex(&"\n \t \n\n \t \n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\n \t \n\n \t \n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2170:26 [INFO] [stdout] | [INFO] [stdout] 2170 | let result = lex(&"\n \t \n \n \t \n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\n \t \n \n \t \n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2193:26 [INFO] [stdout] | [INFO] [stdout] 2193 | let result = lex(&"\n\n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"\n\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2208:26 [INFO] [stdout] | [INFO] [stdout] 2208 | let result = lex(&"\n\n\n\n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\n\n\n\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2231:26 [INFO] [stdout] | [INFO] [stdout] 2231 | let result = lex(&";;".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `";;"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2246:26 [INFO] [stdout] | [INFO] [stdout] 2246 | let result = lex(&";".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `";"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2261:26 [INFO] [stdout] | [INFO] [stdout] 2261 | let result = lex(&"+\n+\n+\n".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"+\n+\n+\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2488:26 [INFO] [stdout] | [INFO] [stdout] 2488 | let result = lex(&"_value".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `"_value"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2503:26 [INFO] [stdout] | [INFO] [stdout] 2503 | let result = lex(&"_".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2510:26 [INFO] [stdout] | [INFO] [stdout] 2510 | let result = lex(&"::value".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"::value"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2525:26 [INFO] [stdout] | [INFO] [stdout] 2525 | let result = lex(&"value_1 Value_2 namespace::value::property".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"value_1 Value_2 namespace::value::property"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2566:26 [INFO] [stdout] | [INFO] [stdout] 2566 | let result = lex(&"value_1+Value_2".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"value_1+Value_2"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2595:26 [INFO] [stdout] | [INFO] [stdout] 2595 | let result = lex(&"expression`".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"expression`"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2610:26 [INFO] [stdout] | [INFO] [stdout] 2610 | let result = lex(&"`expression".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"`expression"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2625:26 [INFO] [stdout] | [INFO] [stdout] 2625 | let result = lex(&"`expression`".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"`expression`"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2640:26 [INFO] [stdout] | [INFO] [stdout] 2640 | let result = lex(&"@annotation".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"@annotation"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2655:26 [INFO] [stdout] | [INFO] [stdout] 2655 | let result = lex(&"@annotation my_value".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"@annotation my_value"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2684:26 [INFO] [stdout] | [INFO] [stdout] 2684 | let result = lex(&"@@ This is a comment".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"@@ This is a comment"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2699:26 [INFO] [stdout] | [INFO] [stdout] 2699 | let result = lex(&"@@This is a comment".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"@@This is a comment"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2714:26 [INFO] [stdout] | [INFO] [stdout] 2714 | let result = lex(&"@@This is a comment\nmy_value".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"@@This is a comment\nmy_value"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2744:26 [INFO] [stdout] | [INFO] [stdout] 2744 | let result = lex(&"12345_67890".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"12345_67890"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2759:26 [INFO] [stdout] | [INFO] [stdout] 2759 | let result = lex(&"12_ABCDF".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"12_ABCDF"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2773:26 [INFO] [stdout] | [INFO] [stdout] 2773 | let result = lex(&"0.12345_67890".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"0.12345_67890"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2788:26 [INFO] [stdout] | [INFO] [stdout] 2788 | let result = lex(&"0.12_ABCDF".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"0.12_ABCDF"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2803:26 [INFO] [stdout] | [INFO] [stdout] 2803 | let result = lex(&"12345 67890".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"12345 67890"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2832:26 [INFO] [stdout] | [INFO] [stdout] 2832 | let result = lex(&"12345+67890".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"12345+67890"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> data/src/data/parsing.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if input.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2913:26 [INFO] [stdout] | [INFO] [stdout] 2913 | let result = lex(&"\"Hello World!".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\"Hello World!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2920:26 [INFO] [stdout] | [INFO] [stdout] 2920 | let result = lex(&"'Hello World!".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"'Hello World!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2927:26 [INFO] [stdout] | [INFO] [stdout] 2927 | let result = lex(&"\"\"\"Hello \"sub quote\" World!\"\"\"".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\"\"\"Hello \"sub quote\" World!\"\"\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2942:26 [INFO] [stdout] | [INFO] [stdout] 2942 | let result = lex(&"'''Hello ' World!'''".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"'''Hello ' World!'''"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2957:26 [INFO] [stdout] | [INFO] [stdout] 2957 | let result = lex(&"'Hello'.4".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"'Hello'.4"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:2986:26 [INFO] [stdout] | [INFO] [stdout] 2986 | let result = lex(&"\"\"".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"\"\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3001:26 [INFO] [stdout] | [INFO] [stdout] 3001 | let result = lex(&"5 \"\" 5".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"5 \"\" 5"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3042:26 [INFO] [stdout] | [INFO] [stdout] 3042 | let result = lex(&"\"Hello World!\"".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\"Hello World!\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3057:26 [INFO] [stdout] | [INFO] [stdout] 3057 | let result = lex(&"\"Hello World!\".4".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\"Hello World!\".4"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:112:39 [INFO] [stdout] | [INFO] [stdout] 112 | 'n' => bytes.push('\n' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:113:39 [INFO] [stdout] | [INFO] [stdout] 113 | 't' => bytes.push('\t' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:114:39 [INFO] [stdout] | [INFO] [stdout] 114 | 'r' => bytes.push('\r' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3086:26 [INFO] [stdout] | [INFO] [stdout] 3086 | let result = lex(&"\"Hello World!\" <~ 10".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"\"Hello World!\" <~ 10"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3127:26 [INFO] [stdout] | [INFO] [stdout] 3127 | let result = lex(&"''".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"''"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3142:26 [INFO] [stdout] | [INFO] [stdout] 3142 | let result = lex(&"'Hello World!'".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"'Hello World!'"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:115:39 [INFO] [stdout] | [INFO] [stdout] 115 | '0' => bytes.push('\0' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:116:40 [INFO] [stdout] | [INFO] [stdout] 116 | '\\' => bytes.push('\\' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> compiler/src/lex/lexer.rs:3157:26 [INFO] [stdout] | [INFO] [stdout] 3157 | let result = lex(&"'Hello World!' <~ 10".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"'Hello World!' <~ 10"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:117:40 [INFO] [stdout] | [INFO] [stdout] 117 | '\'' => bytes.push('\'' as u8), [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\''` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> data/src/data/parsing.rs:144:31 [INFO] [stdout] | [INFO] [stdout] 144 | } else if c == ' ' && current_number.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> tests/src/main.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | while let Some(_) = path.extension() { [INFO] [stdout] | ----------^^^^^^^------------------- help: try: `while path.extension().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> data/src/data/parsing.rs:182:28 [INFO] [stdout] | [INFO] [stdout] 182 | if v < 2 || v > 36 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `!(2..=36).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:120:11 [INFO] [stdout] | [INFO] [stdout] 120 | match read_to_string(PathBuf::from(&script_path)) [INFO] [stdout] | ___________^ [INFO] [stdout] 121 | | .or_else(|e| Err(format!("{}", e))) [INFO] [stdout] | |___________________________________________^ help: try: `read_to_string(PathBuf::from(&script_path)).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / lex(&file) [INFO] [stdout] 124 | | .or_else(|e| Err(format!("{}", e))) [INFO] [stdout] 125 | | .and_then(|tokens| { [INFO] [stdout] 126 | | if create_dump_files { [INFO] [stdout] ... | [INFO] [stdout] 156 | | }) [INFO] [stdout] 157 | | .or_else(|e| Err(format!("{}", e))) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 123 ~ lex(&file) [INFO] [stdout] 124 + .or_else(|e| Err(format!("{}", e))) [INFO] [stdout] 125 + .and_then(|tokens| { [INFO] [stdout] 126 + if create_dump_files { [INFO] [stdout] 127 + let output = tokens [INFO] [stdout] 128 + .iter() [INFO] [stdout] 129 + .map(|t| format!("{:?} - \"{}\"", t.get_token_type(), escape_invisible_chars(t.get_text()))) [INFO] [stdout] 130 + .collect::>() [INFO] [stdout] 131 + .join("\n"); [INFO] [stdout] 132 + let output_path = dump_path.join("tokens.txt"); [INFO] [stdout] 133 + match fs::write(output_path, output).or_else(|e| Err(format!("{}", e))) { [INFO] [stdout] 134 + Ok(_) => {} [INFO] [stdout] 135 + Err(e) => println!("error writing token dump: {}", e), [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] 138 + parse(&tokens).or_else(|e| Err(format!("{}", e))) [INFO] [stdout] 139 + }) [INFO] [stdout] 140 + .and_then(|parse_result| { [INFO] [stdout] 141 + match parse_result.get_node(parse_result.get_root()) { [INFO] [stdout] 142 + None => println!("Could not dump parse tree"), [INFO] [stdout] 143 + Some(root) => { [INFO] [stdout] 144 + if create_dump_files { [INFO] [stdout] 145 + let dump = dump_parse_tree(root, parse_result.get_nodes()); [INFO] [stdout] 146 + let output_path = dump_path.join("tree.txt"); [INFO] [stdout] 147 + match fs::write(output_path, dump).or_else(|e| Err(format!("{}", e))) { [INFO] [stdout] 148 + Ok(_) => {} [INFO] [stdout] 149 + Err(e) => println!("error writing parse tree dump: {}", e), [INFO] [stdout] 150 + } [INFO] [stdout] 151 + } [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] 154 + [INFO] [stdout] 155 + build(parse_result.get_root(), parse_result.get_nodes().clone(), &mut data).or_else(|e| Err(format!("{}", e))) [INFO] [stdout] 156 + }).map_err(|e| format!("{}", e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / lex(&file) [INFO] [stdout] 124 | | .or_else(|e| Err(format!("{}", e))) [INFO] [stdout] | |___________________________________________________^ help: try: `lex(&file).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:133:31 [INFO] [stdout] | [INFO] [stdout] 133 | match fs::write(output_path, output).or_else(|e| Err(format!("{}", e))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::write(output_path, output).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | parse(&tokens).or_else(|e| Err(format!("{}", e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse(&tokens).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:147:39 [INFO] [stdout] | [INFO] [stdout] 147 | ... match fs::write(output_path, dump).or_else(|e| Err(format!("{}", e))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::write(output_path, dump).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | build(parse_result.get_root(), parse_result.get_nodes().clone(), &mut data).or_else(|e| Err(format!("{}", e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `build(parse_result.get_root(), parse_result.get_nodes().clone(), &mut data).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> tests/src/main.rs:157:34 [INFO] [stdout] | [INFO] [stdout] 157 | .or_else(|e| Err(format!("{}", e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | match fs::write(output_path, blocks_output).or_else(|e| Err(format!("{}", e))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::write(output_path, blocks_output).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> tests/src/main.rs:214:23 [INFO] [stdout] | [INFO] [stdout] 214 | match fs::write(output_path, blocks_output).or_else(|e| Err(format!("{}", e))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::write(output_path, blocks_output).map_err(|e| format!("{}", e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> tests/src/main.rs:233:27 [INFO] [stdout] | [INFO] [stdout] 233 | .and_then(|_| ops::put(&mut data, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `garnish_lang::RuntimeError`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> tests/src/main.rs:234:27 [INFO] [stdout] | [INFO] [stdout] 234 | .and_then(|_| ops::equal(&mut data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `garnish_lang::RuntimeError`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> tests/src/main.rs:235:27 [INFO] [stdout] | [INFO] [stdout] 235 | .and_then(|_| ops::push_value(&mut data)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `garnish_lang::RuntimeError`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ParseResult` [INFO] [stdout] --> compiler/src/parse/parser.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 318 | / pub fn new() -> Self { [INFO] [stdout] 319 | | Self { root: 0, nodes: vec![] } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 317 + impl Default for ParseResult { [INFO] [stdout] 318 + fn default() -> Self { [INFO] [stdout] 319 + Self::new() [INFO] [stdout] 320 + } [INFO] [stdout] 321 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/src/main.rs:261:45 [INFO] [stdout] | [INFO] [stdout] 261 | fn dump_parse_tree(tree: &ParseNode, nodes: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 261 - fn dump_parse_tree(tree: &ParseNode, nodes: &Vec) -> String { [INFO] [stdout] 261 + fn dump_parse_tree(tree: &ParseNode, nodes: &[ParseNode]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:476:6 [INFO] [stdout] | [INFO] [stdout] 476 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:466:1 [INFO] [stdout] | [INFO] [stdout] 466 | / fn parse_token( [INFO] [stdout] 467 | | id: usize, [INFO] [stdout] 468 | | definition: Definition, [INFO] [stdout] 469 | | left: Option, [INFO] [stdout] ... | [INFO] [stdout] 475 | | right_to_left: bool, [INFO] [stdout] 476 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/parse/parser.rs:471:12 [INFO] [stdout] | [INFO] [stdout] 471 | nodes: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 471 - nodes: &mut Vec, [INFO] [stdout] 471 + nodes: &mut [ParseNode], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:537:34 [INFO] [stdout] | [INFO] [stdout] 537 | implementation_error(format!("Max iterations reached when searching for last parent."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Max iterations reached when searching for last parent.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:607:6 [INFO] [stdout] | [INFO] [stdout] 607 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:598:1 [INFO] [stdout] | [INFO] [stdout] 598 | / fn parse_token_left_to_right( [INFO] [stdout] 599 | | id: usize, [INFO] [stdout] 600 | | definition: Definition, [INFO] [stdout] 601 | | left: Option, [INFO] [stdout] ... | [INFO] [stdout] 606 | | under_group: Option, [INFO] [stdout] 607 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:620:6 [INFO] [stdout] | [INFO] [stdout] 620 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:611:1 [INFO] [stdout] | [INFO] [stdout] 611 | / fn parse_token_right_to_left( [INFO] [stdout] 612 | | id: usize, [INFO] [stdout] 613 | | definition: Definition, [INFO] [stdout] 614 | | left: Option, [INFO] [stdout] ... | [INFO] [stdout] 619 | | under_group: Option, [INFO] [stdout] 620 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:634:6 [INFO] [stdout] | [INFO] [stdout] 634 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> compiler/src/parse/parser.rs:624:1 [INFO] [stdout] | [INFO] [stdout] 624 | / fn parse_value_like( [INFO] [stdout] 625 | | id: usize, [INFO] [stdout] 626 | | definition: Definition, [INFO] [stdout] 627 | | check_for_list: &mut bool, [INFO] [stdout] ... | [INFO] [stdout] 633 | | under_group: Option, [INFO] [stdout] 634 | | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:648:13 [INFO] [stdout] | [INFO] [stdout] 648 | &priority_map, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `priority_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> compiler/src/parse/parser.rs:677:6 [INFO] [stdout] | [INFO] [stdout] 677 | ) -> Result<(Definition, Option, Option, Option), CompilerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/parse/parser.rs:674:12 [INFO] [stdout] | [INFO] [stdout] 674 | nodes: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 674 - nodes: &mut Vec, [INFO] [stdout] 674 + nodes: &mut [ParseNode], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:722:125 [INFO] [stdout] | [INFO] [stdout] 722 | (SecondaryDefinition::Value, SecondaryDefinition::Value) if !check_for_list => composition_error(previous, current, &token), [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:760:120 [INFO] [stdout] | [INFO] [stdout] 760 | | (SecondaryDefinition::UnarySuffix, SecondaryDefinition::UnaryPrefix) => composition_error(previous, current, &token), [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> compiler/src/parse/parser.rs:766:24 [INFO] [stdout] | [INFO] [stdout] 766 | fn trim_tokens(tokens: &Vec) -> &[LexerToken] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 766 - fn trim_tokens(tokens: &Vec) -> &[LexerToken] { [INFO] [stdout] 766 + fn trim_tokens(tokens: &[LexerToken]) -> &[LexerToken] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> compiler/src/parse/parser.rs:1290:11 [INFO] [stdout] | [INFO] [stdout] 1290 | while !node.parent.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `node.parent.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:808:31 [INFO] [stdout] | [INFO] [stdout] 808 | let trimmed = trim_tokens(&lex_tokens); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `lex_tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:827:57 [INFO] [stdout] | [INFO] [stdout] 827 | None => implementation_error_with_token(format!("Current group set to non-existant group in stack."), token)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Current group set to non-existant group in stack.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> compiler/src/parse/parser.rs:847:25 [INFO] [stdout] | [INFO] [stdout] 847 | / last_left.and_then(|p| nodes.get(p)).and_then(|node| { [INFO] [stdout] 848 | | // need to update prev def as well for composition check [INFO] [stdout] 849 | | previous_second_def = node.secondary_definition; [INFO] [stdout] 850 | | Some(()) [INFO] [stdout] 851 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 847 ~ last_left.and_then(|p| nodes.get(p)).map(|node| { [INFO] [stdout] 848 | // need to update prev def as well for composition check [INFO] [stdout] 849 | previous_second_def = node.secondary_definition; [INFO] [stdout] 850 ~ () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:880:97 [INFO] [stdout] | [INFO] [stdout] 880 | setup_space_list_check(last_left, under_group, &mut nodes, &mut check_for_list, &mut &mut next_last_left)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut next_last_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:1089:55 [INFO] [stdout] | [INFO] [stdout] 1089 | ... .append_token_details(&token))?; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:424:58 [INFO] [stdout] | [INFO] [stdout] 424 | assert_eq!(parse_byte_list(input).unwrap(), vec!['a' as u8]) [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:430:58 [INFO] [stdout] | [INFO] [stdout] 430 | assert_eq!(parse_byte_list(input).unwrap(), vec!['\n' as u8]) [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:436:58 [INFO] [stdout] | [INFO] [stdout] 436 | assert_eq!(parse_byte_list(input).unwrap(), vec!['\t' as u8]) [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> compiler/src/parse/parser.rs:1160:65 [INFO] [stdout] | [INFO] [stdout] 1160 | ...mentation_error_with_token(format!("Current group set to non-existant group in stack."), token)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Current group set to non-existant group in stack.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> compiler/src/parse/parser.rs:1173:101 [INFO] [stdout] | [INFO] [stdout] 1173 | setup_space_list_check(last_left, under_group, &mut nodes, &mut check_for_list, &mut &mut next_last_left)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut next_last_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:442:58 [INFO] [stdout] | [INFO] [stdout] 442 | assert_eq!(parse_byte_list(input).unwrap(), vec!['\r' as u8]) [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:448:58 [INFO] [stdout] | [INFO] [stdout] 448 | assert_eq!(parse_byte_list(input).unwrap(), vec!['\0' as u8]) [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> compiler/src/parse/parser.rs:1227:13 [INFO] [stdout] | [INFO] [stdout] 1227 | / match definition { [INFO] [stdout] 1228 | | Definition::Identifier => match parent.and_then(|p| nodes.get(p)) { [INFO] [stdout] 1229 | | None => (), [INFO] [stdout] 1230 | | Some(p) => { [INFO] [stdout] ... | [INFO] [stdout] 1236 | | _ => (), [INFO] [stdout] 1237 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1227 ~ if definition == Definition::Identifier { match parent.and_then(|p| nodes.get(p)) { [INFO] [stdout] 1228 + None => (), [INFO] [stdout] 1229 + Some(p) => { [INFO] [stdout] 1230 + if p.definition == Definition::Access { [INFO] [stdout] 1231 + definition = Definition::Property; [INFO] [stdout] 1232 + } [INFO] [stdout] 1233 + } [INFO] [stdout] 1234 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> compiler/src/parse/parser.rs:1231:25 [INFO] [stdout] | [INFO] [stdout] 1231 | / if p.definition == Definition::Access { [INFO] [stdout] 1232 | | definition = Definition::Property; [INFO] [stdout] 1233 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1230 ~ Some(p) [INFO] [stdout] 1231 ~ if p.definition == Definition::Access => { [INFO] [stdout] 1232 | definition = Definition::Property; [INFO] [stdout] 1233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> data/src/data/parsing.rs:454:58 [INFO] [stdout] | [INFO] [stdout] 454 | assert_eq!(parse_byte_list(input).unwrap(), vec!['\\' as u8]) [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> compiler/src/parse/parser.rs:1247:27 [INFO] [stdout] | [INFO] [stdout] 1247 | None => match nodes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes.is_empty()` [INFO] [stdout] | [WARN] too many lines in the log, truncating it