[INFO] cloning repository https://github.com/gamma-delta/ttyloop
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gamma-delta/ttyloop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgamma-delta%2Fttyloop", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgamma-delta%2Fttyloop'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 909d9dc8cac9f95f469f2f9b5f2df83c20103e78
[INFO] linting gamma-delta/ttyloop against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgamma-delta%2Fttyloop" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/gamma-delta/ttyloop
[INFO] finished tweaking git repo https://github.com/gamma-delta/ttyloop
[INFO] tweaked toml for git repo https://github.com/gamma-delta/ttyloop written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/gamma-delta/ttyloop on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/gamma-delta/ttyloop already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded ncurses v5.101.0
[INFO] [stderr]   Downloaded term_size v0.3.2
[INFO] [stderr]   Downloaded enumset v1.1.3
[INFO] [stderr]   Downloaded cursive-hjkl v0.1.0
[INFO] [stderr]   Downloaded enumset_derive v0.8.1
[INFO] [stderr]   Downloaded cursive_core v0.3.7
[INFO] [stderr]   Downloaded aglet v0.5.2
[INFO] [stderr]   Downloaded cursive v0.20.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 234794364fd85d3c851f9b4b7c7a1c98de9c37443a296b5fb494451dce876350
[INFO] running `Command { std: "docker" "start" "-a" "234794364fd85d3c851f9b4b7c7a1c98de9c37443a296b5fb494451dce876350", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "234794364fd85d3c851f9b4b7c7a1c98de9c37443a296b5fb494451dce876350", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "234794364fd85d3c851f9b4b7c7a1c98de9c37443a296b5fb494451dce876350", kill_on_drop: false }`
[INFO] [stdout] 234794364fd85d3c851f9b4b7c7a1c98de9c37443a296b5fb494451dce876350
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] d6f45839e29173885316ee1375b2660311e31e786ab143f5e7c47d57d18d2a90
[INFO] running `Command { std: "docker" "start" "-a" "d6f45839e29173885316ee1375b2660311e31e786ab143f5e7c47d57d18d2a90", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.82
[INFO] [stderr]    Compiling libc v0.2.154
[INFO] [stderr]    Compiling cc v1.0.97
[INFO] [stderr]     Checking zerocopy v0.7.34
[INFO] [stderr]    Compiling signal-hook v0.3.17
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling ahash v0.8.11
[INFO] [stderr]     Checking deranged v0.3.11
[INFO] [stderr]     Checking time-core v0.1.2
[INFO] [stderr]     Checking stable_deref_trait v1.2.0
[INFO] [stderr]     Checking once_cell v1.19.0
[INFO] [stderr]     Checking xi-unicode v0.3.0
[INFO] [stderr]     Checking maplit v1.0.2
[INFO] [stderr]     Checking either v1.11.0
[INFO] [stderr]     Checking crossbeam-channel v0.5.12
[INFO] [stderr]     Checking owning_ref v0.4.1
[INFO] [stderr]     Checking itertools v0.12.1
[INFO] [stderr]    Compiling quote v1.0.36
[INFO] [stderr]     Checking getrandom v0.2.15
[INFO] [stderr]     Checking time v0.3.36
[INFO] [stderr]     Checking signal-hook-registry v1.4.2
[INFO] [stderr]     Checking term_size v0.3.2
[INFO] [stderr]    Compiling syn v2.0.61
[INFO] [stderr]    Compiling ncurses v5.101.0
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]     Checking num-complex v0.4.6
[INFO] [stderr]     Checking num-rational v0.4.2
[INFO] [stderr]     Checking num-iter v0.1.45
[INFO] [stderr]     Checking num v0.4.3
[INFO] [stderr]    Compiling darling_core v0.20.8
[INFO] [stderr]    Compiling enum-map-derive v0.17.0
[INFO] [stderr]    Compiling enumflags2_derive v0.7.9
[INFO] [stderr]     Checking enum-map v2.7.3
[INFO] [stderr]     Checking enumflags2 v0.7.9
[INFO] [stderr]     Checking aglet v0.5.2
[INFO] [stderr]    Compiling darling_macro v0.20.8
[INFO] [stderr]    Compiling darling v0.20.8
[INFO] [stderr]    Compiling enumset_derive v0.8.1
[INFO] [stderr]     Checking enumset v1.1.3
[INFO] [stderr]     Checking cursive_core v0.3.7
[INFO] [stderr]     Checking cursive v0.20.0
[INFO] [stderr]     Checking cursive-hjkl v0.1.0
[INFO] [stderr]     Checking ttyloop v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/board.rs:138:18
[INFO] [stdout]     |
[INFO] [stdout] 138 |       let fits = (!my_light) || (my_light && their_light);
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 138 -       let fits = (!my_light) || (my_light && their_light);
[INFO] [stdout] 138 +       let fits = !(my_light && !their_light);
[INFO] [stdout]     |
[INFO] [stdout] 138 -       let fits = (!my_light) || (my_light && their_light);
[INFO] [stdout] 138 +       let fits = !my_light || their_light;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/generate.rs:37:3
[INFO] [stdout]    |
[INFO] [stdout] 37 |   return Board::new(grid);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 37 -   return Board::new(grid);
[INFO] [stdout] 37 +   Board::new(grid)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/generate.rs:42:3
[INFO] [stdout]    |
[INFO] [stdout] 42 |   return Edge::from(rng.bool())
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -   return Edge::from(rng.bool())
[INFO] [stdout] 42 +   Edge::from(rng.bool())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ui.rs:160:8
[INFO] [stdout]     |
[INFO] [stdout] 160 |     if !(max >= min) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^ help: try: `(max < min)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/board.rs:138:18
[INFO] [stdout]     |
[INFO] [stdout] 138 |       let fits = (!my_light) || (my_light && their_light);
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 138 -       let fits = (!my_light) || (my_light && their_light);
[INFO] [stdout] 138 +       let fits = !(my_light && !their_light);
[INFO] [stdout]     |
[INFO] [stdout] 138 -       let fits = (!my_light) || (my_light && their_light);
[INFO] [stdout] 138 +       let fits = !my_light || their_light;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/generate.rs:37:3
[INFO] [stdout]    |
[INFO] [stdout] 37 |   return Board::new(grid);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 37 -   return Board::new(grid);
[INFO] [stdout] 37 +   Board::new(grid)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/generate.rs:42:3
[INFO] [stdout]    |
[INFO] [stdout] 42 |   return Edge::from(rng.bool())
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -   return Edge::from(rng.bool())
[INFO] [stdout] 42 +   Edge::from(rng.bool())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ui.rs:160:8
[INFO] [stdout]     |
[INFO] [stdout] 160 |     if !(max >= min) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^ help: try: `(max < min)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.65s
[INFO] running `Command { std: "docker" "inspect" "d6f45839e29173885316ee1375b2660311e31e786ab143f5e7c47d57d18d2a90", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d6f45839e29173885316ee1375b2660311e31e786ab143f5e7c47d57d18d2a90", kill_on_drop: false }`
[INFO] [stdout] d6f45839e29173885316ee1375b2660311e31e786ab143f5e7c47d57d18d2a90