[INFO] cloning repository https://github.com/gabrielluizsf/rfs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gabrielluizsf/rfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgabrielluizsf%2Frfs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgabrielluizsf%2Frfs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9abd2a56573f1e00240b0c86bedfdeff27064b13 [INFO] linting gabrielluizsf/rfs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgabrielluizsf%2Frfs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gabrielluizsf/rfs [INFO] finished tweaking git repo https://github.com/gabrielluizsf/rfs [INFO] tweaked toml for git repo https://github.com/gabrielluizsf/rfs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gabrielluizsf/rfs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gabrielluizsf/rfs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc36be3d9ede083f3ec4bb38d201fd4872d28a46e8f58df3c840733c144ff3d3 [INFO] running `Command { std: "docker" "start" "-a" "cc36be3d9ede083f3ec4bb38d201fd4872d28a46e8f58df3c840733c144ff3d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc36be3d9ede083f3ec4bb38d201fd4872d28a46e8f58df3c840733c144ff3d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc36be3d9ede083f3ec4bb38d201fd4872d28a46e8f58df3c840733c144ff3d3", kill_on_drop: false }` [INFO] [stdout] cc36be3d9ede083f3ec4bb38d201fd4872d28a46e8f58df3c840733c144ff3d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b084cc811f356a1d5ac616b5cb44b9cbe148cf25936ad780ef77c443e7705d54 [INFO] running `Command { std: "docker" "start" "-a" "b084cc811f356a1d5ac616b5cb44b9cbe148cf25936ad780ef77c443e7705d54", kill_on_drop: false }` [INFO] [stderr] Checking rfs_br v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/file_system.rs:60:43 [INFO] [stdout] | [INFO] [stdout] 60 | let mut f = fs::OpenOptions::new().write(true).append(true).open(file)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/file_system.rs:60:43 [INFO] [stdout] | [INFO] [stdout] 60 | let mut f = fs::OpenOptions::new().write(true).append(true).open(file)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/file_system_test.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(!file_system.read_file(&(test_dir.to_owned()+ "/"+ file)).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `file_system.read_file(&(test_dir.to_owned()+ "/"+ file)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/file_system_test.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return content.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return content.as_bytes(); [INFO] [stdout] 22 + content.as_bytes() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `Command { std: "docker" "inspect" "b084cc811f356a1d5ac616b5cb44b9cbe148cf25936ad780ef77c443e7705d54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b084cc811f356a1d5ac616b5cb44b9cbe148cf25936ad780ef77c443e7705d54", kill_on_drop: false }` [INFO] [stdout] b084cc811f356a1d5ac616b5cb44b9cbe148cf25936ad780ef77c443e7705d54