[INFO] cloning repository https://github.com/gabinpoa/yate-ruste [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/gabinpoa/yate-ruste" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgabinpoa%2Fyate-ruste", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgabinpoa%2Fyate-ruste'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 492c6a1d23ec2683bd92ce136adaf9c8c6f7ffb6 [INFO] linting gabinpoa/yate-ruste against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fgabinpoa%2Fyate-ruste" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/gabinpoa/yate-ruste [INFO] finished tweaking git repo https://github.com/gabinpoa/yate-ruste [INFO] tweaked toml for git repo https://github.com/gabinpoa/yate-ruste written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/gabinpoa/yate-ruste on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/gabinpoa/yate-ruste already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sdl2 v0.36.0 [INFO] [stderr] Downloaded sdl2-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b73a5336a3b082937410bab723a63ad8ad6bc1a6a462133341d662d4f28863dc [INFO] running `Command { std: "docker" "start" "-a" "b73a5336a3b082937410bab723a63ad8ad6bc1a6a462133341d662d4f28863dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b73a5336a3b082937410bab723a63ad8ad6bc1a6a462133341d662d4f28863dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b73a5336a3b082937410bab723a63ad8ad6bc1a6a462133341d662d4f28863dc", kill_on_drop: false }` [INFO] [stdout] b73a5336a3b082937410bab723a63ad8ad6bc1a6a462133341d662d4f28863dc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b23ae5dfd58a7a620cfbdd47f8b5558ebc322ca0ff9eae2c0b1cfae4f55634c2 [INFO] running `Command { std: "docker" "start" "-a" "b23ae5dfd58a7a620cfbdd47f8b5558ebc322ca0ff9eae2c0b1cfae4f55634c2", kill_on_drop: false }` [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Checking editor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:66:38 [INFO] [stdout] | [INFO] [stdout] 66 | let partial_render = font.render(&text); [INFO] [stdout] | ^^^^^ help: change this to: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if line.len() == 0usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | repetition = repetition + 1u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repetition += 1u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:214:21 [INFO] [stdout] | [INFO] [stdout] 214 | &texture_creator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `texture_creator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:216:21 [INFO] [stdout] | [INFO] [stdout] 216 | &font, [INFO] [stdout] | ^^^^^ help: change this to: `font` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/main.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | 1 as u32, [INFO] [stdout] | ^^^^^^^^ help: try: `1_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:257:35 [INFO] [stdout] | [INFO] [stdout] 257 | let cursor_y = (line as i32 * line_height as i32) + PADDING; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `line_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/main.rs:272:42 [INFO] [stdout] | [INFO] [stdout] 272 | let new_line = cursor.line - 1 as u32; [INFO] [stdout] | ^^^^^^^^ help: try: `1_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:293:12 [INFO] [stdout] | [INFO] [stdout] 293 | if !new_line_length.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_line_length.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_line_length` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:295:46 [INFO] [stdout] | [INFO] [stdout] 293 | if !new_line_length.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 294 | (cursor.line, cursor.position) [INFO] [stdout] 295 | } else if cursor.position as usize > new_line_length.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_line_length` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 293 | if !new_line_length.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 296 | (new_line as u32, new_line_length.unwrap() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:306:22 [INFO] [stdout] | [INFO] [stdout] 306 | fn line_exists(text: &Vec, line_index: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 306 - fn line_exists(text: &Vec, line_index: usize) -> bool { [INFO] [stdout] 306 + fn line_exists(text: &[String], line_index: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/main.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 307 | / match text.get(line_index) { [INFO] [stdout] 308 | | None => false, [INFO] [stdout] 309 | | Some(_) => true, [INFO] [stdout] 310 | | } [INFO] [stdout] | |_____^ help: try: `text.get(line_index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:313:41 [INFO] [stdout] | [INFO] [stdout] 313 | fn line_length(line_index: usize, text: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 313 - fn line_length(line_index: usize, text: &Vec) -> Result { [INFO] [stdout] 313 + fn line_length(line_index: usize, text: &[String]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:329:51 [INFO] [stdout] | [INFO] [stdout] 329 | fn insert_str_in_text(string_input: String, text: &mut Vec, cursor: &Cursor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 329 - fn insert_str_in_text(string_input: String, text: &mut Vec, cursor: &Cursor) { [INFO] [stdout] 329 + fn insert_str_in_text(string_input: String, text: &mut [String], cursor: &Cursor) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 394 | let l_string: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `l_string` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 394 ~ [INFO] [stdout] 395 | if f_position == line_length(f_line, editor_text).unwrap() { [INFO] [stdout] ... [INFO] [stdout] 400 | [INFO] [stdout] 401 ~ let l_string: String = if l_position == 0 { [INFO] [stdout] 402 ~ editor_text[l_line].to_owned() [INFO] [stdout] 403 | } else { [INFO] [stdout] 404 ~ editor_text[l_line].split_at(l_position).1.to_owned() [INFO] [stdout] 405 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:415:35 [INFO] [stdout] | [INFO] [stdout] 415 | fn remove_char_under_cursor(text: &mut Vec, cursor: &mut Cursor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 415 - fn remove_char_under_cursor(text: &mut Vec, cursor: &mut Cursor) { [INFO] [stdout] 415 + fn remove_char_under_cursor(text: &mut [String], cursor: &mut Cursor) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:66:38 [INFO] [stdout] | [INFO] [stdout] 66 | let partial_render = font.render(&text); [INFO] [stdout] | ^^^^^ help: change this to: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if line.len() == 0usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | repetition = repetition + 1u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repetition += 1u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:214:21 [INFO] [stdout] | [INFO] [stdout] 214 | &texture_creator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `texture_creator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:216:21 [INFO] [stdout] | [INFO] [stdout] 216 | &font, [INFO] [stdout] | ^^^^^ help: change this to: `font` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/main.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | 1 as u32, [INFO] [stdout] | ^^^^^^^^ help: try: `1_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:257:35 [INFO] [stdout] | [INFO] [stdout] 257 | let cursor_y = (line as i32 * line_height as i32) + PADDING; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `line_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/main.rs:272:42 [INFO] [stdout] | [INFO] [stdout] 272 | let new_line = cursor.line - 1 as u32; [INFO] [stdout] | ^^^^^^^^ help: try: `1_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:293:12 [INFO] [stdout] | [INFO] [stdout] 293 | if !new_line_length.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_line_length.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_line_length` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:295:46 [INFO] [stdout] | [INFO] [stdout] 293 | if !new_line_length.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 294 | (cursor.line, cursor.position) [INFO] [stdout] 295 | } else if cursor.position as usize > new_line_length.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_line_length` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 293 | if !new_line_length.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 296 | (new_line as u32, new_line_length.unwrap() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:306:22 [INFO] [stdout] | [INFO] [stdout] 306 | fn line_exists(text: &Vec, line_index: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 306 - fn line_exists(text: &Vec, line_index: usize) -> bool { [INFO] [stdout] 306 + fn line_exists(text: &[String], line_index: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/main.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 307 | / match text.get(line_index) { [INFO] [stdout] 308 | | None => false, [INFO] [stdout] 309 | | Some(_) => true, [INFO] [stdout] 310 | | } [INFO] [stdout] | |_____^ help: try: `text.get(line_index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:313:41 [INFO] [stdout] | [INFO] [stdout] 313 | fn line_length(line_index: usize, text: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 313 - fn line_length(line_index: usize, text: &Vec) -> Result { [INFO] [stdout] 313 + fn line_length(line_index: usize, text: &[String]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:329:51 [INFO] [stdout] | [INFO] [stdout] 329 | fn insert_str_in_text(string_input: String, text: &mut Vec, cursor: &Cursor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 329 - fn insert_str_in_text(string_input: String, text: &mut Vec, cursor: &Cursor) { [INFO] [stdout] 329 + fn insert_str_in_text(string_input: String, text: &mut [String], cursor: &Cursor) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 394 | let l_string: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `l_string` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 394 ~ [INFO] [stdout] 395 | if f_position == line_length(f_line, editor_text).unwrap() { [INFO] [stdout] ... [INFO] [stdout] 400 | [INFO] [stdout] 401 ~ let l_string: String = if l_position == 0 { [INFO] [stdout] 402 ~ editor_text[l_line].to_owned() [INFO] [stdout] 403 | } else { [INFO] [stdout] 404 ~ editor_text[l_line].split_at(l_position).1.to_owned() [INFO] [stdout] 405 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:415:35 [INFO] [stdout] | [INFO] [stdout] 415 | fn remove_char_under_cursor(text: &mut Vec, cursor: &mut Cursor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 415 - fn remove_char_under_cursor(text: &mut Vec, cursor: &mut Cursor) { [INFO] [stdout] 415 + fn remove_char_under_cursor(text: &mut [String], cursor: &mut Cursor) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.19s [INFO] running `Command { std: "docker" "inspect" "b23ae5dfd58a7a620cfbdd47f8b5558ebc322ca0ff9eae2c0b1cfae4f55634c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b23ae5dfd58a7a620cfbdd47f8b5558ebc322ca0ff9eae2c0b1cfae4f55634c2", kill_on_drop: false }` [INFO] [stdout] b23ae5dfd58a7a620cfbdd47f8b5558ebc322ca0ff9eae2c0b1cfae4f55634c2