[INFO] cloning repository https://github.com/futpib/choomd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/futpib/choomd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffutpib%2Fchoomd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffutpib%2Fchoomd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1788afc52ceb3678a618acd512101f60242f5f63 [INFO] linting futpib/choomd against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffutpib%2Fchoomd" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/futpib/choomd [INFO] finished tweaking git repo https://github.com/futpib/choomd [INFO] tweaked toml for git repo https://github.com/futpib/choomd written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/futpib/choomd on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/futpib/choomd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded users v0.11.0 [INFO] [stderr] Downloaded toml_parser v1.0.2 [INFO] [stderr] Downloaded toml v0.9.5 [INFO] [stderr] Downloaded serde_spanned v1.0.0 [INFO] [stderr] Downloaded serde v1.0.221 [INFO] [stderr] Downloaded toml_datetime v0.7.0 [INFO] [stderr] Downloaded toml_writer v1.0.2 [INFO] [stderr] Downloaded serde_derive v1.0.221 [INFO] [stderr] Downloaded serde_core v1.0.221 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca7604e65432befdc53c6997e017bfc2f242420ea3af5081830cf9902df33dec [INFO] running `Command { std: "docker" "start" "-a" "ca7604e65432befdc53c6997e017bfc2f242420ea3af5081830cf9902df33dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca7604e65432befdc53c6997e017bfc2f242420ea3af5081830cf9902df33dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca7604e65432befdc53c6997e017bfc2f242420ea3af5081830cf9902df33dec", kill_on_drop: false }` [INFO] [stdout] ca7604e65432befdc53c6997e017bfc2f242420ea3af5081830cf9902df33dec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c05e74dd194baf447e35e889556b9da10d5db737b9f8ba48842871d96e1ab12 [INFO] running `Command { std: "docker" "start" "-a" "2c05e74dd194baf447e35e889556b9da10d5db737b9f8ba48842871d96e1ab12", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.221 [INFO] [stderr] Compiling serde v1.0.221 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling procfs v0.18.0 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking procfs-core v0.18.0 [INFO] [stderr] Checking clap_builder v4.5.47 [INFO] [stderr] Checking indexmap v2.11.1 [INFO] [stderr] Checking toml_parser v1.0.2 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking serde_spanned v1.0.0 [INFO] [stderr] Checking toml_datetime v0.7.0 [INFO] [stderr] Checking toml v0.9.5 [INFO] [stderr] Checking clap v4.5.47 [INFO] [stderr] Checking choomd v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rule.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | rule_values: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - rule_values: &Vec, [INFO] [stdout] 15 + rule_values: &[T], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rule.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | process_snapshot_values: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - process_snapshot_values: &Vec, [INFO] [stdout] 16 + process_snapshot_values: &[T], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] 152 | | && self.matches_command_line_argument(process_snapshot) [INFO] [stdout] 153 | | && self.matches_current_working_directory(process_snapshot) [INFO] [stdout] 154 | | && self.matches_owner_user(process_snapshot) [INFO] [stdout] | |________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot) && self.matches_command_line_argument(process_snapshot) && self.matches_current_working_directory(process_snapshot) && self.matches_owner_user(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] 152 | | && self.matches_command_line_argument(process_snapshot) [INFO] [stdout] 153 | | && self.matches_current_working_directory(process_snapshot) [INFO] [stdout] | |_______________________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot) && self.matches_command_line_argument(process_snapshot) && self.matches_current_working_directory(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] 152 | | && self.matches_command_line_argument(process_snapshot) [INFO] [stdout] | |___________________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot) && self.matches_command_line_argument(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] | |____________________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches_command_line_file_path(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/main.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | if let Err(_) = process { [INFO] [stdout] | -------^^^^^^---------- help: try: `if process.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | .expect(format!("Can't parse {} as u32", key).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Can't parse {} as u32", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:142:26 [INFO] [stdout] | [INFO] [stdout] 142 | .expect(format!("Can't parse {} as integer", key).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Can't parse {} as integer", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 182 | / let rule = Rule { [INFO] [stdout] 183 | | key: key.to_string(), [INFO] [stdout] 184 | | command_line_file_path, [INFO] [stdout] 185 | | command_line_file_name, [INFO] [stdout] ... | [INFO] [stdout] 189 | | oom_score_adj, [INFO] [stdout] 190 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 191 | [INFO] [stdout] 192 | rule [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 182 ~ [INFO] [stdout] 183 | [INFO] [stdout] 184 ~ Rule { [INFO] [stdout] 185 + key: key.to_string(), [INFO] [stdout] 186 + command_line_file_path, [INFO] [stdout] 187 + command_line_file_name, [INFO] [stdout] 188 + command_line_argument, [INFO] [stdout] 189 + current_working_directory, [INFO] [stdout] 190 + owner_user_id, [INFO] [stdout] 191 + oom_score_adj, [INFO] [stdout] 192 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:164:18 [INFO] [stdout] | [INFO] [stdout] 164 | .expect(format!("Can't find user: {}", owner_user_name).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Can't find user: {}", owner_user_name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:171:20 [INFO] [stdout] | [INFO] [stdout] 171 | .chain(owner_user_id_from_name.into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 171 - .chain(owner_user_id_from_name.into_iter()), [INFO] [stdout] 171 + .chain(owner_user_id_from_name), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:253:10 [INFO] [stdout] | [INFO] [stdout] 253 | .expect(format!("Can't read config file: {}", config_path.to_string_lossy()).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Can't read config file: {}", config_path.to_string_lossy()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rule.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | rule_values: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - rule_values: &Vec, [INFO] [stdout] 15 + rule_values: &[T], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rule.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | process_snapshot_values: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - process_snapshot_values: &Vec, [INFO] [stdout] 16 + process_snapshot_values: &[T], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] 152 | | && self.matches_command_line_argument(process_snapshot) [INFO] [stdout] 153 | | && self.matches_current_working_directory(process_snapshot) [INFO] [stdout] 154 | | && self.matches_owner_user(process_snapshot) [INFO] [stdout] | |________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot) && self.matches_command_line_argument(process_snapshot) && self.matches_current_working_directory(process_snapshot) && self.matches_owner_user(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] 152 | | && self.matches_command_line_argument(process_snapshot) [INFO] [stdout] 153 | | && self.matches_current_working_directory(process_snapshot) [INFO] [stdout] | |_______________________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot) && self.matches_command_line_argument(process_snapshot) && self.matches_current_working_directory(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] 152 | | && self.matches_command_line_argument(process_snapshot) [INFO] [stdout] | |___________________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot) && self.matches_command_line_argument(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] 151 | | && self.matches_command_line_file_name(process_snapshot) [INFO] [stdout] | |____________________________________________________________________^ help: try: `self.matches_command_line_file_path(process_snapshot) && self.matches_command_line_file_name(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rule.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | true && self.matches_command_line_file_path(process_snapshot) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches_command_line_file_path(process_snapshot)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/main.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | if let Err(_) = process { [INFO] [stdout] | -------^^^^^^---------- help: try: `if process.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | .expect(format!("Can't parse {} as u32", key).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Can't parse {} as u32", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:142:26 [INFO] [stdout] | [INFO] [stdout] 142 | .expect(format!("Can't parse {} as integer", key).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Can't parse {} as integer", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 182 | / let rule = Rule { [INFO] [stdout] 183 | | key: key.to_string(), [INFO] [stdout] 184 | | command_line_file_path, [INFO] [stdout] 185 | | command_line_file_name, [INFO] [stdout] ... | [INFO] [stdout] 189 | | oom_score_adj, [INFO] [stdout] 190 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 191 | [INFO] [stdout] 192 | rule [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 182 ~ [INFO] [stdout] 183 | [INFO] [stdout] 184 ~ Rule { [INFO] [stdout] 185 + key: key.to_string(), [INFO] [stdout] 186 + command_line_file_path, [INFO] [stdout] 187 + command_line_file_name, [INFO] [stdout] 188 + command_line_argument, [INFO] [stdout] 189 + current_working_directory, [INFO] [stdout] 190 + owner_user_id, [INFO] [stdout] 191 + oom_score_adj, [INFO] [stdout] 192 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:164:18 [INFO] [stdout] | [INFO] [stdout] 164 | .expect(format!("Can't find user: {}", owner_user_name).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Can't find user: {}", owner_user_name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:171:20 [INFO] [stdout] | [INFO] [stdout] 171 | .chain(owner_user_id_from_name.into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 171 - .chain(owner_user_id_from_name.into_iter()), [INFO] [stdout] 171 + .chain(owner_user_id_from_name), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:253:10 [INFO] [stdout] | [INFO] [stdout] 253 | .expect(format!("Can't read config file: {}", config_path.to_string_lossy()).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Can't read config file: {}", config_path.to_string_lossy()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.97s [INFO] running `Command { std: "docker" "inspect" "2c05e74dd194baf447e35e889556b9da10d5db737b9f8ba48842871d96e1ab12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c05e74dd194baf447e35e889556b9da10d5db737b9f8ba48842871d96e1ab12", kill_on_drop: false }` [INFO] [stdout] 2c05e74dd194baf447e35e889556b9da10d5db737b9f8ba48842871d96e1ab12