[INFO] cloning repository https://github.com/furcb/sme [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/furcb/sme" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffurcb%2Fsme", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffurcb%2Fsme'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eb68b3f9c633f40572f398f1e88935f64ade4747 [INFO] linting furcb/sme against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffurcb%2Fsme" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/furcb/sme [INFO] finished tweaking git repo https://github.com/furcb/sme [INFO] tweaked toml for git repo https://github.com/furcb/sme written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/furcb/sme on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/furcb/sme already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded subprocess v0.1.20 [INFO] [stderr] Downloaded aho-corasick v0.7.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f432fb2a3e38dcf35bde5e9e54e142ed7ccd5be59624a2c00a9a7d1fda22d569 [INFO] running `Command { std: "docker" "start" "-a" "f432fb2a3e38dcf35bde5e9e54e142ed7ccd5be59624a2c00a9a7d1fda22d569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f432fb2a3e38dcf35bde5e9e54e142ed7ccd5be59624a2c00a9a7d1fda22d569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f432fb2a3e38dcf35bde5e9e54e142ed7ccd5be59624a2c00a9a7d1fda22d569", kill_on_drop: false }` [INFO] [stdout] f432fb2a3e38dcf35bde5e9e54e142ed7ccd5be59624a2c00a9a7d1fda22d569 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8f73b555b39820677f17c93b86d15b663f6f6ae1ef1ca066f149ae7f641b3b4 [INFO] running `Command { std: "docker" "start" "-a" "d8f73b555b39820677f17c93b86d15b663f6f6ae1ef1ca066f149ae7f641b3b4", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking subprocess v0.1.20 [INFO] [stderr] Checking crossbeam-epoch v0.8.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Checking rayon-core v1.7.0 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking sme v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | let paths = get_paths(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | perform_action(&paths, &action)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `action` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|p| String::from(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | let keep = false [INFO] [stdout] | ________________________^ [INFO] [stdout] 51 | | || (!matches.is_present("file") && !matches.is_present("directory")) [INFO] [stdout] 52 | | || (matches.is_present("file") && matches.is_present("directory")) [INFO] [stdout] 53 | | || (matches.is_present("file") && p.is_file()) [INFO] [stdout] | |______________________________________________________________^ help: try: `!matches.is_present("file") && !matches.is_present("directory") || matches.is_present("file") && matches.is_present("directory") || matches.is_present("file") && p.is_file()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | let keep = false [INFO] [stdout] | ________________________^ [INFO] [stdout] 51 | | || (!matches.is_present("file") && !matches.is_present("directory")) [INFO] [stdout] 52 | | || (matches.is_present("file") && matches.is_present("directory")) [INFO] [stdout] | |__________________________________________________________________________________^ help: try: `!matches.is_present("file") && !matches.is_present("directory") || matches.is_present("file") && matches.is_present("directory")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | let keep = false [INFO] [stdout] | ________________________^ [INFO] [stdout] 51 | | || (!matches.is_present("file") && !matches.is_present("directory")) [INFO] [stdout] | |____________________________________________________________________________________^ help: try: `!matches.is_present("file") && !matches.is_present("directory")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | if action == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `action.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/main.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | let paths = get_paths(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | perform_action(&paths, &action)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `action` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|p| String::from(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | let keep = false [INFO] [stdout] | ________________________^ [INFO] [stdout] 51 | | || (!matches.is_present("file") && !matches.is_present("directory")) [INFO] [stdout] 52 | | || (matches.is_present("file") && matches.is_present("directory")) [INFO] [stdout] 53 | | || (matches.is_present("file") && p.is_file()) [INFO] [stdout] | |______________________________________________________________^ help: try: `!matches.is_present("file") && !matches.is_present("directory") || matches.is_present("file") && matches.is_present("directory") || matches.is_present("file") && p.is_file()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | let keep = false [INFO] [stdout] | ________________________^ [INFO] [stdout] 51 | | || (!matches.is_present("file") && !matches.is_present("directory")) [INFO] [stdout] 52 | | || (matches.is_present("file") && matches.is_present("directory")) [INFO] [stdout] | |__________________________________________________________________________________^ help: try: `!matches.is_present("file") && !matches.is_present("directory") || matches.is_present("file") && matches.is_present("directory")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | let keep = false [INFO] [stdout] | ________________________^ [INFO] [stdout] 51 | | || (!matches.is_present("file") && !matches.is_present("directory")) [INFO] [stdout] | |____________________________________________________________________________________^ help: try: `!matches.is_present("file") && !matches.is_present("directory")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | if action == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `action.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/main.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.58s [INFO] running `Command { std: "docker" "inspect" "d8f73b555b39820677f17c93b86d15b663f6f6ae1ef1ca066f149ae7f641b3b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8f73b555b39820677f17c93b86d15b663f6f6ae1ef1ca066f149ae7f641b3b4", kill_on_drop: false }` [INFO] [stdout] d8f73b555b39820677f17c93b86d15b663f6f6ae1ef1ca066f149ae7f641b3b4