[INFO] cloning repository https://github.com/funnsam/4d-sweeper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/funnsam/4d-sweeper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffunnsam%2F4d-sweeper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffunnsam%2F4d-sweeper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8fe9f25bd8c8b861fd7f3e28400fd6f8838669fb [INFO] linting funnsam/4d-sweeper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffunnsam%2F4d-sweeper" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/funnsam/4d-sweeper [INFO] finished tweaking git repo https://github.com/funnsam/4d-sweeper [INFO] tweaked toml for git repo https://github.com/funnsam/4d-sweeper written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/funnsam/4d-sweeper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/funnsam/4d-sweeper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crossterm v0.26.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 320450a5b37e1110a549080d0a0bae30cdc77ed8b67d6a920aeb465b90680e9a [INFO] running `Command { std: "docker" "start" "-a" "320450a5b37e1110a549080d0a0bae30cdc77ed8b67d6a920aeb465b90680e9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "320450a5b37e1110a549080d0a0bae30cdc77ed8b67d6a920aeb465b90680e9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "320450a5b37e1110a549080d0a0bae30cdc77ed8b67d6a920aeb465b90680e9a", kill_on_drop: false }` [INFO] [stdout] 320450a5b37e1110a549080d0a0bae30cdc77ed8b67d6a920aeb465b90680e9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1980efab00de9b926de579a205e490a718abaa0bb09ec6a0fa29999f24309765 [INFO] running `Command { std: "docker" "start" "-a" "1980efab00de9b926de579a205e490a718abaa0bb09ec6a0fa29999f24309765", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.141 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.6 [INFO] [stderr] Checking parking_lot_core v0.9.7 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking minesweeper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/rand.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/rand.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/main.rs:25:10 [INFO] [stdout] | [INFO] [stdout] 25 | seed(UNIX_EPOCH.elapsed().unwrap().as_secs() as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `UNIX_EPOCH.elapsed().unwrap().as_secs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 156 | if (!mass_update && max_dist(&c, &game.selected) > 2) && // near cells [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 156 - if (!mass_update && max_dist(&c, &game.selected) > 2) && // near cells [INFO] [stdout] 157 - (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] 156 + if !(mass_update || max_dist(&c, &game.selected) <= 2 || game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] | [INFO] [stdout] 156 - if (!mass_update && max_dist(&c, &game.selected) > 2) && // near cells [INFO] [stdout] 157 - (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] 156 + if !mass_update && max_dist(&c, &game.selected) > 2 && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c) { // updated [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:157:82 [INFO] [stdout] | [INFO] [stdout] 157 | (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] | ^^^^^-- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:162:68 [INFO] [stdout] | [INFO] [stdout] 162 | let minus = neighbours(&c, &game.size).filter(|c| game.get(&c).unwrap().flagged).count(); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/main.rs:25:10 [INFO] [stdout] | [INFO] [stdout] 25 | seed(UNIX_EPOCH.elapsed().unwrap().as_secs() as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `UNIX_EPOCH.elapsed().unwrap().as_secs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 156 | if (!mass_update && max_dist(&c, &game.selected) > 2) && // near cells [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 156 - if (!mass_update && max_dist(&c, &game.selected) > 2) && // near cells [INFO] [stdout] 157 - (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] 156 + if !(mass_update || max_dist(&c, &game.selected) <= 2 || game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] | [INFO] [stdout] 156 - if (!mass_update && max_dist(&c, &game.selected) > 2) && // near cells [INFO] [stdout] 157 - (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] 156 + if !mass_update && max_dist(&c, &game.selected) > 2 && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c) { // updated [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:157:82 [INFO] [stdout] | [INFO] [stdout] 157 | (!mass_update && !game.updated_cells.chunks(game.size.len()).any(|i| i == &c)) { // updated [INFO] [stdout] | ^^^^^-- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:162:68 [INFO] [stdout] | [INFO] [stdout] 162 | let minus = neighbours(&c, &game.size).filter(|c| game.get(&c).unwrap().flagged).count(); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.81s [INFO] running `Command { std: "docker" "inspect" "1980efab00de9b926de579a205e490a718abaa0bb09ec6a0fa29999f24309765", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1980efab00de9b926de579a205e490a718abaa0bb09ec6a0fa29999f24309765", kill_on_drop: false }` [INFO] [stdout] 1980efab00de9b926de579a205e490a718abaa0bb09ec6a0fa29999f24309765