[INFO] cloning repository https://github.com/fobass/atp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fobass/atp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffobass%2Fatp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffobass%2Fatp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0f9b58e7ca64ad52a2d7ffba1516ad5ae6494a48 [INFO] linting fobass/atp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffobass%2Fatp" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fobass/atp [INFO] finished tweaking git repo https://github.com/fobass/atp [INFO] tweaked toml for git repo https://github.com/fobass/atp written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fobass/atp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fobass/atp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytes v1.7.1 [INFO] [stderr] Downloaded bcrypt v0.15.1 [INFO] [stderr] Downloaded postgres-types v0.2.7 [INFO] [stderr] Downloaded impl-more v0.1.6 [INFO] [stderr] Downloaded actix-cors v0.6.5 [INFO] [stderr] Downloaded postgres v0.19.8 [INFO] [stderr] Downloaded neli v0.5.3 [INFO] [stderr] Downloaded tokio-postgres v0.7.11 [INFO] [stderr] Downloaded unicode-properties v0.1.2 [INFO] [stderr] Downloaded tungstenite v0.15.0 [INFO] [stderr] Downloaded local-ip-address v0.4.9 [INFO] [stderr] Downloaded postgres-protocol v0.6.7 [INFO] [stderr] Downloaded syn v2.0.76 [INFO] [stderr] Downloaded cpufeatures v0.2.13 [INFO] [stderr] Downloaded indexmap v2.4.0 [INFO] [stderr] Downloaded object v0.36.3 [INFO] [stderr] Downloaded bb8 v0.8.5 [INFO] [stderr] Downloaded serde_json v1.0.127 [INFO] [stderr] Downloaded pg_bigdecimal v0.1.5 [INFO] [stderr] Downloaded tokio v1.39.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 158e4eeaaa5d84a3ce298bfbb6e17b277b98b1b4d33d76286faa653ba958f8b0 [INFO] running `Command { std: "docker" "start" "-a" "158e4eeaaa5d84a3ce298bfbb6e17b277b98b1b4d33d76286faa653ba958f8b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "158e4eeaaa5d84a3ce298bfbb6e17b277b98b1b4d33d76286faa653ba958f8b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "158e4eeaaa5d84a3ce298bfbb6e17b277b98b1b4d33d76286faa653ba958f8b0", kill_on_drop: false }` [INFO] [stdout] 158e4eeaaa5d84a3ce298bfbb6e17b277b98b1b4d33d76286faa653ba958f8b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71d9addb84cfb0c09be8ed4ba87a0f1bb712741503909067139923778c5ba9cd [INFO] running `Command { std: "docker" "start" "-a" "71d9addb84cfb0c09be8ed4ba87a0f1bb712741503909067139923778c5ba9cd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking neli v0.5.3 [INFO] [stderr] Checking bigdecimal v0.3.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking bcrypt v0.15.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking local-ip-address v0.4.9 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking postgres-protocol v0.6.7 [INFO] [stderr] Checking tungstenite v0.14.0 [INFO] [stderr] Checking tungstenite v0.15.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking bb8 v0.8.5 [INFO] [stderr] Checking tokio-tungstenite v0.15.0 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking postgres-types v0.2.7 [INFO] [stderr] Checking tokio-postgres v0.7.11 [INFO] [stderr] Checking postgres v0.19.8 [INFO] [stderr] Checking pg_bigdecimal v0.1.5 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Checking actix-web v4.9.0 [INFO] [stderr] Checking actix-cors v0.6.5 [INFO] [stderr] Checking atp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Database` [INFO] [stdout] --> src/repository/database.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / pub fn new() -> Self { [INFO] [stdout] 46 | | let users = Arc::new(Mutex::new(vec![])); [INFO] [stdout] 47 | | Database { users } [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 44 + impl Default for Database { [INFO] [stdout] 45 + fn default() -> Self { [INFO] [stdout] 46 + Self::new() [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/repository/database.rs:114:40 [INFO] [stdout] | [INFO] [stdout] 114 | self.init_default_user_balance(user_id.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Database` [INFO] [stdout] --> src/repository/database.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / pub fn new() -> Self { [INFO] [stdout] 46 | | let users = Arc::new(Mutex::new(vec![])); [INFO] [stdout] 47 | | Database { users } [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 44 + impl Default for Database { [INFO] [stdout] 45 + fn default() -> Self { [INFO] [stdout] 46 + Self::new() [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repository/database.rs:143:42 [INFO] [stdout] | [INFO] [stdout] 143 | match Database::get_user_profile(&self, *user_id).await { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/repository/database.rs:162:31 [INFO] [stdout] | [INFO] [stdout] 162 | return Ok(exist_user_info.user_id.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `exist_user_info.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/repository/database.rs:179:55 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = client.execute(&update_query, &*params).await.map_err(|_| MyError::DbError); [INFO] [stdout] | ^^^^^^^^ help: try: `¶ms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/repository/database.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 181 | Ok(exist_user_info.user_id.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `exist_user_info.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repository/database.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 196 | if !verify(&pwd_info.current_password, ¤t_password_hash).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&pwd_info.current_password, ¤t_password_hash).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/repository/database.rs:114:40 [INFO] [stdout] | [INFO] [stdout] 114 | self.init_default_user_balance(user_id.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repository/database.rs:143:42 [INFO] [stdout] | [INFO] [stdout] 143 | match Database::get_user_profile(&self, *user_id).await { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/repository/database.rs:162:31 [INFO] [stdout] | [INFO] [stdout] 162 | return Ok(exist_user_info.user_id.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `exist_user_info.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/repository/database.rs:179:55 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = client.execute(&update_query, &*params).await.map_err(|_| MyError::DbError); [INFO] [stdout] | ^^^^^^^^ help: try: `¶ms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/repository/database.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 181 | Ok(exist_user_info.user_id.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `exist_user_info.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repository/database.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 196 | if !verify(&pwd_info.current_password, ¤t_password_hash).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&pwd_info.current_password, ¤t_password_hash).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/api/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod api; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/api/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod api; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/auth/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod auth; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/auth/auth.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(auth_header[7..].to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/auth/auth.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | if auth_header.starts_with("Bearer ") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some() = auth_header.strip_prefix("Bearer ") { [INFO] [stdout] 58 ~ Ok(.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/auth/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod auth; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/auth/auth.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(auth_header[7..].to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/auth/auth.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | if auth_header.starts_with("Bearer ") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some() = auth_header.strip_prefix("Bearer ") { [INFO] [stdout] 58 ~ Ok(.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.04s [INFO] running `Command { std: "docker" "inspect" "71d9addb84cfb0c09be8ed4ba87a0f1bb712741503909067139923778c5ba9cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71d9addb84cfb0c09be8ed4ba87a0f1bb712741503909067139923778c5ba9cd", kill_on_drop: false }` [INFO] [stdout] 71d9addb84cfb0c09be8ed4ba87a0f1bb712741503909067139923778c5ba9cd