[INFO] cloning repository https://github.com/florin977/Learn-Rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/florin977/Learn-Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflorin977%2FLearn-Rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflorin977%2FLearn-Rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9ddded86d8359a6ddc2b39f66191f1768ccd146d [INFO] linting florin977/Learn-Rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflorin977%2FLearn-Rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/florin977/Learn-Rust [INFO] finished tweaking git repo https://github.com/florin977/Learn-Rust [INFO] tweaked toml for git repo https://github.com/florin977/Learn-Rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/florin977/Learn-Rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/florin977/Learn-Rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d96fe8601e61d6ee4afddb35df5531d2a692d38e54c22bc94ef8c72cf563203 [INFO] running `Command { std: "docker" "start" "-a" "9d96fe8601e61d6ee4afddb35df5531d2a692d38e54c22bc94ef8c72cf563203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d96fe8601e61d6ee4afddb35df5531d2a692d38e54c22bc94ef8c72cf563203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d96fe8601e61d6ee4afddb35df5531d2a692d38e54c22bc94ef8c72cf563203", kill_on_drop: false }` [INFO] [stdout] 9d96fe8601e61d6ee4afddb35df5531d2a692d38e54c22bc94ef8c72cf563203 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 619c4b8676b75233a222aba1660c593be8f6f0afb80e15b87b5c89d2ee92c05e [INFO] running `Command { std: "docker" "start" "-a" "619c4b8676b75233a222aba1660c593be8f6f0afb80e15b87b5c89d2ee92c05e", kill_on_drop: false }` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | let result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `result` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 | [INFO] [stdout] 21 ~ let result = if config.case_sensitive { [INFO] [stdout] 22 ~ search_case_sensitive(&config.query, &contents) [INFO] [stdout] 23 | } else { [INFO] [stdout] 24 ~ search_case_insensitive(&config.query, &contents) [INFO] [stdout] 25 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | if line.contains(&query) { [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 75 | return (!env::var("IGNORE_CASE").is_ok() || (args.len() > 3 && args[1] == "i")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("IGNORE_CASE").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | / return (!env::var("IGNORE_CASE").is_ok() || (args.len() > 3 && args[1] == "i")) [INFO] [stdout] 76 | | && !(args.len() > 3 && args[1] == "I"); [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 ~ (!env::var("IGNORE_CASE").is_ok() || (args.len() > 3 && args[1] == "i")) [INFO] [stdout] 76 ~ && !(args.len() > 3 && args[1] == "I") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | let result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `result` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 | [INFO] [stdout] 21 ~ let result = if config.case_sensitive { [INFO] [stdout] 22 ~ search_case_sensitive(&config.query, &contents) [INFO] [stdout] 23 | } else { [INFO] [stdout] 24 ~ search_case_insensitive(&config.query, &contents) [INFO] [stdout] 25 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | if line.contains(&query) { [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 75 | return (!env::var("IGNORE_CASE").is_ok() || (args.len() > 3 && args[1] == "i")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("IGNORE_CASE").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | / return (!env::var("IGNORE_CASE").is_ok() || (args.len() > 3 && args[1] == "i")) [INFO] [stdout] 76 | | && !(args.len() > 3 && args[1] == "I"); [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 ~ (!env::var("IGNORE_CASE").is_ok() || (args.len() > 3 && args[1] == "i")) [INFO] [stdout] 76 ~ && !(args.len() > 3 && args[1] == "I") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "619c4b8676b75233a222aba1660c593be8f6f0afb80e15b87b5c89d2ee92c05e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "619c4b8676b75233a222aba1660c593be8f6f0afb80e15b87b5c89d2ee92c05e", kill_on_drop: false }` [INFO] [stdout] 619c4b8676b75233a222aba1660c593be8f6f0afb80e15b87b5c89d2ee92c05e