[INFO] cloning repository https://github.com/florentw/erosion
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/florentw/erosion" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflorentw%2Ferosion", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflorentw%2Ferosion'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 350f1fb30b2bf671277850f9b72330d27248fddd
[INFO] linting florentw/erosion against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflorentw%2Ferosion" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/florentw/erosion
[INFO] finished tweaking git repo https://github.com/florentw/erosion
[INFO] tweaked toml for git repo https://github.com/florentw/erosion written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/florentw/erosion on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/florentw/erosion already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] e6cd8ed192cf9688d7aa9240a0d80203a4d31e0d1308c33b7da0942e2b6febdd
[INFO] running `Command { std: "docker" "start" "-a" "e6cd8ed192cf9688d7aa9240a0d80203a4d31e0d1308c33b7da0942e2b6febdd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e6cd8ed192cf9688d7aa9240a0d80203a4d31e0d1308c33b7da0942e2b6febdd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e6cd8ed192cf9688d7aa9240a0d80203a4d31e0d1308c33b7da0942e2b6febdd", kill_on_drop: false }`
[INFO] [stdout] e6cd8ed192cf9688d7aa9240a0d80203a4d31e0d1308c33b7da0942e2b6febdd
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c118739b9e757905579db1bea5a8757ec510641d205ec574cc5a03b7768ce817
[INFO] running `Command { std: "docker" "start" "-a" "c118739b9e757905579db1bea5a8757ec510641d205ec574cc5a03b7768ce817", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking erosion v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/throughput/mod.rs:49:9
[INFO] [stdout]    |
[INFO] [stdout] 49 |     let mut running = true;
[INFO] [stdout]    |         ----^^^^^^^
[INFO] [stdout]    |         |
[INFO] [stdout]    |         help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `previous_results` after checking its variant with `is_none`
[INFO] [stdout]   --> src/throughput/mod.rs:57:26
[INFO] [stdout]    |
[INFO] [stdout] 54 |     if previous_results.is_none() {
[INFO] [stdout]    |     ----------------------------- help: try: `if let Some(<item>) = previous_results`
[INFO] [stdout] ...
[INFO] [stdout] 57 |         previous_sleep = previous_results.unwrap().last_sleep;
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/throughput/mod.rs:113:5
[INFO] [stdout]     |
[INFO] [stdout] 113 |     return Some(ThroughputResults { last_sleep: previous_sleep, was_interrupted: false, throughput_distance });
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 113 -     return Some(ThroughputResults { last_sleep: previous_sleep, was_interrupted: false, throughput_distance });
[INFO] [stdout] 113 +     Some(ThroughputResults { last_sleep: previous_sleep, was_interrupted: false, throughput_distance })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `subsec_millis()` is more concise than this calculation
[INFO] [stdout]    --> src/throughput/mod.rs:117:35
[INFO] [stdout]     |
[INFO] [stdout] 117 |     (elapsed.as_secs() * 1_000) + (elapsed.subsec_nanos() / 1_000_000) as u64
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stdout]     = note: `#[warn(clippy::duration_subsec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/throughput/mod.rs:135:9
[INFO] [stdout]     |
[INFO] [stdout] 135 |         return true;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 135 -         return true;
[INFO] [stdout] 135 +         true
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/throughput/mod.rs:138:9
[INFO] [stdout]     |
[INFO] [stdout] 138 |         return false;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 138 -         return false;
[INFO] [stdout] 138 +         false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout]    --> src/throughput/mod.rs:154:5
[INFO] [stdout]     |
[INFO] [stdout] 154 |     throughput.round() as f64 / ROUND_FACTOR
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `throughput.round()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/throughput/mod.rs:49:9
[INFO] [stdout]    |
[INFO] [stdout] 49 |     let mut running = true;
[INFO] [stdout]    |         ----^^^^^^^
[INFO] [stdout]    |         |
[INFO] [stdout]    |         help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `previous_results` after checking its variant with `is_none`
[INFO] [stdout]   --> src/throughput/mod.rs:57:26
[INFO] [stdout]    |
[INFO] [stdout] 54 |     if previous_results.is_none() {
[INFO] [stdout]    |     ----------------------------- help: try: `if let Some(<item>) = previous_results`
[INFO] [stdout] ...
[INFO] [stdout] 57 |         previous_sleep = previous_results.unwrap().last_sleep;
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/throughput/mod.rs:113:5
[INFO] [stdout]     |
[INFO] [stdout] 113 |     return Some(ThroughputResults { last_sleep: previous_sleep, was_interrupted: false, throughput_distance });
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 113 -     return Some(ThroughputResults { last_sleep: previous_sleep, was_interrupted: false, throughput_distance });
[INFO] [stdout] 113 +     Some(ThroughputResults { last_sleep: previous_sleep, was_interrupted: false, throughput_distance })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `subsec_millis()` is more concise than this calculation
[INFO] [stdout]    --> src/throughput/mod.rs:117:35
[INFO] [stdout]     |
[INFO] [stdout] 117 |     (elapsed.as_secs() * 1_000) + (elapsed.subsec_nanos() / 1_000_000) as u64
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stdout]     = note: `#[warn(clippy::duration_subsec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/throughput/mod.rs:135:9
[INFO] [stdout]     |
[INFO] [stdout] 135 |         return true;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 135 -         return true;
[INFO] [stdout] 135 +         true
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/throughput/mod.rs:138:9
[INFO] [stdout]     |
[INFO] [stdout] 138 |         return false;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 138 -         return false;
[INFO] [stdout] 138 +         false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout]    --> src/throughput/mod.rs:154:5
[INFO] [stdout]     |
[INFO] [stdout] 154 |     throughput.round() as f64 / ROUND_FACTOR
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `throughput.round()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/throughput/mod.rs:169:9
[INFO] [stdout]     |
[INFO] [stdout] 169 |         assert_eq!(false, has_remainder);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 169 -         assert_eq!(false, has_remainder);
[INFO] [stdout] 169 +         assert!(!has_remainder);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/throughput/mod.rs:176:9
[INFO] [stdout]     |
[INFO] [stdout] 176 |         assert_eq!(true, has_remainder);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 176 -         assert_eq!(true, has_remainder);
[INFO] [stdout] 176 +         assert!(has_remainder);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/throughput/mod.rs:183:9
[INFO] [stdout]     |
[INFO] [stdout] 183 |         assert_eq!(false, has_remainder);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 183 -         assert_eq!(false, has_remainder);
[INFO] [stdout] 183 +         assert!(!has_remainder);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> tests/mono_thread_inttest.rs:89:13
[INFO] [stdout]    |
[INFO] [stdout] 89 |     assert!(!throughput_results.is_none());
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `throughput_results.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/throughput/mod.rs:197:9
[INFO] [stdout]     |
[INFO] [stdout] 197 |         assert_eq!(true, too_fast);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 197 -         assert_eq!(true, too_fast);
[INFO] [stdout] 197 +         assert!(too_fast);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/throughput/mod.rs:204:9
[INFO] [stdout]     |
[INFO] [stdout] 204 |         assert_eq!(false, too_fast);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 204 -         assert_eq!(false, too_fast);
[INFO] [stdout] 204 +         assert!(!too_fast);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.33s
[INFO] running `Command { std: "docker" "inspect" "c118739b9e757905579db1bea5a8757ec510641d205ec574cc5a03b7768ce817", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c118739b9e757905579db1bea5a8757ec510641d205ec574cc5a03b7768ce817", kill_on_drop: false }`
[INFO] [stdout] c118739b9e757905579db1bea5a8757ec510641d205ec574cc5a03b7768ce817