[INFO] cloning repository https://github.com/flew-software/perling-vm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/flew-software/perling-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflew-software%2Fperling-vm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflew-software%2Fperling-vm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 37171b4310a4bb287fb0b9f1cbac7fa3b6778390 [INFO] linting flew-software/perling-vm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fflew-software%2Fperling-vm" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/flew-software/perling-vm [INFO] finished tweaking git repo https://github.com/flew-software/perling-vm [INFO] tweaked toml for git repo https://github.com/flew-software/perling-vm written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/flew-software/perling-vm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/flew-software/perling-vm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded termcolor v1.1.2 [INFO] [stderr] Downloaded textwrap v0.12.1 [INFO] [stderr] Downloaded home v0.5.3 [INFO] [stderr] Downloaded text_io v0.1.8 [INFO] [stderr] Downloaded unicode-segmentation v1.7.1 [INFO] [stderr] Downloaded indexmap v1.6.2 [INFO] [stderr] Downloaded heck v0.3.2 [INFO] [stderr] Downloaded proc-macro2 v1.0.26 [INFO] [stderr] Downloaded clap v3.0.0-beta.2 [INFO] [stderr] Downloaded linked-hash-map v0.5.4 [INFO] [stderr] Downloaded unicode-width v0.1.8 [INFO] [stderr] Downloaded clap_derive v3.0.0-beta.2 [INFO] [stderr] Downloaded simplelog v0.9.0 [INFO] [stderr] Downloaded os_str_bytes v2.4.0 [INFO] [stderr] Downloaded libc v0.2.91 [INFO] [stderr] Downloaded syn v1.0.69 [INFO] [stderr] Downloaded hashbrown v0.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ff774ca07df0872416d0558e3775f093b5b36c037907ac07cabc29e4d91bea2 [INFO] running `Command { std: "docker" "start" "-a" "0ff774ca07df0872416d0558e3775f093b5b36c037907ac07cabc29e4d91bea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ff774ca07df0872416d0558e3775f093b5b36c037907ac07cabc29e4d91bea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ff774ca07df0872416d0558e3775f093b5b36c037907ac07cabc29e4d91bea2", kill_on_drop: false }` [INFO] [stdout] 0ff774ca07df0872416d0558e3775f093b5b36c037907ac07cabc29e4d91bea2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b4aed88170ddf30483b71388168cac648631d24d92a0333cb206400c12a8767 [INFO] running `Command { std: "docker" "start" "-a" "6b4aed88170ddf30483b71388168cac648631d24d92a0333cb206400c12a8767", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling libc v0.2.91 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking text_io v0.1.8 [INFO] [stderr] Checking home v0.5.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking simplelog v0.9.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking perling_vm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use home; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use home; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/register.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.locked; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.locked; [INFO] [stdout] 12 + self.locked [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/register.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return false; [INFO] [stdout] 26 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/register.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / if locked == "1" { [INFO] [stdout] 50 | | reg_array[key].locked = true; [INFO] [stdout] 51 | | } else { [INFO] [stdout] 52 | | reg_array[key].locked = false; [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `reg_array[key].locked = locked == "1";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn new() -> VM { [INFO] [stdout] 21 | | VM { [INFO] [stdout] 22 | | registers: [REGISTER { [INFO] [stdout] 23 | | content: 0, [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for VM { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return used_reg_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return used_reg_count; [INFO] [stdout] 43 + used_reg_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/register.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.locked; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.locked; [INFO] [stdout] 12 + self.locked [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/register.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return false; [INFO] [stdout] 26 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/register.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / if locked == "1" { [INFO] [stdout] 50 | | reg_array[key].locked = true; [INFO] [stdout] 51 | | } else { [INFO] [stdout] 52 | | reg_array[key].locked = false; [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `reg_array[key].locked = locked == "1";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[REGISTER; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | let reg_copy = self.registers.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.registers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `REGISTER` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if i.clone().content != 0 as i32 { [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `(*i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/vm.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | if i.clone().content != 0 as i32 { [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | assert_eq!(test_reg.is_locked(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 69 - assert_eq!(test_reg.is_locked(), false); [INFO] [stdout] 69 + assert!(!test_reg.is_locked()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return result; [INFO] [stdout] 51 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return result; [INFO] [stdout] 59 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return (opcode, original_op); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return (opcode, original_op); [INFO] [stdout] 68 + (opcode, original_op) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(test_reg.is_locked(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(test_reg.is_locked(), true); [INFO] [stdout] 72 + assert!(test_reg.is_locked()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return (true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return (true, 0); [INFO] [stdout] 93 + (true, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(test_reg.locked, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(test_reg.locked, false); [INFO] [stdout] 81 + assert!(!test_reg.locked); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | assert_eq!(test_reg.locked, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 84 - assert_eq!(test_reg.locked, true); [INFO] [stdout] 84 + assert!(test_reg.locked); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(test_reg.locked, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(test_reg.locked, false); [INFO] [stdout] 87 + assert!(!test_reg.locked); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | assert_eq!(test_reg.locked, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 90 - assert_eq!(test_reg.locked, true); [INFO] [stdout] 90 + assert!(test_reg.locked); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vm.rs:300:24 [INFO] [stdout] | [INFO] [stdout] 300 | if (register1 == 1 && register2 == 1) [INFO] [stdout] | ________________________^ [INFO] [stdout] 301 | | || (register1 == 1 && register2 == 0) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 - if (register1 == 1 && register2 == 1) [INFO] [stdout] 301 - || (register1 == 1 && register2 == 0) [INFO] [stdout] 300 + if !(register1 != 1 || register2 != 1 && register2 != 0) [INFO] [stdout] | [INFO] [stdout] 300 - if (register1 == 1 && register2 == 1) [INFO] [stdout] 301 - || (register1 == 1 && register2 == 0) [INFO] [stdout] 300 + if (register2 == 0 || register2 == 1) && register1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | assert_eq!(sucessful, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 101 - assert_eq!(sucessful, true); [INFO] [stdout] 101 + assert!(sucessful); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | assert_eq!(sucessful, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 107 - assert_eq!(sucessful, false); [INFO] [stdout] 107 + assert!(!sucessful); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return (true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return (true, 0); [INFO] [stdout] 399 + (true, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn new() -> VM { [INFO] [stdout] 21 | | VM { [INFO] [stdout] 22 | | registers: [REGISTER { [INFO] [stdout] 23 | | content: 0, [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for VM { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/vm.rs:164:34 [INFO] [stdout] | [INFO] [stdout] 164 | self.remainder = (register1 % register2) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(register1 % register2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return used_reg_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return used_reg_count; [INFO] [stdout] 43 + used_reg_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:209:36 [INFO] [stdout] | [INFO] [stdout] 209 | self.registers[output_register as usize].do_set(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:211:36 [INFO] [stdout] | [INFO] [stdout] 211 | self.registers[output_register as usize].do_set(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/vm.rs:223:44 [INFO] [stdout] | [INFO] [stdout] 223 | self.program_counter = 0 as usize; [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:238:36 [INFO] [stdout] | [INFO] [stdout] 238 | self.registers[output_register as usize].do_set(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:240:36 [INFO] [stdout] | [INFO] [stdout] 240 | self.registers[output_register as usize].do_set(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[REGISTER; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | let reg_copy = self.registers.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.registers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `REGISTER` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if i.clone().content != 0 as i32 { [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `(*i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/vm.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | if i.clone().content != 0 as i32 { [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/vm.rs:254:44 [INFO] [stdout] | [INFO] [stdout] 254 | self.program_counter = 0 as usize; [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return result; [INFO] [stdout] 51 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return result; [INFO] [stdout] 59 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return (opcode, original_op); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return (opcode, original_op); [INFO] [stdout] 68 + (opcode, original_op) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return (true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return (true, 0); [INFO] [stdout] 93 + (true, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vm.rs:300:24 [INFO] [stdout] | [INFO] [stdout] 300 | if (register1 == 1 && register2 == 1) [INFO] [stdout] | ________________________^ [INFO] [stdout] 301 | | || (register1 == 1 && register2 == 0) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 - if (register1 == 1 && register2 == 1) [INFO] [stdout] 301 - || (register1 == 1 && register2 == 0) [INFO] [stdout] 300 + if !(register1 != 1 || register2 != 1 && register2 != 0) [INFO] [stdout] | [INFO] [stdout] 300 - if (register1 == 1 && register2 == 1) [INFO] [stdout] 301 - || (register1 == 1 && register2 == 0) [INFO] [stdout] 300 + if (register2 == 0 || register2 == 1) && register1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return (true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return (true, 0); [INFO] [stdout] 399 + (true, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/vm.rs:164:34 [INFO] [stdout] | [INFO] [stdout] 164 | self.remainder = (register1 % register2) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(register1 % register2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/vm.rs:398:70 [INFO] [stdout] | [INFO] [stdout] 398 | self.program_counter = (self.program_set_counter as usize) * (4 as usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `4_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:209:36 [INFO] [stdout] | [INFO] [stdout] 209 | self.registers[output_register as usize].do_set(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:211:36 [INFO] [stdout] | [INFO] [stdout] 211 | self.registers[output_register as usize].do_set(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/debug.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return false; [INFO] [stdout] 49 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/vm.rs:223:44 [INFO] [stdout] | [INFO] [stdout] 223 | self.program_counter = 0 as usize; [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:238:36 [INFO] [stdout] | [INFO] [stdout] 238 | self.registers[output_register as usize].do_set(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/vm.rs:240:36 [INFO] [stdout] | [INFO] [stdout] 240 | self.registers[output_register as usize].do_set(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ output_register }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/vm.rs:254:44 [INFO] [stdout] | [INFO] [stdout] 254 | self.program_counter = 0 as usize; [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LABEL` contains a capitalized acronym [INFO] [stdout] --> src/label.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct LABEL { [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:36:34 [INFO] [stdout] | [INFO] [stdout] 36 | println!("{}{}",log_location,"/perling.info.log"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 - println!("{}{}",log_location,"/perling.info.log"); [INFO] [stdout] 36 + println!("{}/perling.info.log",log_location); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | let file = std::fs::File::open(location) [INFO] [stdout] | ________________^ [INFO] [stdout] 57 | | .unwrap() [INFO] [stdout] 58 | | .bytes() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if register_file_location != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!register_file_location.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/vm.rs:398:70 [INFO] [stdout] | [INFO] [stdout] 398 | self.program_counter = (self.program_set_counter as usize) * (4 as usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `4_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/vm.rs:553:50 [INFO] [stdout] | [INFO] [stdout] 553 | assert_eq!(test_vm.registers[3].content, 1 as i32); [INFO] [stdout] | ^^^^^^^^ help: try: `1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/vm.rs:559:50 [INFO] [stdout] | [INFO] [stdout] 559 | assert_eq!(test_vm.registers[3].content, 0 as i32); [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/vm.rs:591:50 [INFO] [stdout] | [INFO] [stdout] 591 | assert_eq!(test_vm.registers[3].content, 0 as i32); [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/vm.rs:596:50 [INFO] [stdout] | [INFO] [stdout] 596 | assert_eq!(test_vm.registers[3].content, 1 as i32); [INFO] [stdout] | ^^^^^^^^ help: try: `1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/debug.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return false; [INFO] [stdout] 49 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LABEL` contains a capitalized acronym [INFO] [stdout] --> src/label.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct LABEL { [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:36:34 [INFO] [stdout] | [INFO] [stdout] 36 | println!("{}{}",log_location,"/perling.info.log"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 - println!("{}{}",log_location,"/perling.info.log"); [INFO] [stdout] 36 + println!("{}/perling.info.log",log_location); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | let file = std::fs::File::open(location) [INFO] [stdout] | ________________^ [INFO] [stdout] 57 | | .unwrap() [INFO] [stdout] 58 | | .bytes() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if register_file_location != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!register_file_location.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.14s [INFO] running `Command { std: "docker" "inspect" "6b4aed88170ddf30483b71388168cac648631d24d92a0333cb206400c12a8767", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b4aed88170ddf30483b71388168cac648631d24d92a0333cb206400c12a8767", kill_on_drop: false }` [INFO] [stdout] 6b4aed88170ddf30483b71388168cac648631d24d92a0333cb206400c12a8767