[INFO] cloning repository https://github.com/fldc/twitch-indicator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fldc/twitch-indicator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffldc%2Ftwitch-indicator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffldc%2Ftwitch-indicator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 453c03863937ec9719240ed953d643428218b230 [INFO] linting fldc/twitch-indicator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffldc%2Ftwitch-indicator" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fldc/twitch-indicator [INFO] finished tweaking git repo https://github.com/fldc/twitch-indicator [INFO] tweaked toml for git repo https://github.com/fldc/twitch-indicator written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fldc/twitch-indicator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fldc/twitch-indicator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memmap2 v0.9.7 [INFO] [stderr] Downloaded polling v3.9.0 [INFO] [stderr] Downloaded libredox v0.1.8 [INFO] [stderr] Downloaded mac-notification-sys v0.6.6 [INFO] [stderr] Downloaded windows-implement v0.56.0 [INFO] [stderr] Downloaded windows-interface v0.56.0 [INFO] [stderr] Downloaded tauri-winrt-notification v0.2.1 [INFO] [stderr] Downloaded bytemuck_derive v1.10.0 [INFO] [stderr] Downloaded windows-core v0.56.0 [INFO] [stderr] Downloaded notify-rust v4.11.3 [INFO] [stderr] Downloaded h2 v0.4.11 [INFO] [stderr] Downloaded reqwest v0.12.22 [INFO] [stderr] Downloaded rustls v0.23.29 [INFO] [stderr] Downloaded windows v0.56.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13b8b582ba822f561c875589beb24b59f89ed44f4d51f301c884e0ae0bc65521 [INFO] running `Command { std: "docker" "start" "-a" "13b8b582ba822f561c875589beb24b59f89ed44f4d51f301c884e0ae0bc65521", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13b8b582ba822f561c875589beb24b59f89ed44f4d51f301c884e0ae0bc65521", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13b8b582ba822f561c875589beb24b59f89ed44f4d51f301c884e0ae0bc65521", kill_on_drop: false }` [INFO] [stdout] 13b8b582ba822f561c875589beb24b59f89ed44f4d51f301c884e0ae0bc65521 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9e80e6be3e19a9a5c549bbdb74a4a3c12dc6e9a4333937b3bf446502cc5a3508 [INFO] running `Command { std: "docker" "start" "-a" "9e80e6be3e19a9a5c549bbdb74a4a3c12dc6e9a4333937b3bf446502cc5a3508", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling hashbrown v0.15.4 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling gio v0.18.4 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling aws-lc-rs v1.13.3 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling cc v1.2.30 [INFO] [stderr] Compiling gtk v0.18.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Compiling rustls v0.23.29 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking async-fs v2.1.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking memmap2 v0.8.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking memmap2 v0.9.7 [INFO] [stderr] Checking pem v3.0.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling aws-lc-sys v0.30.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling serde_spanned v0.6.9 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.47.0 [INFO] [stderr] Compiling zvariant_utils v1.1.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking polling v3.9.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Compiling toml v0.8.2 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking async-io v2.5.0 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking bytemuck v1.23.1 [INFO] [stderr] Checking rcgen v0.13.2 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Compiling zvariant_derive v4.0.0 [INFO] [stderr] Compiling gtk3-macros v0.18.2 [INFO] [stderr] Compiling zbus_macros v4.0.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling glib-macros v0.18.5 [INFO] [stderr] Compiling glib-sys v0.18.1 [INFO] [stderr] Compiling gobject-sys v0.18.0 [INFO] [stderr] Compiling gio-sys v0.18.1 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.18.0 [INFO] [stderr] Compiling pango-sys v0.18.0 [INFO] [stderr] Compiling gdk-sys v0.18.2 [INFO] [stderr] Compiling atk-sys v0.18.2 [INFO] [stderr] Compiling cairo-sys-rs v0.18.2 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Compiling gtk-sys v0.18.2 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking xkbcommon v0.7.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking glib v0.18.5 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking zvariant v4.0.0 [INFO] [stderr] Checking serde_json v1.0.141 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking h2 v0.4.11 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.8 [INFO] [stderr] Checking libappindicator-sys v0.9.0 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus v4.0.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking cairo-rs v0.18.5 [INFO] [stderr] Checking atk v0.18.2 [INFO] [stderr] Checking notify-rust v4.11.3 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking gdk-pixbuf v0.18.5 [INFO] [stderr] Checking pango v0.18.3 [INFO] [stderr] Checking gdk v0.18.2 [INFO] [stderr] Checking libappindicator v0.9.0 [INFO] [stderr] Checking twitch-indicator v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config/mod.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / if let Some(extra_program) = &self.stream_open.extra_command { [INFO] [stdout] 198 | | if !extra_program.trim().is_empty() && !channel_name.is_empty() { [INFO] [stdout] 199 | | let mut extra_args = self.stream_open.extra_arguments.clone(); [INFO] [stdout] 200 | | extra_args.push(channel_name.clone()); [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 197 ~ if let Some(extra_program) = &self.stream_open.extra_command [INFO] [stdout] 198 ~ && !extra_program.trim().is_empty() && !channel_name.is_empty() { [INFO] [stdout] 199 | let mut extra_args = self.stream_open.extra_arguments.clone(); [INFO] [stdout] ... [INFO] [stdout] 215 | } [INFO] [stdout] 216 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config/mod.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / if let Some(extra_program) = &self.stream_open.extra_command { [INFO] [stdout] 198 | | if !extra_program.trim().is_empty() && !channel_name.is_empty() { [INFO] [stdout] 199 | | let mut extra_args = self.stream_open.extra_arguments.clone(); [INFO] [stdout] 200 | | extra_args.push(channel_name.clone()); [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 197 ~ if let Some(extra_program) = &self.stream_open.extra_command [INFO] [stdout] 198 ~ && !extra_program.trim().is_empty() && !channel_name.is_empty() { [INFO] [stdout] 199 | let mut extra_args = self.stream_open.extra_arguments.clone(); [INFO] [stdout] ... [INFO] [stdout] 215 | } [INFO] [stdout] 216 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/indicator.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | / if let Ok(mut gtk_settings) = [INFO] [stdout] 101 | | crate::gui::gtk_settings::GtkSettingsWindow::new(config).await [INFO] [stdout] 102 | | { [INFO] [stdout] 103 | | if let Err(e) = gtk_settings.show_sync() { [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 101 ~ crate::gui::gtk_settings::GtkSettingsWindow::new(config).await [INFO] [stdout] 102 ~ && let Err(e) = gtk_settings.show_sync() { [INFO] [stdout] 103 | eprintln!("Failed to show GTK settings: {e}"); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/indicator.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | / if let Ok(mut gtk_settings) = [INFO] [stdout] 101 | | crate::gui::gtk_settings::GtkSettingsWindow::new(config).await [INFO] [stdout] 102 | | { [INFO] [stdout] 103 | | if let Err(e) = gtk_settings.show_sync() { [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 101 ~ crate::gui::gtk_settings::GtkSettingsWindow::new(config).await [INFO] [stdout] 102 ~ && let Err(e) = gtk_settings.show_sync() { [INFO] [stdout] 103 | eprintln!("Failed to show GTK settings: {e}"); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/gui/tray.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | sorted_streams.sort_by(|a, b| b.viewer_count.cmp(&a.viewer_count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 - sorted_streams.sort_by(|a, b| b.viewer_count.cmp(&a.viewer_count)); [INFO] [stdout] 105 + sorted_streams.sort_by_key(|b| std::cmp::Reverse(b.viewer_count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/gui/tray.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | sorted_streams.sort_by(|a, b| b.viewer_count.cmp(&a.viewer_count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 - sorted_streams.sort_by(|a, b| b.viewer_count.cmp(&a.viewer_count)); [INFO] [stdout] 105 + sorted_streams.sort_by_key(|b| std::cmp::Reverse(b.viewer_count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `Command { std: "docker" "inspect" "9e80e6be3e19a9a5c549bbdb74a4a3c12dc6e9a4333937b3bf446502cc5a3508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e80e6be3e19a9a5c549bbdb74a4a3c12dc6e9a4333937b3bf446502cc5a3508", kill_on_drop: false }` [INFO] [stdout] 9e80e6be3e19a9a5c549bbdb74a4a3c12dc6e9a4333937b3bf446502cc5a3508