[INFO] cloning repository https://github.com/fishloversoul/rs-cli-calculator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fishloversoul/rs-cli-calculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffishloversoul%2Frs-cli-calculator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffishloversoul%2Frs-cli-calculator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c3ae805bdcb44de03b5d417594b4a6b913810609 [INFO] linting fishloversoul/rs-cli-calculator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffishloversoul%2Frs-cli-calculator" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fishloversoul/rs-cli-calculator [INFO] finished tweaking git repo https://github.com/fishloversoul/rs-cli-calculator [INFO] tweaked toml for git repo https://github.com/fishloversoul/rs-cli-calculator written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fishloversoul/rs-cli-calculator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fishloversoul/rs-cli-calculator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2024 which implies `resolver = "3"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2024 resolver, specify `workspace.resolver = "3"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a053a4e73ed8e73769c698e7f373cadd862f2dd70e43c1c31288d549d5c69d3f [INFO] running `Command { std: "docker" "start" "-a" "a053a4e73ed8e73769c698e7f373cadd862f2dd70e43c1c31288d549d5c69d3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a053a4e73ed8e73769c698e7f373cadd862f2dd70e43c1c31288d549d5c69d3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a053a4e73ed8e73769c698e7f373cadd862f2dd70e43c1c31288d549d5c69d3f", kill_on_drop: false }` [INFO] [stdout] a053a4e73ed8e73769c698e7f373cadd862f2dd70e43c1c31288d549d5c69d3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6daee9749005edeec48fd9f74a441f935f0d1abcb1b9ceaa48a57b69a3bb5ef6 [INFO] running `Command { std: "docker" "start" "-a" "6daee9749005edeec48fd9f74a441f935f0d1abcb1b9ceaa48a57b69a3bb5ef6", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2024 which implies `resolver = "3"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2024 resolver, specify `workspace.resolver = "3"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking calc_core v0.1.0 (/opt/rustwide/workdir/calc_core) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> calc_core/src/lib.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | while !(depth == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(depth != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> calc_core/src/lib.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | reducs_ops(&mut parts, "^", "**")?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> calc_core/src/lib.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | reducs_ops(&mut parts, "*", "/")?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> calc_core/src/lib.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | reducs_ops(&mut parts, "+", "-")?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> calc_core/src/lib.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 104 | if c.is_digit(10) || c == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> calc_core/src/lib.rs:108:22 [INFO] [stdout] | [INFO] [stdout] 108 | if c == '-' && is_number == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `is_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking calc_cli v0.1.0 (/opt/rustwide/workdir/calc_cli) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> calc_core/src/lib.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | while !(depth == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(depth != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> calc_core/src/lib.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | reducs_ops(&mut parts, "^", "**")?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> calc_core/src/lib.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | reducs_ops(&mut parts, "*", "/")?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> calc_core/src/lib.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | reducs_ops(&mut parts, "+", "-")?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> calc_core/src/lib.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 104 | if c.is_digit(10) || c == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> calc_core/src/lib.rs:108:22 [INFO] [stdout] | [INFO] [stdout] 108 | if c == '-' && is_number == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `is_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> calc_cli/src/main.rs:13:47 [INFO] [stdout] | [INFO] [stdout] 13 | if trimed == "esc" || trimed == "exit" || trimed == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> calc_cli/src/main.rs:13:47 [INFO] [stdout] | [INFO] [stdout] 13 | if trimed == "esc" || trimed == "exit" || trimed == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "6daee9749005edeec48fd9f74a441f935f0d1abcb1b9ceaa48a57b69a3bb5ef6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6daee9749005edeec48fd9f74a441f935f0d1abcb1b9ceaa48a57b69a3bb5ef6", kill_on_drop: false }` [INFO] [stdout] 6daee9749005edeec48fd9f74a441f935f0d1abcb1b9ceaa48a57b69a3bb5ef6