[INFO] cloning repository https://github.com/firejoust/mcdata-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/firejoust/mcdata-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffirejoust%2Fmcdata-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffirejoust%2Fmcdata-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 58d97978125d659621135af792755d3cf643e96d [INFO] linting firejoust/mcdata-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffirejoust%2Fmcdata-rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/firejoust/mcdata-rs [INFO] finished tweaking git repo https://github.com/firejoust/mcdata-rs [INFO] tweaked toml for git repo https://github.com/firejoust/mcdata-rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/firejoust/mcdata-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/firejoust/mcdata-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded deflate64 v0.1.9 [INFO] [stderr] Downloaded jiff-static v0.2.8 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded h2 v0.4.9 [INFO] [stderr] Downloaded zip v2.6.1 [INFO] [stderr] Downloaded rustls v0.23.26 [INFO] [stderr] Downloaded jiff v0.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d504bfa74deac542e5892d2ac6dae5e96c000bda9ff6e38b79359bb1a8470ba9 [INFO] running `Command { std: "docker" "start" "-a" "d504bfa74deac542e5892d2ac6dae5e96c000bda9ff6e38b79359bb1a8470ba9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d504bfa74deac542e5892d2ac6dae5e96c000bda9ff6e38b79359bb1a8470ba9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d504bfa74deac542e5892d2ac6dae5e96c000bda9ff6e38b79359bb1a8470ba9", kill_on_drop: false }` [INFO] [stdout] d504bfa74deac542e5892d2ac6dae5e96c000bda9ff6e38b79359bb1a8470ba9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a294f83f888debb31ef470fb366027c3260f671756cd543247874b09b8d45746 [INFO] running `Command { std: "docker" "start" "-a" "a294f83f888debb31ef470fb366027c3260f671756cd543247874b09b8d45746", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking tokio v1.44.2 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking bumpalo v3.17.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Compiling zip v2.6.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking jiff v0.2.8 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling openssl-sys v0.9.107 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking bzip2 v0.5.2 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking tokio-util v0.7.14 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking h2 v0.4.9 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.12.15 [INFO] [stderr] Checking mcdata-rs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/indexer.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/indexer.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/data_source.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | let base_cache_dir = dirs_next::cache_dir() [INFO] [stdout] | ______________________________^ [INFO] [stdout] 57 | | .ok_or_else(|| McDataError::CacheDirNotFound)? [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 57 - .ok_or_else(|| McDataError::CacheDirNotFound)? [INFO] [stdout] 57 + .ok_or(McDataError::CacheDirNotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/features.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | static LOADED_FEATURES: OnceCell>, McDataError>>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/indexer.rs:98:6 [INFO] [stdout] | [INFO] [stdout] 98 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 99 | | HashMap, [INFO] [stdout] 100 | | HashMap, [INFO] [stdout] 101 | | HashMap, [INFO] [stdout] 102 | | HashMap, [INFO] [stdout] 103 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/indexer.rs:206:6 [INFO] [stdout] | [INFO] [stdout] 206 | ) -> (HashMap>, HashMap>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/indexer.rs:282:17 [INFO] [stdout] | [INFO] [stdout] 282 | / collision_data.blocks.get(name).map_or(false, |shape_ref| { [INFO] [stdout] 283 | | matches!(shape_ref, BlockShapeRef::Single(0)) [INFO] [stdout] 284 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 282 - collision_data.blocks.get(name).map_or(false, |shape_ref| { [INFO] [stdout] 282 + collision_data.blocks.get(name).is_some_and(|shape_ref| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/data_source.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | let base_cache_dir = dirs_next::cache_dir() [INFO] [stdout] | ______________________________^ [INFO] [stdout] 57 | | .ok_or_else(|| McDataError::CacheDirNotFound)? [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 57 - .ok_or_else(|| McDataError::CacheDirNotFound)? [INFO] [stdout] 57 + .ok_or(McDataError::CacheDirNotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/features.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | static LOADED_FEATURES: OnceCell>, McDataError>>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/indexer.rs:98:6 [INFO] [stdout] | [INFO] [stdout] 98 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 99 | | HashMap, [INFO] [stdout] 100 | | HashMap, [INFO] [stdout] 101 | | HashMap, [INFO] [stdout] 102 | | HashMap, [INFO] [stdout] 103 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/indexer.rs:206:6 [INFO] [stdout] | [INFO] [stdout] 206 | ) -> (HashMap>, HashMap>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/indexer.rs:282:17 [INFO] [stdout] | [INFO] [stdout] 282 | / collision_data.blocks.get(name).map_or(false, |shape_ref| { [INFO] [stdout] 283 | | matches!(shape_ref, BlockShapeRef::Single(0)) [INFO] [stdout] 284 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 282 - collision_data.blocks.get(name).map_or(false, |shape_ref| { [INFO] [stdout] 282 + collision_data.blocks.get(name).is_some_and(|shape_ref| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/version.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / impl PartialOrd for Version { [INFO] [stdout] 56 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 57 | | if self.edition != other.edition { [INFO] [stdout] 58 | | None // Cannot compare across editions. [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 57 - if self.edition != other.edition { [INFO] [stdout] 58 - None // Cannot compare across editions. [INFO] [stdout] 59 - } else { [INFO] [stdout] 60 - // Compare based on data_version. [INFO] [stdout] 61 - self.data_version.partial_cmp(&other.data_version) [INFO] [stdout] 62 - } [INFO] [stdout] 63 - } [INFO] [stdout] 56 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/version.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | raw_versions.sort_by(|a, b| b.version.cmp(&a.version)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 118 - raw_versions.sort_by(|a, b| b.version.cmp(&a.version)); [INFO] [stdout] 118 + raw_versions.sort_by_key(|b| std::cmp::Reverse(b.version)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version.rs:162:20 [INFO] [stdout] | [INFO] [stdout] 162 | if (v.data_version > existing.data_version && v.release_type == "release") [INFO] [stdout] | ____________________^ [INFO] [stdout] 163 | | || (v.data_version > existing.data_version [INFO] [stdout] 164 | | && existing.release_type != "release") [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 - if (v.data_version > existing.data_version && v.release_type == "release") [INFO] [stdout] 163 - || (v.data_version > existing.data_version [INFO] [stdout] 164 - && existing.release_type != "release") [INFO] [stdout] 162 + if !(v.data_version <= existing.data_version || v.release_type != "release" && existing.release_type == "release") [INFO] [stdout] | [INFO] [stdout] 162 - if (v.data_version > existing.data_version && v.release_type == "release") [INFO] [stdout] 163 - || (v.data_version > existing.data_version [INFO] [stdout] 164 - && existing.release_type != "release") [INFO] [stdout] 162 + if (existing.release_type != "release" || v.release_type == "release") && v.data_version > existing.data_version [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/version.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / impl PartialOrd for Version { [INFO] [stdout] 56 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 57 | | if self.edition != other.edition { [INFO] [stdout] 58 | | None // Cannot compare across editions. [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 57 - if self.edition != other.edition { [INFO] [stdout] 58 - None // Cannot compare across editions. [INFO] [stdout] 59 - } else { [INFO] [stdout] 60 - // Compare based on data_version. [INFO] [stdout] 61 - self.data_version.partial_cmp(&other.data_version) [INFO] [stdout] 62 - } [INFO] [stdout] 63 - } [INFO] [stdout] 56 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/version.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | raw_versions.sort_by(|a, b| b.version.cmp(&a.version)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 118 - raw_versions.sort_by(|a, b| b.version.cmp(&a.version)); [INFO] [stdout] 118 + raw_versions.sort_by_key(|b| std::cmp::Reverse(b.version)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version.rs:162:20 [INFO] [stdout] | [INFO] [stdout] 162 | if (v.data_version > existing.data_version && v.release_type == "release") [INFO] [stdout] | ____________________^ [INFO] [stdout] 163 | | || (v.data_version > existing.data_version [INFO] [stdout] 164 | | && existing.release_type != "release") [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 - if (v.data_version > existing.data_version && v.release_type == "release") [INFO] [stdout] 163 - || (v.data_version > existing.data_version [INFO] [stdout] 164 - && existing.release_type != "release") [INFO] [stdout] 162 + if !(v.data_version <= existing.data_version || v.release_type != "release" && existing.release_type == "release") [INFO] [stdout] | [INFO] [stdout] 162 - if (v.data_version > existing.data_version && v.release_type == "release") [INFO] [stdout] 163 - || (v.data_version > existing.data_version [INFO] [stdout] 164 - && existing.release_type != "release") [INFO] [stdout] 162 + if (existing.release_type != "release" || v.release_type == "release") && v.data_version > existing.data_version [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.19s [INFO] running `Command { std: "docker" "inspect" "a294f83f888debb31ef470fb366027c3260f671756cd543247874b09b8d45746", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a294f83f888debb31ef470fb366027c3260f671756cd543247874b09b8d45746", kill_on_drop: false }` [INFO] [stdout] a294f83f888debb31ef470fb366027c3260f671756cd543247874b09b8d45746