[INFO] cloning repository https://github.com/filedesless/felisp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/filedesless/felisp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffiledesless%2Ffelisp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffiledesless%2Ffelisp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 20d8d695a682a586dc1654b70c7e7d1727e9a721 [INFO] linting filedesless/felisp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffiledesless%2Ffelisp" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/filedesless/felisp [INFO] finished tweaking git repo https://github.com/filedesless/felisp [INFO] tweaked toml for git repo https://github.com/filedesless/felisp written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/filedesless/felisp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/filedesless/felisp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded fd-lock v4.0.4 [INFO] [stderr] Downloaded rustyline v17.0.2 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c8d63d38694cd097b9d76cc17abbc807240f98b0e8448a0900ac0610fc4d010 [INFO] running `Command { std: "docker" "start" "-a" "8c8d63d38694cd097b9d76cc17abbc807240f98b0e8448a0900ac0610fc4d010", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c8d63d38694cd097b9d76cc17abbc807240f98b0e8448a0900ac0610fc4d010", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c8d63d38694cd097b9d76cc17abbc807240f98b0e8448a0900ac0610fc4d010", kill_on_drop: false }` [INFO] [stdout] 8c8d63d38694cd097b9d76cc17abbc807240f98b0e8448a0900ac0610fc4d010 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6db45f20ff12a22b9ee95f3570dd1932ae2272cfb28b4c9e73b49eb32a98d2f0 [INFO] running `Command { std: "docker" "start" "-a" "6db45f20ff12a22b9ee95f3570dd1932ae2272cfb28b4c9e73b49eb32a98d2f0", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking fd-lock v4.0.4 [INFO] [stderr] Checking rustyline v17.0.2 [INFO] [stderr] Checking felisp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ast.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if !chars.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ast.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 41 | while let Some(_) = chars.next_if(|&c| c.is_whitespace()) {} [INFO] [stdout] | ----------^^^^^^^---------------------------------------- help: try: `while chars.next_if(|&c| c.is_whitespace()).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ast.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 46 | while let Some(_) = chars.next_if(|&c| c.is_whitespace()) {} [INFO] [stdout] | ----------^^^^^^^---------------------------------------- help: try: `while chars.next_if(|&c| c.is_whitespace()).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ast.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if !chars.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ast.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 41 | while let Some(_) = chars.next_if(|&c| c.is_whitespace()) {} [INFO] [stdout] | ----------^^^^^^^---------------------------------------- help: try: `while chars.next_if(|&c| c.is_whitespace()).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ast.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 46 | while let Some(_) = chars.next_if(|&c| c.is_whitespace()) {} [INFO] [stdout] | ----------^^^^^^^---------------------------------------- help: try: `while chars.next_if(|&c| c.is_whitespace()).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/env.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Value::Number(x) = args[0] { [INFO] [stdout] 122 | | if let Value::Number(y) = args[1] { [INFO] [stdout] 123 | | return Ok(Value::Number(x - y)); [INFO] [stdout] 124 | | } [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 121 ~ if let Value::Number(x) = args[0] [INFO] [stdout] 122 ~ && let Value::Number(y) = args[1] { [INFO] [stdout] 123 | return Ok(Value::Number(x - y)); [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/env.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | / if let Value::Number(x) = args[0] { [INFO] [stdout] 146 | | if let Value::Number(y) = args[1] { [INFO] [stdout] 147 | | return Ok(if x <= y { Value::True } else { Value::False }); [INFO] [stdout] 148 | | } [INFO] [stdout] 149 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 145 ~ if let Value::Number(x) = args[0] [INFO] [stdout] 146 ~ && let Value::Number(y) = args[1] { [INFO] [stdout] 147 | return Ok(if x <= y { Value::True } else { Value::False }); [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 67 | fn eval_def(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 67 - fn eval_def(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 67 + fn eval_def(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(format!("def! requires 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"def! requires 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | fn eval_let(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn eval_let(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 80 + fn eval_let(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(format!("let* requires 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"let* requires 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:100:34 [INFO] [stdout] | [INFO] [stdout] 100 | fn eval_do(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 100 - fn eval_do(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 100 + fn eval_do(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | fn eval_if(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - fn eval_if(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 111 + fn eval_if(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.45s [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | return Err(format!("if* requires at least 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"if* requires at least 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | _ => Err(format!("if* requires at most 3 arguments")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"if* requires at most 3 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:124:39 [INFO] [stdout] | [INFO] [stdout] 124 | fn eval_function(env: Rc, exprs: &Vec, f: Callback) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 124 - fn eval_function(env: Rc, exprs: &Vec, f: Callback) -> Result { [INFO] [stdout] 124 + fn eval_function(env: Rc, exprs: &[Expr], f: Callback) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/main.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(f(&args)?) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 130 - Ok(f(&args)?) [INFO] [stdout] 130 + f(&args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:141:34 [INFO] [stdout] | [INFO] [stdout] 141 | fn eval_fn(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 141 - fn eval_fn(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 141 + fn eval_fn(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:143:20 [INFO] [stdout] | [INFO] [stdout] 143 | return Err(format!("fn* requires 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"fn* requires 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/env.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Value::Number(x) = args[0] { [INFO] [stdout] 122 | | if let Value::Number(y) = args[1] { [INFO] [stdout] 123 | | return Ok(Value::Number(x - y)); [INFO] [stdout] 124 | | } [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 121 ~ if let Value::Number(x) = args[0] [INFO] [stdout] 122 ~ && let Value::Number(y) = args[1] { [INFO] [stdout] 123 | return Ok(Value::Number(x - y)); [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/env.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | / if let Value::Number(x) = args[0] { [INFO] [stdout] 146 | | if let Value::Number(y) = args[1] { [INFO] [stdout] 147 | | return Ok(if x <= y { Value::True } else { Value::False }); [INFO] [stdout] 148 | | } [INFO] [stdout] 149 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 145 ~ if let Value::Number(x) = args[0] [INFO] [stdout] 146 ~ && let Value::Number(y) = args[1] { [INFO] [stdout] 147 | return Ok(if x <= y { Value::True } else { Value::False }); [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 67 | fn eval_def(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 67 - fn eval_def(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 67 + fn eval_def(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(format!("def! requires 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"def! requires 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | fn eval_let(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn eval_let(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 80 + fn eval_let(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(format!("let* requires 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"let* requires 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:100:34 [INFO] [stdout] | [INFO] [stdout] 100 | fn eval_do(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 100 - fn eval_do(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 100 + fn eval_do(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | fn eval_if(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - fn eval_if(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 111 + fn eval_if(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | return Err(format!("if* requires at least 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"if* requires at least 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | _ => Err(format!("if* requires at most 3 arguments")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"if* requires at most 3 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:124:39 [INFO] [stdout] | [INFO] [stdout] 124 | fn eval_function(env: Rc, exprs: &Vec, f: Callback) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 124 - fn eval_function(env: Rc, exprs: &Vec, f: Callback) -> Result { [INFO] [stdout] 124 + fn eval_function(env: Rc, exprs: &[Expr], f: Callback) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/main.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(f(&args)?) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 130 - Ok(f(&args)?) [INFO] [stdout] 130 + f(&args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:141:34 [INFO] [stdout] | [INFO] [stdout] 141 | fn eval_fn(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 141 - fn eval_fn(env: &Rc, exprs: &Vec) -> Result { [INFO] [stdout] 141 + fn eval_fn(env: &Rc, exprs: &[Expr]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:143:20 [INFO] [stdout] | [INFO] [stdout] 143 | return Err(format!("fn* requires 2 arguments")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"fn* requires 2 arguments".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "6db45f20ff12a22b9ee95f3570dd1932ae2272cfb28b4c9e73b49eb32a98d2f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6db45f20ff12a22b9ee95f3570dd1932ae2272cfb28b4c9e73b49eb32a98d2f0", kill_on_drop: false }` [INFO] [stdout] 6db45f20ff12a22b9ee95f3570dd1932ae2272cfb28b4c9e73b49eb32a98d2f0