[INFO] cloning repository https://github.com/fietensen/tinydns [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fietensen/tinydns" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffietensen%2Ftinydns", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffietensen%2Ftinydns'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ced4de8e1b974fbaf6c5e8616c98b14280db6a27 [INFO] linting fietensen/tinydns against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffietensen%2Ftinydns" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fietensen/tinydns [INFO] finished tweaking git repo https://github.com/fietensen/tinydns [INFO] tweaked toml for git repo https://github.com/fietensen/tinydns written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fietensen/tinydns on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fietensen/tinydns already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded destructure_traitobject v0.2.0 [INFO] [stderr] Downloaded tokio-stream v0.1.16 [INFO] [stderr] Downloaded typemap-ors v1.0.0 [INFO] [stderr] Downloaded redox_syscall v0.5.9 [INFO] [stderr] Downloaded unsafe-any-ors v1.0.0 [INFO] [stderr] Downloaded log-mdc v0.1.0 [INFO] [stderr] Downloaded ordered-float v2.10.1 [INFO] [stderr] Downloaded thread-id v4.2.2 [INFO] [stderr] Downloaded either v1.14.0 [INFO] [stderr] Downloaded anyhow v1.0.96 [INFO] [stderr] Downloaded log4rs v1.3.0 [INFO] [stderr] Downloaded cc v1.2.7 [INFO] [stderr] Downloaded syn v2.0.94 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5cd449dce48db2cd2b9834fa0d5ab835f7927d4a3d6c823b24d8d5432383475a [INFO] running `Command { std: "docker" "start" "-a" "5cd449dce48db2cd2b9834fa0d5ab835f7927d4a3d6c823b24d8d5432383475a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5cd449dce48db2cd2b9834fa0d5ab835f7927d4a3d6c823b24d8d5432383475a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cd449dce48db2cd2b9834fa0d5ab835f7927d4a3d6c823b24d8d5432383475a", kill_on_drop: false }` [INFO] [stdout] 5cd449dce48db2cd2b9834fa0d5ab835f7927d4a3d6c823b24d8d5432383475a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 537cc1f40ec04744cc5c5794204613a9d330df169fd50d8f27bad288af8ade64 [INFO] running `Command { std: "docker" "start" "-a" "537cc1f40ec04744cc5c5794204613a9d330df169fd50d8f27bad288af8ade64", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling cc v1.2.7 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling pin-project-lite v0.2.15 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling once_cell v1.20.2 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling anyhow v1.0.96 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling tokio v1.42.0 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Compiling syn v2.0.94 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling tempfile v3.17.1 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling tokio-stream v0.1.16 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling zerofrom v0.1.5 [INFO] [stderr] Compiling yoke v0.7.5 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Compiling zerovec v0.10.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Compiling either v1.14.0 [INFO] [stderr] Compiling serde_json v1.0.139 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking sqlx-core v0.8.3 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking sqlx-sqlite v0.8.3 [INFO] [stderr] Compiling sqlx-macros-core v0.8.3 [INFO] [stderr] Compiling sqlx-macros v0.8.3 [INFO] [stderr] Checking sqlx v0.8.3 [INFO] [stderr] Checking tinydns v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `database::RecordEntity` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use database::RecordEntity; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `packet::RecordType` and `util` [INFO] [stdout] --> src/main.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | use protocol::{packet::RecordType, util}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `database::RecordEntity` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use database::RecordEntity; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `packet::RecordType` and `util` [INFO] [stdout] --> src/main.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | use protocol::{packet::RecordType, util}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::log` [INFO] [stdout] --> src/protocol/packet/builder.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use log::log; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::log` [INFO] [stdout] --> src/protocol/packet/builder.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use log::log; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `zone` [INFO] [stdout] --> src/resolver/resolver.rs:109:47 [INFO] [stdout] | [INFO] [stdout] 109 | pub async fn get_zoneauthority<'a>(&self, zone: String, config: &ServerConfig<'a>) -> AnswerEntry { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_zone` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/resolver/resolver.rs:109:61 [INFO] [stdout] | [INFO] [stdout] 109 | pub async fn get_zoneauthority<'a>(&self, zone: String, config: &ServerConfig<'a>) -> AnswerEntry { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `zone` [INFO] [stdout] --> src/resolver/resolver.rs:109:47 [INFO] [stdout] | [INFO] [stdout] 109 | pub async fn get_zoneauthority<'a>(&self, zone: String, config: &ServerConfig<'a>) -> AnswerEntry { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_zone` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/resolver/resolver.rs:109:61 [INFO] [stdout] | [INFO] [stdout] 109 | pub async fn get_zoneauthority<'a>(&self, zone: String, config: &ServerConfig<'a>) -> AnswerEntry { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `insert_record` is never used [INFO] [stdout] --> src/nameserver/nameserver.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 7 | impl<'a> Nameserver<'a> { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub async fn insert_record(&self, record: RecordEntity) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_name`, `with_qtype`, `with_qclass`, and `size` are never used [INFO] [stdout] --> src/protocol/packet/question.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Question { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 23 | pub fn with_name(mut self, name: String) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn with_qtype(mut self, qtype: u16) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub fn with_qclass(mut self, qclass: u16) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | pub fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `size`, `name`, `rtype`, `rclass`, `ttl`, and `rdata` are never used [INFO] [stdout] --> src/protocol/packet/resource_record.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl ResourceRecord { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 152 | pub fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | pub fn name(&self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 160 | pub fn rtype(&self) -> RecordType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn rclass(&self) -> u16 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn ttl(&self) -> u32 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | pub fn rdata(&self) -> Vec { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `with_fallback_server` is never used [INFO] [stdout] --> src/resolver/resolver.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Resolver { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 17 | pub fn with_fallback_server(mut self, server: (String, u16)) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_udp_port` and `with_listen_addr` are never used [INFO] [stdout] --> src/server/server_config.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | impl<'a> ServerConfig<'a> { [INFO] [stdout] | ------------------------- methods in this implementation [INFO] [stdout] 22 | pub fn with_udp_port(mut self, port: u16) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn with_listen_addr(mut self, addr: String) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `domain_name`, `priority`, `created_at`, `updated_at`, and `is_active` are never read [INFO] [stdout] --> src/database/record_query.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct RecordEntity { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 13 | id: u64, [INFO] [stdout] | ^^ [INFO] [stdout] 14 | domain_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | priority: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | created_at: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 20 | updated_at: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 21 | is_active: bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_domain_name`, `with_record_type`, `with_record_value`, `with_ttl`, and `with_priority` are never used [INFO] [stdout] --> src/database/record_query.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 88 | impl RecordEntity { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 111 | pub fn with_domain_name(mut self, domain_name: String) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 116 | pub fn with_record_type(mut self, record_type: RecordType) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | pub fn with_record_value(mut self, record_value: Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | pub fn with_ttl(mut self, ttl: u32) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn with_priority(mut self, priority: u32) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/nameserver/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod nameserver; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `size` is never used [INFO] [stdout] --> src/protocol/packet/question.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Question { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 106 | pub fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `size`, `name`, `rtype`, `rclass`, and `ttl` are never used [INFO] [stdout] --> src/protocol/packet/resource_record.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl ResourceRecord { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 152 | pub fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | pub fn name(&self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 160 | pub fn rtype(&self) -> RecordType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn rclass(&self) -> u16 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn ttl(&self) -> u32 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_get_upzone` is never used [INFO] [stdout] --> src/protocol/util.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | fn test_get_upzone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `with_fallback_server` is never used [INFO] [stdout] --> src/resolver/resolver.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Resolver { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 17 | pub fn with_fallback_server(mut self, server: (String, u16)) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nameserver/nameserver.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return res; [INFO] [stdout] 42 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_udp_port` and `with_listen_addr` are never used [INFO] [stdout] --> src/server/server_config.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | impl<'a> ServerConfig<'a> { [INFO] [stdout] | ------------------------- methods in this implementation [INFO] [stdout] 22 | pub fn with_udp_port(mut self, port: u16) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn with_listen_addr(mut self, addr: String) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `created_at`, `updated_at`, and `is_active` are never read [INFO] [stdout] --> src/database/record_query.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct RecordEntity { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 13 | id: u64, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 19 | created_at: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 20 | updated_at: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 21 | is_active: bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_ttl` and `with_priority` are never used [INFO] [stdout] --> src/database/record_query.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 88 | impl RecordEntity { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 126 | pub fn with_ttl(mut self, ttl: u32) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn with_priority(mut self, priority: u32) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/nameserver/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod nameserver; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded [INFO] [stdout] --> src/nameserver/nameserver.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | Some(record_query._fetch_one(self.db.get_pool(), self.db.config_dns_tbl()).await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Some` and `?` operator [INFO] [stdout] | [INFO] [stdout] 49 - Some(record_query._fetch_one(self.db.get_pool(), self.db.config_dns_tbl()).await?) [INFO] [stdout] 49 + record_query._fetch_one(self.db.get_pool(), self.db.config_dns_tbl()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nameserver/nameserver.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return res; [INFO] [stdout] 42 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded [INFO] [stdout] --> src/nameserver/nameserver.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | Some(record_query._fetch_one(self.db.get_pool(), self.db.config_dns_tbl()).await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Some` and `?` operator [INFO] [stdout] | [INFO] [stdout] 49 - Some(record_query._fetch_one(self.db.get_pool(), self.db.config_dns_tbl()).await?) [INFO] [stdout] 49 + record_query._fetch_one(self.db.get_pool(), self.db.config_dns_tbl()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/flags.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | NULL = 0, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/protocol/packet/flags.rs:97:44 [INFO] [stdout] | [INFO] [stdout] 97 | ((self.0 as u16) << 11) | self.1 | ((self.2 as u16) << 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((self.2 as u16))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/flags.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | NULL = 0, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/protocol/packet/flags.rs:97:44 [INFO] [stdout] | [INFO] [stdout] 97 | ((self.0 as u16) << 11) | self.1 | ((self.2 as u16) << 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((self.2 as u16))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/protocol/packet/mod.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | mod packet; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/protocol/packet/mod.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | mod packet; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:38:50 [INFO] [stdout] | [INFO] [stdout] 38 | let question = Question::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:44:54 [INFO] [stdout] | [INFO] [stdout] 44 | let answer = ResourceRecord::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:50:57 [INFO] [stdout] | [INFO] [stdout] 50 | let authority = ResourceRecord::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:38:50 [INFO] [stdout] | [INFO] [stdout] 38 | let question = Question::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:56:58 [INFO] [stdout] | [INFO] [stdout] 56 | let additional = ResourceRecord::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:44:54 [INFO] [stdout] | [INFO] [stdout] 44 | let answer = ResourceRecord::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:50:57 [INFO] [stdout] | [INFO] [stdout] 50 | let authority = ResourceRecord::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol/packet/packet.rs:56:58 [INFO] [stdout] | [INFO] [stdout] 56 | let additional = ResourceRecord::deserialize(&buffer, &mut offset)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CNAME` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CNAME, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOA` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | SOA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Soa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | NULL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WKS` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | WKS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Wks` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PTR` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | PTR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ptr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HINFO` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | HINFO, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Hinfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MINFO` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | MINFO, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Minfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXT` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | TXT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AAAA` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | AAAA = 28, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aaaa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTTPS` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | HTTPS = 65, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Https` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AXFR` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | AXFR = 252, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Axfr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAILB` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | MAILB, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Mailb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAILA` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | MAILA, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Maila` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BROADCAST` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | BROADCAST, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Broadcast` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CNAME` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CNAME, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOA` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | SOA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Soa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | NULL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WKS` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | WKS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Wks` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/protocol/packet/record_type.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl Into for RecordType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 58 ~ impl From for u16 { [INFO] [stdout] 59 ~ fn from(val: RecordType) -> Self { [INFO] [stdout] 60 ~ val as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PTR` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | PTR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ptr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HINFO` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | HINFO, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Hinfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MINFO` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | MINFO, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Minfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXT` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | TXT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AAAA` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | AAAA = 28, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aaaa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTTPS` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | HTTPS = 65, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Https` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AXFR` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | AXFR = 252, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Axfr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAILB` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | MAILB, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Mailb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAILA` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | MAILA, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Maila` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BROADCAST` contains a capitalized acronym [INFO] [stdout] --> src/protocol/packet/record_type.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | BROADCAST, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Broadcast` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/protocol/packet/record_type.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl Into for RecordType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 58 ~ impl From for u16 { [INFO] [stdout] 59 ~ fn from(val: RecordType) -> Self { [INFO] [stdout] 60 ~ val as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/protocol/util.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/protocol/util.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if part.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/resolver/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod resolver; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/resolver/resolver.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | Ok(packet_builder.build().serialize()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 48 - Ok(packet_builder.build().serialize()?) [INFO] [stdout] 48 + packet_builder.build().serialize() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/protocol/util.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/protocol/util.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if part.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolver/resolver.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 69 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolver/resolver.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 75 | if !packet.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `packet.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/resolver/resolver.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | answer_entry.resource = Some(answer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `protocol::answer::AnswerEntry { resource: Some(answer), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/resolver/resolver.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | let mut answer_entry = AnswerEntry::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/resolver/resolver.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | auth_entry.authority = Some(authority); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `protocol::answer::AnswerEntry { authority: Some(authority), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/resolver/resolver.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut auth_entry = AnswerEntry::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/resolver/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod resolver; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/resolver/resolver.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | Ok(packet_builder.build().serialize()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 48 - Ok(packet_builder.build().serialize()?) [INFO] [stdout] 48 + packet_builder.build().serialize() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolver/resolver.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 69 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolver/resolver.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 75 | if !packet.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `packet.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/resolver/resolver.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | answer_entry.resource = Some(answer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `protocol::answer::AnswerEntry { resource: Some(answer), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/resolver/resolver.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | let mut answer_entry = AnswerEntry::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/resolver/resolver.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | auth_entry.authority = Some(authority); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `protocol::answer::AnswerEntry { authority: Some(authority), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/resolver/resolver.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut auth_entry = AnswerEntry::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server/handle_packet.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 135 | if answer_records.len() > 0 || authorities.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!answer_records.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server/handle_packet.rs:135:36 [INFO] [stdout] | [INFO] [stdout] 135 | if answer_records.len() > 0 || authorities.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!authorities.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/serve.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if !packet_deserialized.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `packet_deserialized.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server/handle_packet.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 135 | if answer_records.len() > 0 || authorities.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!answer_records.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server/handle_packet.rs:135:36 [INFO] [stdout] | [INFO] [stdout] 135 | if answer_records.len() > 0 || authorities.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!authorities.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/serve.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if !packet_deserialized.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `packet_deserialized.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/database/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod database; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/database/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod database; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded [INFO] [stdout] --> src/database/record_query.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / Some( [INFO] [stdout] 61 | | builder.build_query_as().fetch_one(db).await.ok()? [INFO] [stdout] 62 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Some` and `?` operator [INFO] [stdout] | [INFO] [stdout] 60 - Some( [INFO] [stdout] 61 - builder.build_query_as().fetch_one(db).await.ok()? [INFO] [stdout] 62 - ) [INFO] [stdout] 60 + builder.build_query_as().fetch_one(db).await.ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded [INFO] [stdout] --> src/database/record_query.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / Some( [INFO] [stdout] 61 | | builder.build_query_as().fetch_one(db).await.ok()? [INFO] [stdout] 62 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Some` and `?` operator [INFO] [stdout] | [INFO] [stdout] 60 - Some( [INFO] [stdout] 61 - builder.build_query_as().fetch_one(db).await.ok()? [INFO] [stdout] 62 - ) [INFO] [stdout] 60 + builder.build_query_as().fetch_one(db).await.ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 56.84s [INFO] running `Command { std: "docker" "inspect" "537cc1f40ec04744cc5c5794204613a9d330df169fd50d8f27bad288af8ade64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "537cc1f40ec04744cc5c5794204613a9d330df169fd50d8f27bad288af8ade64", kill_on_drop: false }` [INFO] [stdout] 537cc1f40ec04744cc5c5794204613a9d330df169fd50d8f27bad288af8ade64