[INFO] cloning repository https://github.com/fhucek/driveinfo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fhucek/driveinfo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhucek%2Fdriveinfo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhucek%2Fdriveinfo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] af837c9190044e8850f280a3355c5ae9a23bb2bc [INFO] linting fhucek/driveinfo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhucek%2Fdriveinfo" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fhucek/driveinfo [INFO] finished tweaking git repo https://github.com/fhucek/driveinfo [INFO] tweaked toml for git repo https://github.com/fhucek/driveinfo written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fhucek/driveinfo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fhucek/driveinfo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_json v1.0.111 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bc2b956905cf42d58a82922fa6d5e84a5bdfc08ae26f6cee61743d6b8be82ad3 [INFO] running `Command { std: "docker" "start" "-a" "bc2b956905cf42d58a82922fa6d5e84a5bdfc08ae26f6cee61743d6b8be82ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bc2b956905cf42d58a82922fa6d5e84a5bdfc08ae26f6cee61743d6b8be82ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc2b956905cf42d58a82922fa6d5e84a5bdfc08ae26f6cee61743d6b8be82ad3", kill_on_drop: false }` [INFO] [stdout] bc2b956905cf42d58a82922fa6d5e84a5bdfc08ae26f6cee61743d6b8be82ad3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d406f2bc9f89e9b190af9b6003cc68459c204f10a65fefd9405f1b32d71f9f4f [INFO] running `Command { std: "docker" "start" "-a" "d406f2bc9f89e9b190af9b6003cc68459c204f10a65fefd9405f1b32d71f9f4f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking driveinfo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/driveinfo.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use console; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/driveinfo.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use console; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/driveinfo.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | newstring = newstring + " "; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `newstring += " "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/driveinfo.rs:111:10 [INFO] [stdout] | [INFO] [stdout] 111 | / match string_list.iter().map(|string| (**string).len() ).max() { [INFO] [stdout] 112 | | Some(val) => val, [INFO] [stdout] 113 | | None => 30 // 30 chars long default [INFO] [stdout] 114 | | } [INFO] [stdout] | |__________^ help: replace with: `string_list.iter().map(|string| (**string).len() ).max().unwrap_or(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/driveinfo.rs:130:66 [INFO] [stdout] | [INFO] [stdout] 130 | ... .filter(|string| *string != "") [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `newdriveinfo.get(0)` [INFO] [stdout] --> src/driveinfo.rs:134:26 [INFO] [stdout] | [INFO] [stdout] 134 | let fsname = newdriveinfo.get(0)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `newdriveinfo.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/driveinfo.rs:164:103 [INFO] [stdout] | [INFO] [stdout] 164 | ... !(**string).contains("Filesystem") && !((*string) == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `((*string) != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/driveinfo.rs:164:105 [INFO] [stdout] | [INFO] [stdout] 164 | ... !(**string).contains("Filesystem") && !((*string) == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/driveinfo.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | newstring = newstring + " "; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `newstring += " "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/driveinfo.rs:111:10 [INFO] [stdout] | [INFO] [stdout] 111 | / match string_list.iter().map(|string| (**string).len() ).max() { [INFO] [stdout] 112 | | Some(val) => val, [INFO] [stdout] 113 | | None => 30 // 30 chars long default [INFO] [stdout] 114 | | } [INFO] [stdout] | |__________^ help: replace with: `string_list.iter().map(|string| (**string).len() ).max().unwrap_or(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/driveinfo.rs:130:66 [INFO] [stdout] | [INFO] [stdout] 130 | ... .filter(|string| *string != "") [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `newdriveinfo.get(0)` [INFO] [stdout] --> src/driveinfo.rs:134:26 [INFO] [stdout] | [INFO] [stdout] 134 | let fsname = newdriveinfo.get(0)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `newdriveinfo.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/driveinfo.rs:164:103 [INFO] [stdout] | [INFO] [stdout] 164 | ... !(**string).contains("Filesystem") && !((*string) == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `((*string) != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/driveinfo.rs:164:105 [INFO] [stdout] | [INFO] [stdout] 164 | ... !(**string).contains("Filesystem") && !((*string) == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.00s [INFO] running `Command { std: "docker" "inspect" "d406f2bc9f89e9b190af9b6003cc68459c204f10a65fefd9405f1b32d71f9f4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d406f2bc9f89e9b190af9b6003cc68459c204f10a65fefd9405f1b32d71f9f4f", kill_on_drop: false }` [INFO] [stdout] d406f2bc9f89e9b190af9b6003cc68459c204f10a65fefd9405f1b32d71f9f4f