[INFO] cloning repository https://github.com/felipeamp/windmill [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/felipeamp/windmill" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelipeamp%2Fwindmill", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelipeamp%2Fwindmill'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d96a808429a7a8b5f475b03760ec482abab1d1ac [INFO] linting felipeamp/windmill against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelipeamp%2Fwindmill" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/felipeamp/windmill [INFO] finished tweaking git repo https://github.com/felipeamp/windmill [INFO] tweaked toml for git repo https://github.com/felipeamp/windmill written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/felipeamp/windmill on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/felipeamp/windmill already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21cf3b6d70dad31cbe30ea122e667a7cab0f4b72dedd3e00967f8cd5792388fa [INFO] running `Command { std: "docker" "start" "-a" "21cf3b6d70dad31cbe30ea122e667a7cab0f4b72dedd3e00967f8cd5792388fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21cf3b6d70dad31cbe30ea122e667a7cab0f4b72dedd3e00967f8cd5792388fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21cf3b6d70dad31cbe30ea122e667a7cab0f4b72dedd3e00967f8cd5792388fa", kill_on_drop: false }` [INFO] [stdout] 21cf3b6d70dad31cbe30ea122e667a7cab0f4b72dedd3e00967f8cd5792388fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd42313c2ecd11519bce9aa7c4dc750e4e1b594295b9c525b5e0ed53c5be36d9 [INFO] running `Command { std: "docker" "start" "-a" "fd42313c2ecd11519bce9aa7c4dc750e4e1b594295b9c525b5e0ed53c5be36d9", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking windmill v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `types::*` [INFO] [stdout] --> src/bitboard.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | use types::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/types.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | c @ 'a'...'h' => ret_u8 += c as u8 - b'a', [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/types.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 138 | c @ 'A'...'H' => ret_u8 += c as u8 - b'A', [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/types.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 142 | c @ '1'...'8' => ret_u8 += 8 * (c.to_digit(10).unwrap() as u8 - 1), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/types.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | c @ 'a'...'h' => ret_u8 += c as u8 - b'a', [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/types.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 138 | c @ 'A'...'H' => ret_u8 += c as u8 - b'A', [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/types.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 142 | c @ '1'...'8' => ret_u8 += 8 * (c.to_digit(10).unwrap() as u8 - 1), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `std::ascii::AsciiExt`: use inherent methods instead [INFO] [stdout] --> src/types.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `std::ascii::AsciiExt`: use inherent methods instead [INFO] [stdout] --> src/types.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ascii::AsciiExt` [INFO] [stdout] --> src/types.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/types.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | /// (may be lower or uppercase) and one number between '1' and '8'. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 127 | /// (may be lower or uppercase) and one number between '1' and '8'. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/types.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 285 | if (is_en_passent && is_castle) || (is_en_passent && is_promotion) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - if (is_en_passent && is_castle) || (is_en_passent && is_promotion) || [INFO] [stdout] 285 + if !(!is_en_passent || !is_castle && !is_promotion) || [INFO] [stdout] | [INFO] [stdout] 285 - if (is_en_passent && is_castle) || (is_en_passent && is_promotion) || [INFO] [stdout] 285 + if (is_promotion || is_castle) && is_en_passent || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/types.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | let castle_side: CastleSide; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `castle_side` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 236 ~ [INFO] [stdout] 237 ~ let castle_side: CastleSide = match panic::catch_unwind(|| self.castle_side()) { [INFO] [stdout] 238 ~ Ok(temp_cs) => temp_cs, [INFO] [stdout] 239 | Err(_) => return false, [INFO] [stdout] 240 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:351:34 [INFO] [stdout] | [INFO] [stdout] 351 | self.sq_from().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:352:32 [INFO] [stdout] | [INFO] [stdout] 352 | self.sq_to().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:353:41 [INFO] [stdout] | [INFO] [stdout] 353 | self.promoted_piece().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 357 | self.sq_from().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:358:32 [INFO] [stdout] | [INFO] [stdout] 358 | self.sq_to().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:362:34 [INFO] [stdout] | [INFO] [stdout] 362 | self.sq_from().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:363:32 [INFO] [stdout] | [INFO] [stdout] 363 | self.sq_to().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ascii::AsciiExt` [INFO] [stdout] --> src/types.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | piece => panic!(format!("Invalid promoted piece: {}", piece)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 217 - piece => panic!(format!("Invalid promoted piece: {}", piece)), [INFO] [stdout] 217 + piece => panic!("Invalid promoted piece: {}", piece), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types.rs:324:28 [INFO] [stdout] | [INFO] [stdout] 324 | file => panic!(format!("Illegal file in castle move: {}", file)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 324 - file => panic!(format!("Illegal file in castle move: {}", file)), [INFO] [stdout] 324 + file => panic!("Illegal file in castle move: {}", file), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 337 | promotion => {panic!(format!("Wrong promotion value after shift and bitwise-and: {}", [INFO] [stdout] | __________________________________^ [INFO] [stdout] 338 | | promotion)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 337 ~ promotion => {panic!("Wrong promotion value after shift and bitwise-and: {}", [INFO] [stdout] 338 ~ promotion) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/types.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | /// (may be lower or uppercase) and one number between '1' and '8'. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 127 | /// (may be lower or uppercase) and one number between '1' and '8'. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/types.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 285 | if (is_en_passent && is_castle) || (is_en_passent && is_promotion) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - if (is_en_passent && is_castle) || (is_en_passent && is_promotion) || [INFO] [stdout] 285 + if !(!is_en_passent || !is_castle && !is_promotion) || [INFO] [stdout] | [INFO] [stdout] 285 - if (is_en_passent && is_castle) || (is_en_passent && is_promotion) || [INFO] [stdout] 285 + if (is_promotion || is_castle) && is_en_passent || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/types.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | let castle_side: CastleSide; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `castle_side` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 236 ~ [INFO] [stdout] 237 ~ let castle_side: CastleSide = match panic::catch_unwind(|| self.castle_side()) { [INFO] [stdout] 238 ~ Ok(temp_cs) => temp_cs, [INFO] [stdout] 239 | Err(_) => return false, [INFO] [stdout] 240 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:351:34 [INFO] [stdout] | [INFO] [stdout] 351 | self.sq_from().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:352:32 [INFO] [stdout] | [INFO] [stdout] 352 | self.sq_to().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:353:41 [INFO] [stdout] | [INFO] [stdout] 353 | self.promoted_piece().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 357 | self.sq_from().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:358:32 [INFO] [stdout] | [INFO] [stdout] 358 | self.sq_to().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:362:34 [INFO] [stdout] | [INFO] [stdout] 362 | self.sq_from().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/types.rs:363:32 [INFO] [stdout] | [INFO] [stdout] 363 | self.sq_to().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/types.rs:482:25 [INFO] [stdout] | [INFO] [stdout] 482 | Move(0u16 | (1u16 << 6))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((1u16 << 6))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/types.rs:548:25 [INFO] [stdout] | [INFO] [stdout] 548 | Move((0u16 + 48u16) | ((0u16 + 56u16) << 6) | PROMOTION_FLAG)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `48u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/types.rs:548:43 [INFO] [stdout] | [INFO] [stdout] 548 | Move((0u16 + 48u16) | ((0u16 + 56u16) << 6) | PROMOTION_FLAG)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `56u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/types.rs:555:42 [INFO] [stdout] | [INFO] [stdout] 555 | Move((1u16 + 8u16) | ((1u16 + 0u16) << 6) | (0b01 << 12) | PROMOTION_FLAG)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `1u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/types.rs:562:25 [INFO] [stdout] | [INFO] [stdout] 562 | Move((0u16 + 48u16) | ((1u16 + 56u16) << 6) | (0b10 << 12) | PROMOTION_FLAG)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `48u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/types.rs:569:42 [INFO] [stdout] | [INFO] [stdout] 569 | Move((1u16 + 8u16) | ((2u16 + 0u16) << 6) | (0b11 << 12) | PROMOTION_FLAG)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `2u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | piece => panic!(format!("Invalid promoted piece: {}", piece)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 217 - piece => panic!(format!("Invalid promoted piece: {}", piece)), [INFO] [stdout] 217 + piece => panic!("Invalid promoted piece: {}", piece), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types.rs:324:28 [INFO] [stdout] | [INFO] [stdout] 324 | file => panic!(format!("Illegal file in castle move: {}", file)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 324 - file => panic!(format!("Illegal file in castle move: {}", file)), [INFO] [stdout] 324 + file => panic!("Illegal file in castle move: {}", file), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 337 | promotion => {panic!(format!("Wrong promotion value after shift and bitwise-and: {}", [INFO] [stdout] | __________________________________^ [INFO] [stdout] 338 | | promotion)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 337 ~ promotion => {panic!("Wrong promotion value after shift and bitwise-and: {}", [INFO] [stdout] 338 ~ promotion) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `Command { std: "docker" "inspect" "fd42313c2ecd11519bce9aa7c4dc750e4e1b594295b9c525b5e0ed53c5be36d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd42313c2ecd11519bce9aa7c4dc750e4e1b594295b9c525b5e0ed53c5be36d9", kill_on_drop: false }` [INFO] [stdout] fd42313c2ecd11519bce9aa7c4dc750e4e1b594295b9c525b5e0ed53c5be36d9