[INFO] cloning repository https://github.com/feadoor/cryptopals [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/feadoor/cryptopals" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffeadoor%2Fcryptopals", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffeadoor%2Fcryptopals'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 393c0ebb4dddde4b2ccc1286c8ee846b8ab6d1b5 [INFO] linting feadoor/cryptopals/393c0ebb4dddde4b2ccc1286c8ee846b8ab6d1b5 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffeadoor%2Fcryptopals" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/feadoor/cryptopals [INFO] finished tweaking git repo https://github.com/feadoor/cryptopals [INFO] tweaked toml for git repo https://github.com/feadoor/cryptopals written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/feadoor/cryptopals on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/feadoor/cryptopals already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 305cebd1e5c55e7bafe1ec28d447fde7c4467def0731ed9f2c53e85ae85b9dce [INFO] running `Command { std: "docker" "start" "-a" "305cebd1e5c55e7bafe1ec28d447fde7c4467def0731ed9f2c53e85ae85b9dce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "305cebd1e5c55e7bafe1ec28d447fde7c4467def0731ed9f2c53e85ae85b9dce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "305cebd1e5c55e7bafe1ec28d447fde7c4467def0731ed9f2c53e85ae85b9dce", kill_on_drop: false }` [INFO] [stdout] 305cebd1e5c55e7bafe1ec28d447fde7c4467def0731ed9f2c53e85ae85b9dce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9c65078e8502b8564f654c0f601a1dbc687bb16d489ea6cdff52a99e8cca784 [INFO] running `Command { std: "docker" "start" "-a" "d9c65078e8502b8564f654c0f601a1dbc687bb16d489ea6cdff52a99e8cca784", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.15 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/challenges/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | try!(write!(f, "\n{}\n", Green.bold().paint(long_desc))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/challenges/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | try!(write!(f, "\n{}: {}\n", Cyan.bold().paint(key.to_string()), value)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/aes.rs:659:13 [INFO] [stdout] | [INFO] [stdout] 659 | round_keys: round_keys, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `round_keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/aes.rs:660:13 [INFO] [stdout] | [INFO] [stdout] 660 | inv_round_keys: inv_round_keys, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inv_round_keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/challenges/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | try!(write!(f, "\n{}\n", Green.bold().paint(long_desc))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/challenges/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | try!(write!(f, "\n{}: {}\n", Cyan.bold().paint(key.to_string()), value)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/null.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | NullCipher { block_size: block_size } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:137:29 [INFO] [stdout] | [INFO] [stdout] 137 | ... mode: mode, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | ... padding: padding, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | mode: mode, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | padding: padding, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/utils/block/mod.rs:167:20 [INFO] [stdout] | [INFO] [stdout] 167 | let data = try!(match self.mode { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/data.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | Data { bytes: bytes } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/data.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | 0 => Ok(Data { bytes: bytes }), [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/data.rs:150:21 [INFO] [stdout] | [INFO] [stdout] 150 | b'A'...b'Z' => next_bytes |= (ch - b'A') as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/data.rs:151:21 [INFO] [stdout] | [INFO] [stdout] 151 | b'a'...b'z' => next_bytes |= (ch - b'a' + 26) as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/data.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | b'0'...b'9' => next_bytes |= (ch - b'0' + 52) as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/data.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | Ok(Data { bytes: bytes }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/metrics.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | 0x21...0x40 => score += 0.5, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/metrics.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | 0x00...0x08 | 0x14...0x1F => score += -10.0, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/metrics.rs:77:31 [INFO] [stdout] | [INFO] [stdout] 77 | 0x00...0x08 | 0x14...0x1F => score += -10.0, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | block: block, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | suffix: suffix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:165:26 [INFO] [stdout] | [INFO] [stdout] 165 | EcbUserProfile { block: block } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | block: block, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | prefix: prefix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | suffix: suffix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:306:21 [INFO] [stdout] | [INFO] [stdout] 306 | CbcCookie { block: block } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/victims/block.rs:327:22 [INFO] [stdout] | [INFO] [stdout] 327 | let target = &[b';', b'a', b'd', b'm', b'i', b'n', b'=', b't', b'r', b'u', b'e', b';']; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b";admin=true;"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/aes.rs:659:13 [INFO] [stdout] | [INFO] [stdout] 659 | round_keys: round_keys, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `round_keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/aes.rs:660:13 [INFO] [stdout] | [INFO] [stdout] 660 | inv_round_keys: inv_round_keys, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inv_round_keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/null.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | NullCipher { block_size: block_size } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:137:29 [INFO] [stdout] | [INFO] [stdout] 137 | ... mode: mode, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | ... padding: padding, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | mode: mode, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/block/mod.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | padding: padding, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/utils/block/mod.rs:167:20 [INFO] [stdout] | [INFO] [stdout] 167 | let data = try!(match self.mode { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/data.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | Data { bytes: bytes } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/data.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | 0 => Ok(Data { bytes: bytes }), [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils/block/mod.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | cipher: Box, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 116 | cipher: Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/data.rs:150:21 [INFO] [stdout] | [INFO] [stdout] 150 | b'A'...b'Z' => next_bytes |= (ch - b'A') as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/data.rs:151:21 [INFO] [stdout] | [INFO] [stdout] 151 | b'a'...b'z' => next_bytes |= (ch - b'a' + 26) as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/data.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | b'0'...b'9' => next_bytes |= (ch - b'0' + 52) as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/data.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | Ok(Data { bytes: bytes }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/metrics.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | 0x21...0x40 => score += 0.5, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/metrics.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | 0x00...0x08 | 0x14...0x1F => score += -10.0, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/utils/metrics.rs:77:31 [INFO] [stdout] | [INFO] [stdout] 77 | 0x00...0x08 | 0x14...0x1F => score += -10.0, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | block: block, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | suffix: suffix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:165:26 [INFO] [stdout] | [INFO] [stdout] 165 | EcbUserProfile { block: block } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | block: block, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | prefix: prefix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | suffix: suffix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/victims/block.rs:306:21 [INFO] [stdout] | [INFO] [stdout] 306 | CbcCookie { block: block } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/victims/block.rs:327:22 [INFO] [stdout] | [INFO] [stdout] 327 | let target = &[b';', b'a', b'd', b'm', b'i', b'n', b'=', b't', b'r', b'u', b'e', b';']; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b";admin=true;"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils/block/mod.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | cipher: Box, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 116 | cipher: Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/challenges/helpers.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / match pkcs7_unpad(data) { [INFO] [stdout] 37 | | Err(DecryptError::Padding) => false, [INFO] [stdout] 38 | | _ => true, [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 36 - match pkcs7_unpad(data) { [INFO] [stdout] 37 - Err(DecryptError::Padding) => false, [INFO] [stdout] 38 - _ => true, [INFO] [stdout] 39 - } [INFO] [stdout] 36 + !matches!(pkcs7_unpad(data), Err(DecryptError::Padding)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let file = File::open(&Path::new("input/set1challenge4.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge4.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/challenges/helpers.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / match pkcs7_unpad(data) { [INFO] [stdout] 37 | | Err(DecryptError::Padding) => false, [INFO] [stdout] 38 | | _ => true, [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 36 - match pkcs7_unpad(data) { [INFO] [stdout] 37 - Err(DecryptError::Padding) => false, [INFO] [stdout] 38 - _ => true, [INFO] [stdout] 39 - } [INFO] [stdout] 36 + !matches!(pkcs7_unpad(data), Err(DecryptError::Padding)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:201:27 [INFO] [stdout] | [INFO] [stdout] 201 | let file = File::open(&Path::new("input/set1challenge6.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge6.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:239:27 [INFO] [stdout] | [INFO] [stdout] 239 | let file = File::open(&Path::new("input/set1challenge7.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge7.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:280:27 [INFO] [stdout] | [INFO] [stdout] 280 | let file = File::open(&Path::new("input/set1challenge8.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge8.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let file = File::open(&Path::new("input/set1challenge4.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge4.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:201:27 [INFO] [stdout] | [INFO] [stdout] 201 | let file = File::open(&Path::new("input/set1challenge6.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge6.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set2.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let file = File::open(&Path::new("input/set2challenge10.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set2challenge10.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:239:27 [INFO] [stdout] | [INFO] [stdout] 239 | let file = File::open(&Path::new("input/set1challenge7.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge7.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set1.rs:280:27 [INFO] [stdout] | [INFO] [stdout] 280 | let file = File::open(&Path::new("input/set1challenge8.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set1challenge8.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/challenges/mod.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | for &(ref key, ref value) in &self.outputs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 33 - for &(ref key, ref value) in &self.outputs { [INFO] [stdout] 33 + for (key, value) in &self.outputs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/challenges/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | assert!(false, "The key is not present"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/challenges/mod.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | for &(ref key, ref value) in &self.outputs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 45 - for &(ref key, ref value) in &self.outputs { [INFO] [stdout] 45 + for (key, value) in &self.outputs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/challenges/set2.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let file = File::open(&Path::new("input/set2challenge10.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("input/set2challenge10.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/challenges/mod.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert!(false, "The key is not present"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/challenges/mod.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | for &(ref key, ref value) in &self.outputs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 63 - for &(ref key, ref value) in &self.outputs { [INFO] [stdout] 63 + for (key, value) in &self.outputs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/challenges/mod.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | for &(ref key, ref value) in &self.outputs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 33 - for &(ref key, ref value) in &self.outputs { [INFO] [stdout] 33 + for (key, value) in &self.outputs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/challenges/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | assert!(false, "The key is not present"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/challenges/mod.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | for &(ref key, ref value) in &self.outputs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 45 - for &(ref key, ref value) in &self.outputs { [INFO] [stdout] 45 + for (key, value) in &self.outputs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/challenges/mod.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert!(false, "The key is not present"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/challenges/mod.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | for &(ref key, ref value) in &self.outputs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 63 - for &(ref key, ref value) in &self.outputs { [INFO] [stdout] 63 + for (key, value) in &self.outputs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/utils/block/aes.rs:696:13 [INFO] [stdout] | [INFO] [stdout] 696 | / for ix in 0..4 { [INFO] [stdout] 697 | | state[ix] = dummy[ix]; [INFO] [stdout] 698 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `state[..4].copy_from_slice(&dummy[..4]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/utils/block/aes.rs:745:13 [INFO] [stdout] | [INFO] [stdout] 745 | / for ix in 0..4 { [INFO] [stdout] 746 | | state[ix] = dummy[ix]; [INFO] [stdout] 747 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `state[..4].copy_from_slice(&dummy[..4]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/utils/block/mod.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | if data.len() % self.cipher.block_size() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!data.len().is_multiple_of(self.cipher.block_size())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/utils/block/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 251 | if data.len() % self.cipher.block_size() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!data.len().is_multiple_of(self.cipher.block_size())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/utils/block/aes.rs:696:13 [INFO] [stdout] | [INFO] [stdout] 696 | / for ix in 0..4 { [INFO] [stdout] 697 | | state[ix] = dummy[ix]; [INFO] [stdout] 698 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `state[..4].copy_from_slice(&dummy[..4]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/utils/block/aes.rs:745:13 [INFO] [stdout] | [INFO] [stdout] 745 | / for ix in 0..4 { [INFO] [stdout] 746 | | state[ix] = dummy[ix]; [INFO] [stdout] 747 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `state[..4].copy_from_slice(&dummy[..4]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/utils/data.rs:252:48 [INFO] [stdout] | [INFO] [stdout] 252 | let mut out_chars = Vec::with_capacity((self.bytes.len() + 2) / 3 * 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.bytes.len().div_ceil(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/utils/block/mod.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | if data.len() % self.cipher.block_size() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!data.len().is_multiple_of(self.cipher.block_size())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/utils/block/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 251 | if data.len() % self.cipher.block_size() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!data.len().is_multiple_of(self.cipher.block_size())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/utils/data.rs:252:48 [INFO] [stdout] | [INFO] [stdout] 252 | let mut out_chars = Vec::with_capacity((self.bytes.len() + 2) / 3 * 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.bytes.len().div_ceil(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/victims/block.rs:198:20 [INFO] [stdout] | [INFO] [stdout] 198 | if let Some(_) = keyval.next() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if keyval.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/victims/block.rs:216:19 [INFO] [stdout] | [INFO] [stdout] 216 | pairs.get(&"role".to_string()) == Some(&"admin".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `"role"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CbcCookie` [INFO] [stdout] --> src/victims/block.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 298 | / pub fn new() -> CbcCookie { [INFO] [stdout] 299 | | let key = Data::random(16); [INFO] [stdout] 300 | | let iv = Data::random(16); [INFO] [stdout] 301 | | let block = BlockCipher::new(Algorithms::Aes, [INFO] [stdout] ... | [INFO] [stdout] 306 | | CbcCookie { block: block } [INFO] [stdout] 307 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 296 + impl Default for CbcCookie { [INFO] [stdout] 297 + fn default() -> Self { [INFO] [stdout] 298 + Self::new() [INFO] [stdout] 299 + } [INFO] [stdout] 300 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils/block/aes.rs:671:25 [INFO] [stdout] | [INFO] [stdout] 671 | let mut dummy = vec![0, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0, 0, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils/block/aes.rs:720:25 [INFO] [stdout] | [INFO] [stdout] 720 | let mut dummy = vec![0, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0, 0, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/victims/block.rs:198:20 [INFO] [stdout] | [INFO] [stdout] 198 | if let Some(_) = keyval.next() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if keyval.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/victims/block.rs:216:19 [INFO] [stdout] | [INFO] [stdout] 216 | pairs.get(&"role".to_string()) == Some(&"admin".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `"role"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CbcCookie` [INFO] [stdout] --> src/victims/block.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 298 | / pub fn new() -> CbcCookie { [INFO] [stdout] 299 | | let key = Data::random(16); [INFO] [stdout] 300 | | let iv = Data::random(16); [INFO] [stdout] 301 | | let block = BlockCipher::new(Algorithms::Aes, [INFO] [stdout] ... | [INFO] [stdout] 306 | | CbcCookie { block: block } [INFO] [stdout] 307 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 296 + impl Default for CbcCookie { [INFO] [stdout] 297 + fn default() -> Self { [INFO] [stdout] 298 + Self::new() [INFO] [stdout] 299 + } [INFO] [stdout] 300 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils/block/aes.rs:671:25 [INFO] [stdout] | [INFO] [stdout] 671 | let mut dummy = vec![0, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0, 0, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils/block/aes.rs:720:25 [INFO] [stdout] | [INFO] [stdout] 720 | let mut dummy = vec![0, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0, 0, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `Command { std: "docker" "inspect" "d9c65078e8502b8564f654c0f601a1dbc687bb16d489ea6cdff52a99e8cca784", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9c65078e8502b8564f654c0f601a1dbc687bb16d489ea6cdff52a99e8cca784", kill_on_drop: false }` [INFO] [stdout] d9c65078e8502b8564f654c0f601a1dbc687bb16d489ea6cdff52a99e8cca784