[INFO] cloning repository https://github.com/fdw/git-zoxide [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fdw/git-zoxide" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffdw%2Fgit-zoxide", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffdw%2Fgit-zoxide'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 02a4d8f0b1f62fe112a762aadc1f93f1919332cf [INFO] linting fdw/git-zoxide against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffdw%2Fgit-zoxide" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fdw/git-zoxide [INFO] finished tweaking git repo https://github.com/fdw/git-zoxide [INFO] tweaked toml for git repo https://github.com/fdw/git-zoxide written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fdw/git-zoxide on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fdw/git-zoxide already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6d6ba94fe9c45597d2db839c6e0f77efcdfc9a17395d306b5ceab318b827c95 [INFO] running `Command { std: "docker" "start" "-a" "b6d6ba94fe9c45597d2db839c6e0f77efcdfc9a17395d306b5ceab318b827c95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6d6ba94fe9c45597d2db839c6e0f77efcdfc9a17395d306b5ceab318b827c95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6d6ba94fe9c45597d2db839c6e0f77efcdfc9a17395d306b5ceab318b827c95", kill_on_drop: false }` [INFO] [stdout] b6d6ba94fe9c45597d2db839c6e0f77efcdfc9a17395d306b5ceab318b827c95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41ffcc1e949a071553122903b07bc968449d569f551842353fa9aabd71458b41 [INFO] running `Command { std: "docker" "start" "-a" "41ffcc1e949a071553122903b07bc968449d569f551842353fa9aabd71458b41", kill_on_drop: false }` [INFO] [stderr] Checking git-zoxide v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matcher.rs:26:36 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn match_branch_name(haystack: &Vec<&str>, needles: &Vec<&str>) -> f64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn match_branch_name(haystack: &Vec<&str>, needles: &Vec<&str>) -> f64 { [INFO] [stdout] 26 + pub fn match_branch_name(haystack: &[&str], needles: &Vec<&str>) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/matcher.rs:56:32 [INFO] [stdout] | [INFO] [stdout] 56 | if needle.chars().all(|it| it.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `it.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !best_local_match.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `best_local_match.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `best_local_match` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 19 | if !best_local_match.is_none() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] 20 | switch_to_branch(best_local_match.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/main.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if args.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matcher.rs:26:36 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn match_branch_name(haystack: &Vec<&str>, needles: &Vec<&str>) -> f64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn match_branch_name(haystack: &Vec<&str>, needles: &Vec<&str>) -> f64 { [INFO] [stdout] 26 + pub fn match_branch_name(haystack: &[&str], needles: &Vec<&str>) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/matcher.rs:56:32 [INFO] [stdout] | [INFO] [stdout] 56 | if needle.chars().all(|it| it.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `it.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !best_local_match.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `best_local_match.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `best_local_match` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 19 | if !best_local_match.is_none() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] 20 | switch_to_branch(best_local_match.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/main.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if args.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "41ffcc1e949a071553122903b07bc968449d569f551842353fa9aabd71458b41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41ffcc1e949a071553122903b07bc968449d569f551842353fa9aabd71458b41", kill_on_drop: false }` [INFO] [stdout] 41ffcc1e949a071553122903b07bc968449d569f551842353fa9aabd71458b41