[INFO] cloning repository https://github.com/fdavies93/rusty-rogue [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fdavies93/rusty-rogue" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffdavies93%2Frusty-rogue", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffdavies93%2Frusty-rogue'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d8699761816f2234cc5cc99c28b365e611d9b9aa [INFO] linting fdavies93/rusty-rogue against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffdavies93%2Frusty-rogue" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fdavies93/rusty-rogue [INFO] finished tweaking git repo https://github.com/fdavies93/rusty-rogue [INFO] tweaked toml for git repo https://github.com/fdavies93/rusty-rogue written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fdavies93/rusty-rogue on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fdavies93/rusty-rogue already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.64 [INFO] [stderr] Downloaded itoa v1.0.8 [INFO] [stderr] Downloaded serde_json v1.0.102 [INFO] [stderr] Downloaded ryu v1.0.14 [INFO] [stderr] Downloaded unicode-ident v1.0.10 [INFO] [stderr] Downloaded quote v1.0.29 [INFO] [stderr] Downloaded serde_derive v1.0.171 [INFO] [stderr] Downloaded serde v1.0.171 [INFO] [stderr] Downloaded syn v2.0.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf9157fd4701059f164dd5b73ee5e8202dea4180503477be773a40e777ada329 [INFO] running `Command { std: "docker" "start" "-a" "cf9157fd4701059f164dd5b73ee5e8202dea4180503477be773a40e777ada329", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf9157fd4701059f164dd5b73ee5e8202dea4180503477be773a40e777ada329", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf9157fd4701059f164dd5b73ee5e8202dea4180503477be773a40e777ada329", kill_on_drop: false }` [INFO] [stdout] cf9157fd4701059f164dd5b73ee5e8202dea4180503477be773a40e777ada329 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57c74cc3004c25a5a584e5bd4be718d7a1720b24b3df7a749e1fecb1f68fa30c [INFO] running `Command { std: "docker" "start" "-a" "57c74cc3004c25a5a584e5bd4be718d7a1720b24b3df7a749e1fecb1f68fa30c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.102 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking time v0.3.23 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking ratatui v0.21.0 [INFO] [stderr] Checking rusty-rogue v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/main.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::{Context, Result, Error}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Paragraph` and `canvas::Map` [INFO] [stdout] --> src/main.rs:8:52 [INFO] [stdout] | [INFO] [stdout] 8 | use ratatui::{backend::CrosstermBackend, widgets::{Paragraph, canvas::Map}, Terminal, layout::Rect}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `collections::HashMap`, `self`, and `time::Duration` [INFO] [stdout] --> src/main.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | io::{self, Stdout}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 11 | time::Duration, collections::HashMap, str::FromStr, [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Event` and `self` [INFO] [stdout] --> src/main.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | event::{self, Event, KeyCode}, [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `collections::HashMap`, `hash::Hash`, and `ptr` [INFO] [stdout] --> src/rterm.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | time::Duration, collections::HashMap, hash::Hash, ptr, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/rterm.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 72 | let comps = match (comp_option) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 72 - let comps = match (comp_option) { [INFO] [stdout] 72 + let comps = match comp_option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/rterm.rs:183:1 [INFO] [stdout] | [INFO] [stdout] 183 | / /// draws a greeting. [INFO] [stdout] ... | [INFO] [stdout] 187 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 192 | pub fn poll() -> Result { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `poll` then comment it out [INFO] [stdout] | [INFO] [stdout] 182 ~ // /// Render the application. This is where you would draw the application UI. This example just [INFO] [stdout] 183 ~ // /// draws a greeting. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::events::GameEvent` [INFO] [stdout] --> src/game.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::events::GameEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deserialize` [INFO] [stdout] --> src/components/component.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use serde::{Serialize, Deserialize}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/components/tile_map.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | size: size [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/components/monitor.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/events.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InputData` [INFO] [stdout] --> src/scripts/on_hit.rs:2:42 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::events::{GameEvent, Listener, InputData, HitData}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crossterm::event::KeyCode` [INFO] [stdout] --> src/scripts/on_hit.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crossterm::event::KeyCode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TileMap`, `TileType`, and `WorldPosition` [INFO] [stdout] --> src/scripts/on_hit.rs:4:25 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::components::{WorldPosition, TileMap, TileType, Health}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ratatui::text::Text` [INFO] [stdout] --> src/scripts/update_health.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use ratatui::text::Text; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::stringify` [INFO] [stdout] --> src/scripts/update_health.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::stringify; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TickData` [INFO] [stdout] --> src/scripts/update_health.rs:5:42 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::events::{GameEvent, Listener, TickData}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ScreenPosition` and `Vector2` [INFO] [stdout] --> src/scripts/update_health.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::components::{ScreenPosition, Monitor, TextBox, Vector2, Health}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/main.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::{Context, Result, Error}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Paragraph` and `canvas::Map` [INFO] [stdout] --> src/main.rs:8:52 [INFO] [stdout] | [INFO] [stdout] 8 | use ratatui::{backend::CrosstermBackend, widgets::{Paragraph, canvas::Map}, Terminal, layout::Rect}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `collections::HashMap`, `self`, and `time::Duration` [INFO] [stdout] --> src/main.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | io::{self, Stdout}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 11 | time::Duration, collections::HashMap, str::FromStr, [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Event` and `self` [INFO] [stdout] --> src/main.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | event::{self, Event, KeyCode}, [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `collections::HashMap`, `hash::Hash`, and `ptr` [INFO] [stdout] --> src/rterm.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | time::Duration, collections::HashMap, hash::Hash, ptr, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/rterm.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 72 | let comps = match (comp_option) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 72 - let comps = match (comp_option) { [INFO] [stdout] 72 + let comps = match comp_option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/rterm.rs:183:1 [INFO] [stdout] | [INFO] [stdout] 183 | / /// draws a greeting. [INFO] [stdout] ... | [INFO] [stdout] 187 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 192 | pub fn poll() -> Result { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `poll` then comment it out [INFO] [stdout] | [INFO] [stdout] 182 ~ // /// Render the application. This is where you would draw the application UI. This example just [INFO] [stdout] 183 ~ // /// draws a greeting. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::events::GameEvent` [INFO] [stdout] --> src/game.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::events::GameEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deserialize` [INFO] [stdout] --> src/components/component.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use serde::{Serialize, Deserialize}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/components/tile_map.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | size: size [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/components/monitor.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/events.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InputData` [INFO] [stdout] --> src/scripts/on_hit.rs:2:42 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::events::{GameEvent, Listener, InputData, HitData}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crossterm::event::KeyCode` [INFO] [stdout] --> src/scripts/on_hit.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crossterm::event::KeyCode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TileMap`, `TileType`, and `WorldPosition` [INFO] [stdout] --> src/scripts/on_hit.rs:4:25 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::components::{WorldPosition, TileMap, TileType, Health}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ratatui::text::Text` [INFO] [stdout] --> src/scripts/update_health.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use ratatui::text::Text; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::stringify` [INFO] [stdout] --> src/scripts/update_health.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::stringify; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TickData` [INFO] [stdout] --> src/scripts/update_health.rs:5:42 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::events::{GameEvent, Listener, TickData}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ScreenPosition` and `Vector2` [INFO] [stdout] --> src/scripts/update_health.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::components::{ScreenPosition, Monitor, TextBox, Vector2, Health}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rterm.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | let mut glyphs = { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rterm.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut glyph_positions = { [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rterm.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let mut text_positions = { [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ev` [INFO] [stdout] --> src/scripts/update_health.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn update_health(game: &mut GameManager, ev : &GameEvent, listener : &Listener) -> Vec { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ev` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | let mut cur_tick: u16 = 0; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/rterm.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn assemble_render(game : &mut GameManager) -> Box>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rterm.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if comps.len() == 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `comps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/rterm.rs:87:30 [INFO] [stdout] | [INFO] [stdout] 87 | serde_json::from_str(&maps[0].data.as_str()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `maps[0].data.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rterm.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 125 | if comps.len() == 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `comps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rterm.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | let mut glyphs = { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rterm.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut glyph_positions = { [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rterm.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let mut text_positions = { [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return Self { [INFO] [stdout] 20 | | next_id: 0, [INFO] [stdout] 21 | | // event_queue: GameEventQueue::new(), [INFO] [stdout] 22 | | components: HashMap::new(), [INFO] [stdout] 23 | | components_by_obj: HashMap::new(), [INFO] [stdout] 24 | | components_by_type: HashMap::new() [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Self { [INFO] [stdout] 20 + next_id: 0, [INFO] [stdout] 21 + // event_queue: GameEventQueue::new(), [INFO] [stdout] 22 + components: HashMap::new(), [INFO] [stdout] 23 + components_by_obj: HashMap::new(), [INFO] [stdout] 24 + components_by_type: HashMap::new() [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `by_type` after checking its variant with `is_none` [INFO] [stdout] --> src/game.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 118 | if by_type.is_none() || by_obj.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 122 | let by_type = by_type.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `by_obj` after checking its variant with `is_none` [INFO] [stdout] --> src/game.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 118 | if by_type.is_none() || by_obj.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 123 | let by_obj = by_obj.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 141 | None => return Option::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - None => return Option::None, [INFO] [stdout] 141 + None => Option::None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/component.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return serde_json::from_str(self.data.as_str()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return serde_json::from_str(self.data.as_str()).unwrap(); [INFO] [stdout] 31 + serde_json::from_str(self.data.as_str()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOOR` contains a capitalized acronym [INFO] [stdout] --> src/components/tile_map.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FLOOR, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Floor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WALL` contains a capitalized acronym [INFO] [stdout] --> src/components/tile_map.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | WALL [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wall` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/tile_map.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return tiles; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return tiles; [INFO] [stdout] 45 + tiles [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/tile_map.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return self.tiles[usize::from(pos.0)][usize::from(pos.1)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return self.tiles[usize::from(pos.0)][usize::from(pos.1)]; [INFO] [stdout] 49 + self.tiles[usize::from(pos.0)][usize::from(pos.1)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/tile_map.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return self.size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return self.size; [INFO] [stdout] 53 + self.size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/tile_map.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | if filled || (!filled && ( [INFO] [stdout] | ____________________^ [INFO] [stdout] 67 | | (x+1 == real_pos.right()) || [INFO] [stdout] 68 | | (x == real_pos.left()) || [INFO] [stdout] 69 | | (y+1 == real_pos.bottom()) || [INFO] [stdout] 70 | | (y == real_pos.top()) [INFO] [stdout] 71 | | )) { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - if filled || (!filled && ( [INFO] [stdout] 67 - (x+1 == real_pos.right()) || [INFO] [stdout] 68 - (x == real_pos.left()) || [INFO] [stdout] 69 - (y+1 == real_pos.bottom()) || [INFO] [stdout] 70 - (y == real_pos.top()) [INFO] [stdout] 71 - )) { [INFO] [stdout] 66 + if !(!filled && x+1 != real_pos.right() && x != real_pos.left() && y+1 != real_pos.bottom() && y != real_pos.top()) { [INFO] [stdout] | [INFO] [stdout] 66 - if filled || (!filled && ( [INFO] [stdout] 67 - (x+1 == real_pos.right()) || [INFO] [stdout] 68 - (x == real_pos.left()) || [INFO] [stdout] 69 - (y+1 == real_pos.bottom()) || [INFO] [stdout] 70 - (y == real_pos.top()) [INFO] [stdout] 71 - )) { [INFO] [stdout] 66 + if filled || (x+1 == real_pos.right()) || (x == real_pos.left()) || (y+1 == real_pos.bottom()) || (y == real_pos.top()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ev` [INFO] [stdout] --> src/scripts/update_health.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn update_health(game: &mut GameManager, ev : &GameEvent, listener : &Listener) -> Vec { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ev` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | let mut cur_tick: u16 = 0; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return self.next_id - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return self.next_id - 1; [INFO] [stdout] 95 + self.next_id - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/events.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 101 | while evs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!evs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/events.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | let to_trigger: &mut HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `to_trigger` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 109 ~ [INFO] [stdout] 110 | let type_of = ev.ev_type.as_str(); [INFO] [stdout] 111 ~ let to_trigger: &mut HashSet = match self.listener_evs.get_mut(type_of) { [INFO] [stdout] 112 | None => return, [INFO] [stdout] 113 ~ Some(o) => {o} [INFO] [stdout] 114 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scripts/on_hit.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return vec![] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return vec![] [INFO] [stdout] 35 + vec![] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scripts/player_move.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return vec![] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return vec![] [INFO] [stdout] 64 + vec![] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/rterm.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn assemble_render(game : &mut GameManager) -> Box>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rterm.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if comps.len() == 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `comps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scripts/update_health.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return vec![]; [INFO] [stdout] 52 + vec![] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/rterm.rs:87:30 [INFO] [stdout] | [INFO] [stdout] 87 | serde_json::from_str(&maps[0].data.as_str()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `maps[0].data.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/scripts/update_health.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | let mut hs = format!("?/?"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"?/?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scripts/update_health.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if comps.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!comps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rterm.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 125 | if comps.len() == 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `comps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return Self { [INFO] [stdout] 20 | | next_id: 0, [INFO] [stdout] 21 | | // event_queue: GameEventQueue::new(), [INFO] [stdout] 22 | | components: HashMap::new(), [INFO] [stdout] 23 | | components_by_obj: HashMap::new(), [INFO] [stdout] 24 | | components_by_type: HashMap::new() [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Self { [INFO] [stdout] 20 + next_id: 0, [INFO] [stdout] 21 + // event_queue: GameEventQueue::new(), [INFO] [stdout] 22 + components: HashMap::new(), [INFO] [stdout] 23 + components_by_obj: HashMap::new(), [INFO] [stdout] 24 + components_by_type: HashMap::new() [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `by_type` after checking its variant with `is_none` [INFO] [stdout] --> src/game.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 118 | if by_type.is_none() || by_obj.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 122 | let by_type = by_type.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `by_obj` after checking its variant with `is_none` [INFO] [stdout] --> src/game.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 118 | if by_type.is_none() || by_obj.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 123 | let by_obj = by_obj.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 141 | None => return Option::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - None => return Option::None, [INFO] [stdout] 141 + None => Option::None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/component.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return serde_json::from_str(self.data.as_str()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return serde_json::from_str(self.data.as_str()).unwrap(); [INFO] [stdout] 31 + serde_json::from_str(self.data.as_str()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOOR` contains a capitalized acronym [INFO] [stdout] --> src/components/tile_map.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FLOOR, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Floor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WALL` contains a capitalized acronym [INFO] [stdout] --> src/components/tile_map.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | WALL [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wall` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/tile_map.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return tiles; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return tiles; [INFO] [stdout] 45 + tiles [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/tile_map.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return self.tiles[usize::from(pos.0)][usize::from(pos.1)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return self.tiles[usize::from(pos.0)][usize::from(pos.1)]; [INFO] [stdout] 49 + self.tiles[usize::from(pos.0)][usize::from(pos.1)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/tile_map.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return self.size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return self.size; [INFO] [stdout] 53 + self.size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/tile_map.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | if filled || (!filled && ( [INFO] [stdout] | ____________________^ [INFO] [stdout] 67 | | (x+1 == real_pos.right()) || [INFO] [stdout] 68 | | (x == real_pos.left()) || [INFO] [stdout] 69 | | (y+1 == real_pos.bottom()) || [INFO] [stdout] 70 | | (y == real_pos.top()) [INFO] [stdout] 71 | | )) { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - if filled || (!filled && ( [INFO] [stdout] 67 - (x+1 == real_pos.right()) || [INFO] [stdout] 68 - (x == real_pos.left()) || [INFO] [stdout] 69 - (y+1 == real_pos.bottom()) || [INFO] [stdout] 70 - (y == real_pos.top()) [INFO] [stdout] 71 - )) { [INFO] [stdout] 66 + if !(!filled && x+1 != real_pos.right() && x != real_pos.left() && y+1 != real_pos.bottom() && y != real_pos.top()) { [INFO] [stdout] | [INFO] [stdout] 66 - if filled || (!filled && ( [INFO] [stdout] 67 - (x+1 == real_pos.right()) || [INFO] [stdout] 68 - (x == real_pos.left()) || [INFO] [stdout] 69 - (y+1 == real_pos.bottom()) || [INFO] [stdout] 70 - (y == real_pos.top()) [INFO] [stdout] 71 - )) { [INFO] [stdout] 66 + if filled || (x+1 == real_pos.right()) || (x == real_pos.left()) || (y+1 == real_pos.bottom()) || (y == real_pos.top()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return self.next_id - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return self.next_id - 1; [INFO] [stdout] 95 + self.next_id - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/events.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 101 | while evs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!evs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/events.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | let to_trigger: &mut HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `to_trigger` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 109 ~ [INFO] [stdout] 110 | let type_of = ev.ev_type.as_str(); [INFO] [stdout] 111 ~ let to_trigger: &mut HashSet = match self.listener_evs.get_mut(type_of) { [INFO] [stdout] 112 | None => return, [INFO] [stdout] 113 ~ Some(o) => {o} [INFO] [stdout] 114 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scripts/on_hit.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return vec![] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return vec![] [INFO] [stdout] 35 + vec![] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scripts/player_move.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return vec![] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return vec![] [INFO] [stdout] 64 + vec![] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scripts/update_health.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return vec![]; [INFO] [stdout] 52 + vec![] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/scripts/update_health.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | let mut hs = format!("?/?"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"?/?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scripts/update_health.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if comps.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!comps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.37s [INFO] running `Command { std: "docker" "inspect" "57c74cc3004c25a5a584e5bd4be718d7a1720b24b3df7a749e1fecb1f68fa30c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57c74cc3004c25a5a584e5bd4be718d7a1720b24b3df7a749e1fecb1f68fa30c", kill_on_drop: false }` [INFO] [stdout] 57c74cc3004c25a5a584e5bd4be718d7a1720b24b3df7a749e1fecb1f68fa30c