[INFO] cloning repository https://github.com/fabgeyer/bibfzf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fabgeyer/bibfzf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffabgeyer%2Fbibfzf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffabgeyer%2Fbibfzf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f0e4a00cf1221c38e18cb88415bfc0f0484abbf6 [INFO] linting fabgeyer/bibfzf against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffabgeyer%2Fbibfzf" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fabgeyer/bibfzf [INFO] finished tweaking git repo https://github.com/fabgeyer/bibfzf [INFO] tweaked toml for git repo https://github.com/fabgeyer/bibfzf written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fabgeyer/bibfzf on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fabgeyer/bibfzf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thread_local v0.3.6 [INFO] [stderr] Downloaded unicode-width v0.1.5 [INFO] [stderr] Downloaded utf8-ranges v1.0.2 [INFO] [stderr] Downloaded redox_termios v0.1.1 [INFO] [stderr] Downloaded termion v1.5.1 [INFO] [stderr] Downloaded backtrace v0.3.11 [INFO] [stderr] Downloaded linked-hash-map v0.3.0 [INFO] [stderr] Downloaded ansi_term v0.11.0 [INFO] [stderr] Downloaded bitflags v1.0.4 [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded serde_test v0.8.23 [INFO] [stderr] Downloaded rust-ini v0.12.2 [INFO] [stderr] Downloaded num-traits v0.1.43 [INFO] [stderr] Downloaded cc v1.0.25 [INFO] [stderr] Downloaded serde v0.8.23 [INFO] [stderr] Downloaded num-traits v0.2.6 [INFO] [stderr] Downloaded failure v0.1.3 [INFO] [stderr] Downloaded rand v0.4.3 [INFO] [stderr] Downloaded nom v4.1.1 [INFO] [stderr] Downloaded serde_json v1.0.33 [INFO] [stderr] Downloaded regex v0.2.11 [INFO] [stderr] Downloaded syn v0.15.23 [INFO] [stderr] Downloaded nix v0.11.0 [INFO] [stderr] Downloaded clap v2.32.0 [INFO] [stderr] Downloaded regex-syntax v0.6.3 [INFO] [stderr] Downloaded regex-syntax v0.5.6 [INFO] [stderr] Downloaded regex v1.0.6 [INFO] [stderr] Downloaded libc v0.2.43 [INFO] [stderr] Downloaded nom v3.0.0 [INFO] [stderr] Downloaded dirs v1.0.4 [INFO] [stderr] Downloaded serde v1.0.80 [INFO] [stderr] Downloaded term v0.5.1 [INFO] [stderr] Downloaded linked-hash-map v0.5.1 [INFO] [stderr] Downloaded quote v0.6.10 [INFO] [stderr] Downloaded synstructure v0.10.1 [INFO] [stderr] Downloaded encode_unicode v0.3.5 [INFO] [stderr] Downloaded serde-hjson v0.8.2 [INFO] [stderr] Downloaded yaml-rust v0.4.2 [INFO] [stderr] Downloaded arrayvec v0.4.10 [INFO] [stderr] Downloaded argon2rs v0.2.5 [INFO] [stderr] Downloaded backtrace-sys v0.1.28 [INFO] [stderr] Downloaded proc-macro2 v0.4.24 [INFO] [stderr] Downloaded byteorder v1.2.7 [INFO] [stderr] Downloaded prettytable-rs v0.8.0 [INFO] [stderr] Downloaded aho-corasick v0.6.9 [INFO] [stderr] Downloaded memchr v2.1.1 [INFO] [stderr] Downloaded ucd-util v0.1.2 [INFO] [stderr] Downloaded ryu v0.2.7 [INFO] [stderr] Downloaded config v0.9.1 [INFO] [stderr] Downloaded blake2-rfc v0.2.18 [INFO] [stderr] Downloaded nom-bibtex v0.2.0 [INFO] [stderr] Downloaded csv-core v0.1.4 [INFO] [stderr] Downloaded log v0.4.6 [INFO] [stderr] Downloaded itoa v0.4.3 [INFO] [stderr] Downloaded nodrop v0.1.13 [INFO] [stderr] Downloaded constant_time_eq v0.1.3 [INFO] [stderr] Downloaded strsim v0.7.0 [INFO] [stderr] Downloaded textwrap v0.10.0 [INFO] [stderr] Downloaded lazy_static v1.2.0 [INFO] [stderr] Downloaded skim v0.5.2 [INFO] [stderr] Downloaded csv v1.0.2 [INFO] [stderr] Downloaded winapi v0.3.6 [INFO] [stderr] Downloaded rustc-demangle v0.1.11 [INFO] [stderr] Downloaded failure_derive v0.1.3 [INFO] [stderr] Downloaded redox_users v0.2.0 [INFO] [stderr] Downloaded atty v0.2.11 [INFO] [stderr] Downloaded vec_map v0.8.1 [INFO] [stderr] Downloaded env_logger v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69bae79d83012fed45ad40bbfeb7cdc5bea723935a3e7dca34bccd7c984fa57a [INFO] running `Command { std: "docker" "start" "-a" "69bae79d83012fed45ad40bbfeb7cdc5bea723935a3e7dca34bccd7c984fa57a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69bae79d83012fed45ad40bbfeb7cdc5bea723935a3e7dca34bccd7c984fa57a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69bae79d83012fed45ad40bbfeb7cdc5bea723935a3e7dca34bccd7c984fa57a", kill_on_drop: false }` [INFO] [stdout] 69bae79d83012fed45ad40bbfeb7cdc5bea723935a3e7dca34bccd7c984fa57a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ad051c6f7fe06c829484c7d4fdad9d00095b0daf1f4addbfcaf6b1629675b82 [INFO] running `Command { std: "docker" "start" "-a" "8ad051c6f7fe06c829484c7d4fdad9d00095b0daf1f4addbfcaf6b1629675b82", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking ucd-util v0.1.2 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling regex v1.0.6 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling nix v0.11.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking regex-syntax v0.6.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking yaml-rust v0.4.2 [INFO] [stderr] Checking shlex v0.1.1 [INFO] [stderr] Checking encode_unicode v0.3.5 [INFO] [stderr] Checking rust-ini v0.12.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking nom v3.0.0 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking nom-bibtex v0.2.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking serde_test v0.8.23 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking serde-hjson v0.8.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking skim v0.5.2 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Checking bibfzf v18.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/main.rs:91:44 [INFO] [stdout] | [INFO] [stdout] 91 | fn action_copy_key(biblio: &PBibliography, settings: &Config) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/main.rs:95:45 [INFO] [stdout] | [INFO] [stdout] 95 | fn action_copy_cite(biblio: &PBibliography, settings: &Config) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/main.rs:91:44 [INFO] [stdout] | [INFO] [stdout] 91 | fn action_copy_key(biblio: &PBibliography, settings: &Config) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/main.rs:95:45 [INFO] [stdout] | [INFO] [stdout] 95 | fn action_copy_cite(biblio: &PBibliography, settings: &Config) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return biblio.fields.contains_key(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return biblio.fields.contains_key(key); [INFO] [stdout] 103 + biblio.fields.contains_key(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | let actions: Vec<(&str, &str, fn(&PBibliography, &Config))> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | .unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | / return PBibliography { [INFO] [stdout] 142 | | bib: biblio, [INFO] [stdout] 143 | | fields: map, [INFO] [stdout] 144 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 ~ PBibliography { [INFO] [stdout] 142 + bib: biblio, [INFO] [stdout] 143 + fields: map, [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return map; [INFO] [stdout] 156 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | / for entry in glob(path.join("**").join("*.bib").to_str().unwrap()) [INFO] [stdout] 150 | | .expect("Failed to read glob pattern") [INFO] [stdout] 151 | | { [INFO] [stdout] 152 | | if let Ok(path) = entry { [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / if let Ok(path) = entry { [INFO] [stdout] 153 | | map.insert(path.file_name().unwrap().to_str().unwrap().to_owned(), path); [INFO] [stdout] 154 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 ~ for path in glob(path.join("**").join("*.bib").to_str().unwrap()) [INFO] [stdout] 150 ~ .expect("Failed to read glob pattern").flatten() [INFO] [stdout] 151 ~ { [INFO] [stdout] 152 + map.insert(path.file_name().unwrap().to_str().unwrap().to_owned(), path); [INFO] [stdout] 153 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:257:8 [INFO] [stdout] | [INFO] [stdout] 257 | if !bibtexr.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `bibtexr.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | bib_str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `bib_str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:323:25 [INFO] [stdout] | [INFO] [stdout] 323 | .unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return biblio.fields.contains_key(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return biblio.fields.contains_key(key); [INFO] [stdout] 103 + biblio.fields.contains_key(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | let actions: Vec<(&str, &str, fn(&PBibliography, &Config))> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | .unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | / return PBibliography { [INFO] [stdout] 142 | | bib: biblio, [INFO] [stdout] 143 | | fields: map, [INFO] [stdout] 144 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 ~ PBibliography { [INFO] [stdout] 142 + bib: biblio, [INFO] [stdout] 143 + fields: map, [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return map; [INFO] [stdout] 156 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | / for entry in glob(path.join("**").join("*.bib").to_str().unwrap()) [INFO] [stdout] 150 | | .expect("Failed to read glob pattern") [INFO] [stdout] 151 | | { [INFO] [stdout] 152 | | if let Ok(path) = entry { [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / if let Ok(path) = entry { [INFO] [stdout] 153 | | map.insert(path.file_name().unwrap().to_str().unwrap().to_owned(), path); [INFO] [stdout] 154 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 ~ for path in glob(path.join("**").join("*.bib").to_str().unwrap()) [INFO] [stdout] 150 ~ .expect("Failed to read glob pattern").flatten() [INFO] [stdout] 151 ~ { [INFO] [stdout] 152 + map.insert(path.file_name().unwrap().to_str().unwrap().to_owned(), path); [INFO] [stdout] 153 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:257:8 [INFO] [stdout] | [INFO] [stdout] 257 | if !bibtexr.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `bibtexr.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | bib_str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `bib_str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:323:25 [INFO] [stdout] | [INFO] [stdout] 323 | .unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.58s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v3.0.0, nom v4.1.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "8ad051c6f7fe06c829484c7d4fdad9d00095b0daf1f4addbfcaf6b1629675b82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ad051c6f7fe06c829484c7d4fdad9d00095b0daf1f4addbfcaf6b1629675b82", kill_on_drop: false }` [INFO] [stdout] 8ad051c6f7fe06c829484c7d4fdad9d00095b0daf1f4addbfcaf6b1629675b82