[INFO] cloning repository https://github.com/fa-sharp/tiniredis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fa-sharp/tiniredis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffa-sharp%2Ftiniredis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffa-sharp%2Ftiniredis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4cf838fc193b5a2b95530e8e4cedc5d4013b0ff0 [INFO] linting fa-sharp/tiniredis against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffa-sharp%2Ftiniredis" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fa-sharp/tiniredis [INFO] finished tweaking git repo https://github.com/fa-sharp/tiniredis [INFO] tweaked toml for git repo https://github.com/fa-sharp/tiniredis written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fa-sharp/tiniredis on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fa-sharp/tiniredis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ctrlc v3.5.0 [INFO] [stderr] Downloaded tracing-serde v0.2.0 [INFO] [stderr] Downloaded clap v4.5.48 [INFO] [stderr] Downloaded windows-targets v0.53.4 [INFO] [stderr] Downloaded crc-fast v1.5.0 [INFO] [stderr] Downloaded clap_builder v4.5.48 [INFO] [stderr] Downloaded regex v1.11.3 [INFO] [stderr] Downloaded regex-automata v0.4.11 [INFO] [stderr] Downloaded libc v0.2.176 [INFO] [stderr] Downloaded windows-sys v0.61.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3641a8d9ae18ec20c6eff23c3dbf79ec6386becf2e6973d1b9aa58ead39dc7e5 [INFO] running `Command { std: "docker" "start" "-a" "3641a8d9ae18ec20c6eff23c3dbf79ec6386becf2e6973d1b9aa58ead39dc7e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3641a8d9ae18ec20c6eff23c3dbf79ec6386becf2e6973d1b9aa58ead39dc7e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3641a8d9ae18ec20c6eff23c3dbf79ec6386becf2e6973d1b9aa58ead39dc7e5", kill_on_drop: false }` [INFO] [stdout] 3641a8d9ae18ec20c6eff23c3dbf79ec6386becf2e6973d1b9aa58ead39dc7e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] da9a5451552a723a18cbd458301fd683bab814d76b976b82ec36643619533afd [INFO] running `Command { std: "docker" "start" "-a" "da9a5451552a723a18cbd458301fd683bab814d76b976b82ec36643619533afd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Compiling serde_core v1.0.225 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling serde v1.0.225 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking ctrlc v3.5.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Checking crc-fast v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tinikeyval-protocol v0.1.0 (/opt/rustwide/workdir/protocol) [INFO] [stderr] Checking tinikeyval v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinikeyval-client v0.1.0 (/opt/rustwide/workdir/client) [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/storage.rs:100:46 [INFO] [stdout] | [INFO] [stdout] 100 | expiration: ttl_millis.map(|ttl| (Instant::now() + Duration::from_millis(ttl))), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 100 - expiration: ttl_millis.map(|ttl| (Instant::now() + Duration::from_millis(ttl))), [INFO] [stdout] 100 + expiration: ttl_millis.map(|ttl| Instant::now() + Duration::from_millis(ttl) ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/storage.rs:100:46 [INFO] [stdout] | [INFO] [stdout] 100 | expiration: ttl_millis.map(|ttl| (Instant::now() + Duration::from_millis(ttl))), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 100 - expiration: ttl_millis.map(|ttl| (Instant::now() + Duration::from_millis(ttl))), [INFO] [stdout] 100 + expiration: ttl_millis.map(|ttl| Instant::now() + Duration::from_millis(ttl) ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/process.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | let mut authed = !config.auth.is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.auth.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server/process.rs:106:28 [INFO] [stdout] | [INFO] [stdout] 106 | let write_err = if cxn.read_buffer().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cxn.read_buffer().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting float literal to `f64` is unnecessary [INFO] [stdout] --> src/storage/geo/geo_utils.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | const NORMALIZE: f64 = 67_108_864.0 as f64; // 2^26 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `67_108_864.0_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/storage/geo/geo_utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | MIN_LONGITUDE <= lon && lon <= MAX_LONGITUDE [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MIN_LONGITUDE..=MAX_LONGITUDE).contains(&lon)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/storage/geo/geo_utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | MIN_LATITUDE <= lat && lat <= MAX_LATITUDE [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MIN_LATITUDE..=MAX_LATITUDE).contains(&lat)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/storage/geo/geo_utils.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | let mut v: u64 = (v & 0xFFFFFFFF).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/storage/rdb/parser.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | 0b00 | 0b01 | 0b10 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `0b00..=0b10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/storage/rdb.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | storage.data.extend(db.keys.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 55 - storage.data.extend(db.keys.into_iter()); [INFO] [stdout] 55 + storage.data.extend(db.keys); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/set.rs:28:42 [INFO] [stdout] | [INFO] [stdout] 28 | let Some(set) = self.get_set_mut(&key)? else { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/process.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | let mut authed = !config.auth.is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.auth.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/sorted_set.rs:164:69 [INFO] [stdout] | [INFO] [stdout] 164 | let Some(SortedSet(hash, ranked)) = self.get_sorted_set_mut(&key)? else { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server/process.rs:106:28 [INFO] [stdout] | [INFO] [stdout] 106 | let write_err = if cxn.read_buffer().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cxn.read_buffer().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: swapping with a temporary value is inefficient [INFO] [stdout] --> src/storage.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | std::mem::swap(o, &mut default_fn()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `*o = default_fn()` [INFO] [stdout] | [INFO] [stdout] note: this expression returns a temporary value [INFO] [stdout] --> src/storage.rs:70:44 [INFO] [stdout] | [INFO] [stdout] 70 | std::mem::swap(o, &mut default_fn()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary [INFO] [stdout] = note: `#[warn(clippy::swap_with_temporary)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting float literal to `f64` is unnecessary [INFO] [stdout] --> src/storage/geo/geo_utils.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | const NORMALIZE: f64 = 67_108_864.0 as f64; // 2^26 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `67_108_864.0_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/storage/geo/geo_utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | MIN_LONGITUDE <= lon && lon <= MAX_LONGITUDE [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MIN_LONGITUDE..=MAX_LONGITUDE).contains(&lon)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/storage/geo/geo_utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | MIN_LATITUDE <= lat && lat <= MAX_LATITUDE [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MIN_LATITUDE..=MAX_LATITUDE).contains(&lat)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/storage/geo/geo_utils.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | let mut v: u64 = (v & 0xFFFFFFFF).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/storage/rdb/parser.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | 0b00 | 0b01 | 0b10 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `0b00..=0b10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/storage/rdb.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | storage.data.extend(db.keys.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 55 - storage.data.extend(db.keys.into_iter()); [INFO] [stdout] 55 + storage.data.extend(db.keys); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/set.rs:28:42 [INFO] [stdout] | [INFO] [stdout] 28 | let Some(set) = self.get_set_mut(&key)? else { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/sorted_set.rs:164:69 [INFO] [stdout] | [INFO] [stdout] 164 | let Some(SortedSet(hash, ranked)) = self.get_sorted_set_mut(&key)? else { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: swapping with a temporary value is inefficient [INFO] [stdout] --> src/storage.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | std::mem::swap(o, &mut default_fn()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `*o = default_fn()` [INFO] [stdout] | [INFO] [stdout] note: this expression returns a temporary value [INFO] [stdout] --> src/storage.rs:70:44 [INFO] [stdout] | [INFO] [stdout] 70 | std::mem::swap(o, &mut default_fn()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary [INFO] [stdout] = note: `#[warn(clippy::swap_with_temporary)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.88s [INFO] running `Command { std: "docker" "inspect" "da9a5451552a723a18cbd458301fd683bab814d76b976b82ec36643619533afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da9a5451552a723a18cbd458301fd683bab814d76b976b82ec36643619533afd", kill_on_drop: false }` [INFO] [stdout] da9a5451552a723a18cbd458301fd683bab814d76b976b82ec36643619533afd