[INFO] cloning repository https://github.com/external-mirrors/tpsecore [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/external-mirrors/tpsecore" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexternal-mirrors%2Ftpsecore", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexternal-mirrors%2Ftpsecore'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 86ac8b0a27e3f8ccdd56c5c43fd694d3f4eaf23b [INFO] linting external-mirrors/tpsecore against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexternal-mirrors%2Ftpsecore" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/external-mirrors/tpsecore [INFO] finished tweaking git repo https://github.com/external-mirrors/tpsecore [INFO] tweaked toml for git repo https://github.com/external-mirrors/tpsecore written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/external-mirrors/tpsecore on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/external-mirrors/tpsecore already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-vo v0.1.0 [INFO] [stderr] Downloaded siphasher v1.0.2 [INFO] [stderr] Downloaded xmlwriter v0.1.0 [INFO] [stderr] Downloaded simple_logger v5.2.0 [INFO] [stderr] Downloaded derive_arbitrary v1.4.2 [INFO] [stderr] Downloaded darling_macro v0.21.3 [INFO] [stderr] Downloaded core_maths v0.1.1 [INFO] [stderr] Downloaded pico-args v0.5.0 [INFO] [stderr] Downloaded num_threads v0.1.7 [INFO] [stderr] Downloaded extended v0.1.0 [INFO] [stderr] Downloaded dyn-clone v1.0.20 [INFO] [stderr] Downloaded symphonia v0.5.5 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.110 [INFO] [stderr] Downloaded hex-literal v0.4.1 [INFO] [stderr] Downloaded lebe v0.5.3 [INFO] [stderr] Downloaded fax v0.2.6 [INFO] [stderr] Downloaded ref-cast v1.0.25 [INFO] [stderr] Downloaded quick-error v2.0.1 [INFO] [stderr] Downloaded num v0.4.3 [INFO] [stderr] Downloaded symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Downloaded bit_field v0.10.3 [INFO] [stderr] Downloaded zune-core v0.5.1 [INFO] [stderr] Downloaded gif v0.13.3 [INFO] [stderr] Downloaded hound v3.5.1 [INFO] [stderr] Downloaded image-webp v0.2.4 [INFO] [stderr] Downloaded wide v0.7.33 [INFO] [stderr] Downloaded zerocopy-derive v0.8.39 [INFO] [stderr] Downloaded kurbo v0.11.3 [INFO] [stderr] Downloaded moxcms v0.7.11 [INFO] [stderr] Downloaded serde_with v3.16.1 [INFO] [stderr] Downloaded exr v1.74.0 [INFO] [stderr] Downloaded zune-inflate v0.2.54 [INFO] [stderr] Downloaded zerocopy v0.8.39 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Downloaded image v0.25.9 [INFO] [stderr] Downloaded nalgebra v0.32.6 [INFO] [stderr] Downloaded regex-syntax v0.8.9 [INFO] [stderr] Downloaded svgtypes v0.15.3 [INFO] [stderr] Downloaded image-webp v0.1.3 [INFO] [stderr] Downloaded rustybuzz v0.18.0 [INFO] [stderr] Downloaded usvg v0.44.0 [INFO] [stderr] Downloaded imageproc v0.25.0 [INFO] [stderr] Downloaded symphonia-core v0.5.5 [INFO] [stderr] Downloaded fontdb v0.22.0 [INFO] [stderr] Downloaded weezl v0.1.12 [INFO] [stderr] Downloaded zune-jpeg v0.4.21 [INFO] [stderr] Downloaded js-sys v0.3.87 [INFO] [stderr] Downloaded schemars v1.2.1 [INFO] [stderr] Downloaded png v0.17.16 [INFO] [stderr] Downloaded zune-jpeg v0.5.12 [INFO] [stderr] Downloaded unicode-bidi-mirroring v0.3.0 [INFO] [stderr] Downloaded matrixmultiply v0.3.10 [INFO] [stderr] Downloaded safe_arch v0.7.4 [INFO] [stderr] Downloaded simba v0.8.1 [INFO] [stderr] Downloaded resvg v0.44.0 [INFO] [stderr] Downloaded cc v1.2.56 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.110 [INFO] [stderr] Downloaded tiff v0.10.3 [INFO] [stderr] Downloaded wasm-bindgen v0.2.110 [INFO] [stderr] Downloaded darling_core v0.21.3 [INFO] [stderr] Downloaded colored v3.1.1 [INFO] [stderr] Downloaded zip v2.4.2 [INFO] [stderr] Downloaded pxfm v0.1.27 [INFO] [stderr] Downloaded fax_derive v0.2.0 [INFO] [stderr] Downloaded gif v0.14.1 [INFO] [stderr] Downloaded qoi v0.4.1 [INFO] [stderr] Downloaded rand_distr v0.4.3 [INFO] [stderr] Downloaded schemars v0.9.0 [INFO] [stderr] Downloaded darling v0.21.3 [INFO] [stderr] Downloaded serde_with_macros v3.16.1 [INFO] [stderr] Downloaded symphonia-codec-aac v0.5.5 [INFO] [stderr] Downloaded symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Downloaded symphonia-metadata v0.5.5 [INFO] [stderr] Downloaded zune-core v0.4.12 [INFO] [stderr] Downloaded deranged v0.5.7 [INFO] [stderr] Downloaded symphonia-bundle-flac v0.5.5 [INFO] [stderr] Downloaded symphonia-format-mkv v0.5.5 [INFO] [stderr] Downloaded imagesize v0.13.0 [INFO] [stderr] Downloaded unicode-ccc v0.3.0 [INFO] [stderr] Downloaded simplecss v0.2.2 [INFO] [stderr] Downloaded zopfli v0.8.3 [INFO] [stderr] Downloaded num-complex v0.4.6 [INFO] [stderr] Downloaded num-rational v0.4.2 [INFO] [stderr] Downloaded unicase v2.9.0 [INFO] [stderr] Downloaded rgb v0.8.52 [INFO] [stderr] Downloaded symphonia-format-ogg v0.5.5 [INFO] [stderr] Downloaded symphonia-format-riff v0.5.5 [INFO] [stderr] Downloaded arbitrary v1.4.2 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.110 [INFO] [stderr] Downloaded ref-cast-impl v1.0.25 [INFO] [stderr] Downloaded symphonia-codec-pcm v0.5.5 [INFO] [stderr] Downloaded data-url v0.3.2 [INFO] [stderr] Downloaded symphonia-codec-adpcm v0.5.5 [INFO] [stderr] Downloaded symphonia-utils-xiph v0.5.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6049d8a992a8dab5ae44eb5c66e967a4ca552ed35a1ba9f75a227bd3df4159ca [INFO] running `Command { std: "docker" "start" "-a" "6049d8a992a8dab5ae44eb5c66e967a4ca552ed35a1ba9f75a227bd3df4159ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6049d8a992a8dab5ae44eb5c66e967a4ca552ed35a1ba9f75a227bd3df4159ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6049d8a992a8dab5ae44eb5c66e967a4ca552ed35a1ba9f75a227bd3df4159ca", kill_on_drop: false }` [INFO] [stdout] 6049d8a992a8dab5ae44eb5c66e967a4ca552ed35a1ba9f75a227bd3df4159ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ee26becba57b6f416df65207f45679ac21a8e202dd504f57b02af00e628dd8e [INFO] running `Command { std: "docker" "start" "-a" "5ee26becba57b6f416df65207f45679ac21a8e202dd504f57b02af00e628dd8e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking getrandom v0.2.17 (/opt/rustwide/workdir/overrides/getrandom) [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking ttf-parser v0.24.1 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking fontconfig-parser v0.5.8 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking memmap2 v0.9.10 [INFO] [stderr] Checking kurbo v0.11.3 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking unicode-ccc v0.3.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking unicode-script v0.5.8 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking siphasher v1.0.2 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking unicode-bidi-mirroring v0.3.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking fontdb v0.22.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking svgtypes v0.15.3 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking simplecss v0.2.2 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Checking imagesize v0.13.0 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking data-url v0.3.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking deranged v0.5.7 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking symphonia-core v0.5.5 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking rustybuzz v0.18.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking symphonia-metadata v0.5.5 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.5 [INFO] [stderr] Checking symphonia-format-mkv v0.5.5 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Checking symphonia-format-ogg v0.5.5 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.5 [INFO] [stderr] Checking symphonia-format-riff v0.5.5 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.5 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.5 [INFO] [stderr] Checking symphonia-codec-aac v0.5.5 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking usvg v0.44.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking symphonia v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking resvg v0.44.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking colored v3.1.1 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking simple_logger v5.2.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking imageproc v0.25.0 [INFO] [stderr] Checking tpsecore v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/tests.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::accel::software_audio_handle::SoftwareAudioHandle` [INFO] [stdout] --> src/tests.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::accel::software_audio_handle::SoftwareAudioHandle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tpse/file.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return string.to_ascii_uppercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return string.to_ascii_uppercase(); [INFO] [stdout] 38 + string.to_ascii_uppercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tpse/file.rs:58:47 [INFO] [stdout] | [INFO] [stdout] 58 | let url = DataUrl::process(value).map_err(|err| FileParseError::InvalidDataURI(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `FileParseError::InvalidDataURI` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tpse/file.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | let (binary, _) = url.decode_to_vec().map_err(|err| FileParseError::UnparsableBase64(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `FileParseError::UnparsableBase64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tpse/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod tpse; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/tpse/tpse.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | / impl Default for SongGenre { [INFO] [stdout] 41 | | fn default() -> Self { [INFO] [stdout] 42 | | Self::Calm [INFO] [stdout] 43 | | } [INFO] [stdout] 44 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Default)] [INFO] [stdout] 34 | pub enum SongGenre { [INFO] [stdout] 35 | Interface, [INFO] [stdout] 36 | Disabled, [INFO] [stdout] 37 | Override, [INFO] [stdout] 38 ~ #[default] [INFO] [stdout] 39 ~ Calm, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/tpse/tpse_key.rs:341:25 [INFO] [stdout] | [INFO] [stdout] 341 | async fn get(&self, key: &T) -> Result>, TPSEProviderError> { Ok(None) } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/tpse/tpse_key.rs:343:29 [INFO] [stdout] | [INFO] [stdout] 343 | async fn set(&mut self, key: &T, value: Option) -> Result<(), TPSEProviderError> { unreachable!(); } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/tpse/tpse_key.rs:343:38 [INFO] [stdout] | [INFO] [stdout] 343 | async fn set(&mut self, key: &T, value: Option) -> Result<(), TPSEProviderError> { unreachable!(); } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tpse/validate.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | if !graph.iter().filter(|node| node.id == trigger.target).next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph.iter().filter(|node| node.id == trigger.target).next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/tpse/validate.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | if !graph.iter().filter(|node| node.id == trigger.target).next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph.iter().find(|node| node.id == trigger.target)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/import/import_types/animated_options.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | None => format!("unspecified") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"unspecified".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/import/import_types/import_context.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 25 | depth_limit: self.depth_limit.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.depth_limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&dyn ImportLogger + Send + Sync>` which implements the `Copy` trait [INFO] [stdout] --> src/import/import_types/import_context.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | logger: self.logger.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | return conn_submap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return conn_submap; [INFO] [stdout] 159 + conn_submap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/skin_splicer/maps.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(location.len() > 0, "Expected at least one location"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!location.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/import/skin_splicer/maps.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | self.connections.get(&connection).map(|val| *val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.connections.get(&connection).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:186:3 [INFO] [stdout] | [INFO] [stdout] 186 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return map; [INFO] [stdout] 186 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:208:3 [INFO] [stdout] | [INFO] [stdout] 208 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return map; [INFO] [stdout] 208 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:256:3 [INFO] [stdout] | [INFO] [stdout] 256 | return map [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return map [INFO] [stdout] 256 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/import/skin_splicer/mod.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | mod skin_splicer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/import/skin_splicer/skin_splicer.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / if let Some(texture) = texture { [INFO] [stdout] 107 | | if let Some(()) = target.set(*piece, *conn, &texture).await? { [INFO] [stdout] 108 | | valid = true; [INFO] [stdout] 109 | | } [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 106 ~ if let Some(texture) = texture [INFO] [stdout] 107 ~ && let Some(()) = target.set(*piece, *conn, &texture).await? { [INFO] [stdout] 108 | valid = true; [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SkinSplicer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/import/skin_splicer/skin_splicer.rs:119:3 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `min_time` [INFO] [stdout] --> src/tests.rs:280:7 [INFO] [stdout] | [INFO] [stdout] 280 | let min_time = replay.events.iter().map(|x| x.audio_time).reduce(f64::min).unwrap_or(0.0); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_min_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/import/stages/reduce_types.rs:74:61 [INFO] [stdout] | [INFO] [stdout] 74 | for (anim_type, errors) in anim_types.into_iter().filter_map(|el| el) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/stages/reduce_types.rs:138:6 [INFO] [stdout] | [INFO] [stdout] 138 | if sound_effects.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sound_effects.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/stages/reduce_types.rs:141:6 [INFO] [stdout] | [INFO] [stdout] 141 | if ambiguous_mino_skin_errors.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ambiguous_mino_skin_errors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/stages/reduce_types.rs:147:6 [INFO] [stdout] | [INFO] [stdout] 147 | if ambiguous_ghost_skin_errors.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ambiguous_ghost_skin_errors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/import/stages/reduce_types.rs:153:3 [INFO] [stdout] | [INFO] [stdout] 153 | / if animated_minos.as_ref().map(|(t,_)| *t) != animated_ghost.as_ref().map(|(t,_)| *t) { [INFO] [stdout] 154 | | if let Some((ghost_type, results)) = animated_ghost { [INFO] [stdout] 155 | | let files = results [INFO] [stdout] 156 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 161 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if animated_minos.as_ref().map(|(t,_)| *t) != animated_ghost.as_ref().map(|(t,_)| *t) [INFO] [stdout] 154 ~ && let Some((ghost_type, results)) = animated_ghost { [INFO] [stdout] 155 | let files = results [INFO] [stdout] ... [INFO] [stdout] 159 | import_tasks.push(ImportTask::AnimatedSkinFrames(ghost_type, files)) [INFO] [stdout] 160 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:29:39 [INFO] [stdout] | [INFO] [stdout] 29 | .map_err(|err| ctx.wrap(ImportErrorType::LoadError(err.into()).into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::LoadError(err.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | .map_err(|err| ctx.wrap(ImportErrorType::LoadError(err.into()).into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::LoadError(err.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/import/stages/execute_task.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 51 | let height = 1024 * ((frame_count + 15) / 16) as u32; // ceiling division [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `frame_count.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:173:35 [INFO] [stdout] | [INFO] [stdout] 173 | .map_err(|err| ctx.wrap(ImportErrorType::AssetSoundEffectsDecode(err).into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::AssetSoundEffectsDecode(err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:189:33 [INFO] [stdout] | [INFO] [stdout] 189 | .map_err(|err| ctx.wrap(ImportErrorType::AudioEncodeFailed(err).into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::AudioEncodeFailed(err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/import/stages/execute_task.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 202 | let mut groups: HashMap)>> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/file_type.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | _ => return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - _ => return None [INFO] [stdout] 28 + _ => None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `real_time` and `event` are never read [INFO] [stdout] --> src/tests.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 269 | struct ReplayEvent<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 270 | /// milliseconds since epoch [INFO] [stdout] 271 | real_time: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 274 | event: Cow<'a, str>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SpecificImportType` which implements the `Copy` trait [INFO] [stdout] --> src/import/import_result.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | specific_import_type: self.specific_import_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.specific_import_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/import/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | mod import; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tpse/file.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return string.to_ascii_uppercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return string.to_ascii_uppercase(); [INFO] [stdout] 38 + string.to_ascii_uppercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/import/radiance.rs:41:3 [INFO] [stdout] | [INFO] [stdout] 41 | if header != 0x74525344 {} // "tRSD" todo: emit header mismatch warning [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/import/radiance.rs:45:3 [INFO] [stdout] | [INFO] [stdout] 45 | if major != 1 && minor != 0 {} // todo: emit version mismatch warning [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tpse/file.rs:58:47 [INFO] [stdout] | [INFO] [stdout] 58 | let url = DataUrl::process(value).map_err(|err| FileParseError::InvalidDataURI(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `FileParseError::InvalidDataURI` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tpse/file.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | let (binary, _) = url.decode_to_vec().map_err(|err| FileParseError::UnparsableBase64(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `FileParseError::UnparsableBase64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tpse/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod tpse; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/render/board_element.rs:122:40 [INFO] [stdout] | [INFO] [stdout] 122 | let mut garbage_bar = (border*-2 + bar_width*-1, 0, border*2 + bar_width, block*height + border); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using: `-bar_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/render/board_element.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn get_slice(&self) -> (BoardTextureKind, (u32, u32, u32, u32), (u32, u32, u32, u32), u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/render/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | mod render; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/tpse/tpse.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | / impl Default for SongGenre { [INFO] [stdout] 41 | | fn default() -> Self { [INFO] [stdout] 42 | | Self::Calm [INFO] [stdout] 43 | | } [INFO] [stdout] 44 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Default)] [INFO] [stdout] 34 | pub enum SongGenre { [INFO] [stdout] 35 | Interface, [INFO] [stdout] 36 | Disabled, [INFO] [stdout] 37 | Override, [INFO] [stdout] 38 ~ #[default] [INFO] [stdout] 39 ~ Calm, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/render.rs:213:38 [INFO] [stdout] | [INFO] [stdout] 213 | let texture = clone_slice::(&texture, x, y, w, h); [INFO] [stdout] | ^^^^^^^^ help: change this to: `texture` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/render.rs:214:40 [INFO] [stdout] | [INFO] [stdout] 214 | let (x, y, w, h) = el.get_target(&frame.render_options); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `frame.render_options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::slice::Chunks<'_, std::option::Option<(import::skin_splicer::piece::Piece, u8)>>` [INFO] [stdout] --> src/render/board_map.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / self.contents [INFO] [stdout] 14 | | .chunks(self.width) [INFO] [stdout] 15 | | .into_iter() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 13 ~ self.contents [INFO] [stdout] 14 + .chunks(self.width) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/render/board_map.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | chunk.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(Piece, u8)>` which implements the `Copy` trait [INFO] [stdout] --> src/render/board_map.rs:20:47 [INFO] [stdout] | [INFO] [stdout] 20 | .map(move |(col, piece)| (row, col, piece.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*piece` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/accel/software_audio_handle.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | let ext = mime_guess::get_mime_extensions_str(&mime_type).and_then(|x| x.last()).map(|x| *x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `mime_guess::get_mime_extensions_str(&mime_type).and_then(|x| x.last()).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/accel/software_audio_handle.rs:41:53 [INFO] [stdout] | [INFO] [stdout] 41 | let ext = mime_guess::get_mime_extensions_str(&mime_type).and_then(|x| x.last()).map(|x| *x); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `mime_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tpse/validate.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | if !graph.iter().filter(|node| node.id == trigger.target).next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph.iter().filter(|node| node.id == trigger.target).next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/tpse/validate.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | if !graph.iter().filter(|node| node.id == trigger.target).next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph.iter().find(|node| node.id == trigger.target)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/import/import_types/animated_options.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | None => format!("unspecified") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"unspecified".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/import/import_types/import_context.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 25 | depth_limit: self.depth_limit.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.depth_limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&dyn ImportLogger + Send + Sync>` which implements the `Copy` trait [INFO] [stdout] --> src/import/import_types/import_context.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | logger: self.logger.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | return conn_submap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return conn_submap; [INFO] [stdout] 159 + conn_submap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/skin_splicer/maps.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(location.len() > 0, "Expected at least one location"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!location.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/import/skin_splicer/maps.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | self.connections.get(&connection).map(|val| *val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.connections.get(&connection).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:186:3 [INFO] [stdout] | [INFO] [stdout] 186 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return map; [INFO] [stdout] 186 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:208:3 [INFO] [stdout] | [INFO] [stdout] 208 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return map; [INFO] [stdout] 208 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/skin_splicer/maps.rs:256:3 [INFO] [stdout] | [INFO] [stdout] 256 | return map [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return map [INFO] [stdout] 256 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/import/skin_splicer/mod.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | mod skin_splicer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/import/skin_splicer/skin_splicer.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / if let Some(texture) = texture { [INFO] [stdout] 107 | | if let Some(()) = target.set(*piece, *conn, &texture).await? { [INFO] [stdout] 108 | | valid = true; [INFO] [stdout] 109 | | } [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 106 ~ if let Some(texture) = texture [INFO] [stdout] 107 ~ && let Some(()) = target.set(*piece, *conn, &texture).await? { [INFO] [stdout] 108 | valid = true; [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SkinSplicer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/import/skin_splicer/skin_splicer.rs:119:3 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/import/stages/reduce_types.rs:74:61 [INFO] [stdout] | [INFO] [stdout] 74 | for (anim_type, errors) in anim_types.into_iter().filter_map(|el| el) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/stages/reduce_types.rs:138:6 [INFO] [stdout] | [INFO] [stdout] 138 | if sound_effects.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sound_effects.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/stages/reduce_types.rs:141:6 [INFO] [stdout] | [INFO] [stdout] 141 | if ambiguous_mino_skin_errors.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ambiguous_mino_skin_errors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/import/stages/reduce_types.rs:147:6 [INFO] [stdout] | [INFO] [stdout] 147 | if ambiguous_ghost_skin_errors.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ambiguous_ghost_skin_errors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/import/stages/reduce_types.rs:153:3 [INFO] [stdout] | [INFO] [stdout] 153 | / if animated_minos.as_ref().map(|(t,_)| *t) != animated_ghost.as_ref().map(|(t,_)| *t) { [INFO] [stdout] 154 | | if let Some((ghost_type, results)) = animated_ghost { [INFO] [stdout] 155 | | let files = results [INFO] [stdout] 156 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 161 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if animated_minos.as_ref().map(|(t,_)| *t) != animated_ghost.as_ref().map(|(t,_)| *t) [INFO] [stdout] 154 ~ && let Some((ghost_type, results)) = animated_ghost { [INFO] [stdout] 155 | let files = results [INFO] [stdout] ... [INFO] [stdout] 159 | import_tasks.push(ImportTask::AnimatedSkinFrames(ghost_type, files)) [INFO] [stdout] 160 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:29:39 [INFO] [stdout] | [INFO] [stdout] 29 | .map_err(|err| ctx.wrap(ImportErrorType::LoadError(err.into()).into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::LoadError(err.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | .map_err(|err| ctx.wrap(ImportErrorType::LoadError(err.into()).into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::LoadError(err.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/import/stages/execute_task.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 51 | let height = 1024 * ((frame_count + 15) / 16) as u32; // ceiling division [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `frame_count.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:173:35 [INFO] [stdout] | [INFO] [stdout] 173 | .map_err(|err| ctx.wrap(ImportErrorType::AssetSoundEffectsDecode(err).into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::AssetSoundEffectsDecode(err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `import::import_error::ImportErrorType` [INFO] [stdout] --> src/import/stages/execute_task.rs:189:33 [INFO] [stdout] | [INFO] [stdout] 189 | .map_err(|err| ctx.wrap(ImportErrorType::AudioEncodeFailed(err).into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ImportErrorType::AudioEncodeFailed(err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/import/stages/execute_task.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 202 | let mut groups: HashMap)>> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/import/file_type.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | _ => return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - _ => return None [INFO] [stdout] 28 + _ => None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SpecificImportType` which implements the `Copy` trait [INFO] [stdout] --> src/import/import_result.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | specific_import_type: self.specific_import_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.specific_import_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/import/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | mod import; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/import/radiance.rs:41:3 [INFO] [stdout] | [INFO] [stdout] 41 | if header != 0x74525344 {} // "tRSD" todo: emit header mismatch warning [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/import/radiance.rs:45:3 [INFO] [stdout] | [INFO] [stdout] 45 | if major != 1 && minor != 0 {} // todo: emit version mismatch warning [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/render/board_element.rs:122:40 [INFO] [stdout] | [INFO] [stdout] 122 | let mut garbage_bar = (border*-2 + bar_width*-1, 0, border*2 + bar_width, block*height + border); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using: `-bar_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/render/board_element.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn get_slice(&self) -> (BoardTextureKind, (u32, u32, u32, u32), (u32, u32, u32, u32), u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/render/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | mod render; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/render.rs:213:38 [INFO] [stdout] | [INFO] [stdout] 213 | let texture = clone_slice::(&texture, x, y, w, h); [INFO] [stdout] | ^^^^^^^^ help: change this to: `texture` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/render.rs:214:40 [INFO] [stdout] | [INFO] [stdout] 214 | let (x, y, w, h) = el.get_target(&frame.render_options); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `frame.render_options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::slice::Chunks<'_, std::option::Option<(import::skin_splicer::piece::Piece, u8)>>` [INFO] [stdout] --> src/render/board_map.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / self.contents [INFO] [stdout] 14 | | .chunks(self.width) [INFO] [stdout] 15 | | .into_iter() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 13 ~ self.contents [INFO] [stdout] 14 + .chunks(self.width) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/render/board_map.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | chunk.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(Piece, u8)>` which implements the `Copy` trait [INFO] [stdout] --> src/render/board_map.rs:20:47 [INFO] [stdout] | [INFO] [stdout] 20 | .map(move |(col, piece)| (row, col, piece.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*piece` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/accel/software_audio_handle.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | let ext = mime_guess::get_mime_extensions_str(&mime_type).and_then(|x| x.last()).map(|x| *x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `mime_guess::get_mime_extensions_str(&mime_type).and_then(|x| x.last()).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/accel/software_audio_handle.rs:41:53 [INFO] [stdout] | [INFO] [stdout] 41 | let ext = mime_guess::get_mime_extensions_str(&mime_type).and_then(|x| x.last()).map(|x| *x); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `mime_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tests.rs:180:58 [INFO] [stdout] | [INFO] [stdout] 180 | std::fs::write("./testdata/result/render_result.tpse", &serde_json::to_string(&tpse).unwrap()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `serde_json::to_string(&tpse).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `render::board_map::BoardMap` [INFO] [stdout] --> src/tests.rs:218:18 [INFO] [stdout] | [INFO] [stdout] 218 | board: board.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `board.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `std::future::Future` that must be used [INFO] [stdout] --> src/tpse/tpse_key.rs:346:3 [INFO] [stdout] | [INFO] [stdout] 346 | merge(&mut NullTPSEProvider, &NullTPSEProvider); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 04s [INFO] running `Command { std: "docker" "inspect" "5ee26becba57b6f416df65207f45679ac21a8e202dd504f57b02af00e628dd8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ee26becba57b6f416df65207f45679ac21a8e202dd504f57b02af00e628dd8e", kill_on_drop: false }` [INFO] [stdout] 5ee26becba57b6f416df65207f45679ac21a8e202dd504f57b02af00e628dd8e