[INFO] cloning repository https://github.com/exphp-share/mleisher-help [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/exphp-share/mleisher-help" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexphp-share%2Fmleisher-help", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexphp-share%2Fmleisher-help'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f998c50bd30e0b2e51712e3a74a9a7d7e9f7d3d [INFO] linting exphp-share/mleisher-help against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexphp-share%2Fmleisher-help" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/exphp-share/mleisher-help [INFO] finished tweaking git repo https://github.com/exphp-share/mleisher-help [INFO] tweaked toml for git repo https://github.com/exphp-share/mleisher-help written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/exphp-share/mleisher-help on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/exphp-share/mleisher-help already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded autocfg v0.1.6 [INFO] [stderr] Downloaded num-integer v0.1.41 [INFO] [stderr] Downloaded num-traits v0.2.8 [INFO] [stderr] Downloaded time v0.1.42 [INFO] [stderr] Downloaded chrono v0.4.9 [INFO] [stderr] Downloaded regex-syntax v0.6.12 [INFO] [stderr] Downloaded regex v1.3.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2be7ebb3ad3baf35b7b29bc71743a9327fe14beb0714877f4d7e5b43a1512496 [INFO] running `Command { std: "docker" "start" "-a" "2be7ebb3ad3baf35b7b29bc71743a9327fe14beb0714877f4d7e5b43a1512496", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2be7ebb3ad3baf35b7b29bc71743a9327fe14beb0714877f4d7e5b43a1512496", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2be7ebb3ad3baf35b7b29bc71743a9327fe14beb0714877f4d7e5b43a1512496", kill_on_drop: false }` [INFO] [stdout] 2be7ebb3ad3baf35b7b29bc71743a9327fe14beb0714877f4d7e5b43a1512496 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc9c884bddc361f4ca30a2b6a2bf5fc3e6cab21fdf9a8ea007f774a9de05eeff [INFO] running `Command { std: "docker" "start" "-a" "cc9c884bddc361f4ca30a2b6a2bf5fc3e6cab21fdf9a8ea007f774a9de05eeff", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking forums-help v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/main.rs:64:48 [INFO] [stdout] | [INFO] [stdout] 64 | let date = x[1].to_owned();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/main.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | ((12 * (ey - sy)) + em - sm) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - ((12 * (ey - sy)) + em - sm) [INFO] [stdout] 98 + (12 * (ey - sy)) + em - sm [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/main.rs:64:48 [INFO] [stdout] | [INFO] [stdout] 64 | let date = x[1].to_owned();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/main.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | ((12 * (ey - sy)) + em - sm) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - ((12 * (ey - sy)) + em - sm) [INFO] [stdout] 98 + (12 * (ey - sy)) + em - sm [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | / match re.captures(l.as_str()) { [INFO] [stdout] 63 | | Some(x) => { [INFO] [stdout] 64 | | let date = x[1].to_owned();; [INFO] [stdout] 65 | | let mac = x[2].to_owned(); [INFO] [stdout] ... | [INFO] [stdout] 73 | | None => (), [INFO] [stdout] 74 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Some(x) = re.captures(l.as_str()) { [INFO] [stdout] 63 + let date = x[1].to_owned();; [INFO] [stdout] 64 + let mac = x[2].to_owned(); [INFO] [stdout] 65 + let e = emap.entry(mac).or_insert(Mac::new()); [INFO] [stdout] 66 + if e.dates.len() == 2 { [INFO] [stdout] 67 + e.dates.pop(); [INFO] [stdout] 68 + } [INFO] [stdout] 69 + e.dates.push(date); [INFO] [stdout] 70 + e.count += 1; [INFO] [stdout] 71 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 87 | if !end.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `end.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `end` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:88:49 [INFO] [stdout] | [INFO] [stdout] 87 | if !end.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 88 | let edt = NaiveDateTime::parse_from_str(end.unwrap().as_str(), "%Y%m%d_%H%M%S").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 82 | fn nm(start: &String, end: Option<&String>, now: &DateTime) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 ~ fn nm(start: &str, end: Option<&String>, now: &DateTime) -> u32 { [INFO] [stdout] 83 | let ey: u32; [INFO] [stdout] 84 | let em: u32; [INFO] [stdout] 85 ~ let s = NaiveDateTime::parse_from_str(start, "%Y%m%d_%H%M%S").unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/main.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | em = edt.month() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `edt.month()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/main.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | em = now.month() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `now.month()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/main.rs:97:14 [INFO] [stdout] | [INFO] [stdout] 97 | let sm = s.month() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.month()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `lno` is used as a loop counter [INFO] [stdout] --> src/main.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | 'outer: for line_result in reader.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `'outer: for (lno, line_result) in (1_u32..).zip(reader.lines())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | / match emap.get(&mac_string) { [INFO] [stdout] 141 | | Some(v) => { [INFO] [stdout] 142 | | let n: u32; [INFO] [stdout] 143 | | if v.dates.len() == 1 { [INFO] [stdout] ... | [INFO] [stdout] 152 | | None => () [INFO] [stdout] 153 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(v) = emap.get(&mac_string) { [INFO] [stdout] 141 + let n: u32; [INFO] [stdout] 142 + if v.dates.len() == 1 { [INFO] [stdout] 143 + n = nm(&v.dates[0], None, now); [INFO] [stdout] 144 + } else { [INFO] [stdout] 145 + n = nm(&v.dates[0], Some(&v.dates[1]), now); [INFO] [stdout] 146 + } [INFO] [stdout] 147 + if n >= NMONTHS { [INFO] [stdout] 148 + println!("DING! {} {} {} Months: {}", ip, host, mac, n); [INFO] [stdout] 149 + } [INFO] [stdout] 150 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | let n: u32; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `n` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 142 ~ [INFO] [stdout] 143 ~ let n: u32 = if v.dates.len() == 1 { [INFO] [stdout] 144 ~ nm(&v.dates[0], None, now) [INFO] [stdout] 145 | } else { [INFO] [stdout] 146 ~ nm(&v.dates[0], Some(&v.dates[1]), now) [INFO] [stdout] 147 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | / match re.captures(l.as_str()) { [INFO] [stdout] 63 | | Some(x) => { [INFO] [stdout] 64 | | let date = x[1].to_owned();; [INFO] [stdout] 65 | | let mac = x[2].to_owned(); [INFO] [stdout] ... | [INFO] [stdout] 73 | | None => (), [INFO] [stdout] 74 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Some(x) = re.captures(l.as_str()) { [INFO] [stdout] 63 + let date = x[1].to_owned();; [INFO] [stdout] 64 + let mac = x[2].to_owned(); [INFO] [stdout] 65 + let e = emap.entry(mac).or_insert(Mac::new()); [INFO] [stdout] 66 + if e.dates.len() == 2 { [INFO] [stdout] 67 + e.dates.pop(); [INFO] [stdout] 68 + } [INFO] [stdout] 69 + e.dates.push(date); [INFO] [stdout] 70 + e.count += 1; [INFO] [stdout] 71 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 87 | if !end.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `end.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `end` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:88:49 [INFO] [stdout] | [INFO] [stdout] 87 | if !end.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 88 | let edt = NaiveDateTime::parse_from_str(end.unwrap().as_str(), "%Y%m%d_%H%M%S").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 82 | fn nm(start: &String, end: Option<&String>, now: &DateTime) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 ~ fn nm(start: &str, end: Option<&String>, now: &DateTime) -> u32 { [INFO] [stdout] 83 | let ey: u32; [INFO] [stdout] 84 | let em: u32; [INFO] [stdout] 85 ~ let s = NaiveDateTime::parse_from_str(start, "%Y%m%d_%H%M%S").unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/main.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | em = edt.month() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `edt.month()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/main.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | em = now.month() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `now.month()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/main.rs:97:14 [INFO] [stdout] | [INFO] [stdout] 97 | let sm = s.month() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.month()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `lno` is used as a loop counter [INFO] [stdout] --> src/main.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | 'outer: for line_result in reader.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `'outer: for (lno, line_result) in (1_u32..).zip(reader.lines())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | / match emap.get(&mac_string) { [INFO] [stdout] 141 | | Some(v) => { [INFO] [stdout] 142 | | let n: u32; [INFO] [stdout] 143 | | if v.dates.len() == 1 { [INFO] [stdout] ... | [INFO] [stdout] 152 | | None => () [INFO] [stdout] 153 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(v) = emap.get(&mac_string) { [INFO] [stdout] 141 + let n: u32; [INFO] [stdout] 142 + if v.dates.len() == 1 { [INFO] [stdout] 143 + n = nm(&v.dates[0], None, now); [INFO] [stdout] 144 + } else { [INFO] [stdout] 145 + n = nm(&v.dates[0], Some(&v.dates[1]), now); [INFO] [stdout] 146 + } [INFO] [stdout] 147 + if n >= NMONTHS { [INFO] [stdout] 148 + println!("DING! {} {} {} Months: {}", ip, host, mac, n); [INFO] [stdout] 149 + } [INFO] [stdout] 150 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | let n: u32; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `n` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 142 ~ [INFO] [stdout] 143 ~ let n: u32 = if v.dates.len() == 1 { [INFO] [stdout] 144 ~ nm(&v.dates[0], None, now) [INFO] [stdout] 145 | } else { [INFO] [stdout] 146 ~ nm(&v.dates[0], Some(&v.dates[1]), now) [INFO] [stdout] 147 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.77s [INFO] running `Command { std: "docker" "inspect" "cc9c884bddc361f4ca30a2b6a2bf5fc3e6cab21fdf9a8ea007f774a9de05eeff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc9c884bddc361f4ca30a2b6a2bf5fc3e6cab21fdf9a8ea007f774a9de05eeff", kill_on_drop: false }` [INFO] [stdout] cc9c884bddc361f4ca30a2b6a2bf5fc3e6cab21fdf9a8ea007f774a9de05eeff