[INFO] cloning repository https://github.com/expenses/ash-opinionated-abstractions [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/expenses/ash-opinionated-abstractions" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexpenses%2Fash-opinionated-abstractions", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexpenses%2Fash-opinionated-abstractions'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3da2793f2f4661277f193272dfa1e98b29338432 [INFO] linting expenses/ash-opinionated-abstractions against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexpenses%2Fash-opinionated-abstractions" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/expenses/ash-opinionated-abstractions [INFO] finished tweaking git repo https://github.com/expenses/ash-opinionated-abstractions [INFO] tweaked toml for git repo https://github.com/expenses/ash-opinionated-abstractions written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/expenses/ash-opinionated-abstractions on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/expenses/ash-opinionated-abstractions already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Updating gpu-allocator v0.14.0 -> v0.15.1 (available: v0.28.0) [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libloading v0.7.3 [INFO] [stderr] Downloaded miniz_oxide v0.4.4 [INFO] [stderr] Downloaded memchr v2.4.1 [INFO] [stderr] Downloaded vk-sync-fork v0.3.0 [INFO] [stderr] Downloaded log v0.4.14 [INFO] [stderr] Downloaded autocfg v1.0.1 [INFO] [stderr] Downloaded rustc-demangle v0.1.21 [INFO] [stderr] Downloaded gpu-allocator v0.15.1 [INFO] [stderr] Downloaded gimli v0.26.1 [INFO] [stderr] Downloaded anyhow v1.0.52 [INFO] [stderr] Downloaded cc v1.0.72 [INFO] [stderr] Downloaded quote v1.0.14 [INFO] [stderr] Downloaded object v0.27.1 [INFO] [stderr] Downloaded unicode-xid v0.2.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.30 [INFO] [stderr] Downloaded thiserror v1.0.30 [INFO] [stderr] Downloaded ash v0.35.1+1.2.203 [INFO] [stderr] Downloaded backtrace v0.3.63 [INFO] [stderr] Downloaded proc-macro2 v1.0.36 [INFO] [stderr] Downloaded syn v1.0.85 [INFO] [stderr] Downloaded libc v0.2.112 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db094cf1a22acff90cba3e053499072288c9dae8836bd572cdf06ca98a3ff98b [INFO] running `Command { std: "docker" "start" "-a" "db094cf1a22acff90cba3e053499072288c9dae8836bd572cdf06ca98a3ff98b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db094cf1a22acff90cba3e053499072288c9dae8836bd572cdf06ca98a3ff98b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db094cf1a22acff90cba3e053499072288c9dae8836bd572cdf06ca98a3ff98b", kill_on_drop: false }` [INFO] [stdout] db094cf1a22acff90cba3e053499072288c9dae8836bd572cdf06ca98a3ff98b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0775fe091470976004e15e93470298b3399c20db9172b4aa37092f091ccd692 [INFO] running `Command { std: "docker" "start" "-a" "c0775fe091470976004e15e93470298b3399c20db9172b4aa37092f091ccd692", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling ash v0.35.1+1.2.203 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Compiling backtrace v0.3.63 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking gpu-allocator v0.15.1 [INFO] [stderr] Checking vk-sync-fork v0.3.0 [INFO] [stderr] Checking ash-opinionated-abstractions v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: accessing first element with `surface_formats.get(0)` [INFO] [stdout] --> src/lib.rs:88:29 [INFO] [stdout] | [INFO] [stdout] 88 | .or_else(|| surface_formats.get(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `surface_formats.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/lib.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | &cstr_from_array(&extension.extension_name) == required_extension [INFO] [stdout] | -------------------------------------------^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `cstr_from_array(&extension.extension_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:252:22 [INFO] [stdout] | [INFO] [stdout] 252 | let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE [INFO] [stdout] | ______________________^ [INFO] [stdout] 253 | | && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 254 | | || (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO [INFO] [stdout] 255 | | && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE [INFO] [stdout] 253 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 254 - || (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO [INFO] [stdout] 255 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 252 + let filter_out = !(message_type != vk::DebugUtilsMessageTypeFlagsEXT::GENERAL || message_severity != vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE && message_severity != vk::DebugUtilsMessageSeverityFlagsEXT::INFO) [INFO] [stdout] | [INFO] [stdout] 252 - let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE [INFO] [stdout] 253 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 254 - || (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO [INFO] [stdout] 255 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 252 + let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO || message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE) && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:381:13 [INFO] [stdout] | [INFO] [stdout] 381 | / &*vk::DebugUtilsObjectNameInfoEXT::builder() [INFO] [stdout] 382 | | .object_type(T::TYPE) [INFO] [stdout] 383 | | .object_handle(handle.as_raw()) [INFO] [stdout] 384 | | .object_name(&name), [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 381 ~ &vk::DebugUtilsObjectNameInfoEXT::builder() [INFO] [stdout] 382 + .object_type(T::TYPE) [INFO] [stdout] 383 + .object_handle(handle.as_raw()) [INFO] [stdout] 384 ~ .object_name(&name), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:993:1 [INFO] [stdout] | [INFO] [stdout] 993 | / pub fn generate_mips( [INFO] [stdout] 994 | | device: &ash::Device, [INFO] [stdout] 995 | | command_buffer: vk::CommandBuffer, [INFO] [stdout] 996 | | image: vk::Image, [INFO] [stdout] ... | [INFO] [stdout] 1001 | | next_layout: vk_sync::ImageLayout, [INFO] [stdout] 1002 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn as_baked(&self) -> BakedGraphicsPipelineDescriptor { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 298 | pub fn as_baked(&self) -> BakedGraphicsPipelineDescriptor<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `surface_formats.get(0)` [INFO] [stdout] --> src/lib.rs:88:29 [INFO] [stdout] | [INFO] [stdout] 88 | .or_else(|| surface_formats.get(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `surface_formats.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/lib.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | &cstr_from_array(&extension.extension_name) == required_extension [INFO] [stdout] | -------------------------------------------^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `cstr_from_array(&extension.extension_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:252:22 [INFO] [stdout] | [INFO] [stdout] 252 | let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE [INFO] [stdout] | ______________________^ [INFO] [stdout] 253 | | && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 254 | | || (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO [INFO] [stdout] 255 | | && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE [INFO] [stdout] 253 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 254 - || (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO [INFO] [stdout] 255 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 252 + let filter_out = !(message_type != vk::DebugUtilsMessageTypeFlagsEXT::GENERAL || message_severity != vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE && message_severity != vk::DebugUtilsMessageSeverityFlagsEXT::INFO) [INFO] [stdout] | [INFO] [stdout] 252 - let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE [INFO] [stdout] 253 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 254 - || (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO [INFO] [stdout] 255 - && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL) [INFO] [stdout] 252 + let filter_out = (message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::INFO || message_severity == vk::DebugUtilsMessageSeverityFlagsEXT::VERBOSE) && message_type == vk::DebugUtilsMessageTypeFlagsEXT::GENERAL [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:381:13 [INFO] [stdout] | [INFO] [stdout] 381 | / &*vk::DebugUtilsObjectNameInfoEXT::builder() [INFO] [stdout] 382 | | .object_type(T::TYPE) [INFO] [stdout] 383 | | .object_handle(handle.as_raw()) [INFO] [stdout] 384 | | .object_name(&name), [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 381 ~ &vk::DebugUtilsObjectNameInfoEXT::builder() [INFO] [stdout] 382 + .object_type(T::TYPE) [INFO] [stdout] 383 + .object_handle(handle.as_raw()) [INFO] [stdout] 384 ~ .object_name(&name), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:993:1 [INFO] [stdout] | [INFO] [stdout] 993 | / pub fn generate_mips( [INFO] [stdout] 994 | | device: &ash::Device, [INFO] [stdout] 995 | | command_buffer: vk::CommandBuffer, [INFO] [stdout] 996 | | image: vk::Image, [INFO] [stdout] ... | [INFO] [stdout] 1001 | | next_layout: vk_sync::ImageLayout, [INFO] [stdout] 1002 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn as_baked(&self) -> BakedGraphicsPipelineDescriptor { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 298 | pub fn as_baked(&self) -> BakedGraphicsPipelineDescriptor<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.35s [INFO] running `Command { std: "docker" "inspect" "c0775fe091470976004e15e93470298b3399c20db9172b4aa37092f091ccd692", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0775fe091470976004e15e93470298b3399c20db9172b4aa37092f091ccd692", kill_on_drop: false }` [INFO] [stdout] c0775fe091470976004e15e93470298b3399c20db9172b4aa37092f091ccd692