[INFO] cloning repository https://github.com/exlted/Samurai_Warriors_Derusted [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/exlted/Samurai_Warriors_Derusted" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexlted%2FSamurai_Warriors_Derusted", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexlted%2FSamurai_Warriors_Derusted'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30635c6024d7dba8f3c3fa47ce76efde5ad0455a [INFO] linting exlted/Samurai_Warriors_Derusted against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fexlted%2FSamurai_Warriors_Derusted" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/exlted/Samurai_Warriors_Derusted [INFO] finished tweaking git repo https://github.com/exlted/Samurai_Warriors_Derusted [INFO] tweaked toml for git repo https://github.com/exlted/Samurai_Warriors_Derusted written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/exlted/Samurai_Warriors_Derusted on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/exlted/Samurai_Warriors_Derusted already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/StarArawn/bevy_ecs_tilemap.git` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bevy_internal v0.12.1 [INFO] [stderr] Downloaded block2 v0.2.0-alpha.6 [INFO] [stderr] Downloaded bevy_common_assets v0.8.0 [INFO] [stderr] Downloaded spirv v0.2.0+1.5.4 [INFO] [stderr] Downloaded bevy_ptr v0.12.1 [INFO] [stderr] Downloaded bevy v0.12.1 [INFO] [stderr] Downloaded constant_time_eq v0.3.0 [INFO] [stderr] Downloaded ruzstd v0.4.0 [INFO] [stderr] Downloaded bevy_mikktspace v0.12.1 [INFO] [stderr] Downloaded bevy_time v0.12.1 [INFO] [stderr] Downloaded hassle-rs v0.10.0 [INFO] [stderr] Downloaded toml_edit v0.20.2 [INFO] [stderr] Downloaded redox_users v0.4.4 [INFO] [stderr] Downloaded async-channel v2.2.0 [INFO] [stderr] Downloaded naga_oil v0.10.1 [INFO] [stderr] Downloaded libredox v0.0.1 [INFO] [stderr] Downloaded bevy_animation v0.12.1 [INFO] [stderr] Downloaded glow v0.12.3 [INFO] [stderr] Downloaded bevy_rand v0.4.0 [INFO] [stderr] Downloaded derive_more v0.99.17 [INFO] [stderr] Downloaded alsa v0.7.1 [INFO] [stderr] Downloaded cpal v0.15.2 [INFO] [stderr] Downloaded redb v1.5.0 [INFO] [stderr] Downloaded oboe-sys v0.5.0 [INFO] [stderr] Downloaded sysinfo v0.29.11 [INFO] [stderr] Downloaded bindgen v0.69.4 [INFO] [stderr] Downloaded nix v0.24.3 [INFO] [stderr] Downloaded wgpu-hal v0.17.2 [INFO] [stderr] Downloaded inotify v0.10.2 [INFO] [stderr] Downloaded gilrs v0.10.4 [INFO] [stderr] Downloaded bevy_pbr v0.12.1 [INFO] [stderr] Downloaded blake3 v1.5.0 [INFO] [stderr] Downloaded wgpu-core v0.17.1 [INFO] [stderr] Downloaded jni v0.20.0 [INFO] [stderr] Downloaded wgpu v0.17.2 [INFO] [stderr] Downloaded rodio v0.17.3 [INFO] [stderr] Downloaded io-kit-sys v0.4.0 [INFO] [stderr] Downloaded bevy_gizmos v0.12.1 [INFO] [stderr] Downloaded gltf-json v1.4.0 [INFO] [stderr] Downloaded gltf v1.4.0 [INFO] [stderr] Downloaded bevy_asset v0.12.1 [INFO] [stderr] Downloaded naga v0.13.0 [INFO] [stderr] Downloaded regex-syntax v0.7.5 [INFO] [stderr] Downloaded event-listener v5.0.0 [INFO] [stderr] Downloaded anyhow v1.0.79 [INFO] [stderr] Downloaded clang-sys v1.7.0 [INFO] [stderr] Downloaded oboe v0.5.0 [INFO] [stderr] Downloaded gilrs-core v0.5.10 [INFO] [stderr] Downloaded bevy_gltf v0.12.1 [INFO] [stderr] Downloaded bevy_scene v0.12.1 [INFO] [stderr] Downloaded blocking v1.5.1 [INFO] [stderr] Downloaded png v0.17.11 [INFO] [stderr] Downloaded xi-unicode v0.3.0 [INFO] [stderr] Downloaded regex v1.10.3 [INFO] [stderr] Downloaded bevy_reflect v0.12.1 [INFO] [stderr] Downloaded regex-automata v0.4.5 [INFO] [stderr] Downloaded directories v5.0.1 [INFO] [stderr] Downloaded rmp v0.8.12 [INFO] [stderr] Downloaded rmp-serde v1.1.2 [INFO] [stderr] Downloaded bevy_pkv v0.9.1 [INFO] [stderr] Downloaded bevy_prng v0.2.0 [INFO] [stderr] Downloaded glob v0.3.1 [INFO] [stderr] Downloaded gpu-allocator v0.22.0 [INFO] [stderr] Downloaded web-sys v0.3.68 [INFO] [stderr] Downloaded bevy_render v0.12.1 [INFO] [stderr] Downloaded petgraph v0.6.4 [INFO] [stderr] Downloaded bevy_asset_macros v0.12.1 [INFO] [stderr] Downloaded bevy_encase_derive v0.12.1 [INFO] [stderr] Downloaded bevy_render_macros v0.12.1 [INFO] [stderr] Downloaded taffy v0.3.18 [INFO] [stderr] Downloaded bevy_ecs v0.12.1 [INFO] [stderr] Downloaded indexmap v2.2.2 [INFO] [stderr] Downloaded wyrand v0.1.1 [INFO] [stderr] Downloaded proc-macro-crate v2.0.2 [INFO] [stderr] Downloaded leafwing_input_manager_macros v0.11.0 [INFO] [stderr] Downloaded multimap v0.9.1 [INFO] [stderr] Downloaded coreaudio-sys v0.2.15 [INFO] [stderr] Downloaded bevy_audio v0.12.1 [INFO] [stderr] Downloaded bevy_diagnostic v0.12.1 [INFO] [stderr] Downloaded bevy_gilrs v0.12.1 [INFO] [stderr] Downloaded gltf-derive v1.4.0 [INFO] [stderr] Downloaded event-listener-strategy v0.5.0 [INFO] [stderr] Downloaded aho-corasick v1.1.2 [INFO] [stderr] Downloaded ndk-sys v0.4.1+23.1.7779620 [INFO] [stderr] Downloaded android-activity v0.4.3 [INFO] [stderr] Downloaded const_panic v0.2.8 [INFO] [stderr] Downloaded encase_derive_impl v0.6.1 [INFO] [stderr] Downloaded encase_derive v0.6.1 [INFO] [stderr] Downloaded encase v0.6.1 [INFO] [stderr] Downloaded constgebra v0.1.3 [INFO] [stderr] Downloaded hexasphere v9.1.0 [INFO] [stderr] Downloaded crc32fast v1.3.2 [INFO] [stderr] Downloaded glyph_brush_layout v0.2.3 [INFO] [stderr] Downloaded accesskit_winit v0.15.0 [INFO] [stderr] Downloaded toml_datetime v0.6.3 [INFO] [stderr] Downloaded data-encoding v2.5.0 [INFO] [stderr] Downloaded thiserror-core-impl v1.0.50 [INFO] [stderr] Downloaded thiserror-core v1.0.50 [INFO] [stderr] Downloaded d3d12 v0.7.0 [INFO] [stderr] Downloaded khronos-egl v4.1.0 [INFO] [stderr] Downloaded profiling v1.0.14 [INFO] [stderr] Downloaded wgpu-types v0.17.0 [INFO] [stderr] Downloaded bevy_sprite v0.12.1 [INFO] [stderr] Downloaded bevy_text v0.12.1 [INFO] [stderr] Downloaded grid v0.10.0 [INFO] [stderr] Downloaded accesskit_macos v0.10.1 [INFO] [stderr] Downloaded accesskit_windows v0.15.1 [INFO] [stderr] Downloaded bevy_core v0.12.1 [INFO] [stderr] Downloaded tracing-log v0.1.4 [INFO] [stderr] Downloaded bevy_log v0.12.1 [INFO] [stderr] Downloaded bevy_hierarchy v0.12.1 [INFO] [stderr] Downloaded bevy_derive v0.12.1 [INFO] [stderr] Downloaded bevy_app v0.12.1 [INFO] [stderr] Downloaded event-listener v4.0.3 [INFO] [stderr] Downloaded async-lock v3.3.0 [INFO] [stderr] Downloaded async-executor v1.8.0 [INFO] [stderr] Downloaded bevy_reflect_derive v0.12.1 [INFO] [stderr] Downloaded uuid v1.7.0 [INFO] [stderr] Downloaded jobserver v0.1.28 [INFO] [stderr] Downloaded num_enum v0.6.1 [INFO] [stderr] Downloaded winnow v0.5.39 [INFO] [stderr] Downloaded num_enum v0.5.11 [INFO] [stderr] Downloaded objc2 v0.3.0-beta.3.patch-leaks.3 [INFO] [stderr] Downloaded wayland-scanner v0.29.5 [INFO] [stderr] Downloaded com-rs v0.2.1 [INFO] [stderr] Downloaded radsort v0.1.0 [INFO] [stderr] Downloaded accesskit_consumer v0.16.1 [INFO] [stderr] Downloaded regex-syntax v0.8.2 [INFO] [stderr] Downloaded accesskit v0.12.2 [INFO] [stderr] Downloaded bevy_ecs_macros v0.12.1 [INFO] [stderr] Downloaded event-listener-strategy v0.4.0 [INFO] [stderr] Downloaded futures-lite v2.2.0 [INFO] [stderr] Downloaded async-task v4.7.0 [INFO] [stderr] Downloaded parking v2.2.0 [INFO] [stderr] Downloaded bevy_tasks v0.12.1 [INFO] [stderr] Downloaded bevy_input v0.12.1 [INFO] [stderr] Downloaded bevy_math v0.12.1 [INFO] [stderr] Downloaded erased-serde v0.3.31 [INFO] [stderr] Downloaded bevy_utils_proc_macros v0.12.1 [INFO] [stderr] Downloaded bevy_window v0.12.1 [INFO] [stderr] Downloaded crossbeam-channel v0.5.11 [INFO] [stderr] Downloaded num_enum_derive v0.5.11 [INFO] [stderr] Downloaded ndk v0.7.0 [INFO] [stderr] Downloaded block-sys v0.1.0-beta.1 [INFO] [stderr] Downloaded objc-sys v0.2.0-beta.2 [INFO] [stderr] Downloaded objc2-encode v2.0.0-pre.2 [INFO] [stderr] Downloaded raw-window-handle v0.5.2 [INFO] [stderr] Downloaded winit v0.28.7 [INFO] [stderr] Downloaded serde_json v1.0.113 [INFO] [stderr] Downloaded bevy_transform v0.12.1 [INFO] [stderr] Downloaded bevy_ui v0.12.1 [INFO] [stderr] Downloaded bevy_a11y v0.12.1 [INFO] [stderr] Downloaded bytemuck v1.14.2 [INFO] [stderr] Downloaded bevy_utils v0.12.1 [INFO] [stderr] Downloaded bevy_macro_utils v0.12.1 [INFO] [stderr] Downloaded num_enum_derive v0.6.1 [INFO] [stderr] Downloaded serde_derive v1.0.196 [INFO] [stderr] Downloaded metal v0.26.0 [INFO] [stderr] Downloaded serde v1.0.196 [INFO] [stderr] Downloaded pkg-config v0.3.29 [INFO] [stderr] Downloaded bevy_winit v0.12.1 [INFO] [stderr] Downloaded windows v0.46.0 [INFO] [stderr] Downloaded leafwing-input-manager v0.11.2 [INFO] [stderr] Downloaded bevy_core_pipeline v0.12.1 [INFO] [stderr] Downloaded windows v0.44.0 [INFO] [stderr] Downloaded image v0.24.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f87a680f61de15f20e33104f7b18354a917a91c651c35760537f571a638091df [INFO] running `Command { std: "docker" "start" "-a" "f87a680f61de15f20e33104f7b18354a917a91c651c35760537f571a638091df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f87a680f61de15f20e33104f7b18354a917a91c651c35760537f571a638091df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f87a680f61de15f20e33104f7b18354a917a91c651c35760537f571a638091df", kill_on_drop: false }` [INFO] [stdout] f87a680f61de15f20e33104f7b18354a917a91c651c35760537f571a638091df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29231bdbac238429e9554d6dddea3b3f3de7067e695b2f2d52ee8f1f66fa2215 [INFO] running `Command { std: "docker" "start" "-a" "29231bdbac238429e9554d6dddea3b3f3de7067e695b2f2d52ee8f1f66fa2215", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling winnow v0.5.39 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking nonmax v0.5.5 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking bevy_ptr v0.12.1 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling indexmap v2.2.2 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling getrandom v0.2.12 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking event-listener v5.0.0 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling uuid v1.7.0 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking pp-rs v0.2.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking bevy_tasks v0.12.1 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking spirv v0.2.0+1.5.4 [INFO] [stderr] Compiling khronos-egl v4.1.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking accesskit v0.12.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling thiserror-core v1.0.50 [INFO] [stderr] Checking glow v0.12.3 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking renderdoc-sys v1.0.0 [INFO] [stderr] Checking profiling v1.0.14 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Checking const_soft_float v0.1.4 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking const_panic v0.2.8 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking constgebra v0.1.3 [INFO] [stderr] Checking ktx2 v0.3.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking radsort v0.1.0 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Checking euclid v0.22.9 [INFO] [stderr] Checking png v0.17.11 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking svg_fmt v0.4.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking rectangle-pack v0.4.2 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Compiling gilrs v0.10.4 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking grid v0.10.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking sysinfo v0.29.11 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking taffy v0.3.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling redb v1.5.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking owned_ttf_parser v0.20.0 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Compiling bevy_pkv v0.9.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking ab_glyph v0.2.23 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking glyph_brush_layout v0.2.3 [INFO] [stderr] Checking menu_system_plugin v0.1.0 (/opt/rustwide/workdir/menu_system_plugin) [INFO] [stderr] Compiling bevy_macro_utils v0.12.1 [INFO] [stderr] Compiling encase_derive_impl v0.6.1 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Checking accesskit_winit v0.15.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.12.1 [INFO] [stderr] Compiling bevy_reflect_derive v0.12.1 [INFO] [stderr] Compiling bevy_ecs_macros v0.12.1 [INFO] [stderr] Compiling bevy_derive v0.12.1 [INFO] [stderr] Compiling bevy_asset_macros v0.12.1 [INFO] [stderr] Compiling thiserror-core-impl v1.0.50 [INFO] [stderr] Compiling encase_derive v0.6.1 [INFO] [stderr] Compiling bevy_render_macros v0.12.1 [INFO] [stderr] Compiling bevy_encase_derive v0.12.1 [INFO] [stderr] Compiling gltf-derive v1.4.0 [INFO] [stderr] Compiling leafwing_input_manager_macros v0.11.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking ruzstd v0.4.0 [INFO] [stderr] Checking bytemuck v1.14.2 [INFO] [stderr] Checking image v0.24.8 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rmp-serde v1.1.2 [INFO] [stderr] Checking multimap v0.9.1 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking naga v0.13.0 [INFO] [stderr] Checking wgpu-types v0.17.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking gilrs-core v0.5.10 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking gltf-json v1.4.0 [INFO] [stderr] Checking rodio v0.17.3 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking bevy_math v0.12.1 [INFO] [stderr] Checking bevy_mikktspace v0.12.1 [INFO] [stderr] Checking hexasphere v9.1.0 [INFO] [stderr] Checking encase v0.6.1 [INFO] [stderr] Checking gltf v1.4.0 [INFO] [stderr] Checking bevy_utils v0.12.1 [INFO] [stderr] Checking bevy_reflect v0.12.1 [INFO] [stderr] Checking wgpu-hal v0.17.2 [INFO] [stderr] Checking naga_oil v0.10.1 [INFO] [stderr] Checking bevy_ecs v0.12.1 [INFO] [stderr] Checking wgpu-core v0.17.1 [INFO] [stderr] Checking wgpu v0.17.2 [INFO] [stderr] Checking bevy_app v0.12.1 [INFO] [stderr] Checking bevy_log v0.12.1 [INFO] [stderr] Checking bevy_core v0.12.1 [INFO] [stderr] Checking bevy_input v0.12.1 [INFO] [stderr] Checking bevy_a11y v0.12.1 [INFO] [stderr] Checking bevy_time v0.12.1 [INFO] [stderr] Checking bevy_asset v0.12.1 [INFO] [stderr] Checking bevy_hierarchy v0.12.1 [INFO] [stderr] Checking bevy_transform v0.12.1 [INFO] [stderr] Checking bevy_diagnostic v0.12.1 [INFO] [stderr] Checking bevy_window v0.12.1 [INFO] [stderr] Checking bevy_gilrs v0.12.1 [INFO] [stderr] Checking bevy_audio v0.12.1 [INFO] [stderr] Checking bevy_render v0.12.1 [INFO] [stderr] Checking bevy_winit v0.12.1 [INFO] [stderr] Checking bevy_core_pipeline v0.12.1 [INFO] [stderr] Checking bevy_animation v0.12.1 [INFO] [stderr] Checking bevy_scene v0.12.1 [INFO] [stderr] Checking bevy_sprite v0.12.1 [INFO] [stderr] Checking bevy_pbr v0.12.1 [INFO] [stderr] Checking bevy_text v0.12.1 [INFO] [stderr] Checking bevy_ui v0.12.1 [INFO] [stderr] Checking bevy_gltf v0.12.1 [INFO] [stderr] Checking bevy_gizmos v0.12.1 [INFO] [stderr] Checking bevy_internal v0.12.1 [INFO] [stderr] Checking bevy v0.12.1 [INFO] [stderr] Checking bevy_common_assets v0.8.0 [INFO] [stderr] Checking bevy_prng v0.2.0 [INFO] [stderr] Checking leafwing-input-manager v0.11.2 [INFO] [stderr] Checking bevy_ecs_tilemap v0.12.0 (https://github.com/StarArawn/bevy_ecs_tilemap.git#b08a5d99) [INFO] [stderr] Checking asset_loading_plugin v0.1.0 (/opt/rustwide/workdir/asset_loading_plugin) [INFO] [stderr] Checking bevy_rand v0.4.0 [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> asset_loading_plugin/src/loader.rs:90:1 [INFO] [stdout] | [INFO] [stdout] 90 | / pub(crate) fn await_loading( [INFO] [stdout] 91 | | mut next_state: ResMut>, [INFO] [stdout] 92 | | mut asset_sources: ResMut, [INFO] [stdout] 93 | | mut events: EventReader>, [INFO] [stdout] ... | [INFO] [stdout] 98 | | asset_server: Res [INFO] [stdout] 99 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> asset_loading_plugin/src/loader.rs:90:1 [INFO] [stdout] | [INFO] [stdout] 90 | / pub(crate) fn await_loading( [INFO] [stdout] 91 | | mut next_state: ResMut>, [INFO] [stdout] 92 | | mut asset_sources: ResMut, [INFO] [stdout] 93 | | mut events: EventReader>, [INFO] [stdout] ... | [INFO] [stdout] 98 | | asset_server: Res [INFO] [stdout] 99 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking samurai_warriors_derusted v0.1.0 (/opt/rustwide/workdir/samurai_warriors_derusted) [INFO] [stdout] warning: unused variable: `map_entity` [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | if let Some(map_entity) = map_tile_storage.checked_get(&next_pos) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_map_entity` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `passable` is never read [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:131:16 [INFO] [stdout] | [INFO] [stdout] 130 | pub struct TileData { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 131 | pub(crate) passable: bool [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture_handle` is never read [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct RelatedTextureData { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 136 | pub texture_handle: Handle, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RelatedTextureData` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Enemy` is never constructed [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct Enemy; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `health`, `strength`, `defense`, `level`, and `experience` are never read [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Lifeform { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub health: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | pub strength: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 15 | pub defense: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub level: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 17 | pub experience: u32 [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Direction` is never used [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:20:6 [INFO] [stdout] | [INFO] [stdout] 20 | enum Direction { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_lifeform` is never used [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn move_lifeform (direction: Direction, tile_pos: &mut TilePos, map_tile_storage: TileStorage, lifeform_tile_storage: TileStorage) -... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return match (self, old) { [INFO] [stdout] 41 | | (TileTextureData::Corridor{start},TileTextureData::Corridor{start: old_start}) => { [INFO] [stdout] 42 | | *start || !old_start [INFO] [stdout] ... | [INFO] [stdout] 54 | | (_,_) => {true} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ match (self, old) { [INFO] [stdout] 41 + (TileTextureData::Corridor{start},TileTextureData::Corridor{start: old_start}) => { [INFO] [stdout] 42 + *start || !old_start [INFO] [stdout] 43 + } [INFO] [stdout] 44 + (_,TileTextureData::Entrance) => {false} [INFO] [stdout] 45 + (_,TileTextureData::Exit) => {false} [INFO] [stdout] 46 + (TileTextureData::Corridor{..},_) => {true} [INFO] [stdout] 47 + (TileTextureData::Floor, TileTextureData::Corridor{..}) => {false} [INFO] [stdout] 48 + (TileTextureData::Wall{..}, TileTextureData::Corridor{..}) => {false} [INFO] [stdout] 49 + (TileTextureData::Wall{..}, TileTextureData::Floor) => {false} [INFO] [stdout] 50 + (TileTextureData::Enemy, TileTextureData::Player) => {false} [INFO] [stdout] 51 + (TileTextureData::Player, TileTextureData::Enemy) => {true} [INFO] [stdout] 52 + (TileTextureData::Enemy, _) => {panic!("Enemy replacing non-entity")} [INFO] [stdout] 53 + (TileTextureData::Player, _) => {panic!("Player replacing non-entity")} [INFO] [stdout] 54 + (_,_) => {true} [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return match self { [INFO] [stdout] 60 | | TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 | | TileTextureData::Floor => {true} [INFO] [stdout] 62 | | _ => {false} [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ match self { [INFO] [stdout] 60 + TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 + TileTextureData::Floor => {true} [INFO] [stdout] 62 + _ => {false} [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 60 | | TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 | | TileTextureData::Floor => {true} [INFO] [stdout] 62 | | _ => {false} [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 59 - return match self { [INFO] [stdout] 60 - TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 - TileTextureData::Floor => {true} [INFO] [stdout] 62 - _ => {false} [INFO] [stdout] 63 - } [INFO] [stdout] 59 + return matches!(self, TileTextureData::Corridor{..} | TileTextureData::Floor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / return match self { [INFO] [stdout] 68 | | TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 | | _ => {false} [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ match self { [INFO] [stdout] 68 + TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 + _ => {false} [INFO] [stdout] 70 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 68 | | TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 | | _ => {false} [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 67 - return match self { [INFO] [stdout] 68 - TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 - _ => {false} [INFO] [stdout] 70 - } [INFO] [stdout] 67 + return matches!(self, TileTextureData::Wall{..}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / if !connects_north && !connects_south && !connects_east && !connects_west{ [INFO] [stdout] 77 | | TileTextureData::Wall { [INFO] [stdout] 78 | | connects_north: false, [INFO] [stdout] 79 | | connects_east: true, [INFO] [stdout] ... | [INFO] [stdout] 84 | | *self [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ TileTextureData::Wall {connects_north, connects_south, connects_east, connects_west} [INFO] [stdout] 76 ~ if !connects_north && !connects_south && !connects_east && !connects_west=> { [INFO] [stdout] 77 | TileTextureData::Wall { [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / return match self { [INFO] [stdout] 111 | | TileTextureData::None => {false} [INFO] [stdout] 112 | | TileTextureData::Floor => {true} [INFO] [stdout] 113 | | TileTextureData::Corridor { .. } => {true} [INFO] [stdout] ... | [INFO] [stdout] 118 | | TileTextureData::Exit => {true} [INFO] [stdout] 119 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ match self { [INFO] [stdout] 111 + TileTextureData::None => {false} [INFO] [stdout] 112 + TileTextureData::Floor => {true} [INFO] [stdout] 113 + TileTextureData::Corridor { .. } => {true} [INFO] [stdout] 114 + TileTextureData::Player => {false} [INFO] [stdout] 115 + TileTextureData::Enemy => {false} [INFO] [stdout] 116 + TileTextureData::Wall { .. } => {false} [INFO] [stdout] 117 + TileTextureData::Entrance => {true} [INFO] [stdout] 118 + TileTextureData::Exit => {true} [INFO] [stdout] 119 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / return TileData { [INFO] [stdout] 124 | | passable: self.is_passable() [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 ~ TileData { [INFO] [stdout] 124 + passable: self.is_passable() [INFO] [stdout] 125 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] 60 + fn blit(output: &mut [Vec], input: Vec>, x: usize, y: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 132 | / let output = Rect { [INFO] [stdout] 133 | | x: close_x, [INFO] [stdout] 134 | | y: close_y, [INFO] [stdout] 135 | | width: far_x - close_x, [INFO] [stdout] 136 | | height: far_y - close_y [INFO] [stdout] 137 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 138 | output [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 132 ~ [INFO] [stdout] 133 ~ Rect { [INFO] [stdout] 134 + x: close_x, [INFO] [stdout] 135 + y: close_y, [INFO] [stdout] 136 + width: far_x - close_x, [INFO] [stdout] 137 + height: far_y - close_y [INFO] [stdout] 138 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map_entity` [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | if let Some(map_entity) = map_tile_storage.checked_get(&next_pos) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_map_entity` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:145:33 [INFO] [stdout] | [INFO] [stdout] 145 | rooms: vec![this_rect.clone(), that_rect.clone()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:145:52 [INFO] [stdout] | [INFO] [stdout] 145 | rooms: vec![this_rect.clone(), that_rect.clone()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `that_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:150:28 [INFO] [stdout] | [INFO] [stdout] 150 | rooms.push(rect.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | rooms.push(rect.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | return (state, order); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return (state, order); [INFO] [stdout] 214 + (state, order) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | return (intersection, order); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return (intersection, order); [INFO] [stdout] 297 + (intersection, order) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:270:102 [INFO] [stdout] | [INFO] [stdout] 270 | ...intersection(Room::Basic{rect: this_rect.clone()}, Room::Basic{rect: that_aabb}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `idx` is only used to index `that_rooms` [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:280:32 [INFO] [stdout] | [INFO] [stdout] 280 | for idx in 0..that_rooms.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 280 - for idx in 0..that_rooms.len() { [INFO] [stdout] 280 + for in &that_rooms { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:283:114 [INFO] [stdout] | [INFO] [stdout] 283 | ...intersection(Room::Basic{rect: this_rect.clone()}, Room::Basic{rect: that_room}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:356:70 [INFO] [stdout] | [INFO] [stdout] 356 | fn set_at(x: usize, y: usize, new_data: TileTextureData, output: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 356 - fn set_at(x: usize, y: usize, new_data: TileTextureData, output: &mut Vec>) { [INFO] [stdout] 356 + fn set_at(x: usize, y: usize, new_data: TileTextureData, output: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:447:29 [INFO] [stdout] | [INFO] [stdout] 447 | fn check_neighbor(data: &Vec>, x: usize, y: usize) -> (bool, bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 447 - fn check_neighbor(data: &Vec>, x: usize, y: usize) -> (bool, bool) { [INFO] [stdout] 447 + fn check_neighbor(data: &[Vec], x: usize, y: usize) -> (bool, bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:465:69 [INFO] [stdout] | [INFO] [stdout] 465 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x - 1, y - 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:469:87 [INFO] [stdout] | [INFO] [stdout] 469 | let (inner_connects_west, temp_make_wall) = RoomGenerator::check_neighbor(&data, x - 1, y); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:474:69 [INFO] [stdout] | [INFO] [stdout] 474 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x - 1, y + 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:478:88 [INFO] [stdout] | [INFO] [stdout] 478 | let (inner_connects_south, temp_make_wall) = RoomGenerator::check_neighbor(&data, x, y - 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:483:88 [INFO] [stdout] | [INFO] [stdout] 483 | let (inner_connects_north, temp_make_wall) = RoomGenerator::check_neighbor(&data, x, y + 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:488:69 [INFO] [stdout] | [INFO] [stdout] 488 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x + 1, y - 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:492:87 [INFO] [stdout] | [INFO] [stdout] 492 | let (inner_connects_east, temp_make_wall) = RoomGenerator::check_neighbor(&data, x + 1, y); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:497:69 [INFO] [stdout] | [INFO] [stdout] 497 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x + 1, y + 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:509:13 [INFO] [stdout] | [INFO] [stdout] 509 | / match data[x][y].tile_data { [INFO] [stdout] 510 | | TileTextureData::Wall { .. } => { [INFO] [stdout] 511 | | data[x][y].tile_data = TileTextureData::None; [INFO] [stdout] ... | [INFO] [stdout] 514 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 509 ~ if let TileTextureData::Wall { .. } = data[x][y].tile_data { [INFO] [stdout] 510 + data[x][y].tile_data = TileTextureData::None; [INFO] [stdout] 511 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:519:21 [INFO] [stdout] | [INFO] [stdout] 519 | fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 519 - fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] 519 + fn blit(output: &mut [Vec], input: Vec>, x: usize, y: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:522:17 [INFO] [stdout] | [INFO] [stdout] 522 | / if input[input_x][input_y] != TileTextureData::None { [INFO] [stdout] 523 | | if input[input_x][input_y].can_replace(output[input_x + x][input_y + y].tile_data) { [INFO] [stdout] 524 | | output[input_x + x][input_y + y].tile_data = input[input_x][input_y]; [INFO] [stdout] 525 | | } [INFO] [stdout] 526 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 522 ~ if input[input_x][input_y] != TileTextureData::None [INFO] [stdout] 523 ~ && input[input_x][input_y].can_replace(output[input_x + x][input_y + y].tile_data) { [INFO] [stdout] 524 | output[input_x + x][input_y + y].tile_data = input[input_x][input_y]; [INFO] [stdout] 525 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx_removed` is used as a loop counter [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:608:13 [INFO] [stdout] | [INFO] [stdout] 608 | for idx_to_remove in remove_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx_removed, idx_to_remove) in remove_idx.into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:653:89 [INFO] [stdout] | [INFO] [stdout] 653 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Entrance]], entrance_x as usize, entrance_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `entrance_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:653:110 [INFO] [stdout] | [INFO] [stdout] 653 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Entrance]], entrance_x as usize, entrance_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `entrance_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:658:85 [INFO] [stdout] | [INFO] [stdout] 658 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Exit]], exit_x as usize, exit_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `exit_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:658:102 [INFO] [stdout] | [INFO] [stdout] 658 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Exit]], exit_x as usize, exit_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `exit_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:670:17 [INFO] [stdout] | [INFO] [stdout] 670 | / match output[x][y].tile_data { [INFO] [stdout] 671 | | TileTextureData::Wall{..} => { [INFO] [stdout] 672 | | RoomGenerator::check_neighbors(&mut output, x, y); [INFO] [stdout] ... | [INFO] [stdout] 675 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 670 ~ if let TileTextureData::Wall{..} = output[x][y].tile_data { [INFO] [stdout] 671 + RoomGenerator::check_neighbors(&mut output, x, y); [INFO] [stdout] 672 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return false; [INFO] [stdout] 53 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TilePos` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 28 | let mut next_pos = tile_pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tile_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `passable` is never read [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:131:16 [INFO] [stdout] | [INFO] [stdout] 130 | pub struct TileData { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 131 | pub(crate) passable: bool [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture_handle` is never read [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct RelatedTextureData { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 136 | pub texture_handle: Handle, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RelatedTextureData` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Enemy` is never constructed [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct Enemy; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `health`, `strength`, `defense`, `level`, and `experience` are never read [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Lifeform { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub health: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | pub strength: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 15 | pub defense: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub level: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 17 | pub experience: u32 [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Direction` is never used [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:20:6 [INFO] [stdout] | [INFO] [stdout] 20 | enum Direction { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_lifeform` is never used [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn move_lifeform (direction: Direction, tile_pos: &mut TilePos, map_tile_storage: TileStorage, lifeform_tile_storage: TileStorage) -... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return match (self, old) { [INFO] [stdout] 41 | | (TileTextureData::Corridor{start},TileTextureData::Corridor{start: old_start}) => { [INFO] [stdout] 42 | | *start || !old_start [INFO] [stdout] ... | [INFO] [stdout] 54 | | (_,_) => {true} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ match (self, old) { [INFO] [stdout] 41 + (TileTextureData::Corridor{start},TileTextureData::Corridor{start: old_start}) => { [INFO] [stdout] 42 + *start || !old_start [INFO] [stdout] 43 + } [INFO] [stdout] 44 + (_,TileTextureData::Entrance) => {false} [INFO] [stdout] 45 + (_,TileTextureData::Exit) => {false} [INFO] [stdout] 46 + (TileTextureData::Corridor{..},_) => {true} [INFO] [stdout] 47 + (TileTextureData::Floor, TileTextureData::Corridor{..}) => {false} [INFO] [stdout] 48 + (TileTextureData::Wall{..}, TileTextureData::Corridor{..}) => {false} [INFO] [stdout] 49 + (TileTextureData::Wall{..}, TileTextureData::Floor) => {false} [INFO] [stdout] 50 + (TileTextureData::Enemy, TileTextureData::Player) => {false} [INFO] [stdout] 51 + (TileTextureData::Player, TileTextureData::Enemy) => {true} [INFO] [stdout] 52 + (TileTextureData::Enemy, _) => {panic!("Enemy replacing non-entity")} [INFO] [stdout] 53 + (TileTextureData::Player, _) => {panic!("Player replacing non-entity")} [INFO] [stdout] 54 + (_,_) => {true} [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return match self { [INFO] [stdout] 60 | | TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 | | TileTextureData::Floor => {true} [INFO] [stdout] 62 | | _ => {false} [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ match self { [INFO] [stdout] 60 + TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 + TileTextureData::Floor => {true} [INFO] [stdout] 62 + _ => {false} [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 60 | | TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 | | TileTextureData::Floor => {true} [INFO] [stdout] 62 | | _ => {false} [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 59 - return match self { [INFO] [stdout] 60 - TileTextureData::Corridor{..} => {true} [INFO] [stdout] 61 - TileTextureData::Floor => {true} [INFO] [stdout] 62 - _ => {false} [INFO] [stdout] 63 - } [INFO] [stdout] 59 + return matches!(self, TileTextureData::Corridor{..} | TileTextureData::Floor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / return match self { [INFO] [stdout] 68 | | TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 | | _ => {false} [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ match self { [INFO] [stdout] 68 + TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 + _ => {false} [INFO] [stdout] 70 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 68 | | TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 | | _ => {false} [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 67 - return match self { [INFO] [stdout] 68 - TileTextureData::Wall{..} => {true} [INFO] [stdout] 69 - _ => {false} [INFO] [stdout] 70 - } [INFO] [stdout] 67 + return matches!(self, TileTextureData::Wall{..}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / if !connects_north && !connects_south && !connects_east && !connects_west{ [INFO] [stdout] 77 | | TileTextureData::Wall { [INFO] [stdout] 78 | | connects_north: false, [INFO] [stdout] 79 | | connects_east: true, [INFO] [stdout] ... | [INFO] [stdout] 84 | | *self [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ TileTextureData::Wall {connects_north, connects_south, connects_east, connects_west} [INFO] [stdout] 76 ~ if !connects_north && !connects_south && !connects_east && !connects_west=> { [INFO] [stdout] 77 | TileTextureData::Wall { [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / return match self { [INFO] [stdout] 111 | | TileTextureData::None => {false} [INFO] [stdout] 112 | | TileTextureData::Floor => {true} [INFO] [stdout] 113 | | TileTextureData::Corridor { .. } => {true} [INFO] [stdout] ... | [INFO] [stdout] 118 | | TileTextureData::Exit => {true} [INFO] [stdout] 119 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ match self { [INFO] [stdout] 111 + TileTextureData::None => {false} [INFO] [stdout] 112 + TileTextureData::Floor => {true} [INFO] [stdout] 113 + TileTextureData::Corridor { .. } => {true} [INFO] [stdout] 114 + TileTextureData::Player => {false} [INFO] [stdout] 115 + TileTextureData::Enemy => {false} [INFO] [stdout] 116 + TileTextureData::Wall { .. } => {false} [INFO] [stdout] 117 + TileTextureData::Entrance => {true} [INFO] [stdout] 118 + TileTextureData::Exit => {true} [INFO] [stdout] 119 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/tile_data.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / return TileData { [INFO] [stdout] 124 | | passable: self.is_passable() [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 ~ TileData { [INFO] [stdout] 124 + passable: self.is_passable() [INFO] [stdout] 125 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] 60 + fn blit(output: &mut [Vec], input: Vec>, x: usize, y: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 132 | / let output = Rect { [INFO] [stdout] 133 | | x: close_x, [INFO] [stdout] 134 | | y: close_y, [INFO] [stdout] 135 | | width: far_x - close_x, [INFO] [stdout] 136 | | height: far_y - close_y [INFO] [stdout] 137 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 138 | output [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 132 ~ [INFO] [stdout] 133 ~ Rect { [INFO] [stdout] 134 + x: close_x, [INFO] [stdout] 135 + y: close_y, [INFO] [stdout] 136 + width: far_x - close_x, [INFO] [stdout] 137 + height: far_y - close_y [INFO] [stdout] 138 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:145:33 [INFO] [stdout] | [INFO] [stdout] 145 | rooms: vec![this_rect.clone(), that_rect.clone()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:145:52 [INFO] [stdout] | [INFO] [stdout] 145 | rooms: vec![this_rect.clone(), that_rect.clone()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `that_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:150:28 [INFO] [stdout] | [INFO] [stdout] 150 | rooms.push(rect.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | rooms.push(rect.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | return (state, order); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return (state, order); [INFO] [stdout] 214 + (state, order) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | return (intersection, order); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return (intersection, order); [INFO] [stdout] 297 + (intersection, order) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:270:102 [INFO] [stdout] | [INFO] [stdout] 270 | ...intersection(Room::Basic{rect: this_rect.clone()}, Room::Basic{rect: that_aabb}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `idx` is only used to index `that_rooms` [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:280:32 [INFO] [stdout] | [INFO] [stdout] 280 | for idx in 0..that_rooms.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 280 - for idx in 0..that_rooms.len() { [INFO] [stdout] 280 + for in &that_rooms { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:283:114 [INFO] [stdout] | [INFO] [stdout] 283 | ...intersection(Room::Basic{rect: this_rect.clone()}, Room::Basic{rect: that_room}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:356:70 [INFO] [stdout] | [INFO] [stdout] 356 | fn set_at(x: usize, y: usize, new_data: TileTextureData, output: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 356 - fn set_at(x: usize, y: usize, new_data: TileTextureData, output: &mut Vec>) { [INFO] [stdout] 356 + fn set_at(x: usize, y: usize, new_data: TileTextureData, output: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:447:29 [INFO] [stdout] | [INFO] [stdout] 447 | fn check_neighbor(data: &Vec>, x: usize, y: usize) -> (bool, bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 447 - fn check_neighbor(data: &Vec>, x: usize, y: usize) -> (bool, bool) { [INFO] [stdout] 447 + fn check_neighbor(data: &[Vec], x: usize, y: usize) -> (bool, bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:465:69 [INFO] [stdout] | [INFO] [stdout] 465 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x - 1, y - 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:469:87 [INFO] [stdout] | [INFO] [stdout] 469 | let (inner_connects_west, temp_make_wall) = RoomGenerator::check_neighbor(&data, x - 1, y); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:474:69 [INFO] [stdout] | [INFO] [stdout] 474 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x - 1, y + 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:478:88 [INFO] [stdout] | [INFO] [stdout] 478 | let (inner_connects_south, temp_make_wall) = RoomGenerator::check_neighbor(&data, x, y - 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:483:88 [INFO] [stdout] | [INFO] [stdout] 483 | let (inner_connects_north, temp_make_wall) = RoomGenerator::check_neighbor(&data, x, y + 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:488:69 [INFO] [stdout] | [INFO] [stdout] 488 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x + 1, y - 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:492:87 [INFO] [stdout] | [INFO] [stdout] 492 | let (inner_connects_east, temp_make_wall) = RoomGenerator::check_neighbor(&data, x + 1, y); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:497:69 [INFO] [stdout] | [INFO] [stdout] 497 | let (_, temp_make_wall) = RoomGenerator::check_neighbor(&data,x + 1, y + 1); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:509:13 [INFO] [stdout] | [INFO] [stdout] 509 | / match data[x][y].tile_data { [INFO] [stdout] 510 | | TileTextureData::Wall { .. } => { [INFO] [stdout] 511 | | data[x][y].tile_data = TileTextureData::None; [INFO] [stdout] ... | [INFO] [stdout] 514 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 509 ~ if let TileTextureData::Wall { .. } = data[x][y].tile_data { [INFO] [stdout] 510 + data[x][y].tile_data = TileTextureData::None; [INFO] [stdout] 511 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:519:21 [INFO] [stdout] | [INFO] [stdout] 519 | fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 519 - fn blit(output: &mut Vec>, input: Vec>, x: usize, y: usize) { [INFO] [stdout] 519 + fn blit(output: &mut [Vec], input: Vec>, x: usize, y: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:522:17 [INFO] [stdout] | [INFO] [stdout] 522 | / if input[input_x][input_y] != TileTextureData::None { [INFO] [stdout] 523 | | if input[input_x][input_y].can_replace(output[input_x + x][input_y + y].tile_data) { [INFO] [stdout] 524 | | output[input_x + x][input_y + y].tile_data = input[input_x][input_y]; [INFO] [stdout] 525 | | } [INFO] [stdout] 526 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 522 ~ if input[input_x][input_y] != TileTextureData::None [INFO] [stdout] 523 ~ && input[input_x][input_y].can_replace(output[input_x + x][input_y + y].tile_data) { [INFO] [stdout] 524 | output[input_x + x][input_y + y].tile_data = input[input_x][input_y]; [INFO] [stdout] 525 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx_removed` is used as a loop counter [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:608:13 [INFO] [stdout] | [INFO] [stdout] 608 | for idx_to_remove in remove_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx_removed, idx_to_remove) in remove_idx.into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:653:89 [INFO] [stdout] | [INFO] [stdout] 653 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Entrance]], entrance_x as usize, entrance_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `entrance_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:653:110 [INFO] [stdout] | [INFO] [stdout] 653 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Entrance]], entrance_x as usize, entrance_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `entrance_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:658:85 [INFO] [stdout] | [INFO] [stdout] 658 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Exit]], exit_x as usize, exit_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `exit_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:658:102 [INFO] [stdout] | [INFO] [stdout] 658 | RoomGenerator::blit(&mut output, vec![vec![TileTextureData::Exit]], exit_x as usize, exit_y as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `exit_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> samurai_warriors_derusted/src/worldgen.rs:670:17 [INFO] [stdout] | [INFO] [stdout] 670 | / match output[x][y].tile_data { [INFO] [stdout] 671 | | TileTextureData::Wall{..} => { [INFO] [stdout] 672 | | RoomGenerator::check_neighbors(&mut output, x, y); [INFO] [stdout] ... | [INFO] [stdout] 675 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 670 ~ if let TileTextureData::Wall{..} = output[x][y].tile_data { [INFO] [stdout] 671 + RoomGenerator::check_neighbors(&mut output, x, y); [INFO] [stdout] 672 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return false; [INFO] [stdout] 53 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TilePos` which implements the `Copy` trait [INFO] [stdout] --> samurai_warriors_derusted/src/lifeform.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 28 | let mut next_pos = tile_pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tile_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 3m 42s [INFO] running `Command { std: "docker" "inspect" "29231bdbac238429e9554d6dddea3b3f3de7067e695b2f2d52ee8f1f66fa2215", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29231bdbac238429e9554d6dddea3b3f3de7067e695b2f2d52ee8f1f66fa2215", kill_on_drop: false }` [INFO] [stdout] 29231bdbac238429e9554d6dddea3b3f3de7067e695b2f2d52ee8f1f66fa2215