[INFO] cloning repository https://github.com/evilja/neo-crystal-plus [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/evilja/neo-crystal-plus" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fevilja%2Fneo-crystal-plus", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fevilja%2Fneo-crystal-plus'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 05c4f3db5e0a70b154f35bc1e14a5431431a0cfc [INFO] linting evilja/neo-crystal-plus against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fevilja%2Fneo-crystal-plus" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/evilja/neo-crystal-plus [INFO] finished tweaking git repo https://github.com/evilja/neo-crystal-plus [INFO] tweaked toml for git repo https://github.com/evilja/neo-crystal-plus written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/evilja/neo-crystal-plus on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/evilja/neo-crystal-plus already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symphonia-utils-xiph v0.5.5 [INFO] [stderr] Downloaded symphonia-format-mkv v0.5.5 [INFO] [stderr] Downloaded symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Downloaded symphonia-format-riff v0.5.5 [INFO] [stderr] Downloaded quork-proc v0.5.0 [INFO] [stderr] Downloaded mp4ameta_proc v0.6.0 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Downloaded symphonia-bundle-flac v0.5.5 [INFO] [stderr] Downloaded pancurses v0.17.0 [INFO] [stderr] Downloaded readme-rustdocifier v0.1.1 [INFO] [stderr] Downloaded symphonia-codec-aac v0.5.5 [INFO] [stderr] Downloaded metaflac v0.2.8 [INFO] [stderr] Downloaded audiotags-macro v0.2.0 [INFO] [stderr] Downloaded quork v0.9.1 [INFO] [stderr] Downloaded id3 v1.16.4 [INFO] [stderr] Downloaded alsa v0.10.0 [INFO] [stderr] Downloaded symphonia-codec-adpcm v0.5.5 [INFO] [stderr] Downloaded mach2 v0.5.0 [INFO] [stderr] Downloaded symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Downloaded symphonia-codec-pcm v0.5.5 [INFO] [stderr] Downloaded symphonia-core v0.5.5 [INFO] [stderr] Downloaded winreg v0.5.1 [INFO] [stderr] Downloaded objc2-avf-audio v0.3.2 [INFO] [stderr] Downloaded objc2-core-audio-types v0.3.2 [INFO] [stderr] Downloaded symphonia-format-ogg v0.5.5 [INFO] [stderr] Downloaded discord-presence v3.0.0 [INFO] [stderr] Downloaded audiotags v0.5.0 [INFO] [stderr] Downloaded pdcurses-sys v0.7.1 [INFO] [stderr] Downloaded objc2-core-audio v0.3.2 [INFO] [stderr] Downloaded objc2-audio-toolbox v0.3.2 [INFO] [stderr] Downloaded mp4ameta v0.11.0 [INFO] [stderr] Downloaded cpal v0.17.1 [INFO] [stderr] Downloaded symphonia-metadata v0.5.5 [INFO] [stderr] Downloaded ringbuf v0.4.8 [INFO] [stderr] Downloaded symphonia v0.5.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86de5d7fbbc2ade92f88902366af49adeacee6e8ba617e356e6ee288eb77b62b [INFO] running `Command { std: "docker" "start" "-a" "86de5d7fbbc2ade92f88902366af49adeacee6e8ba617e356e6ee288eb77b62b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86de5d7fbbc2ade92f88902366af49adeacee6e8ba617e356e6ee288eb77b62b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86de5d7fbbc2ade92f88902366af49adeacee6e8ba617e356e6ee288eb77b62b", kill_on_drop: false }` [INFO] [stdout] 86de5d7fbbc2ade92f88902366af49adeacee6e8ba617e356e6ee288eb77b62b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9eca63bd8b8a448709887712415fc20c779ae6bed86376736c577293a556324 [INFO] running `Command { std: "docker" "start" "-a" "c9eca63bd8b8a448709887712415fc20c779ae6bed86376736c577293a556324", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking symphonia-core v0.5.5 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking endi v1.1.1 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Compiling cpal v0.16.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Compiling cpal v0.17.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling mp4ameta_proc v0.6.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking id3 v1.16.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking metaflac v0.2.8 [INFO] [stderr] Checking mp4ameta v0.11.0 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking symphonia-metadata v0.5.5 [INFO] [stderr] Checking symphonia-codec-aac v0.5.5 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.5 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.5 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking audiotags-macro v0.2.0 [INFO] [stderr] Checking ringbuf v0.4.8 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.5 [INFO] [stderr] Checking symphonia-format-riff v0.5.5 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Checking symphonia-format-ogg v0.5.5 [INFO] [stderr] Checking symphonia-format-mkv v0.5.5 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.5 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling toml_edit v0.23.9 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking alsa v0.10.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking pancurses v0.17.0 [INFO] [stderr] Checking symphonia v0.5.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking rodio v0.21.1 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling quork-proc v0.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking audiotags v0.5.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking quork v0.9.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking discord-presence v3.0.0 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking neocrystal v1.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/presence.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | sender: sender [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/tui_ir.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | color: color, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/tui_ir.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 150 | color: color, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/tui_ir.rs:160:13 [INFO] [stdout] | [INFO] [stdout] 160 | color: color, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/modules/tui_ir.rs:247:32 [INFO] [stdout] | [INFO] [stdout] 247 | .unwrap_or(&[b' ']) [INFO] [stdout] | ^^^^^^^ help: try: `b" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/presence.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | sender: sender [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/tui_ir.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | color: color, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/tui_ir.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 150 | color: color, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/modules/tui_ir.rs:160:13 [INFO] [stdout] | [INFO] [stdout] 160 | color: color, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/modules/tui_ir.rs:247:32 [INFO] [stdout] | [INFO] [stdout] 247 | .unwrap_or(&[b' ']) [INFO] [stdout] | ^^^^^^^ help: try: `b" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Magic` is never used [INFO] [stdout] --> src/modules/crystal_manager.rs:86:10 [INFO] [stdout] | [INFO] [stdout] 86 | pub enum Magic { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Event` is never used [INFO] [stdout] --> src/modules/crystal_manager.rs:115:10 [INFO] [stdout] | [INFO] [stdout] 115 | pub enum Event { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PlaylistPage` is never constructed [INFO] [stdout] --> src/modules/curses.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub enum Ownership { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 26 | Songs, [INFO] [stdout] 27 | PlaylistPage, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ownership` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `switch_alloc` is never used [INFO] [stdout] --> src/modules/curses.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn switch_alloc(general: &mut GeneralState) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `realloc` is never used [INFO] [stdout] --> src/modules/curses.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn realloc(general: &mut GeneralState) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/modules/audio.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | if let Some(ext) = path.split('.').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - if let Some(ext) = path.split('.').last() { [INFO] [stdout] 19 + if let Some(ext) = path.split('.').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/modules/audio.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/audio.rs:57:49 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] 57 + pub fn act(&mut self) -> bool { if self.r { false } else { self.r = true; return true } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/audio.rs:57:86 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] 57 + pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; true } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/audio.rs:66:41 [INFO] [stdout] | [INFO] [stdout] 66 | let sink = rodio::Sink::connect_new(&stream_handle.mixer()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `stream_handle.mixer()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/modules/audio.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | / match sink.try_seek(sink.get_pos() + Duration::from_secs(5)) { [INFO] [stdout] 114 | | _ => (), [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 113 ~ sink.try_seek(sink.get_pos() + Duration::from_secs(5)); [INFO] [stdout] 114 + () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/modules/audio.rs:119:34 [INFO] [stdout] | [INFO] [stdout] 119 | if cached == "uinit".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"uinit"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/modules/audio.rs:129:25 [INFO] [stdout] | [INFO] [stdout] 129 | (); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/modules/audio.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 137 | if cached == "uinit".to_string() || sink.is_paused() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"uinit"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/modules/crystal_manager.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | NULL = 1000, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/modules/crystal_manager.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | / if let Ok(mevent) = pancurses::getmouse() { [INFO] [stdout] 231 | | if let Some(action) = mouse::handle_mouse(mevent, &general) { [INFO] [stdout] 232 | | general.action = action; [INFO] [stdout] 233 | | } [INFO] [stdout] 234 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 230 ~ if let Ok(mevent) = pancurses::getmouse() [INFO] [stdout] 231 ~ && let Some(action) = mouse::handle_mouse(mevent, &general) { [INFO] [stdout] 232 | general.action = action; [INFO] [stdout] 233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/modules/crystal_manager.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | / if general.action != Action::Nothing { [INFO] [stdout] 237 | | if let Some(nk) = mouse::action_to_key(general.action, &mut general) { [INFO] [stdout] 238 | | key = nk; [INFO] [stdout] 239 | | } [INFO] [stdout] 240 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 236 ~ if general.action != Action::Nothing [INFO] [stdout] 237 ~ && let Some(nk) = mouse::action_to_key(general.action, &mut general) { [INFO] [stdout] 238 | key = nk; [INFO] [stdout] 239 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/modules/crystal_manager.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 247 | / match general.songs.set_by_next() { [INFO] [stdout] 248 | | Ok(_) => (), [INFO] [stdout] 249 | | Err(_) => (), [INFO] [stdout] 250 | | } [INFO] [stdout] | |_________________________^ help: try: `if let Ok(_) = general.songs.set_by_next() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/modules/crystal_manager.rs:271:25 [INFO] [stdout] | [INFO] [stdout] 271 | / match general.songs.prev() { [INFO] [stdout] 272 | | Ok(_) => (), [INFO] [stdout] 273 | | Err(_) => (), [INFO] [stdout] 274 | | } [INFO] [stdout] | |_________________________^ help: try: `if let Ok(_) = general.songs.prev() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/modules/crystal_manager.rs:296:25 [INFO] [stdout] | [INFO] [stdout] 296 | / match general.songs.set_by_next() { [INFO] [stdout] 297 | | Ok(_) => (), [INFO] [stdout] 298 | | Err(_) => (), [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________________________^ help: try: `if let Ok(_) = general.songs.set_by_next() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/modules/crystal_manager.rs:463:5 [INFO] [stdout] | [INFO] [stdout] 463 | / match rpc_comm.send_message(RpcCommand::Stop) { [INFO] [stdout] 464 | | _ => (), [INFO] [stdout] 465 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 463 ~ rpc_comm.send_message(RpcCommand::Stop); [INFO] [stdout] 464 + (); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/crystal_manager.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - return true; [INFO] [stdout] 488 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/crystal_manager.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 490 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 490 - return false; [INFO] [stdout] 490 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/modules/crystal_manager.rs:502:20 [INFO] [stdout] | [INFO] [stdout] 502 | let max_page = (total + psize - 1) / psize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `total.div_ceil(psize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/modules/crystal_manager.rs:543:9 [INFO] [stdout] | [INFO] [stdout] 543 | / tx.send(AudioCommand::SetVolume(general.volume.as_f32())) [INFO] [stdout] 544 | | .unwrap_or_else(|_| ()); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 544 - .unwrap_or_else(|_| ()); [INFO] [stdout] 544 + .unwrap_or(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/modules/curses.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | let max_page = (total + psize - 1) / psize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `total.div_ceil(psize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'life [INFO] [stdout] --> src/modules/curses.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | fn get_name<'life>(&self, general: &'life mut GeneralState, idx: usize) -> String { [INFO] [stdout] | ^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 146 - fn get_name<'life>(&self, general: &'life mut GeneralState, idx: usize) -> String { [INFO] [stdout] 146 + fn get_name(&self, general: &mut GeneralState, idx: usize) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `abs` is only used to index `g` [INFO] [stdout] --> src/modules/curses.rs:184:20 [INFO] [stdout] | [INFO] [stdout] 184 | for abs in start..end { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 184 - for abs in start..end { [INFO] [stdout] 184 + for in g.iter().take(end).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `abs` is used to index `g` [INFO] [stdout] --> src/modules/curses.rs:235:20 [INFO] [stdout] | [INFO] [stdout] 235 | for abs in start..(start + psize).min(total) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 235 - for abs in start..(start + psize).min(total) { [INFO] [stdout] 235 + for (abs, ) in g.iter().enumerate().take((start + psize).min(total)).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row` is used as a loop counter [INFO] [stdout] --> src/modules/curses.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 235 | for abs in start..(start + psize).min(total) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row, abs) in (start..(start + psize).min(total)).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/modules/curses.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | if general.songs.shuffle { "yes" } else { "no" }.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `if general.songs.shuffle { "yes" } else { "no" }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/modules/curses.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | if general.state.isloop { "yes" } else { "no" }.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `if general.state.isloop { "yes" } else { "no" }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/modules/curses.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | / match general.rpc.mode { [INFO] [stdout] 331 | | ReinitMode::Init => "int", [INFO] [stdout] 332 | | ReinitMode::Renew | ReinitMode::Pretend => "rnw", [INFO] [stdout] 333 | | ReinitMode::None => "yes", [INFO] [stdout] 334 | | } [INFO] [stdout] 335 | | .into(), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 330 ~ match general.rpc.mode { [INFO] [stdout] 331 + ReinitMode::Init => "int", [INFO] [stdout] 332 + ReinitMode::Renew | ReinitMode::Pretend => "rnw", [INFO] [stdout] 333 + ReinitMode::None => "yes", [INFO] [stdout] 334 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/modules/curses.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 398 | / ( [INFO] [stdout] 399 | | pancurses::curs_set(0), [INFO] [stdout] 400 | | window.keypad(true), [INFO] [stdout] 401 | | pancurses::noecho(), [INFO] [stdout] 402 | | window.nodelay(true), [INFO] [stdout] 403 | | mousemask(0x2 as u32, None), [INFO] [stdout] 404 | | ); [INFO] [stdout] | |______^ help: statement can be reduced to: `pancurses::curs_set(0); window.keypad(true); pancurses::noecho(); window.nodelay(true); mousemask(0x2 as u32, None);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/modules/curses.rs:403:19 [INFO] [stdout] | [INFO] [stdout] 403 | mousemask(0x2 as u32, None), [INFO] [stdout] | ^^^^^^^^^^ help: try: `0x2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/modules/curses.rs:406:5 [INFO] [stdout] | [INFO] [stdout] 406 | / ( [INFO] [stdout] 407 | | pancurses::start_color(), [INFO] [stdout] 408 | | pancurses::init_pair(0, pancurses::COLOR_WHITE, pancurses::COLOR_BLACK), [INFO] [stdout] 409 | | pancurses::init_pair(1, pancurses::COLOR_GREEN, pancurses::COLOR_BLACK), [INFO] [stdout] ... | [INFO] [stdout] 413 | | pancurses::init_pair(9, pancurses::COLOR_CYAN, pancurses::COLOR_BLACK), [INFO] [stdout] 414 | | ); [INFO] [stdout] | |______^ help: statement can be reduced to: `pancurses::start_color(); pancurses::init_pair(0, pancurses::COLOR_WHITE, pancurses::COLOR_BLACK); pancurses::init_pair(1, pancurses::COLOR_GREEN, pancurses::COLOR_BLACK); pancurses::init_pair(2, pancurses::COLOR_RED, pancurses::COLOR_BLACK); pancurses::init_pair(3, pancurses::COLOR_BLACK, pancurses::COLOR_WHITE); pancurses::init_pair(4, pancurses::COLOR_YELLOW, pancurses::COLOR_BLACK); pancurses::init_pair(9, pancurses::COLOR_CYAN, pancurses::COLOR_BLACK);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/modules/songs.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 146 | if something == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `something.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/songs.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return 0; [INFO] [stdout] 162 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/songs.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return 2; [INFO] [stdout] 164 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/modules/songs.rs:204:68 [INFO] [stdout] | [INFO] [stdout] 204 | pub fn set_artist(&mut self, index_in_filtered: usize, artist: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 204 ~ pub fn set_artist(&mut self, index_in_filtered: usize, artist: &str) { [INFO] [stdout] 205 | if self.stophandler || index_in_filtered >= self.filtered_songs.len() { [INFO] [stdout] ... [INFO] [stdout] 209 | if change_artist(&self.all_songs[idx].path, artist).is_ok() { [INFO] [stdout] 210 ~ self.all_songs[idx].artist = artist.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/modules/utils.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | self.steps as f32 / 100 as f32 [INFO] [stdout] | ^^^^^^^^^^ help: try: `100_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/modules/utils.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 35 | let artist = t.artists().unwrap_or(vec!["Unknown"]).join(", "); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | artist [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ t.artists().unwrap_or(vec!["Unknown"]).join(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/utils.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | !(self.grapheme_width <= self.width) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.grapheme_width > self.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/modules/utils.rs:149:20 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn to_mode(&mut self, mode: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SIM` contains a capitalized acronym [INFO] [stdout] --> src/modules/tui_ir.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | SIM(usize), // Single Instruction Multiple Operations [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sim` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/tui_ir.rs:143:37 [INFO] [stdout] | [INFO] [stdout] 143 | self.blob.extend_from_slice(&into); [INFO] [stdout] | ^^^^^ help: change this to: `into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/tui_ir.rs:153:37 [INFO] [stdout] | [INFO] [stdout] 153 | self.blob.extend_from_slice(&into); [INFO] [stdout] | ^^^^^ help: change this to: `into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/tui_ir.rs:164:41 [INFO] [stdout] | [INFO] [stdout] 164 | self.blob.extend_from_slice(&into); [INFO] [stdout] | ^^^^^ help: change this to: `into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/tui_ir.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | return Some(a.range_x.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return Some(a.range_x.1); [INFO] [stdout] 193 + Some(a.range_x.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/tui_ir.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return None; [INFO] [stdout] 195 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/modules/tui_ir.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 283 | if cw > 0 { [INFO] [stdout] | ^^^^^^ check performed here [INFO] [stdout] 284 | if x == rx.0 { [INFO] [stdout] 285 | let reps = rx.1.saturating_sub(w) / cw; [INFO] [stdout] | --------------------------- division performed here [INFO] [stdout] ... [INFO] [stdout] 290 | let reps = rx.1 / cw; [INFO] [stdout] | --------- ... and here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:297:12 [INFO] [stdout] | [INFO] [stdout] 297 | if b.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/modules/tui_ir.rs:327:12 [INFO] [stdout] | [INFO] [stdout] 327 | if cw > 0 { [INFO] [stdout] | ^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 330 | let reps = cols / cw; [INFO] [stdout] | --------- division performed here [INFO] [stdout] ... [INFO] [stdout] 335 | let reps = rx.1 / cw; [INFO] [stdout] | --------- ... and here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/modules/tui_ir.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | if cw > 0 { [INFO] [stdout] | ^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 378 | let reps = cols / cw; [INFO] [stdout] | --------- division performed here [INFO] [stdout] ... [INFO] [stdout] 383 | let reps = rx.1 / cw; [INFO] [stdout] | --------- ... and here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:402:12 [INFO] [stdout] | [INFO] [stdout] 402 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:410:12 [INFO] [stdout] | [INFO] [stdout] 410 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Magic` is never used [INFO] [stdout] --> src/modules/crystal_manager.rs:86:10 [INFO] [stdout] | [INFO] [stdout] 86 | pub enum Magic { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Event` is never used [INFO] [stdout] --> src/modules/crystal_manager.rs:115:10 [INFO] [stdout] | [INFO] [stdout] 115 | pub enum Event { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:417:12 [INFO] [stdout] | [INFO] [stdout] 417 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PlaylistPage` is never constructed [INFO] [stdout] --> src/modules/curses.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub enum Ownership { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 26 | Songs, [INFO] [stdout] 27 | PlaylistPage, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ownership` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `switch_alloc` is never used [INFO] [stdout] --> src/modules/curses.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn switch_alloc(general: &mut GeneralState) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `realloc` is never used [INFO] [stdout] --> src/modules/curses.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn realloc(general: &mut GeneralState) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:424:12 [INFO] [stdout] | [INFO] [stdout] 424 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/modules/audio.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | if let Some(ext) = path.split('.').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - if let Some(ext) = path.split('.').last() { [INFO] [stdout] 19 + if let Some(ext) = path.split('.').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/modules/audio.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/audio.rs:57:49 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] 57 + pub fn act(&mut self) -> bool { if self.r { false } else { self.r = true; return true } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/audio.rs:57:86 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; return true } } [INFO] [stdout] 57 + pub fn act(&mut self) -> bool { if self.r { return false } else { self.r = true; true } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/audio.rs:66:41 [INFO] [stdout] | [INFO] [stdout] 66 | let sink = rodio::Sink::connect_new(&stream_handle.mixer()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `stream_handle.mixer()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/modules/audio.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | / match sink.try_seek(sink.get_pos() + Duration::from_secs(5)) { [INFO] [stdout] 114 | | _ => (), [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 113 ~ sink.try_seek(sink.get_pos() + Duration::from_secs(5)); [INFO] [stdout] 114 + () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/modules/audio.rs:119:34 [INFO] [stdout] | [INFO] [stdout] 119 | if cached == "uinit".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"uinit"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/modules/audio.rs:129:25 [INFO] [stdout] | [INFO] [stdout] 129 | (); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/modules/audio.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 137 | if cached == "uinit".to_string() || sink.is_paused() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"uinit"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/modules/crystal_manager.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | NULL = 1000, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/modules/crystal_manager.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | / if let Ok(mevent) = pancurses::getmouse() { [INFO] [stdout] 231 | | if let Some(action) = mouse::handle_mouse(mevent, &general) { [INFO] [stdout] 232 | | general.action = action; [INFO] [stdout] 233 | | } [INFO] [stdout] 234 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 230 ~ if let Ok(mevent) = pancurses::getmouse() [INFO] [stdout] 231 ~ && let Some(action) = mouse::handle_mouse(mevent, &general) { [INFO] [stdout] 232 | general.action = action; [INFO] [stdout] 233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/modules/crystal_manager.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | / if general.action != Action::Nothing { [INFO] [stdout] 237 | | if let Some(nk) = mouse::action_to_key(general.action, &mut general) { [INFO] [stdout] 238 | | key = nk; [INFO] [stdout] 239 | | } [INFO] [stdout] 240 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 236 ~ if general.action != Action::Nothing [INFO] [stdout] 237 ~ && let Some(nk) = mouse::action_to_key(general.action, &mut general) { [INFO] [stdout] 238 | key = nk; [INFO] [stdout] 239 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/modules/crystal_manager.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 247 | / match general.songs.set_by_next() { [INFO] [stdout] 248 | | Ok(_) => (), [INFO] [stdout] 249 | | Err(_) => (), [INFO] [stdout] 250 | | } [INFO] [stdout] | |_________________________^ help: try: `if let Ok(_) = general.songs.set_by_next() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/modules/crystal_manager.rs:271:25 [INFO] [stdout] | [INFO] [stdout] 271 | / match general.songs.prev() { [INFO] [stdout] 272 | | Ok(_) => (), [INFO] [stdout] 273 | | Err(_) => (), [INFO] [stdout] 274 | | } [INFO] [stdout] | |_________________________^ help: try: `if let Ok(_) = general.songs.prev() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/modules/crystal_manager.rs:296:25 [INFO] [stdout] | [INFO] [stdout] 296 | / match general.songs.set_by_next() { [INFO] [stdout] 297 | | Ok(_) => (), [INFO] [stdout] 298 | | Err(_) => (), [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________________________^ help: try: `if let Ok(_) = general.songs.set_by_next() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/modules/crystal_manager.rs:463:5 [INFO] [stdout] | [INFO] [stdout] 463 | / match rpc_comm.send_message(RpcCommand::Stop) { [INFO] [stdout] 464 | | _ => (), [INFO] [stdout] 465 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 463 ~ rpc_comm.send_message(RpcCommand::Stop); [INFO] [stdout] 464 + (); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/crystal_manager.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - return true; [INFO] [stdout] 488 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/crystal_manager.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 490 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 490 - return false; [INFO] [stdout] 490 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/modules/crystal_manager.rs:502:20 [INFO] [stdout] | [INFO] [stdout] 502 | let max_page = (total + psize - 1) / psize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `total.div_ceil(psize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/modules/crystal_manager.rs:543:9 [INFO] [stdout] | [INFO] [stdout] 543 | / tx.send(AudioCommand::SetVolume(general.volume.as_f32())) [INFO] [stdout] 544 | | .unwrap_or_else(|_| ()); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 544 - .unwrap_or_else(|_| ()); [INFO] [stdout] 544 + .unwrap_or(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/modules/curses.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | let max_page = (total + psize - 1) / psize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `total.div_ceil(psize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | thread::spawn(move || match play_audio(rx, tx_proc) { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 16 | | Ok(_) => (), [INFO] [stdout] 17 | | Err(_) => (), [INFO] [stdout] 18 | | }); [INFO] [stdout] | |_____^ help: try: `if let Ok(_) = play_audio(rx, tx_proc) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'life [INFO] [stdout] --> src/modules/curses.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | fn get_name<'life>(&self, general: &'life mut GeneralState, idx: usize) -> String { [INFO] [stdout] | ^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 146 - fn get_name<'life>(&self, general: &'life mut GeneralState, idx: usize) -> String { [INFO] [stdout] 146 + fn get_name(&self, general: &mut GeneralState, idx: usize) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `abs` is only used to index `g` [INFO] [stdout] --> src/modules/curses.rs:184:20 [INFO] [stdout] | [INFO] [stdout] 184 | for abs in start..end { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 184 - for abs in start..end { [INFO] [stdout] 184 + for in g.iter().take(end).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `abs` is used to index `g` [INFO] [stdout] --> src/modules/curses.rs:235:20 [INFO] [stdout] | [INFO] [stdout] 235 | for abs in start..(start + psize).min(total) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 235 - for abs in start..(start + psize).min(total) { [INFO] [stdout] 235 + for (abs, ) in g.iter().enumerate().take((start + psize).min(total)).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row` is used as a loop counter [INFO] [stdout] --> src/modules/curses.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 235 | for abs in start..(start + psize).min(total) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row, abs) in (start..(start + psize).min(total)).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/modules/curses.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | if general.songs.shuffle { "yes" } else { "no" }.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `if general.songs.shuffle { "yes" } else { "no" }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/modules/curses.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | if general.state.isloop { "yes" } else { "no" }.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `if general.state.isloop { "yes" } else { "no" }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/modules/curses.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | / match general.rpc.mode { [INFO] [stdout] 331 | | ReinitMode::Init => "int", [INFO] [stdout] 332 | | ReinitMode::Renew | ReinitMode::Pretend => "rnw", [INFO] [stdout] 333 | | ReinitMode::None => "yes", [INFO] [stdout] 334 | | } [INFO] [stdout] 335 | | .into(), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 330 ~ match general.rpc.mode { [INFO] [stdout] 331 + ReinitMode::Init => "int", [INFO] [stdout] 332 + ReinitMode::Renew | ReinitMode::Pretend => "rnw", [INFO] [stdout] 333 + ReinitMode::None => "yes", [INFO] [stdout] 334 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/modules/curses.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 398 | / ( [INFO] [stdout] 399 | | pancurses::curs_set(0), [INFO] [stdout] 400 | | window.keypad(true), [INFO] [stdout] 401 | | pancurses::noecho(), [INFO] [stdout] 402 | | window.nodelay(true), [INFO] [stdout] 403 | | mousemask(0x2 as u32, None), [INFO] [stdout] 404 | | ); [INFO] [stdout] | |______^ help: statement can be reduced to: `pancurses::curs_set(0); window.keypad(true); pancurses::noecho(); window.nodelay(true); mousemask(0x2 as u32, None);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/modules/curses.rs:403:19 [INFO] [stdout] | [INFO] [stdout] 403 | mousemask(0x2 as u32, None), [INFO] [stdout] | ^^^^^^^^^^ help: try: `0x2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/modules/curses.rs:406:5 [INFO] [stdout] | [INFO] [stdout] 406 | / ( [INFO] [stdout] 407 | | pancurses::start_color(), [INFO] [stdout] 408 | | pancurses::init_pair(0, pancurses::COLOR_WHITE, pancurses::COLOR_BLACK), [INFO] [stdout] 409 | | pancurses::init_pair(1, pancurses::COLOR_GREEN, pancurses::COLOR_BLACK), [INFO] [stdout] ... | [INFO] [stdout] 413 | | pancurses::init_pair(9, pancurses::COLOR_CYAN, pancurses::COLOR_BLACK), [INFO] [stdout] 414 | | ); [INFO] [stdout] | |______^ help: statement can be reduced to: `pancurses::start_color(); pancurses::init_pair(0, pancurses::COLOR_WHITE, pancurses::COLOR_BLACK); pancurses::init_pair(1, pancurses::COLOR_GREEN, pancurses::COLOR_BLACK); pancurses::init_pair(2, pancurses::COLOR_RED, pancurses::COLOR_BLACK); pancurses::init_pair(3, pancurses::COLOR_BLACK, pancurses::COLOR_WHITE); pancurses::init_pair(4, pancurses::COLOR_YELLOW, pancurses::COLOR_BLACK); pancurses::init_pair(9, pancurses::COLOR_CYAN, pancurses::COLOR_BLACK);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/modules/songs.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 146 | if something == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `something.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/songs.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return 0; [INFO] [stdout] 162 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/songs.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return 2; [INFO] [stdout] 164 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/modules/songs.rs:204:68 [INFO] [stdout] | [INFO] [stdout] 204 | pub fn set_artist(&mut self, index_in_filtered: usize, artist: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 204 ~ pub fn set_artist(&mut self, index_in_filtered: usize, artist: &str) { [INFO] [stdout] 205 | if self.stophandler || index_in_filtered >= self.filtered_songs.len() { [INFO] [stdout] ... [INFO] [stdout] 209 | if change_artist(&self.all_songs[idx].path, artist).is_ok() { [INFO] [stdout] 210 ~ self.all_songs[idx].artist = artist.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/modules/utils.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | self.steps as f32 / 100 as f32 [INFO] [stdout] | ^^^^^^^^^^ help: try: `100_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/modules/utils.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 35 | let artist = t.artists().unwrap_or(vec!["Unknown"]).join(", "); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | artist [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ t.artists().unwrap_or(vec!["Unknown"]).join(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/utils.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | !(self.grapheme_width <= self.width) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.grapheme_width > self.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/modules/utils.rs:149:20 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn to_mode(&mut self, mode: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SIM` contains a capitalized acronym [INFO] [stdout] --> src/modules/tui_ir.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | SIM(usize), // Single Instruction Multiple Operations [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sim` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/tui_ir.rs:143:37 [INFO] [stdout] | [INFO] [stdout] 143 | self.blob.extend_from_slice(&into); [INFO] [stdout] | ^^^^^ help: change this to: `into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/tui_ir.rs:153:37 [INFO] [stdout] | [INFO] [stdout] 153 | self.blob.extend_from_slice(&into); [INFO] [stdout] | ^^^^^ help: change this to: `into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/tui_ir.rs:164:41 [INFO] [stdout] | [INFO] [stdout] 164 | self.blob.extend_from_slice(&into); [INFO] [stdout] | ^^^^^ help: change this to: `into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/tui_ir.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | return Some(a.range_x.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return Some(a.range_x.1); [INFO] [stdout] 193 + Some(a.range_x.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modules/tui_ir.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return None; [INFO] [stdout] 195 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/modules/tui_ir.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 283 | if cw > 0 { [INFO] [stdout] | ^^^^^^ check performed here [INFO] [stdout] 284 | if x == rx.0 { [INFO] [stdout] 285 | let reps = rx.1.saturating_sub(w) / cw; [INFO] [stdout] | --------------------------- division performed here [INFO] [stdout] ... [INFO] [stdout] 290 | let reps = rx.1 / cw; [INFO] [stdout] | --------- ... and here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:297:12 [INFO] [stdout] | [INFO] [stdout] 297 | if b.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/modules/tui_ir.rs:327:12 [INFO] [stdout] | [INFO] [stdout] 327 | if cw > 0 { [INFO] [stdout] | ^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 330 | let reps = cols / cw; [INFO] [stdout] | --------- division performed here [INFO] [stdout] ... [INFO] [stdout] 335 | let reps = rx.1 / cw; [INFO] [stdout] | --------- ... and here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/modules/tui_ir.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | if cw > 0 { [INFO] [stdout] | ^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 378 | let reps = cols / cw; [INFO] [stdout] | --------- division performed here [INFO] [stdout] ... [INFO] [stdout] 383 | let reps = rx.1 / cw; [INFO] [stdout] | --------- ... and here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:402:12 [INFO] [stdout] | [INFO] [stdout] 402 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:410:12 [INFO] [stdout] | [INFO] [stdout] 410 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:417:12 [INFO] [stdout] | [INFO] [stdout] 417 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/tui_ir.rs:424:12 [INFO] [stdout] | [INFO] [stdout] 424 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | thread::spawn(move || match play_audio(rx, tx_proc) { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 16 | | Ok(_) => (), [INFO] [stdout] 17 | | Err(_) => (), [INFO] [stdout] 18 | | }); [INFO] [stdout] | |_____^ help: try: `if let Ok(_) = play_audio(rx, tx_proc) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.96s [INFO] running `Command { std: "docker" "inspect" "c9eca63bd8b8a448709887712415fc20c779ae6bed86376736c577293a556324", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9eca63bd8b8a448709887712415fc20c779ae6bed86376736c577293a556324", kill_on_drop: false }` [INFO] [stdout] c9eca63bd8b8a448709887712415fc20c779ae6bed86376736c577293a556324